From patchwork Mon Sep 23 19:49:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tom Psyborg X-Patchwork-Id: 11157529 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE2FC13BD for ; Mon, 23 Sep 2019 19:49:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B4BF20665 for ; Mon, 23 Sep 2019 19:49:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tTAizgBO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Je1LjaS7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B4BF20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qfd2RZt6ZOCSlhkkPe+/4oGLFSZp+rm9FOhvgDy00C0=; b=tTAizgBO944x1U WIsWokDV/O1JoMsbjtcnfcma7BcxaozmBKiPaYmHJHKSEeKvPXsmgFR74EZTaq67pykPA1+FUOA/o vZUPSLfYlx6k9AZB4nKQ4PkpdbcPGu+HA/RKhENumbFPuLhGogmq5nmkuXffBC2lYs7HgphoFD0Zk sSLaL9apVhEV44ixkhzBjkZdrQTVWHr0EYsHaeJN6Rb423xvUqf2gwuaThtCZMkRABg6NWY6ap1xu YR4DMVoZnKO57xhNA+KQQKfDQk1QKasxmLmpCJOuR+/29u9Wi7V9Gr/skc1fAyghSjg4f5BhEh/Yp mmDKJq8/I5IkyHSrO/XQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCUL5-0004Pe-Ve; Mon, 23 Sep 2019 19:49:39 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCUL2-0004OP-Ec for ath10k@lists.infradead.org; Mon, 23 Sep 2019 19:49:39 +0000 Received: by mail-wm1-x343.google.com with SMTP id y21so10592130wmi.0 for ; Mon, 23 Sep 2019 12:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5B/Mh0LM7+3R0IUqdEb/xm0Cw/iYqewSqzeC/0CfkIw=; b=Je1LjaS7mkfqGTMy9PS8hdn/1XvE3ixc3SgKhuKwXQNG5LT/RpvjxmvOfS+90WubTc jbm8RG8AY7l1Wf5EVFaKtWt1NI5F48WubqwcJBsx76PHTi7rJzQqtwR/ASifgWuiyP2V Grr4K90JF9ANJiQ3UvDP8JQS5CFkrVuirR7yd9W0HVgEKTdh9+DyBPpCd0ahkkB6U1Xi aaRd4su4ZBKmpiTzv9WHNPX517tUHRM64xLSUGTaL8Lf9lhyFuUVh2OW9YWXxt3R3bKL iQfWWBPsfjSofThp1HF0FhbIILBlSZT0LdictHzrZ/wTnd76e66+yXxXNWYhwx6xl4Vd JcVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5B/Mh0LM7+3R0IUqdEb/xm0Cw/iYqewSqzeC/0CfkIw=; b=ToG1UUyduciFLn43LFH6fRj01OTKSB/oRaPog2VhvWJyMI32rrnaTnCFc6OjZATMVH AonnWI/bXo0kbdayiXZrkFwiYKe+Ii8G4Baj+bA5vD1Df1mUl++aR2E21CM4R1YtDCHZ 4axZuX6kKghboZzpj0cexzmUWdCeutb2g0DZ/YWXcT16gG8LeffuQxYJY6FpX8I7chTE 3NEPfGDCBkHIGTxPsn4Hcgh0J0E+HQNC2G+JqyGoqAHgIBQ82UXzbuoO36c4XD29U+pQ 26HWi1ELMFkQ5JqIrWOy3EUe5Kj4GV+4JJxGi9h8TI6eLf6YQ9ESHk0FrJ+HiE/Gqm6T gzmA== X-Gm-Message-State: APjAAAVOIldnT4be6jPd5oDQn1dwEYydKlK3eWS+lHLduacE0EIKpa9Z 8QKsXuUAJrLscZhcjLrOaPVUSc7n X-Google-Smtp-Source: APXvYqwL53XSKibUyDWZ7XLazAjizCey5Aut1uilDPUfzn73pHc89LjaNpRT0xm8yHme8Bz578baAA== X-Received: by 2002:a1c:6a06:: with SMTP id f6mr991788wmc.113.1569268172748; Mon, 23 Sep 2019 12:49:32 -0700 (PDT) Received: from localhost.localdomain ([31.147.208.18]) by smtp.googlemail.com with ESMTPSA id o188sm25108013wma.14.2019.09.23.12.49.31 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 23 Sep 2019 12:49:32 -0700 (PDT) From: =?utf-8?q?Tomislav_Po=C5=BEega?= To: linux-wireless@vger.kernel.org Subject: [PATCH 5/5] ath10k: pull_svc_rdy code-style fix Date: Mon, 23 Sep 2019 21:49:25 +0200 Message-Id: <1569268165-1639-5-git-send-email-pozega.tomislav@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1569268165-1639-1-git-send-email-pozega.tomislav@gmail.com> References: <1569268165-1639-1-git-send-email-pozega.tomislav@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190923_124937_214378_23DA220B X-CRM114-Status: UNSURE ( 9.42 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pozega.tomislav[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ath10k@lists.infradead.org, kvalo@codeaurora.org Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org Drop unneeded lines by moving skb data in both main and 10x WMI pull service ready event operations. Signed-off-by: Tomislav Požega --- drivers/net/wireless/ath/ath10k/wmi.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 59d2d2a..8ab178c 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -5345,13 +5345,12 @@ static int ath10k_wmi_alloc_host_mem(struct ath10k *ar, u32 req_id, ath10k_wmi_main_op_pull_svc_rdy_ev(struct ath10k *ar, struct sk_buff *skb, struct wmi_svc_rdy_ev_arg *arg) { - struct wmi_service_ready_event *ev; + struct wmi_service_ready_event *ev = (void *)skb->data; size_t i, n; if (skb->len < sizeof(*ev)) return -EPROTO; - ev = (void *)skb->data; skb_pull(skb, sizeof(*ev)); arg->min_tx_power = ev->hw_min_tx_power; arg->max_tx_power = ev->hw_max_tx_power; @@ -5387,13 +5386,12 @@ static int ath10k_wmi_alloc_host_mem(struct ath10k *ar, u32 req_id, ath10k_wmi_10x_op_pull_svc_rdy_ev(struct ath10k *ar, struct sk_buff *skb, struct wmi_svc_rdy_ev_arg *arg) { - struct wmi_10x_service_ready_event *ev; + struct wmi_10x_service_ready_event *ev = (void *)skb->data; int i, n; if (skb->len < sizeof(*ev)) return -EPROTO; - ev = (void *)skb->data; skb_pull(skb, sizeof(*ev)); arg->min_tx_power = ev->hw_min_tx_power; arg->max_tx_power = ev->hw_max_tx_power;