From patchwork Thu Sep 26 13:36:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sergey Dyasli X-Patchwork-Id: 11162771 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 384001599 for ; Thu, 26 Sep 2019 13:38:12 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12583222C0 for ; Thu, 26 Sep 2019 13:38:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="ATpVfbt5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12583222C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDTww-0000Yo-Dv; Thu, 26 Sep 2019 13:36:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDTwv-0000Yi-An for xen-devel@lists.xen.org; Thu, 26 Sep 2019 13:36:49 +0000 X-Inumbo-ID: b03361aa-e062-11e9-9654-12813bfff9fa Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by localhost (Halon) with ESMTPS id b03361aa-e062-11e9-9654-12813bfff9fa; Thu, 26 Sep 2019 13:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1569505008; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=gLn9425sUw7wSjmm3RrcNAtrhU0yvYtnHREweJrQA54=; b=ATpVfbt5/CPZ/0PzNqwPM3dmzQzhR7ID05MYO4MJtQOi3aKL3IqSUIUq StCWOtXN1zsn61nLHHzfhq5LRl2iANXgLleTU8LVr2sVa49hnv4acOo7q kb8mhCYfg6jHYFOz77vnXC0wSfef7xcTVHBniSzo7FqlUFyLFmeBYBm0i I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=sergey.dyasli@citrix.com; spf=Pass smtp.mailfrom=sergey.dyasli@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of sergey.dyasli@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="sergey.dyasli@citrix.com"; x-sender="sergey.dyasli@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of sergey.dyasli@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="sergey.dyasli@citrix.com"; x-sender="sergey.dyasli@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="sergey.dyasli@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: R2OGPts+/G192iYDTmeEcN6z532bxe/65x8In8aSXsa/Yyo9lE3PD1v4xhW74pIGSVgzHQ6U7C K+12lDDaMHYVUoworxNqfkzr5aGiXpNmndI/515itOxUOELRnbju5ThEr4uvLUO7mD/t4Re6oz TWlp9vbInQCUPOxQttU4/F0CmhR9mscz6whYZn0t2CAVtlkexGyoMGeWtqG+Cjf4Lt8KiVb1JS 7wskLOYHg9odydL0uQ82H8l1uxEbZQ7EuKdVu3sNl+2jZbKfV87l8Z4PrPhscKVcFF8c56P02r b38= X-SBRS: 2.7 X-MesageID: 6394211 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,552,1559534400"; d="scan'208";a="6394211" From: Sergey Dyasli To: Date: Thu, 26 Sep 2019 14:36:18 +0100 Message-ID: <20190926133618.24083-1-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] x86/shim: fix ballooning down the guest X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Sergey Dyasli , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Jan Beulich , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Currently ballooning down a pvshim guest causes the following errors inside the shim: d3v0 failed to reserve 512 extents of order 512 for offlining And the ballooned-out pages stay inside shim and don't reach L0 Xen. Fix this by passing the correct arguments to pv_shim_offline_memory() during a XENMEM_decrease_reservation request. Signed-off-by: Sergey Dyasli Reviewed-by: Roger Pau Monné Acked-by: Jan Beulich --- CC: Andrew Cooper CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/common/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index 7364fd2c33..309e872edf 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1225,7 +1225,7 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) * hypercall has failed and only part of the extents where * processed. */ - pv_shim_offline_memory(args.nr_extents, args.nr_done); + pv_shim_offline_memory(args.nr_done, args.extent_order); #endif break;