From patchwork Tue Oct 1 21:14:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stuart hayes X-Patchwork-Id: 11169731 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8859813B1 for ; Tue, 1 Oct 2019 21:14:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66BFA21855 for ; Tue, 1 Oct 2019 21:14:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r+k0uy4N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727577AbfJAVOk (ORCPT ); Tue, 1 Oct 2019 17:14:40 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:41575 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbfJAVOj (ORCPT ); Tue, 1 Oct 2019 17:14:39 -0400 Received: by mail-oi1-f193.google.com with SMTP id w65so2971277oiw.8; Tue, 01 Oct 2019 14:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=h7zBxPIpqei6RdhutEMOr6Bfy8yNZwbOVfBFiC5FcV0=; b=r+k0uy4N/G3hyn8ODXlnf5E3CNecPYE9A9kudrJdUoiV4IgjmpqflGQIMBS01s9dR3 1twN9XGw6Gbss/oYW0TrYcx6nuYNc7ate0o58JaMsx4kBJmYPLwftLSpFYHdyFZnWhg7 h8KwKVEM1HHduF0Z/p2DyD5zj183m741wI/XTksmQ3XJpRPO7Ehm99P0Bs/imhYRao3x XFdMlnuIYZvzjVzaORr7UFjzOiSmcuo17apX/9nkLVjMwSslQ7DUfnhkSpfKfBZ+7fWC 2oJLWafDDG6vlsyFlRf9dtHh3dNaon0RkBzspBRpAibf06w9pZE3XGRWfwS/hwxHjKBy Ds7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=h7zBxPIpqei6RdhutEMOr6Bfy8yNZwbOVfBFiC5FcV0=; b=gJDgXztKoz4MCtcj6wzbyQ+hBfL/83jzpPG1LYVaAaXUKyYLUONUXJ/R6fT4OD+6mq UUeK6PFKfhMc28VS1qExpoNFyFHQflh0tnVPqFl9Nm4APCx8nT1V6XyYUVDnj6X0zhQQ rX0oyuwVplPg3dS++dPAPEZbO1gOaxOEVVWtMP/pH7T8yErV0sMchAImMJxmFeCffVV1 2METORrVodAdvnEUXmAFbxKHX/yyEI6cMD2GRELNB3dWzjl64j6ek5PiBYG/gqgmvpnp KS9sDCTYAe9/OrdrvZH08cO1BoVbfvQt0+kIhVlvPCqrc5JklroMPjfXlb+GqHDdvEMd cS2g== X-Gm-Message-State: APjAAAUm9a/nxxnrqLOio8P3v03jakxRvP8sxZth5QH6sTyr8twiI7d+ YRRl/KdagNWmx5kAE+fqwko= X-Google-Smtp-Source: APXvYqyzT9eUf0Gqpxg8KLfWlbsD4oPd46TsvpMArK83phhdmdFM9F7MUdFsHV+Z0rPGe9ScRkFF1Q== X-Received: by 2002:aca:dcd6:: with SMTP id t205mr38480oig.11.1569964478702; Tue, 01 Oct 2019 14:14:38 -0700 (PDT) Received: from localhost.localdomain ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id o23sm5220073ote.67.2019.10.01.14.14.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 14:14:38 -0700 (PDT) From: Stuart Hayes To: Bjorn Helgaas Cc: Austin Bolen , keith.busch@intel.com, Alexandru Gagniuc , "Rafael J . Wysocki" , Mika Westerberg , Andy Shevchenko , "Gustavo A . R . Silva" , Sinan Kaya , Oza Pawandeep , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, lukas@wunner.de, Stuart Hayes Subject: [PATCH 1/3] PCI: pciehp: Add support for disabling in-band presence Date: Tue, 1 Oct 2019 17:14:17 -0400 Message-Id: <20191001211419.11245-2-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20191001211419.11245-1-stuart.w.hayes@gmail.com> References: <20191001211419.11245-1-stuart.w.hayes@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The presence detect state (PDS) is normally a logical or of in-band and out-of-band presence. As of PCIe 4.0, there is the option to disable in-band presence so that the PDS bit always reflects the state of the out-of-band presence. The recommendation of the PCIe spec is to disable in-band presence whenever supported. Signed-off-by: Stuart Hayes --- drivers/pci/hotplug/pciehp.h | 1 + drivers/pci/hotplug/pciehp_hpc.c | 9 ++++++++- include/uapi/linux/pci_regs.h | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h index 654c972b8ea0..27e4cd6529b0 100644 --- a/drivers/pci/hotplug/pciehp.h +++ b/drivers/pci/hotplug/pciehp.h @@ -83,6 +83,7 @@ struct controller { struct pcie_device *pcie; u32 slot_cap; /* capabilities and quirks */ + unsigned int inband_presence_disabled:1; u16 slot_ctrl; /* control register access */ struct mutex ctrl_lock; diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 1a522c1c4177..dc109d521f30 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -811,7 +811,7 @@ static inline void dbg_ctrl(struct controller *ctrl) struct controller *pcie_init(struct pcie_device *dev) { struct controller *ctrl; - u32 slot_cap, link_cap; + u32 slot_cap, slot_cap2, link_cap; u8 poweron; struct pci_dev *pdev = dev->port; struct pci_bus *subordinate = pdev->subordinate; @@ -869,6 +869,13 @@ struct controller *pcie_init(struct pcie_device *dev) FLAG(link_cap, PCI_EXP_LNKCAP_DLLLARC), pdev->broken_cmd_compl ? " (with Cmd Compl erratum)" : ""); + pcie_capability_read_dword(pdev, PCI_EXP_SLTCAP2, &slot_cap2); + if (slot_cap2 & PCI_EXP_SLTCAP2_IBPD) { + pcie_write_cmd_nowait(ctrl, PCI_EXP_SLTCTL_IBPD_DISABLE, + PCI_EXP_SLTCTL_IBPD_DISABLE); + ctrl->inband_presence_disabled = 1; + } + /* * If empty slot's power status is on, turn power off. The IRQ isn't * requested yet, so avoid triggering a notification with this command. diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h index 29d6e93fd15e..ea1cf9546e4d 100644 --- a/include/uapi/linux/pci_regs.h +++ b/include/uapi/linux/pci_regs.h @@ -604,6 +604,7 @@ #define PCI_EXP_SLTCTL_PWR_OFF 0x0400 /* Power Off */ #define PCI_EXP_SLTCTL_EIC 0x0800 /* Electromechanical Interlock Control */ #define PCI_EXP_SLTCTL_DLLSCE 0x1000 /* Data Link Layer State Changed Enable */ +#define PCI_EXP_SLTCTL_IBPD_DISABLE 0x4000 /* In-band PD disable */ #define PCI_EXP_SLTSTA 26 /* Slot Status */ #define PCI_EXP_SLTSTA_ABP 0x0001 /* Attention Button Pressed */ #define PCI_EXP_SLTSTA_PFD 0x0002 /* Power Fault Detected */ @@ -676,6 +677,7 @@ #define PCI_EXP_LNKSTA2 50 /* Link Status 2 */ #define PCI_CAP_EXP_ENDPOINT_SIZEOF_V2 52 /* v2 endpoints with link end here */ #define PCI_EXP_SLTCAP2 52 /* Slot Capabilities 2 */ +#define PCI_EXP_SLTCAP2_IBPD 0x0001 /* In-band PD Disable Supported */ #define PCI_EXP_SLTCTL2 56 /* Slot Control 2 */ #define PCI_EXP_SLTSTA2 58 /* Slot Status 2 */ From patchwork Tue Oct 1 21:14:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stuart hayes X-Patchwork-Id: 11169729 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9A0E1709 for ; Tue, 1 Oct 2019 21:14:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 885FB2168B for ; Tue, 1 Oct 2019 21:14:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U6KOA9La" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727594AbfJAVOl (ORCPT ); Tue, 1 Oct 2019 17:14:41 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:36825 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727581AbfJAVOl (ORCPT ); Tue, 1 Oct 2019 17:14:41 -0400 Received: by mail-oi1-f194.google.com with SMTP id k20so15811496oih.3; Tue, 01 Oct 2019 14:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K1zrq8nG75RI+IGXt6RF0ionKO3pnPXpbdwWKZg3yRg=; b=U6KOA9Lav3pCY4HYTF4MRg2UDw5Eh7a3H6lnHWgCCxGO3UaDL7P8Wt6UdZMhfEXSbF qBvNQPTWtN3e5tGgY3h1oiNDc7YR2Wc1cZvl2YiPQq0eUoLPAYTinQ2QyqVfHwf46mjL HfGMNUZyhPyyHTiPBFF19X7VwKkPn+QL4QwGNVZa0xTP5TN5tXUd3+J3FSVAKJXSunN/ ttjeUqVIJjqWvkD2yIR6QT7K4WS+oGkYioEk5uKoDwPPq5M+iOITtctyjd89uXJlBpap MxuSV0TxEFv4kx8ZRF5sbGwywryYaBYYICU/IbsrIV7Kln7AxRyCq5Fb+P09x1v6inF4 w8Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=K1zrq8nG75RI+IGXt6RF0ionKO3pnPXpbdwWKZg3yRg=; b=gLWbO/jaVHf70XRYS47mFNrj2byKTrTJ2oDo2RLkA8hd+0QRbxMXPs6MsePD3aSxKL PbvaLUm6j0EZp9wzx7vjQStOqGNs+diuOD9CwBWu/cGeun7GDPHsiZVikDWE9aMcs1pA OyaFcQSLMgyq4lo6OgHquwNTS8To7a1mVpCxqOMoizSrczOcRqD9+tBAUgx/SoFb5eap j28dCfe9onWSCvfLRa6j5NYW9ayO1DYs/MOzZwE6lBFNf3UR9ldEQRiu12ZGx4n4LQJH ik4AuZbwnPCnc8Y32SgttKeX4fEEU1wKFaIbTmgmwHMlDWzWlrThcZ3A98mOMqYBrsIM RuDw== X-Gm-Message-State: APjAAAXyCpvCX7hBUH6OXwSeJu9yRrwEIwa+5uZv5albcbxkA7BPMu99 k49LLGOvf3grTyTxblDu4Pw= X-Google-Smtp-Source: APXvYqzCNrBEiC4vUKrbClH9/cmjYbM5sjQlB93sQYcGzbUXBVY/ukOeteqN2JF/PN38CrqceYSEPA== X-Received: by 2002:a05:6808:b07:: with SMTP id s7mr51715oij.134.1569964480229; Tue, 01 Oct 2019 14:14:40 -0700 (PDT) Received: from localhost.localdomain ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id o23sm5220073ote.67.2019.10.01.14.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 14:14:39 -0700 (PDT) From: Stuart Hayes To: Bjorn Helgaas Cc: Austin Bolen , keith.busch@intel.com, Alexandru Gagniuc , "Rafael J . Wysocki" , Mika Westerberg , Andy Shevchenko , "Gustavo A . R . Silva" , Sinan Kaya , Oza Pawandeep , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, lukas@wunner.de, Stuart Hayes Subject: [PATCH 2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled Date: Tue, 1 Oct 2019 17:14:18 -0400 Message-Id: <20191001211419.11245-3-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20191001211419.11245-1-stuart.w.hayes@gmail.com> References: <20191001211419.11245-1-stuart.w.hayes@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org When inband presence is disabled, PDS may come up at any time, or not at all. PDS being low may indicate that the card is still mating, and we could expect contact bounce to bring down the link as well. It is reasonable to assume that most cards will mate in a hotplug slot in about a second. Thus, when we know PDS only reflects out-of-band presence, it's worthwhile to wait the extra second or so to make sure the card is properly mated before loading the driver, and to prevent the hotplug code from disabling a device if the presence detect change goes active after the device is enabled. Signed-off-by: Stuart Hayes --- drivers/pci/hotplug/pciehp_hpc.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index dc109d521f30..1282641c6458 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -242,6 +242,25 @@ static bool pci_bus_check_dev(struct pci_bus *bus, int devfn) return found; } +static void pcie_wait_for_presence(struct pci_dev *pdev) +{ + int timeout = 1250; + bool pds; + u16 slot_status; + + while (true) { + pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &slot_status); + pds = !!(slot_status & PCI_EXP_SLTSTA_PDS); + if (pds || timeout <= 0) + break; + msleep(10); + timeout -= 10; + } + + if (!pds) + pci_info(pdev, "Presence Detect state not set in 1250 msec\n"); +} + int pciehp_check_link_status(struct controller *ctrl) { struct pci_dev *pdev = ctrl_dev(ctrl); @@ -251,6 +270,9 @@ int pciehp_check_link_status(struct controller *ctrl) if (!pcie_wait_for_link(pdev, true)) return -1; + if (ctrl->inband_presence_disabled) + pcie_wait_for_presence(pdev); + found = pci_bus_check_dev(ctrl->pcie->port->subordinate, PCI_DEVFN(0, 0)); From patchwork Tue Oct 1 21:14:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stuart hayes X-Patchwork-Id: 11169727 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7F8CD13B1 for ; Tue, 1 Oct 2019 21:14:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D43021855 for ; Tue, 1 Oct 2019 21:14:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hUhiEEan" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727629AbfJAVOp (ORCPT ); Tue, 1 Oct 2019 17:14:45 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:44013 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727605AbfJAVOm (ORCPT ); Tue, 1 Oct 2019 17:14:42 -0400 Received: by mail-oi1-f195.google.com with SMTP id t84so15763461oih.10; Tue, 01 Oct 2019 14:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UuDNbF2gV+LyjceU1ngZXA4KGi6dXJs2jlZxsWh+OEI=; b=hUhiEEan53w6H4qCylahOlh68Y/6FTlzXiyUXL38GW2ImrNRlt85H5bsyoTypqcFPC tZoV2eLEzT5JhF0LGucRd2IB7gyXRisY89ojgTvPKvaVVd5NY0QLu4LPjZmyT2g4blkX JXcVsQD0R6XFLo0mHao90lPSTX8KBhb43JjPTeEi5bayheyYk03d13q+Mog4XbH1bZEe /Pf7ipEzL0V9wzJ3gTkEZyEW9F6VxEm3wahswlsBHctZh9Z/b4OhSe7FmqnnRoCzxKH7 2gOdo5HsFIcYpX/SJWkXLJTQDsUqHPu1c5o9bsRyfGiAugfuuQ3/4Ly4JTC1Qwa3P2t9 maMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UuDNbF2gV+LyjceU1ngZXA4KGi6dXJs2jlZxsWh+OEI=; b=Xigc6/xmRMDT4PdfvQ8Q/6ZPOIopZrx55gfG/xWpwwuZAXex3wTdYmJwvNWOumeIqM 5eQzLBz526tHx2qXWbGJOVgkHndbgfjUJHLuYzUpNZlV6c7PQxa6F6JoMFI5ogxeIJ2v fl6f4AdTVYOyy3CYTe2aN1wBUOAapO7c0GCRYPSz9dnKI2flny0k+A4jnpM4IRfbmPx1 TZwuyvKLNHh6q2RFqyv/smN4Cq/aLsfzjMnndimt68DTfPvXfoieJJTVCLREF0mnC25w ThfqZRaF5r6yEkqD3YyDAEULy4b2w2sGII6mvhESHHyGppTSeZq4NdPbw5O/Sn/6XM2G 7Q4w== X-Gm-Message-State: APjAAAWM4lmqFyc9hK2w/TvTxOrndOEmL5qlONXUB0ee0QHHwBG/cuon F58VPIvMNfSjBRhTLEd/qUU= X-Google-Smtp-Source: APXvYqxY4xV2qaLo44Gs/pIGdkALaTbOx+2OXshNup2CFbBS3INHp8CbSpMts6Vr58CuN0Ay+mba5g== X-Received: by 2002:aca:538a:: with SMTP id h132mr58946oib.66.1569964481652; Tue, 01 Oct 2019 14:14:41 -0700 (PDT) Received: from localhost.localdomain ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id o23sm5220073ote.67.2019.10.01.14.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 14:14:41 -0700 (PDT) From: Stuart Hayes To: Bjorn Helgaas Cc: Austin Bolen , keith.busch@intel.com, Alexandru Gagniuc , "Rafael J . Wysocki" , Mika Westerberg , Andy Shevchenko , "Gustavo A . R . Silva" , Sinan Kaya , Oza Pawandeep , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, lukas@wunner.de, Stuart Hayes Subject: [PATCH 3/3] PCI: pciehp: Add dmi table for in-band presence disabled Date: Tue, 1 Oct 2019 17:14:19 -0400 Message-Id: <20191001211419.11245-4-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20191001211419.11245-1-stuart.w.hayes@gmail.com> References: <20191001211419.11245-1-stuart.w.hayes@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Some systems have in-band presence detection disabled for hot-plug PCI slots, but do not report this in the slot capabilities 2 (SLTCAP2) register. On these systems, presence detect can become active well after the link is reported to be active, which can cause the slots to be disabled after a device is connected. Add a dmi table to flag these systems as having in-band presence disabled. Signed-off-by: Stuart Hayes --- drivers/pci/hotplug/pciehp_hpc.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 1282641c6458..1dd01e752587 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -14,6 +14,7 @@ #define dev_fmt(fmt) "pciehp: " fmt +#include #include #include #include @@ -26,6 +27,16 @@ #include "../pci.h" #include "pciehp.h" +static const struct dmi_system_id inband_presence_disabled_dmi_table[] = { + { + .ident = "Dell System", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"), + }, + }, + {} +}; + static inline struct pci_dev *ctrl_dev(struct controller *ctrl) { return ctrl->pcie->port; @@ -898,6 +909,9 @@ struct controller *pcie_init(struct pcie_device *dev) ctrl->inband_presence_disabled = 1; } + if (dmi_first_match(inband_presence_disabled_dmi_table)) + ctrl->inband_presence_disabled = 1; + /* * If empty slot's power status is on, turn power off. The IRQ isn't * requested yet, so avoid triggering a notification with this command.