From patchwork Tue Oct 1 23:39:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11169919 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8BFA51709 for ; Tue, 1 Oct 2019 23:39:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 611E921924 for ; Tue, 1 Oct 2019 23:39:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SvSuvufv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729145AbfJAXjm (ORCPT ); Tue, 1 Oct 2019 19:39:42 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:42841 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729121AbfJAXjm (ORCPT ); Tue, 1 Oct 2019 19:39:42 -0400 Received: by mail-io1-f68.google.com with SMTP id n197so52561592iod.9; Tue, 01 Oct 2019 16:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=58jpN6kWHAdO3tEL+y4lY6rt76msdHq/bsZsGT7F90Q=; b=SvSuvufv+gb1Em1YZE/meNqsikAT0bmsrAYxIog97pFs618p0gqm7/afZrcd9pUc33 5fxADY0uoB818dziQyLsbJ0PoaWJdBqXD007LX4kpdBh+rlYQpKTSkecUrFbmOuchmab YJfxmzd2FdhuDAzkRHimZ9xvpg9y/bY74MIQgq5d3uXDPtXfaIbb1QL9wQCz6n6hf6IT J9Ng1E8Cf8UWM2bxh8OQUP6yHpZXT9lIy1vdOts7yc52qHM8XB60aSg2jDoFvT+GfSdJ X2yJZWJoGLotuCHq0W8w0fAR4ORaz67fnzyRyEKKAfCVhnD4cyJ8TzuceQXvAqNbrj66 xC6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=58jpN6kWHAdO3tEL+y4lY6rt76msdHq/bsZsGT7F90Q=; b=MukdRL6FpIYoYypmNQtsC/n7Z7KddeLkMSnhqrBEaVbiI1gxvkH7lc1VprU+TCIMnz 4bSDV5OMEAHmSC2TQV1C7xjU+rNgdH6OsB9ZpOF+hd56L8T4AUWM2SzbSCht4xy011rj Ho36Us2ilLptepGTlxXuE2ZG5gJLR8ax2TCefUTxyc6SKOWIBpyVqdrB6pRSsmDu27Ru TQF/nUssdYQVcyDUGdk16wNd+lhaLFrIvZuGUE14S9ipVfI1rzVggDs8WoxBtY075mMl OmEWpOE0Kqm8UhX0/Hcmg7vG9al6pTs7VPoQ0KU5PlBXMLn1k89awjLdN5r8FxQV0Lqi 2fFg== X-Gm-Message-State: APjAAAUnhLM4xS0UXptoGt//mwnJlQSXLQ94Odes2Ipi+T1w4ppNNtlz zclVRXkeGPRUtUlGHRJUCWw= X-Google-Smtp-Source: APXvYqx/Io8WkCb0T45Vregl4/lp6Yar6RAnWh52hAyGEGPoMLqPDMbZySdWTSgeeIhBx7SWJOXZug== X-Received: by 2002:a6b:b4c7:: with SMTP id d190mr774996iof.209.1569973181556; Tue, 01 Oct 2019 16:39:41 -0700 (PDT) Received: from localhost.localdomain (c-73-37-219-234.hsd1.mn.comcast.net. [73.37.219.234]) by smtp.gmail.com with ESMTPSA id r22sm8659935ilb.85.2019.10.01.16.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 16:39:40 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Cc: linux-omap@vger.kernel.org, adam.ford@logicpd.com, Adam Ford , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V4 1/3] drm/panel: simple: Add Logic PD Type 28 display support Date: Tue, 1 Oct 2019 18:39:18 -0500 Message-Id: <20191001233923.16514-1-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg --- V4: No Change V3: No Change V2: No Change diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 28fa6ba7b767..8abb31f83ffc 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2048,6 +2048,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock = 9000, + .hdisplay = 480, + .hsync_start = 480 + 3, + .hsync_end = 480 + 3 + 42, + .htotal = 480 + 3 + 42 + 2, + + .vdisplay = 272, + .vsync_start = 272 + 2, + .vsync_end = 272 + 2 + 11, + .vtotal = 272 + 2 + 11 + 3, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 105, + .height = 67, + }, + .delay = { + .prepare = 200, + .enable = 200, + .unprepare = 200, + .disable = 200, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | + DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, +}; + static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes = 1, @@ -3264,6 +3298,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01, From patchwork Tue Oct 1 23:39:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11169935 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9565317EE for ; Tue, 1 Oct 2019 23:40:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72BF321906 for ; Tue, 1 Oct 2019 23:40:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d5sf5a4Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729183AbfJAXjv (ORCPT ); Tue, 1 Oct 2019 19:39:51 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:34614 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729221AbfJAXju (ORCPT ); Tue, 1 Oct 2019 19:39:50 -0400 Received: by mail-io1-f66.google.com with SMTP id q1so52683097ion.1; Tue, 01 Oct 2019 16:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RRxLLSLdYwPdwhaO14RiyNJQD0CnUxdvg/CobR3GW5Q=; b=d5sf5a4QPval49H/yPG+oZ218/LNFsYS2BqSXjPtJQZVXLxwOE9eFp/e1Itrk/nsMN 6xHr7klTiWaAx5ZwbkIYHMMhDJ1zq7JlFCsf81h+mhmCcKKAbOdGj3Pika8UsnR5O7dq ryOg5PveRi69RaDQogmV3+UoaAyq5ii++GhDdQcyXrQADLH/3kOIGk5P0/6TgjxoHQo+ XIdRmIgV6R8l+Gnf7ntm5ffCrTiBcajCjsuKXcwTQC1pl7Er6sjXvMJ7iNaP9nZc3XTi cIFFv06rhM1wQB8sozAiNHN1ssw+inHRC4J4fieg4fzJOwVRY+Ze1FD7rk5cy0h5zzII w3Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RRxLLSLdYwPdwhaO14RiyNJQD0CnUxdvg/CobR3GW5Q=; b=r/kYnuHOy6jjffdHBn5jswoFnV+Lcqs6c9saLgD1xrzHrn7Uy2w0DtT8Z7mxe2zGZE xkkoJCchn1xJl+yM4MGEpfQpZ4zAgHFQ1ZQKJLu9rkxlAZPQj2rNVeD+Gl83QcWRHZ5p G2X8fvJzEiS9G2OZAWNLGrWPpN7G0uegPNjNXBw8qPITsVLvdTee/QUbJC/glyxZKeOg wK/tO1YlDzPYygL4r+kVJ7cuft5kQgh0pxtAS8Zm0b1/L7+L+TqQ9dN5Lew1I7f5gsQB NuaX4ssjYYJuUz+bfwumDX72q6q+PqwbWS0jd+h8wZLWkaIOefPDQ86ZyX6n3miiBsIq zXPg== X-Gm-Message-State: APjAAAXzQfpUEymGYq9jl/Yd1pLvOhRg8yiXPQIXtlj1rgdKYKj+sT47 wTtsKwkIh4CL+jUMXOoztzQ= X-Google-Smtp-Source: APXvYqw/0RbXnF1zpAYBmsTItdefmNQwLFLdY/TiQ+O49LmKTlWPdXKhCB6f8Yd31d8q+MoClv92Bw== X-Received: by 2002:a92:502:: with SMTP id q2mr750564ile.141.1569973187916; Tue, 01 Oct 2019 16:39:47 -0700 (PDT) Received: from localhost.localdomain (c-73-37-219-234.hsd1.mn.comcast.net. [73.37.219.234]) by smtp.gmail.com with ESMTPSA id r22sm8659935ilb.85.2019.10.01.16.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 16:39:47 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Cc: linux-omap@vger.kernel.org, adam.ford@logicpd.com, Adam Ford , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V4 2/3] dt-bindings: Add Logic PD Type 28 display panel Date: Tue, 1 Oct 2019 18:39:22 -0500 Message-Id: <20191001233923.16514-5-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191001233923.16514-1-aford173@gmail.com> References: <20191001233923.16514-1-aford173@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for binding diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file mode 100644 index 000000000000..e2c62e8f1db4 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel + +maintainers: + - Adam Ford + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: logicpd,type28 + + power-supply: true + enable-gpios: true + backlight: true + port: true + +required: + - compatible + +additionalProperties: false + +examples: + - | + lcd0: display { + compatible = "logicpd,type28"; + enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; + backlight = <&backlight>; + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + }; + +... From patchwork Tue Oct 1 23:39:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11169937 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 773ED1709 for ; Tue, 1 Oct 2019 23:40:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 561C021924 for ; Tue, 1 Oct 2019 23:40:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DNOUBVmV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729225AbfJAXju (ORCPT ); Tue, 1 Oct 2019 19:39:50 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:37682 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729219AbfJAXju (ORCPT ); Tue, 1 Oct 2019 19:39:50 -0400 Received: by mail-io1-f66.google.com with SMTP id b19so24534959iob.4; Tue, 01 Oct 2019 16:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IviJQ2N622ovMvnAFQ5UMMPkhv4vjXzkXpkg1vsAmBc=; b=DNOUBVmVUAypCrPEcDm3GsIKmKDVicfDkI4NfruqmYi2MbnOdkXuQs2Hz45pZdKkXP tQ8LxfGcTS8aExdl0rNn7GFyd+jpdJ0HQkik2f14QyjgMJu4MWa7nZUeDWbS4HTnivc4 mZGOByd/VTLmvEpH9QvFam1pMSxa0F3bFvzbBfk5lYVcOJwA2lz7vl0qxcwkIkW1Y58w OhmFkSTbCGXaUlfxXD5sPggnlSdIIsRuJCrbbcAVvIMb8p5RCFKEcxTpstSB54rK1NbJ yPq7hRfuuMWFF8lnjYYrApUgOMCcSjRLKS4O/IDjL9cXqDM8eB+mpJTU6YkzzHQgKDMy O7Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IviJQ2N622ovMvnAFQ5UMMPkhv4vjXzkXpkg1vsAmBc=; b=Z1HD5QUY742LX4P48C3Ze3bwTaRFnuhXZ1L0it1qxlwCNiJh/t5UflVGUKJqSzNwCR Br6jdFRv+fnyNGx6/z79FrzOuJYTswKvFjd3sYBTqxjPaY7rgKg+RCl2FF/xzgsw6Pzc 454ziLaUNwk3VlCsCPqrIt3L+3mDTlRaiTVY5H8PHC/jiurGCiEflnXRY4c75sR6ackW rmain2ze94EeYRdNqHTabdgJjDcDp5HM+3jopZ976FFsd9wmLcttLHUcXLs0UUNwUffz penWqJzoCKyI9yFu8WTXHblPlwAitr7vks8SsaKJB126i30M5+OJVeZQ5GZM0+OvGQrc tf4A== X-Gm-Message-State: APjAAAWJrUgAmfYkKwThzyTDmEMJ6m6kVPRVmqLTegfzxENjhs4vPJbH +TGkwrcPXNTNVsR5y6lbMHo= X-Google-Smtp-Source: APXvYqy4qifIuV3uXjVmLyj/P9fmIFx/f/pEw5vONAuRa7jHVpmKT9t9pDPuxlKh2izbbpKZGI5FbQ== X-Received: by 2002:a92:1559:: with SMTP id v86mr820194ilk.130.1569973189265; Tue, 01 Oct 2019 16:39:49 -0700 (PDT) Received: from localhost.localdomain (c-73-37-219-234.hsd1.mn.comcast.net. [73.37.219.234]) by smtp.gmail.com with ESMTPSA id r22sm8659935ilb.85.2019.10.01.16.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 16:39:48 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Cc: linux-omap@vger.kernel.org, adam.ford@logicpd.com, Adam Ford , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V4 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel Date: Tue, 1 Oct 2019 18:39:23 -0500 Message-Id: <20191001233923.16514-6-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191001233923.16514-1-aford173@gmail.com> References: <20191001233923.16514-1-aford173@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg --- V4: No Change V3: No change V2: Remove legacy 'label' from binding diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts index 07ac99b9cda6..cdb89b3e2a9b 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts @@ -11,22 +11,6 @@ #include "logicpd-torpedo-37xx-devkit.dts" &lcd0 { - - label = "28"; - - panel-timing { - clock-frequency = <9000000>; - hactive = <480>; - vactive = <272>; - hfront-porch = <3>; - hback-porch = <2>; - hsync-len = <42>; - vback-porch = <3>; - vfront-porch = <2>; - vsync-len = <11>; - hsync-active = <1>; - vsync-active = <1>; - de-active = <1>; - pixelclk-active = <0>; - }; + /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */ + compatible = "logicpd,type28"; };