From patchwork Mon Oct 14 17:38:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11189241 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D7EB76 for ; Mon, 14 Oct 2019 17:38:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3E5E20873 for ; Mon, 14 Oct 2019 17:38:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lMX0xWSe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730523AbfJNRij (ORCPT ); Mon, 14 Oct 2019 13:38:39 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52193 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730508AbfJNRij (ORCPT ); Mon, 14 Oct 2019 13:38:39 -0400 Received: by mail-wm1-f68.google.com with SMTP id 7so18151171wme.1 for ; Mon, 14 Oct 2019 10:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pZB6ccNxWfk6NZibMKYvriXwtcv9GEZSbjmWhYH39uM=; b=lMX0xWSe+fRd0y328Srb0mXFWasaRWw3Jzo3NbMTd4nnvgeN3N+VsDWy5W2S9rWY8j wu47ddVVY1HsX0EkGNUITF2x7ZKLm8rVaEGOS7jhaKk02E4qs8wJKeiOyCDzutlZk6rF 4iWo7+Lp7EgmkEdLU+nNhHrKLR7Q0ABuLhymaDknZUUmvk1yQ4HUuFPU6Uo8+zR5In4d dPW6j/XvideO+QuXF23GON+r3If+kZpiAJb05wlciSvEFjOjfb8LScGzfcH5LDBaoB1U g2xp/jQrYRGwg6njTrChKsrUDKdCondUpR5c4OJgXHhkWRs9QIh/hpHZGpltKpdt6Q0u XsCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pZB6ccNxWfk6NZibMKYvriXwtcv9GEZSbjmWhYH39uM=; b=bNVtNOpyt+WNdt5vQ5FhvFcdoMAINPzPZtrJpVoUcpAFMu58sI5xJ+11lpOCVjXH6E hKjfr+iysKG5Dbm95Jncl7EHnnkUtk7Y3+LzM9KgLYqY3dUf6Lk8lJNGP/FCUWwgTFV6 JO2XA8Lo0gJUypVyfOBnAs4b9Z/R3vC0s+s2QnofBgk/qJvmTH6kkZfn0kRvCiY0mX+3 xemuYNrEgU8RplFjaelgbZ56KAsuvLdzL8o6e8KT6LNb4xrQcjUFW39jS33nTBhC2FsB oQjBmI+ac53GHXBigz9KvFAarlbssca+AhUO8Cxx/2XDVI/tlWSoEYmBpFheIoWs3rtm GTWA== X-Gm-Message-State: APjAAAVVzul9QdE+SGzBVxbtcl6kw8HDS2Gk3147b+TcBJzLwPvu/t8j NjLIxTS40CIhwQ3HOq7gUBOZd4bV X-Google-Smtp-Source: APXvYqyXLQWP2YWfYYXXf9XULb2Gw7fEtx4CWNCQPRRlT6dSpDpNlZ6TmcDfGvNyRjVprADoEf1eMw== X-Received: by 2002:a1c:5609:: with SMTP id k9mr15760608wmb.103.1571074716885; Mon, 14 Oct 2019 10:38:36 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id 36sm24981585wrp.30.2019.10.14.10.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 10:38:36 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next 1/4] RDMA/core: Fix return code when modify_port isn't supported Date: Mon, 14 Oct 2019 20:38:14 +0300 Message-Id: <20191014173817.10596-2-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191014173817.10596-1-kamalheib1@gmail.com> References: <20191014173817.10596-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org The proper return code is "-EOPNOTSUPP" when modify_port callback is not supported. Signed-off-by: Kamal Heib --- drivers/infiniband/core/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index a667636f74bf..98a01caf7850 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -2397,7 +2397,7 @@ int ib_modify_port(struct ib_device *device, port_modify_mask, port_modify); else - rc = rdma_protocol_roce(device, port_num) ? 0 : -ENOSYS; + rc = rdma_protocol_roce(device, port_num) ? 0 : -EOPNOTSUPP; return rc; } EXPORT_SYMBOL(ib_modify_port); From patchwork Mon Oct 14 17:38:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11189243 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A8AA676 for ; Mon, 14 Oct 2019 17:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B4CA20873 for ; Mon, 14 Oct 2019 17:38:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k+lqMOyK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730508AbfJNRil (ORCPT ); Mon, 14 Oct 2019 13:38:41 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35101 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730039AbfJNRik (ORCPT ); Mon, 14 Oct 2019 13:38:40 -0400 Received: by mail-wr1-f66.google.com with SMTP id v8so20708471wrt.2 for ; Mon, 14 Oct 2019 10:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E0mAKklmj8b9BHq3gYzHhA+M82D94UL3c4aRysFZhfg=; b=k+lqMOyKxtp6FXzpms8F1nl3BwkQR9ZJd4RsKZ9QUOCHgcot+2xjJyHRT2Zbhv9TzL 9SBvE73C88D62rCfb0EFrQbC1EQobHH9c6GifPA2xamWAorQKXB9xgAVDtuTsuMengP0 RIs2y0Y8onvCzT/0x7iKyooHUdpAhtTZClF5NfXRrhRUdxgFOXtm31XwRYZZSj1B2iL1 MCSut+D809DGqUXqcEDVAJ5Bl1I4F2U9NCjRT+qBRDKo6vpfNqHN8lU7pGf7ArHquw6F EoUd7fe53FNQyEfBv92c7qEaKrAU4Dd0u3U0sxgvnZddZWtg+mPt4p66Aph39wbWGq66 3R3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E0mAKklmj8b9BHq3gYzHhA+M82D94UL3c4aRysFZhfg=; b=UFVhMf+2RgrllyIhaJNU/vGUDaT7TmAeMnxsGf76dFav4pYPlIlS3rLk4T7hJJzvsg obPkF7mo6R5EtZiazj5IXsDKd/JpKtRUFOWNXuJXxF/IhjNG9EQdq9cK0roye7wEY2cv cB7OStDyZQizXh01wcWf/FsrtD04f2dVJdp8g8eHdzDsZJsx0r6mpPH47zsA9UFYfWFg sneSuS+yWkY/S1frGIWN/7feRU5vAFhvboxqyMHMjViA22SJ6B4PJFfdwO2Z9QdVzGod 5/NIa62DwM0ryvErmQgjz2V/J1S+r8peIGmsYHGHk59+jHB/iIzUqlZlYZRrFJ1qbCb5 Y1LA== X-Gm-Message-State: APjAAAW5bAdTMVCL9fjiEqgX3L2ni/Z5ouiEn010gqyPiWHqysrvcErA /Ytq/bwZbtJ4ZFhQvydS9oCokA6M X-Google-Smtp-Source: APXvYqy79NgNF8ZVMxvVtVSe9UKWkAQnlLsjvm41wex2vFcO9ttU4w8Y/9DoI+eVGp9pNZgDBHQX/A== X-Received: by 2002:a5d:484e:: with SMTP id n14mr25879009wrs.110.1571074718305; Mon, 14 Oct 2019 10:38:38 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id 36sm24981585wrp.30.2019.10.14.10.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 10:38:37 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next 2/4] RDMA/hns: Remove unsupported modify_port callback Date: Mon, 14 Oct 2019 20:38:15 +0300 Message-Id: <20191014173817.10596-3-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191014173817.10596-1-kamalheib1@gmail.com> References: <20191014173817.10596-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Signed-off-by: Kamal Heib --- drivers/infiniband/hw/hns/hns_roce_main.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c index b5d196c119ee..b241f74a7e3b 100644 --- a/drivers/infiniband/hw/hns/hns_roce_main.c +++ b/drivers/infiniband/hw/hns/hns_roce_main.c @@ -301,12 +301,6 @@ static int hns_roce_modify_device(struct ib_device *ib_dev, int mask, return 0; } -static int hns_roce_modify_port(struct ib_device *ib_dev, u8 port_num, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int hns_roce_alloc_ucontext(struct ib_ucontext *uctx, struct ib_udata *udata) { @@ -438,7 +432,6 @@ static const struct ib_device_ops hns_roce_dev_ops = { .get_port_immutable = hns_roce_port_immutable, .mmap = hns_roce_mmap, .modify_device = hns_roce_modify_device, - .modify_port = hns_roce_modify_port, .modify_qp = hns_roce_modify_qp, .query_ah = hns_roce_query_ah, .query_device = hns_roce_query_device, From patchwork Mon Oct 14 17:38:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11189245 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1A53176 for ; Mon, 14 Oct 2019 17:38:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F062120854 for ; Mon, 14 Oct 2019 17:38:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rWLwv6FE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730567AbfJNRin (ORCPT ); Mon, 14 Oct 2019 13:38:43 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35104 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730039AbfJNRin (ORCPT ); Mon, 14 Oct 2019 13:38:43 -0400 Received: by mail-wr1-f65.google.com with SMTP id v8so20708554wrt.2 for ; Mon, 14 Oct 2019 10:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xGSj+0zwi0V4FE8yNS+b2NCvo79lwer8DLhs3owmsYw=; b=rWLwv6FEKa03sfHl1XwxBo5j2JVahQ3FIK+LD7DO1s6YRcseRODC5844798/MVh1B8 q/AmBKbO3C4iKIdPU+n65/4MMDTGStFLdZH3MZz79iLxCnNspIMjF2MJZHGi7ydTHDDL gjDROGwe7sjaZ7G56x7xQtteIkYJWX9EYwpXVTsMPFQNhPXb9AjRf6TqL0e/RAAcS7ix n4ph3NIgXSg3pih/QLOgitLxr8R/ClYSfZ5/lZp39ev7GkkqPKzEMUeuHjG8tFb+8nDd d/09N3Gvtde41UUgMl7QhKhDATTf9HJ+yO35UnFqyA7rW0xLB0x/SmDcatLObmAJUS92 j9JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xGSj+0zwi0V4FE8yNS+b2NCvo79lwer8DLhs3owmsYw=; b=r2wMeaCLyoyUXqQyWJLAEig4RcnlRPX/DuBTbtNCdiwfVrwlj1UBfYcth8+IZei79j YC3Fs2Th4/fT3Sfz45KEl5xoFe6MFXFyCJslBa14dfQ9goUmz8xxHFTWAq5eJKSlLtP3 jsA4lHs/6lizsjWfW6q/xrrpJB6BCPLflsNcMS4UsFlPJA9LMr4W4KFzwLretKxi3Ope atGvwqt3BuvTH6040qQ889Dvagk/bN2yQYvwW6X9/iBa4kpQHYW5oBy9AgHWSnEUbfjk jU1RPxzzaVHSmKiRzPV2Yh45+6B/uDiMLypDsM/912nGjC3v3Gek1/9HbwuBTisWQxg1 FHIw== X-Gm-Message-State: APjAAAXmjY0Tl0fCGRWoRckZZlmpgesMIKkzYFDfL+QKHRHUjV9cXWAI gnZvVVw+6ex57kf+TqrOlxqUBJFG X-Google-Smtp-Source: APXvYqwTJRCT6cdkwMzTc9UDRdsf76Aau/W6dO1zdU2jdEuvEFPS4zFc5OZOBQGzfpP+QXm04Zypuw== X-Received: by 2002:a5d:4302:: with SMTP id h2mr17424564wrq.35.1571074719707; Mon, 14 Oct 2019 10:38:39 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id 36sm24981585wrp.30.2019.10.14.10.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 10:38:39 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next 3/4] RDMA/ocrdma: Remove unsupported modify_port callback Date: Mon, 14 Oct 2019 20:38:16 +0300 Message-Id: <20191014173817.10596-4-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191014173817.10596-1-kamalheib1@gmail.com> References: <20191014173817.10596-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Signed-off-by: Kamal Heib --- drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 - drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 6 ------ drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 2 -- 3 files changed, 9 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c index c15cfc6cef81..d8c47d24d6d6 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c @@ -166,7 +166,6 @@ static const struct ib_device_ops ocrdma_dev_ops = { .get_port_immutable = ocrdma_port_immutable, .map_mr_sg = ocrdma_map_mr_sg, .mmap = ocrdma_mmap, - .modify_port = ocrdma_modify_port, .modify_qp = ocrdma_modify_qp, .poll_cq = ocrdma_poll_cq, .post_recv = ocrdma_post_recv, diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index e8267e590772..e72050de5734 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -190,12 +190,6 @@ int ocrdma_query_port(struct ib_device *ibdev, return 0; } -int ocrdma_modify_port(struct ib_device *ibdev, u8 port, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int ocrdma_add_mmap(struct ocrdma_ucontext *uctx, u64 phy_addr, unsigned long len) { diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h index 32488da1b752..3a5010881be5 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h @@ -54,8 +54,6 @@ int ocrdma_arm_cq(struct ib_cq *, enum ib_cq_notify_flags flags); int ocrdma_query_device(struct ib_device *, struct ib_device_attr *props, struct ib_udata *uhw); int ocrdma_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int ocrdma_modify_port(struct ib_device *, u8 port, int mask, - struct ib_port_modify *props); enum rdma_protocol_type ocrdma_query_protocol(struct ib_device *device, u8 port_num); From patchwork Mon Oct 14 17:38:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11189247 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EFE1776 for ; Mon, 14 Oct 2019 17:38:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D294320873 for ; Mon, 14 Oct 2019 17:38:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XTFbNAnC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730039AbfJNRio (ORCPT ); Mon, 14 Oct 2019 13:38:44 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:50873 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730527AbfJNRio (ORCPT ); Mon, 14 Oct 2019 13:38:44 -0400 Received: by mail-wm1-f65.google.com with SMTP id 5so18158391wmg.0 for ; Mon, 14 Oct 2019 10:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VuCmTl5VzUxy3QDinOpzJbSFYV8O12fP4R6UuCOy2n0=; b=XTFbNAnCkaLz71nVRS/N0V3D4Fehve93csLuqwj9Qm0u6EZQ1JWignJp+LI2coq6he ZqRINwSjXqopyN7VOjqAbjhc/vwrSggcbQ8CNyW+eW/6sgRYhYohyPhYYXgNIwEKHl79 n6yqr2O68atGt+PCNT/y7qtSMwiqAfSRHMmNN6V1o/8ZPqVnfIy4QipGfh/xmh7TpPUy RrzTOImGQvgFDlE/RSCgU3UXC7irlQGjkOEEDnh+3Unxt4UoU84Poghc/2U6cOIc+i0G iWyVT+nL2WqN+6GLHwNVzRm8skHlLJhqowVpUcNftIQQFedL8+kjEyTDF/TD8sSSX1Qj vc8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VuCmTl5VzUxy3QDinOpzJbSFYV8O12fP4R6UuCOy2n0=; b=hsAOA5r3evbFK4A+NFn/Zj6A+d1phHJZaSu7vhh2QL+O72Jp86jvA2i6wzaG1WtzNz qQNrwYEIcg/VxYGZlWox2lmqyx8kvNtKT2ADC2fo0piofn0+PCIuhv/Oz4Pgbr93pcYq zQdY5R4KCoXWM+LgSjWdbp+fn3sAx+XR1LTdkdXg0LoaXrIpWQwJ/6tZBBgcuR0ynr0a RUH8k6Pwzzah8WDDykKvyhs42Bq7fDas2P1MIHerkqjqigbeGzYzg6z6ri3bPfyXBg/i dcL0i90LWudBbElNYodWOQu4bA9pmto73spLjCKLmPyHYlEvywJ7peMqKzeEzd3bpJOn 0ccQ== X-Gm-Message-State: APjAAAW1h6mrLQk0WFHisgMuRpDQP5k7ryJVfz6nhWdu5FITstFZqFa5 OY/KLEiRbOs01CSOzXEwCI+/BMi3 X-Google-Smtp-Source: APXvYqzG+XOpS5CAQCc0nqj67CaiucsRSeyxD74wJTLFQbS0HjktGJoY5zLNuGDfv7iy72GHRG8hog== X-Received: by 2002:a1c:e455:: with SMTP id b82mr15736493wmh.41.1571074721940; Mon, 14 Oct 2019 10:38:41 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id 36sm24981585wrp.30.2019.10.14.10.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 10:38:40 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next 4/4] RDMA/qedr: Remove unsupported modify_port callback Date: Mon, 14 Oct 2019 20:38:17 +0300 Message-Id: <20191014173817.10596-5-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191014173817.10596-1-kamalheib1@gmail.com> References: <20191014173817.10596-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Signed-off-by: Kamal Heib --- drivers/infiniband/hw/qedr/main.c | 1 - drivers/infiniband/hw/qedr/verbs.c | 6 ------ drivers/infiniband/hw/qedr/verbs.h | 2 -- 3 files changed, 9 deletions(-) diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index 5136b835e1ba..e5f36adb0120 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -212,7 +212,6 @@ static const struct ib_device_ops qedr_dev_ops = { .get_link_layer = qedr_link_layer, .map_mr_sg = qedr_map_mr_sg, .mmap = qedr_mmap, - .modify_port = qedr_modify_port, .modify_qp = qedr_modify_qp, .modify_srq = qedr_modify_srq, .poll_cq = qedr_poll_cq, diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index 6f3ce86019b7..fee02ac47f32 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -250,12 +250,6 @@ int qedr_query_port(struct ib_device *ibdev, u8 port, struct ib_port_attr *attr) return 0; } -int qedr_modify_port(struct ib_device *ibdev, u8 port, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int qedr_add_mmap(struct qedr_ucontext *uctx, u64 phy_addr, unsigned long len) { diff --git a/drivers/infiniband/hw/qedr/verbs.h b/drivers/infiniband/hw/qedr/verbs.h index 9aaa90283d6e..d81b81f86f0a 100644 --- a/drivers/infiniband/hw/qedr/verbs.h +++ b/drivers/infiniband/hw/qedr/verbs.h @@ -35,8 +35,6 @@ int qedr_query_device(struct ib_device *ibdev, struct ib_device_attr *attr, struct ib_udata *udata); int qedr_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int qedr_modify_port(struct ib_device *, u8 port, int mask, - struct ib_port_modify *props); int qedr_iw_query_gid(struct ib_device *ibdev, u8 port, int index, union ib_gid *gid);