From patchwork Tue Oct 15 06:59:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 11189743 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6EFAC76 for ; Tue, 15 Oct 2019 06:59:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CE072086A for ; Tue, 15 Oct 2019 06:59:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kztX3ETP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YOT0SMP8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CE072086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=K6k40LLahMprrEwXc3dhdMiinJTJBlpfIlQibs1jOfM=; b=kzt X3ETP6kqnaBEDXV0/EYnSDyDvhUeuO+yeNVeSrnycWxeb9lb3po+LH2SKZDJboibayaedM3RSJoMW 6eqP+Kb9t9ZYQQo+sHfqOOrcEZZsbQunkTFroAlyOF0BGtEDJhTtq9BLMO4KEfXLA0jVmmrxj30FO 4SjkUPqUvi/BJUVY65042dRQfask/yXj/sKSrPoTc44xX6/OxeKp0QwyoK+esrVExQTOnDOEaeeSt 5G2317i4jhjNyZnG0NaweRZiCi0Dz0vUr9R1+rEs1+PsZseB1Hm3nW1NFFEwBC+ukZaVrPPmFTEA1 sOkTsumSmZuyikh1keBS48qsc6udFtQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKGo4-0002hL-IQ; Tue, 15 Oct 2019 06:59:44 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKGo0-0002gU-RF for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 06:59:42 +0000 Received: by mail-pf1-x444.google.com with SMTP id v4so11841120pff.6 for ; Mon, 14 Oct 2019 23:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=WEvY8mI7wziVLeSGskg+VNlvZA9UmNy6YweIvzpqB9w=; b=YOT0SMP8zAfJji7EtL9vvZypd6z4pxouSQAnJufkKRSOMQ4ymp7uwYdjKZcCXY7Zr/ vlHfrHfFTdZDS7kxk9/xC++gQjcLxWTpFf1Emh86cDYBMu9X0nyxBsOvX6zpeyDGFXg8 sHb+qmocNkSYNxf9LblfFZD/XBXqzbvc/zUvVX/hYJjquDKKTQ0o0sY4IgVjCL2LiSi8 qMPvK2TNwjKMR41GCEAWL3IiVLt/FAhHUOeXJouxPtHSvK/9eLS8eODPM1bEWkWRDHmr 1L4HLAOGKmMoAC1as61Tls400S2SuDX1FGS1HRWvfX7H83dewtHM792iH76FBZw+XJya I/DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WEvY8mI7wziVLeSGskg+VNlvZA9UmNy6YweIvzpqB9w=; b=R7X3+NOadFxyNl2als6b/97Dj9aKMnJG+E3rmeNkM0s827dp/6RAQf9Ggj1HiPwT4d 8QrjTUcF6IyE+3n1YvsFXpHRQqpdj2OpkEmBYd3gFU9vOK55RN52wnbqxNAGCBwsu73d qXEEkUEfEtmXw815zUcQbIMv0KvUNOGcPDIP7j8DCg/6twUJRuXho0yTTCHuryH42QA7 tNRzoKewvbdV562/QXIhfdDPuHH7t7y5acvx6RsP7/F4+ne7YNEgZIJVk6hTm8+MR0Cp o9HsfIYYnalfY6+yOAL+8txq68JydaVYQkA+PijuesVULiVefSdXlC1nF2MvuOCxQnlX 1jDA== X-Gm-Message-State: APjAAAUyaDoU2HYSS13nDWjqf/xv+Yf8xEeHJVOOgxOJBAvVa05uA7OZ nbaAShSsXgvsasjbM6uPoJ2i0g== X-Google-Smtp-Source: APXvYqyVgzodVpkQoZfWKsHR6n19NZcAwX3aK1+mxFq1JsBD/k0LL87kiVMZ0tTHshCDkxYoswk+bw== X-Received: by 2002:aa7:9e88:: with SMTP id p8mr38091616pfq.10.1571122779560; Mon, 14 Oct 2019 23:59:39 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id i16sm17952646pfa.184.2019.10.14.23.59.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 23:59:38 -0700 (PDT) From: Mathieu Poirier To: stable@vger.kernel.org Subject: [stable 4.19][PATCH 1/4] ARM: dts: am4372: Set memory bandwidth limit for DISPC Date: Tue, 15 Oct 2019 00:59:34 -0600 Message-Id: <20191015065937.23169-1-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_235940_907525_E15DDB88 X-CRM114-Status: UNSURE ( 8.04 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Peter Ujfalusi commit f90ec6cdf674248dcad85bf9af6e064bf472b841 upstream Set memory bandwidth limit to filter out resolutions above 720p@60Hz to avoid underflow errors due to the bandwidth needs of higher resolutions. am43xx can not provide enough bandwidth to DISPC to correctly handle 'high' resolutions. Signed-off-by: Peter Ujfalusi Signed-off-by: Tomi Valkeinen Signed-off-by: Tony Lindgren Cc: stable # 4.19 Signed-off-by: Mathieu Poirier --- arch/arm/boot/dts/am4372.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index d4b7c59eec68..cf1e4f747242 100644 --- a/arch/arm/boot/dts/am4372.dtsi +++ b/arch/arm/boot/dts/am4372.dtsi @@ -1142,6 +1142,8 @@ ti,hwmods = "dss_dispc"; clocks = <&disp_clk>; clock-names = "fck"; + + max-memory-bandwidth = <230000000>; }; rfbi: rfbi@4832a800 { From patchwork Tue Oct 15 06:59:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 11189745 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0AD8176 for ; Tue, 15 Oct 2019 06:59:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8C7E2086A for ; Tue, 15 Oct 2019 06:59:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h/ZX/3Gr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LqiY4+eT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8C7E2086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=sOR/95KT8n4e0e9dSLMXbVpEuqr7L7RZa4v/unkdjVU=; b=h/ZX/3GrTbYHWDvYB/NH3Kuwua tLR7/MhksZaWt2ZFRalkJwhezYZxy8JetCnQgQXWRMMc3xxjbCTe46Qf6nBrR/TzKYc2DQqEnqc6f LXYUfo3y9UmxskJVa3cg68js6/z6P+hXGIj0TpkSgnjNhe7h1SI4tjdXxAGCkq5B/PBOtncBrCj5R emgRHrPhHqY6he5uEURdwvhwrn7/CJg0eWCXm+hHgXiX7AxklmgwqJYp+EYycMDR+a0skByHDZZUQ A/nbATvmSQCfNBrLQ5Gs24+neosUABSCa5N1RGTNa22IEtrZ+Yy+WvAvgwihpwfQOOw9jcMnN0Tm4 bU+fOpcg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKGoH-0002qk-N2; Tue, 15 Oct 2019 06:59:57 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKGo1-0002gd-29 for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 06:59:42 +0000 Received: by mail-pf1-x444.google.com with SMTP id q21so11817991pfn.11 for ; Mon, 14 Oct 2019 23:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=s8ax0pNsjS34NQgcw7z1oLLF7sOclh4TjvoGbZiiLB8=; b=LqiY4+eTQkVeBC1lMPF7YYxbluIbw9VUU8JZtS9m6oR7ctp0sCqy0oj4hTdQIc/l15 4DKDY8XL6sekA8doxm7hTPg4AYK71o2L3A+NMbrt5Pj3intEUQQqTlIub45xUtEBQHHY uD4GaZUTARVLXiFJ2UuOxQ+Qalc/tgumAzfr1ixW/QDNGrfDlhnouuNdzqQQA78tRker NJhTGUVomZcZO0b1u18SHLHzElT0gFfFT5bFTusN5tdKNIcWQzVZ+SPUAJYdPIe4kOwX TK42n/0c8B70Kd735fQhYiGw/4K/tVRxsZFiYCozdTENJ+8gZ76uk2nf4TNCdtBx/UY7 2uHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=s8ax0pNsjS34NQgcw7z1oLLF7sOclh4TjvoGbZiiLB8=; b=unELTHBTS/pzC5h8mki+CwIJGsKIiVsASg8++9+BOHzljaJ/M2+51JYCmetgjrd9gf zB4elWiHGSGA3pGSPankhjroIrYgL66D1TJdbYjQf9LaV5NH6rJbcK1WEnaaxlAkgydo KQxe7FJn8TnuBo2RLaNVNcXkklsldu7SOqFKrPaU0fpBzWI0OejJltZ8ChvU3Xp4C8b9 stzi1X5mNBZ+cuW6hNOI/OHkoTSgG4nbYJhi3TtrN1jVmoppYTP7g1inHG3cJwurKcXS bIJfdYodqLxaqRCTp5Oz4LnSHQVVaq8tGrFLm5TrR2P4n+3w0XCW9gJHaXdcnk4tKT1i tFbw== X-Gm-Message-State: APjAAAUKBJOVl2yslhAV4CGlY5AbzVPk4L/RPbLYdkzOjwsRB5KjO4cV ierEb0UtqeLjKacUCydf6Ne9bw== X-Google-Smtp-Source: APXvYqyVrARJeunnXPSfERMIsMVbKXz1zoefqYCxcoqCdlJ+Flg5NAbVu6m+pTIqUmhkYPT5g+KCtw== X-Received: by 2002:a62:6411:: with SMTP id y17mr37212371pfb.24.1571122780487; Mon, 14 Oct 2019 23:59:40 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id i16sm17952646pfa.184.2019.10.14.23.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 23:59:39 -0700 (PDT) From: Mathieu Poirier To: stable@vger.kernel.org Subject: [stable 4.19][PATCH 2/4] ASoC: pcm3168a: The codec does not support S32_LE Date: Tue, 15 Oct 2019 00:59:35 -0600 Message-Id: <20191015065937.23169-2-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191015065937.23169-1-mathieu.poirier@linaro.org> References: <20191015065937.23169-1-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_235941_101400_21457ECD X-CRM114-Status: GOOD ( 12.51 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Peter Ujfalusi commit 7b2db65b59c30d58c129d3c8b2101feca686155a upstream 24 bits is supported in all modes and 16 bit only when the codec is slave and the DAI is set to RIGHT_J. Remove the unsupported sample format. Signed-off-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20190919071652.31724-1-peter.ujfalusi@ti.com Signed-off-by: Mark Brown Cc: stable # 4.19 Signed-off-by: Mathieu Poirier --- sound/soc/codecs/pcm3168a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index e3de1ff3b6c2..439e40245bb0 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -24,8 +24,7 @@ #define PCM3168A_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \ SNDRV_PCM_FMTBIT_S24_3LE | \ - SNDRV_PCM_FMTBIT_S24_LE | \ - SNDRV_PCM_FMTBIT_S32_LE) + SNDRV_PCM_FMTBIT_S24_LE) #define PCM3168A_FMT_I2S 0x0 #define PCM3168A_FMT_LEFT_J 0x1 From patchwork Tue Oct 15 06:59:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 11189747 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6BDD114E5 for ; Tue, 15 Oct 2019 07:00:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4938C2086A for ; Tue, 15 Oct 2019 07:00:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f3N+YQfe"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pye2eFOD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4938C2086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=jgb/PTmrOSu6euxgWAlZufThGxszz95NBGmBE7W8Jl4=; b=f3N+YQfehsg877O9Hy/nuLUDaF tncg2VyRK0W1bevZlbYgiPby48sOkBYpOws/k3trBIKlxX1z+HpnluZfmZpGYSvF5YIsoE3vxk4FS RHvp1cw2waO5+J4cFXeiXfQd5PiMpdbN4GSMqp1c2us8m7qDhVBjFlt01KfIQd6jg3RExB+gkICk3 AsDk/qE3t1KZ/xfLRn7KO5UbcR2e0cAcDfyjdaC7iX5CiAxRWCvm0EelrKu77D1UrdrAKGAaNTcnO hQADTOVu+nmalHQxA9rrHBbA/MZxgcc/Gmve6RTRlxPY2e16S4AkkLXdEWSfmsjL1J19YruV7eTyW RGW0oYgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKGoY-00037M-Fb; Tue, 15 Oct 2019 07:00:14 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKGo3-0002h5-CO for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 06:59:44 +0000 Received: by mail-pg1-x543.google.com with SMTP id p1so11537784pgi.4 for ; Mon, 14 Oct 2019 23:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=d6TuX5wbjT0cVL+CWwuFac6eFY+2DAq9db0NWeLvHfw=; b=Pye2eFODufy4FTc3Xuhtdnel9539e3atHEkUYgW5W90Gt+TPrWlJaLHjhn8B8ywWxY JoudPnOzfKiGz6r/GXUjxsc4y9rmrC8nFGkyt8fSr7TSs1mm4WMoH8rNZ0mldDmfBtk2 U1SNxtyH+z30OFykMII7vnC5xK8AngQM6Dtw8G5BPgn45gK2tBi9zBLJH1Io0eoWDHZD qy8D4/WWO0Jwnx529wxnERHIqvwFUr21JjxqduVRUwPGrduJGGtSYPoXVgxyF0mmB2Ce fAw+5B5ywpYV68NUjSKvUhv3Gtx0ZCheLTTiffLXcmdB6dzRX5oaNEvD26RWP41nZxAE q2RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=d6TuX5wbjT0cVL+CWwuFac6eFY+2DAq9db0NWeLvHfw=; b=a8zDHe2bZ6QgRI7tm8l+VFldM0JqTSMpFN+Oofitk8Wq5oRNLeJ8/11Y4hk7k5SJ1C JT9HUwqaNYWtcsZ25L8vUCDzCLDeBQPHMiOGwt5yfmPhTyfjxy5YHRno2UIdkVmXZGPU qyhxbWBx6FlrbGchhrlh+AI6UMs384bvu4+aiS0lax8eXXycKq/KVYeF7TXQU+uV5DOk ZySweifgNIJjwBgh8QzgiY/n33brrCBeaH9YBqA6tHeosO5cvRosAzNEaFYHETcQUKU/ YjbJXAn2M6ioJqWgp2NJJ0CHJ2Bv7CWFZvwy1Py4EStzAqmhMrbhioF75E6vrihVJ4VI 2i2Q== X-Gm-Message-State: APjAAAXKhfPkO5HAKj88GWHoO2OVGrchQEu+b+XKMS4yUX/4uX4LDTvx PG1zqi85A+p1yb/TBpT3iAwrUg== X-Google-Smtp-Source: APXvYqy6bs2VA4ZtJFgvxKRN0L+Ft8psiktp6GA6jTulW2YhCe3WNJiVPW4r4+fnGDmoR0/4lfTFLw== X-Received: by 2002:a62:6247:: with SMTP id w68mr37823007pfb.11.1571122782444; Mon, 14 Oct 2019 23:59:42 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id i16sm17952646pfa.184.2019.10.14.23.59.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 23:59:40 -0700 (PDT) From: Mathieu Poirier To: stable@vger.kernel.org Subject: [stable 4.19][PATCH 3/4] arm64: dts: ti: k3-am65-main: Fix gic-its node unit-address Date: Tue, 15 Oct 2019 00:59:36 -0600 Message-Id: <20191015065937.23169-3-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191015065937.23169-1-mathieu.poirier@linaro.org> References: <20191015065937.23169-1-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_235943_417243_2068F291 X-CRM114-Status: GOOD ( 11.55 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:543 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Suman Anna commit 389ce1a7c5279ebfb682fab220b4021b2bd49c8b upstream The gic-its node unit-address has an additional zero compared to the actual reg value. Fix it. Fixes: ea47eed33a3f ("arm64: dts: ti: Add Support for AM654 SoC") Reported-by: Robert Tivy Signed-off-by: Suman Anna Signed-off-by: Tero Kristo Cc: stable # 4.19 Signed-off-by: Mathieu Poirier --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index 2409344df4fa..e23c5762355d 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi @@ -21,7 +21,7 @@ */ interrupts = ; - gic_its: gic-its@18200000 { + gic_its: gic-its@1820000 { compatible = "arm,gic-v3-its"; reg = <0x01820000 0x10000>; msi-controller; From patchwork Tue Oct 15 06:59:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 11189749 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 92E3B76 for ; Tue, 15 Oct 2019 07:00:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52B422086A for ; Tue, 15 Oct 2019 07:00:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XMjAjiwM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="td8vDyR3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52B422086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=lyjdztdeqHwVpd1dh/PI9qGtMjalVEFpaweDGuw5pR8=; b=XMjAjiwMW8bM++MIWg2Kv67mZY qNhGPi6ZXupQzhF43qVq4eyyyX2/8KQ+HazKPZEkikNSag3K605kEogBdtGjnUbp7hZn6+pmj9JkU mKRUTQghw9W171sKiF8AMYbCDzOoXjLWeGqlaGYIEAMwBWzJLYOlnAhKHAOqr6lh6TIHg3t5/T2r3 LPR62UnQO/h2ev64BEU8gykrpRFKFGrxq8E5OT/nr4tSvliazGtWKSx+KFiePk2pCRSM5gjtuO15w lvhF8hkeRFBRd7WdZDqD+cHpXGZ3/1rH9TkdN56WqvutTxMDaSaubJfm9BMRODGb4HKz4IQWvgdNM fzQduvEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKGok-0003KS-QJ; Tue, 15 Oct 2019 07:00:26 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKGo4-0002hK-6f for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 06:59:46 +0000 Received: by mail-pg1-x541.google.com with SMTP id i76so11551368pgc.0 for ; Mon, 14 Oct 2019 23:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mTg0FMT6vr5u2XqGUSj/m+I5t1w5ozsNKbohqK+I32g=; b=td8vDyR3YArCs7AvGhwya+a/EH7MvQV5uULvkgZc8iUSMyZSzj/kfOFE4o8bKSjlRD Ep0bQKe7+Xm1abyFo9bhsXvg/oxXCfTs2CWuoKoSGl+KoG0bpgN13Dg96xQuzykxcKTA MWQxa32hsBFO17VdLpPpYIJKflEYr9dkiuDWgimgEG9JyNtBr25nN3m9lY93eKlEwRne o3OMq1nBUsTkAwygR7+/B1RVombnoQxYB3+Lh3/GHeAsEsIKH5h+D4oNfm9pAiS8utyS L1p8fe4A6VpA25fbfmQBUbiceQA1L7yWPiW7HCjYsvRT2rcall2pNF2fn7x1hIvBoxrf Un7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mTg0FMT6vr5u2XqGUSj/m+I5t1w5ozsNKbohqK+I32g=; b=YdIr3z5rpwFnuNMYqClY8Hth/EWIFSq/qnMeybdoTOFpLBArVpcMRTzW8BTzVg6IPu RQMGE3HB+/E8Jl7pkwdiBu6l2Ko2F6oxkxLdvxiXJ76mW0vjGT8QGfZj9wTrE6f1Tmkx SpTm7AFhgRQFrvMK7qOFf+ONT52nljX6VFLJeSYtIdWcc+NfVjIgLNNiuYTQH40nM8b2 AVcTh86UJ8FU8mXVhZ5ztLwLuteBlxp2UiVejs4yEo69dJ+zrKbnd32jKBdX9vaPJl+j lyJCeNne9I3Ds1eq1dAzlA76DuACVHGqns2u/QvVpcsjaKxBrsltmhOU6pedC5S//y8T TWyg== X-Gm-Message-State: APjAAAVRL6ix/ZjO+b1wRMQuB2q4JaXo7nnAK9N1Z5I/y6eDb4WHdWCp PyMaZoPDFDAeKsoHvIFwXYz1qQ== X-Google-Smtp-Source: APXvYqxoLX22ZMv6ADNBO+02t8Ng3OFUGaEOVWKpsG4ca9+5fEvBI/KEECsVZ2SkW2Zj9+Gej6jlpA== X-Received: by 2002:a62:e70d:: with SMTP id s13mr36572094pfh.240.1571122783277; Mon, 14 Oct 2019 23:59:43 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id i16sm17952646pfa.184.2019.10.14.23.59.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 23:59:42 -0700 (PDT) From: Mathieu Poirier To: stable@vger.kernel.org Subject: [stable 4.19][PATCH 4/4] usb: gadget: udc: core: Fix segfault if udc_bind_to_driver() for pending driver fails Date: Tue, 15 Oct 2019 00:59:37 -0600 Message-Id: <20191015065937.23169-4-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191015065937.23169-1-mathieu.poirier@linaro.org> References: <20191015065937.23169-1-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_235944_264077_27ED98B7 X-CRM114-Status: GOOD ( 14.90 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:541 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Roger Quadros commit 163be6ff7739b12ff300d77897d340f661821da2 upstream If a gadget driver is in the pending drivers list, a UDC becomes available and udc_bind_to_driver() fails, then it gets deleted from the pending list. i.e. list_del(&driver->pending) in check_pending_gadget_drivers(). Then if that gadget driver is unregistered, usb_gadget_unregister_driver() does a list_del(&driver->pending) again thus causing a page fault as that list entry has been poisoned by the previous list_del(). Fix this by using list_del_init() instead of list_del() in check_pending_gadget_drivers(). Test case: - Make sure no UDC is available - modprobe g_mass_storage file=wrongfile - Load UDC driver so it becomes available lun0: unable to open backing file: wrongfile - modprobe -r g_mass_storage [ 60.900431] Unable to handle kernel paging request at virtual address dead000000000108 [ 60.908346] Mem abort info: [ 60.911145] ESR = 0x96000044 [ 60.914227] Exception class = DABT (current EL), IL = 32 bits [ 60.920162] SET = 0, FnV = 0 [ 60.923217] EA = 0, S1PTW = 0 [ 60.926354] Data abort info: [ 60.929228] ISV = 0, ISS = 0x00000044 [ 60.933058] CM = 0, WnR = 1 [ 60.936011] [dead000000000108] address between user and kernel address ranges [ 60.943136] Internal error: Oops: 96000044 [#1] PREEMPT SMP [ 60.948691] Modules linked in: g_mass_storage(-) usb_f_mass_storage libcomposite xhci_plat_hcd xhci_hcd usbcore ti_am335x_adc kfifo_buf omap_rng cdns3 rng_core udc_core crc32_ce xfrm_user crct10dif_ce snd_so6 [ 60.993995] Process modprobe (pid: 834, stack limit = 0x00000000c2aebc69) [ 61.000765] CPU: 0 PID: 834 Comm: modprobe Not tainted 4.19.59-01963-g065f42a60499 #92 [ 61.008658] Hardware name: Texas Instruments SoC (DT) [ 61.014472] pstate: 60000005 (nZCv daif -PAN -UAO) [ 61.019253] pc : usb_gadget_unregister_driver+0x7c/0x108 [udc_core] [ 61.025503] lr : usb_gadget_unregister_driver+0x30/0x108 [udc_core] [ 61.031750] sp : ffff00001338fda0 [ 61.035049] x29: ffff00001338fda0 x28: ffff800846d40000 [ 61.040346] x27: 0000000000000000 x26: 0000000000000000 [ 61.045642] x25: 0000000056000000 x24: 0000000000000800 [ 61.050938] x23: ffff000008d7b0d0 x22: ffff0000088b07c8 [ 61.056234] x21: ffff000001100000 x20: ffff000002020260 [ 61.061530] x19: ffff0000010ffd28 x18: 0000000000000000 [ 61.066825] x17: 0000000000000000 x16: 0000000000000000 [ 61.072121] x15: 0000000000000000 x14: 0000000000000000 [ 61.077417] x13: ffff000000000000 x12: ffffffffffffffff [ 61.082712] x11: 0000000000000030 x10: 7f7f7f7f7f7f7f7f [ 61.088008] x9 : fefefefefefefeff x8 : 0000000000000000 [ 61.093304] x7 : ffffffffffffffff x6 : 000000000000ffff [ 61.098599] x5 : 8080000000000000 x4 : 0000000000000000 [ 61.103895] x3 : ffff000001100020 x2 : ffff800846d40000 [ 61.109190] x1 : dead000000000100 x0 : dead000000000200 [ 61.114486] Call trace: [ 61.116922] usb_gadget_unregister_driver+0x7c/0x108 [udc_core] [ 61.122828] usb_composite_unregister+0x10/0x18 [libcomposite] [ 61.128643] msg_cleanup+0x18/0xfce0 [g_mass_storage] [ 61.133682] __arm64_sys_delete_module+0x17c/0x1f0 [ 61.138458] el0_svc_common+0x90/0x158 [ 61.142192] el0_svc_handler+0x2c/0x80 [ 61.145926] el0_svc+0x8/0xc [ 61.148794] Code: eb03003f d10be033 54ffff21 a94d0281 (f9000420) [ 61.154869] ---[ end trace afb22e9b637bd9a7 ]--- Segmentation fault Acked-by: Alan Stern Signed-off-by: Roger Quadros Signed-off-by: Felipe Balbi Cc: stable # 4.19 Signed-off-by: Mathieu Poirier --- drivers/usb/gadget/udc/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index af88b48c1cea..b564a3251923 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1138,7 +1138,7 @@ static int check_pending_gadget_drivers(struct usb_udc *udc) dev_name(&udc->dev)) == 0) { ret = udc_bind_to_driver(udc, driver); if (ret != -EPROBE_DEFER) - list_del(&driver->pending); + list_del_init(&driver->pending); break; }