From patchwork Sat Oct 26 20:06:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Jarzmik X-Patchwork-Id: 11213833 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D75413B1 for ; Sat, 26 Oct 2019 20:08:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68BD120863 for ; Sat, 26 Oct 2019 20:08:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Y/bufzER" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68BD120863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3110918D4; Sat, 26 Oct 2019 22:07:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3110918D4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572120508; bh=gxDWjQusrh4qW5jpLFhyJvh3JqexuLNkTL5yq+Ih2Hg=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=Y/bufzER5UCsqVz/tSLzJoiwN3QRV701QXek+6P6WlWm6y5UP23sO1qsMVSwSM/IJ 9FFI7vMCuLgcVsuUG3PXJnGtTIUyyHhl3QdXUg3UP/yXmNTG44lpUtqiY9TDFOif5v WajuA1uSOIIGKQeCcrThMirRH/6IiTm5ea8QAIwM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8C7C3F800BF; Sat, 26 Oct 2019 22:07:37 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3B32EF80228; Sat, 26 Oct 2019 22:07:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=FREEMAIL_FROM, KHOP_HELO_FCRDNS, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,SPOOFED_FREEMAIL autolearn=disabled version=3.4.0 Received: from smtp.smtpout.orange.fr (smtp10.smtpout.orange.fr [80.12.242.132]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9472EF80367 for ; Sat, 26 Oct 2019 22:06:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9472EF80367 Received: from belgarion ([90.76.41.223]) by mwinf5d19 with ME id JL6B210024otT8A03L6B8P; Sat, 26 Oct 2019 22:06:12 +0200 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 26 Oct 2019 22:06:12 +0200 X-ME-IP: 90.76.41.223 From: Robert Jarzmik To: Mark Brown , Charles Keepax , patches@opensource.cirrus.com X-URL: http://belgarath.falguerolles.org/ Date: Sat, 26 Oct 2019 22:06:10 +0200 Message-ID: <87a79nqnkd.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org Subject: [alsa-devel] wm9713 regression on pxa platforms X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Wolfson maintainers, hi Mark, Recently, the wm9713 support broke on my platforms. I'm pretty sure that a previous harmless warning became an error preventing the probe of my driver (sound/soc/pxa/mioa701_wm9713.c) : the error is shown in [1] ("Control not supported"). The warning "ASoC: no dapm match for Mic B Source" has be there as far as I'm aware for ages, and it never prevented the probe before. Now, if I apply the ugly patch in [2], everything works as expected ... but that's definitely not the right fix. Would any of you be able to figure out a fix please ? Cheers. Tested-by: Robert Jarzmik diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c index 6497c1ea6228..ec140ccbab0b 100644 --- a/sound/soc/codecs/wm9713.c +++ b/sound/soc/codecs/wm9713.c @@ -630,8 +630,8 @@ static const struct snd_soc_dapm_route wm9713_audio_map[] = { {"Mic A Source", "Mic 1", "MIC1"}, {"Mic A Source", "Mic 2 A", "MIC2A"}, {"Mic A Source", "Mic 2 B", "Mic B Source"}, - {"Mic B Pre Amp", "MPB", "Mic B Source"}, - {"Mic B Source", NULL, "MIC2B"}, + /* {"Mic B Pre Amp", "MPB", "Mic B Source"}, */ + /* {"Mic B Source", NULL, "MIC2B"}, */ /* headphone capture */ {"Capture Headphone Mux", "Stereo", "Capture Mixer"},