From patchwork Thu Oct 31 18:28:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jordan Crouse X-Patchwork-Id: 11221697 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D5A3314E5 for ; Thu, 31 Oct 2019 18:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0D4821734 for ; Thu, 31 Oct 2019 18:29:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Tss01mpS"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ggGVru41" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729274AbfJaS3A (ORCPT ); Thu, 31 Oct 2019 14:29:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33632 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729149AbfJaS27 (ORCPT ); Thu, 31 Oct 2019 14:28:59 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 255E360A23; Thu, 31 Oct 2019 18:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572546538; bh=28gXZHObDLcaUnkvLy2J2bRGCEy8fMDphUJiu2quWxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tss01mpSM/zZeGnOKAGrJSCo/3ABRZg+vdOJCk63tV1ZpoYCqAQ2hfMqYwtpu1+7v LkNyjzlkAmmGWa6AF/kRj1qVztb5h8Mz+dp0etjgPHuXeozgc7/wXyFKsKwFYJCYOk b7ipUlhi4OKA6EWUIxzl1715XmMgyQu1SFJPzXMo= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 139DE60ACF; Thu, 31 Oct 2019 18:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572546537; bh=28gXZHObDLcaUnkvLy2J2bRGCEy8fMDphUJiu2quWxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ggGVru41wLxORxdTapQHvpButnQCFEmnDuZUSnnKPaLBHeBuex/sP+WIFet3z+F87 rHO4JkkJOI2mHcpCviOj+ThLpAV+BoYRKreuKTDVEHnEm3JMtVDgrMDAEJFMw1ElmB UlknnN6fsK2qY5uUF426sA+PGOHsyS/EtdNM5QTE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 139DE60ACF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org From: Jordan Crouse To: Georgi Djakov Cc: Bjorn Andersson , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org Subject: [PATCH v1 1/2] interconnect: Move interconnect drivers to core_initcall Date: Thu, 31 Oct 2019 12:28:51 -0600 Message-Id: <1572546532-19248-2-git-send-email-jcrouse@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1572546532-19248-1-git-send-email-jcrouse@codeaurora.org> References: <1572546532-19248-1-git-send-email-jcrouse@codeaurora.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The interconnect drivers are essential to nearly every leaf driver and subcomponent in the SoC. Initialize them at the core_initcall level so that they are available to their dependent drivers when built in. Signed-off-by: Jordan Crouse Reviewed-by: Bjorn Andersson --- drivers/interconnect/qcom/msm8974.c | 14 +++++++++++++- drivers/interconnect/qcom/qcs404.c | 14 +++++++++++++- drivers/interconnect/qcom/sdm845.c | 13 ++++++++++++- 3 files changed, 38 insertions(+), 3 deletions(-) diff --git a/drivers/interconnect/qcom/msm8974.c b/drivers/interconnect/qcom/msm8974.c index c70ac58..9386d5c 100644 --- a/drivers/interconnect/qcom/msm8974.c +++ b/drivers/interconnect/qcom/msm8974.c @@ -778,7 +778,19 @@ static struct platform_driver msm8974_noc_driver = { .of_match_table = msm8974_noc_of_match, }, }; -module_platform_driver(msm8974_noc_driver); + +static int __init msm8974_noc_driver_init(void) +{ + return platform_driver_register(&msm8974_noc_driver); +} +core_initcall(msm8974_noc_driver_init); + +static void __exit msm8974_noc_driver_exit(void) +{ + platform_driver_unregister(&msm8974_noc_driver); +} +module_exit(msm8974_noc_driver_exit); + MODULE_DESCRIPTION("Qualcomm MSM8974 NoC driver"); MODULE_AUTHOR("Brian Masney "); MODULE_LICENSE("GPL v2"); diff --git a/drivers/interconnect/qcom/qcs404.c b/drivers/interconnect/qcom/qcs404.c index b4966d8..7dd3e76 100644 --- a/drivers/interconnect/qcom/qcs404.c +++ b/drivers/interconnect/qcom/qcs404.c @@ -535,6 +535,18 @@ static struct platform_driver qcs404_noc_driver = { .of_match_table = qcs404_noc_of_match, }, }; -module_platform_driver(qcs404_noc_driver); + +static int __init qcs404_noc_driver_init(void) +{ + return platform_driver_register(&qcs404_noc_driver); +} +core_initcall(qcs404_noc_driver_init); + +static void __exit qcs404_noc_driver_exit(void) +{ + platform_driver_unregister(&qcs404_noc_driver); +} +module_exit(qcs404_noc_driver_exit); + MODULE_DESCRIPTION("Qualcomm QCS404 NoC driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c index 502a6c2..4dab92a 100644 --- a/drivers/interconnect/qcom/sdm845.c +++ b/drivers/interconnect/qcom/sdm845.c @@ -892,7 +892,18 @@ static struct platform_driver qnoc_driver = { .of_match_table = qnoc_of_match, }, }; -module_platform_driver(qnoc_driver); + +static int __init qnoc_driver_init(void) +{ + return platform_driver_register(&qnoc_driver); +} +core_initcall(qnoc_driver_init); + +static void __exit qnoc_driver_exit(void) +{ + platform_driver_unregister(&qnoc_driver); +} +module_exit(qnoc_driver_exit); MODULE_AUTHOR("David Dai "); MODULE_DESCRIPTION("Qualcomm sdm845 NoC driver"); From patchwork Thu Oct 31 18:28:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jordan Crouse X-Patchwork-Id: 11221699 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 523651709 for ; Thu, 31 Oct 2019 18:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FD5F217F9 for ; Thu, 31 Oct 2019 18:29:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ks8JAuSY"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ks8JAuSY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729266AbfJaS27 (ORCPT ); Thu, 31 Oct 2019 14:28:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33664 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726602AbfJaS27 (ORCPT ); Thu, 31 Oct 2019 14:28:59 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A323A60B10; Thu, 31 Oct 2019 18:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572546538; bh=H2Iz/pUnQMf04bxJGH12r7cX3YO7brMgUFKejUjQM1s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ks8JAuSYi1huOoPvddManF0RgPajJThPTbqNIc1Fl5V+fjV2V/XxThvza//5KxOKs Fl0cZiwgnXNW3/5RLwWPLP8g+dVbGdasxaJ1X6vHuak8ByeICBxaBD1vAuiNA/cpEN Ox3Hj/j/mhX/JL4hrB7F1u/uSowzKCzMpx+Hg/Ow= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E5F8C60913; Thu, 31 Oct 2019 18:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572546538; bh=H2Iz/pUnQMf04bxJGH12r7cX3YO7brMgUFKejUjQM1s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ks8JAuSYi1huOoPvddManF0RgPajJThPTbqNIc1Fl5V+fjV2V/XxThvza//5KxOKs Fl0cZiwgnXNW3/5RLwWPLP8g+dVbGdasxaJ1X6vHuak8ByeICBxaBD1vAuiNA/cpEN Ox3Hj/j/mhX/JL4hrB7F1u/uSowzKCzMpx+Hg/Ow= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E5F8C60913 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org From: Jordan Crouse To: Georgi Djakov Cc: Bjorn Andersson , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v1 2/2] interconnect: Remove unused module exit code from core Date: Thu, 31 Oct 2019 12:28:52 -0600 Message-Id: <1572546532-19248-3-git-send-email-jcrouse@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1572546532-19248-1-git-send-email-jcrouse@codeaurora.org> References: <1572546532-19248-1-git-send-email-jcrouse@codeaurora.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The interconnect core is currently always built in: menuconfig INTERCONNECT bool "On-Chip Interconnect management support" So remove the module_exit function and symbolically rename module_init to device_initcall to drive home the point. Signed-off-by: Jordan Crouse Reviewed-by: Bjorn Andersson --- drivers/interconnect/core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index c498796..61aba50 100644 --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -805,12 +805,7 @@ static int __init icc_init(void) return 0; } -static void __exit icc_exit(void) -{ - debugfs_remove_recursive(icc_debugfs_dir); -} -module_init(icc_init); -module_exit(icc_exit); +device_initcall(icc_init); MODULE_AUTHOR("Georgi Djakov "); MODULE_DESCRIPTION("Interconnect Driver Core");