From patchwork Mon Sep 17 23:10:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Um, Taeil" X-Patchwork-Id: 10603549 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 83D9A14DA for ; Mon, 17 Sep 2018 23:10:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6619F2A6CB for ; Mon, 17 Sep 2018 23:10:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 571A62A6E1; Mon, 17 Sep 2018 23:10:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C32DC2A6CB for ; Mon, 17 Sep 2018 23:10:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B43228E0039; Mon, 17 Sep 2018 19:10:51 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id AF3B08E0001; Mon, 17 Sep 2018 19:10:51 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C9048E0039; Mon, 17 Sep 2018 19:10:51 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by kanga.kvack.org (Postfix) with ESMTP id 6DD048E0001 for ; Mon, 17 Sep 2018 19:10:51 -0400 (EDT) Received: by mail-qk1-f200.google.com with SMTP id x204-v6so33698qka.6 for ; Mon, 17 Sep 2018 16:10:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:thread-topic :thread-index:date:message-id:accept-language:content-language :mime-version:precedence; bh=HSgQ70X/pkuLGonWAHtsso8X0l++KC/DbK7VtyUDXJk=; b=ud1mL2gG0R1GVSRBPC0WcIMuTcsq8bpzRPJVV4h8aHx9gKq4xu6DS5+oYVV2CEbbUt 89kW58OUP5aGvT46yS1Xd2vfBbGGRcPp51xATv/RXIRZllaOfYCM88BBkC3jsBGJKjLx FQFWlwSX1KktL6gLlKc7IOAkil++cW8cXSc87XA1AN3b7mzN5nYQCjN2wYyfEWW4j0to nxL14KmU/mlr7MgvtH9GnqqzkTQGFiKHH+K1gBLFGZ1+hgEAtJRVMZeTmz83Sx+Ne2Gd pY3wVnqi7CktHPGyMs6nDbXH8a8kx2JzXiB2vOjFDJZZw9Pt03ANuOMrS+DURTWq2CUw sgjA== X-Gm-Message-State: APzg51BQAYF4wo70wyuUTMDdtMiSDLPD+uYZGcLPW2j+xOkT+JC9FXOZ Ka/Fqvog/nlb+iNi2sMUlPxFuOHkXAxq1eO6y/J3+f2VTAXDess9n+48O/axi2r/+Flw/3CtrAL OcrVMfV1GVO1ucK0IWVnxQrVWuF2+ROgi/NNLW6IeC6EXGdpws6IHHRbsc2sEqflwRQ== X-Received: by 2002:aed:3031:: with SMTP id 46-v6mr3881530qte.29.1537225851137; Mon, 17 Sep 2018 16:10:51 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZC2V29iOot+wfKJFhjLnUiS6DjUkYY+BPKkoEmcynZPIvLroNQ6Zaa8YH+egpoWLqoAsOa X-Received: by 2002:aed:3031:: with SMTP id 46-v6mr3881513qte.29.1537225850512; Mon, 17 Sep 2018 16:10:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537225850; cv=none; d=google.com; s=arc-20160816; b=uhbqpdTgqim7Q/oRGxSX2VWOWmhJaE63fgiHFLAn54H2m8b5sawZgnu0mrxPneGk7L mZfr1kQIK8Y1Es3eL0AMD2sDQqwXYeyHBO8t7ikJlXlz7/CLZBgndOpOAnRmPQlhxZMN tSxFttMoaV+UWdeajogSdF6u1JFc2K8xzuworJIVQlZYf29H6PnibfEoTcufjw3h2jyY 0LykvoSlGNvQHJxz85IvPdQk2uIfRM/gPgDdEieBZmVWRk9NrxZKq8AafiLeeIEyQxkh pJUxBdlMp9p1g2ICUp+bxtzKvqnswdmjb1lLoOZ00oO27t0wYTY+m11Yq29uY7CYNypR t+1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=precedence:mime-version:content-language:accept-language:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=HSgQ70X/pkuLGonWAHtsso8X0l++KC/DbK7VtyUDXJk=; b=LFV3FRA+aNEcbR7jrE+Jnc+vdyA4jMv/yBMQJ+pZnhOweY1OkydqLwOkSUJ3kn1Ese VWhit2GIQTDrZuz/n0chpKtq+s/65IpBoucWWiSlE3DAoaogpgxIkKC5WaOhFL8m2q1p k+C0Csi2v5NoGAqBudyprDQFn9F/g17lGC9KafxcQE1wnBmlsWCQHgSa99wt/kUakt5S bslS4xWpUiyHgNGGKzsndEzbJWOAC6hbsJ68SSnmex5kHIzVR79egVvL4sNFC5bq5NzG jNJxBQDTADKbg6kQyhcjXCF4LWgQse5/ztv4OGtx7qCuRrpPcgnFDI+/4QTW6tNOlhZy qnhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=hU5C0ZpW; spf=pass (google.com: domain of prvs=7914b0f73=taeilum@amazon.com designates 52.95.48.154 as permitted sender) smtp.mailfrom="prvs=7914b0f73=taeilum@amazon.com"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com. [52.95.48.154]) by mx.google.com with ESMTPS id s65-v6si5858743qkf.79.2018.09.17.16.10.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Sep 2018 16:10:50 -0700 (PDT) Received-SPF: pass (google.com: domain of prvs=7914b0f73=taeilum@amazon.com designates 52.95.48.154 as permitted sender) client-ip=52.95.48.154; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=hU5C0ZpW; spf=pass (google.com: domain of prvs=7914b0f73=taeilum@amazon.com designates 52.95.48.154 as permitted sender) smtp.mailfrom="prvs=7914b0f73=taeilum@amazon.com"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1537225850; x=1568761850; h=from:to:cc:subject:date:message-id:mime-version; bh=HSgQ70X/pkuLGonWAHtsso8X0l++KC/DbK7VtyUDXJk=; b=hU5C0ZpWdxsAuaBZ7DBPyb4M+UhEBA0eEZh0FAwYUjiMyKp2Szt/eqzu TECSKZ9+ZcVFnCQ3Miy/bj2t7m04qvnq0T6ZoxoB21Jn7EyUF6Dtw7DgA /U4fZBhxkuosamnpgD2QydPhbYgT7O29CqFNfZXpNt1dXp+FhusieiIVM Y=; X-IronPort-AV: E=Sophos;i="5.53,387,1531785600"; d="scan'208,217";a="357541314" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2a-90c42d1d.us-west-2.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Sep 2018 23:10:36 +0000 Received: from EX13MTAUWC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2a-90c42d1d.us-west-2.amazon.com (8.14.7/8.14.7) with ESMTP id w8HNAZRN031596 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 17 Sep 2018 23:10:35 GMT Received: from EX13D22UWC001.ant.amazon.com (10.43.162.192) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 17 Sep 2018 23:10:35 +0000 Received: from EX13D22UWC001.ant.amazon.com (10.43.162.192) by EX13D22UWC001.ant.amazon.com (10.43.162.192) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 17 Sep 2018 23:10:35 +0000 Received: from EX13D22UWC001.ant.amazon.com ([10.43.162.192]) by EX13D22UWC001.ant.amazon.com ([10.43.162.192]) with mapi id 15.00.1367.000; Mon, 17 Sep 2018 23:10:35 +0000 From: "Um, Taeil" To: "linux-mm@kvack.org" CC: "sjenning@redhat.com" , "ddstreet@ieee.org" Subject: zswap: use PAGE_SIZE * 2 for compression dst buffer size when calling crypto compression API Thread-Topic: zswap: use PAGE_SIZE * 2 for compression dst buffer size when calling crypto compression API Thread-Index: AQHUTtuj/fwHpaXyqk+kZ8ZUnb5FUg== Date: Mon, 17 Sep 2018 23:10:35 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.160.33] MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Currently, we allocate PAGE_SIZE * 2 for zswap_dstmem which is used as compression destination buffer. However, we pass only half of the size (PAGE_SIZE) to crypto_comp_compress. This might not be a problem for CPU based existing lzo, lz4 crypto compression driver implantation. However, this could be a problem for some H/W acceleration compression drivers, which honor destination buffer size when it prepares H/W resources. Actually, this patch is aligned with what zram is passing when it calls crypto_comp_compress. The following simple patch will solve this problem. I tested it with existing crypto/lzo.c and crypto/lz4.c compression driver and it works fine. Thank you, Taeil --- mm/zswap.c.orig 2018-09-14 14:36:37.984199232 -0700 +++ mm/zswap.c 2018-09-14 14:36:53.340189681 -0700 @@ -1001,7 +1001,7 @@ static int zswap_frontswap_store(unsigne struct zswap_entry *entry, *dupentry; struct crypto_comp *tfm; int ret; - unsigned int hlen, dlen = PAGE_SIZE; + unsigned int hlen, dlen = PAGE_SIZE * 2; unsigned long handle, value; char *buf; u8 *src, *dst;