From patchwork Mon Nov 11 22:55:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ralph Campbell X-Patchwork-Id: 11237977 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 13740159A for ; Mon, 11 Nov 2019 22:56:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC55221D7F for ; Mon, 11 Nov 2019 22:56:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Z5ZYSy1n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC55221D7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0E39B6B0005; Mon, 11 Nov 2019 17:56:07 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 06D2A6B0006; Mon, 11 Nov 2019 17:56:06 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E75C46B0007; Mon, 11 Nov 2019 17:56:06 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id CD1976B0005 for ; Mon, 11 Nov 2019 17:56:06 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 9E2622C04 for ; Mon, 11 Nov 2019 22:56:06 +0000 (UTC) X-FDA: 76145506332.03.soda03_8c9467ebf5a5b X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,rcampbell@nvidia.com,:akpm@linux-foundation.org::linux-kernel@vger.kernel.org:rcampbell@nvidia.com,RULES_HIT:7522:30054:30064:30075,0,RBL:216.228.121.143:@nvidia.com:.lbl8.mailshell.net-62.18.0.100 64.10.201.10,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:ft,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: soda03_8c9467ebf5a5b X-Filterd-Recvd-Size: 3397 Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Nov 2019 22:56:05 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 11 Nov 2019 14:56:07 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 11 Nov 2019 14:56:04 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 11 Nov 2019 14:56:04 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 11 Nov 2019 22:56:04 +0000 Received: from hqnvemgw03.nvidia.com (10.124.88.68) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 11 Nov 2019 22:56:03 +0000 Received: from rcampbell-dev.nvidia.com (Not Verified[10.110.48.66]) by hqnvemgw03.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Mon, 11 Nov 2019 14:56:03 -0800 From: Ralph Campbell To: Andrew Morton CC: , , Ralph Campbell Subject: [PATCH v2] mm/debug: __dump_page() prints an extra line Date: Mon, 11 Nov 2019 14:55:59 -0800 Message-ID: <20191111225559.19657-1-rcampbell@nvidia.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-NVConfidentiality: public DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1573512967; bh=gpbb9yB97W1L8rR4vN87iKDSDQkjImhoYao2rBS6+Mw=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: MIME-Version:X-NVConfidentiality:Content-Transfer-Encoding: Content-Type; b=Z5ZYSy1nHz1eY4sGkYtLaCtuJA3ry0YzeYlFWOzyYpPHEidBitOo17CKqi6UIEoPp 0Mjd8dzxO2I23H0BMkbEsR4aQh9bIa+QUI88c5V6PBVtAHz6faMitIfSOjSuw4zNY6 z0QVol6ej4CE0pVCsS2tzZ8+CPuSTU4k4Agp2puQKmdRqrHy40K+6LIo2c0q8ayo4O yatovKD+lDwQ4zhAkUNILSoTsDizLZKgUHdKBmNgaf65TM2YW9pume3cJGaoNg5Chq w+uZAr+WhbM6sFDoSmiLYYL3KMv287K4YLnG8UgrOIDX6ReeJzD4+ptD2ZpreH4A4f 9twKWT5MEv4mg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When dumping struct page information, __dump_page() prints the page type with a trailing blank followed by the page flags on a separate line: anon flags: 0x100000000090034(uptodate|lru|active|head|swapbacked) Fix this by using pr_cont() instead of pr_warn() to get a single line: anon flags: 0x100000000090034(uptodate|lru|active|head|swapbacked) Signed-off-by: Ralph Campbell Reviewed-by: Jérôme Glisse --- v1 -> v2: Oops, fix the subject line. mm/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/debug.c b/mm/debug.c index 8345bb6e4769..752c78721ea0 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -87,7 +87,7 @@ void __dump_page(struct page *page, const char *reason) } BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1); - pr_warn("flags: %#lx(%pGp)\n", page->flags, &page->flags); + pr_cont("flags: %#lx(%pGp)\n", page->flags, &page->flags); hex_only: print_hex_dump(KERN_WARNING, "raw: ", DUMP_PREFIX_NONE, 32,