From patchwork Tue Sep 18 13:23:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kashyap Chamarthy X-Patchwork-Id: 10604327 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CBF0D15E8 for ; Tue, 18 Sep 2018 13:24:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B461A29F27 for ; Tue, 18 Sep 2018 13:24:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A6F282A71A; Tue, 18 Sep 2018 13:24:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5A5F829F27 for ; Tue, 18 Sep 2018 13:24:16 +0000 (UTC) Received: from localhost ([::1]:40375 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2FzC-0004N7-Nl for patchwork-qemu-devel@patchwork.kernel.org; Tue, 18 Sep 2018 09:24:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2FyF-0003gJ-Rk for qemu-devel@nongnu.org; Tue, 18 Sep 2018 09:23:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2FyB-0005yy-TX for qemu-devel@nongnu.org; Tue, 18 Sep 2018 09:23:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60242) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g2FyB-0005wB-Np for qemu-devel@nongnu.org; Tue, 18 Sep 2018 09:23:11 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3DCA530832E2 for ; Tue, 18 Sep 2018 13:23:09 +0000 (UTC) Received: from paraplu.localdomain (ovpn-117-164.ams2.redhat.com [10.36.117.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id D144C2015AD1; Tue, 18 Sep 2018 13:23:07 +0000 (UTC) From: Kashyap Chamarthy To: qemu-devel@nongnu.org Date: Tue, 18 Sep 2018 15:23:03 +0200 Message-Id: <20180918132303.8708-1-kchamart@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 18 Sep 2018 13:23:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kashyap Chamarthy , armbru@redhat.com, ehabkost@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Eduardo Habkost mentioned on IRC that the intended functionality of QMP 'cpu-add' is replaced with a combination of 'query-hotpluggable-cpus' and 'device_add'. And 'cpu-add' is likely to be deprecated in the future. Add a note in the QAPI schema to reflect that. Suggested-by: Eduardo Habkost --- qapi/misc.json | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/qapi/misc.json b/qapi/misc.json index d450cfef21..178a94b904 100644 --- a/qapi/misc.json +++ b/qapi/misc.json @@ -1104,7 +1104,13 @@ ## # @cpu-add: # -# Adds CPU with specified ID +# Adds CPU with specified ID. +# +# Notes: This command is likely to be deprecated in the future. The +# way to achieve the intended functionality of 'cpu-add', which +# is to allow CPU hot-plug, is possible with the combination of +# QMP 'query-hotpluggable-cpus' and 'device_add'. (And +# hot-unplug via 'device_del'.) # # @id: ID of CPU to be created, valid values [0..max_cpus) #