From patchwork Fri Dec 20 10:26:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamel BOUHARA X-Patchwork-Id: 11305149 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B06DA14F6 for ; Fri, 20 Dec 2019 10:26:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C71024680 for ; Fri, 20 Dec 2019 10:26:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PrWJMmW4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C71024680 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=xYrc558qzjtGTPE2eDzJUxEa7Ot4tY9WvFoFU8QUkjY=; b=PrWJMmW4WP2D4t UwsCH1e98zASMyYyQed/aVew1x2vQhE27MMKkDV6hA1ahDHBFqiFxpu7ynj7LU1Svx4lSRsuLMqPp r2sl0J3A9AGcpo1DlofTOsXb3FavUW2RPpHnYDwylsCUjjA1VQkhRueDFE3yKpQI5Qez6rWMNwOCL 244YqWvyDMMjQPlSsI4ld82MR8tyHSBYrsBAphZE2xUxVGggnaCOcmRE+AqS+ihU/VYAHbHJh67Ts dPp0M3JMRmc8CFNgsj347kS0u+349ytB9y5yXT5/4PRzBY4lDwXqhHGa4Q58enURq9G8gTZOPnio4 VLKTUsihZmq/Plk0M2ig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiFUm-00089U-5y; Fri, 20 Dec 2019 10:26:56 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiFUj-00088Y-Ao for linux-arm-kernel@lists.infradead.org; Fri, 20 Dec 2019 10:26:55 +0000 X-Originating-IP: 90.65.102.129 Received: from localhost (lfbn-lyo-1-1670-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: kamel.bouhara@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D9D1EE000C; Fri, 20 Dec 2019 10:26:40 +0000 (UTC) From: Kamel Bouhara To: Sebastian Reichel , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 1/2] power: reset: Introduce generic reset reason Date: Fri, 20 Dec 2019 11:26:37 +0100 Message-Id: <20191220102638.154206-1-kamel.bouhara@bootlin.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191220_022653_510571_D29CCC9E X-CRM114-Status: GOOD ( 11.02 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.196 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.196 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kamel Bouhara , Thomas Petazzoni Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This introduce some generic sources of reset reason to expose through sysfs interface. Update the ABI documentation to list current power on sources. Signed-off-by: Kamel Bouhara Acked-by: Nicolas Ferre --- Changes in v2 ============= - Be less specific on the crystal oscillator value - Add an Acked-by Changes in v3 ============= - Really be less specific on the crystal oscillator value Changes in v4 ============= - Rebase to 5.5-rc2 - Remove remaining crystal specific value in documentation - Split the patch for the sake of clarity - Match the documentation with the actual header defines Changes in v5 ============= - Reorder patches for the sake of bisectability .../sysfs-devices-platform-power-on-reason | 12 ++++++++++++ include/linux/power/power_on_reason.h | 19 +++++++++++++++++++ 2 files changed, 31 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-devices-platform-power-on-reason create mode 100644 include/linux/power/power_on_reason.h -- 2.24.0 diff --git a/Documentation/ABI/testing/sysfs-devices-platform-power-on-reason b/Documentation/ABI/testing/sysfs-devices-platform-power-on-reason new file mode 100644 index 000000000000..918ab178fee7 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-devices-platform-power-on-reason @@ -0,0 +1,12 @@ +What: /sys/devices/platform/.../power_on_reason + +Date: October 2019 +KernelVersion: 5.5 +Contact: Kamel Bouhara +Description: This file shows system power on reason. + The possible sources are: + General System Power-ON, RTC wakeup, Watchdog timeout, + Software reset, User reset button, CPU clock failure, + Oscillator Failure, Low power mode exit, Unknown. + + The file is read only. diff --git a/include/linux/power/power_on_reason.h b/include/linux/power/power_on_reason.h new file mode 100644 index 000000000000..5ef8e78f3de4 --- /dev/null +++ b/include/linux/power/power_on_reason.h @@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Author: Kamel Bouhara + */ + +#ifndef POWER_ON_REASON_H +#define POWER_ON_REASON_H + +#define POWER_ON_REASON_GENERAL "General system power-on" +#define POWER_ON_REASON_RTC "RTC wakeup" +#define POWER_ON_REASON_WATCHDOG "Watchdog timeout" +#define POWER_ON_REASON_SOFTWARE "Software reset" +#define POWER_ON_REASON_USER "User reset button" +#define POWER_ON_REASON_CPU_FAIL "CPU clock failure" +#define POWER_ON_REASON_XTAL_FAIL "Crystal oscillator failure" +#define POWER_ON_REASON_LOW_POWER "Low power mode exit" +#define POWER_ON_REASON_UNKNOWN "Unknown" + +#endif /* POWER_ON_REASON_H */ From patchwork Fri Dec 20 10:26:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamel BOUHARA X-Patchwork-Id: 11305151 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 395861892 for ; Fri, 20 Dec 2019 10:27:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 171A424680 for ; Fri, 20 Dec 2019 10:27:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ICdvWm/3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 171A424680 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SyDt5xkIDZWNqTQuPSJmL1yjP8WYv95WKUtEtOqYiT4=; b=ICdvWm/3aBFI4f isN4gZOKjBtChkONaFIsbRfsXTVi16yJ7hPCrKJOFyodxO6s51kvS6cRG0DSCO2PQvuxSA7XyxIil ox2Vo/IHfABtzmymySfMG8TciZEgIeZwM4bKUotnr0IETb2lE/80JJhJEmaCsIyjHXQPNlkjrldmB vOejwJMortlVRLoz/ZqiVYlKYV2nwywDbUY5yDbjCtQPqO4jUfGf1o/zEFNkntF+ukI06GZLw8gCv 8GIs6oh9zv4+L+2wzGvVw4HqLtRjdYLJGWtDnMqMppb315+EXA4bAf78b6DOcdwJcbtd1VprXhJja aGw98nDi0OZGBBB0zKYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiFUu-0008Hi-A3; Fri, 20 Dec 2019 10:27:04 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiFUj-00088a-Eh for linux-arm-kernel@lists.infradead.org; Fri, 20 Dec 2019 10:26:55 +0000 X-Originating-IP: 90.65.102.129 Received: from localhost (lfbn-lyo-1-1670-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: kamel.bouhara@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 1D6BB24000B; Fri, 20 Dec 2019 10:26:42 +0000 (UTC) From: Kamel Bouhara To: Sebastian Reichel , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 2/2] power: reset: at91-reset: export reset reason through sysfs Date: Fri, 20 Dec 2019 11:26:38 +0100 Message-Id: <20191220102638.154206-2-kamel.bouhara@bootlin.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191220102638.154206-1-kamel.bouhara@bootlin.com> References: <20191220102638.154206-1-kamel.bouhara@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191220_022653_762150_1B315B7F X-CRM114-Status: GOOD ( 12.37 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.193 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.193 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kamel Bouhara , Thomas Petazzoni Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Export the reset reason through a sysfs file so it can be exploited by user space application. $ cat /sys/devices/platform/ahb/ahb:apb/f8048000.rstc/power_on_reason RTC wakeup Signed-off-by: Kamel Bouhara Acked-by: Nicolas Ferre --- drivers/power/reset/at91-reset.c | 44 ++++++++++++++++++++++---------- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c index d94e3267c3b6..c1625572f07c 100644 --- a/drivers/power/reset/at91-reset.c +++ b/drivers/power/reset/at91-reset.c @@ -17,7 +17,7 @@ #include #include #include - +#include #include #include @@ -144,42 +144,42 @@ static int samx7_restart(struct notifier_block *this, unsigned long mode, return NOTIFY_DONE; } -static void __init at91_reset_status(struct platform_device *pdev) +static const char *at91_reset_reason(struct platform_device *pdev) { const char *reason; u32 reg = readl(at91_rstc_base + AT91_RSTC_SR); switch ((reg & AT91_RSTC_RSTTYP) >> 8) { case RESET_TYPE_GENERAL: - reason = "general reset"; + reason = POWER_ON_REASON_GENERAL; break; case RESET_TYPE_WAKEUP: - reason = "wakeup"; + reason = POWER_ON_REASON_RTC; break; case RESET_TYPE_WATCHDOG: - reason = "watchdog reset"; + reason = POWER_ON_REASON_WATCHDOG; break; case RESET_TYPE_SOFTWARE: - reason = "software reset"; + reason = POWER_ON_REASON_SOFTWARE; break; case RESET_TYPE_USER: - reason = "user reset"; + reason = POWER_ON_REASON_USER; break; case RESET_TYPE_CPU_FAIL: - reason = "CPU clock failure detection"; + reason = POWER_ON_REASON_CPU_FAIL; break; case RESET_TYPE_XTAL_FAIL: - reason = "32.768 kHz crystal failure detection"; + reason = POWER_ON_REASON_XTAL_FAIL; break; case RESET_TYPE_ULP2: - reason = "ULP2 reset"; + reason = POWER_ON_REASON_LOW_POWER; break; default: - reason = "unknown reset"; + reason = POWER_ON_REASON_UNKNOWN; break; } - dev_info(&pdev->dev, "Starting after %s\n", reason); + return reason; } static const struct of_device_id at91_ramc_of_match[] = { @@ -202,6 +202,17 @@ static struct notifier_block at91_restart_nb = { .priority = 192, }; +static ssize_t power_on_reason_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct platform_device *pdev = to_platform_device(dev); + + return sprintf(buf, "%s\n", at91_reset_reason(pdev)); +} + +static DEVICE_ATTR_RO(power_on_reason); + static int __init at91_reset_probe(struct platform_device *pdev) { const struct of_device_id *match; @@ -246,7 +257,14 @@ static int __init at91_reset_probe(struct platform_device *pdev) return ret; } - at91_reset_status(pdev); + ret = device_create_file(&pdev->dev, &dev_attr_power_on_reason); + if (ret) { + dev_err(&pdev->dev, "Could not create sysfs entry\n"); + return ret; + } + + dev_info(&pdev->dev, "Starting after %s reset\n", + at91_reset_reason(pdev)); return 0; }