From patchwork Fri Jan 3 21:50:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 11317487 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3FA9139A for ; Fri, 3 Jan 2020 21:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A742A222C3 for ; Fri, 3 Jan 2020 21:57:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="eGC4nYXQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728711AbgACV5v (ORCPT ); Fri, 3 Jan 2020 16:57:51 -0500 Received: from smtpcmd0997.aruba.it ([62.149.156.97]:38623 "EHLO smtpcmd0997.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728687AbgACV5v (ORCPT ); Fri, 3 Jan 2020 16:57:51 -0500 Received: from ubuntu.localdomain ([89.164.7.165]) by smtpcmd09.ad.aruba.it with bizsmtp id lxqg2101g3ZeEr501xqie8; Fri, 03 Jan 2020 22:50:43 +0100 From: Giulio Benetti To: linux-nfs@vger.kernel.org Cc: Giulio Benetti Subject: [nfs-utils PATCH 1/7] rpcgen: rpc_cout: silence unused def parameter Date: Fri, 3 Jan 2020 22:50:33 +0100 Message-Id: <20200103215039.27471-2-giulio.benetti@benettiengineering.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> References: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aruba.it; s=a1; t=1578088243; bh=8+hIwXb7lCaAPNVVeeu2ue3i/EAnwhm8pWB2k3aLIvc=; h=From:To:Subject:Date:MIME-Version; b=eGC4nYXQbGS7oNfLXr0ROZsW6javEAsmdFwGsXuc69WiZZpmn89IZwx1opsMJt6Ne DcX5CVch+JGta+NIS/LjPsmoZ64LvhqV/YnrWYuWzopS9VyZQBZZNttvhXWyoLn/HM 5qLZ6OVxrOffk5/VS5gdOUBwGcMrZAlX34HS5EO5TevldyNGwWvC6Zg+F5S5C7qDVW r3Kj8wwLkAVIHC9OgnkCKk9ECqdv91SRA2uWT/W9oprgbDf2huYY7ekIFZQNEtGNzO s+kI4WA/8KANqdex+1k2tew1JGprWtaoWyP2IJhmBmwPuOpUKJSGAlOnQJV0j5ZgNW y5QlxU5pBaUTA== Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org In emit_enum() argument def is not used and can cause a warning. So let's mark it with __attribute__((unused)). Signed-off-by: Giulio Benetti --- tools/rpcgen/rpc_cout.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/rpcgen/rpc_cout.c b/tools/rpcgen/rpc_cout.c index a61214fd..f806a86a 100644 --- a/tools/rpcgen/rpc_cout.c +++ b/tools/rpcgen/rpc_cout.c @@ -53,7 +53,7 @@ static void print_ifsizeof(char *prefix, char *type); static void print_ifclose(int indent); static void print_ifstat(int indent, char *prefix, char *type, relation rel, char *amax, char *objname, char *name); -static void emit_enum(definition *def); +static void emit_enum(__attribute__((unused)) definition *def); static void emit_program(definition *def); static void emit_union(definition *def); static void emit_struct(definition *def); @@ -286,7 +286,7 @@ print_ifstat(int indent, char *prefix, char *type, relation rel, } static void -emit_enum(definition *def) +emit_enum(__attribute__((unused)) definition *def) { print_ifopen(1, "enum"); print_ifarg("(enum_t *)objp"); From patchwork Fri Jan 3 21:50:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 11317485 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B85217F0 for ; Fri, 3 Jan 2020 21:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A817222C3 for ; Fri, 3 Jan 2020 21:57:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="ld71bdkZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728698AbgACV5v (ORCPT ); Fri, 3 Jan 2020 16:57:51 -0500 Received: from smtpcmd0997.aruba.it ([62.149.156.97]:57371 "EHLO smtpcmd0997.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728711AbgACV5u (ORCPT ); Fri, 3 Jan 2020 16:57:50 -0500 Received: from ubuntu.localdomain ([89.164.7.165]) by smtpcmd09.ad.aruba.it with bizsmtp id lxqg2101g3ZeEr501xqjeE; Fri, 03 Jan 2020 22:50:44 +0100 From: Giulio Benetti To: linux-nfs@vger.kernel.org Cc: Giulio Benetti Subject: [nfs-utils PATCH 2/7] rpcgen: rpc_util: add storeval args to prototype Date: Fri, 3 Jan 2020 22:50:34 +0100 Message-Id: <20200103215039.27471-3-giulio.benetti@benettiengineering.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> References: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aruba.it; s=a1; t=1578088244; bh=IpcO46TGeUmpVcbjgafphEj0IzPX776wcDD92508DLg=; h=From:To:Subject:Date:MIME-Version; b=ld71bdkZ3EJUVCx+xzolO4g2IZtdj/NOeZD4jxPQBiglu7Wc+P6yK/JMvPBOg+sla hlxnTTIeFRDS/kxRm0eBtSzV3d2HFxD5fEKRw1ohlQ7bRfl0KomwZJPrzlLwA1ERDM ahjzywHZe0cV1nyFKpg3I6I+/gnqUzOOqpey8qedQIXSS7CwQIA/Nn+CKm63aiDpg7 stcjletpeXdg2SkER7kB/LeaXnUQv+LHRdjwHqTzrMWRI7y1Hl02cBgOryK+rXdIl8 qkekgWKpEhuuYb56SdijTPe1wP2NtbZEt+fplmkCCSWHoqH6eY0R5tS6cNR2gyNa/s cxrGY4NlHMZrQ== Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org storeval() prototype has no arguments and this can cause warnings during building. Let's add its arguments to prototype according to its implementation. Signed-off-by: Giulio Benetti --- tools/rpcgen/rpc_util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/rpcgen/rpc_util.h b/tools/rpcgen/rpc_util.h index fa115bee..bd7b15ca 100644 --- a/tools/rpcgen/rpc_util.h +++ b/tools/rpcgen/rpc_util.h @@ -91,7 +91,7 @@ extern int nonfatalerrors; /* * rpc_util routines */ -void storeval(); +void storeval(list **, definition *); #define STOREVAL(list,item) \ storeval(list,item) From patchwork Fri Jan 3 21:50:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 11317481 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B6C4C17F0 for ; Fri, 3 Jan 2020 21:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BFAD22314 for ; Fri, 3 Jan 2020 21:57:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="kaeyVWbu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728549AbgACV5u (ORCPT ); Fri, 3 Jan 2020 16:57:50 -0500 Received: from smtpcmd0997.aruba.it ([62.149.156.97]:36892 "EHLO smtpcmd0997.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728645AbgACV5t (ORCPT ); Fri, 3 Jan 2020 16:57:49 -0500 Received: from ubuntu.localdomain ([89.164.7.165]) by smtpcmd09.ad.aruba.it with bizsmtp id lxqg2101g3ZeEr501xqkeJ; Fri, 03 Jan 2020 22:50:44 +0100 From: Giulio Benetti To: linux-nfs@vger.kernel.org Cc: Giulio Benetti Subject: [nfs-utils PATCH 3/7] rpcgen: rpc_util: add findval args to prototype Date: Fri, 3 Jan 2020 22:50:35 +0100 Message-Id: <20200103215039.27471-4-giulio.benetti@benettiengineering.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> References: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aruba.it; s=a1; t=1578088244; bh=LndOWQbqWbE+/mh+Q/OA/ILl2X9Qt+5deLE0twnuW1o=; h=From:To:Subject:Date:MIME-Version; b=kaeyVWbu1lhrtBeO+Gu44xTuz+179ny+G2CqOZ1rlfTMqkh4UzOcz7GqN+5YDi6rX BIJ3K0WqnC5+ykj6Ttttkakj+BpnLycNZ0qziaaaNdxmwUcj+mjwuppnCYXhekG34O 3GBwnYsetDqWFt7d2KfvowcL52wF3P1vvaVdQmh4wCLihfgl3GUIokLgJuEXe3Er6C Dkjm59s9Kd2+oU7DHi6Z66Mk3eYi1a71VdglDNEhI/+pIw75qBG41aARwPHVsOWR/p 4NU0Df6hKnCdf0v5rV4dLQQaLRFEDeaMczykHEv+Mirq7+h3AiiE7em8PEPLtI9izo EIhA3WdXrQVng== Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org findval() prototype has no arguments and this can cause warnings during building. Let's add its arguments to prototype according to its implementation. Signed-off-by: Giulio Benetti --- tools/rpcgen/rpc_util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/rpcgen/rpc_util.h b/tools/rpcgen/rpc_util.h index bd7b15ca..97b87f2b 100644 --- a/tools/rpcgen/rpc_util.h +++ b/tools/rpcgen/rpc_util.h @@ -96,7 +96,7 @@ void storeval(list **, definition *); #define STOREVAL(list,item) \ storeval(list,item) -definition *findval(); +definition *findval(list *, char *, int (*)(definition *, char *)); #define FINDVAL(list,item,finder) \ findval(list, item, finder) From patchwork Fri Jan 3 21:50:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 11317483 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 22B9F139A for ; Fri, 3 Jan 2020 21:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0275C222C3 for ; Fri, 3 Jan 2020 21:57:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="J1JupHu1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728645AbgACV5v (ORCPT ); Fri, 3 Jan 2020 16:57:51 -0500 Received: from smtpcmd0997.aruba.it ([62.149.156.97]:53995 "EHLO smtpcmd0997.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728698AbgACV5u (ORCPT ); Fri, 3 Jan 2020 16:57:50 -0500 Received: from ubuntu.localdomain ([89.164.7.165]) by smtpcmd09.ad.aruba.it with bizsmtp id lxqg2101g3ZeEr501xqleL; Fri, 03 Jan 2020 22:50:46 +0100 From: Giulio Benetti To: linux-nfs@vger.kernel.org Cc: Giulio Benetti Subject: [nfs-utils PATCH 4/7] rpcgen: rpc_parse: add get_definition() void argument Date: Fri, 3 Jan 2020 22:50:36 +0100 Message-Id: <20200103215039.27471-5-giulio.benetti@benettiengineering.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> References: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aruba.it; s=a1; t=1578088246; bh=s0/vXAJf5ErPcbRliVgrliOraulwcqeXI6IUq9DwmCc=; h=From:To:Subject:Date:MIME-Version; b=J1JupHu1xBJUOOP5dTV2vlIU7qv8tmfSVyGmsksaeSI/0NHf9+wRZsWZPQjTCqPpl jlDkGp+/41BCFdfyy8Hr61PC1f/qmriBazUM/f5wNcZL3sZqaJpKYXFW9eBQBRLSRz fckffpa9nwacVuCR0YZFBnNk+ObFUyMJ4KqFRONWnXXsf29UqAZ2usA1WIsZkMb72v klg2Zi1xbW0ct8mkLmtGtQ4w5e5GW8emmvSrMhxuxTQlPCa4iQfOhEdal1xxzch/x2 JrwjXNVn5+kwxIByKegeWwjvc8RXXc8ll6pP1NHnmD+tZtm8hZwqCxclbiTFpQeo+k FyPTFSCnkSi7w== Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org get_definition() prototype has no arguments and this can cause warnings during building. Let's add void argument to prototype according to its implementation. Signed-off-by: Giulio Benetti --- tools/rpcgen/rpc_parse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/rpcgen/rpc_parse.h b/tools/rpcgen/rpc_parse.h index 2afae104..6c134dd8 100644 --- a/tools/rpcgen/rpc_parse.h +++ b/tools/rpcgen/rpc_parse.h @@ -153,7 +153,7 @@ struct definition { }; typedef struct definition definition; -definition *get_definition(); +definition *get_definition(void); struct bas_type From patchwork Fri Jan 3 21:50:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 11317493 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7B0BC139A for ; Fri, 3 Jan 2020 21:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50879222C3 for ; Fri, 3 Jan 2020 21:57:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="hYuLg/ES" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728716AbgACV5y (ORCPT ); Fri, 3 Jan 2020 16:57:54 -0500 Received: from smtpcmd0997.aruba.it ([62.149.156.97]:60290 "EHLO smtpcmd0997.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728721AbgACV5x (ORCPT ); Fri, 3 Jan 2020 16:57:53 -0500 X-Greylist: delayed 425 seconds by postgrey-1.27 at vger.kernel.org; Fri, 03 Jan 2020 16:57:48 EST Received: from ubuntu.localdomain ([89.164.7.165]) by smtpcmd09.ad.aruba.it with bizsmtp id lxqg2101g3ZeEr501xqmeU; Fri, 03 Jan 2020 22:50:46 +0100 From: Giulio Benetti To: linux-nfs@vger.kernel.org Cc: Giulio Benetti Subject: [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning Date: Fri, 3 Jan 2020 22:50:37 +0100 Message-Id: <20200103215039.27471-6-giulio.benetti@benettiengineering.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> References: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aruba.it; s=a1; t=1578088246; bh=1jMLJeansiaM1gzNPiE3UcK3x2BfjS24fO6axf3XLl8=; h=From:To:Subject:Date:MIME-Version; b=hYuLg/ESNRPZSphnquikYioS4liuob/oVdKIjXjZse/ohK8Lw2HsFXdDW+4AstGvX Q2n+rQwcRrTeDdK5csMZ7nO3fVQQS6uvKFeRvG8EqxZPip9Ud6CqDB4lFBP1utXmOo C9J7CW1+7VumvGkNsQ09hknzMujEiEu2ZeFfBJMZ+7JKAZy0R3qobIb33WiLr6EEf0 FN+6pUZQy4GSnvs/2DZ6ngqnbk41I/tHIT+gZe3iDs+Ap9Pup9Gkg6XKnCwLonkk88 uS+tcJ1bX0qe2wUlhLdx8EA4Tf/EvPMr61LfMruKyEOAa9mIvbtS3LvmVXOisLHa8v R3lq3oQj2h/dg== Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org format and vecformat must be declared as "char * const" to be really treated as constant when building with -Werror=format-nonliteral, otherwise compiler will consider them subject to change throughout the function. Signed-off-by: Giulio Benetti --- tools/rpcgen/rpc_cout.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/rpcgen/rpc_cout.c b/tools/rpcgen/rpc_cout.c index f806a86a..df2609c4 100644 --- a/tools/rpcgen/rpc_cout.c +++ b/tools/rpcgen/rpc_cout.c @@ -319,8 +319,8 @@ emit_union(definition *def) case_list *cl; declaration *cs; char *object; - char *vecformat = "objp->%s_u.%s"; - char *format = "&objp->%s_u.%s"; + char * const vecformat = "objp->%s_u.%s"; + char * const format = "&objp->%s_u.%s"; print_stat(1,&def->def.un.enum_decl); f_print(fout, "\tswitch (objp->%s) {\n", def->def.un.enum_decl.name); From patchwork Fri Jan 3 21:50:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 11317489 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2B9B3139A for ; Fri, 3 Jan 2020 21:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01B40222C3 for ; Fri, 3 Jan 2020 21:57:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="h+sPkL+G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728730AbgACV5x (ORCPT ); Fri, 3 Jan 2020 16:57:53 -0500 Received: from smtpcmd0997.aruba.it ([62.149.156.97]:36892 "EHLO smtpcmd0997.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728687AbgACV5x (ORCPT ); Fri, 3 Jan 2020 16:57:53 -0500 Received: from ubuntu.localdomain ([89.164.7.165]) by smtpcmd09.ad.aruba.it with bizsmtp id lxqg2101g3ZeEr501xqnea; Fri, 03 Jan 2020 22:50:47 +0100 From: Giulio Benetti To: linux-nfs@vger.kernel.org Cc: Giulio Benetti Subject: [nfs-utils PATCH 6/7] rpcgen: rpc_hout: fix potential -Wformat-security warning Date: Fri, 3 Jan 2020 22:50:38 +0100 Message-Id: <20200103215039.27471-7-giulio.benetti@benettiengineering.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> References: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aruba.it; s=a1; t=1578088247; bh=HJCLC7zorNQ4sSP6DKe+6nRgQRhpIZr7UMLE4eDaAyc=; h=From:To:Subject:Date:MIME-Version; b=h+sPkL+GTOkLwbhpKS9N5fogkeVDzVN+mrHX3yBzcvzhDArkC1Hu2QdRwxod2/iIx 3bNArfbV+nrSQBS9veQ9NHo49l5j1AFos9+nTVKwvGC5UB9jXTvi9hHiVVHVGwcWCa HFalRbEMWizXqgOmJ2Ewm1wAU+idqfJCAWgTYxIgqhBpijm5p2xmxxBTN85wrMZiYz EnRC96Ceqw74InqT6IWx7JON4xr8Cm/WZQ0DHswQE0XQlrUTQW8JhF/FDRtdCJ4lz2 OzSGVabWUUfVHA/gp37a/CEvoIEUtakhWcybctN8w+niqZMdtHzYeE7H0aD+aHyeYo RmiknN6jsky5g== Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org f_print()'s argument "separator" is not known because it's passed as an argument and with -Wformat-security will cause a useless warning. Let's ignore by adding "#pragma GCC diagnostic ignored/warning" before and after f_print(). Signed-off-by: Giulio Benetti --- tools/rpcgen/rpc_hout.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/rpcgen/rpc_hout.c b/tools/rpcgen/rpc_hout.c index ea1cb24f..999c061f 100644 --- a/tools/rpcgen/rpc_hout.c +++ b/tools/rpcgen/rpc_hout.c @@ -467,7 +467,9 @@ pdeclaration(char *name, declaration *dec, int tab, char *separator) break; } } +#pragma GCC diagnostic ignored "-Wformat-security" f_print(fout, separator ); +#pragma GCC diagnostic warning "-Wformat-security" } static int From patchwork Fri Jan 3 21:50:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 11317491 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D2CF217F0 for ; Fri, 3 Jan 2020 21:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B226E222C3 for ; Fri, 3 Jan 2020 21:57:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="VATCRjFY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728687AbgACV5x (ORCPT ); Fri, 3 Jan 2020 16:57:53 -0500 Received: from smtpcmd0997.aruba.it ([62.149.156.97]:57371 "EHLO smtpcmd0997.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728716AbgACV5x (ORCPT ); Fri, 3 Jan 2020 16:57:53 -0500 Received: from ubuntu.localdomain ([89.164.7.165]) by smtpcmd09.ad.aruba.it with bizsmtp id lxqg2101g3ZeEr501xqnee; Fri, 03 Jan 2020 22:50:48 +0100 From: Giulio Benetti To: linux-nfs@vger.kernel.org Cc: Giulio Benetti Subject: [nfs-utils PATCH 7/7] rpcgen: rpc_hout: fix indentation on f_print() argument separator Date: Fri, 3 Jan 2020 22:50:39 +0100 Message-Id: <20200103215039.27471-8-giulio.benetti@benettiengineering.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> References: <20200103215039.27471-1-giulio.benetti@benettiengineering.com> MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aruba.it; s=a1; t=1578088248; bh=rtzQ93BPe1MzD6QNoaREvwNimkV8DY1BsJDtAB87oIs=; h=From:To:Subject:Date:MIME-Version; b=VATCRjFYmPLeVafvj8WGdPxGj23Lab+w3JdSrLmNsC4Pk+0N7ZQB8lePMNCi3Weg0 IlrC25r4BUHBMj73uCGHtSEu+M2cHAucf/wRbewZF6NHJhRYYKmpy8lWdI0lkoh03r bKqGxkaAn73jLgFlJNNO431CMRkxth/5A8Zzbr+MFPm9pG91nKwFieSSrgEiCD15OD B3xTPZDZmwzEClxYTTMVtg8r/kqdMOJY9bLw0xrFNLoeHxZwNObqYJscvSjCi03EwE wnPuQyP7b0JhH/BgQgIIMDLZ0SPvRfBOpeF4oDQ7NI17WgeAJrqnoJaPpxY3mh7OeU HzlEBtmSErcPQ== Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Remove useless space before closing parenthesys. Signed-off-by: Giulio Benetti --- tools/rpcgen/rpc_hout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/rpcgen/rpc_hout.c b/tools/rpcgen/rpc_hout.c index 999c061f..ed668778 100644 --- a/tools/rpcgen/rpc_hout.c +++ b/tools/rpcgen/rpc_hout.c @@ -468,7 +468,7 @@ pdeclaration(char *name, declaration *dec, int tab, char *separator) } } #pragma GCC diagnostic ignored "-Wformat-security" - f_print(fout, separator ); + f_print(fout, separator); #pragma GCC diagnostic warning "-Wformat-security" }