From patchwork Tue Jan 21 09:28:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miroslav Rezanina X-Patchwork-Id: 11343247 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E5B161398 for ; Tue, 21 Jan 2020 09:30:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB52322522 for ; Tue, 21 Jan 2020 09:30:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZGZtCSyr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB52322522 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:50492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itprn-0007rY-QS for patchwork-qemu-devel@patchwork.kernel.org; Tue, 21 Jan 2020 04:30:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58314) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itpph-0005Jk-Vh for qemu-devel@nongnu.org; Tue, 21 Jan 2020 04:28:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itppg-0001ma-WE for qemu-devel@nongnu.org; Tue, 21 Jan 2020 04:28:25 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:29572 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itppg-0001mQ-T5 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 04:28:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579598904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:in-reply-to:references:references:references; bh=tLxyOeT3VL5PaRjCIKPmBGFw0DadvQA+VbCzoFlCEFQ=; b=ZGZtCSyrfJxwk2GUGz8wvpVlGHOvuxUU/iTljLnDW9xz+RtxbDHeXMZxrfxXPY0Mf5bs0i qPf8g7MHj7eolgFPjJWPLgN0KkRmCTSlcNPHAfzDsuflR7QfUAYLrW/rB6DzIvyHwu9kzV pa0jNb/VH7/hxUisIjNw7I+xzxVu3qA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-87-MjGylKfNNg6d1zNdVMgZSA-1; Tue, 21 Jan 2020 04:28:20 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0FF6618FF662; Tue, 21 Jan 2020 09:28:19 +0000 (UTC) Received: from workimage.localdomain (ovpn-204-25.brq.redhat.com [10.40.204.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF2635DA66; Tue, 21 Jan 2020 09:28:17 +0000 (UTC) From: mrezanin@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH 1/2] test-logging: Fix -Werror=maybe-uninitialized warning Date: Tue, 21 Jan 2020 10:28:13 +0100 Message-Id: <63b0fcedf7dfe799c8210b113e5dccf32414a89d.1579598240.git.mrezanin@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: MjGylKfNNg6d1zNdVMgZSA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Miroslav Rezanina Checking for uninitialized variables raises warning for file path variables in test_logfile_write and test_logfile_lock functions. To suppress this warning, initialize varibles to NULL. This is safe change as result of g_build_filename is stored to them before any usage. Signed-off-by: Miroslav Rezanina Reviewed-by: Thomas Huth Reviewed-by: Robert Foley --- tests/test-logging.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-logging.c b/tests/test-logging.c index 1e646f0..6387e49 100644 --- a/tests/test-logging.c +++ b/tests/test-logging.c @@ -114,8 +114,8 @@ static void test_logfile_write(gconstpointer data) QemuLogFile *logfile2; gchar const *dir = data; Error *err = NULL; - g_autofree gchar *file_path; - g_autofree gchar *file_path1; + g_autofree gchar *file_path = NULL; + g_autofree gchar *file_path1 = NULL; FILE *orig_fd; /* @@ -157,7 +157,7 @@ static void test_logfile_lock(gconstpointer data) FILE *logfile; gchar const *dir = data; Error *err = NULL; - g_autofree gchar *file_path; + g_autofree gchar *file_path = NULL; file_path = g_build_filename(dir, "qemu_test_logfile_lock0.log", NULL); From patchwork Tue Jan 21 09:28:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miroslav Rezanina X-Patchwork-Id: 11343245 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 86E876C1 for ; Tue, 21 Jan 2020 09:29:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D2FE24125 for ; Tue, 21 Jan 2020 09:29:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a8Q/7wj+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D2FE24125 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:50454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itpqY-0006Hm-7z for patchwork-qemu-devel@patchwork.kernel.org; Tue, 21 Jan 2020 04:29:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58325) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itppr-0005QJ-I1 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 04:28:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itppq-0001pu-KH for qemu-devel@nongnu.org; Tue, 21 Jan 2020 04:28:35 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:31093 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itppq-0001pc-GV for qemu-devel@nongnu.org; Tue, 21 Jan 2020 04:28:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579598913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:in-reply-to:references:references:references; bh=pYodZQXMhVcIrB+en2M7QyjxGrpL1f1tVGXYrbtpSS8=; b=a8Q/7wj+7zycuKqrljd8Hp2rHMqnHdfEvRZvjJ996k1DI2oK5BfV+74pgMAVaUZcMZUsiF IYQYFXLGaYyD32vTrisRlIFmBYUSzueZTmSh8NWgMEbeyBwer5/q/urUIuHkZ9wvmCcxIx xyZMlKvBtPkqkZbW7ifKkMh/1dFBjMI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-GUwCQjCsNrKSYU1FQZsDcA-1; Tue, 21 Jan 2020 04:28:21 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90CF4DB62; Tue, 21 Jan 2020 09:28:20 +0000 (UTC) Received: from workimage.localdomain (ovpn-204-25.brq.redhat.com [10.40.204.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F1915DA66; Tue, 21 Jan 2020 09:28:19 +0000 (UTC) From: mrezanin@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH 2/2] aspeed/i2c: Prevent uninitialized warning Date: Tue, 21 Jan 2020 10:28:14 +0100 Message-Id: <07957dcab31f65de3dd30efa91e6b9152ac79879.1579598240.git.mrezanin@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: GUwCQjCsNrKSYU1FQZsDcA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Miroslav Rezanina Compiler reports uninitialized warning for cmd_flags variable. Adding NULL initialization to prevent this warning. Signed-off-by: Miroslav Rezanina Reviewed-by: Thomas Huth --- hw/i2c/aspeed_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 2da04a4..445182a 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -400,7 +400,7 @@ static bool aspeed_i2c_check_sram(AspeedI2CBus *bus) static void aspeed_i2c_bus_cmd_dump(AspeedI2CBus *bus) { - g_autofree char *cmd_flags; + g_autofree char *cmd_flags = NULL; uint32_t count; if (bus->cmd & (I2CD_RX_BUFF_ENABLE | I2CD_RX_BUFF_ENABLE)) {