From patchwork Mon Feb 3 01:17:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chanwoo Choi X-Patchwork-Id: 11361963 X-Patchwork-Delegate: cw00.choi@samsung.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6032B1395 for ; Mon, 3 Feb 2020 01:10:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 232AE20679 for ; Mon, 3 Feb 2020 01:10:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="bCXDsABT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbgBCBJy (ORCPT ); Sun, 2 Feb 2020 20:09:54 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:24045 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726637AbgBCBJx (ORCPT ); Sun, 2 Feb 2020 20:09:53 -0500 Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20200203010950epoutp02992b40231972e9b1e5d0bb8308b51fd0~vvywEU1OC0073600736epoutp02e for ; Mon, 3 Feb 2020 01:09:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20200203010950epoutp02992b40231972e9b1e5d0bb8308b51fd0~vvywEU1OC0073600736epoutp02e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1580692190; bh=RQmoYEoCJrDBF3NGfioncJhLMZZJauhsFwOd7mIxRXM=; h=From:To:Cc:Subject:Date:References:From; b=bCXDsABTnWEFcAxUQsQJq/7EV70umTAyUXu588p9iVCMNFr9sCyXvQxQ3jgN3XvDM XtQGVGWoXnJ8wBTToHB1xOZeyKeP+X256aVFFZPSB7vwXUPzlbiKJDxi5bifvI3gCp 23N9ngNgRbU/mIrnQvmYkHza2ENWFANHGbdjF+5A= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20200203010949epcas1p1f651a0db3b1df904e13505c51da40343~vvyvheIRl1965619656epcas1p1G; Mon, 3 Feb 2020 01:09:49 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.40.158]) by epsnrtp2.localdomain (Postfix) with ESMTP id 489qVf66j2zMqYkX; Mon, 3 Feb 2020 01:09:46 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id BD.61.48498.AD2773E5; Mon, 3 Feb 2020 10:09:46 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200203010946epcas1p16010f3f1e5b079927bd81b8e70c0a015~vvys0R2Y-0039600396epcas1p1v; Mon, 3 Feb 2020 01:09:46 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200203010946epsmtrp1d46994cbbe3a0a22910605e48f1727c7~vvyszPEC41442914429epsmtrp1L; Mon, 3 Feb 2020 01:09:46 +0000 (GMT) X-AuditID: b6c32a36-a55ff7000001bd72-4e-5e3772da08a2 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id F0.AE.06569.AD2773E5; Mon, 3 Feb 2020 10:09:46 +0900 (KST) Received: from localhost.localdomain (unknown [10.113.221.102]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200203010946epsmtip2332d592caf87478db944e064894428e9~vvysoH5j72257522575epsmtip2O; Mon, 3 Feb 2020 01:09:46 +0000 (GMT) From: Chanwoo Choi To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: cw00.choi@samsung.com, chanwoo@kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, lukasz.luba@arm.com Subject: [PATCHv2 1/2] PM / devfreq: Remove unneeded extern keyword Date: Mon, 3 Feb 2020 10:17:32 +0900 Message-Id: <20200203011733.7639-1-cw00.choi@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGKsWRmVeSWpSXmKPExsWy7bCmnu6tIvM4g0d/9S0m3rjCYnH9y3NW i7NNb9gtLu+aw2bxufcIo8XCphZ2i9uNK9gc2D3WzFvD6LFpVSebR9+WVYwenzfJBbBEZdtk pCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAF2gpFCWmFMK FApILC5W0rezKcovLUlVyMgvLrFVSi1IySmwLNArTswtLs1L10vOz7UyNDAwMgUqTMjO+LP4 LHtBs0PF0cbDzA2MF0y6GDk5JARMJHp27GDvYuTiEBLYwSjxeMlJFpCEkMAnRoneOwUQiW+M Es0Tr7DCdEzv2sQMUbSXUeLgOTWIoi+MEi0LO5lAEmwCWhL7X9xgA7FFBKwkTv/vAGtgFqiU +HLuKNggYQFnib6DnWA1LAKqEk3fDoPFeQUsJY7ffskIsUxeYvWGA8wgCyQE/rJKPJq0CSrh IvHjUh8ThC0s8er4FnYIW0riZX8blF0tsfLkETaI5g5GiS37L0C9YCyxf+lkoGYOoIs0Jdbv 0ocIK0rs/D2XEeJQPol3X3tYQUokBHglOtqEIEqUJS4/uAu1VlJicTvI/SAlHhIthyMhYRIr MaHzAeMERtlZCPMXMDKuYhRLLSjOTU8tNiwwQo6jTYzgNKVltoNx0TmfQ4wCHIxKPLwzHprF CbEmlhVX5h5ilOBgVhLhrbMyjRPiTUmsrEotyo8vKs1JLT7EaAoMvInMUqLJ+cAUmlcSb2hq ZGxsbGFiaGZqaKgkzvswUjNOSCA9sSQ1OzW1ILUIpo+Jg1OqgVFYUVG2NFPGJ0Tp15KLbCfe deztyP/4f/4dzcOH2WPqrBssl0y8bHpI77+imvLs+gD9wrP9C+rb1vmbTXstGzKn+enOm7oK s/WKfRWEla/pfnkn9pjpoJLDIx9l7nn3dkkGqoe3NOjNlHtszelpaCIZprhSQPJhVjpfn/q5 M2sfLTttuPV8ihJLcUaioRZzUXEiANHsN5lpAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjluLIzCtJLcpLzFFi42LZdlhJXvdWkXmcwfLtMhYTb1xhsbj+5Tmr xdmmN+wWl3fNYbP43HuE0WJhUwu7xe3GFWwO7B5r5q1h9Ni0qpPNo2/LKkaPz5vkAliiuGxS UnMyy1KL9O0SuDL+LD7LXtDsUHG08TBzA+MFky5GTg4JAROJ6V2bmLsYuTiEBHYzSrSvvs4O kZCUmHbxKFCCA8gWljh8uBii5hOjxP6+ecwgNWwCWhL7X9xgA7FFBGwk7i6+xgJiMwvUS7Sd 2Q82R1jAWaLvYCdYDYuAqkTTt8OsIDavgKXE8dsvGSF2yUus3nCAeQIjzwJGhlWMkqkFxbnp ucWGBUZ5qeV6xYm5xaV56XrJ+bmbGMGho6W1g/HEifhDjAIcjEo8vDMemsUJsSaWFVfmHmKU 4GBWEuGtszKNE+JNSaysSi3Kjy8qzUktPsQozcGiJM4rn38sUkggPbEkNTs1tSC1CCbLxMEp 1cBoLfkgdrJMRsztrVcYefR8CyyKz1ZM3MK0JVNHasJmXh6JgEcL6y3nWsvsLAv/P9G7X3D+ t6h/a2T3v3+YZcuspyIoJ8XfOMFE+zj/iydeN+yL3vWq6Z90+MxY45vaHlW+YZ70jfMVZuHG GmVTps5rWqdtd1TfouNpVePKyitWUjcniCfvnq/EUpyRaKjFXFScCAC3ZZyxGQIAAA== X-CMS-MailID: 20200203010946epcas1p16010f3f1e5b079927bd81b8e70c0a015 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200203010946epcas1p16010f3f1e5b079927bd81b8e70c0a015 References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Remove unneeded extern keyword from devfreq-related header file and adjust the indentation of function parameter to keep the consistency in header file Reviewed-by: Lukasz Luba Signed-off-by: Chanwoo Choi --- Changes from v1: - Add reviewed tag of Lukasz drivers/devfreq/governor.h | 17 +++---- include/linux/devfreq.h | 100 ++++++++++++++++++------------------- 2 files changed, 57 insertions(+), 60 deletions(-) diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h index dc7533ccc3db..5ba3e051b1d0 100644 --- a/drivers/devfreq/governor.h +++ b/drivers/devfreq/governor.h @@ -57,17 +57,16 @@ struct devfreq_governor { unsigned int event, void *data); }; -extern void devfreq_monitor_start(struct devfreq *devfreq); -extern void devfreq_monitor_stop(struct devfreq *devfreq); -extern void devfreq_monitor_suspend(struct devfreq *devfreq); -extern void devfreq_monitor_resume(struct devfreq *devfreq); -extern void devfreq_interval_update(struct devfreq *devfreq, - unsigned int *delay); +void devfreq_monitor_start(struct devfreq *devfreq); +void devfreq_monitor_stop(struct devfreq *devfreq); +void devfreq_monitor_suspend(struct devfreq *devfreq); +void devfreq_monitor_resume(struct devfreq *devfreq); +void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay); -extern int devfreq_add_governor(struct devfreq_governor *governor); -extern int devfreq_remove_governor(struct devfreq_governor *governor); +int devfreq_add_governor(struct devfreq_governor *governor); +int devfreq_remove_governor(struct devfreq_governor *governor); -extern int devfreq_update_status(struct devfreq *devfreq, unsigned long freq); +int devfreq_update_status(struct devfreq *devfreq, unsigned long freq); static inline int devfreq_update_stats(struct devfreq *df) { diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index c6f82d4bec9f..82630fafacde 100644 --- a/include/linux/devfreq.h +++ b/include/linux/devfreq.h @@ -201,24 +201,23 @@ struct devfreq_freqs { }; #if defined(CONFIG_PM_DEVFREQ) -extern struct devfreq *devfreq_add_device(struct device *dev, - struct devfreq_dev_profile *profile, - const char *governor_name, - void *data); -extern int devfreq_remove_device(struct devfreq *devfreq); -extern struct devfreq *devm_devfreq_add_device(struct device *dev, - struct devfreq_dev_profile *profile, - const char *governor_name, - void *data); -extern void devm_devfreq_remove_device(struct device *dev, - struct devfreq *devfreq); +struct devfreq *devfreq_add_device(struct device *dev, + struct devfreq_dev_profile *profile, + const char *governor_name, + void *data); +int devfreq_remove_device(struct devfreq *devfreq); +struct devfreq *devm_devfreq_add_device(struct device *dev, + struct devfreq_dev_profile *profile, + const char *governor_name, + void *data); +void devm_devfreq_remove_device(struct device *dev, struct devfreq *devfreq); /* Supposed to be called by PM callbacks */ -extern int devfreq_suspend_device(struct devfreq *devfreq); -extern int devfreq_resume_device(struct devfreq *devfreq); +int devfreq_suspend_device(struct devfreq *devfreq); +int devfreq_resume_device(struct devfreq *devfreq); -extern void devfreq_suspend(void); -extern void devfreq_resume(void); +void devfreq_suspend(void); +void devfreq_resume(void); /** * update_devfreq() - Reevaluate the device and configure frequency @@ -226,35 +225,34 @@ extern void devfreq_resume(void); * * Note: devfreq->lock must be held */ -extern int update_devfreq(struct devfreq *devfreq); +int update_devfreq(struct devfreq *devfreq); /* Helper functions for devfreq user device driver with OPP. */ -extern struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, - unsigned long *freq, u32 flags); -extern int devfreq_register_opp_notifier(struct device *dev, - struct devfreq *devfreq); -extern int devfreq_unregister_opp_notifier(struct device *dev, - struct devfreq *devfreq); -extern int devm_devfreq_register_opp_notifier(struct device *dev, - struct devfreq *devfreq); -extern void devm_devfreq_unregister_opp_notifier(struct device *dev, - struct devfreq *devfreq); -extern int devfreq_register_notifier(struct devfreq *devfreq, - struct notifier_block *nb, - unsigned int list); -extern int devfreq_unregister_notifier(struct devfreq *devfreq, - struct notifier_block *nb, - unsigned int list); -extern int devm_devfreq_register_notifier(struct device *dev, +struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, + unsigned long *freq, u32 flags); +int devfreq_register_opp_notifier(struct device *dev, + struct devfreq *devfreq); +int devfreq_unregister_opp_notifier(struct device *dev, + struct devfreq *devfreq); +int devm_devfreq_register_opp_notifier(struct device *dev, + struct devfreq *devfreq); +void devm_devfreq_unregister_opp_notifier(struct device *dev, + struct devfreq *devfreq); +int devfreq_register_notifier(struct devfreq *devfreq, + struct notifier_block *nb, + unsigned int list); +int devfreq_unregister_notifier(struct devfreq *devfreq, + struct notifier_block *nb, + unsigned int list); +int devm_devfreq_register_notifier(struct device *dev, struct devfreq *devfreq, struct notifier_block *nb, unsigned int list); -extern void devm_devfreq_unregister_notifier(struct device *dev, +void devm_devfreq_unregister_notifier(struct device *dev, struct devfreq *devfreq, struct notifier_block *nb, unsigned int list); -extern struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev, - int index); +struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev, int index); #if IS_ENABLED(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND) /** @@ -311,9 +309,9 @@ struct devfreq_passive_data { #else /* !CONFIG_PM_DEVFREQ */ static inline struct devfreq *devfreq_add_device(struct device *dev, - struct devfreq_dev_profile *profile, - const char *governor_name, - void *data) + struct devfreq_dev_profile *profile, + const char *governor_name, + void *data) { return ERR_PTR(-ENOSYS); } @@ -350,31 +348,31 @@ static inline void devfreq_suspend(void) {} static inline void devfreq_resume(void) {} static inline struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, - unsigned long *freq, u32 flags) + unsigned long *freq, u32 flags) { return ERR_PTR(-EINVAL); } static inline int devfreq_register_opp_notifier(struct device *dev, - struct devfreq *devfreq) + struct devfreq *devfreq) { return -EINVAL; } static inline int devfreq_unregister_opp_notifier(struct device *dev, - struct devfreq *devfreq) + struct devfreq *devfreq) { return -EINVAL; } static inline int devm_devfreq_register_opp_notifier(struct device *dev, - struct devfreq *devfreq) + struct devfreq *devfreq) { return -EINVAL; } static inline void devm_devfreq_unregister_opp_notifier(struct device *dev, - struct devfreq *devfreq) + struct devfreq *devfreq) { } @@ -393,22 +391,22 @@ static inline int devfreq_unregister_notifier(struct devfreq *devfreq, } static inline int devm_devfreq_register_notifier(struct device *dev, - struct devfreq *devfreq, - struct notifier_block *nb, - unsigned int list) + struct devfreq *devfreq, + struct notifier_block *nb, + unsigned int list) { return 0; } static inline void devm_devfreq_unregister_notifier(struct device *dev, - struct devfreq *devfreq, - struct notifier_block *nb, - unsigned int list) + struct devfreq *devfreq, + struct notifier_block *nb, + unsigned int list) { } static inline struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev, - int index) + int index) { return ERR_PTR(-ENODEV); } From patchwork Mon Feb 3 01:17:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chanwoo Choi X-Patchwork-Id: 11361965 X-Patchwork-Delegate: cw00.choi@samsung.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8489C14E3 for ; Mon, 3 Feb 2020 01:10:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 628AB2073C for ; Mon, 3 Feb 2020 01:10:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="HS1NO8GM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727100AbgBCBKC (ORCPT ); Sun, 2 Feb 2020 20:10:02 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:24081 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727097AbgBCBJ7 (ORCPT ); Sun, 2 Feb 2020 20:09:59 -0500 Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20200203010956epoutp023f6a771082cb4f32a350512f3e52ed98~vvy2IbsSM0166801668epoutp02h for ; Mon, 3 Feb 2020 01:09:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20200203010956epoutp023f6a771082cb4f32a350512f3e52ed98~vvy2IbsSM0166801668epoutp02h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1580692196; bh=BUMewYx5rWSJ6Wq1oWqSbYdedpvv2YPQrcYYGRikm7Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HS1NO8GMjAEp6KPKFzPW748rOkAQAGCrhNXOOsToLyjA6fPRL6kwzusHhqsRTXnlP 2+q2oxAd4Kl+PxIxdSUbnn5zOqg8Q6jw15qCMGNCHU89q+zEZFpQQSRb0/+hp8NPQK mabKmK2+ufISfpxztLYP9Xv9YcV4f89Uuuwj5qHA= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20200203010956epcas1p28f683e120bb91a48e24eee51aeadeb6d~vvy10Z2IH2741427414epcas1p2a; Mon, 3 Feb 2020 01:09:56 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.40.152]) by epsnrtp3.localdomain (Postfix) with ESMTP id 489qVn3W9GzMqYkn; Mon, 3 Feb 2020 01:09:53 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id A3.6A.52419.BD2773E5; Mon, 3 Feb 2020 10:09:47 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200203010946epcas1p1dcf58e3d8c638341a3410e813f68e59d~vvys6Shtc0038000380epcas1p1t; Mon, 3 Feb 2020 01:09:46 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200203010946epsmtrp15e04d7202a358be7f2231f9237533ee2~vvys5tbGT1442914429epsmtrp1M; Mon, 3 Feb 2020 01:09:46 +0000 (GMT) X-AuditID: b6c32a37-5b7ff7000001ccc3-54-5e3772db458a Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 71.AE.06569.AD2773E5; Mon, 3 Feb 2020 10:09:46 +0900 (KST) Received: from localhost.localdomain (unknown [10.113.221.102]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200203010946epsmtip247212d517c65435a46c3f1b659474acc~vvysvdZXi2247622476epsmtip2k; Mon, 3 Feb 2020 01:09:46 +0000 (GMT) From: Chanwoo Choi To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: cw00.choi@samsung.com, chanwoo@kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, lukasz.luba@arm.com Subject: [PATCHv2 2/2] PM / devfreq: Change to DEVFREQ_GOV_UPDATE_INTERVAL event name Date: Mon, 3 Feb 2020 10:17:33 +0900 Message-Id: <20200203011733.7639-2-cw00.choi@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200203011733.7639-1-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrEKsWRmVeSWpSXmKPExsWy7bCmge7tIvM4g+UP2C0m3rjCYnH9y3NW i7NNb9gtLu+aw2bxufcIo8XCphZ2i9uNK9gc2D3WzFvD6LFpVSebR9+WVYwenzfJBbBEZdtk pCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAF2gpFCWmFMK FApILC5W0rezKcovLUlVyMgvLrFVSi1IySmwLNArTswtLs1L10vOz7UyNDAwMgUqTMjOuPr2 BnvBLrWKDf9/sDQw7lXoYuTkkBAwkdi65DIjiC0ksINRYtdx2y5GLiD7E6NEz8mbjBDON0aJ 72fvssB0/F21iBkisReoatdpKOcLo8SnredZQarYBLQk9r+4wQZiiwhYSZz+38EMYjMLVEp8 OXcUqIaDQ1ggXOL2LDkQk0VAVeJDRwJIBa+ApcTOtbNZIXbJS6zecACskxNoyt9T+9lBVkkI zGCT2DipkR2kV0LAReL1IWuIemGJV8e3sEPYUhIv+9ug7GqJlSePsEH0djBKbNl/AWqBscT+ pZOZQOYwC2hKrN+lDxFWlNj5ey4jxMV8Eu++9rBCrOKV6GgTgihRlrj84C4ThC0psbi9kw3C 9pA4ufczEyREehklnjftZ5/AKDcLYcMCRsZVjGKpBcW56anFhgXGyPG1iRGcvrTMdzBuOOdz iFGAg1GJh3fGQ7M4IdbEsuLK3EOMEhzMSiK8dVamcUK8KYmVValF+fFFpTmpxYcYTYEBOZFZ SjQ5H5ha80riDU2NjI2NLUwMzUwNDZXEeR9GasYJCaQnlqRmp6YWpBbB9DFxcEo1MCY817qw gE2IM+GgSpj35ZelBz83TissT5jxb+q5VWFKhsaTTyXfSUrztZx2MyA6+tb1o7o7FtxUzLlz T7FwdZJm4+n1UYf4EhrWB0Quf1EdJM8sEPiS82hYwwcO/6qjenUWp1P2fVabEGRgV564UVF1 9eQX0t8Kvyren/7XT5rXYqJOcufJ40osxRmJhlrMRcWJAAyfaZZ1AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDLMWRmVeSWpSXmKPExsWy7bCSvO6tIvM4g6UXFCwm3rjCYnH9y3NW i7NNb9gtLu+aw2bxufcIo8XCphZ2i9uNK9gc2D3WzFvD6LFpVSebR9+WVYwenzfJBbBEcdmk pOZklqUW6dslcGVcfXuDvWCXWsWG/z9YGhj3KnQxcnJICJhI/F21iBnEFhLYzShxcmo4RFxS YtrFo0BxDiBbWOLw4eIuRi6gkk+MEu39qxhBatgEtCT2v7jBBmKLCNhI3F18jQXEZhaol2g7 s58dxBYWCJWYvLGHBWQOi4CqxIeOBJAwr4ClxM61s1khVslLrN5wAOwETgErib+nIFqFgGo2 r1nKNIGRbwEjwypGydSC4tz03GLDAqO81HK94sTc4tK8dL3k/NxNjOAw09LawXjiRPwhRgEO RiUe3hkPzeKEWBPLiitzDzFKcDArifDWWZnGCfGmJFZWpRblxxeV5qQWH2KU5mBREueVzz8W KSSQnliSmp2aWpBaBJNl4uCUamDMmqvbtP62fPi0iDytu846qpKvZUyeXjgm9G4f76KDs8oL T8fr5VyV4TgcZ3LH0dLlJceJyMkv17aW1u09G/pxro51NtvWK2Lup3zzDTQk/P8o5vx7vKjK 6s8nraPGG1jXlu576holu1rTq9WP63RkGGfW1zILJoW1ErMmfTlznd/xzMxJqj+UWIozEg21 mIuKEwGRiD/4LwIAAA== X-CMS-MailID: 20200203010946epcas1p1dcf58e3d8c638341a3410e813f68e59d X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200203010946epcas1p1dcf58e3d8c638341a3410e813f68e59d References: <20200203011733.7639-1-cw00.choi@samsung.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org DEVFREQ_GOV_INTERVAL event indicates that update the interval for polling mode of devfreq device. But, this event name doesn't specify exactly what to do. Change DEVFREQ_GOV_INTERVAL event name to DEVFREQ_GOV_UPDATE_INTERVAL which specifies what to do by event name. And modify the function name to DEVFREQ_GOV_UPDATE_INTERVAL with 'devfreq_' prefix + verb + object as following: - devfreq_interval_update -> devfreq_updatee_interval Reviewed-by: Lukasz Luba Signed-off-by: Chanwoo Choi --- Changes from v1: - Add reviewed tag of Lukasz - Fix typo in patch description drivers/devfreq/devfreq.c | 10 +++++----- drivers/devfreq/governor.h | 4 ++-- drivers/devfreq/governor_simpleondemand.c | 4 ++-- drivers/devfreq/tegra30-devfreq.c | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index cceee8bc3c2f..8494c5f05a73 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -550,14 +550,14 @@ void devfreq_monitor_resume(struct devfreq *devfreq) EXPORT_SYMBOL(devfreq_monitor_resume); /** - * devfreq_interval_update() - Update device devfreq monitoring interval + * devfreq_update_interval() - Update device devfreq monitoring interval * @devfreq: the devfreq instance. * @delay: new polling interval to be set. * * Helper function to set new load monitoring polling interval. Function - * to be called from governor in response to DEVFREQ_GOV_INTERVAL event. + * to be called from governor in response to DEVFREQ_GOV_UPDATE_INTERVAL event. */ -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay) +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay) { unsigned int cur_delay = devfreq->profile->polling_ms; unsigned int new_delay = *delay; @@ -597,7 +597,7 @@ void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay) out: mutex_unlock(&devfreq->lock); } -EXPORT_SYMBOL(devfreq_interval_update); +EXPORT_SYMBOL(devfreq_update_interval); /** * devfreq_notifier_call() - Notify that the device frequency requirements @@ -1426,7 +1426,7 @@ static ssize_t polling_interval_store(struct device *dev, if (ret != 1) return -EINVAL; - df->governor->event_handler(df, DEVFREQ_GOV_INTERVAL, &value); + df->governor->event_handler(df, DEVFREQ_GOV_UPDATE_INTERVAL, &value); ret = count; return ret; diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h index 5ba3e051b1d0..c07ce77c253d 100644 --- a/drivers/devfreq/governor.h +++ b/drivers/devfreq/governor.h @@ -18,7 +18,7 @@ /* Devfreq events */ #define DEVFREQ_GOV_START 0x1 #define DEVFREQ_GOV_STOP 0x2 -#define DEVFREQ_GOV_INTERVAL 0x3 +#define DEVFREQ_GOV_UPDATE_INTERVAL 0x3 #define DEVFREQ_GOV_SUSPEND 0x4 #define DEVFREQ_GOV_RESUME 0x5 @@ -61,7 +61,7 @@ void devfreq_monitor_start(struct devfreq *devfreq); void devfreq_monitor_stop(struct devfreq *devfreq); void devfreq_monitor_suspend(struct devfreq *devfreq); void devfreq_monitor_resume(struct devfreq *devfreq); -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay); +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay); int devfreq_add_governor(struct devfreq_governor *governor); int devfreq_remove_governor(struct devfreq_governor *governor); diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c index 3d809f228619..1b314e1df028 100644 --- a/drivers/devfreq/governor_simpleondemand.c +++ b/drivers/devfreq/governor_simpleondemand.c @@ -96,8 +96,8 @@ static int devfreq_simple_ondemand_handler(struct devfreq *devfreq, devfreq_monitor_stop(devfreq); break; - case DEVFREQ_GOV_INTERVAL: - devfreq_interval_update(devfreq, (unsigned int *)data); + case DEVFREQ_GOV_UPDATE_INTERVAL: + devfreq_update_interval(devfreq, (unsigned int *)data); break; case DEVFREQ_GOV_SUSPEND: diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 0b65f89d74d5..28b2c7ca416e 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -734,7 +734,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, devfreq_monitor_stop(devfreq); break; - case DEVFREQ_GOV_INTERVAL: + case DEVFREQ_GOV_UPDATE_INTERVAL: /* * ACTMON hardware supports up to 256 milliseconds for the * sampling period. @@ -745,7 +745,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, } tegra_actmon_pause(tegra); - devfreq_interval_update(devfreq, new_delay); + devfreq_update_interval(devfreq, new_delay); ret = tegra_actmon_resume(tegra); break;