From patchwork Wed Feb 5 22:26:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Agner X-Patchwork-Id: 11367265 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 30180924 for ; Wed, 5 Feb 2020 22:36:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04974214AF for ; Wed, 5 Feb 2020 22:36:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="AWS1XuQc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04974214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A4926F965; Wed, 5 Feb 2020 22:36:27 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 331 seconds by postgrey-1.36 at gabe; Wed, 05 Feb 2020 22:36:25 UTC Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0B666F965 for ; Wed, 5 Feb 2020 22:36:25 +0000 (UTC) Received: from zyt.lan (unknown [IPv6:2a02:169:3df5::564]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 2D3E25C4363; Wed, 5 Feb 2020 23:30:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1580941853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=8j/wLPVNelocFC7g7KIME69AY5HWX79CB2Mc0G7rnng=; b=AWS1XuQcm4wvY/QLxoLWaINZ0MDRA75jAX35f8zRoS6r4tFVmWTqPmL0I7WYIrC4kvVvhd hcjShldOactnbRSkfznuWKTcF1ZH9Acnx2rkPeOkl+VbQ5KqHI/v5P5cGUk2egYt/K6q7J nfieAP0L3J1FAE6CVr18oXS2vU964mA= From: Stefan Agner To: maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel.vetter@ffwll.ch Subject: [PATCH] drm: Add missing newline after comment Date: Wed, 5 Feb 2020 23:26:00 +0100 Message-Id: <586aab08af596120f48858005bb6784c83035d59.1580941448.git.stefan@agner.ch> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@redhat.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, clang-built-linux@googlegroups.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Clang prints a warning: drivers/gpu/drm/drm_lock.c:363:6: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] */ mutex_lock(&dev->struct_mutex); ^ drivers/gpu/drm/drm_lock.c:357:2: note: previous statement is here if (!drm_core_check_feature(dev, DRIVER_LEGACY)) ^ Fix this by adding a newline after the multi-line comment. Fixes: 058ca50ce3f1 ("drm/legacy: move lock cleanup for master into lock file (v2)") Link: https://github.com/ClangBuiltLinux/linux/issues/855 Signed-off-by: Stefan Agner --- drivers/gpu/drm/drm_lock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c index 2e8ce99d0baa..2c79e8199e3c 100644 --- a/drivers/gpu/drm/drm_lock.c +++ b/drivers/gpu/drm/drm_lock.c @@ -360,7 +360,8 @@ void drm_legacy_lock_master_cleanup(struct drm_device *dev, struct drm_master *m /* * Since the master is disappearing, so is the * possibility to lock. - */ mutex_lock(&dev->struct_mutex); + */ + mutex_lock(&dev->struct_mutex); if (master->lock.hw_lock) { if (dev->sigdata.lock == master->lock.hw_lock) dev->sigdata.lock = NULL;