From patchwork Wed Feb 19 03:04:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 11390283 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A818A92A for ; Wed, 19 Feb 2020 03:05:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 74DF224655 for ; Wed, 19 Feb 2020 03:05:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bNy4CX1e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74DF224655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B45E76B0006; Tue, 18 Feb 2020 22:05:13 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id AF7756B0007; Tue, 18 Feb 2020 22:05:13 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0CCE6B0008; Tue, 18 Feb 2020 22:05:13 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 8B14E6B0006 for ; Tue, 18 Feb 2020 22:05:13 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 201B78248047 for ; Wed, 19 Feb 2020 03:05:13 +0000 (UTC) X-FDA: 76505385306.03.vein86_4a9eab6eccf34 X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,bhe@redhat.com,:linux-kernel@vger.kernel.org::akpm@linux-foundation.org:richardw.yang@linux.intel.com:david@redhat.com:osalvador@suse.de:dan.j.williams@intel.com:mhocko@suse.com:bhe@redhat.com,RULES_HIT:30003:30012:30029:30054:30056:30064,0,RBL:205.139.110.61:@redhat.com:.lbl8.mailshell.net-62.18.0.100 66.10.201.10,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:ft,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: vein86_4a9eab6eccf34 X-Filterd-Recvd-Size: 5569 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Feb 2020 03:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582081512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=9OhfWyBEXxV7rEPCXEVIaYGIjekHl4/xRgmn4rQ0/S4=; b=bNy4CX1eg5qVUhbxZvJRH5loONUAw7nh1KOb1MNFiv9GuM7rZG2vQ0Zhh4dyJfecFMJrJS 1nGuip5m3xh0Blaw5FAni4/vIuGRKoDDmjCx0dYInhDq+sUPJKMSDOh1VCyTFic+ywQOnF W7qyGflc+WX45JiUV82laj3g/uWvjVw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-wbzldZKCO7KpnXpN2KNm2w-1; Tue, 18 Feb 2020 22:05:03 -0500 X-MC-Unique: wbzldZKCO7KpnXpN2KNm2w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA5A1A0CBF; Wed, 19 Feb 2020 03:05:01 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-16.pek2.redhat.com [10.72.12.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2100019756; Wed, 19 Feb 2020 03:04:55 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, richardw.yang@linux.intel.com, david@redhat.com, osalvador@suse.de, dan.j.williams@intel.com, mhocko@suse.com, bhe@redhat.com Subject: [PATCH v2 RESEND] mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM Date: Wed, 19 Feb 2020 11:04:54 +0800 Message-Id: <20200219030454.4844-1-bhe@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Wei Yang When we use SPARSEMEM instead of SPARSEMEM_VMEMMAP, pfn_to_page() doesn't work before sparse_init_one_section() is called. This leads to a crash when hotplug memory: [ 41.839170] BUG: unable to handle page fault for address: 0000000006400000 [ 41.840663] #PF: supervisor write access in kernel mode [ 41.841822] #PF: error_code(0x0002) - not-present page [ 41.842970] PGD 0 P4D 0 [ 41.843538] Oops: 0002 [#1] SMP PTI [ 41.844125] CPU: 3 PID: 221 Comm: kworker/u16:1 Tainted: G W 5.5.0-next-20200205+ #343 [ 41.845659] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 [ 41.846977] Workqueue: kacpi_hotplug acpi_hotplug_work_fn [ 41.847904] RIP: 0010:__memset+0x24/0x30 [ 41.848660] Code: cc cc cc cc cc cc 0f 1f 44 00 00 49 89 f9 48 89 d1 83 e2 07 48 c1 e9 03 40 0f b6 f6 48 b8 01 01 01 01 01 01 01 01 48 0f af c6 48 ab 89 d1 f3 aa 4c 89 c8 c3 90 49 89 f9 40 88 f0 48 89 d1 f3 [ 41.851836] RSP: 0018:ffffb43ac0373c80 EFLAGS: 00010a87 [ 41.852686] RAX: ffffffffffffffff RBX: ffff8a1518800000 RCX: 0000000000050000 [ 41.853824] RDX: 0000000000000000 RSI: 00000000000000ff RDI: 0000000006400000 [ 41.854967] RBP: 0000000000140000 R08: 0000000000100000 R09: 0000000006400000 [ 41.856107] R10: 0000000000000000 R11: 0000000000000002 R12: 0000000000000000 [ 41.857255] R13: 0000000000000028 R14: 0000000000000000 R15: ffff8a153ffd9280 [ 41.858414] FS: 0000000000000000(0000) GS:ffff8a153ab00000(0000) knlGS:0000000000000000 [ 41.859703] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 41.860627] CR2: 0000000006400000 CR3: 0000000136fca000 CR4: 00000000000006e0 [ 41.861716] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 41.862680] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 41.863628] Call Trace: [ 41.863983] sparse_add_section+0x1c9/0x26a [ 41.864570] __add_pages+0xbf/0x150 [ 41.865057] add_pages+0x12/0x60 [ 41.865489] add_memory_resource+0xc8/0x210 [ 41.866017] ? wake_up_q+0xa0/0xa0 [ 41.866416] __add_memory+0x62/0xb0 [ 41.866825] acpi_memory_device_add+0x13f/0x300 [ 41.867410] acpi_bus_attach+0xf6/0x200 [ 41.867890] acpi_bus_scan+0x43/0x90 [ 41.868448] acpi_device_hotplug+0x275/0x3d0 [ 41.868972] acpi_hotplug_work_fn+0x1a/0x30 [ 41.869473] process_one_work+0x1a7/0x370 [ 41.869953] worker_thread+0x30/0x380 [ 41.870396] ? flush_rcu_work+0x30/0x30 [ 41.870846] kthread+0x112/0x130 [ 41.871236] ? kthread_create_on_node+0x60/0x60 [ 41.871770] ret_from_fork+0x35/0x40 We should use memmap as it did. Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") Signed-off-by: Wei Yang Acked-by: David Hildenbrand Reviewed-by: Baoquan He CC: Dan Williams Reviewed-by: Dan Williams Acked-by: Michal Hocko --- v1->v2: Add trace printed by triggered bug to log. v1 can be found here: http://lkml.kernel.org/r/20200206125343.9070-1-richardw.yang@linux.intel.com mm/sparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/sparse.c b/mm/sparse.c index c184b69460b7..596b2a45b100 100644 --- a/mm/sparse.c +++ b/mm/sparse.c @@ -876,7 +876,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn, * Poison uninitialized struct pages in order to catch invalid flags * combinations. */ - page_init_poison(pfn_to_page(start_pfn), sizeof(struct page) * nr_pages); + page_init_poison(memmap, sizeof(struct page) * nr_pages); ms = __nr_to_section(section_nr); set_section_nid(section_nr, nid);