From patchwork Fri Mar 6 03:58:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "tiantao (H)" X-Patchwork-Id: 11423333 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 636F814B7 for ; Fri, 6 Mar 2020 08:04:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BC792073D for ; Fri, 6 Mar 2020 08:04:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BC792073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04D3C6EC9E; Fri, 6 Mar 2020 08:03:28 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 938 seconds by postgrey-1.36 at gabe; Fri, 06 Mar 2020 04:14:36 UTC Received: from huawei.com (szxga02-in.huawei.com [45.249.212.188]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9AFFF6EC63 for ; Fri, 6 Mar 2020 04:14:36 +0000 (UTC) Received: from DGGEMM402-HUB.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id A2F262437629F8AAB41B; Fri, 6 Mar 2020 11:58:53 +0800 (CST) Received: from dggeme711-chm.china.huawei.com (10.1.199.107) by DGGEMM402-HUB.china.huawei.com (10.3.20.210) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 6 Mar 2020 11:58:53 +0800 Received: from dggeme759-chm.china.huawei.com (10.3.19.105) by dggeme711-chm.china.huawei.com (10.1.199.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 6 Mar 2020 11:58:53 +0800 Received: from dggeme759-chm.china.huawei.com ([10.7.64.73]) by dggeme759-chm.china.huawei.com ([10.7.64.73]) with mapi id 15.01.1713.004; Fri, 6 Mar 2020 11:58:53 +0800 From: "tiantao (H)" To: "tiantao (H)" , "Chenfeng (puck)" , "airlied@linux.ie" , "daniel@ffwll.ch" , "tzimmermann@suse.de" , "kraxel@redhat.com" , "alexander.deucher@amd.com" , "tglx@linutronix.de" , "dri-devel@lists.freedesktop.org" , "xinliang.liu@linaro.org" , "linux-kernel@vger.kernel.org" Subject: =?eucgb2312_cn?b?tPC4tDogW1BBVENIXSBkcm0vaGlzaWxpY29uOiBBZGQgdGhlIHNodXRk?= =?eucgb2312_cn?b?b3duIGZvciBoaWJtY19wY2lfZHJpdmVy?= Thread-Topic: [PATCH] drm/hisilicon: Add the shutdown for hibmc_pci_driver Thread-Index: AQHV82lxn9gkibbLOEaVBpUdO8J6s6g6796g Date: Fri, 6 Mar 2020 03:58:53 +0000 Message-ID: <063d5262b6f7401bb9a0bb2a52a123b2@hisilicon.com> References: <1583466184-7060-1-git-send-email-tiantao6@hisilicon.com> <1583466184-7060-2-git-send-email-tiantao6@hisilicon.com> In-Reply-To: <1583466184-7060-2-git-send-email-tiantao6@hisilicon.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.57.60.129] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mailman-Approved-At: Fri, 06 Mar 2020 08:03:01 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linuxarm Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi All： Sorry，please ignore this patch. Best -----邮件原件----- 发件人: Linuxarm [mailto:linuxarm-bounces@huawei.com] 代表 Tian Tao 发送时间: 2020年3月6日 11:43 收件人: Chenfeng (puck) ; airlied@linux.ie; daniel@ffwll.ch; tzimmermann@suse.de; kraxel@redhat.com; alexander.deucher@amd.com; tglx@linutronix.de; dri-devel@lists.freedesktop.org; xinliang.liu@linaro.org; linux-kernel@vger.kernel.org 抄送: Linuxarm 主题: [PATCH] drm/hisilicon: Add the shutdown for hibmc_pci_driver add the shutdown function to release the resource. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) .remove = hibmc_pci_remove, + .shutdown = hibmc_pci_shutdown, .driver.pm = &hibmc_pm_ops, }; -- 2.7.4 diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index 51f1c70..0e58455d 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -357,9 +357,14 @@ static void hibmc_pci_remove(struct pci_dev *pdev) { struct drm_device *dev = pci_get_drvdata(pdev); - drm_dev_unregister(dev); - hibmc_unload(dev); drm_dev_put(dev); + pci_disable_device(pdev); + +} + +static void hibmc_pci_shutdown(struct pci_dev *pdev) { + hibmc_pci_remove(pdev); } static struct pci_device_id hibmc_pci_table[] = { @@ -372,6 +377,7 @@ static struct pci_driver hibmc_pci_driver = { .id_table = hibmc_pci_table, .probe = hibmc_pci_probe,