From patchwork Thu Mar 26 08:25:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff King X-Patchwork-Id: 11459589 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BBA251668 for ; Thu, 26 Mar 2020 08:25:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5AD72070A for ; Thu, 26 Mar 2020 08:25:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727675AbgCZIZ2 (ORCPT ); Thu, 26 Mar 2020 04:25:28 -0400 Received: from cloud.peff.net ([104.130.231.41]:51884 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726347AbgCZIZ2 (ORCPT ); Thu, 26 Mar 2020 04:25:28 -0400 Received: (qmail 1305 invoked by uid 109); 26 Mar 2020 08:25:27 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 26 Mar 2020 08:25:27 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12176 invoked by uid 111); 26 Mar 2020 08:35:22 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 26 Mar 2020 04:35:22 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 26 Mar 2020 04:25:27 -0400 From: Jeff King To: git@vger.kernel.org Cc: Johannes Schindelin , Junio C Hamano Subject: [PATCH 1/2] t/lib-credential.sh: drop shebang line Message-ID: <20200326082527.GA3611762@coredump.intra.peff.net> References: <20200326082338.GA3611364@coredump.intra.peff.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200326082338.GA3611364@coredump.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The purpose of lib-credential.sh is to be sourced into other test scripts. It doesn't need a "#!/bin/sh" line, as running it directly makes no sense. Nor does it serve any real filetype documentation purpose, as the file is cleary named with a ".sh" extension. In the spirit of c74c72034f (test: replace shebangs with descriptions in shell libraries, 2013-11-25), let's replace it with a human-readable description. Signed-off-by: Jeff King --- I left the similar case in lib-gpg alone so as not to conflict with Dscho's version. t/lib-credential.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/lib-credential.sh b/t/lib-credential.sh index 937b831ea6..5ea8bc9f1d 100755 --- a/t/lib-credential.sh +++ b/t/lib-credential.sh @@ -1,4 +1,5 @@ -#!/bin/sh +# Shell library for testing credential handling including helpers. See t0302 +# for an example of testing a specific helper. # Try a set of credential helpers; the expected stdin, # stdout and stderr should be provided on stdin, From patchwork Thu Mar 26 08:25:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff King X-Patchwork-Id: 11459591 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 922E381 for ; Thu, 26 Mar 2020 08:25:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 720A720772 for ; Thu, 26 Mar 2020 08:25:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727690AbgCZIZy (ORCPT ); Thu, 26 Mar 2020 04:25:54 -0400 Received: from cloud.peff.net ([104.130.231.41]:51898 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726347AbgCZIZy (ORCPT ); Thu, 26 Mar 2020 04:25:54 -0400 Received: (qmail 1326 invoked by uid 109); 26 Mar 2020 08:25:53 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 26 Mar 2020 08:25:53 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12204 invoked by uid 111); 26 Mar 2020 08:35:47 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 26 Mar 2020 04:35:47 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 26 Mar 2020 04:25:53 -0400 From: Jeff King To: git@vger.kernel.org Cc: Johannes Schindelin , Junio C Hamano Subject: [PATCH 2/2] t/lib-*.sh: drop executable bit Message-ID: <20200326082553.GB3611762@coredump.intra.peff.net> References: <20200326082338.GA3611364@coredump.intra.peff.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200326082338.GA3611364@coredump.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org There's no need for shell libraries to have the executable bit. They're meant to be sourced, and running them stand-alone is pointless. Let's reduce any possible confusion by making it more clear they're not meant to be run this way. Signed-off-by: Jeff King --- t/lib-credential.sh | 0 t/lib-gpg.sh | 0 t/lib-log-graph.sh | 0 t/lib-submodule-update.sh | 0 4 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 t/lib-credential.sh mode change 100755 => 100644 t/lib-gpg.sh mode change 100755 => 100644 t/lib-log-graph.sh mode change 100755 => 100644 t/lib-submodule-update.sh diff --git a/t/lib-credential.sh b/t/lib-credential.sh old mode 100755 new mode 100644 diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh old mode 100755 new mode 100644 diff --git a/t/lib-log-graph.sh b/t/lib-log-graph.sh old mode 100755 new mode 100644 diff --git a/t/lib-submodule-update.sh b/t/lib-submodule-update.sh old mode 100755 new mode 100644