From patchwork Tue Mar 31 08:10:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 11466873 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B742014B4 for ; Tue, 31 Mar 2020 08:10:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C50E20B1F for ; Tue, 31 Mar 2020 08:10:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="hc2co1l6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729624AbgCaIKJ (ORCPT ); Tue, 31 Mar 2020 04:10:09 -0400 Received: from mail-eopbgr20080.outbound.protection.outlook.com ([40.107.2.80]:8974 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726528AbgCaIKJ (ORCPT ); Tue, 31 Mar 2020 04:10:09 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eK27NVIA6j9CGE0pUTWvQXv83VsiN21yOSBBcBu+s5HuduYLTCX0twMRXnTlSqo3uyPHMesgK3waJ2cD1/pGNtZvPA7/y1Uj91D7fShjGRmK08RjL0wWV/xni9HNFpJsb83eY2TzKmC9CLUKegkVCO+q9MrCLxKvpV4AjeYOD8RQ5BlY3Xj10AKXYE5NBUlBqa+Hr3HUTHhpuz0jMr3msKg0nfaORs4K+eTNb5s91d15B0BxohAd2Qn1fyPU23vfvR442BTWUMaYhF15bzrR+gg3we7zvGsqSdxD8FZ0345eOagZpy0jDAmYbWXO+3K8XVjSnivmGm/0EuHEom3adw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Q/DEjEzALQNbuFVugb2ybCWOvxFq+KU9Mv12z3EFfA=; b=gEIYmHEPo8zhNMiaOo5Yn353ZJTJU7bmORXTy4kZHcQWULqw4jECxTLyPlfYwEIEnxJn6NdXveWPe18NlsRJAoRZxKQUkfSSR88jPMIHLfI+4M2Oo3RuPIUKXzxbGy8nMdKNTxrWd8m8lD4CrW/EvACRi1bO6o9nu+hFW4P+fkypeZgmofTvn3YWiau0O9tp3hjYNaA9DaF+X2PrQedLJSmd/1z1uS/Ml9W5wmq42CUiLExMCZKgeZtWVQXTk0zVYST6SK6L73vUqVIN/xwaVYEruQCAylv2GXwIHiJFxr9FkARX9axQNEpO5nkNIzlSWmAEN5SeFIbFHNZVfvO7QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Q/DEjEzALQNbuFVugb2ybCWOvxFq+KU9Mv12z3EFfA=; b=hc2co1l6yk4IIAJ2q9QG0XUpcc3kAgDSZTnlGeH2G5E2ZHWBwLYEAprspxpvfGk+aGI6x8b+TebYYW6YmqbCn9FlhXM76dij+qqJsEFQDc3Gzelc4w9JMj2gNpTmfXHHktHOc+RFiKbdvLnnPJraM0rwyQ9rQkBGZA/hFbVL6k0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; Received: from AM7PR04MB7157.eurprd04.prod.outlook.com (52.135.57.84) by AM7PR04MB6934.eurprd04.prod.outlook.com (10.141.173.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Tue, 31 Mar 2020 08:10:02 +0000 Received: from AM7PR04MB7157.eurprd04.prod.outlook.com ([fe80::902c:71:6377:4273]) by AM7PR04MB7157.eurprd04.prod.outlook.com ([fe80::902c:71:6377:4273%5]) with mapi id 15.20.2856.019; Tue, 31 Mar 2020 08:10:02 +0000 From: Peter Chen To: balbi@kernel.org Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com, pawell@cadence.com, rogerq@ti.com, gregkh@linuxfoundation.org, jun.li@nxp.com, Peter Chen Subject: [PATCH 1/4] usb: cdns3: core: get role switch node from firmware Date: Tue, 31 Mar 2020 16:10:02 +0800 Message-Id: <20200331081005.32752-1-peter.chen@nxp.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: SG2PR03CA0123.apcprd03.prod.outlook.com (2603:1096:4:91::27) To AM7PR04MB7157.eurprd04.prod.outlook.com (2603:10a6:20b:118::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from b29397-desktop.ap.freescale.net (119.31.174.66) by SG2PR03CA0123.apcprd03.prod.outlook.com (2603:1096:4:91::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.9 via Frontend Transport; Tue, 31 Mar 2020 08:09:59 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [119.31.174.66] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4e7832a2-081c-4124-1796-08d7d54ae9b5 X-MS-TrafficTypeDiagnostic: AM7PR04MB6934:|AM7PR04MB6934: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:741; X-Forefront-PRVS: 0359162B6D X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7157.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(66476007)(5660300002)(6916009)(16526019)(186003)(4744005)(6506007)(52116002)(26005)(6486002)(6512007)(44832011)(8936002)(956004)(4326008)(81166006)(66556008)(8676002)(36756003)(2616005)(81156014)(316002)(478600001)(6666004)(2906002)(86362001)(66946007)(1076003);DIR:OUT;SFP:1101; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yDlFy4l+p7fuURa/ESe5Zh6k8JkrmAoLqPXdOnxY7qSmrQMX/uaCUmY6UGyTgL1wzBgxq7Z41Yn+unGmG2zz7Uu1lwvF4MuDl3etowJZJBv2LLPkc4BV3mBw3zF37a1Obs5OENj5ZeF2keuLpA1mHyP4fveFW5B7QxcrP4jE/EGDD4kTfdDoV4uSwIokjI6oR/v33P+aV08cuZQRxnu9EtycPXw2SfKKYloHBoyMsjfj9gfr9PKbVZPi8iwEgLLsiWszJWARObRPHr3aNGCCRakTCgU2ttWkuyyk5veab+KGYDpQDkHV9OdTFgMz3A7IsRrVVRjCF3WowsNUCdt1aljILZA0ryxkj2hrHMVZo7quD0oeH/5jxrhw3PfBNc5q5Suw/SIPTg8okSXMC0T8t/6R0GhCSZtfJ6ioq9MvFmX2x0N7VoXXfzlv9eVdHmGc X-MS-Exchange-AntiSpam-MessageData: WVNqOpipbT2BRR3nC8UTh3ZOWTB+Czm+Qc2eblSALamI/qvCs/hFG2NO6qgEzspKU50xbKWkzrmWgsRvomm71FLkE/S8PYWsPzrKFMLKC0wijrOTsXhYdjNBHyMDWgM95vondacmQyHhr7zSpPONog== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e7832a2-081c-4124-1796-08d7d54ae9b5 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2020 08:10:02.5412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZP8HVYInOIQ5q/c0/n/H3z0HeNxFPkXfYhjPlPqb7DCYmp/lFVyR6NcVPiBDIqUTV8CA3qV+n6GLF38jl/drMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6934 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org After that, the role switch device (eg, Type-C device) could call cdns3_role_set to finish the role switch. Signed-off-by: Peter Chen Reviewed-by: Roger Quadros --- drivers/usb/cdns3/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 4aafba20f450..704c679a0c5d 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -528,6 +528,8 @@ static int cdns3_probe(struct platform_device *pdev) sw_desc.get = cdns3_role_get; sw_desc.allow_userspace_control = true; sw_desc.driver_data = cdns; + if (device_property_read_bool(dev, "usb-role-switch")) + sw_desc.fwnode = dev->fwnode; cdns->role_sw = usb_role_switch_register(dev, &sw_desc); if (IS_ERR(cdns->role_sw)) { From patchwork Tue Mar 31 08:10:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 11466875 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B05D192A for ; Tue, 31 Mar 2020 08:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8238E2145D for ; Tue, 31 Mar 2020 08:10:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="ANRxhVLp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729925AbgCaIKN (ORCPT ); Tue, 31 Mar 2020 04:10:13 -0400 Received: from mail-eopbgr20080.outbound.protection.outlook.com ([40.107.2.80]:8974 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726528AbgCaIKM (ORCPT ); Tue, 31 Mar 2020 04:10:12 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TK8ewhP4TbLKRqS+qAZe7Wc30w46ducPMK81FMfPbcR0D1EhXf1R4msv8S6yNs0aV4d5h8flhBKnULQHCF56qKkBt4LJtBkwvJkG8xrq210oLAIZ+JtG9h4Htpj/18zHrGrjdGZyDDISZNmvydpOTL6YRAMV//i7MknQhmNNiWEr2KU+3111yWzYpXHr6yQWPb/MyDGaU8/UPy4bbv95ZNz0yzHheXGFsINzKBJFyEvrJGRaAiuDCcIN2+InePc1p3eNPK63sHuDTWDiS9m7blyBUgnHzOBpL69HXIV6mpW9Lf5Vac7SAe7uxa684bXzEkncCPlMDF5Wqs+83xudyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XZfU613EPkEmC1UVN3XJBvsPGFd20jvlcnjDL5fFUj4=; b=n+KWN2XirSHTb4SNs0QlzQD9l14Th3ZfHAfmKC4fES00zev1MNg+7pE2scKVmms+NvDdrBQzNweDTq0TFPsli2uHPpVe8eXBcfHywxvEIVUIcbuHd3co8I0jIiQGKjv89dMEelF3STob6y9x8G7beb34f/PtChSvs2p3eFU6gVNMSjoLL+saXCUqyXhussCTzfPb1sdXYWlnQqYATWlMcWmsIy+D6vHaiP7JKFM+HxxtumALsp8tMs+NbM1wHOKgNKljJ7Xhst6Ltc3a0xo6RqDKjYh9YjMGguRmui4U2j7Czv5/h0DH4zF5RNvgKA0EoD1tMZ7pQ/VdAEac2va45w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XZfU613EPkEmC1UVN3XJBvsPGFd20jvlcnjDL5fFUj4=; b=ANRxhVLpYo+7csynmzCHSy7n8JMEwBXPlXoH8rgNurPCfBdlvwjWu6zHwnsnaAwBvvqenl4P8vr7q7kYBOZ3X7kxasUz63pV0uqBPa4MXb0OqU2solkuT55tGv6IIuTj2Ktd0qxI5ndbeSfHKEc5tzk55S41rIDNGAhFJCaHq2M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; Received: from AM7PR04MB7157.eurprd04.prod.outlook.com (52.135.57.84) by AM7PR04MB6934.eurprd04.prod.outlook.com (10.141.173.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Tue, 31 Mar 2020 08:10:05 +0000 Received: from AM7PR04MB7157.eurprd04.prod.outlook.com ([fe80::902c:71:6377:4273]) by AM7PR04MB7157.eurprd04.prod.outlook.com ([fe80::902c:71:6377:4273%5]) with mapi id 15.20.2856.019; Tue, 31 Mar 2020 08:10:05 +0000 From: Peter Chen To: balbi@kernel.org Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com, pawell@cadence.com, rogerq@ti.com, gregkh@linuxfoundation.org, jun.li@nxp.com, Peter Chen Subject: [PATCH 2/4] usb: cdns3: delete role_override Date: Tue, 31 Mar 2020 16:10:03 +0800 Message-Id: <20200331081005.32752-2-peter.chen@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200331081005.32752-1-peter.chen@nxp.com> References: <20200331081005.32752-1-peter.chen@nxp.com> X-ClientProxiedBy: SG2PR03CA0123.apcprd03.prod.outlook.com (2603:1096:4:91::27) To AM7PR04MB7157.eurprd04.prod.outlook.com (2603:10a6:20b:118::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from b29397-desktop.ap.freescale.net (119.31.174.66) by SG2PR03CA0123.apcprd03.prod.outlook.com (2603:1096:4:91::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.9 via Frontend Transport; Tue, 31 Mar 2020 08:10:02 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [119.31.174.66] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9eb48ba8-d0fb-4497-d835-08d7d54aebae X-MS-TrafficTypeDiagnostic: AM7PR04MB6934:|AM7PR04MB6934: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 0359162B6D X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7157.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(66476007)(5660300002)(6916009)(16526019)(186003)(6506007)(52116002)(26005)(6486002)(6512007)(44832011)(8936002)(956004)(4326008)(81166006)(66556008)(8676002)(36756003)(2616005)(81156014)(316002)(478600001)(2906002)(86362001)(66946007)(1076003);DIR:OUT;SFP:1101; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i88S+Kzn6JPC2ocyxhT/6PHo/6CkAUUirTBr7WN23+d6Qs4vd5e//cJi83PLPFuVefivk7hIhh6PZDqwf9HBXVLlIOEXkCQ9aSvpU+tira2r+3pUJgVyLWOBq2FgTNRqFdos+4wifYIMk983b+IqJqG6xnnWerQtOKUQ/sczI6B5MUyBY0ftxr9NnckL8Ul7tO0IRq45MJIJ0xQCJ9d2PLQbKsdGNW+2rUj1nC73+03F4fkxmuQ0BICim317hOVQCx0EqTiIvI9K8sOlVf7EPAV9NI8e0DMa1B+ebztF0InmlP4FWE3kUdAfrBtdnM1HNrjwt7fux5e15/hEqJhcuZewq6XxAnd8dfHXbQz9un6xsW3ENTNN8kJ8UjWwlYZBk1ENSMvk3ku/SgD2AG7TH/pXpQ3k5EFgw7w464YtkE+wtVfMV4/aQvjA2athFSEW X-MS-Exchange-AntiSpam-MessageData: eKCBH5QNsGWrfoEMkrjdZPxEe3efbOTIxU8IKMmIGsZPbImO/bgd69s5n+m77xC09VjL15pxdDn3Is7DhflcseKWeNceVKj8VCBNs/3nzV38LEpg5I+uG5y1cnyWdxXy1WtotcdcBenZuYOptmqu6w== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9eb48ba8-d0fb-4497-d835-08d7d54aebae X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2020 08:10:05.6337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g8rTuU0zo5DdyL5cITySDgNDoonwQPNeRb2e8HoxEf1uu4u3bjSRQP+SBig6GyXrmPTZ/8Vl+z2r0HKyOBzFQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6934 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org In short, we have three kinds of role switches: - Based on SoC: ID and VBUS - Based on external connnctor, eg, Type-C or GPIO Connector - Based on user choices through sysfs Since HW handling and usb-role-switch handling are at different places, we do not need role_override any more, and this flag could not judge external connector case well. With role_override deleted, We use cdns3_hw_role_switch for the 1st use case, and usb-role-switch for the 2nd and 3rd cases. Signed-off-by: Peter Chen --- drivers/usb/cdns3/core.c | 37 ------------------------------------- drivers/usb/cdns3/core.h | 2 -- 2 files changed, 39 deletions(-) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 704c679a0c5d..f57c66a9f87c 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -291,10 +291,6 @@ int cdns3_hw_role_switch(struct cdns3 *cdns) enum usb_role real_role, current_role; int ret = 0; - /* Do nothing if role based on syfs. */ - if (cdns->role_override) - return 0; - pm_runtime_get_sync(cdns->dev); current_role = cdns->role; @@ -353,39 +349,6 @@ static int cdns3_role_set(struct usb_role_switch *sw, enum usb_role role) pm_runtime_get_sync(cdns->dev); - /* - * FIXME: switch role framework should be extended to meet - * requirements. Driver assumes that role can be controlled - * by SW or HW. Temporary workaround is to use USB_ROLE_NONE to - * switch from SW to HW control. - * - * For dr_mode == USB_DR_MODE_OTG: - * if user sets USB_ROLE_HOST or USB_ROLE_DEVICE then driver - * sets role_override flag and forces that role. - * if user sets USB_ROLE_NONE, driver clears role_override and lets - * HW state machine take over. - * - * For dr_mode != USB_DR_MODE_OTG: - * Assumptions: - * 1. Restricted user control between NONE and dr_mode. - * 2. Driver doesn't need to rely on role_override flag. - * 3. Driver needs to ensure that HW state machine is never called - * if dr_mode != USB_DR_MODE_OTG. - */ - if (role == USB_ROLE_NONE) - cdns->role_override = 0; - else - cdns->role_override = 1; - - /* - * HW state might have changed so driver need to trigger - * HW state machine if dr_mode == USB_DR_MODE_OTG. - */ - if (!cdns->role_override && cdns->dr_mode == USB_DR_MODE_OTG) { - cdns3_hw_role_switch(cdns); - goto pm_put; - } - if (cdns->role == role) goto pm_put; diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h index 969eb94de204..1ad1f1fe61e9 100644 --- a/drivers/usb/cdns3/core.h +++ b/drivers/usb/cdns3/core.h @@ -62,7 +62,6 @@ struct cdns3_role_driver { * This field based on firmware setting, kernel configuration * and hardware configuration. * @role_sw: pointer to role switch object. - * @role_override: set 1 if role rely on SW. */ struct cdns3 { struct device *dev; @@ -90,7 +89,6 @@ struct cdns3 { struct mutex mutex; enum usb_dr_mode dr_mode; struct usb_role_switch *role_sw; - int role_override; }; int cdns3_hw_role_switch(struct cdns3 *cdns); From patchwork Tue Mar 31 08:10:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 11466877 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 98F8092A for ; Tue, 31 Mar 2020 08:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 777662145D for ; Tue, 31 Mar 2020 08:10:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="EwwEyv/L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729955AbgCaIKP (ORCPT ); Tue, 31 Mar 2020 04:10:15 -0400 Received: from mail-eopbgr20080.outbound.protection.outlook.com ([40.107.2.80]:8974 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729950AbgCaIKO (ORCPT ); Tue, 31 Mar 2020 04:10:14 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bAlM+YDzQRQfltFsi+IplupId22hlGXQh+iraIrwaL+1ZUZrH+kwofxTGLnkZKcC1I8cLfuqVNOlD+bixY2iEgyUzjpi4LPWzyTazYcC1MYkB0OptTgJG01PY2qdffEQcpL4JJ1h/bUjSJgFYMm1b2+Pugfa75vfVHD088LCLZEFe+mxIqMxPI40TVsEj85AdBsjrEdvo90K+yXWRQAVriBvu2zN414unDbQ2pD1X+ESLO5QWjdjCOmORwNp2OFc9xLVzIsuv5w33QLNyPAU/2RHQ2nsjP4C94NP11M5xLlXynRTz+V9OOvhVbVvczLyM0uCesqgdrT3+L64H4MdjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cYX51b0jE15IVAtYC1Si9bBHA+W7j9qFsPyHajnvFuA=; b=DaONF7/oBa3GY2yfuE9s0+7dv0SQr5ECb/A7WJ+/XhqPQlv+NH/Y0fiJNdQaelnC9yBXi0tPqUFXYqAl/eRuBgZHChQatJWCFe94RP4JYflseyPc7VUDjisL+ECda4YjY9WaMa9PxnexoKJezTFeW2khwzwrhKFw1C4VJYArk/uBMDlu35e4mVY+W8/7iq+JxYHppZX8zTgVxRgWWBXM6L5x3rx58qfvIVpgxDnB+gz7dQ29XSfDtOpC6//t8jkcaaFPQpk4lY875Oy/UW6aPemkotmesRXSAF/zq67VnxXKhlD0mDtO3zMy73pLJNsGgZNg8YY0l768yoWF+ubAbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cYX51b0jE15IVAtYC1Si9bBHA+W7j9qFsPyHajnvFuA=; b=EwwEyv/LwNKJFtqDV+4MCztcMvv/N0cJLbndvoy59f6JrxG6E4mt2/5EjCzeriwTWYaT1WE7haGdiiYCA43Kc0mP0p+7/zfnKXp+OOnCQW7u66cIjueGXK/CJ5PegNEkIiq72k3TT5tXUI2qPWRyFAiMyJsmcTR6h53qI2DzL1E= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; Received: from AM7PR04MB7157.eurprd04.prod.outlook.com (52.135.57.84) by AM7PR04MB6934.eurprd04.prod.outlook.com (10.141.173.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Tue, 31 Mar 2020 08:10:08 +0000 Received: from AM7PR04MB7157.eurprd04.prod.outlook.com ([fe80::902c:71:6377:4273]) by AM7PR04MB7157.eurprd04.prod.outlook.com ([fe80::902c:71:6377:4273%5]) with mapi id 15.20.2856.019; Tue, 31 Mar 2020 08:10:08 +0000 From: Peter Chen To: balbi@kernel.org Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com, pawell@cadence.com, rogerq@ti.com, gregkh@linuxfoundation.org, jun.li@nxp.com, Peter Chen Subject: [PATCH 3/4] usb: cdns3: change "cdsn3" to"cdns3" Date: Tue, 31 Mar 2020 16:10:04 +0800 Message-Id: <20200331081005.32752-3-peter.chen@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200331081005.32752-1-peter.chen@nxp.com> References: <20200331081005.32752-1-peter.chen@nxp.com> X-ClientProxiedBy: SG2PR03CA0123.apcprd03.prod.outlook.com (2603:1096:4:91::27) To AM7PR04MB7157.eurprd04.prod.outlook.com (2603:10a6:20b:118::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from b29397-desktop.ap.freescale.net (119.31.174.66) by SG2PR03CA0123.apcprd03.prod.outlook.com (2603:1096:4:91::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.9 via Frontend Transport; Tue, 31 Mar 2020 08:10:05 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [119.31.174.66] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5bee5e3e-b5f4-4341-f8c4-08d7d54aed8a X-MS-TrafficTypeDiagnostic: AM7PR04MB6934:|AM7PR04MB6934: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:785; X-Forefront-PRVS: 0359162B6D X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7157.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(66476007)(5660300002)(6916009)(16526019)(186003)(6506007)(52116002)(26005)(6486002)(6512007)(44832011)(8936002)(956004)(4326008)(81166006)(66556008)(8676002)(36756003)(2616005)(81156014)(316002)(478600001)(2906002)(86362001)(66946007)(1076003);DIR:OUT;SFP:1101; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 78Uyt6kaKQ5sTarxPNQ8GIXhUZ7hSQqXiYnau8bMuZtY7ipzHYqTjsnUrip9yBRF2lQksS3DOyCI39azrMWnDdg8WJ4yQjLOi6v60Ri9PnJhziWGhrM7a4u5bCge+aNzDQ/pG8cIb3C/E3yVq9OYu21Z3s90NYPSPGnxIFst8QSPjKO9aBvlYUcqWn4S7rxkHWcrgRru4jRlaoyqYU/4aZkH7sp0bvQUli0lkuB18nn90ZtfHNR1403hkCGRDJpyXObejhJ/1HFZUZ73h+fwB/r394oDf68m87l6U4iRI66Tbx5imYJY1X+L5GSfXGYn9UgCjPl7MnA53ySELvmVndO86rGQK0vsaROON1bU8MDgzZMkJmSP6FuTRjxtDUwl//w+258wH9qX8sj7FvXjrjnYPEUZdO/L6DH256TTlvI2+gbpACHaM42Gmq7ej1CM X-MS-Exchange-AntiSpam-MessageData: G+B87m3hpKcXpJ7TCooOPXOt9czx6jlyY20r8utyfX9O/Ggj9OOjaHkKkZZW1/qlXWdVh0n04BUUceD1N2JWDRKoYi+HNJpC6DKrEXl0aMv38UveCZw1GJoqCgpw+2wJh9Qpkmj/yA+zXeYTuXR33w== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bee5e3e-b5f4-4341-f8c4-08d7d54aed8a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2020 08:10:08.7361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MrXMwd3gzbSc6il+4H6RTeNCMCX/cpBfvOWi6cDLiiG2wJO+yPtEjHbW+osEnW4HDcydmVla9FWcH7wxpvzQ5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6934 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org And delete cdsn3_hw_role_state_machine declare which doesn't be needed. Signed-off-by: Peter Chen --- drivers/usb/cdns3/core.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index f57c66a9f87c..19bbb5b7e6b6 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -82,8 +82,6 @@ static void cdns3_exit_roles(struct cdns3 *cdns) cdns3_drd_exit(cdns); } -static enum usb_role cdsn3_hw_role_state_machine(struct cdns3 *cdns); - /** * cdns3_core_init_role - initialize role of operation * @cdns: Pointer to cdns3 structure @@ -193,12 +191,12 @@ static int cdns3_core_init_role(struct cdns3 *cdns) } /** - * cdsn3_hw_role_state_machine - role switch state machine based on hw events. + * cdns3_hw_role_state_machine - role switch state machine based on hw events. * @cdns: Pointer to controller structure. * * Returns next role to be entered based on hw events. */ -static enum usb_role cdsn3_hw_role_state_machine(struct cdns3 *cdns) +static enum usb_role cdns3_hw_role_state_machine(struct cdns3 *cdns) { enum usb_role role; int id, vbus; @@ -294,7 +292,7 @@ int cdns3_hw_role_switch(struct cdns3 *cdns) pm_runtime_get_sync(cdns->dev); current_role = cdns->role; - real_role = cdsn3_hw_role_state_machine(cdns); + real_role = cdns3_hw_role_state_machine(cdns); /* Do nothing if nothing changed */ if (current_role == real_role) From patchwork Tue Mar 31 08:10:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 11466879 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4D83D92A for ; Tue, 31 Mar 2020 08:10:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 220E52145D for ; Tue, 31 Mar 2020 08:10:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="Pn6wVNwL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729989AbgCaIKR (ORCPT ); Tue, 31 Mar 2020 04:10:17 -0400 Received: from mail-eopbgr20080.outbound.protection.outlook.com ([40.107.2.80]:8974 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729950AbgCaIKR (ORCPT ); Tue, 31 Mar 2020 04:10:17 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TX60A8Jl48lIqwixHe02oPwWC9XAFMYVl+AnxEDtw48YpSLPpae4P76OIP8qB+TRSkrjXgQ3tR0Qa9DG9g2gihVENqqBMCh+su0XyBP10Wi82Ylmj7c1eFgliP98HZinZrjF/Q78RZFfBW4F7HoXzzwrtfW6eEPfQ8jdvIDjYEtR1eAQfjB9UqpBSzl1lmqf6fP0pN46KzmFXnoQJvtfSfUQPgnDhK09bfr1SkLgHLmO8G0/yl3v6yulT129i5iOR6VB2DrilK83QHGKXvxudIhHQwqdE2jPA3S2N0yEbvqD3plRY/m3I2wYdBIBzvpjmNrbBIP1msMcjSom/hVidw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BJhyJsbya4+B58sp87W4OdZVrtusWyLWTMAsTpXmEWs=; b=mTt+XaoJD2TeOUJVeK90IhMZg9PDDwmbeYVhVWfUCe+YFTUVviW8S7aPUVu/Vd140WNoQZqhlGB2uXXTvdgPDS7v9jx/bx5hcvtK53LBmbgTOQxOyIKwZMCmmJDI8uRVFeTgx0pVyra+zgKAq+JhLEnfoicczsPM3ZoX3eUuPWJYUoVfo9AiCD/LBGV7V1oiwKMyNaREW1iBPgw0ALe5zvgI+NSyIe3SiHN6+h7dpwLo5yWmY2SxOvBfCzMX/bykUcQQqF5zND+DmzSGsrSwm4X6sG2pbPfY2oaQjsXJa8h9nJ1Kszg8OFusMWKeXRlxRoNc3JasMWcq/IowHpaWjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BJhyJsbya4+B58sp87W4OdZVrtusWyLWTMAsTpXmEWs=; b=Pn6wVNwL+zmu0zdnyqLzndILsUv9W/Oz2WUBmMvpLLBVohhwgZotwpYN9hXZjMaUmaBJHqRGASCeJElC0fSgiWJ/I8FmK0icGKWdcnrXLPm61jJEzhzT+bnbBSyjAxG4yzzHLh+Ahok27IemULXNeTRiVXwzElNGIFQWGU1gZZM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; Received: from AM7PR04MB7157.eurprd04.prod.outlook.com (52.135.57.84) by AM7PR04MB6934.eurprd04.prod.outlook.com (10.141.173.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Tue, 31 Mar 2020 08:10:12 +0000 Received: from AM7PR04MB7157.eurprd04.prod.outlook.com ([fe80::902c:71:6377:4273]) by AM7PR04MB7157.eurprd04.prod.outlook.com ([fe80::902c:71:6377:4273%5]) with mapi id 15.20.2856.019; Tue, 31 Mar 2020 08:10:12 +0000 From: Peter Chen To: balbi@kernel.org Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com, pawell@cadence.com, rogerq@ti.com, gregkh@linuxfoundation.org, jun.li@nxp.com, Peter Chen Subject: [PATCH 4/4] usb: cdns3: change dev_info to dev_dbg for debug message Date: Tue, 31 Mar 2020 16:10:05 +0800 Message-Id: <20200331081005.32752-4-peter.chen@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200331081005.32752-1-peter.chen@nxp.com> References: <20200331081005.32752-1-peter.chen@nxp.com> X-ClientProxiedBy: SG2PR03CA0123.apcprd03.prod.outlook.com (2603:1096:4:91::27) To AM7PR04MB7157.eurprd04.prod.outlook.com (2603:10a6:20b:118::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from b29397-desktop.ap.freescale.net (119.31.174.66) by SG2PR03CA0123.apcprd03.prod.outlook.com (2603:1096:4:91::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.9 via Frontend Transport; Tue, 31 Mar 2020 08:10:09 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [119.31.174.66] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7c45c57b-f99a-4cf2-fc41-08d7d54aef69 X-MS-TrafficTypeDiagnostic: AM7PR04MB6934:|AM7PR04MB6934: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:77; X-Forefront-PRVS: 0359162B6D X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7157.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(66476007)(5660300002)(6916009)(16526019)(186003)(6506007)(52116002)(26005)(6486002)(6512007)(44832011)(8936002)(956004)(4326008)(81166006)(66556008)(8676002)(36756003)(2616005)(81156014)(316002)(478600001)(6666004)(2906002)(15650500001)(86362001)(66946007)(1076003)(473944003)(414714003);DIR:OUT;SFP:1101; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9YYcG0PxVtG4itFnDT3IHY6RB1xyM9uAqiZ6atqL1uFPKmwR7WToClTG+8aH/zryabFy6pUwbJtpS/beNIYIm4UqiKHkZ3MFPtUnwbYENYAi7AULYc9/spmQijHKdSUJ2WOy/DJyBTQDB6m8ENH1TA7yfLPcVc0veiFlNquTN9o9GZJEnF4qafqGaDn7eiwflKUJ6NR9PRVcu2YYmzM93FiboWxrVd2sKiPqKgWAw2ceZx+8psKxsluyTLDQeoabSrWuvIZaW8mgO6LT8pj2Vau4EhUAAbRAffU1TCu0cZucMEdU737eFemAdW557U6LEzm2ZH0RkBagfrSQmcq/iNywHcbiAwmo34mV72KVas6vh7DoPlEeLlfhTugm7Ih7hpQsFWKHzZrR2A29Dv4bsjzSikxIlRu5heQzzvN3GwsuiPi/M70dUZopQTMSR5rz5u2ze26yoN2QXziD+myzB5ORr0ATmQQgp1r5miv8VKHJ1UFwXfXI0Sh/77YCVCsUvvHz4oQ0aEZV6+k30cUQoQ== X-MS-Exchange-AntiSpam-MessageData: Oz53O115HemI7JUTYdm5HhGFuORzMeyx0osWvVFrx7F5W9KWiJLbrYhx0zm7yVQJuBLgTo07qSci1reRHkCn/XARHmnuS3iFhaxAjxMCoytsg0a04xfico3LlsT+CLcUc3khTgiQOYcIdC1LqnlBDw== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c45c57b-f99a-4cf2-fc41-08d7d54aef69 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2020 08:10:11.8963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7K9zG2mFqlFZxPBXLTLGFir4bihpTMPeWEfCobAWA68XNxKPkMASq6Cv5FZN27B5tGlj/pPOwUAD+DE2V/CuhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6934 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org During device mode initialization, lots of device information are printed to console, see below. Change them as debug message. cdns-usb3 5b130000.cdns3: Initialized ep0 support: cdns-usb3 5b130000.cdns3: Initialized ep1out support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep2out support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep3out support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep4out support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep5out support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep6out support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep7out support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep1in support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep2in support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep3in support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep4in support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep5in support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep6in support: BULK, INT ISO cdns-usb3 5b130000.cdns3: Initialized ep7in support: BULK, INT ISO Signed-off-by: Peter Chen --- drivers/usb/cdns3/drd.c | 4 ++-- drivers/usb/cdns3/gadget.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c index 16ad485f0b69..58089841ed52 100644 --- a/drivers/usb/cdns3/drd.c +++ b/drivers/usb/cdns3/drd.c @@ -329,7 +329,7 @@ int cdns3_drd_init(struct cdns3 *cdns) cdns->otg_v1_regs = NULL; cdns->otg_regs = regs; writel(1, &cdns->otg_v0_regs->simulate); - dev_info(cdns->dev, "DRD version v0 (%08x)\n", + dev_dbg(cdns->dev, "DRD version v0 (%08x)\n", readl(&cdns->otg_v0_regs->version)); } else { cdns->otg_v0_regs = NULL; @@ -337,7 +337,7 @@ int cdns3_drd_init(struct cdns3 *cdns) cdns->otg_regs = (void *)&cdns->otg_v1_regs->cmd; cdns->version = CDNS3_CONTROLLER_V1; writel(1, &cdns->otg_v1_regs->simulate); - dev_info(cdns->dev, "DRD version v1 (ID: %08x, rev: %08x)\n", + dev_dbg(cdns->dev, "DRD version v1 (ID: %08x, rev: %08x)\n", readl(&cdns->otg_v1_regs->did), readl(&cdns->otg_v1_regs->rid)); } diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c index 3c05080a9ad5..2dab1da4a2bc 100644 --- a/drivers/usb/cdns3/gadget.c +++ b/drivers/usb/cdns3/gadget.c @@ -2954,7 +2954,7 @@ static int cdns3_init_eps(struct cdns3_device *priv_dev) priv_ep->flags = 0; - dev_info(priv_dev->dev, "Initialized %s support: %s %s\n", + dev_dbg(priv_dev->dev, "Initialized %s support: %s %s\n", priv_ep->name, priv_ep->endpoint.caps.type_bulk ? "BULK, INT" : "", priv_ep->endpoint.caps.type_iso ? "ISO" : "");