From patchwork Wed Apr 1 16:57:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lars-Peter Clausen X-Patchwork-Id: 11469337 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2BED91667 for ; Wed, 1 Apr 2020 16:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D908720714 for ; Wed, 1 Apr 2020 16:57:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=metafoo.de header.i=@metafoo.de header.b="UgfhwJhI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732307AbgDAQ5t (ORCPT ); Wed, 1 Apr 2020 12:57:49 -0400 Received: from www381.your-server.de ([78.46.137.84]:46642 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732304AbgDAQ5t (ORCPT ); Wed, 1 Apr 2020 12:57:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metafoo.de; s=default2002; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qMmfCU+ahUMs2BevCfrx+AdQfOBvj0SgwP/PbTk63nU=; b=UgfhwJhIoXc+kODByWLYpNG13M DHMmC43dWDOXYJv4OLPoHkphZ735DnReH0wxvmqyD6Lx1hJZ6s3Ee3HgaFxICZZX89eNmiXpEZS4a Qx65QENA3wtvEtvRB+uBiYA5jGRtYk9MvaLN0SiQ6gytFpMjj7NINhTmvjRrnP5RgH9jku5aFu0Na bCnOhJJhPPPkNk735/fOkFwxYkliehGA+0e7VnLsjQuckwKdnw6B43icWVjeSralfW8iNqWIOwHZ7 dXUf2W3T4cuFgHAnAilZbuPVElOM8/tPB6OCChqwVLuJY6hsIEXxSvhWfnVBLf+4nx+X0SUfqzTh0 HbwC5FwQ==; Received: from sslproxy06.your-server.de ([78.46.172.3]) by www381.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jJggU-0002o9-R5; Wed, 01 Apr 2020 18:57:46 +0200 Received: from [82.135.74.241] (helo=lars-desktop.fritz.box) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJggU-000TQk-HU; Wed, 01 Apr 2020 18:57:46 +0200 From: Lars-Peter Clausen To: Jonathan Cameron Cc: Hartmut Knaack , Peter Meerwald-Stadler , Alexandru Ardelean , linux-iio@vger.kernel.org, Lars-Peter Clausen Subject: [PATCH v2] iio: dma-buffer: Cleanup buffer.h/buffer_impl.h includes Date: Wed, 1 Apr 2020 18:57:06 +0200 Message-Id: <20200401165706.30416-1-lars@metafoo.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Authenticated-Sender: lars@metafoo.de X-Virus-Scanned: Clear (ClamAV 0.102.2/25769/Wed Apr 1 14:53:49 2020) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The IIO DMA buffer is a DMA buffer implementation. As such it should include buffer_impl.h rather than buffer.h. The include to buffer.h in buffer-dma.h should be buffer_impl.h so it has access to the struct iio_buffer definition. The code currently only works because all places that use buffer-dma.h include buffer_impl.h before it. The include to buffer.h in industrialio-buffer-dma.c can be removed since those file does not reference any of buffer consumer functions. Signed-off-by: Lars-Peter Clausen Tested-by: Alexandru Ardelean --- Changes since v1: * Don't remove buffer.h include in buffer-dma.h since it is needed after all. --- drivers/iio/buffer/industrialio-buffer-dma.c | 1 - include/linux/iio/buffer-dma.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/buffer/industrialio-buffer-dma.c b/drivers/iio/buffer/industrialio-buffer-dma.c index a74bd9c0587c..d348af8b9705 100644 --- a/drivers/iio/buffer/industrialio-buffer-dma.c +++ b/drivers/iio/buffer/industrialio-buffer-dma.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include diff --git a/include/linux/iio/buffer-dma.h b/include/linux/iio/buffer-dma.h index 016d8a068353..ff15c61bf319 100644 --- a/include/linux/iio/buffer-dma.h +++ b/include/linux/iio/buffer-dma.h @@ -11,7 +11,7 @@ #include #include #include -#include +#include struct iio_dma_buffer_queue; struct iio_dma_buffer_ops;