From patchwork Thu Apr 2 10:59:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 11470483 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D281414B4 for ; Thu, 2 Apr 2020 11:03:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACFB620757 for ; Thu, 2 Apr 2020 11:03:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387610AbgDBLDi (ORCPT ); Thu, 2 Apr 2020 07:03:38 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:58168 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387477AbgDBLDi (ORCPT ); Thu, 2 Apr 2020 07:03:38 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D0277D8FE0A6F619D048; Thu, 2 Apr 2020 19:03:10 +0800 (CST) Received: from localhost.localdomain (10.69.192.58) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Thu, 2 Apr 2020 19:03:02 +0800 From: John Garry To: , CC: , , , , , , John Garry Subject: [PATCH] ACPI: PPTT: Inform user that table offset used for Physical processor node ID Date: Thu, 2 Apr 2020 18:59:01 +0800 Message-ID: <1585825141-107529-1-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 X-Originating-IP: [10.69.192.58] X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org If the the Processor ID valid is not set for a Physical Processor Package node, then the node table offset is used as a substitute. As such, we may get info like this from sysfs: root@(none)$ pwd /sys/devices/system/cpu/cpu0/topology root@(none)$ more physical_package_id 56 Inform the user of this in the bootlog, as it is much less than ideal, and they can remedy this in their FW. This topic was originally discussed in: https://lore.kernel.org/linux-acpi/c325cfe2-7dbf-e341-7f0f-081b6545e890@huawei.com/T/#m0ec18637d8586f832084a8a6af22580e6174669a Signed-off-by: John Garry diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c index 4ae93350b70d..b4ed3c818e00 100644 --- a/drivers/acpi/pptt.c +++ b/drivers/acpi/pptt.c @@ -515,6 +515,8 @@ static int topology_get_acpi_cpu_tag(struct acpi_table_header *table, if (level == 0 || cpu_node->flags & ACPI_PPTT_ACPI_PROCESSOR_ID_VALID) return cpu_node->acpi_processor_id; + if (level == PPTT_ABORT_PACKAGE) + pr_notice_once("Physical package node Processor ID valid not set, will use table offset as substitute\n"); return ACPI_PTR_DIFF(cpu_node, table); } pr_warn_once("PPTT table found, but unable to locate core %d (%d)\n",