From patchwork Thu Apr 23 13:47:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= X-Patchwork-Id: 11505699 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6445913B2 for ; Thu, 23 Apr 2020 13:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C3752076C for ; Thu, 23 Apr 2020 13:48:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c4MgLJ/6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728379AbgDWNsH (ORCPT ); Thu, 23 Apr 2020 09:48:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728339AbgDWNsG (ORCPT ); Thu, 23 Apr 2020 09:48:06 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD0EBC08ED7D for ; Thu, 23 Apr 2020 06:48:06 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id o10so2910818pgb.6 for ; Thu, 23 Apr 2020 06:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pzkZCe5uYKk6rhdDUMXrg2Ostg9Jn3aYVIdQ6giVSrA=; b=c4MgLJ/6JiCP9mQ+ftlkYNFxBbVOUXRYqNdv0DHtkbPeTogJBSYzqDPKIcum8utwWb XmWzEh0KIARgfBnUbi/49hJRH7FoCjdsJLsvKq/J5dDBNXt1kgOPjiBb2EoOurBkxs7Q hW28Vq52Zz274ZL7VlvuwqBaDjfpE7pU4nZr61XDheaVBgAEWwsEIMGhrGP4qdZWLjH7 7p9qULyMTC3bguNHlEjfkfDMhPc5fhau9T6GiyfJVWoAxzR5hpLuCYMiJ9RhtXQcWEWr IPy3HN7fEj/sVFm9MeCTovydH2TrdQ539U+uSTtz/7E4SzmHxr9Y14nSx3wtrf36PfeD AaVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pzkZCe5uYKk6rhdDUMXrg2Ostg9Jn3aYVIdQ6giVSrA=; b=OKNuDF6ZIMk6JxB5hc/7cJ4PLd4bXrftgfwrXfVEmy31ykVaOOLMwxZS3QSnJ1ZcoL 7sccoyaC9x2ImyRuhia4pQDUdF27SHA0RxmfNGocoNWtfYhZeHKpoG/3+3hxKa4ysTGP 6MsB5eYf6Hm/OB8IXQRCwGPlgd/9sKRxRVRdBskVdZ77mZ/2jl7BbFMLa9UMWE5DuI0s 0EJUrUvuc6kIAcaoXa9CoC9uKTRiFJTWMzrY4RcfTTN3E0vpKne6msLaiK5Nhw7iQqsJ /kEte3TSKn4c59oWFGP1j7MlTRfApNIftOjLnpD+EqAdWsWXg9vcV8DvpIrPoHMGFB4E 8l1g== X-Gm-Message-State: AGi0PuZF3Qpq5xQLQo3j9CCuV3kZdxHmAoApQzw4e+7Yt3PqK8kqFpD3 LL5mypgOS/08gl5a/QoXCmNwjtJM X-Google-Smtp-Source: APiQypKHoQrvCQ+YLZBC2xpgf1jrCNL39F2yNwJ6cC9s7s+CNU2NMbSyeM5XF0OPUsxyUnSpYteYsQ== X-Received: by 2002:a63:ba09:: with SMTP id k9mr4235442pgf.305.1587649685937; Thu, 23 Apr 2020 06:48:05 -0700 (PDT) Received: from localhost.localdomain ([2402:800:6374:f359:1ce8:a621:5f80:1116]) by smtp.gmail.com with ESMTPSA id z23sm2635958pfr.136.2020.04.23.06.48.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2020 06:48:05 -0700 (PDT) From: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= To: git@vger.kernel.org Cc: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= Subject: [PATCH 1/4] C: s/0/NULL/ for pointer type Date: Thu, 23 Apr 2020 20:47:53 +0700 Message-Id: X-Mailer: git-send-email 2.26.2.384.g435bf60bd5 In-Reply-To: References: MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Fix warning from `make sparse`. Signed-off-by: Đoàn Trần Công Danh --- add-interactive.c | 2 +- builtin/fmt-merge-msg.c | 2 +- log-tree.c | 4 ++-- range-diff.c | 2 +- t/helper/test-parse-pathspec-file.c | 6 +++--- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/add-interactive.c b/add-interactive.c index 29cd2fe020..b8983838b9 100644 --- a/add-interactive.c +++ b/add-interactive.c @@ -526,7 +526,7 @@ static int get_modified_files(struct repository *r, for (i = 0; i < 2; i++) { struct rev_info rev; - struct setup_revision_opt opt = { 0 }; + struct setup_revision_opt opt = { NULL }; if (filter == INDEX_ONLY) s.mode = (i == 0) ? FROM_INDEX : FROM_WORKTREE; diff --git a/builtin/fmt-merge-msg.c b/builtin/fmt-merge-msg.c index 172dfbd852..f4376bccef 100644 --- a/builtin/fmt-merge-msg.c +++ b/builtin/fmt-merge-msg.c @@ -494,7 +494,7 @@ static void fmt_merge_msg_sigs(struct strbuf *out) enum object_type type; unsigned long size, len; char *buf = read_object_file(oid, &type, &size); - struct signature_check sigc = { 0 }; + struct signature_check sigc = { NULL }; struct strbuf sig = STRBUF_INIT; if (!buf || type != OBJ_TAG) diff --git a/log-tree.c b/log-tree.c index 0064788b25..ca721150d4 100644 --- a/log-tree.c +++ b/log-tree.c @@ -449,7 +449,7 @@ static void show_signature(struct rev_info *opt, struct commit *commit) { struct strbuf payload = STRBUF_INIT; struct strbuf signature = STRBUF_INIT; - struct signature_check sigc = { 0 }; + struct signature_check sigc = { NULL }; int status; if (parse_signed_commit(commit, &payload, &signature) <= 0) @@ -496,7 +496,7 @@ static int show_one_mergetag(struct commit *commit, struct object_id oid; struct tag *tag; struct strbuf verify_message; - struct signature_check sigc = { 0 }; + struct signature_check sigc = { NULL }; int status, nth; size_t payload_size; diff --git a/range-diff.c b/range-diff.c index f745567cf6..71dcd947c5 100644 --- a/range-diff.c +++ b/range-diff.c @@ -107,7 +107,7 @@ static int read_patches(const char *range, struct string_list *list, } if (starts_with(line, "diff --git")) { - struct patch patch = { 0 }; + struct patch patch = { NULL }; struct strbuf root = STRBUF_INIT; int linenr = 0; diff --git a/t/helper/test-parse-pathspec-file.c b/t/helper/test-parse-pathspec-file.c index 02f4ccfd2a..b3e08cef4b 100644 --- a/t/helper/test-parse-pathspec-file.c +++ b/t/helper/test-parse-pathspec-file.c @@ -6,7 +6,7 @@ int cmd__parse_pathspec_file(int argc, const char **argv) { struct pathspec pathspec; - const char *pathspec_from_file = 0; + const char *pathspec_from_file = NULL; int pathspec_file_nul = 0, i; static const char *const usage[] = { @@ -20,9 +20,9 @@ int cmd__parse_pathspec_file(int argc, const char **argv) OPT_END() }; - parse_options(argc, argv, 0, options, usage, 0); + parse_options(argc, argv, NULL, options, usage, 0); - parse_pathspec_file(&pathspec, 0, 0, 0, pathspec_from_file, + parse_pathspec_file(&pathspec, 0, 0, NULL, pathspec_from_file, pathspec_file_nul); for (i = 0; i < pathspec.nr; i++) From patchwork Thu Apr 23 13:47:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= X-Patchwork-Id: 11505705 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CC125159A for ; Thu, 23 Apr 2020 13:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFD5B2076C for ; Thu, 23 Apr 2020 13:48:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TKDU2pKw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728413AbgDWNsJ (ORCPT ); Thu, 23 Apr 2020 09:48:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728339AbgDWNsI (ORCPT ); Thu, 23 Apr 2020 09:48:08 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EAE2C08E934 for ; Thu, 23 Apr 2020 06:48:08 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id 18so1744030pfv.8 for ; Thu, 23 Apr 2020 06:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6zDL6Rv0DnD2NZ1626U0EgnwYOqorHsi3rL2txzD9pc=; b=TKDU2pKww2xP9WuWYovbVtpIR7MrbKxOi8xYaJgrv9Gf+KzeTnwIM5CoqZZLr/JD4w JJ6ctBDEwOHIKPaYAjDChW7J4ZdPe5vgJLgXn1q4Pf8KZShEFfM9Z5+JiqemPCBmxjFw LyBC0a0ck2w82RMvfdxpK36GiqCidiNppekBo/uXf9OaxkCZA4m9cbDDx3MsQ+H1Anj6 iv7p4Pl9539qsBsGxRqZkV2lCu2zWjAWIz9bgk8MsJrKXTEKqwkQUqIkWmQUeG/PTxwQ H8sM6382XV11kW35CYJ6YVnC4//R8ifCIoKhGjMhDQ6c2DdNlcmkSLLPbrr7fE2aBD6d L7JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6zDL6Rv0DnD2NZ1626U0EgnwYOqorHsi3rL2txzD9pc=; b=Ri3zWuwXwLR4QflQukvzBk/3k2GYkWdwndEDtJ5cYR3dapDWiGhwmwbl9P00veVfpY zqaJcM/YhBV4cWU+z6oW1IzKOgZaLqSG82oeU7arSIR7bwD3rcUpvaPqY5QFFN/qoAF+ KYkPEzDmvnNjwSda5rnCh+CGYcYVowb9/F13k/O/t2HERzYoLxkmBa1V+EC/z3ya0CDz s2B9ZFPVp5HrhKFUThyiBrJlkLmVk0yQnoTLmXmZ217EwRTY0KTY9TZCpfQrplUXLoGj ocp3t7KMPVwez/ifpGuu93HpOQpajmQMz4iXWh8UeFWdV5dba+96k/Dc+C14L6dsO41E FXYg== X-Gm-Message-State: AGi0PubfpkZD+QcqsUoup1umV7V5dgY2pZEUzcPsyt28A5ADNTMa+QJq ThRQOYBlWmjZLiKe+sgOy3wpx2fJ X-Google-Smtp-Source: APiQypIhV0LCfFlEKP5BxWIcvJk59AXrHq8LbZALcfuWa1S2bi/KlbGt19qUz6LRv41OAFU7h8wd5A== X-Received: by 2002:a63:4f65:: with SMTP id p37mr4220716pgl.60.1587649687568; Thu, 23 Apr 2020 06:48:07 -0700 (PDT) Received: from localhost.localdomain ([2402:800:6374:f359:1ce8:a621:5f80:1116]) by smtp.gmail.com with ESMTPSA id z23sm2635958pfr.136.2020.04.23.06.48.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2020 06:48:07 -0700 (PDT) From: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= To: git@vger.kernel.org Cc: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= Subject: [PATCH 2/4] compat/regex: silence `make sparse` warning Date: Thu, 23 Apr 2020 20:47:54 +0700 Message-Id: <25f595f56f7f895ab31bf7269aabad9142c0590c.1587648870.git.congdanhqx@gmail.com> X-Mailer: git-send-email 2.26.2.384.g435bf60bd5 In-Reply-To: References: MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org * alloca: somewhere later in the code, we indirectly include alloca.h which will define alloca again, include it prior to define alloca in order to not define it against. * Copy all attributes from the header to source file, and move the attributes prior to function name. cgcc is very picky on the position of attribute. Signed-off-by: Đoàn Trần Công Danh --- compat/regex/regex.c | 1 + compat/regex/regex_internal.c | 2 +- compat/regex/regex_internal.h | 5 ++--- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/compat/regex/regex.c b/compat/regex/regex.c index f3e03a9eab..4bef75a716 100644 --- a/compat/regex/regex.c +++ b/compat/regex/regex.c @@ -62,6 +62,7 @@ #include #ifdef GAWK +#include #undef alloca #define alloca alloca_is_bad_you_should_never_use_it #endif diff --git a/compat/regex/regex_internal.c b/compat/regex/regex_internal.c index ec51cf3446..58504f795b 100644 --- a/compat/regex/regex_internal.c +++ b/compat/regex/regex_internal.c @@ -921,7 +921,7 @@ re_string_destruct (re_string_t *pstr) /* Return the context at IDX in INPUT. */ static unsigned int -internal_function +internal_function __attribute ((pure)) re_string_context_at (const re_string_t *input, int idx, int eflags) { int c; diff --git a/compat/regex/regex_internal.h b/compat/regex/regex_internal.h index 3ee8aae59d..c61a1e4971 100644 --- a/compat/regex/regex_internal.h +++ b/compat/regex/regex_internal.h @@ -430,9 +430,8 @@ static reg_errcode_t build_wcs_upper_buffer (re_string_t *pstr) # endif /* RE_ENABLE_I18N */ static void build_upper_buffer (re_string_t *pstr) internal_function; static void re_string_translate_buffer (re_string_t *pstr) internal_function; -static unsigned int re_string_context_at (const re_string_t *input, int idx, - int eflags) - internal_function __attribute ((pure)); +static internal_function __attribute ((pure)) +unsigned int re_string_context_at (const re_string_t *input, int idx, int eflags); #endif #define re_string_peek_byte(pstr, offset) \ ((pstr)->mbs[(pstr)->cur_idx + offset]) From patchwork Thu Apr 23 13:47:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= X-Patchwork-Id: 11505707 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0A68E13B2 for ; Thu, 23 Apr 2020 13:48:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC2F72077D for ; Thu, 23 Apr 2020 13:48:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QBJYZTTh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728506AbgDWNsM (ORCPT ); Thu, 23 Apr 2020 09:48:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728339AbgDWNsJ (ORCPT ); Thu, 23 Apr 2020 09:48:09 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB43FC08E934 for ; Thu, 23 Apr 2020 06:48:09 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id g6so2903835pgs.9 for ; Thu, 23 Apr 2020 06:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6Svij7AqIu1IfO1+ocfAXfydIcw/vut33rQEygmYm5k=; b=QBJYZTThdgXDehoE8lxtFJYikuoex0WCTS8diwZ01hvUUZpkol+pvK4Duefs1JdkbH kp5W+h2rp9PhMg+wGs5o4Dp57sjIoT7fB27OsOhayq5QPD/E2kzX+PivhRjaaaiP8WLd CCY20hN5h7Q8QGqtfxl1SQMW31C4W3E13oJ88xth6tj+aIHTC/zlVmTr9/b5uSnYIkqw mwzNPb39OYqVLmppoTTinKQV+nMmFjCdjfqrd2dHEw+MtSWM/TQcBxW2iZUv9d9nVAed mivcSCHxHAAQ/nsWw4DCZQV3i64C4X9PuR32ko9yqGMrk1AIiw3Tamru1uxX9L+8PH5W 7glQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6Svij7AqIu1IfO1+ocfAXfydIcw/vut33rQEygmYm5k=; b=X61lseXy5lVdhgOZFeMYfU//YaVUxs1gg7q0O2/wuXFl4cN2YelzPn9SEkTb2TU+4P qj6wfNnC2AWeTNvDLBYFmfiz0zam9N6R/eOa++wVseCHEaJsiFthkuRErNuhVKCgtqU9 XPYjUEGCyMLFB9LnMba1SzdY6jJC71zEOzZ110FrbsT2P6w2BL4VQQhMYlSG+wtbG7q/ /eLicv+CF2Dnbp8hSRHWTxPKokyoecXLMHZqUUcakiEb2FAqPwhUOSNJwWETIpRtbQn1 wrWghmcHoX2TFLSIA656WvqCeBZDI1Y02EiRTr3Oh4nAaACrjlLQA48NjW0jsQB028Z/ YWbQ== X-Gm-Message-State: AGi0PuZmIPQj6LL+kujxHVkJ/bipwIITGuw7GBGsMaivzpvX5hKy8nq4 YEyRYcCo4VFmQT5oKiLeE1ByF/ik X-Google-Smtp-Source: APiQypJLkTjRfatBZVPvQ4Bxy7m404mWc6uuNI0tl8LltZHProp7ouyn/6aN+QiPrgiL3dbM0bHBig== X-Received: by 2002:a63:f70e:: with SMTP id x14mr3833764pgh.394.1587649689201; Thu, 23 Apr 2020 06:48:09 -0700 (PDT) Received: from localhost.localdomain ([2402:800:6374:f359:1ce8:a621:5f80:1116]) by smtp.gmail.com with ESMTPSA id z23sm2635958pfr.136.2020.04.23.06.48.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2020 06:48:08 -0700 (PDT) From: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= To: git@vger.kernel.org Cc: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= Subject: [PATCH 3/4] graph.c: limit linkage of internal variable Date: Thu, 23 Apr 2020 20:47:55 +0700 Message-Id: <5bd7b929107c277e10a697bc874b702b85691558.1587648870.git.congdanhqx@gmail.com> X-Mailer: git-send-email 2.26.2.384.g435bf60bd5 In-Reply-To: References: MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Signed-off-by: Đoàn Trần Công Danh --- graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graph.c b/graph.c index 4fb25ad464..4cd9915075 100644 --- a/graph.c +++ b/graph.c @@ -1055,7 +1055,7 @@ static void graph_output_commit_line(struct git_graph *graph, struct graph_line graph_update_state(graph, GRAPH_COLLAPSING); } -const char merge_chars[] = {'/', '|', '\\'}; +static const char merge_chars[] = {'/', '|', '\\'}; static void graph_output_post_merge_line(struct git_graph *graph, struct graph_line *line) { From patchwork Thu Apr 23 13:47:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= X-Patchwork-Id: 11505709 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7D7E5159A for ; Thu, 23 Apr 2020 13:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60D462087E for ; Thu, 23 Apr 2020 13:48:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UldrMsPq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728562AbgDWNsO (ORCPT ); Thu, 23 Apr 2020 09:48:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728458AbgDWNsM (ORCPT ); Thu, 23 Apr 2020 09:48:12 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AB32C08E934 for ; Thu, 23 Apr 2020 06:48:11 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id a7so2526145pju.2 for ; Thu, 23 Apr 2020 06:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VOUgvKNu1KMx+CMgWGYhfRw9FoZU/PdCS5jVeb8Itec=; b=UldrMsPqpFEoqd+1+2sOVLO0KmcAskn4ABqWQAGTMN6qvTnfhwCZ/RM3HjRxz28c49 eSmElatOLOUvM/NrZ7JQMvlOG34lC6xkHqnugs2X6hp1tzshZYPXD/PWv+/Sk7hbjyoy 2gUZ51O4lIMtpfkEffXCfxREnTmxi2X44IkLKBFSFg1LFP1TCstle6953mZnFdM8UsWn aRfCweeZODmKebmTAwS+37TWGUsUluqmKTAwKEIgNTPEevt+jwmLPpKFc0w9O6C6dvNf 7jgV3laUMpXcnv2HhVvWhF8PIGRvqP50i/plnMqxccAfQko4KSk1iE+eyMMTK3KY7rP3 fIKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VOUgvKNu1KMx+CMgWGYhfRw9FoZU/PdCS5jVeb8Itec=; b=aVfvEnT5ArGecKqchOrNQFoXeGGUIe6UvuGvXORw1YuSzL3J8Vnmw6YL8tEX0OUrFQ A88VOyEU3W2TeOuwwpA3nFRAQZbueHHu+eVXYCXZDaphBmAXrl2P8BTBWzyDVgy4F5sq hlSyn+mm1ZkXe0dX/WZLxofibdrFdp/QFxnl7wYAb94PuNXuheTnRBn96hV7fqpho9uY a0Cv5oqYcLM8y0viIZZvcO4GhLazDSyDZGSRBxqZupYeCMDpud7LLvG0o3Z9j2oKJyJV 17pclsyErscz1+bwcXhU7rNNZSYOyyz6ToIa4pRA90NUGrSHM9wdITVn9AC9qNlNpjle QVUg== X-Gm-Message-State: AGi0PuY4BNRTjKgpyI0CDIqLpgyRwQZkdAyGOJGAa8TjOXxw8Af4gYJQ A6QWE+taQXyTOXxOlzqxOukOKlz5 X-Google-Smtp-Source: APiQypLM1lkRCZoLO8YMgGURSj+goCLmNu0mgKrR9KfT6d1qCvkjcjikxc1qOfC4C4ZzQV9pZnjuBw== X-Received: by 2002:a17:90a:f194:: with SMTP id bv20mr755176pjb.27.1587649690894; Thu, 23 Apr 2020 06:48:10 -0700 (PDT) Received: from localhost.localdomain ([2402:800:6374:f359:1ce8:a621:5f80:1116]) by smtp.gmail.com with ESMTPSA id z23sm2635958pfr.136.2020.04.23.06.48.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2020 06:48:10 -0700 (PDT) From: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= To: git@vger.kernel.org Cc: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= Subject: [PATCH 4/4] progress.c: silence cgcc suggestion about internal linkage Date: Thu, 23 Apr 2020 20:47:56 +0700 Message-Id: X-Mailer: git-send-email 2.26.2.384.g435bf60bd5 In-Reply-To: References: MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Signed-off-by: Đoàn Trần Công Danh --- progress.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/progress.c b/progress.c index 19805ac646..fb53a2ec0c 100644 --- a/progress.c +++ b/progress.c @@ -50,7 +50,9 @@ static volatile sig_atomic_t progress_update; * These are only intended for testing the progress output, i.e. exclusively * for 'test-tool progress'. */ +extern int progress_testing; /* to silence sparse: internal linkage */ int progress_testing; +extern uint64_t progress_test_ns; /* to silence sparse: internal linkage */ uint64_t progress_test_ns = 0; void progress_test_force_update(void); /* To silence -Wmissing-prototypes */ void progress_test_force_update(void) From patchwork Thu Apr 23 13:47:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= X-Patchwork-Id: 11505711 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CC92B15AB for ; Thu, 23 Apr 2020 13:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB4E9208E4 for ; Thu, 23 Apr 2020 13:48:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zb58xhzk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728585AbgDWNsP (ORCPT ); Thu, 23 Apr 2020 09:48:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728534AbgDWNsO (ORCPT ); Thu, 23 Apr 2020 09:48:14 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37A7FC08ED7D for ; Thu, 23 Apr 2020 06:48:13 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id t4so2349174plq.12 for ; Thu, 23 Apr 2020 06:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8d7VxX5uwaFIhgGErkkvwOrNu/3IXcZtziPCVBCAJ38=; b=Zb58xhzk4J8gxBVDd9GQ+fmQ1W2v3HEsWqlNW9pUBGqZu/5r7+jS8B5tO8OTLaNaGe U9FccjIPdLSuGpsrtAf5pfbZsdQgQB4udNVEWR49rpeQxjGUmH1CapB36yOQnJS7bRmH 3IdDsJj4ogh3QXXPSrL/RC+aZDJpEzi9NJS2xcmJUCFcgd5Vy2yoTGQ8ryqeI8+wKGeQ 7pzmDPHr5Dd4vAUHV5SLVGFQACkDLpb8HKTs6c/35AtyEcFY5E9zYK9DVeQmfAk+o5Is JI6oTPbTbFTlSGUEqE1Rs7nYq7SusBQvK9Kg1G2JYdP8KYFVsrIPyZ7E5/j6fox1AV8k 4YpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8d7VxX5uwaFIhgGErkkvwOrNu/3IXcZtziPCVBCAJ38=; b=Ojux5sqItRcgf5uOVfsiRIBzGvzn1+yQR5K+Fzpu2RhgqUk7VHojE8oCEB4YnOaQYr H/Fai0qMfU9HUWmApnTSo8raid5ZfhRRfbHyfhoGNPp5aaTstcDtJbm266tijCSzuPHR b4ICW1HvxgKAIKmDJRPfj7yDxtF+sRI93zW5dzC6ihyyRSIimLkCEJtDDN2rqUf+sXcZ pVixi0ZqV0S70l6rR8gJPComHyy4zXi5YHZMlz383gev1bftv1eVvK7DoWGcja0j5gCf R8irECoD0zNWycinuQSP8VTkaDzAehN1hNol14CXJtRkHJsYGUFbd11anjSuU3+a+7ap GDRQ== X-Gm-Message-State: AGi0Pua4QNYR8bpnooaR+pNpBQAmp52GJml5atV7jO7/mB0iOifd9Q01 WKV2GyLsQQh7b7C8g5+S0vaL95Mp X-Google-Smtp-Source: APiQypI97SG7ijS/2cyxlqZCzzSf3XzW8o4s+4UTpY+trdi1Oww/Ussde+fJwy5bEHK/kNg5pQJdLg== X-Received: by 2002:a17:90a:2450:: with SMTP id h74mr729558pje.57.1587649692541; Thu, 23 Apr 2020 06:48:12 -0700 (PDT) Received: from localhost.localdomain ([2402:800:6374:f359:1ce8:a621:5f80:1116]) by smtp.gmail.com with ESMTPSA id z23sm2635958pfr.136.2020.04.23.06.48.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2020 06:48:12 -0700 (PDT) From: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= To: git@vger.kernel.org Cc: =?utf-8?b?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= Subject: [PATCH 5/4] fmt-merge-msg.c: fix `make sparse` on next Date: Thu, 23 Apr 2020 20:47:57 +0700 Message-Id: <20200423134811.8634-1-congdanhqx@gmail.com> X-Mailer: git-send-email 2.26.2.384.g435bf60bd5 In-Reply-To: References: MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Probably, un-necessary, since this is merged down to master. Signed-off-by: Đoàn Trần Công Danh --- fmt-merge-msg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fmt-merge-msg.c b/fmt-merge-msg.c index 08022ed2e4..72d32bd73b 100644 --- a/fmt-merge-msg.c +++ b/fmt-merge-msg.c @@ -484,7 +484,7 @@ static void fmt_merge_msg_sigs(struct strbuf *out) enum object_type type; unsigned long size, len; char *buf = read_object_file(oid, &type, &size); - struct signature_check sigc = { 0 }; + struct signature_check sigc = { NULL }; struct strbuf sig = STRBUF_INIT; if (!buf || type != OBJ_TAG)