From patchwork Mon Oct 8 17:16:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 10631057 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1D9CA112B for ; Mon, 8 Oct 2018 17:17:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 056DE28DAF for ; Mon, 8 Oct 2018 17:17:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED99A29481; Mon, 8 Oct 2018 17:16:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9266D292AC for ; Mon, 8 Oct 2018 17:16:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726383AbeJIA3l (ORCPT ); Mon, 8 Oct 2018 20:29:41 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:32784 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbeJIA3k (ORCPT ); Mon, 8 Oct 2018 20:29:40 -0400 Received: by mail-pg1-f195.google.com with SMTP id y18-v6so8133819pge.0 for ; Mon, 08 Oct 2018 10:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=CN5s4ecUj3pRaRBc5F3N9iKtufjq28Ma2Mtwvzmhwvk=; b=dWns1hS3LQOD2KVT0K6ESnWaao0gmLhx41081rKNIPthLpS42aVeGylCgnSwvR+HrM 0kM5Elrfw/6J9bS79uzRnieYgckNSoNvaa9zt7Y04KERCGtbgVdgLv9dsfr/WfctPXNV RRHsACNno2glKZxuWoXtwl/PqSc02R6VYbouo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CN5s4ecUj3pRaRBc5F3N9iKtufjq28Ma2Mtwvzmhwvk=; b=p5pCDujQ3AY9he5GH2E4AV/dy9RO1QTcHD3+s7WmuNPza+YIUXBO2jmlye3SqULG2T 2T9Sg9JSnjz14G+inQ3lb6QFuwqjIdPrkVQPYth3hQvRsXMC49MQo5dImWlF4S8JobtQ ra1FoC1MvCPXXSMjSSR1BpULJi/+I7CqSi+ezp+FCwMKp6plC+3qPyw4EsZqxjBs5hyp JHUT7hBMXm1tmVbG3OurZLfGl6hUKw8b4W0/LvjnnUAdAdHnGp/f45QgDhFT43dkdOe3 Fn3DMM2n5FtWLaqaGiWhUSrLY1616WTc8oi3uLnaSGXXEMjCZgBxkSCDd5ErO80pbn1K IiPQ== X-Gm-Message-State: ABuFfojb8r/Pem3lvjD47GsNqiNWNCmPBv6+8BbpI5eSoUA5SgXcCEYm BQi1hCNe/Psqpl0IMmHuOVDv X-Google-Smtp-Source: ACcGV63Xl/ug1qVoaqEwmXVQL4i/bmJvGXNSIAStTJmXckElj4a8fcpOwiGVVcBHsan+QKZW9ZYiKw== X-Received: by 2002:a62:71c4:: with SMTP id m187-v6mr25858021pfc.232.1539019017811; Mon, 08 Oct 2018 10:16:57 -0700 (PDT) Received: from localhost.localdomain ([2409:4072:996:3731:9fd:1785:d893:1e98]) by smtp.gmail.com with ESMTPSA id y24-v6sm8288974pfn.123.2018.10.08.10.16.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Oct 2018 10:16:57 -0700 (PDT) From: Manivannan Sadhasivam To: vkoul@kernel.org Cc: afaerber@suse.de, dmaengine@vger.kernel.org, liuwei@actions-semi.com, 96boards@ucrobotics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hzhang@ucrobotics.com, bdong@ucrobotics.com, manivannanece23@gmail.com, thomas.liau@actions-semi.com, pn@denx.de, edgar.righi@lsitec.org.br, Manivannan Sadhasivam Subject: [PATCH] dmaengine: owl: Fix warnings generated during build Date: Mon, 8 Oct 2018 22:46:31 +0530 Message-Id: <20181008171631.5603-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Following warnings are generated when compiled with W=1, drivers/dma/owl-dma.c:170: warning: Function parameter or member 'cyclic' not described in 'owl_dma_txd' drivers/dma/owl-dma.c:198: warning: Function parameter or member 'cfg' not described in 'owl_dma_vchan' drivers/dma/owl-dma.c:198: warning: Function parameter or member 'drq' not described in 'owl_dma_vchan' drivers/dma/owl-dma.c:225: warning: Function parameter or member 'irq' not described in 'owl_dma' Fix this by adding comments for relevant struct members to appear in kernel-doc. Fixes: d64e1b3f5cce ("dmaengine: owl: Add Slave and Cyclic mode support for Actions Semi Owl S900 SoC") Reported-by: Vinod Koul Signed-off-by: Manivannan Sadhasivam Reviewed-by: Andreas Färber --- drivers/dma/owl-dma.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c index 1d26db4c9229..90bbcef99ef8 100644 --- a/drivers/dma/owl-dma.c +++ b/drivers/dma/owl-dma.c @@ -162,6 +162,7 @@ struct owl_dma_lli { * struct owl_dma_txd - Wrapper for struct dma_async_tx_descriptor * @vd: virtual DMA descriptor * @lli_list: link list of lli nodes + * @cyclic: flag to indicate cyclic transfers */ struct owl_dma_txd { struct virt_dma_desc vd; @@ -188,6 +189,8 @@ struct owl_dma_pchan { * @vc: wrappped virtual channel * @pchan: the physical channel utilized by this channel * @txd: active transaction on this channel + * @cfg: slave configuration for this channel + * @drq: physical DMA request ID for this channel */ struct owl_dma_vchan { struct virt_dma_chan vc; @@ -204,6 +207,7 @@ struct owl_dma_vchan { * @clk: clock for the DMA controller * @lock: a lock to use when change DMA controller global register * @lli_pool: a pool for the LLI descriptors + * @irq: interrupt ID for the DMA controller * @nr_pchans: the number of physical channels * @pchans: array of data for the physical channels * @nr_vchans: the number of physical channels