From patchwork Thu May 7 19:20:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 11534775 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 22A4792A for ; Thu, 7 May 2020 19:15:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BED52184D for ; Thu, 7 May 2020 19:15:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588878935; bh=ZPm1lXreSdVxT/TB7RrJsuJK7F5PayuZXbIMXSCMsAY=; h=Date:From:To:Cc:Subject:List-ID:From; b=2CvwSQpIGUZX6/hPRHjzIc8SFT43RXUdb8V/ilPQ6x0s5vZsHtyZkmcgio1u0heut hkqDIhz6XRchfFMit1mnDtM+2fEcy4q6EZWnieutK8zqm8denu6fCTvOvtSSkne0e5 3dFfpIR+4dSSb7NfaDFFg/IwbTPMEPjT0Avi0EZo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728605AbgEGTPe (ORCPT ); Thu, 7 May 2020 15:15:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:39298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbgEGTPe (ORCPT ); Thu, 7 May 2020 15:15:34 -0400 Received: from embeddedor (unknown [189.207.59.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5EF12208E4; Thu, 7 May 2020 19:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588878933; bh=ZPm1lXreSdVxT/TB7RrJsuJK7F5PayuZXbIMXSCMsAY=; h=Date:From:To:Cc:Subject:From; b=vlko1ZXU6sxyMwVHztzLWGJbGIgUyvcKyr7zJGP09DVL7Q53ijWDz62osbXgQtpqB m6+ktOxPTd8FWxurabY8spnYoPSq/8r1QDAPrYCIUwuHt+V27sKyMHKbZeYonoHLn9 +LBX/te2mO9bBc6Gi15U13IQoxBlukDWYHM+Zr+k= Date: Thu, 7 May 2020 14:20:00 -0500 From: "Gustavo A. R. Silva" To: Kyungmin Park , Andrzej Hajda Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: s5k5baf: Replace zero-length array with flexible-array Message-ID: <20200507192000.GA16098@embeddedor> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] sizeof(flexible-array-member) triggers a warning because flexible array members have incomplete type[1]. There are some instances of code in which the sizeof operator is being incorrectly/erroneously applied to zero-length arrays and the result is zero. Such instances may be hiding some bugs. So, this work (flexible-array member conversions) will also help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva --- drivers/media/i2c/s5k5baf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c index cdfe008ba39f..42584a088273 100644 --- a/drivers/media/i2c/s5k5baf.c +++ b/drivers/media/i2c/s5k5baf.c @@ -281,7 +281,7 @@ struct s5k5baf_fw { u16 id; u16 offset; } seq[0]; - u16 data[0]; + u16 data[]; }; struct s5k5baf {