From patchwork Fri May 15 21:28:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 11553073 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 14FD01391 for ; Fri, 15 May 2020 21:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3CD4207D0 for ; Fri, 15 May 2020 21:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589578178; bh=RNMsg/AOqipY6NFThZYJpUGXRNGY0wQRDMN3eKkahBo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=k4/siF21l1W+K4xiQZ4kvtNFHeR//p7Yz6Um9Gf+WJXhpPqZaZahA2c2XgYXInXxG WQX3TN0txbsqkS18+Et+/hbkFty+JpXk+tF71b3AB3HGRYJT7oucFYhQoKA0jth5kM omI9f6Wi/Q2q5UXRB39mx42DFJZHAAWHRneSIwI4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727933AbgEOV3G (ORCPT ); Fri, 15 May 2020 17:29:06 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:41786 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727922AbgEOV3G (ORCPT ); Fri, 15 May 2020 17:29:06 -0400 Received: by mail-pf1-f194.google.com with SMTP id 23so1592660pfy.8; Fri, 15 May 2020 14:29:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+C5HUmb0IVN2XUMtCx+958ASlteYAzKSr3n9xtQKd1o=; b=sjmJt+iGDzcAx/sJoynK2092IRpplkRBFKvE8SzJoTImgURQwF1+95B0lH32YGTQlx Nkxj0LdLaMogM/jD1n716idtha6ExL6H7iFa9vX/Bw639xmKZ4CJBBaHNMIipt3qT9Ue F99d/3wd8fCdZfeNJSIx6tUe/PSsCXxY2Qp+BkDuqX+9Qs4qJYfQl+eM+fyvk+ybOeVU wSIjtT2JQgIWjvjqcFZ2AYT0bBcQj363PxClrk2P3EY20eCf24ZYdkQvfO0lgw7fXrza SLI7FEHFO7Uer02fGPHdSG73D50AEQY24TDXAcMT1QqO/jI7C+qtQ5UEvu01h/Vtd9yD x8mw== X-Gm-Message-State: AOAM531+lkF3zUHdQpy7F465dWKz5qwkXKyTRF1smhzUdS2OXu2N3dw7 1nwCJXQRHUhdtzB+dENzks0= X-Google-Smtp-Source: ABdhPJx5aHzvT/Yod67FCxrd/rYpeLz+YvwfHeXEiG+n38C/BUT1hIQZlmj9K6EmCO5IWEzJJXgtBQ== X-Received: by 2002:a63:ef05:: with SMTP id u5mr4866245pgh.237.1589578144777; Fri, 15 May 2020 14:29:04 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id e18sm2688831pfh.75.2020.05.15.14.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:56 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 33D1942349; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH v2 12/15] ath10k: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:43 +0000 Message-Id: <20200515212846.1347-13-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: ath10k@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ drivers/net/wireless/ath/ath10k/sdio.c | 2 ++ drivers/net/wireless/ath/ath10k/snoc.c | 1 + 3 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 1d941d53fdc9..6bd0f3b518b9 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1767,6 +1767,7 @@ static void ath10k_pci_fw_dump_work(struct work_struct *work) scnprintf(guid, sizeof(guid), "n/a"); ath10k_err(ar, "firmware crashed! (guid %s)\n", guid); + module_firmware_crashed(); ath10k_print_driver_info(ar); ath10k_pci_dump_registers(ar, crash_data); ath10k_ce_dump_registers(ar, crash_data); @@ -2837,6 +2838,7 @@ static int ath10k_pci_hif_power_up(struct ath10k *ar, if (ret) { if (ath10k_pci_has_fw_crashed(ar)) { ath10k_warn(ar, "firmware crashed during chip reset\n"); + module_firmware_crashed(); ath10k_pci_fw_crashed_clear(ar); ath10k_pci_fw_crashed_dump(ar); } diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index e2aff2254a40..d34ad289380f 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -794,6 +794,7 @@ static int ath10k_sdio_mbox_proc_dbg_intr(struct ath10k *ar) /* TODO: Add firmware crash handling */ ath10k_warn(ar, "firmware crashed\n"); + module_firmware_crashed(); /* read counter to clear the interrupt, the debug error interrupt is * counter 0. @@ -915,6 +916,7 @@ static int ath10k_sdio_mbox_proc_cpu_intr(struct ath10k *ar) if (cpu_int_status & MBOX_CPU_STATUS_ENABLE_ASSERT_MASK) { ath10k_err(ar, "firmware crashed!\n"); queue_work(ar->workqueue, &ar->restart_work); + module_firmware_crashed(); } return ret; } diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index 354d49b1cd45..7cfc123c345c 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1451,6 +1451,7 @@ void ath10k_snoc_fw_crashed_dump(struct ath10k *ar) scnprintf(guid, sizeof(guid), "n/a"); ath10k_err(ar, "firmware crashed! (guid %s)\n", guid); + module_firmware_crashed(); ath10k_print_driver_info(ar); ath10k_msa_dump_memory(ar, crash_data); mutex_unlock(&ar->dump_mutex); From patchwork Fri May 15 21:28:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 11553069 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D6911739 for ; Fri, 15 May 2020 21:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C08082070A for ; Fri, 15 May 2020 21:29:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589578168; bh=ZfUVlJaeaKSRStF/trEpieR9P5r+zyJMM6uubu9p/3c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gcCauuX4DBavTrUU+0S3bWAl08I9sWslsNDnDcoUwM5TM31Lb2b19RNdG9RWwH80A JzxMHF7dT/VpYUeWjIg8RggWSpQETNPZKyXE6vdkTb1rFY91DlSd44CXRDhZ30PUpO 0xjI+0t5VBi08cQ+tBAOHBX68OTPE/XPGqVDVH/U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727966AbgEOV3I (ORCPT ); Fri, 15 May 2020 17:29:08 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:44006 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727927AbgEOV3H (ORCPT ); Fri, 15 May 2020 17:29:07 -0400 Received: by mail-pl1-f196.google.com with SMTP id k22so1420778pls.10; Fri, 15 May 2020 14:29:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aC7L6/f42/gPjIDsH2AkyT3HK+i3vctnLudoDWO4A04=; b=AjRDRWxVI1WN7GDdK6vjTn5SnQsS2mN8zRsjdrP7IWtWYZbszAuLxVMczdZJhB1b4l EjVWOyRKLCMJNfmtFed1M9mUiwjz6IfcQ/zdbqtgf68gVDwaT3GJVuGBTV9sQiqCinAi UwGyQ8QOVaEmITnedKpN8LBHVsga4l6aDUZ8uBzA+s8qnXeN3js0d4gH0RTrByZUr4fU Fhm+Zp2gxIMoKWSm3iFlccjku5CzAVa/OrP+3ti8mcJb68fZlG/iBUtfXTfoyqUVmw3O NA6d4RuTC4mA+QImQPBPxEZi+8vz2X6AG0yKeWfzBztGwAW1xvq978P2wusLN4c9u8d4 mslw== X-Gm-Message-State: AOAM531K7v+evP/tw2qlD6CfBRAeGsFAz12yq6TSCPH8/36ST4e3nsDQ ImtxfAyO6D7y8MizlDmzSQI= X-Google-Smtp-Source: ABdhPJxXNou50yIHSh6fq7UacJSKWUh4Fh8iActeIPzYhcfbgAV9CeFNZwMPi6ZjkC+/+JSXSaCiwQ== X-Received: by 2002:a17:90a:d818:: with SMTP id a24mr5616179pjv.75.1589578146344; Fri, 15 May 2020 14:29:06 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id w190sm2302171pfw.35.2020.05.15.14.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:29:04 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 42D5442376; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH v2 13/15] ath6kl: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:44 +0000 Message-Id: <20200515212846.1347-14-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: ath10k@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/wireless/ath/ath6kl/hif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net/wireless/ath/ath6kl/hif.c index d1942537ea10..cfd838607544 100644 --- a/drivers/net/wireless/ath/ath6kl/hif.c +++ b/drivers/net/wireless/ath/ath6kl/hif.c @@ -120,6 +120,7 @@ static int ath6kl_hif_proc_dbg_intr(struct ath6kl_device *dev) int ret; ath6kl_warn("firmware crashed\n"); + module_firmware_crashed(); /* * read counter to clear the interrupt, the debug error interrupt is From patchwork Fri May 15 21:28:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 11553071 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 99943739 for ; Fri, 15 May 2020 21:29:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82ECB2070A for ; Fri, 15 May 2020 21:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589578176; bh=hSudVJFyAZ9/J4REpJ76G/FrhB+ePdz7UgTctgDaIH8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ikhyBDtsYP/k32f69+QXI42wfN0Q8xTRlT3XWXaSBB+BI9ngpnxF6tCp1pvUOdW+u YVMg0sERutT8L+yPWeJKmNeyj2eB6tlTHYSkY1zbvjfu8V+ouBAeOeBg/8fwfEiXnh 9P0KOtMMZnx2gmY1I+dx6GVJae2wU4F0f0dgq3pk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727969AbgEOV3b (ORCPT ); Fri, 15 May 2020 17:29:31 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44667 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727942AbgEOV3H (ORCPT ); Fri, 15 May 2020 17:29:07 -0400 Received: by mail-pg1-f193.google.com with SMTP id b8so1587153pgi.11; Fri, 15 May 2020 14:29:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7iSHfXW9+fvDe3OMezoTpoZ6yc3BiswtzUTGtFdEoqM=; b=CWT3RSEsOAt3vxph1Drkp6lLCexue3b3KvLCldOnH8ALvAN+vG7ea8ubR3spND7fNJ jrosDF++LVePslD+xaXTT04Dr31BRgvteWo/uCtQqi4oif794PROe+fklD8OUKEqX4pA QG4wWoSauN0emeuSxha6yT8ugiYfMnV346cti0anyZR8Z/mDDmIpCO2Thvyp22N+lQeZ kTbgXNu6dlOitrhfpKl5z4QKE5wWxYyiNBtWDp59hDGh2rzVZMNfsCSsQxtPbismgFxD zuok7sbso5ktvEQvVHjRzuSbyvpON5p/VgfmCj5Zs6lbISK6e1gFECdajf/sQCQVnJek 6KhQ== X-Gm-Message-State: AOAM5320EiO4ESDUt3yjDQX383A+SPvM1GZR0amfD/fawwVeiraWdgom 8naqhOEHuEOtYF2c0FbXQuk= X-Google-Smtp-Source: ABdhPJy8UUPC9xXHxB4FjCVxUaLsmMMiDQI0BvVJYF+PqZUF0tKyMG2HswF59FK0uEUmrA4F0O6+Ng== X-Received: by 2002:a62:7d91:: with SMTP id y139mr5770731pfc.172.1589578147283; Fri, 15 May 2020 14:29:07 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id 25sm2281115pjk.50.2020.05.15.14.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:29:04 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 6016742380; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts Subject: [PATCH v2 14/15] brcm80211: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:45 +0000 Message-Id: <20200515212846.1347-15-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "Rafał Miłecki" Cc: Pieter-Paul Giesberts Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index c88655acc78c..d623f83568b3 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -1393,6 +1393,7 @@ void brcmf_fw_crashed(struct device *dev) struct brcmf_pub *drvr = bus_if->drvr; bphy_err(drvr, "Firmware has halted or crashed\n"); + module_firmware_crashed(); brcmf_dev_coredump(dev); From patchwork Fri May 15 21:28:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 11553065 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3D8A71391 for ; Fri, 15 May 2020 21:29:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 240752070A for ; Fri, 15 May 2020 21:29:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589578165; bh=axO7uaYrjQR5BXFcyfzz5CtxMgICxAqYcDU4Tgu6OYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FAIKU0sZKuZyf5PL8azhbQpui2na4kH0/zK+Ap/+q5q9kE6jO7A9vvqKAmwj8Kfns YqYof2h926Nv0G0PbT8OYmzNJ6DKnSKiAqQyaHqzHsDp42RkJTXg0xcoMjbXP+oQ+S 0nkyr6Yueg7ofXg77NgI9aD2SYHpR0JtGRONxVhk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728031AbgEOV3U (ORCPT ); Fri, 15 May 2020 17:29:20 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38031 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727972AbgEOV3J (ORCPT ); Fri, 15 May 2020 17:29:09 -0400 Received: by mail-pf1-f193.google.com with SMTP id y25so1601914pfn.5; Fri, 15 May 2020 14:29:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wyaNKYj+csWx0v5/RRrrvPiG/GlOrf9rCpyGTc2gDv0=; b=PNU2WB7xGk4aeo9LqsRnFBNqh2ufNpsh3E2UmToKGNuzHfu5s+ztk+s6S6VUKmq0C/ iwuKhe46HL2A2VjsuMCiBG1UUq668ruWKtTYFkzSo6RRrX/zBJOPXhRKnsWG3B0dZ2hW bWS2BRDcZKdi0ogAgjbkHYrTzBOU4NRKRmSTPmsBmzjqEpdkwG3CiEBpgHGmHoGOpB6R 79oBGxLCemAvW7+V9HRYSkPx8A6zubaw+QyShr460zkG2LBJNAtE7VyZ2ppalO/b0PTK iMKzu8k478e+nghLjgvLqcZuQkCqBKzZEUEUe5QfMFc988OM7X2xv4dSblScsJRps6Fl 5B1A== X-Gm-Message-State: AOAM531hGbKW+WC3F5TKCbWmueDzmsXgOmOREtXk4XgjwqnH/lMZEyw5 Y6Oh5B+/fqtxcGWbDJ81iE4= X-Google-Smtp-Source: ABdhPJzT8OuJIcMz4maB705Q5rp4ih5zCp5ALUBnEyTPR7+PH8X96oQqmCWUmGTpOQxsyRkd6WhDeA== X-Received: by 2002:aa7:8a92:: with SMTP id a18mr5990105pfc.0.1589578148396; Fri, 15 May 2020 14:29:08 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id 19sm2216513pjl.52.2020.05.15.14.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:29:04 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 7975D4238B; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, Lennert Buytenhek , "Gustavo A. R. Silva" , Johannes Berg , Ganapathi Bhat Subject: [PATCH v2 15/15] mwl8k: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:46 +0000 Message-Id: <20200515212846.1347-16-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: Lennert Buytenhek Cc: Kalle Valo Cc: "Gustavo A. R. Silva" Cc: Johannes Berg Cc: Ganapathi Bhat Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/wireless/marvell/mwl8k.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c index 97f23f93f6e7..d609ef1bb879 100644 --- a/drivers/net/wireless/marvell/mwl8k.c +++ b/drivers/net/wireless/marvell/mwl8k.c @@ -1551,6 +1551,7 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw) * the firmware has crashed */ if (priv->hw_restart_in_progress) { + module_firmware_crashed(); if (priv->hw_restart_owner == current) return 0; else