From patchwork Mon May 18 18:54:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 11556151 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1044713B4 for ; Mon, 18 May 2020 18:57:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07960207C4 for ; Mon, 18 May 2020 18:57:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="FxRZ1CkL"; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C0KuoYtF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07960207C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B74ED1771; Mon, 18 May 2020 20:56:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B74ED1771 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589828243; bh=md3VPrvK85HM5jK5awA0uE8ow+MthBQduGtpyMr5rFI=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=FxRZ1CkLVxW9dNoiL9qnQI99OpSUb8f3mB2hweCwqkPn4bycVVC2JHS2FQ3EzXJY0 NrReH54FJb3DacYOUTbldMDeuygjYvIy7OuLsi4ZpuThORsHxzfd9BdDeVWeyNnXhi VfnS9VBztecY02As+i8xUqJxXX8mOjXSiz1XRhcU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 291AFF801D8; Mon, 18 May 2020 20:56:37 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8AA49F801F9; Mon, 18 May 2020 20:56:34 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=3.4.0 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E850BF800C9 for ; Mon, 18 May 2020 20:56:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E850BF800C9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C0KuoYtF" Received: by mail-qt1-x842.google.com with SMTP id n22so6570373qtv.12 for ; Mon, 18 May 2020 11:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=PU9+FcYTmwz4OTF9GQsuEoV2hcNPVWJLTGkAqfHLxMk=; b=C0KuoYtFVZisDnqQE05n+kfcuQXzEF7n8pDJccnhcUsBSuZxSV8ywKLPIuTVZUIuWF 6Ef/IrJdr2TCV3rpfV+C3pL//E/Eh6v7LXI/NIMpBUhwrdHrOyDGTp3ZsTfeSShO7I9z ivX5TFEM7rYT6sTvrdnpklTFUMeWh8JEmdFTGiMKBlEWmEnd/352KlLKXcZjUQv1f1PK /Wwz3BJego7R/2lRHnKR7gtA2do5Z/HcC7qjwQeAaekfYcszHjGZq4HOzXVu72vQ8kSv iJtsbuqUWnCNSzHtGUq5leR3Nk3apN93/xuDoilW+1v80catFe/SjmPf0SQYIJdRB+ta IXnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PU9+FcYTmwz4OTF9GQsuEoV2hcNPVWJLTGkAqfHLxMk=; b=SsXjk6chudOvSFzBm5pj0achVfiUaEUjBSwbyZrR1IrpxgJ1pB73YdajtZoQr0sPxf C6XlnZGbTzlBrXxyrv5FoSJRtcx/Z4ghmqvAMXOA4aZiImGf/Uw9BtfyAIePxHl6FIr7 ql+21WfompWuU8XbcTNPrHjzImgnwJxqstyv5n14cr5euCgsbZS4dn3pcGRW0aosHnqP eCo91qldNfFkKYsM8Yrkeo87wavMjN/+1ZLQHP7sYniRCox2W5TTM8Z2WTtJD8n1x46D JEcAsqPeb/ZYhkIPiXTyaoi/e8/m60ksEQs4CosbM5u0pPaZogOe2eJcnVA3X52NsiXs BwqA== X-Gm-Message-State: AOAM530CG1Qrc4wjqIV8FqLx+wvVfKAUg9NG0ZVXeosgnsCfc8xC3oU4 7+qsbekvXLQ7ZTSiby+IC7U= X-Google-Smtp-Source: ABdhPJyZtx8fMKUs/SXXvW7jKM9WwWcKcful398CGMWm5Ep+MXlfGNs+sCUew/EPCXyV+NmSPB/3pA== X-Received: by 2002:aed:3889:: with SMTP id k9mr18460028qte.347.1589828183745; Mon, 18 May 2020 11:56:23 -0700 (PDT) Received: from localhost.localdomain ([177.194.72.74]) by smtp.gmail.com with ESMTPSA id u39sm6040770qtc.8.2020.05.18.11.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 11:56:22 -0700 (PDT) From: Fabio Estevam To: broonie@kernel.org Subject: [PATCH 1/2] ASoC: fsl_micfil: Remove unneeded ifdef's Date: Mon, 18 May 2020 15:54:47 -0300 Message-Id: <20200518185448.6116-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 Cc: cosmin.samoila@nxp.com, alsa-devel@alsa-project.org, Fabio Estevam X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" There is no need to use ifdef's around the power managament related functions, as they are already using the __maybe_unused notation. Signed-off-by: Fabio Estevam --- sound/soc/fsl/fsl_micfil.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index e73bd6570a08..1c51bd720e6b 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -753,7 +753,6 @@ static int fsl_micfil_probe(struct platform_device *pdev) return ret; } -#ifdef CONFIG_PM static int __maybe_unused fsl_micfil_runtime_suspend(struct device *dev) { struct fsl_micfil *micfil = dev_get_drvdata(dev); @@ -780,9 +779,7 @@ static int __maybe_unused fsl_micfil_runtime_resume(struct device *dev) return 0; } -#endif /* CONFIG_PM*/ -#ifdef CONFIG_PM_SLEEP static int __maybe_unused fsl_micfil_suspend(struct device *dev) { pm_runtime_force_suspend(dev); @@ -796,7 +793,6 @@ static int __maybe_unused fsl_micfil_resume(struct device *dev) return 0; } -#endif /* CONFIG_PM_SLEEP */ static const struct dev_pm_ops fsl_micfil_pm_ops = { SET_RUNTIME_PM_OPS(fsl_micfil_runtime_suspend, From patchwork Mon May 18 18:54:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 11556153 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EE7B013B4 for ; Mon, 18 May 2020 18:58:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 844C3207C4 for ; Mon, 18 May 2020 18:58:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="XOxbM1rd"; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MTQPtufS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 844C3207C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D72051789; Mon, 18 May 2020 20:57:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D72051789 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589828296; bh=TWYEtptr4tbJ4TkUF6S5C+wsp6xzyYuTx9j4EOgrydo=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XOxbM1rdswRtIVLm7RdBanMTglGl4LVS63ohLNInRxznZskx3QDogtvEXDXSQw3ts I5/XOPpRABt2jzEa5szq+YW0jyrVD2nqalStuZz0BGJFljA3osZEHguum3+FKodzLw ZyrUeUUZfBak2HSQ3dWLqmm+arAJx3tSfzvEvevs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A43DDF80213; Mon, 18 May 2020 20:56:40 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5923CF801DA; Mon, 18 May 2020 20:56:36 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE autolearn=disabled version=3.4.0 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BB57DF80086 for ; Mon, 18 May 2020 20:56:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BB57DF80086 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MTQPtufS" Received: by mail-qt1-x844.google.com with SMTP id c24so9028346qtw.7 for ; Mon, 18 May 2020 11:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kkPmHDM6lPrQmd1eFqwAKBCn0O3Oqdax7ohsEkmNUlo=; b=MTQPtufSbxR2WjsfL/ODLqDadbxWORH7uiY920YkZtdL/6O1k1k3bZzgggqtGNrSCq K5zUFHiaqjjQMVPRDRDdKYh1dYsqdM08dU8KPm+LL0dR6X6XgXfubBUMS4KohYBu/cAZ fUULDzMRxChsTRzab1RfaM7it4anX/CMZBvFmQi9uUP7y8wHXshVeFvqDeK+iG/eqjjf /63gApOJ3CzZPwVOYtFtEXq7n5qZxUHHp+vrs0OnOMCoV2t0EbLBI382Sp+wz2u8Znp/ rSvIGCpIuYRzylbKgAAwW6atEXOHaqlhnanAtNXhPi7WGhqpWSDAGVz1azobgCvGcgjQ /z8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kkPmHDM6lPrQmd1eFqwAKBCn0O3Oqdax7ohsEkmNUlo=; b=KWLR5cZMlLYimG+21YaaLJdIjua7WFhpKx8pD+5S9Sal9N8VYEvQ1suTG/CcMw09HG 0x3qhno690e4MRW7wj9+DUf/jY/Lno6+B8qSipXt8hcPGB/pRKdVQYOzm7BH/OcRdUtB EfXfBDtoN9fCiTFr/7Z+IAh0dE6hOsTZQwXcwiT2appyXhuOWbik6Nq9CjZAWYao6kAX AZULIDz2nTn3k3VD4iDMUMyozwH6h+CCwsSrGH9di5MOl2P8NSPkmPn3LOOXBY8SOqQo PJAcs1Ieav9Jm8uRNL5t2xveq0/JNtJjgg207Qbnfnl2utuSxNaPkE+dplyUTyY1TgR8 zA3w== X-Gm-Message-State: AOAM532jI6C+LHkBy0n0NGeKX3rOEMgLBMSApWmrcGNC/HuwVxtL+clW 7EoMAX8YWe7hixhhdIoCVn0= X-Google-Smtp-Source: ABdhPJz5iWV9niEHNJbT/Ssc4punhZon2ginSENfYHSaAAl/Az7RJS0VeCyocyQzKgOX53f3XGewfw== X-Received: by 2002:ac8:7b45:: with SMTP id m5mr17902665qtu.329.1589828186127; Mon, 18 May 2020 11:56:26 -0700 (PDT) Received: from localhost.localdomain ([177.194.72.74]) by smtp.gmail.com with ESMTPSA id u39sm6040770qtc.8.2020.05.18.11.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 11:56:25 -0700 (PDT) From: Fabio Estevam To: broonie@kernel.org Subject: [PATCH 2/2] ASoC: fsl_micfil: Do not pass irq numbers in comments Date: Mon, 18 May 2020 15:54:48 -0300 Message-Id: <20200518185448.6116-2-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200518185448.6116-1-festevam@gmail.com> References: <20200518185448.6116-1-festevam@gmail.com> Cc: cosmin.samoila@nxp.com, alsa-devel@alsa-project.org, Fabio Estevam X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The IRQ numbers may change depending on the SoC, so do not pass the IRQ numbers in the comments. Signed-off-by: Fabio Estevam --- sound/soc/fsl/fsl_micfil.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 1c51bd720e6b..c62cc8b41ff0 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -709,7 +709,7 @@ static int fsl_micfil_probe(struct platform_device *pdev) if (of_property_read_bool(np, "fsl,shared-interrupt")) irqflag = IRQF_SHARED; - /* Digital Microphone interface interrupt - IRQ 109 */ + /* Digital Microphone interface interrupt */ ret = devm_request_irq(&pdev->dev, micfil->irq[0], micfil_isr, irqflag, micfil->name, micfil); @@ -719,7 +719,7 @@ static int fsl_micfil_probe(struct platform_device *pdev) return ret; } - /* Digital Microphone interface error interrupt - IRQ 110 */ + /* Digital Microphone interface error interrupt */ ret = devm_request_irq(&pdev->dev, micfil->irq[1], micfil_err_isr, irqflag, micfil->name, micfil);