From patchwork Tue May 19 14:34:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 11557883 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6921314B7 for ; Tue, 19 May 2020 14:35:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63E2D204EA for ; Tue, 19 May 2020 14:35:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="afppGT5K"; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="na9T+Zvz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63E2D204EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C5ACB175B; Tue, 19 May 2020 16:34:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C5ACB175B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589898913; bh=2H2gOvr+YamZU6rtRCJE3v1l1sQPUZyZqFDThELZEMk=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=afppGT5Kb1IAKhBaSbyZV7Ani2ig1DuMBjmqgKrRoKDj4EbL+2FrRgYaq+b2dLO06 QVncCFLLlmxz0l3piyLmjCMpja+XO0m6WjLxfIQWbFKb8vAo9R0T72SJ/pNx0BAofA bcev9qY3+jZ5AtXqEr/KFXv9GixETkHfOTJnWe3E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3C97FF80229; Tue, 19 May 2020 16:34:27 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id B8866F80256; Tue, 19 May 2020 16:34:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: * X-Spam-Status: No, score=1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, FORGED_SPF_HELO,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-eopbgr750077.outbound.protection.outlook.com [40.107.75.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 30915F80161 for ; Tue, 19 May 2020 16:34:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 30915F80161 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="na9T+Zvz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mY+kdYU6rq9M4lakR4NcaK9ACy81McMLLjr5GKpfdkCuBFuIzWjkN+n7SWhiJOlu8rOK5FrwqxeMbZgi2dU0sAcejnZ9TYvW/EW4bcY+ChsdYQVnTudYgaWTi7RU8afrKSWrCLSPD89CzZXnuHnXgNQhj3YFSr0DhuNacrusV1ln6F6kG4N4ZlOBz7ySSJIXAnnBj1rkTqKMuHiv21R9d1UFf0RXxm8oVvnAjcKfjv9X//1YsQYmp637IIbA8txFTuVFcXdWXNDIC3ur5IYRrfhBJkh1opZNCWJEAmykK/T9A2Y8JYcGVk1O4JsgMF2WHyhnNoGQsn348DkrlSvjLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bhaz8gayckoLhVCuSSb2fd/ZvTYXq/lpCUbMx6i+kDA=; b=TZm+Gj1uLq/a3HJHqc7nJjsRTXDqJPQSNQcwnjptvMa86J/CioY+EyWB1rmRzZ4EzmbRLjf4o7XLgIbefU61F3IuKGnvUl02xzYeAQG0nI01QHhKuyJp0QG3Bt0gyjgeTesLHifFScj6p5HH+YBHzXSRhlOwA0mGCEr6tIPIJ3NvwMkDOG1RmYccvyAnOYiv4IhR/Wnmk5abZ5XK505AdxpEtbvod2J7L0Gjm800HoPfuUFo2CWh1kcYcao2HiLtvGrRjnPvkCHAnFd7wfRVRSWZMU+3BBwxOcifIXuMEWl1C6TcD2XlDLMp4erYhzygIvjHoE72zUSlgf9l9DJibw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none (sender ip is 165.204.84.17) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=amd.com; dmarc=permerror action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bhaz8gayckoLhVCuSSb2fd/ZvTYXq/lpCUbMx6i+kDA=; b=na9T+Zvz2EluLVMNsa5UlxJ3bUGkH7kZVPYbqrc9coelaFhazVrOa3FRa64gVUwhPGXToBs4q+gUDLFpZtat0AOdGAaEUCvNGUg+eN/bv5ebZuMKPwuzMmHjJs7HF0a8j/5Zjk8hCty56Jd2t7V9BAgKm92qcMAT13Drz+IVBow= Received: from DM3PR14CA0136.namprd14.prod.outlook.com (2603:10b6:0:53::20) by DM5SPR00MB254.namprd12.prod.outlook.com (2603:10b6:3:7a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Tue, 19 May 2020 14:34:13 +0000 Received: from DM6NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:0:53:cafe::33) by DM3PR14CA0136.outlook.office365.com (2603:10b6:0:53::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Tue, 19 May 2020 14:34:13 +0000 X-MS-Exchange-Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=permerror action=none header.from=amd.com; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from SATLEXMB02.amd.com (165.204.84.17) by DM6NAM11FT023.mail.protection.outlook.com (10.13.173.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3000.19 via Frontend Transport; Tue, 19 May 2020 14:34:12 +0000 Received: from SATLEXMB02.amd.com (10.181.40.143) by SATLEXMB02.amd.com (10.181.40.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 May 2020 09:34:11 -0500 Received: from atgasia02.amd.com (10.180.168.240) by SATLEXMB02.amd.com (10.181.40.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Tue, 19 May 2020 09:34:10 -0500 From: Vijendar Mukunda To: , , Subject: [PATCH 1/3] ASoC: amd: fix kernel warning Date: Tue, 19 May 2020 22:34:20 +0800 Message-ID: <20200519143422.18255-1-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SATLEXMB02.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(39860400002)(136003)(376002)(46966005)(86362001)(8936002)(186003)(110136005)(26005)(336012)(54906003)(8676002)(316002)(426003)(82740400003)(82310400002)(4326008)(356005)(81166007)(7696005)(47076004)(70206006)(5660300002)(70586007)(1076003)(4744005)(2906002)(2616005)(36756003)(478600001)(6666004); DIR:OUT; SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22cf9c82-9679-4616-68fa-08d7fc01b300 X-MS-TrafficTypeDiagnostic: DM5SPR00MB254: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:741; X-Forefront-PRVS: 040866B734 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lAGgC/hIk1AY99CaAK97wIbdBNJnMUmOHom2+alObBKD8APGXuxSpeSQEfBH4hOkkZzINQOlPgWTHdvdGg5vVPVTsBR0ppHL6i8G5Z0YtE2MOMcUd7BawQNRAi74sIHU3bCZ1aCcO0YtyND9XhE8X6fgXFo/epao20YnvHAZ1cvy7YWrJDcr8iydovRn5hQ2AStjHvReArims8nTi+HMvIJCOsuDbllxa18b40HbNh7lDYsha990jeJDnZlxEwkVqnp/m/tC3kherZAcsZW+vebEToANNQmF5Batl3R1/Ul/ng1UQAVLBRmWca5u8dW+NDXo88qogvpeluptejgrkIeBX+1a2g07N4h43NuWH2RKa8V+9DoEWslg4fT8wTStcom/26WmvhWlT8cKMHFR4Q== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 14:34:12.3630 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22cf9c82-9679-4616-68fa-08d7fc01b300 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5SPR00MB254 Cc: Alexander.Deucher@amd.com, kbuild test robot , Vijendar Mukunda X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Removed unused variable from code to fix the kernel warning. Reported-by: kbuild test robot Signed-off-by: Vijendar Mukunda --- sound/soc/amd/renoir/acp3x-pdm-dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c index 942010021319..b33c7aec7481 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -150,12 +150,11 @@ static int start_pdm_dma(void __iomem *acp_base) static int stop_pdm_dma(void __iomem *acp_base) { - u32 pdm_enable, pdm_dma_enable, pdm_fifo_flush; + u32 pdm_enable, pdm_dma_enable; int timeout; pdm_enable = 0x00; pdm_dma_enable = 0x00; - pdm_fifo_flush = 0x00; pdm_enable = rn_readl(acp_base + ACP_WOV_PDM_ENABLE); pdm_dma_enable = rn_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE); From patchwork Tue May 19 14:34:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 11557893 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EF63E159A for ; Tue, 19 May 2020 14:36:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 868CC20709 for ; Tue, 19 May 2020 14:36:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="piDdO9dl"; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="S2oUXP0U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 868CC20709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CC6D91778; Tue, 19 May 2020 16:35:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CC6D91778 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589898966; bh=5zq728ZJV6eCyVD31I23xaHIb1to1LqEGPxyB7LPNKo=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=piDdO9dlwR/CIAO8HCpjWTuIraJmsapATvbCDUS5+DNbFyOfNNBEaViXlz3y6VWWa saTrEHuNFmPQNkDMMPwiRkElQlGcjXf0WJuDZc5bTzzyW8c+ngcXiZ0OPU04mEBSBI ljhdMKLOkd0ViJkfsbqQJNzBTecgEN/ScN/SZA40= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9BC21F801A3; Tue, 19 May 2020 16:34:30 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 279AAF80274; Tue, 19 May 2020 16:34:29 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: * X-Spam-Status: No, score=1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, FORGED_SPF_HELO,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2081.outbound.protection.outlook.com [40.107.220.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1C8DDF80132 for ; Tue, 19 May 2020 16:34:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1C8DDF80132 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="S2oUXP0U" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L+fhzvIxBYFDDgIyxqKAiajoblzpKaUyadqf/JLOuTDrIVbT8yvt/rrX4dcxgCvl0ZRu1ztn3cM7RtONh6YSmcjUMCX2CSCvcXUTtVRYXqp8QYKtGK1HMn/yDXElkeovurEcsTgxIRMnqOgDI8eJgyknt+XNMq6ohf5bhfMCfJQAVPHbRpngPM8s/fs4IFQJ1QzkUVAu63c0alryfNqAsXVxq8gVwn7aW1Es5Lwfi9aVZiIPaC7yq/SWBK61kXkwmSywd1pIvAn2tZGKRdojJtQ3Biihn+KZxb3LXY+D7KFgdWhxtr8wyHq3ixhbbVxzFRGg2gzX5626rvAek9uadw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=65EJ+LS6E2tMFYhiIfl2qPreF5KMA1DrWaw95vuZ1xk=; b=HjxsRayF9TDk3uH6N0KeJxxtLqy4THLCRfXrc0sOUnkruRmxm/mVfz7J2e3x/GH6lUMvvoiZCMRn+40SmFYZyPbbDzWS78jDHvyVoj9/yBNsIm/nLk/al3WKQBm5nTgveYS00CfYmazY6E+9JFoVVsUt2dNPnwz4oU3w+GjvtQseEmWRE2m8uuWhLI2Tp9mwMt39whQVJr150bGodAHEgqk9NmkeKAEK9RmYG9X8KQg03iSYaC69z0IRJI07yiiWeAC/CjJ1ft7At/6EZyIffskZqaOAaE/4YjTp7THbl4dS800ZxAHq0PrSAquhGa32ZvRxISVnBukIp7YpRrnocQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none (sender ip is 165.204.84.17) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=amd.com; dmarc=permerror action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=65EJ+LS6E2tMFYhiIfl2qPreF5KMA1DrWaw95vuZ1xk=; b=S2oUXP0U11lrfVBoD5C65D3q/1NnYNFaoeHeituwPxZFNCeAULL95aVzDdfyFMAmS2W+phTU2Ubo/2CC1jrD6xQDxg1Yl2X1imDYfi3VkbziQaN4TwuobJRHAGga8qII+56jzoYebCDyVK7iCkFb8i0a9eflg+Qp75lEKCmpzzY= Received: from MWHPR11CA0013.namprd11.prod.outlook.com (2603:10b6:301:1::23) by BY5PR12MB4291.namprd12.prod.outlook.com (2603:10b6:a03:20c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Tue, 19 May 2020 14:34:16 +0000 Received: from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:301:1:cafe::2) by MWHPR11CA0013.outlook.office365.com (2603:10b6:301:1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Tue, 19 May 2020 14:34:16 +0000 X-MS-Exchange-Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=permerror action=none header.from=amd.com; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from SATLEXMB01.amd.com (165.204.84.17) by CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3000.19 via Frontend Transport; Tue, 19 May 2020 14:34:14 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB01.amd.com (10.181.40.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 May 2020 09:34:13 -0500 Received: from SATLEXMB02.amd.com (10.181.40.143) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 May 2020 09:34:13 -0500 Received: from atgasia02.amd.com (10.180.168.240) by SATLEXMB02.amd.com (10.181.40.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Tue, 19 May 2020 09:34:12 -0500 From: Vijendar Mukunda To: , , Subject: [PATCH 2/3] ASoC: amd: refactoring dai_hw_params() callback Date: Tue, 19 May 2020 22:34:21 +0800 Message-ID: <20200519143422.18255-2-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200519143422.18255-1-Vijendar.Mukunda@amd.com> References: <20200519143422.18255-1-Vijendar.Mukunda@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SATLEXMB01.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(396003)(346002)(376002)(46966005)(2616005)(26005)(8676002)(70206006)(70586007)(478600001)(426003)(2906002)(336012)(36756003)(6666004)(4326008)(86362001)(47076004)(5660300002)(82740400003)(1076003)(7696005)(54906003)(110136005)(82310400002)(356005)(81166007)(316002)(8936002)(186003); DIR:OUT; SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6745f6b3-8b10-4687-2443-08d7fc01b44f X-MS-TrafficTypeDiagnostic: BY5PR12MB4291: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:469; X-Forefront-PRVS: 040866B734 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w85ZwDC64Vf+ifPKGT98NiP5cxPMWCmuuABlah0eUFZ8N7aelz9nnkX8L7PZSPSB8vpQI6NjyiovU8K1+AFvsqdLf82PxaNQbkkMdyij9+3vccGHK7yyHkeow8e7go9V6brx1LI6r5X9auEBjvFrkvNp5dZdJD31qo7jkYNKr3sXpuqIscW3jg51WzpHagdXd2bzHlPzjlBalje5o6XuqLVe9xoSEqJL1GdI5WImW7pefDe87WdAX3SkJa5BArH1pSvLIRWqeuMgnBbSXcstWWNDJsQpYeaMwYNFgU59ebx22y2DSXpGJP3JjfTe9DH9eHnZ8Usw1R3jXEf/nQw+jtKH4xFIem14xeYlzufoSHn7VDogPlx2n449c5pmQpSjjyXiVWHGGm8nIqTL1RobVZbdTRnEsTPFS/JS7gvVYRX3ZyLErYzYr/tf/7SNvVipbhEy43RiVkSDJSLMCUfQa1c+ZUkXvK4ncmQQVW1snan/2OEC11YkFqpv2b3ycWeFZcuycm+1hpIkM0NNMzn6EA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 14:34:14.4727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6745f6b3-8b10-4687-2443-08d7fc01b44f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4291 Cc: Alexander.Deucher@amd.com, Vijendar Mukunda X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Removed api config_pdm_stream_params(). Modified switch case for channel check. Default case should return -EINVAL. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/renoir/acp3x-pdm-dma.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c index b33c7aec7481..623dfd3ea705 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -72,14 +72,6 @@ static void init_pdm_ring_buffer(u32 physical_addr, rn_writel(0x01, acp_base + ACPAXI2AXI_ATU_CTRL); } -static void config_pdm_stream_params(unsigned int ch_mask, - void __iomem *acp_base) -{ - rn_writel(ch_mask, acp_base + ACP_WOV_PDM_NO_OF_CHANNELS); - rn_writel(PDM_DECIMATION_FACTOR, acp_base + - ACP_WOV_PDM_DECIMATION_FACTOR); -} - static void enable_pdm_clock(void __iomem *acp_base) { u32 pdm_clk_enable, pdm_ctrl; @@ -332,11 +324,14 @@ static int acp_pdm_dai_hw_params(struct snd_pcm_substream *substream, rtd = substream->runtime->private_data; switch (params_channels(params)) { case TWO_CH: - default: ch_mask = 0x00; break; + default: + return -EINVAL; } - config_pdm_stream_params(ch_mask, rtd->acp_base); + rn_writel(ch_mask, rtd->acp_base + ACP_WOV_PDM_NO_OF_CHANNELS); + rn_writel(PDM_DECIMATION_FACTOR, rtd->acp_base + + ACP_WOV_PDM_DECIMATION_FACTOR); return 0; } From patchwork Tue May 19 14:34:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 11557911 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 76206138A for ; Tue, 19 May 2020 14:36:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D9B5206BE for ; Tue, 19 May 2020 14:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="WSeOrjjw"; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="mu8LsIaq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D9B5206BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 58C45178E; Tue, 19 May 2020 16:36:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 58C45178E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589899017; bh=+rtQIVXJK+v3Q1TbGc09SWAwI2gF9as/sfKN1D3TrBA=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WSeOrjjwNJzbCsaS+DVZMlzWAhVLpW8bowZzcKX0z483MpO2aGga/GJWVhaBb8F8R iCz4UzO6BoLkdUYnkUIL5JkicJFRPl+AurH5CQVVT5t2llkUWiolqeqatvb0L5p4wd rPILAHh+F8kcEr0aOIp5xjR7x52qNs0sfTB17RTU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 782B2F80299; Tue, 19 May 2020 16:34:34 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7B185F80259; Tue, 19 May 2020 16:34:30 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: * X-Spam-Status: No, score=1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, FORGED_SPF_HELO,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2059.outbound.protection.outlook.com [40.107.237.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4186FF801A3 for ; Tue, 19 May 2020 16:34:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4186FF801A3 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="mu8LsIaq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DowwdH4nqhv5pvR/aG4KGtZfVa/DoN4OrVwK1egeF7w+xndkmGeXsOdapEEoGOmZAE5OaJmsVL3S+MpYDvyK7On4rM43iuvA5NvwBdLgtKf/jPdpmQBNPODKBjwjIzYRFQ39MGLyHRiMxRwvWDbcABxgsLPQ3Tsqd1KsZf9YaEW5kBQa1ovlyJtJs2Rj7Gm3rpZO29WOXz/DCqz8hxBJMbIIo89yCd3ajiMgzkw5f0LgVYBWwYqtya6UPPCziRKLQhQP/5zJI/in+jwutQl3USICBY278uMjD0PdUFuPe1hoC5TwKs4mrlbK7V/aFpzo3swf9TYIJ1r/Kw2Sao/QEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wEyqXWM9Epe0m/NPV0N8dBhNrc6Qd2arc8Ntt6CN1wE=; b=eIq8G+dFq36OqVCHL3eA5s+hPK1wqdE/w89C0XoZzQ9VXgBfg0kB8WOcGOHPyWqo0NcZlgROGkuLt1ZxizMoTOvUVFMJdlARDwAsqHzpBvbON3GhFwzVYJcZD/YBaZvEQPLO/5f6nqIlksXc/iVb2+b2XM14yi5hhmWh31vPR9oc2XLCfxWkqkAi2TYqoznsCcwVo819KtDqtFxhZu333zAQi5EL35cyA9VNX2KLc+eu5R3XDlD/T/RuJvdipHLq6Bw2H81TmVuXjrrclyZrxi/vI2+rzBPCovOL0mALPMTMcOTbUYoh9L7hhcGa69DYDRZVe2iOIbgg+Wo3WqtXHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none (sender ip is 165.204.84.17) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=amd.com; dmarc=permerror action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wEyqXWM9Epe0m/NPV0N8dBhNrc6Qd2arc8Ntt6CN1wE=; b=mu8LsIaqu5mZq7DJ30YrhK2yh26KxNfJanLz+M3SHIntWi2IogDdsSjaksEqk0X2g+WygMtdke3s0Ye3SKqQZzKEHiJpSCCECVSf3xyTSzJsKhjS8pbYnyqDym4g5LhzW9laTHzl09YIvGeV6pF9uGeU/bvfYqlscu2ZKHP3VqM= Received: from DM3PR14CA0146.namprd14.prod.outlook.com (2603:10b6:0:53::30) by BY5PR12MB4019.namprd12.prod.outlook.com (2603:10b6:a03:1a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Tue, 19 May 2020 14:34:16 +0000 Received: from DM6NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:0:53:cafe::75) by DM3PR14CA0146.outlook.office365.com (2603:10b6:0:53::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25 via Frontend Transport; Tue, 19 May 2020 14:34:16 +0000 X-MS-Exchange-Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=permerror action=none header.from=amd.com; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from SATLEXMB02.amd.com (165.204.84.17) by DM6NAM11FT023.mail.protection.outlook.com (10.13.173.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3000.19 via Frontend Transport; Tue, 19 May 2020 14:34:16 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB02.amd.com (10.181.40.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 May 2020 09:34:15 -0500 Received: from SATLEXMB02.amd.com (10.181.40.143) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 May 2020 09:34:15 -0500 Received: from atgasia02.amd.com (10.180.168.240) by SATLEXMB02.amd.com (10.181.40.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Tue, 19 May 2020 09:34:13 -0500 From: Vijendar Mukunda To: , , Subject: [PATCH 3/3] ASoC: amd: return error when acp de-init fails Date: Tue, 19 May 2020 22:34:22 +0800 Message-ID: <20200519143422.18255-3-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200519143422.18255-1-Vijendar.Mukunda@amd.com> References: <20200519143422.18255-1-Vijendar.Mukunda@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SATLEXMB02.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(136003)(346002)(39860400002)(46966005)(186003)(86362001)(4744005)(2906002)(26005)(336012)(70206006)(2616005)(70586007)(426003)(82740400003)(6666004)(47076004)(316002)(81166007)(356005)(1076003)(5660300002)(110136005)(8676002)(54906003)(4326008)(478600001)(8936002)(7696005)(36756003)(82310400002); DIR:OUT; SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 380754cc-ec32-40e1-ee24-08d7fc01b53a X-MS-TrafficTypeDiagnostic: BY5PR12MB4019: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:296; X-Forefront-PRVS: 040866B734 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7Y8omCgu56/96ly2TT8IqYHCPjOSInATkYkSgMgCvN4TkXrVZLWt3muKPUuOyBUAirifXS93vjth7ZkCo2xwaNan0qPLeI42Zv6LO2DE/gyXfPd9QIR3sTRJ16xzCl3ScIl3vbc4qWCRa+DcGVaSb5UzLQQ1BsiOQHIn9Iz40EuInVHNQcF8QUaAgAQvhNngBSXemZ7rCyrtrbWOHrMZHN8atTPVRadlEXH55aJttyRfshkmeXDhGDSWfgeHAf6/ge6hawTYV5phSQGNHM/cohy6SHJsJzPM3XdNioasYVAqWlgUHnhW7v+j62aax37ijbpKDeW4BjfRHv0vMtAQhDDzambRdgiC9Vosv2IyQv4Zl/r2wdDNtd7QUozphpJDQ+pGWlOcPkwJ8XYg4zmp6u030XW+2rLXu43mvuIq5VbyTX+kBcDnTIOg0relkAktk3f7gmK3/aBoFCSjCYHT0OvC4/BLSXBa0/6wNlQlCNjzCoQmNtOxKzcnUz5EfiFmdoF88qK9nfOwkadJxJHnmw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 14:34:16.1010 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 380754cc-ec32-40e1-ee24-08d7fc01b53a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4019 Cc: Alexander.Deucher@amd.com, Vijendar Mukunda X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Return error when acp de-init fails during suspend. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/renoir/rn-pci-acp3x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/rn-pci-acp3x.c index 502c3f794ba0..859ed67b93cf 100644 --- a/sound/soc/amd/renoir/rn-pci-acp3x.c +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c @@ -277,7 +277,7 @@ static int snd_rn_acp_suspend(struct device *dev) else dev_dbg(dev, "ACP de-initialized\n"); - return 0; + return ret; } static int snd_rn_acp_resume(struct device *dev)