From patchwork Wed May 20 07:31:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Albrieux X-Patchwork-Id: 11559543 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B8699138A for ; Wed, 20 May 2020 07:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A06E9207FB for ; Wed, 20 May 2020 07:31:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tDEvENcD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726534AbgETHby (ORCPT ); Wed, 20 May 2020 03:31:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgETHbx (ORCPT ); Wed, 20 May 2020 03:31:53 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B36D2C061A0E; Wed, 20 May 2020 00:31:53 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id p12so1773445qtn.13; Wed, 20 May 2020 00:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WKBpDTD43/1JUhixc7t1FITqiPa/wHci3Gf2DjHkB/4=; b=tDEvENcDMc0bDElhZiirOvkFTyUoHAQnShMpwos6MP8+NbYBH42x7ZotDklvsrr5+d lFZytsEf8oDgcVERmZLrQNxwnNKnStCurzlsJ5uph2tcIw7okpkzKDAoVYyEBZCHEzqb ei6KT2zHF4MVavG8qQU6yvUE/Tuy7OaYP1tddmu9nOQ+KpO+15OiNboz8zdCfCymbBLt Oz/1R+B0T2EnAAN7F4sYWucYx4DXOCLnCheEKssWiy2FjgP4glira8O1/lAv9OPPSz+g qIAknz1J1kHg6kigY83rXGRYRhUDnQwILaYk1tOqiecIQFUDtoElEujC93nHB3mhHTGV 8NUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WKBpDTD43/1JUhixc7t1FITqiPa/wHci3Gf2DjHkB/4=; b=CtMbqylc1CIdqN7zy99HmXmkKcEyv96eOOgqRsKGHiKZjPgxoJuqF+owoRBow0vlEd /N0W+uSiN4nmV1UkMMNULteC6DpbbkbDb+BHJ//rB2ReBiCztTSqf5C8bVIgnlkKLlS/ h1BAA7Kg+VJ8Lgm6MtM0YHb/mEmtsgIQrIOAe40u6O5bIUSnVUv/ldhbE35w64hKOvRL nN5yeYTdK6+BhBk7aW8exJvIoVyPVyGnMiNlTgAarLwSXXEZn5hXe+QqQZh0iJcWB2Qp RFoHAFAE5q2BKu2AsBbdbGF0u3T/5NzM/t24vYevUK3br+8TCv4P6/ECg7dg2AEZkfbT ddZA== X-Gm-Message-State: AOAM532DepkoRhUJ9BiJbBJPe0PNDTjCtPtcOLyLygZpdP2FSHI/xTmw jiQV9BQZm1eUYhK/CMQOhvE8dvOKpUmeIQ== X-Google-Smtp-Source: ABdhPJz9bXRj6o6XnePg1lqWh2aKqTxkMxwclqg1x+/MkVY4Pvazt2btlCZ+ldXRwHa/+DfXjnSUlQ== X-Received: by 2002:ac8:2a3a:: with SMTP id k55mr3817837qtk.294.1589959912199; Wed, 20 May 2020 00:31:52 -0700 (PDT) Received: from ict14-OptiPlex-980.kataweb.it ([178.23.248.46]) by smtp.googlemail.com with ESMTPSA id w9sm1702540qtn.29.2020.05.20.00.31.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 00:31:51 -0700 (PDT) From: Jonathan Albrieux To: linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Jonathan Albrieux , Allison Randal , Andy Shevchenko , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Greg Kroah-Hartman , Hartmut Knaack , Jilayne Lovejoy , Jonathan Cameron , Kate Stewart , Lars-Peter Clausen , Linus Walleij , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), Peter Meerwald-Stadler , Thomas Gleixner , Jonathan Cameron , Rob Herring Subject: [PATCH v4 1/4] dt-bindings: iio: magnetometer: ak8975: convert txt format to yaml Date: Wed, 20 May 2020 09:31:13 +0200 Message-Id: <20200520073125.30808-2-jonathan.albrieux@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200520073125.30808-1-jonathan.albrieux@gmail.com> References: <20200520073125.30808-1-jonathan.albrieux@gmail.com> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Converts documentation from txt format to yaml. Signed-off-by: Jonathan Albrieux --- .../bindings/iio/magnetometer/ak8975.txt | 30 -------- .../bindings/iio/magnetometer/ak8975.yaml | 71 +++++++++++++++++++ 2 files changed, 71 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/iio/magnetometer/ak8975.txt create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml diff --git a/Documentation/devicetree/bindings/iio/magnetometer/ak8975.txt b/Documentation/devicetree/bindings/iio/magnetometer/ak8975.txt deleted file mode 100644 index aa67ceb0d4e0..000000000000 --- a/Documentation/devicetree/bindings/iio/magnetometer/ak8975.txt +++ /dev/null @@ -1,30 +0,0 @@ -* AsahiKASEI AK8975 magnetometer sensor - -Required properties: - - - compatible : should be "asahi-kasei,ak8975" - - reg : the I2C address of the magnetometer - -Optional properties: - - - gpios : should be device tree identifier of the magnetometer DRDY pin - - vdd-supply: an optional regulator that needs to be on to provide VDD - - mount-matrix: an optional 3x3 mounting rotation matrix - -Example: - -ak8975@c { - compatible = "asahi-kasei,ak8975"; - reg = <0x0c>; - gpios = <&gpj0 7 0>; - vdd-supply = <&ldo_3v3_gnss>; - mount-matrix = "-0.984807753012208", /* x0 */ - "0", /* y0 */ - "-0.173648177666930", /* z0 */ - "0", /* x1 */ - "-1", /* y1 */ - "0", /* z1 */ - "-0.173648177666930", /* x2 */ - "0", /* y2 */ - "0.984807753012208"; /* z2 */ -}; diff --git a/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml new file mode 100644 index 000000000000..9d5b1e6908d1 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml @@ -0,0 +1,71 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/magnetometer/ak8975.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AsahiKASEI AK8975 magnetometer sensor + +maintainers: + - can't find a maintainer, author is Laxman Dewangan + +properties: + compatible: + oneOf: + - const: asahi-kasei,ak8975 + - const: asahi-kasei,ak8963 + - const: asahi-kasei,ak09911 + - const: asahi-kasei,ak09912 + - const: ak8975 + deprecated: true + - const: ak8963 + deprecated: true + - const: ak09911 + deprecated: true + - const: ak09912 + deprecated: true + + reg: + maxItems: 1 + description: the I2C address of the magnetometer + + gpios: + description: should be device tree identifier of the magnetometer DRDY pin + + vdd-supply: + maxItems: 1 + description: | + an optional regulator that needs to be on to provide VDD power to + the sensor. + + mount-matrix: + description: an optional 3x3 mounting rotation matrix + +required: + - compatible + - reg + +examples: + - | + #include + i2c@78b7000 { + reg = <0x78b6000 0x600>; + #address-cells = <1>; + #size-cells = <0>; + + magnetometer@c { + compatible = "asahi-kasei,ak8975"; + reg = <0x0c>; + gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>; + vdd-supply = <&ldo_3v3_gnss>; + mount-matrix = "-0.984807753012208", /* x0 */ + "0", /* y0 */ + "-0.173648177666930", /* z0 */ + "0", /* x1 */ + "-1", /* y1 */ + "0", /* z1 */ + "-0.173648177666930", /* x2 */ + "0", /* y2 */ + "0.984807753012208"; /* z2 */ + }; + }; From patchwork Wed May 20 07:31:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Albrieux X-Patchwork-Id: 11559545 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 605CC912 for ; Wed, 20 May 2020 07:32:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 459CB205CB for ; Wed, 20 May 2020 07:32:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tqqqdgqA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbgETHcA (ORCPT ); Wed, 20 May 2020 03:32:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgETHcA (ORCPT ); Wed, 20 May 2020 03:32:00 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFC90C061A0E; Wed, 20 May 2020 00:31:58 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id m11so2651394qka.4; Wed, 20 May 2020 00:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iRfEPrYZ1xtYGkhU1NkXMfy3ReHbbp0NPMUXh7YcI8Y=; b=tqqqdgqAgXUZ8EmtroT3Yt7zsjmAJHxh+ub58M+OQL5p6YNwZpfDxx6PsfakqLwWfd rFHJqXE+ruuiBDk1ZwmM4SlVbJ5fUsPw0awd7rb0qB7PI/RHHy1VUsqyEiYNK4yMhStP qDsLb2ufzLl8hUoYsfc1Lln2T5Ju5+3DdAkJjMxt+El2lsvMVdfHKPcTcwluXJkfUksz x8Li4KVYaWHNdH4yim6EQm0LOVMVfi9JC5E8eyq9H9EpQ/tXMxoEJX/qlyOZic75/cEh LpdrvPKYH0Bnjp99k0DLBp46ilBRbPUNH6q8snhM+s++WRnWioIEH759JjYMyW3v/BKD w8kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iRfEPrYZ1xtYGkhU1NkXMfy3ReHbbp0NPMUXh7YcI8Y=; b=NI7Q/wf17SjGcFcviduEBPZyXunWK9TKTphphE6R5tcp36WXPTRD0wFszowh4mg8Kx Cv41eFYNvM+hVMTIVsZGYaWP8TH10Z2JqaqozR7wFeiKCJQfHLEEwrW4lNJYi4N2ICGm nvoSYw8a2yBWRPWjXyx/Pgs7gbKHyHtVUGTCmL16KwYswYQdYup8qE3kZcs4swQz6Tlo 6EcPYneT6RXCJod83WR7DIi1zQjAeof7krc9ifDeFt9X02cA8VvHweSEgb+rjeke0ife UVZM8z4LMgjW3y5aW6QGqz71CIZS3AMippzVzTgNhUVFxodX8fT+P7Vk7C2RaqrdBIAz FWbg== X-Gm-Message-State: AOAM530cm3gmj9ZlbE66HmzT/bILRLOuzcT4b2ocQW3HzqGeHb/SaLzv 2+7bPR5lCHd1EngYNy7eVUCSFkK8v/gaIg== X-Google-Smtp-Source: ABdhPJwN+QhzLieNYik7JjnCgm1CC3oj2eBS936pW1H5qbjqJ46767HRcQCuRtpkAbukrCi2EzGy8A== X-Received: by 2002:a37:8c45:: with SMTP id o66mr3288674qkd.392.1589959917527; Wed, 20 May 2020 00:31:57 -0700 (PDT) Received: from ict14-OptiPlex-980.kataweb.it ([178.23.248.46]) by smtp.googlemail.com with ESMTPSA id w9sm1702540qtn.29.2020.05.20.00.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 00:31:57 -0700 (PDT) From: Jonathan Albrieux To: linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Jonathan Albrieux , Allison Randal , Andy Shevchenko , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Greg Kroah-Hartman , Hartmut Knaack , Jilayne Lovejoy , Jonathan Cameron , Kate Stewart , Lars-Peter Clausen , Linus Walleij , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), Peter Meerwald-Stadler , Thomas Gleixner , Jonathan Cameron , Rob Herring Subject: [PATCH v4 2/4] dt-bindings: iio: magnetometer: ak8975: add gpio reset support Date: Wed, 20 May 2020 09:31:14 +0200 Message-Id: <20200520073125.30808-3-jonathan.albrieux@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200520073125.30808-1-jonathan.albrieux@gmail.com> References: <20200520073125.30808-1-jonathan.albrieux@gmail.com> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Add reset-gpio support. Without reset's deassertion during ak8975_power_on(), driver's probe fails on ak8975_who_i_am() while checking for device identity for AK09911 chip. AK09911 has an active low reset gpio to handle register's reset. AK09911 datasheet says that, if not used, reset pin should be connected to VID. This patch emulates this situation. Signed-off-by: Jonathan Albrieux --- .../devicetree/bindings/iio/magnetometer/ak8975.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml index 9d5b1e6908d1..d83f7e212658 100644 --- a/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml +++ b/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml @@ -41,6 +41,11 @@ properties: mount-matrix: description: an optional 3x3 mounting rotation matrix + reset-gpio: + description: | + an optional pin needed for AK09911 to set the reset state. This should + be usually active low + required: - compatible - reg @@ -58,6 +63,7 @@ examples: reg = <0x0c>; gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>; vdd-supply = <&ldo_3v3_gnss>; + reset-gpio = <&msmgpio 111 GPIO_ACTIVE_LOW>; mount-matrix = "-0.984807753012208", /* x0 */ "0", /* y0 */ "-0.173648177666930", /* z0 */ From patchwork Wed May 20 07:31:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Albrieux X-Patchwork-Id: 11559547 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9B6D9912 for ; Wed, 20 May 2020 07:32:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83D57207ED for ; Wed, 20 May 2020 07:32:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ewnxfr7Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbgETHcF (ORCPT ); Wed, 20 May 2020 03:32:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgETHcE (ORCPT ); Wed, 20 May 2020 03:32:04 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A84AC061A0E; Wed, 20 May 2020 00:32:03 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id v4so1831063qte.3; Wed, 20 May 2020 00:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hOveqjYBk1+7IoXrKWjzzpmC29NQEFV/46uICdldkHU=; b=ewnxfr7Zn2WCDka8Z1ZE4YnqNTreQv7/AaL61dcWtTgXc0GQNWySm2h/5BWSX0NCDQ F/HlvM4RsnlmK8ZPdAcCBhfEXfHIe9+TqoC2/9jgUGDF8i9kOtM4ev3CKnjnRJczlhzE Z+xY2vv5qT8zjb58RDX67BzpS2gjUftTuiIte9hQ858DIO/6jo+0EzoPccCdRO2eMQie mKHvn/NkR6x/yb0gltHkZ6yV+6j9Z52+w6TeCYBjY7qettgo3iAMGvNM2FtDyipmUWYC 1g2sjxsTvaoejVwZbEfQFXzwS4aI3FsKeyRRRiyBFljuuFwd/BLFQHR7VJS7eQ+sZ7El RN/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hOveqjYBk1+7IoXrKWjzzpmC29NQEFV/46uICdldkHU=; b=JZMzoqPw4j7fydET1ec09E08wHqKPqD2UBANqrbCvY33IdyFpXR512Od5fXPQ0LdH0 34PL7W5m3MlK/eMiKarDkNrYGEUf2btxhNK9sU74fCR8/082PxJZaY77IhLMSVAoYuE0 GBV8mx9CKqDFVFYj9oZmAzovjaVFq+lzwxHLBDLtibOZRxB8yyW2qOWa3IhLnKEqw7hX z7fi7EmB2bOOayPhfe4pozL/7xLfb8oVR6JgzpwumEWq6p6HUxQk+w0t/6cVnKe3zPY+ LXRqgpgxNZIuuJ/XOLN2dMDsaCTTvzmaeyNa7nu5j4SeSEepiiBUA5/sPGlx91r8WlX9 JtaA== X-Gm-Message-State: AOAM531W9hXtn9ihEBjBTnGxf8K9MOaWG4ydmHo/cWwLT1RsiF2Nbewe bZDRq2DwkSZhqEjRL55qaMHWaVg0MF221g== X-Google-Smtp-Source: ABdhPJw9RgHGLym+SQy81PxjQu8pnjhS+XinnafLQ/jGNlE19vEZoYzTm25HtL17j/xjVfRoApim0w== X-Received: by 2002:ac8:1381:: with SMTP id h1mr3746316qtj.98.1589959922061; Wed, 20 May 2020 00:32:02 -0700 (PDT) Received: from ict14-OptiPlex-980.kataweb.it ([178.23.248.46]) by smtp.googlemail.com with ESMTPSA id w9sm1702540qtn.29.2020.05.20.00.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 00:32:01 -0700 (PDT) From: Jonathan Albrieux To: linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Jonathan Albrieux , Allison Randal , Andy Shevchenko , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Greg Kroah-Hartman , Hartmut Knaack , Jilayne Lovejoy , Jonathan Cameron , Kate Stewart , Lars-Peter Clausen , Linus Walleij , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), Peter Meerwald-Stadler , Thomas Gleixner , Jonathan Cameron Subject: [PATCH v4 3/4] iio: magnetometer: ak8975: Fix typo, uniform measurement unit style Date: Wed, 20 May 2020 09:31:15 +0200 Message-Id: <20200520073125.30808-4-jonathan.albrieux@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200520073125.30808-1-jonathan.albrieux@gmail.com> References: <20200520073125.30808-1-jonathan.albrieux@gmail.com> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Minor comment style edits. Signed-off-by: Jonathan Albrieux Reviewed-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c index 3c881541ae72..fd368455cd7b 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -385,9 +385,9 @@ static int ak8975_power_on(const struct ak8975_data *data) return ret; } /* - * According to the datasheet the power supply rise time i 200us + * According to the datasheet the power supply rise time is 200us * and the minimum wait time before mode setting is 100us, in - * total 300 us. Add some margin and say minimum 500us here. + * total 300us. Add some margin and say minimum 500us here. */ usleep_range(500, 1000); return 0; From patchwork Wed May 20 07:31:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Albrieux X-Patchwork-Id: 11559549 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A1288912 for ; Wed, 20 May 2020 07:32:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84A6F207FB for ; Wed, 20 May 2020 07:32:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l1cnWShy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbgETHcI (ORCPT ); Wed, 20 May 2020 03:32:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgETHcI (ORCPT ); Wed, 20 May 2020 03:32:08 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05FD2C061A0E; Wed, 20 May 2020 00:32:08 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id f83so2561902qke.13; Wed, 20 May 2020 00:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ru/VedSe7R+1+BFX/X1C1fyozp4gv15sJxfe6kqv7eI=; b=l1cnWShyzk9WpD7pyxlfhmMLb+wtc9wEg7fKABXKL/TGoaRZcNmK/zMBcIYoeR6i1z MoPSYxpn0RWpHFxdLsov2rafdry6nwoXRqwT7RGGO4sUfLnijEr8z0iuWO2tzL5rpfoz NkaN2nsHS+ys+9WijxzaQ9NbAZMHx2zFoH+k5Br4QDWBJQxzHL1GjwubVZUq4koT5tRv 918czWDtlyduHSTwLlIlMMzIUP95ZPbzXikLUjvsI1js7e1hbAFMjudPiabmflNlzgoh ewTQk/+0xHvKmI6ZFdAqgm8FzL86Tlk7RZ8zv7qJnaWPXo2TBTg9r7GtI6e3Pq/v8Oce KgvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ru/VedSe7R+1+BFX/X1C1fyozp4gv15sJxfe6kqv7eI=; b=abcP7ddrTDv2ba6kHQL3AoJYWD95X3sA3ZLlTi3Q0evtE7IeUJdpUa0IDdnnpHFhQw 9d48Abn7SfBbSojRvBRPecVzsrMugjTBbfYOfp4ex9rByqvtxdoid6jHE51GVN6InFs5 2OwK3ooecWqIvROvcC+IOjbnkqYAvGAV8aP8BlBYETRkGpippdu+5j4kzpgT93EGRnxr 82CzKvmYaQx00ro+TDlujx5n0rX1iMIRgy0yzuw32/Qw7bvq7sqLfhwB/N+qQE9PKPiL OzNhRh2veheOrRXyslQohUiQUeKS8Y7XWlRE/Z4frCsaJVZ9F5zl9tiruUfy1gmSSsXz NyKA== X-Gm-Message-State: AOAM532WJSO6YksjaEW85Ytmdg+x1EsENl7ipGTJCQH6jKuCJ+xtM6EP D6GGB66vEYy9Xnowq5Yrlaxdt4A1NryxqA== X-Google-Smtp-Source: ABdhPJzpfHTP0qAcbJMP7wqThG01HGbMM7NnPaLg9RG8U068gUNRZKc+3qgpT9Ut6IWTF5fkFwqkWQ== X-Received: by 2002:a37:628a:: with SMTP id w132mr3234893qkb.294.1589959926837; Wed, 20 May 2020 00:32:06 -0700 (PDT) Received: from ict14-OptiPlex-980.kataweb.it ([178.23.248.46]) by smtp.googlemail.com with ESMTPSA id w9sm1702540qtn.29.2020.05.20.00.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 00:32:06 -0700 (PDT) From: Jonathan Albrieux To: linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Jonathan Albrieux , Allison Randal , Andy Shevchenko , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Greg Kroah-Hartman , Hartmut Knaack , Jilayne Lovejoy , Jonathan Cameron , Kate Stewart , Lars-Peter Clausen , Linus Walleij , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), Peter Meerwald-Stadler , Thomas Gleixner , Jonathan Cameron Subject: [PATCH v4 4/4] iio: magnetometer: ak8975: Add gpio reset support Date: Wed, 20 May 2020 09:31:16 +0200 Message-Id: <20200520073125.30808-5-jonathan.albrieux@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200520073125.30808-1-jonathan.albrieux@gmail.com> References: <20200520073125.30808-1-jonathan.albrieux@gmail.com> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org According to AK09911 datasheet, if reset gpio is provided then deassert reset on ak8975_power_on() and assert reset on ak8975_power_off(). Without reset's deassertion during ak8975_power_on(), driver's probe fails on ak8975_who_i_am() while checking for device identity for AK09911 chip. AK09911 has an active low reset gpio to handle register's reset. AK09911 datasheet says that, if not used, reset pin should be connected to VID. This patch emulates this situation. Signed-off-by: Jonathan Albrieux Reviewed-by: Andy Shevchenko Reviewed-by: Stephan Gerhold --- drivers/iio/magnetometer/ak8975.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c index fd368455cd7b..a23422aad97d 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -358,6 +358,7 @@ struct ak8975_data { u8 asa[3]; long raw_to_gauss[3]; struct gpio_desc *eoc_gpiod; + struct gpio_desc *reset_gpiod; int eoc_irq; wait_queue_head_t data_ready_queue; unsigned long flags; @@ -384,6 +385,9 @@ static int ak8975_power_on(const struct ak8975_data *data) "Failed to enable specified Vid supply\n"); return ret; } + + gpiod_set_value_cansleep(data->reset_gpiod, 0); + /* * According to the datasheet the power supply rise time is 200us * and the minimum wait time before mode setting is 100us, in @@ -396,6 +400,8 @@ static int ak8975_power_on(const struct ak8975_data *data) /* Disable attached power regulator if any. */ static void ak8975_power_off(const struct ak8975_data *data) { + gpiod_set_value_cansleep(data->reset_gpiod, 1); + regulator_disable(data->vid); regulator_disable(data->vdd); } @@ -839,6 +845,7 @@ static int ak8975_probe(struct i2c_client *client, struct ak8975_data *data; struct iio_dev *indio_dev; struct gpio_desc *eoc_gpiod; + struct gpio_desc *reset_gpiod; const void *match; unsigned int i; int err; @@ -856,6 +863,16 @@ static int ak8975_probe(struct i2c_client *client, if (eoc_gpiod) gpiod_set_consumer_name(eoc_gpiod, "ak_8975"); + /* + * According to AK09911 datasheet, if reset GPIO is provided then + * deassert reset on ak8975_power_on() and assert reset on + * ak8975_power_off(). + */ + reset_gpiod = devm_gpiod_get_optional(&client->dev, + "reset", GPIOD_OUT_HIGH); + if (IS_ERR(reset_gpiod)) + return PTR_ERR(reset_gpiod); + /* Register with IIO */ indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); if (indio_dev == NULL) @@ -866,6 +883,7 @@ static int ak8975_probe(struct i2c_client *client, data->client = client; data->eoc_gpiod = eoc_gpiod; + data->reset_gpiod = reset_gpiod; data->eoc_irq = 0; err = iio_read_mount_matrix(&client->dev, "mount-matrix", &data->orientation);