From patchwork Thu May 28 12:57:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herbert Xu X-Patchwork-Id: 11575809 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D485614C0 for ; Thu, 28 May 2020 12:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C595220814 for ; Thu, 28 May 2020 12:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389937AbgE1M5z (ORCPT ); Thu, 28 May 2020 08:57:55 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:36532 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389884AbgE1M5z (ORCPT ); Thu, 28 May 2020 08:57:55 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jeI6a-0007y6-0R; Thu, 28 May 2020 22:57:53 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 28 May 2020 22:57:52 +1000 Date: Thu, 28 May 2020 22:57:52 +1000 From: Herbert Xu To: dash@vger.kernel.org Subject: [PATCH] shell: Enable fnmatch/glob by default Message-ID: <20200528125751.GA18863@gondor.apana.org.au> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: dash-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dash@vger.kernel.org As fnmatch(3) and glob(3) from glibc are now working consistently, this patch enables them by default. Signed-off-by: Herbert Xu diff --git a/configure.ac b/configure.ac index dbd97d8..d73b2bf 100644 --- a/configure.ac +++ b/configure.ac @@ -37,9 +37,10 @@ if test "$enable_static" = "yes"; then export LDFLAGS="-static -Wl,--fatal-warnings" fi -AC_ARG_ENABLE(fnmatch, AS_HELP_STRING(--enable-fnmatch, \ - [Use fnmatch(3) from libc])) -AC_ARG_ENABLE(glob, AS_HELP_STRING(--enable-glob, [Use glob(3) from libc])) +AC_ARG_ENABLE(fnmatch, AS_HELP_STRING(--disable-fnmatch, \ + [Do not use fnmatch(3) from libc])) +AC_ARG_ENABLE(glob, AS_HELP_STRING(--disable-glob, \ + [Do not use glob(3) from libc])) dnl Checks for libraries. @@ -122,12 +123,12 @@ if test "$enable_test_workaround" = "yes"; then [Define if your faccessat tells root all files are executable]) fi -if test "$enable_fnmatch" = yes; then +if test "$enable_fnmatch" != no; then use_fnmatch= AC_CHECK_FUNCS(fnmatch, use_fnmatch=yes) fi -if test "$use_fnmatch" = yes && test "$enable_glob" = yes; then +if test "$use_fnmatch" = yes && test "$enable_glob" != no; then AC_CHECK_FUNCS(glob) fi