From patchwork Tue Jun 2 09:12:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 11583431 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B49FE912 for ; Tue, 2 Jun 2020 09:12:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A809320734 for ; Tue, 2 Jun 2020 09:12:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726139AbgFBJMb (ORCPT ); Tue, 2 Jun 2020 05:12:31 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:54472 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbgFBJMa (ORCPT ); Tue, 2 Jun 2020 05:12:30 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 01DF08030808; Tue, 2 Jun 2020 09:12:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bd7-JbQHWhoR; Tue, 2 Jun 2020 12:12:27 +0300 (MSK) From: Serge Semin To: Jean Delvare , Guenter Roeck CC: Serge Semin , Serge Semin , kbuild test robot , Maxim Kaurkin , Alexey Malahov , , Subject: [PATCH] hwmon: bt1-pvt: Declare Temp- and Volt-to-N poly when alarms are enabled Date: Tue, 2 Jun 2020 12:12:19 +0300 Message-ID: <20200602091219.24404-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Clang-based kernel building with W=1 warns that some static const variables are unused: drivers/hwmon/bt1-pvt.c:67:30: warning: unused variable 'poly_temp_to_N' [-Wunused-const-variable] static const struct pvt_poly poly_temp_to_N = { ^ drivers/hwmon/bt1-pvt.c:99:30: warning: unused variable 'poly_volt_to_N' [-Wunused-const-variable] static const struct pvt_poly poly_volt_to_N = { ^ Indeed these polynomials are utilized only when the PVT sensor alarms are enabled. In that case they are used to convert the temperature and voltage alarm limits from normal quantities (Volts and degree Celsius) to the sensor data representation N = [0, 1023]. Otherwise when alarms are disabled the driver only does the detected data conversion to the human readable form and doesn't need that polynomials defined. So let's declare the Temp-to-N and Volt-to-N polynomials only if the PVT alarms are switched on at compile-time. Note gcc with W=1 doesn't notice the problem. Fixes: 87976ce2825d ("hwmon: Add Baikal-T1 PVT sensor driver") Reported-by: kbuild test robot Signed-off-by: Serge Semin Cc: Maxim Kaurkin Cc: Alexey Malahov --- drivers/hwmon/bt1-pvt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hwmon/bt1-pvt.c b/drivers/hwmon/bt1-pvt.c index 1a9772fb1f73..1a5212c04549 100644 --- a/drivers/hwmon/bt1-pvt.c +++ b/drivers/hwmon/bt1-pvt.c @@ -64,6 +64,7 @@ static const struct pvt_sensor_info pvt_info[] = { * 48380, * where T = [-48380, 147438] mC and N = [0, 1023]. */ +#if defined(CONFIG_SENSORS_BT1_PVT_ALARMS) static const struct pvt_poly poly_temp_to_N = { .total_divider = 10000, .terms = { @@ -74,6 +75,7 @@ static const struct pvt_poly poly_temp_to_N = { {0, 1720400, 1, 1} } }; +#endif /* CONFIG_SENSORS_BT1_PVT_ALARMS */ static const struct pvt_poly poly_N_to_temp = { .total_divider = 1, @@ -96,6 +98,7 @@ static const struct pvt_poly poly_N_to_temp = { * N = (18658e-3*V - 11572) / 10, * V = N * 10^5 / 18658 + 11572 * 10^4 / 18658. */ +#if defined(CONFIG_SENSORS_BT1_PVT_ALARMS) static const struct pvt_poly poly_volt_to_N = { .total_divider = 10, .terms = { @@ -103,6 +106,7 @@ static const struct pvt_poly poly_volt_to_N = { {0, -11572, 1, 1} } }; +#endif /* CONFIG_SENSORS_BT1_PVT_ALARMS */ static const struct pvt_poly poly_N_to_volt = { .total_divider = 10,