From patchwork Mon Jun  8 14:02:02 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: "Randall S. Becker" <rsbecker@nexbridge.com>
X-Patchwork-Id: 11593383
Return-Path: <SRS0=SopW=7V=vger.kernel.org=git-owner@kernel.org>
Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org
 [172.30.200.123])
	by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 29061912
	for <patchwork-git@patchwork.kernel.org>;
 Mon,  8 Jun 2020 14:02:22 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 18A0C206C3
	for <patchwork-git@patchwork.kernel.org>;
 Mon,  8 Jun 2020 14:02:22 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729896AbgFHOCQ convert rfc822-to-8bit (ORCPT
        <rfc822;patchwork-git@patchwork.kernel.org>);
        Mon, 8 Jun 2020 10:02:16 -0400
Received: from elephants.elehost.com ([216.66.27.132]:38009 "EHLO
        elephants.elehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729175AbgFHOCP (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 8 Jun 2020 10:02:15 -0400
X-Virus-Scanned: amavisd-new at elehost.com
Received: from gnash (CPE00fc8d49d843-CM00fc8d49d840.cpe.net.cable.rogers.com
 [173.32.57.223])
        (authenticated bits=0)
        by elephants.elehost.com (8.15.2/8.15.2) with ESMTPSA id
 058E2CH2043461
        (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO)
        for <git@vger.kernel.org>; Mon, 8 Jun 2020 10:02:13 -0400 (EDT)
        (envelope-from rsbecker@nexbridge.com)
From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: <git@vger.kernel.org>
Subject: [BUG] Installing git-gui (2.27.0)
Date: Mon, 8 Jun 2020 10:02:02 -0400
Message-ID: <00dd01d63d9d$65f5dda0$31e198e0$@nexbridge.com>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQEy7MDCp8p+dvhPBcEMR9038QKDTQ==
Content-Language: en-ca
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Hi,

This is what I found when trying to install the whole git package on the
NonStop TNS/E platform:

 DEST /usr/local/share/git-gui/lib
    INSTALL 644 tclIndex
install: cannot stat 'lib/tclIndex': No such file or directory
Makefile:293: recipe for target 'install' failed

I’m not sure why we are only hitting this now at 2.27.0. We don’t use
git-gui anyway on this platform as it has no GUI interface. It looks like
the install script runs auto_mkindex that actually does nothing in our case,
so lib/tclIndex is not built.

This does block the install from completing successfully. To bypass, I added
the following:

index f10caedaa7..943febaf75 100644

Regards,
Randall

-- Brief whoami:
 NonStop developer since approximately 211288444200000000
 UNIX developer since approximately 421664400
-- In my real life, I talk too much.

--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -256,6 +256,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
          $(foreach p,$(PRELOAD_FILES),source $p\;) \
          auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \
        | $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \
+        echo >>$@ ; \
        else \
         echo >&2 "    * $(TCL_PATH) failed; using unoptimized loading"; \
         rm -f $@ ; \