From patchwork Tue Jun 16 19:00:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simao Gomes Viana X-Patchwork-Id: 11608479 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 46A8092A for ; Tue, 16 Jun 2020 19:06:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B678214DB for ; Tue, 16 Jun 2020 19:06:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=superboring.dev header.i=@superboring.dev header.b="SbJeLTFd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730056AbgFPTGt (ORCPT ); Tue, 16 Jun 2020 15:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729994AbgFPTGt (ORCPT ); Tue, 16 Jun 2020 15:06:49 -0400 Received: from mail.halogenos.org (halogenos.org [IPv6:2a02:c207:2037:5246::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E23C4C06174E for ; Tue, 16 Jun 2020 12:06:48 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 2824115002EC; Tue, 16 Jun 2020 21:01:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=superboring.dev; s=dkim; t=1592334062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=c+vtbEXBLAum4cfRDsthiIbEKyQV6GkxTQYpGQE3yPc=; b=SbJeLTFdGV5nnJh7kfshfOSin5u0cKyL0m18MP2GfrlEGsRJfd5l2KMmVUgxIRgD4ZFDBx 3cxFPT4L3PnJqQ4IIpLt+m6ulLBORf6YSxVFS1DVEcP4xgahbkuAbQTnz3sI8cdn0uLZWb 2sOeRX1SmL4WtoQzQUnstwCMdoLLM/XEPPQbVoe6E0EXdmoid3awRMYMUlwOmPOIHmErSq wPRK5vbIXpVv+Zjsi1KYuH/FIF89IRG6jkRHS3KjeNU1ovlw3l66J5c0U4wufVl6K15uw5 d/dFuzerZJ4TfIESO4Fmg5IX4Hv0fffndA3GbdOGBtmkTkfvoSCj/RR4JMfx/g== From: Simao Gomes Viana To: Jiri Kosina Cc: Simao Gomes Viana , linux-input@vger.kernel.org Subject: [PATCH 1/4] drivers: hid: lightly fix code style Date: Tue, 16 Jun 2020 21:00:41 +0200 Message-Id: <20200616190044.126928-1-devel@superboring.dev> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Signed-off-by: Simao Gomes Viana --- drivers/hid/hid-input.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index dea9cc65bf80..5a7282a0abbb 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1185,7 +1185,8 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel if (field->application == HID_GD_GAMEPAD || field->application == HID_GD_JOYSTICK) input_set_abs_params(input, usage->code, a, b, (b - a) >> 8, (b - a) >> 4); - else input_set_abs_params(input, usage->code, a, b, 0, 0); + else + input_set_abs_params(input, usage->code, a, b, 0, 0); input_abs_set_res(input, usage->code, hidinput_calc_abs_res(field, usage->code)); @@ -1198,6 +1199,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel if (usage->type == EV_ABS && (usage->hat_min < usage->hat_max || usage->hat_dir)) { int i; + for (i = usage->code; i < usage->code + 2 && i <= max; i++) { input_set_abs_params(input, i, -1, 1, 0, 0); set_bit(i, input->absbit); @@ -1280,10 +1282,12 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct if (usage->hat_min < usage->hat_max || usage->hat_dir) { int hat_dir = usage->hat_dir; + if (!hat_dir) hat_dir = (value - usage->hat_min) * 8 / (usage->hat_max - usage->hat_min + 1) + 1; - if (hat_dir < 0 || hat_dir > 8) hat_dir = 0; - input_event(input, usage->type, usage->code , hid_hat_to_axis[hat_dir].x); + if (hat_dir < 0 || hat_dir > 8) + hat_dir = 0; + input_event(input, usage->type, usage->code, hid_hat_to_axis[hat_dir].x); input_event(input, usage->type, usage->code + 1, hid_hat_to_axis[hat_dir].y); return; } @@ -1306,11 +1310,12 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct if (usage->hid == (HID_UP_DIGITIZER | 0x0030) && (*quirks & HID_QUIRK_NOTOUCH)) { /* Pressure */ int a = field->logical_minimum; int b = field->logical_maximum; + input_event(input, EV_KEY, BTN_TOUCH, value > a + ((b - a) >> 3)); } if (usage->hid == (HID_UP_PID | 0x83UL)) { /* Simultaneous Effects Max */ - dbg_hid("Maximum Effects - %d\n",value); + dbg_hid("Maximum Effects - %d\n", value); return; } @@ -1869,6 +1874,7 @@ int hidinput_connect(struct hid_device *hid, unsigned int force) if (!force) { for (i = 0; i < hid->maxcollection; i++) { struct hid_collection *col = &hid->collection[i]; + if (col->type == HID_COLLECTION_APPLICATION || col->type == HID_COLLECTION_PHYSICAL) if (IS_INPUT_APPLICATION(col->usage)) From patchwork Tue Jun 16 19:00:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simao Gomes Viana X-Patchwork-Id: 11608481 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7C81A1392 for ; Tue, 16 Jun 2020 19:06:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 618C2214DB for ; Tue, 16 Jun 2020 19:06:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=superboring.dev header.i=@superboring.dev header.b="JM2gq7ME" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729994AbgFPTGt (ORCPT ); Tue, 16 Jun 2020 15:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730020AbgFPTGt (ORCPT ); Tue, 16 Jun 2020 15:06:49 -0400 Received: from mail.halogenos.org (halogenos.org [IPv6:2a02:c207:2037:5246::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 018FDC061755 for ; Tue, 16 Jun 2020 12:06:48 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 12E5E1500CDF; Tue, 16 Jun 2020 21:01:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=superboring.dev; s=dkim; t=1592334070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q3E2Ui1W8iVQUns1ff+8rSZE5FsvHCrbNKjbTVVQ0Xw=; b=JM2gq7MEt3M93AZkXZJfRuvRdsoisKzOAohuHMNLigsEjJmLArkCNfQ1OTcFWWRO4WPjcz iSHQQ6ProK3YoHYx/Fj6+Hrw+5NpPrvrUM6AgEaGqrp52nobN/Qt/5zV2wDk1+Gt+hqf2g mVIeK+C+HkIQayFKVGuQ2RpiFO0EE0Mw9C9N//tDkZNutpVGIKqPx+D4TRpIrNGwSZBXIM hVbFhVs0ofJaCiZskkGcYuFvDsLmtWfqJNz0PhNlib29uBQxobYdLJfr6LOI0hoYko6HDZ oFyx0/GH2BvESioaDnPq5AsK0HwsZpeBvxE5gwwMjY0WPcoMPCNxpTwpzA7W0A== From: Simao Gomes Viana To: Jiri Kosina Cc: Simao Gomes Viana , linux-input@vger.kernel.org Subject: [PATCH 2/4] drivers: hid: code style fixes Date: Tue, 16 Jun 2020 21:00:42 +0200 Message-Id: <20200616190044.126928-2-devel@superboring.dev> In-Reply-To: <20200616190044.126928-1-devel@superboring.dev> References: <20200616190044.126928-1-devel@superboring.dev> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Signed-off-by: Simao Gomes Viana --- drivers/hid/hid-input.c | 99 ++++++++++++++++++++++++++++------------- 1 file changed, 67 insertions(+), 32 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 5a7282a0abbb..e70066e4c545 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -751,17 +751,17 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel case HID_UP_LED: switch (usage->hid & 0xffff) { /* HID-Value: */ - case 0x01: map_led (LED_NUML); break; /* "Num Lock" */ - case 0x02: map_led (LED_CAPSL); break; /* "Caps Lock" */ - case 0x03: map_led (LED_SCROLLL); break; /* "Scroll Lock" */ - case 0x04: map_led (LED_COMPOSE); break; /* "Compose" */ - case 0x05: map_led (LED_KANA); break; /* "Kana" */ - case 0x27: map_led (LED_SLEEP); break; /* "Stand-By" */ - case 0x4c: map_led (LED_SUSPEND); break; /* "System Suspend" */ - case 0x09: map_led (LED_MUTE); break; /* "Mute" */ - case 0x4b: map_led (LED_MISC); break; /* "Generic Indicator" */ - case 0x19: map_led (LED_MAIL); break; /* "Message Waiting" */ - case 0x4d: map_led (LED_CHARGING); break; /* "External Power Connected" */ + case 0x01: map_led(LED_NUML); break; /* "Num Lock" */ + case 0x02: map_led(LED_CAPSL); break; /* "Caps Lock" */ + case 0x03: map_led(LED_SCROLLL); break; /* "Scroll Lock" */ + case 0x04: map_led(LED_COMPOSE); break; /* "Compose" */ + case 0x05: map_led(LED_KANA); break; /* "Kana" */ + case 0x27: map_led(LED_SLEEP); break; /* "Stand-By" */ + case 0x4c: map_led(LED_SUSPEND); break; /* "System Suspend" */ + case 0x09: map_led(LED_MUTE); break; /* "Mute" */ + case 0x4b: map_led(LED_MISC); break; /* "Generic Indicator" */ + case 0x19: map_led(LED_MAIL); break; /* "Message Waiting" */ + case 0x4d: map_led(LED_CHARGING); break; /* "External Power Connected" */ default: goto ignore; } @@ -1066,29 +1066,61 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel case HID_UP_HPVENDOR: /* Reported on a Dutch layout HP5308 */ set_bit(EV_REP, input->evbit); switch (usage->hid & HID_USAGE) { - case 0x021: map_key_clear(KEY_PRINT); break; - case 0x070: map_key_clear(KEY_HP); break; - case 0x071: map_key_clear(KEY_CAMERA); break; - case 0x072: map_key_clear(KEY_SOUND); break; - case 0x073: map_key_clear(KEY_QUESTION); break; - case 0x080: map_key_clear(KEY_EMAIL); break; - case 0x081: map_key_clear(KEY_CHAT); break; - case 0x082: map_key_clear(KEY_SEARCH); break; - case 0x083: map_key_clear(KEY_CONNECT); break; - case 0x084: map_key_clear(KEY_FINANCE); break; - case 0x085: map_key_clear(KEY_SPORT); break; - case 0x086: map_key_clear(KEY_SHOP); break; - default: goto ignore; + case 0x021: + map_key_clear(KEY_PRINT); + break; + case 0x070: + map_key_clear(KEY_HP); + break; + case 0x071: + map_key_clear(KEY_CAMERA); + break; + case 0x072: + map_key_clear(KEY_SOUND); + break; + case 0x073: + map_key_clear(KEY_QUESTION); + break; + case 0x080: + map_key_clear(KEY_EMAIL); + break; + case 0x081: + map_key_clear(KEY_CHAT); + break; + case 0x082: + map_key_clear(KEY_SEARCH); + break; + case 0x083: + map_key_clear(KEY_CONNECT); + break; + case 0x084: + map_key_clear(KEY_FINANCE); + break; + case 0x085: + map_key_clear(KEY_SPORT); + break; + case 0x086: + map_key_clear(KEY_SHOP); + break; + default: + goto ignore; } break; case HID_UP_HPVENDOR2: set_bit(EV_REP, input->evbit); switch (usage->hid & HID_USAGE) { - case 0x001: map_key_clear(KEY_MICMUTE); break; - case 0x003: map_key_clear(KEY_BRIGHTNESSDOWN); break; - case 0x004: map_key_clear(KEY_BRIGHTNESSUP); break; - default: goto ignore; + case 0x001: + map_key_clear(KEY_MICMUTE); + break; + case 0x003: + map_key_clear(KEY_BRIGHTNESSDOWN); + break; + case 0x004: + map_key_clear(KEY_BRIGHTNESSUP); + break; + default: + goto ignore; } break; @@ -1108,13 +1140,16 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel case HID_UP_PID: switch (usage->hid & HID_USAGE) { - case 0xa4: map_key_clear(BTN_DEAD); break; - default: goto ignore; + case 0xa4: + map_key_clear(BTN_DEAD); + break; + default: + goto ignore; } break; default: - unknown: +unknown: if (field->report_size == 1) { if (field->report->type == HID_OUTPUT_REPORT) { map_led(LED_MISC); @@ -1383,7 +1418,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct * skip the keycode translation and only forward real events. */ if (!(field->flags & (HID_MAIN_ITEM_RELATIVE | - HID_MAIN_ITEM_BUFFERED_BYTE)) && + HID_MAIN_ITEM_BUFFERED_BYTE)) && (field->flags & HID_MAIN_ITEM_VARIABLE) && usage->usage_index < field->maxusage && value == field->value[usage->usage_index]) From patchwork Tue Jun 16 19:00:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simao Gomes Viana X-Patchwork-Id: 11608485 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 19321175D for ; Tue, 16 Jun 2020 19:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED00D20B1F for ; Tue, 16 Jun 2020 19:06:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=superboring.dev header.i=@superboring.dev header.b="Jwy1mVcg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729988AbgFPTGu (ORCPT ); Tue, 16 Jun 2020 15:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730034AbgFPTGt (ORCPT ); Tue, 16 Jun 2020 15:06:49 -0400 Received: from mail.halogenos.org (halogenos.org [IPv6:2a02:c207:2037:5246::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DC71C0613ED for ; Tue, 16 Jun 2020 12:06:49 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 789641500CE1; Tue, 16 Jun 2020 21:01:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=superboring.dev; s=dkim; t=1592334073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=odCaLXpvlUszfTFuzcpO8n7Br8wmp9OsetmSmIjTFig=; b=Jwy1mVcgK1mKMslt0bFLLR0xZkM/s7Nlorfg740+JgPWkxJFEFAMA35ldSrc45QoSF15VS gB702CuQy+s9YseWMsK0yxptBxU7E+GQc48eKUFd389wHXuhd9ZzdbSwZEIyGwGUudGhgE ZYyZqSxk0Z+C1dZcrZofukQPW7uYjG3veGxTNbyqrAIrClP7ksHrb3BUvMTxu4GhGD1gdu ItTPxN8azzXmjy5ZrYcBnaLXgx4DKV3YyTwY8PEWoA7J8a9vdnnkkFHilIrhhiQcFc3kWG q3aYCmx3PaoJP76Wh3yRX01Q/XvMM9xzZXihQa/F15LXKcflY+YP7pR/BChf6A== From: Simao Gomes Viana To: Jiri Kosina Cc: Simao Gomes Viana , linux-input@vger.kernel.org Subject: [PATCH 3/4] drivers: hid: change unsigned to unsigned int Date: Tue, 16 Jun 2020 21:00:43 +0200 Message-Id: <20200616190044.126928-3-devel@superboring.dev> In-Reply-To: <20200616190044.126928-1-devel@superboring.dev> References: <20200616190044.126928-1-devel@superboring.dev> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org as per scripts/checkpatch.pl --- drivers/hid/hid-input.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index e70066e4c545..ef077da7485d 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -322,9 +322,9 @@ static const struct hid_device_id hid_battery_quirks[] = { {} }; -static unsigned find_battery_quirk(struct hid_device *hdev) +static unsigned int find_battery_quirk(struct hid_device *hdev) { - unsigned quirks = 0; + unsigned int quirks = 0; const struct hid_device_id *match; match = hid_match_id(hdev, hid_battery_quirks); @@ -428,11 +428,11 @@ static int hidinput_get_battery_property(struct power_supply *psy, return ret; } -static int hidinput_setup_battery(struct hid_device *dev, unsigned report_type, struct hid_field *field) +static int hidinput_setup_battery(struct hid_device *dev, unsigned int report_type, struct hid_field *field) { struct power_supply_desc *psy_desc; struct power_supply_config psy_cfg = { .drv_data = dev, }; - unsigned quirks; + unsigned int quirks; s32 min, max; int error; @@ -541,7 +541,7 @@ static void hidinput_update_battery(struct hid_device *dev, int value) } } #else /* !CONFIG_HID_BATTERY_STRENGTH */ -static int hidinput_setup_battery(struct hid_device *dev, unsigned report_type, +static int hidinput_setup_battery(struct hid_device *dev, unsigned int report_type, struct hid_field *field) { return 0; @@ -1300,7 +1300,7 @@ static void hidinput_handle_scroll(struct hid_usage *usage, void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct hid_usage *usage, __s32 value) { struct input_dev *input; - unsigned *quirks = &hid->quirks; + unsigned int *quirks = &hid->quirks; if (!usage->type) return; From patchwork Tue Jun 16 19:00:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simao Gomes Viana X-Patchwork-Id: 11608483 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE51C13B6 for ; Tue, 16 Jun 2020 19:06:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C744214DB for ; Tue, 16 Jun 2020 19:06:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=superboring.dev header.i=@superboring.dev header.b="YTn4YjzQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730020AbgFPTGt (ORCPT ); Tue, 16 Jun 2020 15:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729988AbgFPTGt (ORCPT ); Tue, 16 Jun 2020 15:06:49 -0400 X-Greylist: delayed 340 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 16 Jun 2020 12:06:48 PDT Received: from mail.halogenos.org (halogenos.org [IPv6:2a02:c207:2037:5246::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC53FC061573 for ; Tue, 16 Jun 2020 12:06:48 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1976B1500CE2; Tue, 16 Jun 2020 21:01:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=superboring.dev; s=dkim; t=1592334074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ePTtzVzTZk1JuadsO9tbd8TX4Uadz1o3NB+qLTLvi2g=; b=YTn4YjzQ14gM7DOneiK5PWsqbJc92Zv1zRYkmp+ZzpzBjC6BHmtSPF9rDzbOgOmHgCK29C gyVLOrKZLqsr/dRQ34lRQ2hkyCBJURUor9yEH2gmI3eRgE0mKHGPMaW3+QVT+JYfeAEy88 D8QRZ+r3Q0756oDXdVZc58O19ygsp55+arva8hdn4p3xC5ZdYJji9v3YWJCzpxQVQFnAYE rwRywQ++RVsroMddWQi4HkTb5WmjDMnvGtdzzQ8fo1wrkkqhXY8DgA/9yoJNdmaUymGrzQ Qt+S5LqFsuR3J6JNpG3hvy5djplss1/vvdV8gHCDILZCnXnJhmvNMv8xf8EZXw== From: Simao Gomes Viana To: Jiri Kosina Cc: Simao Gomes Viana , linux-input@vger.kernel.org Subject: [PATCH 4/4] drivers: hid: move trailing block comment close to new line Date: Tue, 16 Jun 2020 21:00:44 +0200 Message-Id: <20200616190044.126928-4-devel@superboring.dev> In-Reply-To: <20200616190044.126928-1-devel@superboring.dev> References: <20200616190044.126928-1-devel@superboring.dev> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Signed-off-by: Simao Gomes Viana --- drivers/hid/hid-input.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index ef077da7485d..c0a329fd8067 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -2016,7 +2016,8 @@ void hidinput_disconnect(struct hid_device *hid) /* led_work is spawned by input_dev callbacks, but doesn't access the * parent input_dev at all. Once all input devices are removed, we * know that led_work will never get restarted, so we can cancel it - * synchronously and are safe. */ + * synchronously and are safe. + */ cancel_work_sync(&hid->led_work); } EXPORT_SYMBOL_GPL(hidinput_disconnect);