From patchwork Thu Jun 18 09:06:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yangerkun X-Patchwork-Id: 11614091 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2465713A0 for ; Fri, 19 Jun 2020 12:40:05 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7737207E8 for ; Fri, 19 Jun 2020 12:40:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QS/MuW4l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7737207E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592570403; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kM9fAuRlhWWpL0soZeBRfotAojLrNl1nf1gWpoyP+xE=; b=QS/MuW4lV7PspimzDY5sY9s6xzUdlOn3S84DPDWX06fAwcqcwsYUVKRh+qvJzgOWd5rONm ++rpyuYVpRnG7v3GabU609D2Jq7+zwhuJ5xVD+iLxjssbeZ4r2QK5IP7qVfwI2GQ4XTKVo O4okgoj7Zy7tIl8/9/noOYsWZsyK5VM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-Y41DC6f8PGyVDVbIrA7csw-1; Fri, 19 Jun 2020 08:39:18 -0400 X-MC-Unique: Y41DC6f8PGyVDVbIrA7csw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9119564ACA; Fri, 19 Jun 2020 12:39:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7541A7C1EB; Fri, 19 Jun 2020 12:39:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4DEBD1809557; Fri, 19 Jun 2020 12:39:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05I95XQV029492 for ; Thu, 18 Jun 2020 05:05:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id DC44F11921A5; Thu, 18 Jun 2020 09:05:32 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D727D11921A7 for ; Thu, 18 Jun 2020 09:05:30 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D89E48007A4 for ; Thu, 18 Jun 2020 09:05:30 +0000 (UTC) Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-HltVY57zN9qhxPhcLfOuzA-1; Thu, 18 Jun 2020 05:05:23 -0400 X-MC-Unique: HltVY57zN9qhxPhcLfOuzA-1 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9EB5596EC8DAF21BE5C3; Thu, 18 Jun 2020 17:05:19 +0800 (CST) Received: from code-website.localdomain (10.175.127.227) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 18 Jun 2020 17:05:09 +0800 From: yangerkun To: , , , Date: Thu, 18 Jun 2020 17:06:19 +0800 Message-ID: <20200618090620.3517530-2-yangerkun@huawei.com> In-Reply-To: <20200618090620.3517530-1-yangerkun@huawei.com> References: <20200618090620.3517530-1-yangerkun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.127.227] X-CFilter-Loop: Reflected X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 05I95XQV029492 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Fri, 19 Jun 2020 08:38:54 -0400 Cc: dm-devel@redhat.com, yangerkun@huawei.com Subject: [dm-devel] [PATCH v2 1/2] dm dust: list badblock in dust_status X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com List all bad blocks may help user check the status of dust. We add this logical in dust_status, which will return result to user directly. Signed-off-by: yangerkun --- drivers/md/dm-dust.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/drivers/md/dm-dust.c b/drivers/md/dm-dust.c index ff03b90072c5..f96adb240adc 100644 --- a/drivers/md/dm-dust.c +++ b/drivers/md/dm-dust.c @@ -478,6 +478,30 @@ static int dust_message(struct dm_target *ti, unsigned int argc, char **argv, return r; } +static void dust_list_badblocks(struct dust_device *dd, char *result, unsigned int maxlen, + unsigned int *sz_ptr) +{ + unsigned long flags; + struct rb_root badblocklist; + struct rb_node *node; + struct badblock *bblk; + unsigned int sz = *sz_ptr; + int num = 0; + + DMEMIT(" badblocks list:"); + spin_lock_irqsave(&dd->dust_lock, flags); + badblocklist = dd->badblocklist; + for (node = rb_first(&badblocklist); node; node = rb_next(node)) { + bblk = rb_entry(node, struct badblock, node); + DMEMIT(" %llu", bblk->bb); + num++; + } + + spin_unlock_irqrestore(&dd->dust_lock, flags); + if (!num) + DMEMIT(" null"); +} + static void dust_status(struct dm_target *ti, status_type_t type, unsigned int status_flags, char *result, unsigned int maxlen) { @@ -489,6 +513,7 @@ static void dust_status(struct dm_target *ti, status_type_t type, DMEMIT("%s %s %s", dd->dev->name, dd->fail_read_on_bb ? "fail_read_on_bad_block" : "bypass", dd->quiet_mode ? "quiet" : "verbose"); + dust_list_badblocks(dd, result, maxlen, &sz); break; case STATUSTYPE_TABLE: From patchwork Thu Jun 18 09:06:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yangerkun X-Patchwork-Id: 11614079 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02DBB1746 for ; Fri, 19 Jun 2020 12:39:22 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B489721527 for ; Fri, 19 Jun 2020 12:39:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PVvgwDhd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B489721527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592570360; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XT9kVvN7cKUg1UhT2KMHjAMjpJ1PzeWUZSZUHvbK0jQ=; b=PVvgwDhduWP3AMHMv/Zab1yXDYSmmoPUJJ8aZ4hG9iUTyOMOg9EangGlmsI5FuyqWqsvTG QeBgKuN+zYW6Bk6lUCa1/b5gbbueo3irT1Eym/4c3LePZPlRP7RbFxNOqPXYc/4PXaFmY/ z0wzyJcHhxPfgkJecwDy5eD+vZvRdHs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-x82e_SNKPamVeAQmITxseQ-1; Fri, 19 Jun 2020 08:39:19 -0400 X-MC-Unique: x82e_SNKPamVeAQmITxseQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5403364AEA; Fri, 19 Jun 2020 12:39:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 33419100239A; Fri, 19 Jun 2020 12:39:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0C8D7833D3; Fri, 19 Jun 2020 12:39:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05I95bPi029509 for ; Thu, 18 Jun 2020 05:05:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id DCC192028CD2; Thu, 18 Jun 2020 09:05:37 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D883F20267F2 for ; Thu, 18 Jun 2020 09:05:37 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD6A01033654 for ; Thu, 18 Jun 2020 09:05:37 +0000 (UTC) Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-4k5HjnvPMm6vTaudXgleOQ-1; Thu, 18 Jun 2020 05:05:32 -0400 X-MC-Unique: 4k5HjnvPMm6vTaudXgleOQ-1 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 99189FC5DF41890B71E3; Thu, 18 Jun 2020 17:05:19 +0800 (CST) Received: from code-website.localdomain (10.175.127.227) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 18 Jun 2020 17:05:10 +0800 From: yangerkun To: , , , Date: Thu, 18 Jun 2020 17:06:20 +0800 Message-ID: <20200618090620.3517530-3-yangerkun@huawei.com> In-Reply-To: <20200618090620.3517530-1-yangerkun@huawei.com> References: <20200618090620.3517530-1-yangerkun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.127.227] X-CFilter-Loop: Reflected X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 05I95bPi029509 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Fri, 19 Jun 2020 08:38:54 -0400 Cc: dm-devel@redhat.com, yangerkun@huawei.com Subject: [dm-devel] [PATCH v2 2/2] dm dust: introduce list badblocks in the rst X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Since we can list bad blocks with command status, introduce the detail in the doc. Signed-off-by: yangerkun --- .../admin-guide/device-mapper/dm-dust.rst | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/admin-guide/device-mapper/dm-dust.rst b/Documentation/admin-guide/device-mapper/dm-dust.rst index b6e7e7ead831..9267d9330482 100644 --- a/Documentation/admin-guide/device-mapper/dm-dust.rst +++ b/Documentation/admin-guide/device-mapper/dm-dust.rst @@ -205,6 +205,20 @@ appear:: kernel: device-mapper: dust: clearbadblocks: no badblocks found +Listing the bad blocks +---------------------- + +After we have add some bad blocks(like block 1 and 2), run the following +command can help us to check the bad blocks:: + + $ sudo dmsetup status dust1 + 0 33552384 dust 252:17 bypass verbose badblocks list: 1 2 + +And if there is no bad blocks, we will get following results:: + + $ sudo dmsetup status dust1 + 0 33552384 dust 252:17 bypass verbose badblocks list: null + Message commands list ---------------------