From patchwork Thu Jun 25 16:31:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625685 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7EFF260D for ; Thu, 25 Jun 2020 16:33:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4427B206C3 for ; Thu, 25 Jun 2020 16:33:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kbWXEi/D"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jcythmom" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4427B206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W3bjEPecJfnjOpPZt5EV7CmGawl83Zrkf1iWCl9D8Wk=; b=kbWXEi/DNWVKZQqgB18a37cJ7 XgyD87JYJAg8a2Z99PJtWMWoq6oQ/YrDrjpzJruEsEu3oCHpgOYWHIJkI2BJzaJP8jtiG1HcJAQ5N FyQ0jmomAASuPLHsA3+3SWpEqeJksmH/TQP9c02fJgUN1uro8cqM7pRlzXBW4Fb10tl6XYoT0/uQc J3Fq1geK/3Ibt7rHG6t0zpojDeK/mtAEZsswlPWIO74+XWtiwxKrc6QNIfG/epcEgXGeh4OKToFK3 fy/hQhngomJetj/cBD5dnSs0wOOnkG8KxJPWgwe9eeVe9f0QxK0MNKi9chKN/3WnKFownY/iXWTkq bGDSF175Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUn4-0003yT-GS; Thu, 25 Jun 2020 16:31:54 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmn-0003sh-2E for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:38 +0000 Received: by mail-wr1-x444.google.com with SMTP id f7so3509604wrw.1 for ; Thu, 25 Jun 2020 09:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bq/btLCNVpDq7WQbqNzbqWHRqAbD1Rvrp24T5PkKMvQ=; b=jcythmom0hvII4A/DrE6Hw1TYrCtaWr2Amn8NRqD8zdJGovBnTWIOHoKr5nGTkR//D yIgFHe9mEKMvghz25c8EaBymoqXspHL2jfwB25I/P+6rsvpNhL11WuzprjBFm2qzRe15 x4v4AvpxQHxSYrMjJ3Gz67k4zD3LuuGQGakGZyAvmqPXYzPEN7NVzq4HjxzICD98RPKN m2jklcV5OwvPSj4aPw2U4TYpPy4eGg06Tb+Zz3eeHic1lxRkBska2yn6hmTdMYt/goSm Yvk7V3gfIUX0/n0TCEP6H/g254ynuP/uqqJqdCtlnDryKn+HEKPQb/2z2zMjWcNC+stk m44g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bq/btLCNVpDq7WQbqNzbqWHRqAbD1Rvrp24T5PkKMvQ=; b=EF3l0UhHUiepXya4Uni9CZr2EVO72UCictpkmEtcIqR+VyQAGc0ZlsJMu7tSlp7+Xc csy+uddhgti3fANXp+lwL8v0EcflH7OwafL0hVmgT/ln/FXOCafmwN46z7gu9XijPkc8 2wC+mJtxZvZnIk1770kwCZaXz2WUMfjbQcpVLhGtanNo0WzDBIxKrhRQrDS17amxIpa2 IEJH0Jd4QJqlCszDOYZ23KBN/QeEEA8A5SXy7PSYNU3n8T2wTkEtDkbE/MDhK35QSjfC MnduMbU59gK6guYcnp12ppO2bY3wmA+MLBgXDpuZ6vtI6LL5D8CKOAd+jmt3zfTglRkZ UJSQ== X-Gm-Message-State: AOAM531WqUPgu4Ltny3hHJXnUpnO2jd6RHIZoP1Ua3Bgc4FctGfZy8Dc 1/zHfHkOU3Hs+LdfRsUfdEwNhQ== X-Google-Smtp-Source: ABdhPJyK5azuDtfQu+j+mtbkTuNEoVInNEMuX+9qoIDVs73VZrHnCclPv1nUkDUC3iM2iD6b6Pe1kw== X-Received: by 2002:adf:bc41:: with SMTP id a1mr35910174wrh.186.1593102694696; Thu, 25 Jun 2020 09:31:34 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:34 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/10] mfd: cros_ec_dev: Fix cros_feature_to_{name, cells} struct descriptions Date: Thu, 25 Jun 2020 17:31:18 +0100 Message-Id: <20200625163127.4000462-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Bill Richardson , Guenter Roeck , Enric Balletbo i Serra , Benson Leung , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc expects kernel structures to be prefixed with 'struct'. Fixes the following W=1 level warnings: drivers/mfd/cros_ec_dev.c:32: warning: cannot understand function prototype: 'struct cros_feature_to_name ' drivers/mfd/cros_ec_dev.c:44: warning: cannot understand function prototype: 'struct cros_feature_to_cells ' Cc: Benson Leung Cc: Enric Balletbo i Serra Cc: Guenter Roeck Cc: Bill Richardson Signed-off-by: Lee Jones Acked-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 32c2b912b58b2..d07b43d7c761a 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -24,7 +24,7 @@ static struct class cros_class = { }; /** - * cros_feature_to_name - CrOS feature id to name/short description. + * struct cros_feature_to_name - CrOS feature id to name/short description. * @id: The feature identifier. * @name: Device name associated with the feature id. * @desc: Short name that will be displayed. @@ -36,7 +36,7 @@ struct cros_feature_to_name { }; /** - * cros_feature_to_cells - CrOS feature id to mfd cells association. + * struct cros_feature_to_cells - CrOS feature id to mfd cells association. * @id: The feature identifier. * @mfd_cells: Pointer to the array of mfd cells that needs to be added. * @num_cells: Number of mfd cells into the array. From patchwork Thu Jun 25 16:31:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625689 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 53C5060D for ; Thu, 25 Jun 2020 16:33:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C377206C3 for ; Thu, 25 Jun 2020 16:33:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OIQP1oJG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Oc6Gltle" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C377206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OsR/G0hYwAzTBxmU8641Iw9zin5+uirh+xSxa0UZ2uw=; b=OIQP1oJGNPx7ecWOt5jNDTrQx d4O8HiOiaDTOEi/8AA85Lzf6QGu3Ss3bMTru2KFJdYMpFopfOEMwH4JgXDadxit1pDnrW8+5jvViK 9ogiLZnOkVVXj0Ci4m7FSHv/FSfo89KtMqwxqcyN3W+GZm0Q6xpB44AtPZ1D8gGO+KN4nlfHNsVRz xO4cxH4BKGiCsFtbYnOhwqly8xJeBs++CgDyvLOKY2iswK8j4y5DD33y0TG7SZub5IGRUd7UffX3q nNjUTlQqnutDmOvUY0ub9bEn9v8YM9iW4tLQnKZm6zOKvH5C7G8WPzM/8S20ouk/e/CaXjoHgLop9 UOSo8KorQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmx-0003vr-Do; Thu, 25 Jun 2020 16:31:48 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmm-0003tB-QW for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:37 +0000 Received: by mail-wr1-x444.google.com with SMTP id s10so6471508wrw.12 for ; Thu, 25 Jun 2020 09:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SPm1NIoii4wp9HC9Gj5qfuMICtlvrSHRycc3QSZfRtM=; b=Oc6Gltle84A86QA8gNtOqEV/3yAOQ2so8xkE1d2LdYXT4/k3U5+r2QEFnPWiDUAccm Uar3DxQDE6xpe12o0ztoVfC2w4xJlXQy7OjCKQS1nQc3oWmmIcUQ47SqdWmiSz1Ljif7 34wb61IwWDSmV4datUbi2+aSRTQOQIur0agRCRZVkF/UfvLN02otdpR+TPEyceLkmtHk KXHe4u9ly4IXJZAxe7yi2jK7szMHLCFvfVFcOJnV5lQgE0I2bF1TQpsNfEL4zFqNrH/x fr+jLI6l5RfgtVC7SIsW6zeZMON74CmOvWC2kLyD4PSsoJG7VjMpUehREXD5+rs/X6UR PZoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SPm1NIoii4wp9HC9Gj5qfuMICtlvrSHRycc3QSZfRtM=; b=ANTaa3HYb7P2CkHkFjJ17LEzlTHBQt/HXxJadkesPvces0PQFc2zlIblPPn31tW0E6 S0g4u3vpxWSAZ/6h+PHwAmtR/zcL26lYVRNz8qx7taW/V9/3dD7/QmMbHeCJMkCjA3vc 6XiuB1HLXHlS/9Ux/Ifqv8FFaKsM58Ik69XZ7T4zrQBgrw2yjUvIrdJncMiglx4xbAP8 aNSFtWB923iyNNpZgJtZZfzABL6fYArY5wIFkzCGxX3f+HrPaImMINXRLNIAghiNruci RVtEmvJ4UY3sCVgAjvojg14QywZX/t7JwsUHGiZaa7vV8X+BFWo2BNZd7fjlh0E6JoiS jHiw== X-Gm-Message-State: AOAM532RtmcGz71eIA/OfIzw5s8GGnbO6U758Ia3APxRME2+uCg2xlHV a/csRr05xbY6Ou1nI6Z3Z70Qcw== X-Google-Smtp-Source: ABdhPJwES1XecqH4cBXo1fQeYPsxoZ0MTBumS6wvW98Pi31ZCdSAaVU/3Nqdi5GIDI6t+uULaWzFkg== X-Received: by 2002:adf:8168:: with SMTP id 95mr37262827wrm.104.1593102696010; Thu, 25 Jun 2020 09:31:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:35 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 02/10] mfd: tps65218: Repair incorrect function argument name 's/tps65218/tps/' Date: Thu, 25 Jun 2020 17:31:19 +0100 Message-Id: <20200625163127.4000462-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , J Keerthy , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The kerneldocs for both tps65218_reg_write() and tps65218_update_bits() describe their first arguments as 'tps65218', when in reality these are simply called 'tps'. Fixes the following W=1 warnings: drivers/mfd/tps65218.c:58: warning: Function parameter or member 'tps' not described in 'tps65218_reg_write' drivers/mfd/tps65218.c:58: warning: Excess function parameter 'tps65218' description in 'tps65218_reg_write' drivers/mfd/tps65218.c:90: warning: Function parameter or member 'tps' not described in 'tps65218_update_bits' drivers/mfd/tps65218.c:90: warning: Excess function parameter 'tps65218' description in 'tps65218_update_bits' Cc: Tony Lindgren Cc: J Keerthy Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mfd/tps65218.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c index a62ea4cb8be7e..d41dd864b472b 100644 --- a/drivers/mfd/tps65218.c +++ b/drivers/mfd/tps65218.c @@ -48,7 +48,7 @@ static const struct mfd_cell tps65218_cells[] = { /** * tps65218_reg_write: Write a single tps65218 register. * - * @tps65218: Device to write to. + * @tps: Device to write to. * @reg: Register to write to. * @val: Value to write. * @level: Password protected level @@ -79,7 +79,7 @@ EXPORT_SYMBOL_GPL(tps65218_reg_write); /** * tps65218_update_bits: Modify bits w.r.t mask, val and level. * - * @tps65218: Device to write to. + * @tps: Device to write to. * @reg: Register to read-write to. * @mask: Mask. * @val: Value to write. From patchwork Thu Jun 25 16:31:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625697 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7D8A460D for ; Thu, 25 Jun 2020 16:34:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56524206C3 for ; Thu, 25 Jun 2020 16:34:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vXKD+m51"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zjs+Wwp+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56524206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4YyACB9523Gt9R5VD/e83PSh51ahkU37ckQetW0xKZE=; b=vXKD+m51ue53EZfesNMl5DdID Bx7DYGvUqYmsHg74U0x5iAkLh029N4PcuV+BhCBp6p2nIP3R7dW8O96Cdh+PnOp+W5nC4x5OjrtTM 6yk/7ub+G99/yysoHc/lfzmr4PIlz4/ztLUCaz3shi0TumIFREuHtpO/Qau/zGUBCe53UjNxjEoiC 4wPYTV8IfG0JNaiitssNmMRuHTk99nAD024f+nVk6nQLdtQkByh20YmkR+72rIL7YDHRzGArzehEX IzasIu/3ZjsMI6xAeHzdAo7G+Z7nI4qSCxymjvpZXBiu9aP7IRMfRYbzlIb9RRtnIwI9khMrJMiMt F0pOkH/xQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUnE-00041G-5r; Thu, 25 Jun 2020 16:32:04 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmn-0003tY-QC for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:38 +0000 Received: by mail-wm1-x341.google.com with SMTP id f18so6602421wml.3 for ; Thu, 25 Jun 2020 09:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/bWGv4VBKOqL31GzcG0gB8CKWRpsoEmNceOm2KS99aM=; b=Zjs+Wwp+7x9CksZF3ZsaA6S8W81k699KS03axTaAPYPfNau/zqgV3kktdkfj62cfpa E4hX02UAX+KL4mHDuso3yT2uTFKg4RE75yZ4URWvK4eEt+14A87dPWi6X6E59k1pUhBD xbhXWXGSrn8ByiYfzzwfxy9fj1CcNFW1/UWn1esb+iQ9UIHLqobiwHuUYYoOZFHNbDfU lBBG30lPDe7MGubZpNBVzTDmYIZ6x8fLhwZM3YtNjxeHeC82g4b1m7DTS1AnIPPqdqjI BDcehCfNNB3DFg613gUBJYFddVSMYe9BtD/PnhFqlaqYZQpbQoJ1zmqvNociCGQ+QJI9 QhaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/bWGv4VBKOqL31GzcG0gB8CKWRpsoEmNceOm2KS99aM=; b=pJxznGDIO18VGqCnb1uRKdJQWcrLuyPkLDWGfnW9BVprtRu1fYKF0n8g6beIExRnY6 t+gvAd+Y4ZSzsz05TAEySg9HDKqLL1uT0jyOEQby6YeJJcxpN88cd4vVlHZUhPgJ7bp3 ki0jSPx6PmfAx/HDOfSYdvgVEjeVx1rRx1suih4qLR3zLnOacN1Y531ldg8lSq1NF8AM IwU7df9h7Z5jINN0i19NNLy0H4gOGDmXtBobUF1MdaVdpkzliDMwLg1XcFxh2BZYzMSA LNNqz+D7AeuZcTQScXhaUuAdAYBHCQTxrKA96s4sLlE/EuptUMdgwtgD75Vw7earkWkx rulA== X-Gm-Message-State: AOAM531PiCyYAT5g9J0YZz58cWmZmOYYSxRwXZjO2TU8nNz3Wgp4G2cV 981OOxwj1vVYRZbyZqCsNFmFvw== X-Google-Smtp-Source: ABdhPJwowkoEHG814z9kcM+1wV92pQB2K++HtdG/lFR3I8yuJjUhwKOoenqUu6c1TeBI6+cOh5n1Rg== X-Received: by 2002:a1c:24c6:: with SMTP id k189mr4485173wmk.9.1593102696971; Thu, 25 Jun 2020 09:31:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:36 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 03/10] mfd: tps65217: Repair incorrect function argument name 's/tps65217/tps/' Date: Thu, 25 Jun 2020 17:31:20 +0100 Message-Id: <20200625163127.4000462-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , AnilKumar Ch , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The kerneldocs for both tps65217_reg_write() and tps65217_update_bits() describe their first arguments as 'tps65217', when in reality these are simply called 'tps'. Fixes the following W=1 warnings: drivers/mfd/tps65217.c:215: warning: Function parameter or member 'tps' not described in 'tps65217_reg_write' drivers/mfd/tps65217.c:215: warning: Excess function parameter 'tps65217' description in 'tps65217_reg_write' drivers/mfd/tps65217.c:261: warning: Function parameter or member 'tps' not described in 'tps65217_update_bits' drivers/mfd/tps65217.c:261: warning: Excess function parameter 'tps65217' description in 'tps65217_update_bits' Cc: Tony Lindgren Cc: AnilKumar Ch Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mfd/tps65217.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c index 7566ce4457a01..923602599549b 100644 --- a/drivers/mfd/tps65217.c +++ b/drivers/mfd/tps65217.c @@ -205,7 +205,7 @@ EXPORT_SYMBOL_GPL(tps65217_reg_read); /** * tps65217_reg_write: Write a single tps65217 register. * - * @tps65217: Device to write to. + * @tps: Device to write to. * @reg: Register to write to. * @val: Value to write. * @level: Password protected level @@ -250,7 +250,7 @@ EXPORT_SYMBOL_GPL(tps65217_reg_write); /** * tps65217_update_bits: Modify bits w.r.t mask, val and level. * - * @tps65217: Device to write to. + * @tps: Device to write to. * @reg: Register to read-write to. * @mask: Mask. * @val: Value to write. From patchwork Thu Jun 25 16:31:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625695 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2B92F60D for ; Thu, 25 Jun 2020 16:34:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 011BC206C3 for ; Thu, 25 Jun 2020 16:34:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B76XvG6a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eCsjtb0C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 011BC206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pcuoJQIMPbBHMsoEtjNK+tJzT4xZ2C9fyiSEsSb7M2A=; b=B76XvG6aAhYXPNChrxhX9zVUa iL8GxpEWPdHKD2wO2mIZBXjwoE3t/zv4Q9OU0LrB4vgYDU90soMDELHrUale6ylR0eL2WmrU6qL3j NN78nv6egzOnDmKy0Gbil9QcPVJpuP68r6Cd2Pg78K8hB02GtSNqWpl/E+KcUCoyvNfb63U7wv5i3 Plbx7PWit4F9aftjVOwDcXmfb9SKhhg0d6EuTs+RGGrMSEJrM9+2naXCadnhJgDFhF2hIXTG/AAKU JFwpUWRWNZRy8g+RGJExG/HBp8pKOMF/Ao7dsgW5WxXZ24C1Dt6BLPYPyOCHlb4dIBPj5RVCb/NGq yn879h8Aw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUnH-00043a-MM; Thu, 25 Jun 2020 16:32:07 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmo-0003tv-Vs for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:40 +0000 Received: by mail-wm1-x344.google.com with SMTP id q15so6189055wmj.2 for ; Thu, 25 Jun 2020 09:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EoDDRWYqSRFNxuy0oLGiJ2BCcmCTg6+79vgN6npQkDY=; b=eCsjtb0CD0LDkL/xpQgVQpUKp46erAgw6x4yrXv2r8sD3j++WjCcmIyOt1/Ru6SBKS 31Wn7T59R8BrNIi+NbhvYd1Dwd7McIkOUfHsMrPDmjJ7Eevz7+PwJ2mZlbE1thlXu6td qpIf95KNd37Ub8rtfwRk8obKD8t7NdwtO3qLfJpkGf56W6hHceqWDZe+g+lR3tycgaNf ftPDOpr/JIFpSRm/X6hLfJOuvtaGSqyecEG6Wmnilnk7XeamBZuOZ30XIIiCyLLJ6FyS /lod4D62NPUbBm6aLWDd0162ZdkwbS2gLu+NVSsCgaDE7Gsv93oeh4HR1+6xDDHaJ0jt 8iUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EoDDRWYqSRFNxuy0oLGiJ2BCcmCTg6+79vgN6npQkDY=; b=QTS1R8hX6GcgJdxFARIcSa4fIQNE6mFB0LTBMqa/nWewITnA5jbZuZlwsEKCNvRwLe JjMwD/R1kkKziyMfGiprGA/AV4yUrae4jYefHGPGCs+VK6LE18dI2llAEJ+Oky9/VhsX OPjJ/93L9u8X5023CY1SuxJce9l8SJ7cfeLOA1D+gYeLvQtL7oj1aSDqbY1HMMmduXgA Jj/GC1v/2rMWYBw5PnG8FZoEKNrY/vZ04SdeIOIlPBNYk6IetLAS90gq1Ym0UfdR8Rw4 cvGUaC2QnjPnPMYrkPsIvp4bmVl509FHT/KwYpe5gMh4ddSg0uXcff2/Qw6gXM13cglb yUCQ== X-Gm-Message-State: AOAM530mIKHMh3V2qkRkr1icRWMndOcQXaaO73zV+n/dwa4fE0Z24lAd YeNGyUatOiczdg744lrLcZsdSg== X-Google-Smtp-Source: ABdhPJxs0E1ZwZRgy1IPBlo62VKJtW4RR3mcSMYVd6SruY6FQ67fUZ/rYYoLZFZyV6U9/jG7A6WazQ== X-Received: by 2002:a7b:cbcb:: with SMTP id n11mr4041219wmi.99.1593102698025; Thu, 25 Jun 2020 09:31:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:37 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 04/10] mfd: ab3100-otp: Add missing colon(s) for all documented kerneldoc arguments Date: Thu, 25 Jun 2020 17:31:21 +0100 Message-Id: <20200625163127.4000462-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc validation gets confused if syntax isn't "@.*: ". Adding the missing colons squashes the following W=1 warnings: drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'dev' not described in 'ab3100_otp' drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'locked' not described in 'ab3100_otp' drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'freq' not described in 'ab3100_otp' drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'paf' not described in 'ab3100_otp' drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'imeich' not described in 'ab3100_otp' drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'cid' not described in 'ab3100_otp' drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'tac' not described in 'ab3100_otp' drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'fac' not described in 'ab3100_otp' drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'svn' not described in 'ab3100_otp' drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'debugfs' not described in 'ab3100_otp' Cc: Linus Walleij Signed-off-by: Lee Jones Reviewed-by: Linus Walleij --- drivers/mfd/ab3100-otp.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/ab3100-otp.c b/drivers/mfd/ab3100-otp.c index c4751fb9bc224..c393102e3a394 100644 --- a/drivers/mfd/ab3100-otp.c +++ b/drivers/mfd/ab3100-otp.c @@ -29,22 +29,22 @@ /** * struct ab3100_otp - * @dev containing device - * @locked whether the OTP is locked, after locking, no more bits + * @dev: containing device + * @locked: whether the OTP is locked, after locking, no more bits * can be changed but before locking it is still possible * to change bits from 1->0. - * @freq clocking frequency for the OTP, this frequency is either + * @freq: clocking frequency for the OTP, this frequency is either * 32768Hz or 1MHz/30 - * @paf product activation flag, indicates whether this is a real + * @paf: product activation flag, indicates whether this is a real * product (paf true) or a lab board etc (paf false) - * @imeich if this is set it is possible to override the + * @imeich: if this is set it is possible to override the * IMEI number found in the tac, fac and svn fields with * (secured) software - * @cid customer ID - * @tac type allocation code of the IMEI - * @fac final assembly code of the IMEI - * @svn software version number of the IMEI - * @debugfs a debugfs file used when dumping to file + * @cid: customer ID + * @tac: type allocation code of the IMEI + * @fac: final assembly code of the IMEI + * @svn: software version number of the IMEI + * @debugfs: a debugfs file used when dumping to file */ struct ab3100_otp { struct device *dev; From patchwork Thu Jun 25 16:31:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625687 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4609A60D for ; Thu, 25 Jun 2020 16:33:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E35320767 for ; Thu, 25 Jun 2020 16:33:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F0xmJ/iq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vy09unAz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E35320767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aIGEht7PZCj3m44CMTHmlAHU+g8S7EgbKeJWUXaTtt4=; b=F0xmJ/iqD8npv3nIYyBHEJHiX f6xeuXNy7mIUV2KARLWMqpc+H4HHfbNH9k55L5IcvB3i5JzRKXuw8Fsrw1NqIs4a9tCu7F/TUqNwY HgRj6di9OdH/i23SKgEXrIz8fyoUHS8OmtX6wt027GjSs4axEm0NpC0s2uTFJJcSrKez4kmnUxcVJ gcKGPOwCQZzcMWq/zzU9hEY60XAvw7OL9e46V87BuhRbcAQ+sAVymCz9RE7ldazXxWUPoggU2Csag gUq/YPJ8enpF1irNmNjwRKJjL9gITP9XSeZd1apnhhIEkbDWPNj0NpGuGs8f3fxeQt0wy5P2NanLQ Wb2Na6Dtw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUnK-00044Y-7h; Thu, 25 Jun 2020 16:32:10 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmq-0003uK-0S for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:40 +0000 Received: by mail-wr1-x444.google.com with SMTP id k6so6512917wrn.3 for ; Thu, 25 Jun 2020 09:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XxI9BhAfrJpW+cNsrQPMJfGCyd0KQMsn+2Q7Z4q8M9M=; b=Vy09unAzWzBm7p/Z8sXAwDBEEE541im9XUsCyfot+2sgPnWxZ2Gk5OrQMMvieY77Os n/epknFjcJIi8dhWDYCm48+cKrTSOhhFZFRTka1gidFJj/xEKmZ376Hg68SNO7cxFWwq qN1OA9DfITpdWYPfEJzJZkw0NfW0chYPuKe3LzdaFOAXPXshL564Cs/+OjnXg0NrM6jD kecVxgzOY6jeUG18XeAXUkQg/YvYL5Qr+YJVNIizm52jJSF3PDN29Xo6olSalcDKCQrB 3hV8f/H3fYJ5QGtr1oU4rBXp3CTZsyppJIKcLX0Ja6oJ/BLNlTwztfq3p48PSogBaHrm Fa1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XxI9BhAfrJpW+cNsrQPMJfGCyd0KQMsn+2Q7Z4q8M9M=; b=Br+ElFkehZO8KU02OtxdKqPIZBTIk6mOfy5YQww79KeWcyRZ/Gwqr25F/8i2EfdPgQ WLNSPY0edyOgi0+NLlZAfUkUtVtsjI34a6kPvPLQ3uCrogisXeeYnahDbQBkWIOsblkM AOnWxBr+X3YOohytos1Cx7Bp8Y3QHEruwT6aR/y68Mu7JmaQDYwn4yZJuQLFTDAn623c PNYmxZwoY/pV2fQ8dO6xhDiRLzzrdxS9qS2yHhTjdk87+dovh5IIkCHHvmX6XBNZSWsd SugzuBzIygR11Bqhu7dr0vhpTfpaVrCF4lwIe2Kaz3uO1u9q1S+P0Usk+V4ayRyPitJ1 DMAw== X-Gm-Message-State: AOAM530BqLmDUdJZxuJT0dkuijGk4wqXJlhNmUzp2Br1hlCOwIpsUEKY v/p/miCXmG8hoJL5jAkuhzBUUF22H3M= X-Google-Smtp-Source: ABdhPJxQcDZfTw8ATt3Q/S58X6QJDPiWu01vMmoV+iJw+tDAjnCJEPQ+9Ztl2EgWWXsNZTzZ1KeYEg== X-Received: by 2002:adf:8b5a:: with SMTP id v26mr37295310wra.165.1593102699140; Thu, 25 Jun 2020 09:31:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:38 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/10] mfd: tps65010: Remove delcared and set, but never used variable 'status' Date: Thu, 25 Jun 2020 17:31:22 +0100 Message-Id: <20200625163127.4000462-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'status' hasn't been checked since 2008. It's probably safe to remove it. Fixes W=1 warning: drivers/mfd/tps65010.c:407:7: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] 407 | int status; | ^~~~~~ Signed-off-by: Lee Jones --- drivers/mfd/tps65010.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c index 65fcc58c02da8..7e7dbee58ca90 100644 --- a/drivers/mfd/tps65010.c +++ b/drivers/mfd/tps65010.c @@ -404,7 +404,6 @@ static void tps65010_work(struct work_struct *work) tps65010_interrupt(tps); if (test_and_clear_bit(FLAG_VBUS_CHANGED, &tps->flags)) { - int status; u8 chgconfig, tmp; chgconfig = i2c_smbus_read_byte_data(tps->client, @@ -415,8 +414,8 @@ static void tps65010_work(struct work_struct *work) else if (tps->vbus >= 100) chgconfig |= TPS_VBUS_CHARGING; - status = i2c_smbus_write_byte_data(tps->client, - TPS_CHGCONFIG, chgconfig); + i2c_smbus_write_byte_data(tps->client, + TPS_CHGCONFIG, chgconfig); /* vbus update fails unless VBUS is connected! */ tmp = i2c_smbus_read_byte_data(tps->client, TPS_CHGCONFIG); From patchwork Thu Jun 25 16:31:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625699 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A4BBC138C for ; Thu, 25 Jun 2020 16:34:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E08420767 for ; Thu, 25 Jun 2020 16:34:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RG3gP5Wu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Rsf1N6yX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E08420767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3IkeRe/LL5l8d3JIlbYCERWw5oEpxmheR1ud3o5Zrf4=; b=RG3gP5WutM2rUPPQllqrMZL/c /UHBxW3boLLosHEhAbqRqXKCQdat59dRuPnwW22+pgOx/iZFn7NgVANMfJv1D3ZITggtgowB39PB6 n0DB1PqkV8Q88Z9xeDwjGJ8eTQpL51o6Dv3GoZWEOsvmiwzlUJ/tDfp4G+djNeTAenohWHGZMkmQl 8e6MCYgXQ1t2frG8TSPDYWsZO7nqqNdIfAEafreKmtkSyGeuBkDB8pYtuXQTgjF2xTjlc5aWJukcp 7k58/uoCJBSS6UzIZPfJfFWzOaCSTVq9Us0O3ZHdRqeM+TtLMyA+G9tvnqM2/HQ7+NiPFJqOjt8oG dsyR1aGfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUnN-00045x-3J; Thu, 25 Jun 2020 16:32:13 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmr-0003un-3Y for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:42 +0000 Received: by mail-wm1-x344.google.com with SMTP id l2so5111478wmf.0 for ; Thu, 25 Jun 2020 09:31:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rS9j2rQNFBNuRqF+LXK8DlVraMrXmRrORbc3erknD/A=; b=Rsf1N6yX7IxQGRLHSgXSpJP/QPbCuo2R1yR5hRp/jiWLAjlOONAIfPujcEjKgSdHQq HCdTJkdvd5BFjh1Bf4cFe8BzerfwN1dBFhQUFxF2l/p1UxJkuvzb87JUP9Toy1Dy2axP a0LXFQn4VuxV6m0LMVFRM7zV0Uc8Z7kDndCgJbFlhEyRA0LwFTWA5a6HeDrPOr1yYDD0 zLqv5Mi39CHmn58FiUh2XnxGJdysqcpFfOV7VH5Ll6rpkZHvKIPTXw3GtnCZ+KGLOvMG hjQBHX76GS7NR1yBcE561TiGBTocOaLGrfvZnmZqg7tfQe775ibW+ZCGKNSY7nrv4GFD KOIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rS9j2rQNFBNuRqF+LXK8DlVraMrXmRrORbc3erknD/A=; b=uPcAKQMI3Jk+GcQcdKBOq1cEL2VztL6pV3KHme1bpCS4UXhcgcyrdbthi1OUgFEDA1 pIKxatRtlSvpshFnLNdMkRwb6I0/dVsQnQJ+xMyLQ1SdpCq6wUGt/IXLoT0KmbyxGBby 0Q9CB5PqrE/YZan3jfUS55i6j8BwfZ6BLcWUzjXu2B04GARWwZk49zXwOM+Hi1AzTjIV /6FR2WoibS+oZk6+7u1eaECIg751apy16l3YwMKgFfJQOI+vnl0Cq3efHvQXlp8/6r80 Cu7HNEEG+rwn4GY3jM0rB5cfYflYECCDLwbO3B3btzu+WIYqBQmbPQUDBEmz+pco3nul utaw== X-Gm-Message-State: AOAM532NGzbRFhhkhicKAI/SjHCprPXRcNFwzkzXQ0WeAgGsi7Ut2zyB FPwfDv78dAPc0flI0QVm8cM5LuqQnSk= X-Google-Smtp-Source: ABdhPJzhQiFSSOZa69VFgcR0DY0GlXvIC6q9WGt36h5eMePZdVb++c5OYhmvra/vUdFSxkb68YaCJQ== X-Received: by 2002:a7b:c76a:: with SMTP id x10mr4312440wmk.16.1593102700156; Thu, 25 Jun 2020 09:31:40 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:39 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/10] mfd: si476x-cmd: Repair wrongly described function argument 's/response/resp' Date: Thu, 25 Jun 2020 17:31:23 +0100 Message-Id: <20200625163127.4000462-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org si476x_core_send_command()'s 5th argument has never been called response. This change must have occurred prior to the driver being Mainlined. We're also taking the opportunity to bring the first description back into line, making my OCD happy! This fixes the following W=1 warning(s): drivers/mfd/si476x-cmd.c:264: warning: Function parameter or member 'resp' not described in 'si476x_core_send_command drivers/mfd/si476x-cmd.c:264: warning: Excess function parameter 'response' description in 'si476x_core_send_command' Cc: Andrey Smirnov Signed-off-by: Lee Jones --- drivers/mfd/si476x-cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/si476x-cmd.c b/drivers/mfd/si476x-cmd.c index 4a09ce9609c90..316d44c2edcd4 100644 --- a/drivers/mfd/si476x-cmd.c +++ b/drivers/mfd/si476x-cmd.c @@ -241,13 +241,13 @@ static int si476x_core_parse_and_nag_about_error(struct si476x_core *core) /** * si476x_core_send_command() - sends a command to si476x and waits its * response - * @core: si476x_device structure for the device we are + * @core: si476x_device structure for the device we are * communicating with * @command: command id * @args: command arguments we are sending * @argn: actual size of @args - * @response: buffer to place the expected response from the device - * @respn: actual size of @response + * @resp: buffer to place the expected response from the device + * @respn: actual size of @resp * @usecs: amount of time to wait before reading the response (in * usecs) * From patchwork Thu Jun 25 16:31:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625703 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 60773138C for ; Thu, 25 Jun 2020 16:34:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AA5E206C3 for ; Thu, 25 Jun 2020 16:34:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GThK9Ky0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ARVv8HhU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AA5E206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XeHSZxDiytpQdzuxktdJ7d7XtKI2e7TMAdIn5FPL4QE=; b=GThK9Ky0VfROW//paNn7sDctK ZZTSRRPelW5NBuM252jPCYPnkUqfGQuA/EU78aLPERfWyv0+zKysZ3SPhZElFP5VA/KO9YmFeBR6U oIq6Vg5uzBUQf+ccbXgch6Me2wv8Irqe3z572rMrQSXBjIIvZ3lyrROi6C6p0qBPKj2x043Xe2/Re vM5+YGu3DtRbviWaESFDdE7lVliH3Iw0yzCori+l8GFNq+PeQ/YEXtLUoeeP8EHsVVK6SpWeh4ze6 RodeWn7H2Wo9gcA2UoeOpvfc7L8F2/cB7Pr7aDeTFfIxdkbaORty3ZLXFds2pW9tome6rzddSUC8g gYg7rnDWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUng-0004FJ-3P; Thu, 25 Jun 2020 16:32:32 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUms-0003vB-Of for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:48 +0000 Received: by mail-wm1-x343.google.com with SMTP id f18so6602677wml.3 for ; Thu, 25 Jun 2020 09:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6WT7h1Rv45O3atqnarAKKAFYuh59qbPlwPNodrXrSPg=; b=ARVv8HhUOnUYrUqklxVAxxRHJM0L4zbLlrC6PuHsKVz+pl9qu2EmdJVm2WIqJFCgbR U0bNDkLkLD0AtQxk6WAfnyDBsVYqXiIfUxUtbN94mYHriEytUv76VRMv5xMYUC7Ni8Ar a5TYx1foBZNaPvLg9DB5kg/pANL4nZ7PIIBIjUjvaPjMCupvQVpT0S4RStIWAgWOPrJQ EL7YNzaNvPJtUD4FXyxm2OY59xVcQ2OilUE/OxPx1QtM47arj0JF+rpFjFH1AU7l6oz7 +r4IrLacD/9n+iVVxd523LlQ8EiD5zMzhjXoxpEKHN11f76hMUB9BDbNAOOx6lgZ47ow 9XTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6WT7h1Rv45O3atqnarAKKAFYuh59qbPlwPNodrXrSPg=; b=MMQ1wMRF2FH0Y++kqm/i4QcCYNZXmwv68mCkV8WlPZ4OYUbyTPElOJNsa/ms2PjIG/ CY+F0okkAV1pWk8/H+elnCMb+a6FkktCmI0GQtMEgTCMlYXlrGDdjPxrokCzTeLvmMs0 E+/S/TEYPNwhDCmY7c46Dl66/KClX7rESkfrzCrv3V7elA050y69TL+jcTglrfTwEHgm O7947t4dOKCnMk6Kk26pPJh5TvHQPAhqgkw+UCfcr3enhu9V63JQWUZbqMI0ujrOXcKs bLhQMy8nWN/uoNEpjE6tvLs147aWSOUX/d9g0qS5qh5bXQ38wa3uqB2xowEa4aCIVujN 7Tgw== X-Gm-Message-State: AOAM531YIyEcHjsaaL9R5mB0R4zowL7kLoO2rw1qdll1OidUStyFhN86 /RZEhlXhBaTtAiTXN11oAQnGNw== X-Google-Smtp-Source: ABdhPJwJwWjOF0ZaS/IPLE2Q4MNqGjjLQnhA8K9AoN9yt+zSvcXTt+viMKV9cibJeAkDvqX5+5rcTw== X-Received: by 2002:a1c:e910:: with SMTP id q16mr4258261wmc.188.1593102701324; Thu, 25 Jun 2020 09:31:41 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:40 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 07/10] mfd: si476x-cmd: Add missing colon(s) for all documented kerneldoc arguments Date: Thu, 25 Jun 2020 17:31:24 +0100 Message-Id: <20200625163127.4000462-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc validation gets confused if syntax isn't "@.*: ". Adding the missing colons squashes the following W=1 warnings: drivers/mfd/si476x-cmd.c:525: warning: Function parameter or member 'dout' not described in 'si476x_core_cmd_dig_audio_pin_c drivers/mfd/si476x-cmd.c:525: warning: Function parameter or member 'xout' not described in 'si476x_core_cmd_dig_audio_pin_c drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_zif_pin_cfg' drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'iqclk' not described in 'si476x_core_cmd_zif_pin_cfg' drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'iqfs' not described in 'si476x_core_cmd_zif_pin_cfg' drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'iout' not described in 'si476x_core_cmd_zif_pin_cfg' drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'qout' not described in 'si476x_core_cmd_zif_pin_cfg' drivers/mfd/si476x-i2c.c:550: warning: Function parameter or member 'func' not described in 'si476x_core_fwver_to_revision' drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_ic_link_gpo_ctl drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'icin' not described in 'si476x_core_cmd_ic_link_gpo_ctl drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'icip' not described in 'si476x_core_cmd_ic_link_gpo_ctl drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'icon' not described in 'si476x_core_cmd_ic_link_gpo_ctl drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'icop' not described in 'si476x_core_cmd_ic_link_gpo_ctl drivers/mfd/si476x-cmd.c:662: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_ana_audio_pin_c drivers/mfd/si476x-cmd.c:662: warning: Function parameter or member 'lrout' not described in 'si476x_core_cmd_ana_audio_pin_ drivers/mfd/si476x-cmd.c:697: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_intb_pin_cfg_a1 drivers/mfd/si476x-cmd.c:697: warning: Function parameter or member 'intb' not described in 'si476x_core_cmd_intb_pin_cfg_a1 drivers/mfd/si476x-cmd.c:697: warning: Function parameter or member 'a1' not described in 'si476x_core_cmd_intb_pin_cfg_a10' drivers/mfd/si476x-cmd.c:746: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_am_rsq_status' drivers/mfd/si476x-cmd.c:746: warning: Function parameter or member 'rsqargs' not described in 'si476x_core_cmd_am_rsq_statu drivers/mfd/si476x-cmd.c:746: warning: Function parameter or member 'report' not described in 'si476x_core_cmd_am_rsq_status drivers/mfd/si476x-cmd.c:878: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_fm_seek_start' drivers/mfd/si476x-cmd.c:878: warning: Function parameter or member 'seekup' not described in 'si476x_core_cmd_fm_seek_start drivers/mfd/si476x-cmd.c:878: warning: Function parameter or member 'wrap' not described in 'si476x_core_cmd_fm_seek_start' drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_fm_rds_status' drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'status_only' not described in 'si476x_core_cmd_fm_rds_s drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'mtfifo' not described in 'si476x_core_cmd_fm_rds_status drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'intack' not described in 'si476x_core_cmd_fm_rds_status drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'report' not described in 'si476x_core_cmd_fm_rds_status drivers/mfd/si476x-cmd.c:1052: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_am_seek_start' drivers/mfd/si476x-cmd.c:1052: warning: Function parameter or member 'seekup' not described in 'si476x_core_cmd_am_seek_star drivers/mfd/si476x-cmd.c:1052: warning: Function parameter or member 'wrap' not described in 'si476x_core_cmd_am_seek_start' Cc: Andrey Smirnov Signed-off-by: Lee Jones --- drivers/mfd/si476x-cmd.c | 66 ++++++++++++++++++++-------------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/mfd/si476x-cmd.c b/drivers/mfd/si476x-cmd.c index 316d44c2edcd4..5b42dfab431a3 100644 --- a/drivers/mfd/si476x-cmd.c +++ b/drivers/mfd/si476x-cmd.c @@ -496,7 +496,7 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_get_property); * enable 1MOhm pulldown * SI476X_DFS_DAUDIO - set the pin to be a part of digital * audio interface - * @dout - DOUT pin function configuration: + * @dout: - DOUT pin function configuration: * SI476X_DOUT_NOOP - do not modify the behaviour * SI476X_DOUT_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown @@ -504,7 +504,7 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_get_property); * port 1 * SI476X_DOUT_I2S_INPUT - set this pin to be digital in on I2S * port 1 - * @xout - XOUT pin function configuration: + * @xout: - XOUT pin function configuration: * SI476X_XOUT_NOOP - do not modify the behaviour * SI476X_XOUT_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown @@ -540,25 +540,25 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_dig_audio_pin_cfg); /** * si476x_cmd_zif_pin_cfg - send 'ZIF_PIN_CFG_COMMAND' - * @core - device to send the command to - * @iqclk - IQCL pin function configuration: + * @core: - device to send the command to + * @iqclk: - IQCL pin function configuration: * SI476X_IQCLK_NOOP - do not modify the behaviour * SI476X_IQCLK_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown * SI476X_IQCLK_IQ - set pin to be a part of I/Q interace * in master mode - * @iqfs - IQFS pin function configuration: + * @iqfs: - IQFS pin function configuration: * SI476X_IQFS_NOOP - do not modify the behaviour * SI476X_IQFS_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown * SI476X_IQFS_IQ - set pin to be a part of I/Q interace * in master mode - * @iout - IOUT pin function configuration: + * @iout: - IOUT pin function configuration: * SI476X_IOUT_NOOP - do not modify the behaviour * SI476X_IOUT_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown * SI476X_IOUT_OUTPUT - set pin to be I out - * @qout - QOUT pin function configuration: + * @qout: - QOUT pin function configuration: * SI476X_QOUT_NOOP - do not modify the behaviour * SI476X_QOUT_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown @@ -590,29 +590,29 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_zif_pin_cfg); /** * si476x_cmd_ic_link_gpo_ctl_pin_cfg - send * 'IC_LINK_GPIO_CTL_PIN_CFG' comand to the device - * @core - device to send the command to - * @icin - ICIN pin function configuration: + * @core: - device to send the command to + * @icin: - ICIN pin function configuration: * SI476X_ICIN_NOOP - do not modify the behaviour * SI476X_ICIN_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown * SI476X_ICIN_GPO1_HIGH - set pin to be an output, drive it high * SI476X_ICIN_GPO1_LOW - set pin to be an output, drive it low * SI476X_ICIN_IC_LINK - set the pin to be a part of Inter-Chip link - * @icip - ICIP pin function configuration: + * @icip: - ICIP pin function configuration: * SI476X_ICIP_NOOP - do not modify the behaviour * SI476X_ICIP_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown * SI476X_ICIP_GPO1_HIGH - set pin to be an output, drive it high * SI476X_ICIP_GPO1_LOW - set pin to be an output, drive it low * SI476X_ICIP_IC_LINK - set the pin to be a part of Inter-Chip link - * @icon - ICON pin function configuration: + * @icon: - ICON pin function configuration: * SI476X_ICON_NOOP - do not modify the behaviour * SI476X_ICON_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown * SI476X_ICON_I2S - set the pin to be a part of audio * interface in slave mode (DCLK) * SI476X_ICON_IC_LINK - set the pin to be a part of Inter-Chip link - * @icop - ICOP pin function configuration: + * @icop: - ICOP pin function configuration: * SI476X_ICOP_NOOP - do not modify the behaviour * SI476X_ICOP_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown @@ -647,8 +647,8 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_ic_link_gpo_ctl_pin_cfg); /** * si476x_cmd_ana_audio_pin_cfg - send 'ANA_AUDIO_PIN_CFG' to the * device - * @core - device to send the command to - * @lrout - LROUT pin function configuration: + * @core: - device to send the command to + * @lrout: - LROUT pin function configuration: * SI476X_LROUT_NOOP - do not modify the behaviour * SI476X_LROUT_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown @@ -675,15 +675,15 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_ana_audio_pin_cfg); /** * si476x_cmd_intb_pin_cfg - send 'INTB_PIN_CFG' command to the device - * @core - device to send the command to - * @intb - INTB pin function configuration: + * @core: - device to send the command to + * @intb: - INTB pin function configuration: * SI476X_INTB_NOOP - do not modify the behaviour * SI476X_INTB_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown * SI476X_INTB_DAUDIO - set pin to be a part of digital * audio interface in slave mode * SI476X_INTB_IRQ - set pin to be an interrupt request line - * @a1 - A1 pin function configuration: + * @a1: - A1 pin function configuration: * SI476X_A1_NOOP - do not modify the behaviour * SI476X_A1_TRISTATE - put the pin in tristate condition, * enable 1MOhm pulldown @@ -728,14 +728,14 @@ static int si476x_core_cmd_intb_pin_cfg_a20(struct si476x_core *core, /** * si476x_cmd_am_rsq_status - send 'AM_RSQ_STATUS' command to the * device - * @core - device to send the command to - * @rsqack - if set command clears RSQINT, SNRINT, SNRLINT, RSSIHINT, + * @core: - device to send the command to + * @rsqack: - if set command clears RSQINT, SNRINT, SNRLINT, RSSIHINT, * RSSSILINT, BLENDINT, MULTHINT and MULTLINT - * @attune - when set the values in the status report are the values + * @attune: - when set the values in the status report are the values * that were calculated at tune - * @cancel - abort ongoing seek/tune opertation - * @stcack - clear the STCINT bin in status register - * @report - all signal quality information retured by the command + * @cancel: - abort ongoing seek/tune opertation + * @stcack: - clear the STCINT bin in status register + * @report: - all signal quality information retured by the command * (if NULL then the output of the command is ignored) * * Function returns 0 on success and negative error code on failure @@ -862,9 +862,9 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_am_acf_status); /** * si476x_cmd_fm_seek_start - send 'FM_SEEK_START' command to the * device - * @core - device to send the command to - * @seekup - if set the direction of the search is 'up' - * @wrap - if set seek wraps when hitting band limit + * @core: - device to send the command to + * @seekup: - if set the direction of the search is 'up' + * @wrap: - if set seek wraps when hitting band limit * * This function begins search for a valid station. The station is * considered valid when 'FM_VALID_SNR_THRESHOLD' and @@ -890,12 +890,12 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_fm_seek_start); /** * si476x_cmd_fm_rds_status - send 'FM_RDS_STATUS' command to the * device - * @core - device to send the command to - * @status_only - if set the data is not removed from RDSFIFO, + * @core: - device to send the command to + * @status_only: - if set the data is not removed from RDSFIFO, * RDSFIFOUSED is not decremented and data in all the * rest RDS data contains the last valid info received - * @mtfifo if set the command clears RDS receive FIFO - * @intack if set the command clards the RDSINT bit. + * @mtfifo: if set the command clears RDS receive FIFO + * @intack: if set the command clards the RDSINT bit. * * Function returns 0 on success and negative error code on failure */ @@ -1036,9 +1036,9 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_fm_phase_div_status); /** * si476x_cmd_am_seek_start - send 'FM_SEEK_START' command to the * device - * @core - device to send the command to - * @seekup - if set the direction of the search is 'up' - * @wrap - if set seek wraps when hitting band limit + * @core: - device to send the command to + * @seekup: - if set the direction of the search is 'up' + * @wrap: - if set seek wraps when hitting band limit * * This function begins search for a valid station. The station is * considered valid when 'FM_VALID_SNR_THRESHOLD' and From patchwork Thu Jun 25 16:31:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625693 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BB83214E3 for ; Thu, 25 Jun 2020 16:34:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92D9120767 for ; Thu, 25 Jun 2020 16:34:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PU5zr03N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vuRTp0pw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92D9120767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OPnIACs4dusja36xa9cVYADeh6PjJNEyupII6+AU7pg=; b=PU5zr03N1GIi2ab4D8NVcB2LF zpFVqdDHYK9aIeOPk014/NT54Orpn9IgAy28AYNUp8GXBM1V0lvssgyHmkXAj3Fc/Ctw7AYZKzgvI h1qKKcf/84Keowy/eF1tyvOONTUmACiiPM5mi8hrJxjT+wr/9zvQ0NkcgOlIqrerarLnqdnxS9X2v fiSRJR2J2eJEcVFooHaZ6TG9QNluSXFCaPsWUcEMmsk4PPP9ax+wlpqHsO8TbscMobjgu4Q1cxN9L Mm4Px8o1TNY0U9S81SZx8tbrh2awRWxvN78Wu7ysAbS//SQ4YNBEi6HonSNDtEM+dBeBOtZaIzucF eZHF4iu+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUnV-0004A3-PS; Thu, 25 Jun 2020 16:32:21 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmt-0003vQ-6O for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:45 +0000 Received: by mail-wr1-x444.google.com with SMTP id r12so6451961wrj.13 for ; Thu, 25 Jun 2020 09:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k8LHcx9qvNOxdNgpbKyrwuZ34KPVZZIgrr7AZi6KeZA=; b=vuRTp0pwkrASLzZlEd7t4bzVTihvDKzr6q/V1/a5h2KOgNHNmLVb3LCRQs3fqx6eDs g066CUVbKbA1D6tXqZLZP15dAlDHHd/sUfhuhsXQ6mq6VPWr2PWIipubrFXNm+EPZlZS 4DB3EK9bHiHFNPdNdKLwfjNFwx5IrjiTWbthsvgfnUVdVMvUA/cCOZMgBzPblB7y9Wk2 bwQvt4Wb13Js+kWH1OQ7tjj7UY7JaBPIA9Pc3xO2lYp5vxkZUGtBd49ngrtmOqeWcXHL voXi/mVlWJiM4sQoRJ4ilt5yTDUEBXzrNxdxa2qjofTn7ZAy96MtnSiItN21r4dAfPa1 9pcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k8LHcx9qvNOxdNgpbKyrwuZ34KPVZZIgrr7AZi6KeZA=; b=VLN/ccx6oxov5p4Az+NiQR6DVzX06y5oA6ouiIXTVkpPEzQCXm1i8rHTxq1eN/DR1e 3znDMqxWRD+zWNV3vnUVmP0x94WJsJnVwnRCnvz7Tzc712P7ZRy82eYEWMJ2YDDOlq2A t4jB6wsditdbhO++9eSCxDCn5ZFAvzaC3E9HIQdPYB5RooYUJvrvoEMH5ZrYUfmo9+kn jOJ0fZKLQHkOxGDusDhOPP0O5BunI+nYgkK3y4nr9hQ0cMbnxz9EHPMI95T2vo3If9xa XRaFLHBqXpmXtJigCWz5jFfoiXuHyn9jdrxbJdcwQUL079u1UryLaB4NKuMHTboxgJza Tcew== X-Gm-Message-State: AOAM533gvU/f5WrihC6c2os9ljiYoUYAeebQNCtZxaFcpuHEKTWMFQIi YyziC30TnbJneGl9e82+4OFyAdblAiE= X-Google-Smtp-Source: ABdhPJyDBx8MGsajh2N8dhN8HkgjNiO+zy04k92leLBktFBwL31ExA1tkRhJDISfX6ialHdYh3QUng== X-Received: by 2002:a5d:4b41:: with SMTP id w1mr425998wrs.27.1593102702205; Thu, 25 Jun 2020 09:31:42 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:41 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/10] mfd: si476x-i2c: Add description for si476x_core_fwver_to_revision()'s arg 'func' Date: Thu, 25 Jun 2020 17:31:25 +0100 Message-Id: <20200625163127.4000462-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc syntax is used, but not complete. Descriptions are required for all arguments. Fixes the following W=1 build warning: drivers/mfd/si476x-i2c.c:550: warning: Function parameter or member 'func' not described in 'si476x_core_fwver_to_revision' Cc: Andrey Smirnov Signed-off-by: Lee Jones --- drivers/mfd/si476x-i2c.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c index c8d28b844def8..517d49bcd667b 100644 --- a/drivers/mfd/si476x-i2c.c +++ b/drivers/mfd/si476x-i2c.c @@ -534,6 +534,11 @@ static irqreturn_t si476x_core_interrupt(int irq, void *dev) /** * si476x_firmware_version_to_revision() * @core: Core device structure + * @func: Selects the boot function of the device: + * *_BOOTLOADER - Boot loader + * *_FM_RECEIVER - FM receiver + * *_AM_RECEIVER - AM receiver + * *_WB_RECEIVER - Weatherband receiver * @major: Firmware major number * @minor1: Firmware first minor number * @minor2: Firmware second minor number From patchwork Thu Jun 25 16:31:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625691 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 39A7D138C for ; Thu, 25 Jun 2020 16:34:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 125AD206C3 for ; Thu, 25 Jun 2020 16:34:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lhtrD4yw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WpCqNjvZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 125AD206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ky4k54ottKNsdGPp6gzXhg18I+sY0pO6xrZoCAYkWBA=; b=lhtrD4yw+8xsueF2MaSwfXGqE zUv2XHz7BKHEPr8degfNct1wZYTBylTfPZW6R1O4PdED9SpC9GP/h2XRw5WKQpCdVsrWSxy9dfeHB QlvMn05MjR+eEIbw7nPq5mupFitEU/tRYYjDqSM6ezMiVl2lmICgT2rIhMFDuNotAV/X4pcRdUtaw llEEULoE5m/cihJbGkgX2qaoIKYgLIF00BHoePHzlCzOlbLjP7q+dN3HmsatTG9kIX/8DFVMMx1LG WVM3Y5u8rtdJJKuFS4xqsBINGtTz6OcFGgizn6zYCAnDfKIV0HignGHvKEI6YRXeVsYQxjOJR4qQu P2fzcjntA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUnR-00047o-OJ; Thu, 25 Jun 2020 16:32:17 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmu-0003vW-13 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:45 +0000 Received: by mail-wr1-x444.google.com with SMTP id b6so6478282wrs.11 for ; Thu, 25 Jun 2020 09:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZRm78CKEaQ1OsF7LZfHXu0AnYDnquV1Y/Grx78hG0MU=; b=WpCqNjvZboyLwL4LAn6mI62gQryMJLzOSWZ984JZ9DxikGCM6ZwG/VrO/mL2cwkj5q sAqNL2+ZthviB5F4ZsFMD37DlbspqcJYPyLqlmWVJmU2DOxg7flC92SMyLY2bkOfaefj Vi6bqbTgrkIDd8B4rLiRKkht2kkwTdzoMCIxXAFUYK4wjBbzyZ0Bhli2pME/aLJ2zDly EPrGdNGRbIvpgl6SwxbcAtR9VZsd34wuE0obZ+qv57tTKD0olDztMe8GdX9cZFD+uUhI zTUZe+rfS3eGSLFaOz4KnYn3kkankdGHblzCQAVTL64GgHqcvYo+qmTDW8xbPdHU8v0H O6Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZRm78CKEaQ1OsF7LZfHXu0AnYDnquV1Y/Grx78hG0MU=; b=nhtCq9Jch1+jiCfLllKiKN+8L6DgWYtYlB50vw6rVfnQfWvR3W7BOqcm4CLjEbmeYO o+uRcgScAQyeWyUDqPEqZhILzdPgJPCuuqXoawAQSxFlrfr8E+4f2I/60oi9rNloXVYH K5c92KdAraQRzCbXYMyKyNM6l0RkUNtFOqaUOZ64UtksGhiJz7f7l+14egepNwR6AIpb WyZLnyD9JakmWeOA9z+spucU8mJmWZiaxN+DoUujNB00PKAa9vN493tYRGLhJfDeAE7k RZvgIYWP8WLQ2wNdxAZba8pprlKWfyQYaJ/rn/FlJLFDRnToyrxVxtQ+2FGqFoB1Onm+ iv8w== X-Gm-Message-State: AOAM531UoiFifs2TelLNAfD7vNdsnzHO0xniEgtuYipKf/Dh5Jsg/1ZC /PukbbAPz0q/3Pv0PsCUXS98vg== X-Google-Smtp-Source: ABdhPJwOJGuhySHwz3S5co+7hBssBWVGR6ohtDtbKagEqOEZwvh6/BWn16l+PV4RAtyKx+7qYqduSg== X-Received: by 2002:adf:f388:: with SMTP id m8mr6513876wro.338.1593102703228; Thu, 25 Jun 2020 09:31:43 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:42 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/10] mfd: si476x-i2c: Fix spelling mistake in case() statement's FALLTHROUGH comment Date: Thu, 25 Jun 2020 17:31:26 +0100 Message-Id: <20200625163127.4000462-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 's/FALLTHROUG/FALLTHROUGH' Cc: Andrey Smirnov Signed-off-by: Lee Jones --- drivers/mfd/si476x-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c index 517d49bcd667b..c1d7b845244ed 100644 --- a/drivers/mfd/si476x-i2c.c +++ b/drivers/mfd/si476x-i2c.c @@ -588,7 +588,7 @@ static int si476x_core_fwver_to_revision(struct si476x_core *core, goto unknown_revision; } case SI476X_FUNC_BOOTLOADER: - default: /* FALLTHROUG */ + default: /* FALLTHROUGH */ BUG(); return -1; } From patchwork Thu Jun 25 16:31:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625701 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AEEA4138C for ; Thu, 25 Jun 2020 16:34:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 862FC2081A for ; Thu, 25 Jun 2020 16:34:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aQxdu8yp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ygOQGNld" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 862FC2081A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0UZLVMPCuTam2OmS5Eofb2hkintzOCbS9CUHMED6etE=; b=aQxdu8ypQQV7XRXQDORUOumkL 8l1I4qlGykEPR8w5vLJmzAnjDcp96rKlvTxDy75GxYjS42F9utR6f3j2ANPCB72bnAi/xtxQ0bFHP dfH5ScU8+pIhnjC7yDNbTpRTNfykKFi0GnfzVrord2eyW8u+gozVhT7w7jIWeRF/SGFGH5ZD1Sdpa JK1BOHLhp+74QTGZXkD68nNXzg+n2WUdwzmtZlKUqhZlCZQqvtgI38wEFM5f3TOY9/s9aNj9qLncM aNjthY18Cg+eGizVX8zF+QL1YPsQJ7mWu4GZQTCuG6yysu35sI65yyzTd78yrScnesfEpW74JXXTo Y9I0xYBNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUnc-0004Db-VM; Thu, 25 Jun 2020 16:32:29 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmv-0003vs-CB for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:48 +0000 Received: by mail-wm1-x343.google.com with SMTP id u26so7090999wmn.1 for ; Thu, 25 Jun 2020 09:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y53vRxEwQ50K5Q0PMsRsFAgyQQXwXSqIk0yKzOk+/Yg=; b=ygOQGNldRss3ZrXxaWpr3Kq52jwGWchTxUrLqhRwme27ejGnxmqjUyEo8F+4nxWkCA XKcxpasME/p10DALC6HMosS9zfa9xWOqQzHgCgayfs5qgPqbmoo4H01qdumnqvME1Kno J5C3fSWJhbBTMTSHHHUbxQmBWc/Uq1/gg6d+CHx+q7thEAzAc7+grbNmBIpNTjFvEmvs VxUcBbTnxq6X9/pVcBgtJ6XlbabnIAeujJwvhFSpuqJEYAR6xvthwEubPhjrNf+FEHjZ 274vL/H0EhN37cbYCSfRwaHgSdxGzonJaBwwwB/6x4LXpzjloDtEN2QEXILZ3znXZjNI b/lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y53vRxEwQ50K5Q0PMsRsFAgyQQXwXSqIk0yKzOk+/Yg=; b=EEft+rjZc4vzPuSCCc8uo1DsF7VaZNLeUjU9LwhQT5qnXnYt/rLufMe6KPihc1R/Q4 pD4hmKj+9e5nh5YAVq1eEa3GR+hHmqSUkvhsK/XttP8wsOvhtFJEY9Sf8ged6zGaubZG 58Qmle3hCibxtlORvpQZUrjh2ueJCn84UwG4EKWicsuX+eh+lbg2R4lzCM9fI9GqaHki 2+Xua8gRlTBzvAi4RQvpj/yyd2K1vC1UjxUHbn3abWMJ2CC+QQ/HliY5gnq3xnq8LisL aFel9uS9cJl7VAgo7h6hcxlpNXvUSyUn3gfM0IfJlZFXHl+jta7eOzCKF0qHMrIfyiQ0 dkPw== X-Gm-Message-State: AOAM533aWfyz6w3cqoUn8H12kT4fKVyrDv1Ee/hTpEaZ8U0iqZgww7F6 ySOlXZ1aVp5uTckVuIHHLZB1hw== X-Google-Smtp-Source: ABdhPJxVlcey9CUUrRsBfa+vrJu/ehTYMV9CuIPvXnAb/B4gjmZE8r9aXK80SK7xubjTyX0cSXma/g== X-Received: by 2002:a7b:cf2c:: with SMTP id m12mr4286288wmg.70.1593102704141; Thu, 25 Jun 2020 09:31:44 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:43 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/10] mfd: si476x-cmd: Update si476x_cmd_am_rsq_status()'s kerneldoc Date: Thu, 25 Jun 2020 17:31:27 +0100 Message-Id: <20200625163127.4000462-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 4 of the old arguments were grouped and moved into a struct which is now passed as a pointer instead of the arguments themselves. However, whoever carried out this work forgot to update the function's kerneldoc header. Fixes the following W=1 warnings: drivers/mfd/si476x-cmd.c:746: warning: Function parameter or member 'rsqargs' not described in 'si476x_core_cmd_am_rsq_s drivers/mfd/si476x-cmd.c:746: warning: Excess function parameter 'rsqack' description in 'si476x_core_cmd_am_rsq_status' drivers/mfd/si476x-cmd.c:746: warning: Excess function parameter 'attune' description in 'si476x_core_cmd_am_rsq_status' drivers/mfd/si476x-cmd.c:746: warning: Excess function parameter 'cancel' description in 'si476x_core_cmd_am_rsq_status' drivers/mfd/si476x-cmd.c:746: warning: Excess function parameter 'stcack' description in 'si476x_core_cmd_am_rsq_status' Cc: Andrey Smirnov Signed-off-by: Lee Jones --- drivers/mfd/si476x-cmd.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/si476x-cmd.c b/drivers/mfd/si476x-cmd.c index 5b42dfab431a3..0a40c5cb751db 100644 --- a/drivers/mfd/si476x-cmd.c +++ b/drivers/mfd/si476x-cmd.c @@ -729,12 +729,8 @@ static int si476x_core_cmd_intb_pin_cfg_a20(struct si476x_core *core, * si476x_cmd_am_rsq_status - send 'AM_RSQ_STATUS' command to the * device * @core: - device to send the command to - * @rsqack: - if set command clears RSQINT, SNRINT, SNRLINT, RSSIHINT, - * RSSSILINT, BLENDINT, MULTHINT and MULTLINT - * @attune: - when set the values in the status report are the values - * that were calculated at tune - * @cancel: - abort ongoing seek/tune opertation - * @stcack: - clear the STCINT bin in status register + * @rsqargs: - pointer to a structure containing a group of sub-args + * relevant to sending the RSQ status command * @report: - all signal quality information retured by the command * (if NULL then the output of the command is ignored) *