From patchwork Fri Jun 26 06:57:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627119 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F168B618 for ; Fri, 26 Jun 2020 10:38:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFC0A20775 for ; Fri, 26 Jun 2020 10:38:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cAsIIMxb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a68o20Gm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFC0A20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ahlCQ3w0kAk3S6HFzSFtoNvITgnqYoVdsYlSXjSlI5Y=; b=cAsIIMxbcv3YpdXGLticojgiZ nZ9dT1jwssmK1vPJd2w43Nu9j7JnmZnE/JXlZz3o/fu6IhncdOGNYetEeUijg5/nTQbHo0xwA5tHa eogaEGSXZe9K+NhSN3Mz0GrYEevZUaJVYVnWS4H8Tb/UC8SWdskDe+oVENOasyGBcgEpu+osYxtWu qUC9QcjWV+iobXubFX6v21L/poF05k09UhnyGeFzBYsQIE/W66lf3yc5O6EvluEKPJ90rxdxT1DEr g2D8jvxgTKVeETkLZSh+/ZEHu0htj1A1fVxQtorsMVxSju45Wali0Ylr9c7kur5InVf/t7rz9dyXK pMMrP5Y5Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joli6-0007Na-MU; Fri, 26 Jun 2020 10:35:54 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolhT-00077N-61 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:35:22 +0000 Received: by mail-lj1-x241.google.com with SMTP id n23so9798858ljh.7 for ; Fri, 26 Jun 2020 03:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/E1PdVn/9jzzc34D3D+WNExjRWlGVi1N3dWKjpxsWKE=; b=a68o20Gmmh0AyVgl/PpKk+tsY9DfLFWxKbSXt+qf+QeHv9ryx9N2GLgLxgdpcME+oz n5CBJu8CJXJt6rWJBLxQ5rt2eGIOlPfgo+mLNsgXG9GfZLRbjdBgOz6oGuH++cBqasbF je/seh5XPcrMsHgXv1ANElfefrnnY6nPilIuMB4Tjk0++4C0Dwf2iBnNTr9pvI2DtdNv FYKKhpUxGrDfAOjuIkTfWcgJRArbRgC5fugLbAEwoDNWN1bCvH6cdkWnopB4uEyTKcR0 /osZUZ2sKKtLEVnIU4he/yg07D0715OWbL2KosASZvI/k/lGiD5JTUi7q6XmeV4ft1kH HQNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/E1PdVn/9jzzc34D3D+WNExjRWlGVi1N3dWKjpxsWKE=; b=j09+YYiceusK9g2wSIcrebE86RRncr9+gb2FAGiagRy0w/EOLFvYk2FpfZs5+ViSlD MBT5mH+lQNpgN0Rxn6vCPl+BTQAXmnbC30TsKqdBAyFUAktWF2iGvyAK74Kh0NWKLJ/t Ulmku2OVWiWjNeXSXi84qZqWZFwZcOI39HMedhDfTLm5MOMACCgsWYqlFGCl2UkwQccH U6rioOY3kijxwIkBNw7yLBs2H+WncHE79Ep/OkRS/XeH4b5yas1Yroczw1una/5EaULb O71R+LOjJugO7UOa5196zntdIe2ZsBpfwO53p1lpJQNBbWvuDXyQlCgumwt36UqrH22m Lo7w== X-Gm-Message-State: AOAM531hAM7ne7vMBAlaUMmAIfdQ4viRLArD/KrH4EO1pJjKBUtyhoXU Wicqs0WvyrM0z5jfrcuZUrINRKige4I= X-Google-Smtp-Source: ABdhPJzlrUVwS/s+z+kPaLN7mMZ6TH290vDO8qERoSmz8o7Sm04wV5mFHDvFboop/xRMB+UYBri1Yw== X-Received: by 2002:adf:f504:: with SMTP id q4mr2075095wro.163.1593154663208; Thu, 25 Jun 2020 23:57:43 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:42 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Subject: [PATCH 1/9] regulator: max8998: Staticify internal function max8998_get_current_limit() Date: Fri, 26 Jun 2020 07:57:30 +0100 Message-Id: <20200626065738.93412-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:241 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kyungmin Park , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org max8998_get_current_limit() is only used via the .get_current_limit, so it doesn't need to be publicly supported, or to have its own external prototype. Instead, we'll make it static. Fixes the following W=1 warning: drivers/regulator/max8998.c:418:5: warning: no previous prototype for ‘max8998_get_current_limit’ [-Wmissing-prototypes] 418 | int max8998_get_current_limit(struct regulator_dev *rdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Kyungmin Park Cc: Marek Szyprowski Signed-off-by: Lee Jones --- drivers/regulator/max8998.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c index 340413bba0c5f..ac69bdd398cb3 100644 --- a/drivers/regulator/max8998.c +++ b/drivers/regulator/max8998.c @@ -415,7 +415,7 @@ static int max8998_set_current_limit(struct regulator_dev *rdev, sel, rdev->desc->csel_mask); } -int max8998_get_current_limit(struct regulator_dev *rdev) +static int max8998_get_current_limit(struct regulator_dev *rdev) { struct max8998_data *max8998 = rdev_get_drvdata(rdev); struct i2c_client *i2c = max8998->iodev->i2c; From patchwork Fri Jun 26 06:57:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627189 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D10D90 for ; Fri, 26 Jun 2020 11:12:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DC1120724 for ; Fri, 26 Jun 2020 11:12:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jNKHnPBk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cU3REmEx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DC1120724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eG0IMLbymOqxzjru7RopD36fj3IuahTVPefIZLJqPrI=; b=jNKHnPBkzJn2kEX4X66qYaule u1s48483CGl1qC46Id7Dt7WeEIYf8UrpEkqLCkVj/s5qeb9jFownuYvTwgXmT23dBSQLexR+0Y+/V pXVOu2AJV9YefHzgaj8R9x6EixYhiO4H5GssLLQ1QfUVzxsI/EGCc5PakHs1ZfqE4OR4YC3Dm6CVv HTD9DmHbCnBKECO8u5PT1nJR1Yr9SkreXk3JdYx63AIK3G1DU0wPDlfqcF5Av1643fURTDM5PnF1Y eNHAU5j7MMe6s8jzMrx//Bme8IcRhnkZiWz0Fd5yaHt0LgF8cNhT73ahHXKfXT4YY3E8BOznJjvqn fP/8JY2kw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomFZ-0004R3-Ql; Fri, 26 Jun 2020 11:10:30 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomCI-0002xY-Mi for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 11:07:15 +0000 Received: by mail-ej1-x642.google.com with SMTP id w16so8964581ejj.5 for ; Fri, 26 Jun 2020 04:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EQdtlCq0FayiIxw9Rs+gOrZ/5VZqnIsgjAQgaobsp4s=; b=cU3REmExdXZnTF1HXY2PtQ30RmVx7lx6+g3J32TSut/xk7G7p7XuOcEJLmRCbZ1oAr yxV9KPJUZZxSbh1LCZe2jrxDJ+MPWPlh0BioUJLmX/EUALUyyccsVlG1MH1dkpOLRMbg F1qIyO8QOKmF/5DVafM5L6c29Kmb/zbFn7/mZAHvQwjiHO04zXvrQrvjofjw6jUuyN1n mP/+VZDB0onc+Z+oo783ZaFEVi8BQHwkpLhTxi8/2m/2B8ctw2r2H/OwnpQMJBAjCEAO SGmQdBYITEgfwziCb87ej+7xh0NjA/L6OCgXbTy+b95YSxVc84h4L5vpK1eAZH5R/Qp9 gajw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EQdtlCq0FayiIxw9Rs+gOrZ/5VZqnIsgjAQgaobsp4s=; b=V25XD0vcIEFFLCehBlslzaYoS1MB3d+/zjyJIdL00YuWwEfFD2qhjvYtwT9s7IezrF aDd0LHTAPlusWbtB5WVrcFHsEcbwljYzjFOhI+WEOcy99QUPCv2RN3+Fbd2Xln9CeDsG SbSmC/I1fSytBf9JC8402MZ0D6ekMf18YxHrpFDPOB9LCM5u0DyyWogfT4uPOrd+sFuO ithY6uu2kvwAi7++5QKzqjFwpINUE4irGnt3OslF82j+btizOHQvCbyBpZoEH7lWfbAY WU7m60TKMWDi72mMB9HcKoPs386N7zYWNWSYeoQCXJSmM85CsUl7ilXCXf3q3dO3laRd 9CHw== X-Gm-Message-State: AOAM531nEDED3bV8fSyXTEWRDTppTX7TyQtxRPc1MI9WSbmFb8CapUgU eyutv4DRbaBt1UqBiXCjoJuOFNGBNs4= X-Google-Smtp-Source: ABdhPJwZ+URFbBBN0AhuwE/y6WRRpqaFyX55X7XIOPgwaR11LJdWPX+JuV9C2QRf7yGvIuLUOuZ4Yg== X-Received: by 2002:adf:fa81:: with SMTP id h1mr2187942wrr.288.1593154664379; Thu, 25 Jun 2020 23:57:44 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:43 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Subject: [PATCH 2/9] regulator: qcom-rpmh-regulator: Repair dodgy kerneldoc header formatting Date: Fri, 26 Jun 2020 07:57:31 +0100 Message-Id: <20200626065738.93412-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:642 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Andy Gross , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org W=1 kernel builds report a lack of descriptions for various enum properties and function arguments. In reality they are documented, but the formatting was not as expected '@.*:'. Instead, some weird arg identifiers were used or none at all. This change fixes the following warnings: drivers/regulator/qcom-rpmh-regulator.c:33: warning: Enum value 'VRM' not described in enum 'rpmh_regulator_type' drivers/regulator/qcom-rpmh-regulator.c:33: warning: Enum value 'XOB' not described in enum 'rpmh_regulator_type' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'vreg' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'dev' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'node' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'pmic_id' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'pmic_rpmh_data' not described in 'rpmh_regulator_init_vreg' Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson --- drivers/regulator/qcom-rpmh-regulator.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c index 79bdc129cb504..08dcc614efa7f 100644 --- a/drivers/regulator/qcom-rpmh-regulator.c +++ b/drivers/regulator/qcom-rpmh-regulator.c @@ -22,9 +22,9 @@ /** * enum rpmh_regulator_type - supported RPMh accelerator types - * %VRM: RPMh VRM accelerator which supports voting on enable, voltage, + * @VRM: RPMh VRM accelerator which supports voting on enable, voltage, * and mode of LDO, SMPS, and BOB type PMIC regulators. - * %XOB: RPMh XOB accelerator which supports voting on the enable state + * @XOB: RPMh XOB accelerator which supports voting on the enable state * of PMIC regulators. */ enum rpmh_regulator_type { @@ -399,13 +399,13 @@ static const struct regulator_ops rpmh_regulator_xob_ops = { /** * rpmh_regulator_init_vreg() - initialize all attributes of an rpmh-regulator - * vreg: Pointer to the individual rpmh-regulator resource - * dev: Pointer to the top level rpmh-regulator PMIC device - * node: Pointer to the individual rpmh-regulator resource + * @vreg: Pointer to the individual rpmh-regulator resource + * @dev: Pointer to the top level rpmh-regulator PMIC device + * @node: Pointer to the individual rpmh-regulator resource * device node - * pmic_id: String used to identify the top level rpmh-regulator + * @pmic_id: String used to identify the top level rpmh-regulator * PMIC device on the board - * pmic_rpmh_data: Pointer to a null-terminated array of rpmh-regulator + * @pmic_rpmh_data: Pointer to a null-terminated array of rpmh-regulator * resources defined for the top level PMIC device * * Return: 0 on success, errno on failure From patchwork Fri Jun 26 06:57:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627125 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3FA8C1392 for ; Fri, 26 Jun 2020 10:39:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11F2720775 for ; Fri, 26 Jun 2020 10:39:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Bgm2dkTH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yzt02VDu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11F2720775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nifLy4RblZpiRl/RJFMy/9Tc0k6XnaNpb3MhgB/IaJY=; b=Bgm2dkTH+8r12HDkfaL/65f9v xVdYRWciGtBcpnAd2T657lfpcr8Jc+rb/OG/JWz39hIGNl8OVnq+Qx8uTAqbBqxzZGxJkxistLOzD J7pptJq8FAgfCOGNJlySbRCQ4dW+9isc7snIgWx2VoSw2wYSlNBW7HvQ6KUZjqmZluwnBcnolS5Ey CkrNA/xayX7kvpOdKHgt/mzIqkxNwzL+hpiAHS7QO2pzGOG4h/8Qz3hdpKI8d72le6yqODjY/5Eko /+hRK9BwxcnTcyn0MCuQMZyELBbEKcO8MUbxYxQyQIRQTSFk3zQnsT2572Dn2ZOq0eM/4aB6Ia+oF jqLnhIstw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joljL-0007yK-Pq; Fri, 26 Jun 2020 10:37:11 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolig-0007gf-R0 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:36:32 +0000 Received: by mail-lj1-x244.google.com with SMTP id n23so9802549ljh.7 for ; Fri, 26 Jun 2020 03:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V/fY+SKO1Jj5D5YQYaGnVvTrQu75adS3mRb5y+EqAwo=; b=yzt02VDu0CzSC/QEDj7E7YM9X1XLw0ISddmZdLk9sScfqkbGp0Xq+20XMr1gslxJS6 KHFEQG7qy01LuqwWZJr/r+RaQLZDRUFEcVK6uXQzJALuIp1aqt5UN7hJi5Qe7D8QfwvG AWZ5I6QeKJWM0ax4C1xMPqrw/6cxvpQej9vui13gMOGceQIt3sjLY79AO9x4lfGSBxLD LmETWiL9qaPWmANArrjT1QP6tTgDn6+WtzVetfkCVf/otoyvfRf1A/EER61/b+dqIAbG oEen04QTx5EwVGOpsdzhKozLB8ueIJWYYwmXAW1IUiIAuxUVBNlaKjzhbQ20Np54ti8e LS9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V/fY+SKO1Jj5D5YQYaGnVvTrQu75adS3mRb5y+EqAwo=; b=tvB6LhpN9j92MBEpv+fdG0Rqm49k61P59tG8TgAQOma12qr2aLwu1Ge2oagDmSOuHz Us8oDw1HxbL8JHj+YN2p2QBSP8AoG3zMn+tw/g2o87P2ZxXldv1TXgOiDHKFASDZtuB6 gOjs6Wak+LlgEhQ0IRNhhz5HGPB+ytwqXrnY+7ksCV7Tez97p+yuadovhcFV8w1XTZDN +yDDXGi2qbjquX9UhS8NPGULCUEREY8BMYxGDfPfEduJo2lGTmGVp68vl5cgi9kkmKWw fcqnNaWfF0M1p/puvudIckYC3uTcYKGSW1jgqJtbHwh5LH56/G/DY/IdBjdF9s4cNlG7 ElAQ== X-Gm-Message-State: AOAM5321am3xJHYCCohrPpgnFYrWUVHpSN2xkR+IsSMBeKOBlm+f0qAx 2DmDrFJKR9W6S3/ihziJedJ3hioenEc= X-Google-Smtp-Source: ABdhPJwCkkYYaOhccmFsNz/Yhg7coOjKTR+t9o30rYzg3GOOoRKpB9DeJhL5Nc6h+vNDcVxJOLd7Lw== X-Received: by 2002:a5d:68c7:: with SMTP id p7mr2245534wrw.16.1593154665319; Thu, 25 Jun 2020 23:57:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:44 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Subject: [PATCH 3/9] regulator: pwm-regulator: Demote kerneldoc header to standard comment Date: Fri, 26 Jun 2020 07:57:32 +0100 Message-Id: <20200626065738.93412-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This particular comment doesn't have anything to do with documenting functions or data structures. Instead it is used as a section header. Fixes W=1 warning: drivers/regulator/pwm-regulator.c:55: warning: Function parameter or member 'rdev' not described in 'pwm_regulator_init_state' Signed-off-by: Lee Jones --- drivers/regulator/pwm-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c index 638329bd0745e..3234b118b53ea 100644 --- a/drivers/regulator/pwm-regulator.c +++ b/drivers/regulator/pwm-regulator.c @@ -48,7 +48,7 @@ struct pwm_voltages { unsigned int dutycycle; }; -/** +/* * Voltage table call-backs */ static void pwm_regulator_init_state(struct regulator_dev *rdev) From patchwork Fri Jun 26 06:57:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627035 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D9256C1 for ; Fri, 26 Jun 2020 10:09:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41821206C0 for ; Fri, 26 Jun 2020 10:09:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nlwih2VJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iSjtc1BZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oMN+5SES" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41821206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g1bN4omL93gi+KA4OYivC1oTPJaf8YGbqWrCKvxkThM=; b=nlwih2VJamonVj8FjwyiIMKP5 RZ9oTwqA9+7SsgQ+EWZ8Bv6nrudz4jbdN4M4jF/tqF9QgC6XN5GOQR1fcbuuJqfal+5S4OGhP2l20 1d4c6zFbDpzCDVj7i0/gZDxjCaxGHoHmGTwzLZcFXnUDpGmPHH57RnZkbA1ni3q1FR88a5h1l57Bo XN5Qx1WR/FrMM/SP3VBl6P329nc1AyXMTi4UFHAr0pMZNkBEa0tzzs0Ar2vozVl24ijlj+smdsEgT vWNkZsiY4FdMUvGghff2ttojFUTyv63tF2E2iIXpmg3eJ9bNze5eC8KWj0VOS7kFWWMGRcQH8AsGv jpH940VSA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolGn-0002AY-Qn; Fri, 26 Jun 2020 10:07:42 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolDV-0000bm-7Y for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:04:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=y9hN7NO0rdQRJARX8qa7eYKYz3O3kVESkS3PoJ7SKiY=; b=iSjtc1BZgTKdqbfVuMrzS0dcif JJG0G3MwQ67+0Cb/zNqE3oo9gWM4/mKXVdVaBwYS6d+Q0mw5dWJ4qhxl6NCyNQvXEygOyLSEaWAeA /2AYfRc48dD5kSoPXBBuMfG2kZiMbUchnKdK6SKX1qqKtOXmLqrpwxZ/5g1bsqmDPDCE7t2GtVcSY f1eE1igtqGc3+l9vT2BYj6x8PAwtVqWf41b5N0Kxyl0yNyJlN0X6Wflmn8ayb04EZ9Uip18vX4zAY MF8qgp4ckwK0fp4zDoeBAslNfmJGygI7TQM1WaMUr4YCvlAYN0o0X3cPw5W50Yj1OE/w+Su1d3OXm ajlwc22g==; Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolBW-0003uN-3i for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:02:30 +0000 Received: by mail-ej1-x641.google.com with SMTP id i14so8774846ejr.9 for ; Fri, 26 Jun 2020 03:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y9hN7NO0rdQRJARX8qa7eYKYz3O3kVESkS3PoJ7SKiY=; b=oMN+5SESRViJGi4oMdoYffiAIfTV0HTw712Nu4lIwJpvz3ph6VHskhTuPqAub7zRL1 BAHisNhPGZdpQe+zfCmznmkwfxUPe7KErp4/mTy+EGkED1oAvKKb4P7Yilw1CkWtsmr4 pyanrIHcJ/dwK+IBBHBKGdCgFPOr46YkenbRq+nAdBC74VVOJINtEEVCGRI9yNxx4WDy Ubr1PSc7g8MlWhEYIkfNBKICDjb7tVLvgQDVz57Vs6VvhNJ1nojyIXvKv2ZbAa2wu1Bu L+p17Rtqd4X1tEwjktgKojLmmbeKxn21eBdfeZensHH0xSrtfQdEQ4C4aKJ8NavBdcji hAHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y9hN7NO0rdQRJARX8qa7eYKYz3O3kVESkS3PoJ7SKiY=; b=lvGzhNMnegAvnkiUmiP+FvN5mAO7sB89Uvs3Z4oE4w6/5GQG2F6Jm12ObSzmXPkr4R VpLaFZEWQQaizw7zOTv344MrlP8ixVRo+DUGe1p8Sh+eqB0MFs4Wm7LU21B9GlYXhVy9 NEJuy7SFE6+i8bTYpIoINVTHcTVjVlOdUb9PatzsZpYImI0LiJc2gYxulpG1iOyl4nGj eKTzdP9YNddpjW6L8VwkGpvBXxELOIzY9YMjYOFTWnMc8KKXsmSbrS5yqHGCGNlBsVdx 04UOEO630j2kSsZjRIDA5biHL9SPWBDOfdHhfrTIGSQjZ8Oh1l3FWfndRcLjlVCj/jtJ EXog== X-Gm-Message-State: AOAM531ZjcDHp5XfTuOWjQBphMYym84JUA3GN/noIqilcqGzm8OsL7Fv cFkjUhLJc9/nzSUwJRV8YEhC/H/OsxU= X-Google-Smtp-Source: ABdhPJzCrrAiKXmS/P3/z8bW+Zozzihsle1ZeNtAdmBePwrKgRx2OeGMoZCsXgJ2BWVeEnC+h/bs6A== X-Received: by 2002:adf:828b:: with SMTP id 11mr2309054wrc.58.1593154666455; Thu, 25 Jun 2020 23:57:46 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:45 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Subject: [PATCH 4/9] regulator: stpmic1_regulator: Properly document 'struct stpmic1_regulator_cfg' Date: Fri, 26 Jun 2020 07:57:33 +0100 Message-Id: <20200626065738.93412-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_110214_659908_64B9BFF0 X-CRM114-Status: GOOD ( 12.44 ) X-Spam-Score: -2.1 (--) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:641 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pascal Paillet , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org In kerneldoc format, data structures have to start with 'struct' else the kerneldoc tooling/parsers/validators get confused. Fixes the following W=1 kernel build warning: drivers/regulator/stpmic1_regulator.c:25: warning: cannot understand function prototype: 'struct stpmic1_regulator_cfg ' Cc: Pascal Paillet Signed-off-by: Lee Jones --- drivers/regulator/stpmic1_regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/stpmic1_regulator.c b/drivers/regulator/stpmic1_regulator.c index adc9973d1b2f7..73e0ab2baeaa6 100644 --- a/drivers/regulator/stpmic1_regulator.c +++ b/drivers/regulator/stpmic1_regulator.c @@ -15,7 +15,7 @@ #include /** - * stpmic1 regulator description: this structure is used as driver data + * struct stpmic1 regulator description: this structure is used as driver data * @desc: regulator framework description * @mask_reset_reg: mask reset register address * @mask_reset_mask: mask rank and mask reset register mask From patchwork Fri Jun 26 06:57:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627187 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 506CB6C1 for ; Fri, 26 Jun 2020 11:11:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2085620724 for ; Fri, 26 Jun 2020 11:11:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xGl3zbJA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V+f/N1sh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2085620724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KNM45Tu1NxsJBFhiTydOY7fBUY9faMzIa+3v5HdbAOc=; b=xGl3zbJAG4nPjGYKHAuvMjf13 PRiLxqQGeC6CtL7Aa8GwySGO/eFxvloG/M9cJqPlYZbHVkT4NkxNi/JUKFr+TfuZZF9hfIo97qK7f +C+9RQslonl8is6XnG9FboiX205BQYETC8TtNmX3ddpJHlLuwdubB3s0iJp+NGPnHoW0quzKWn4N2 xBXDR3nRrhg2pLpjVz5NADZFsXv9hWzNG9kITuLCBFayFAHYu0apDMjflW4fRL1kOYLsx+fNfCRf3 ibP78qCwO1S4ejNAZiVCayI8Edp4FupaU1waPK237DRVdTjbyENX74GAErjzuDB8seNHwZKvPckIJ G/LOujToQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomDo-0003c1-9o; Fri, 26 Jun 2020 11:08:40 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jol6s-0006DM-BC for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 09:57:37 +0000 Received: by mail-lj1-x241.google.com with SMTP id s9so9642432ljm.11 for ; Fri, 26 Jun 2020 02:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7sD07a6En2jWPWH2kq8TUsn+RVkOBsvIFsWTqmBLW7Y=; b=V+f/N1sh9o182ePat9lbQamPC/xUQtqafZxm5ypirNrQKbDKBqQ4bjIcONYNaxl3bT SOVYt7m9hF2UYTxbT6EE1TVluOIxfDnbWgmea430ebNS8wCS8vBhHomJYiPwr3dEw7nC BEfJ83GZIJxiNxsokwodTwezX9wpLi5ZXnRjQ9jRvzdWxNoh+R56OGC3sRqBw2Mznu3Y HRU8Tb95/BKVOjFpbvDZbTd2016NZeX+SU7QjLc8cZed6J4jfxNf8yNYRNAiphrQYfo+ +5Vhrl7fj0n00G1l4XVsH0+wvvgUzFYgutMbkcK/ayG549z0zXCUKOd4GUhIXV2+r/vu vlyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7sD07a6En2jWPWH2kq8TUsn+RVkOBsvIFsWTqmBLW7Y=; b=ClqbI/Z3paNa2eC6mt8usxOXL8jIXAylrjDdvCn3m24Zac9S0H+l3/v9C1rgv4GgyJ cKCilh1sa73ioLMSRrdU6ciHcxkht6xwoIeaYgfj7JU4SxK+3An6p+tP2QyCj2rkBe7S OHGRrQwur9FtxcKo4FGPUEEqj6nirlTcOILc/3IWZWj3xcbGoTOMZ0Yu4zZwzrM0dLTr PtL69+dqoDplQeMQFVCpV2rxg79a4NowGwVhGRjotA0JUhy9l55em4PxGSdOBQakjQkU CjfdHGp/wKqWEEKHmgI7KocKCrpGUxsiQv7DAJZsiCSbEGVjhnfPoYTL1JiSWaL2csYw JxzA== X-Gm-Message-State: AOAM531j41xCMTfbPyCBL7KJTBMDtpzs3DQUM5H0f6yrPz5dJElI/9Em Y2T2qvSyhxDxTXGs3EZDkusvj9Roi50= X-Google-Smtp-Source: ABdhPJxS9JeaA9nugKhk00ilscAGO+mjKuClzKn+M1SFU8Zww2GY/t5YayskghAfrWlTh0txvkRTVw== X-Received: by 2002:adf:f546:: with SMTP id j6mr2063748wrp.167.1593154667581; Thu, 25 Jun 2020 23:57:47 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:47 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Subject: [PATCH 5/9] regulator: tps65217-regulator: Remove pointless 'is unsigned int <0' check Date: Fri, 26 Jun 2020 07:57:34 +0100 Message-Id: <20200626065738.93412-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:241 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keerthy , linux-kernel@vger.kernel.org, Russ Dill , AnilKumar Ch , linux-omap@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'rid' is declared as unsigned int, so there is little point checking for <0. Removing these checks fixes the following W=1 warnings: drivers/regulator/tps65217-regulator.c: In function ‘tps65217_pmic_set_suspend_enable’: drivers/regulator/tps65217-regulator.c:127:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 127 | if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4) | ^ drivers/regulator/tps65217-regulator.c: In function ‘tps65217_pmic_set_suspend_disable’: drivers/regulator/tps65217-regulator.c:140:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 140 | if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4) | ^ Cc: Russ Dill Cc: Keerthy Cc: AnilKumar Ch Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/regulator/tps65217-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c index d27dbbafcf721..f2d3a4a9f3e77 100644 --- a/drivers/regulator/tps65217-regulator.c +++ b/drivers/regulator/tps65217-regulator.c @@ -124,7 +124,7 @@ static int tps65217_pmic_set_suspend_enable(struct regulator_dev *dev) struct tps65217 *tps = rdev_get_drvdata(dev); unsigned int rid = rdev_get_id(dev); - if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4) + if (rid > TPS65217_LDO_4) return -EINVAL; return tps65217_clear_bits(tps, dev->desc->bypass_reg, @@ -137,7 +137,7 @@ static int tps65217_pmic_set_suspend_disable(struct regulator_dev *dev) struct tps65217 *tps = rdev_get_drvdata(dev); unsigned int rid = rdev_get_id(dev); - if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4) + if (rid > TPS65217_LDO_4) return -EINVAL; if (!tps->strobes[rid]) From patchwork Fri Jun 26 06:57:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627239 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F38D913 for ; Fri, 26 Jun 2020 11:26:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 269A820724 for ; Fri, 26 Jun 2020 11:26:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nYkASjhv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FpuTFE6Q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SKp3jqiW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 269A820724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SMXuIHAwBkDvnhs+ci1pLCmoH/VldF1rkpBmG7T/mjk=; b=nYkASjhv6bCiioNYhyn8MSN9X 7SaHLzdLI/m7/P+UsoXd2cKL7T7x2jkk+rLGNBLYamij0t18FAbIEJZwPQpwmvl8F7LJfB/xrAGV+ HwPoV9B0QFjEGnweDQjouiGbMbxwekUqR29/t4hpQNV+Ac5DwoX7QOB0osjq9Ij+ufc40u+uNQvQR VQmgwVOiAFTfZwjRx09RW63hikoMsLYQ+UeGkRskuD3UolP4a5ujKeruLNoJosCQEvbZhOmDfmNzR fJ5hLMOzKlK/2Cj0HwEhpgAnjYGDdl3ISTszUwec5Jk9zpM1Vy5gBQFLKLZxJmk0c6xmkYW7ALmG/ DEKy6dTfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomTR-0001gO-Bk; Fri, 26 Jun 2020 11:24:49 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolEf-0000YK-Mi for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:05:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=Vqpawo5MJsJOmOd5oGBoADQ9AShkAYfWIevIqG7XtBk=; b=FpuTFE6QlQaENPGbvpZGUej0qx 35JDbc66tx6aZNOEr/3rSE0tumN6/i0DxDq5V3N9OzDITHcnLSLBQ1QKLER7YrNJ/45fNPHaaCiYN dUGCotWIptUkQ6aqymsLXuDLqvOFCpUTDxgKjYEJvJZjZnpJhqL5sAhYM7Eawp7mwLNfgaF/fmPOL NegxhBLuZMjmau2D3nQXlQZw9dO3Zk3/PaPLkKdVelxA1yZeW/vjC5TWibLHv7rSJ4URXAKWU6O4F lD+lG1w7MwWJoeAX+xJ6C1cOB7Xgau7OvGmHsfA8jsRDM+Z1SOqQP8qV55E6VFdFkgzjWb9lMA6MW 2CW07Kwg==; Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jokxi-0006ZB-Qt for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 09:48:22 +0000 Received: by mail-lj1-x242.google.com with SMTP id s1so9677026ljo.0 for ; Fri, 26 Jun 2020 02:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vqpawo5MJsJOmOd5oGBoADQ9AShkAYfWIevIqG7XtBk=; b=SKp3jqiWYrIXN0jB0OY408JIuyw4za4+UhL8h4rqgsIDHOoRrIpyJa6mqRtdVOps/0 mgEnzvPXKOyVwiok9xc3e/aGae/TCe+lyKlYblCgxaVLB7fMbQtnu11Fo+LZk4h2UfVY 8P1sCwqocGnNgb/S8jhEd6RpJSjY68unkDdCp+pHLc9YZnYIj1UgvuxvRk19OyaAut+a LmXMXl6hD2/rB7lZdVRXsKPxUxXp+btTwbd/amNtSAhDR5xvBKGtFOiZlDYFOrCx0d27 8kN6CjSFPWag25rf6VgKqLU1xAHYvr3vl9ay5I0DYXrHesL43//ThifVueOcz0HuZEjY gVIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Vqpawo5MJsJOmOd5oGBoADQ9AShkAYfWIevIqG7XtBk=; b=t5Ug+dodNJEhjvk0sSeDaoSdWxVuXxCHJROcCxagexDgwAomxkeWK/qg5Xaw/G6qCb KvAqE31PdScQLFNY4kuxqiw5mXwkI4d+/LRMoq7WtDPkcwY5KzBtor8SWVn49JAtktY+ SWFEFX/F/hKdvSAezk6fEh4mww9XiltKWYP2nvg8QmlkHEsr7du80oXHiyI9fXaDP4JK r8mUBK8tDvTEwIGCb4Ikny6SHInnkxg+RRN32XUzk8lTBYbo5FH3Vyh4pVF6OhHz6SsX LbWkscZ9kpQQ0EHCfaLEcLM1vcLPOQVBLdZE9scXaKsoETEQOMA0NWgAZGy5kZafeT1q 7ZRA== X-Gm-Message-State: AOAM530Z21mYbNC07DtKe5UUoTXk3SLT9tak7UrgI3el6mv9o60TB5cx B3BqCkZn86LsxtMjEIyWmTIRCX8lGPg= X-Google-Smtp-Source: ABdhPJzUZcx9JMvk0I42jptf4iOIhyswi9h4IvKidFSgFgUMg8zyNP/ZGhoR0T7CSf8Q1Xinyvy5Tw== X-Received: by 2002:adf:9307:: with SMTP id 7mr2062805wro.414.1593154668628; Thu, 25 Jun 2020 23:57:48 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:48 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Subject: [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read() Date: Fri, 26 Jun 2020 07:57:35 +0100 Message-Id: <20200626065738.93412-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_104759_394004_FBE9F884 X-CRM114-Status: GOOD ( 13.93 ) X-Spam-Score: -2.1 (--) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:242 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keerthy , linux-kernel@vger.kernel.org, Russ Dill , AnilKumar Ch , linux-omap@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Until now the aforementioned return value has been ignored. Previous and current calls to tps65217_reg_read() return instantly when the value is not 0, so let's do that. Fixes the following W=1 warning: drivers/regulator/tps65217-regulator.c: In function ‘tps65217_regulator_probe’: drivers/regulator/tps65217-regulator.c:227:9: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 227 | int i, ret; | ^~~ Cc: Russ Dill Cc: Keerthy Cc: AnilKumar Ch Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/regulator/tps65217-regulator.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c index f2d3a4a9f3e77..3f5ea029e2e3f 100644 --- a/drivers/regulator/tps65217-regulator.c +++ b/drivers/regulator/tps65217-regulator.c @@ -254,6 +254,9 @@ static int tps65217_regulator_probe(struct platform_device *pdev) /* Store default strobe info */ ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val); + if (ret) + return ret; + tps->strobes[i] = val & regulators[i].bypass_mask; } From patchwork Fri Jun 26 06:57:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627123 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A4D431392 for ; Fri, 26 Jun 2020 10:39:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CE4E20775 for ; Fri, 26 Jun 2020 10:39:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dhpw5M3s"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vfi1pBqW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CE4E20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ms/V5Bq7XX2Nkotu8fVNeliOdiIqVyJL1tICvf9OilA=; b=dhpw5M3spiq8VfF4qe1ZdttE7 DG+/sIK576BMsSIFW+o8QBhz13xvD7OfjvGI6kwqvozSRhXK/QrXcNbmnrQfGH2a+oC04KIe5k1Ul RXoNv+8GpX6TSYEKvN19bq7FWq5w2XdWHl4xu9Mtx9vWQpw+bvBOky5AKQHEVZqlqgKgF2JyjTXCP isiaYg8RIrQ3GD/SDfX1DQPgqWgyhjonyKdesj1YtSd0HwsxRiNZbm9mU7nfmRPqpkuYnNA24UoYN qq0dC8WU3GkwetbUzG7ABQ6dMQG3SctgzWA8dkImDoFZdzCik0IPevm+mJoW6BqKCCqdANW76u1On wKrNJP2ZQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolj1-0007rx-Lc; Fri, 26 Jun 2020 10:36:51 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolid-0007fG-9d for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:36:32 +0000 Received: by mail-wm1-x344.google.com with SMTP id u26so8603192wmn.1 for ; Fri, 26 Jun 2020 03:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LxP+pj5dAfq9jSQlmqxGkL2BQjDUMxM20D8uW61hd/0=; b=Vfi1pBqWKvy+Zc8b6ok7wbVccd/dzbvbdRZeJ5pR8nYf1oFkBEn+32PfanZ68mKmr4 X7Tz4VRmpdTJNEbXUjgt/SMOKgRA7SoYdp1+rdmzItdFaoND9odQiqI4x7PWlymMow7j 47xl3ZNui7jVUD3/NPVzpvi3EVWYilYP2Jzrcr63XY4eDP1liqeFJQyXGPgziN12Wj82 b/Wl7AaVTxk1N7JZssKKbllkIfoVOUuPtnnjpdNEOVIDFnW/8NycoeMynve7OiuLkyFm MSiuq21fBdUJwWGnr52ypxku7WTHmFnVpZf+bceWW8T7hjkb7IxLrE+km3hzsv6Wnq9y QqIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LxP+pj5dAfq9jSQlmqxGkL2BQjDUMxM20D8uW61hd/0=; b=NIHexWLHn/YMXMSIsz/uFmzkl6WcIZukfNKL7A+UogX62YbVywMYyzi1v2yo9PMqQ1 F30s5OdQcRlyBOvZvpKRxiEak3grFYiQBOflauaBe53HV96q4ug66AiZhMqKhwFkiEMo W81ku4j7Nrm8DnOCOPikS5WxBTNfVwF1Xy+dXrNszzHLyAcs5uFMJb9eyk3LigyICFjQ veBoEPFg6ulzz8zGeH5+LmDNRh+VW18ih1yE7pVto15A3QUn0RuuAKTSoAsIHhdZUdPX KhlmK/fmP1q2Jdg6cosPoSc/X6Nlty6/pIHeZDqi9D5qJB0n09ayeBMlqFsgb7KwJm6U c3Mg== X-Gm-Message-State: AOAM530IPkrdydHWSOia3Tus8C1KSk7hJw8p/dfIAUAmcW90kwR9Xk4k Tcfvm7xlun+uTF67kn3u/2iIsraScoI= X-Google-Smtp-Source: ABdhPJw73SIBNHcTFiMa5r63xLyQriFo1/WVEXa9xIrz7jwg0GpR9c0vG5B4g091gEXs8yriVT/9Og== X-Received: by 2002:a1c:4185:: with SMTP id o127mr1808366wma.8.1593154669736; Thu, 25 Jun 2020 23:57:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:49 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Subject: [PATCH 7/9] regulator: tps65218-regulator: Remove pointless 'is unsigned int <0' check Date: Fri, 26 Jun 2020 07:57:36 +0100 Message-Id: <20200626065738.93412-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Gerlach , Keerthy , linux-kernel@vger.kernel.org, Tero Kristo , linux-omap@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'rid' is declared as unsigned int, so there is little point checking for <0. Removing these checks fixes the following W=1 warnings: drivers/regulator/tps65218-regulator.c: In function ‘tps65218_pmic_set_suspend_enable’: drivers/regulator/tps65218-regulator.c:131:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 131 | if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1) | ^ drivers/regulator/tps65218-regulator.c: In function ‘tps65218_pmic_set_suspend_disable’: drivers/regulator/tps65218-regulator.c:144:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 144 | if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1) | ^ Cc: Keerthy Cc: Tero Kristo Cc: Dave Gerlach Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/regulator/tps65218-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c index 05d13f8079182..9133d0af793a7 100644 --- a/drivers/regulator/tps65218-regulator.c +++ b/drivers/regulator/tps65218-regulator.c @@ -128,7 +128,7 @@ static int tps65218_pmic_set_suspend_enable(struct regulator_dev *dev) struct tps65218 *tps = rdev_get_drvdata(dev); unsigned int rid = rdev_get_id(dev); - if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1) + if (rid > TPS65218_LDO_1) return -EINVAL; return tps65218_clear_bits(tps, dev->desc->bypass_reg, @@ -141,7 +141,7 @@ static int tps65218_pmic_set_suspend_disable(struct regulator_dev *dev) struct tps65218 *tps = rdev_get_drvdata(dev); unsigned int rid = rdev_get_id(dev); - if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1) + if (rid > TPS65218_LDO_1) return -EINVAL; /* From patchwork Fri Jun 26 06:57:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627083 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D9AF66C1 for ; Fri, 26 Jun 2020 10:30:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB1462070A for ; Fri, 26 Jun 2020 10:30:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ghSaM0Fz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MQXuPCc7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB1462070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E8Gfz9QTr2Rv4KGSB+xpczgzWn9olW4yk5YXLPWpwyA=; b=ghSaM0FzlWkZwo8lg9G5IvgPc n9ta4JnPZ6q90XKjbH8yrqy2qxHL0qQUzcS2b/KdqusUiXK1+Y0Cdjpw5sfPO7vMA6yP3nGi2Pjy0 4y+DsaD1srOTq/PNThccp4mglf4sppmBqv6PgNSrMYKAd1AGgmp3I4Fexp434gT66Wiw4ye+KRaFo xHNtD+bkkvBo3s3q9Disge/acfOphpgnLfngNZSm4vUN3U1UCQhmcsWVR443YISm7k6xj+FWdBMAq NMnK8t8Zsv7JLA57oizj+pJ60//9nJ9H5KkI52pv0Wsn+PRoFE0FmN41M/vNKfqQ95M7r2MSQJKU6 JK8J0KuPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jola5-0003U3-9U; Fri, 26 Jun 2020 10:27:37 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolWp-0001wT-NF for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:24:25 +0000 Received: by mail-ed1-x541.google.com with SMTP id t21so6484822edr.12 for ; Fri, 26 Jun 2020 03:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jRfQMWFiLuo72c4Et2D0Wla00RQIPz6rSbxQq9GAn0g=; b=MQXuPCc7Mjv33UQSHtC4N3wrHkIlhRxtHQwgqZtO4v7nCEB36kZKmsUQi6wdGYHIPL VQb8HSHug4A0Lgyb89wHbep9mhuiQbFY4edoDQGhK8MDrVxYq9EU0AHoRScOzad/EcNZ Ucjr7ATwejxJmF1az44c0zA9yy4nIqLqT9xeZLJf3hoS5CLzCCEqxvXS0/ZHNZ4n7Tvu LK7V9grgePhB3Lhuke4DCkxcRYN7eOB9WmyT6sO1lTIORYotBCo2hmaLEAwLu2wmrOu+ JEjNMMcO9gIdIERLXVXkmyKCakRN6+u6VlxH4vUKfhxbimykfd962r69x9g/TYt+R2MB 4cfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jRfQMWFiLuo72c4Et2D0Wla00RQIPz6rSbxQq9GAn0g=; b=eKXvv429ev3YvFt+b4M330OEI5m36uug03UDGn6yzWEM3yof6GVhR+p9fMJtnyycyK LXeb4rImh7NObTzhIrL+yPutPtbJQaqcMc1wvlniMk92+Zua90XhJxS5YricJ9qSKiXq HJhV5Pn1N7J+Tlf4iHyC4ylMk9AXGwZUPmFHU8YVN7PsKGNUmaic1iAvkmMsqJhrs0Al 90L5Os8+uoGWhkX6kLkGfVzUvxhBDd079ix/CZWN4MQzNDAcyf3J3WJtavpTXBk6Mfx8 ZJSQKDRfRThT+gM66Ii5XbYF3Onz0HwlScqPUqAAr2KZWAqnShwNErsOUDBhRLDfXOUP ycRQ== X-Gm-Message-State: AOAM532KU0BrHdKGT8us3PixIEWqAyJQRkrshScTbX75DZ6PUsmsrB0+ gb2qbsg/k9fary7QXZWBJRUyJn8qjoI= X-Google-Smtp-Source: ABdhPJyKozvM3BXdGCNtzmZiByH7kCyGCYKVSZ9+sVOpyMVo9mCtBv8zHsYyN9Z4cgcVvtAYBkL7BQ== X-Received: by 2002:a5d:46d0:: with SMTP id g16mr2262620wrs.229.1593154671271; Thu, 25 Jun 2020 23:57:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:50 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Subject: [PATCH 8/9] regulator: wm8400-regulator: Repair dodgy kerneldoc header formatting Date: Fri, 26 Jun 2020 07:57:37 +0100 Message-Id: <20200626065738.93412-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:541 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@opensource.cirrus.com, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org W=1 kernel builds report a lack of descriptions for various function arguments. In reality they are documented, but the formatting was not as expected '@.*:'. Instead, some weird arg identifiers were used. This change fixes the following warnings: drivers/regulator/wm8400-regulator.c:243: warning: Function parameter or member 'dev' not described in 'wm8400_register_regulator' drivers/regulator/wm8400-regulator.c:243: warning: Function parameter or member 'reg' not described in 'wm8400_register_regulator' drivers/regulator/wm8400-regulator.c:243: warning: Function parameter or member 'initdata' not described in 'wm8400_register_regulator' Cc: patches@opensource.cirrus.com Signed-off-by: Lee Jones Acked-by: Charles Keepax --- drivers/regulator/wm8400-regulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/wm8400-regulator.c b/drivers/regulator/wm8400-regulator.c index 4cb1fbb597227..e9fd137077213 100644 --- a/drivers/regulator/wm8400-regulator.c +++ b/drivers/regulator/wm8400-regulator.c @@ -234,9 +234,9 @@ static struct platform_driver wm8400_regulator_driver = { * the regulator API. It is intended to be called from the * platform_init() callback of the WM8400 MFD driver. * - * @param dev The WM8400 device to operate on. - * @param reg The regulator to control. - * @param initdata Regulator initdata for the regulator. + * @dev: The WM8400 device to operate on. + * @reg: The regulator to control. + * @initdata: Regulator initdata for the regulator. */ int wm8400_register_regulator(struct device *dev, int reg, struct regulator_init_data *initdata) From patchwork Fri Jun 26 06:57:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627183 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BA7DA90 for ; Fri, 26 Jun 2020 11:10:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B6082082E for ; Fri, 26 Jun 2020 11:10:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oZKhapjw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o4qPuOSq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B6082082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EOcjAukzw7F7yOWTNuY8JwBSBraoA+ThB3cSSioxGpo=; b=oZKhapjwiIQss7j7eAMkyrzFV wJCTRpFL1mSxiFm2xyvOYYrrjEKTcYYb78NIWVDTem4kocPG6dvVgNoJ2iW+w5Cg//mTZWqut71nD ++AtfNn3jgxl5bJG9g4xNfg8u9cH30NHd2T4pew4LRP1ZWweBj5EN/KKoAb7YqgaWHI/+BpUlrh/y DXesdNfEZDBMRZ6Z7uOHZ69nZNDBWHFXUUyv6IMe+ymHF/rxvd/KifiEro3tTVGWpPUvlyskWSRZR D1mjTBejojBJkb6e12tDMduMu1Af9rJp8nNLgEjgTV5l6XAwGx0v3/RlCS7bn7kCz9tRitLmN4atl SYRByN7qA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomCn-0003Aa-DH; Fri, 26 Jun 2020 11:07:37 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jokrd-0008F8-65 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 09:41:52 +0000 Received: by mail-wm1-x344.google.com with SMTP id j18so8209022wmi.3 for ; Fri, 26 Jun 2020 02:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LPP/UO1S0fFlAO//S91M0USmj0hNvysUxqLwY/EHMpU=; b=o4qPuOSqulK9KuVSnsgC92nheOHo5sPkiZnIT04OlBWs0kqtIAb1N4z9yQia5M2icA guTWlRhrkyCoWzC3edxywWhCMB3kYYXx9d8LTrmQCGfjb/QaOR6ps5jq6FstBy2QKQJb plyMLcEJmAyltVcNPygxskIaJ7VzzxZD4OsFPUEhxq4+1VRKnED8SBVFGi4HWn9pUxx+ tLSKSQgUHmlCfWhnt7UMwcLy7gfDfBLZbhv5ML1APO4aygCLEAPPS0iKzMTl7AMxCCSl d7BR7Lw8RUp82W2CZ80jxbfRBZ1g1YuuLsfxPW4NCtWVmtct5JlmAwZ+yoIeeDj7kiuO Werg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LPP/UO1S0fFlAO//S91M0USmj0hNvysUxqLwY/EHMpU=; b=NPJIUBgAZStoLBXpOUTTUaUY7Y3/M6aMj3dgS9TKwXP6cs6Pb5+Gw/2lDxF0OVUDYa YVr+Pd6IxMaWMFmos+7tn/yOf3c2W7Sg+LmTsd/7LeVAaQVxI/5cGIvhT874MrDSxfrF N6O5Gz4QVnAWIS2ZQbCSWRyx1QfaeACo/okMiIT6AZa+IZX4EMnzWhrzuYww6uQVZOM9 GzAQkvrkW6Os8u72LTmEW1bFOa98L4u2rukT5JryJNH2awfuzJbWZd976ngNA5t8Ac3q xS0j22YJPpbiFcC6M6hPxIV38CPf2n0U5dh5R+80BHq9PH+ACNFoclOmauKReCwTd/3d t8nw== X-Gm-Message-State: AOAM530sIi5ClLZDhgq2DU2G/Wmaes+f5v/6AeV0Fuc1PDfcNfO59aOH C5/29PFpCnfgCvMEw9BEgnYsgLepLMc= X-Google-Smtp-Source: ABdhPJx/RXJWJ6f3locg3j1C1CnDGokvk4hRTKSjAebqtaEGNZhKkk9x/cjUDtFriHU5yMFzH+64dQ== X-Received: by 2002:a1c:1bc4:: with SMTP id b187mr1906640wmb.105.1593154672520; Thu, 25 Jun 2020 23:57:52 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:51 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Subject: [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct regulator_desc pmi8994_boost' Date: Fri, 26 Jun 2020 07:57:38 +0100 Message-Id: <20200626065738.93412-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Andy Gross , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This was an upstreaming error. Remove it as it's not to be used. Fixes the following W=1 kernel build warning: drivers/regulator/qcom_smd-regulator.c:477:36: warning: ‘pmi8994_boost’ defined but not used [-Wunused-const-variable=] Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson --- drivers/regulator/qcom_smd-regulator.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c index 53a64d856926f..4c0a469d8a115 100644 --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -474,15 +474,6 @@ static const struct regulator_desc pmi8994_bby = { .ops = &rpm_bob_ops, }; -static const struct regulator_desc pmi8994_boost = { - .linear_ranges = (struct linear_range[]) { - REGULATOR_LINEAR_RANGE(4000000, 0, 30, 50000), - }, - .n_linear_ranges = 1, - .n_voltages = 31, - .ops = &rpm_smps_ldo_ops, -}; - static const struct regulator_desc pm8998_ftsmps = { .linear_ranges = (struct linear_range[]) { REGULATOR_LINEAR_RANGE(320000, 0, 258, 4000),