From patchwork Sat Jun 27 11:10:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 11629541 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C031D13B4 for ; Sat, 27 Jun 2020 11:10:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E2DF21582 for ; Sat, 27 Jun 2020 11:10:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OZs/VMZr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726457AbgF0LKf (ORCPT ); Sat, 27 Jun 2020 07:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725926AbgF0LKe (ORCPT ); Sat, 27 Jun 2020 07:10:34 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D4BEC03E979 for ; Sat, 27 Jun 2020 04:10:34 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id e4so12931811ljn.4 for ; Sat, 27 Jun 2020 04:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lBpdf/khDgnPpIUamL/U5+Y2f2FxxM1Gdrv6GX7g+Fw=; b=OZs/VMZrdx4IM8IwdI/rOmvKtKfJES5KxqmGr9W/zseFQpHIN2CYbbksTIdd60bv7i YhHIWXO1UkTFVj0hV6xDBEBPIyniTtF3Xqaqjt1EGfqs3vdQc851lJtwoBARu1PrPQDx Kq8gzMdPY4+pL+mR0cRzFPWlotCP2krSD/GLcvEvygrRSN+ffYLKiMQ5jPBOQVdBAMSc 7/jsZ4mt5VKrF9elvGe1DffIsK54k68rb4CEkcmJApxSK97/keprc0VoH0rKQYf+zxj1 Q7QdNnLsmwKzwJjxmt8bLaYh0U8Lu+9kBWrLpjcU5HBjfqepjWT8ol9X4Q3/60cuKXrv 78NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lBpdf/khDgnPpIUamL/U5+Y2f2FxxM1Gdrv6GX7g+Fw=; b=OnOD+L/NAhon8tJaaWBFtNeXpF6OsCH3dTwRmN+aBc2n0MwS2iieHfKIDm4susnx54 C6HB4C1WA79Bg4Ou8NX2zVZ3Zh5GTHFClbMlY7k6TB28YCVqhIheAtULme33AJlRNitC DyP2v3n5LSfuKYF0YHJm/A7FL2hB1lVjG9pDh2s4FsxT8Lk3EqNuJJ6XDGqr6tuWSJXp cklFrGfUxOmloD/wYbVLqcnBh8S+5UecsTAvWfYKriNVVzetK9u5h0x8fuaiul3Krdmm OvT/e3vDUrZoUwbh88/ezBkeyo2y57OIiwGwTanSr7L+bm9JmEvCe7pWsoO3eYx4veeF VwGQ== X-Gm-Message-State: AOAM531Cl+x0eeEdf4AW63INe91U3WfaSJn1F7sahhmMBOe0Jm4FDgcd ck3xpOMQgBzJJBo2KwmrYuljvQ96dlk= X-Google-Smtp-Source: ABdhPJy2EjExybwo4F2qhfAjl24OfnH6LnJpxXi+X3RTNPFwY3q67ukvLBc1D/ePR19D97HXQVsC6w== X-Received: by 2002:a2e:9eca:: with SMTP id h10mr3716603ljk.273.1593256232482; Sat, 27 Jun 2020 04:10:32 -0700 (PDT) Received: from genomnajs.lan (c-d63ee155.152980-0-69706f6e6c79.bbcust.telenor.se. [85.225.62.214]) by smtp.gmail.com with ESMTPSA id g7sm5347807lfe.62.2020.06.27.04.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jun 2020 04:10:31 -0700 (PDT) From: Linus Walleij To: Greg Kroah-Hartman , Felipe Balbi Cc: linux-usb@vger.kernel.org, Linus Walleij , Andy Shevchenko Subject: [PATCH] usb: gadget: pch_udc: Convert to use GPIO descriptors Date: Sat, 27 Jun 2020 13:10:29 +0200 Message-Id: <20200627111029.513642-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This switches the PCH UDC driver to use GPIO descriptors. The way this is supposed to be used is confusing. The code contains the following: /* GPIO port for VBUS detecting */ static int vbus_gpio_port = -1; /* GPIO port number (-1:Not used) */ So a hardcoded GPIO number in the code. Further the probe() path very clearly will exit if the GPIO is not found, so this driver can only be configured by editing the code, hard-coding a GPIO number into this variable. This is simply not how we do things. My guess is that this is used in products by patching a GPIO number into this variable and shipping a kernel that is compile-time tailored for the target system. I switched this mechanism to using a GPIO descriptor associated with the parent PCI device. This can be added by using the 16bit subsystem ID or similar to identify which exact machine we are running on and what GPIO is present on that machine, and then add a GPIO descriptor using gpiod_add_lookup_table() from . Since I don't have any target systems I cannot add this but I'm happy to help. I put in a FIXME so the people actually using this driver knows what to do. Cc: Felipe Balbi Cc: Andy Shevchenko Signed-off-by: Linus Walleij Tested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko --- Andy: your input would be appreciated, this kind of code customizing random embedded Intel systems is deep water for me, so this is just a rough guess on how it should be done. --- drivers/usb/gadget/udc/pch_udc.c | 55 +++++++++++++------------------- 1 file changed, 22 insertions(+), 33 deletions(-) diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index 3344fb8c4181..a9e332130091 100644 --- a/drivers/usb/gadget/udc/pch_udc.c +++ b/drivers/usb/gadget/udc/pch_udc.c @@ -12,12 +12,9 @@ #include #include #include -#include +#include #include -/* GPIO port for VBUS detecting */ -static int vbus_gpio_port = -1; /* GPIO port number (-1:Not used) */ - #define PCH_VBUS_PERIOD 3000 /* VBUS polling period (msec) */ #define PCH_VBUS_INTERVAL 10 /* VBUS polling interval (msec) */ @@ -302,13 +299,13 @@ struct pch_udc_ep { /** * struct pch_vbus_gpio_data - Structure holding GPIO informaton * for detecting VBUS - * @port: gpio port number + * @port: gpio descriptor for the VBUS GPIO * @intr: gpio interrupt number * @irq_work_fall Structure for WorkQueue * @irq_work_rise Structure for WorkQueue */ struct pch_vbus_gpio_data { - int port; + struct gpio_desc *port; int intr; struct work_struct irq_work_fall; struct work_struct irq_work_rise; @@ -1253,7 +1250,7 @@ static int pch_vbus_gpio_get_value(struct pch_udc_dev *dev) int vbus = 0; if (dev->vbus_gpio.port) - vbus = gpio_get_value(dev->vbus_gpio.port) ? 1 : 0; + vbus = gpiod_get_value(dev->vbus_gpio.port) ? 1 : 0; else vbus = -1; @@ -1355,42 +1352,30 @@ static irqreturn_t pch_vbus_gpio_irq(int irq, void *data) /** * pch_vbus_gpio_init() - This API initializes GPIO port detecting VBUS. * @dev: Reference to the driver structure - * @vbus_gpio Number of GPIO port to detect gpio * * Return codes: * 0: Success * -EINVAL: GPIO port is invalid or can't be initialized. */ -static int pch_vbus_gpio_init(struct pch_udc_dev *dev, int vbus_gpio_port) +static int pch_vbus_gpio_init(struct pch_udc_dev *dev) { int err; int irq_num = 0; + struct gpio_desc *gpiod; - dev->vbus_gpio.port = 0; + dev->vbus_gpio.port = NULL; dev->vbus_gpio.intr = 0; - if (vbus_gpio_port <= -1) - return -EINVAL; - - err = gpio_is_valid(vbus_gpio_port); - if (!err) { - pr_err("%s: gpio port %d is invalid\n", - __func__, vbus_gpio_port); - return -EINVAL; - } - - err = gpio_request(vbus_gpio_port, "pch_vbus"); - if (err) { - pr_err("%s: can't request gpio port %d, err: %d\n", - __func__, vbus_gpio_port, err); - return -EINVAL; - } + /* Retrieve the GPIO line from the USB gadget device */ + gpiod = devm_gpiod_get(dev->gadget.dev.parent, NULL, GPIOD_IN); + if (IS_ERR(gpiod)) + return PTR_ERR(gpiod); + gpiod_set_consumer_name(gpiod, "pch_vbus"); - dev->vbus_gpio.port = vbus_gpio_port; - gpio_direction_input(vbus_gpio_port); + dev->vbus_gpio.port = gpiod; INIT_WORK(&dev->vbus_gpio.irq_work_fall, pch_vbus_gpio_work_fall); - irq_num = gpio_to_irq(vbus_gpio_port); + irq_num = gpiod_to_irq(gpiod); if (irq_num > 0) { irq_set_irq_type(irq_num, IRQ_TYPE_EDGE_BOTH); err = request_irq(irq_num, pch_vbus_gpio_irq, 0, @@ -1416,9 +1401,6 @@ static void pch_vbus_gpio_free(struct pch_udc_dev *dev) { if (dev->vbus_gpio.intr) free_irq(dev->vbus_gpio.intr, dev); - - if (dev->vbus_gpio.port) - gpio_free(dev->vbus_gpio.port); } /** @@ -2894,7 +2876,7 @@ static int pch_udc_pcd_init(struct pch_udc_dev *dev) { pch_udc_init(dev); pch_udc_pcd_reinit(dev); - pch_vbus_gpio_init(dev, vbus_gpio_port); + pch_vbus_gpio_init(dev); return 0; } @@ -3096,6 +3078,13 @@ static int pch_udc_probe(struct pci_dev *pdev, dev->base_addr = pcim_iomap_table(pdev)[bar]; + /* + * FIXME: add a GPIO descriptor table to pdev.dev using + * gpiod_add_descriptor_table() from based on + * the PCI subsystem ID. The system-dependent GPIO is necessary for + * VBUS operation. + */ + /* initialize the hardware */ if (pch_udc_pcd_init(dev)) return -ENODEV;