From patchwork Mon Oct 15 14:10:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10641923 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E47C6925 for ; Mon, 15 Oct 2018 14:11:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D3B9729953 for ; Mon, 15 Oct 2018 14:11:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C709729AE1; Mon, 15 Oct 2018 14:11:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC5E629953 for ; Mon, 15 Oct 2018 14:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbeJOV4i (ORCPT ); Mon, 15 Oct 2018 17:56:38 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:35031 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726557AbeJOV4h (ORCPT ); Mon, 15 Oct 2018 17:56:37 -0400 Received: by mail-lf1-f67.google.com with SMTP id r191-v6so14201334lff.2 for ; Mon, 15 Oct 2018 07:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=M/ZhIWYIfY5r4RddVyoWnRgXdqgFCk+iYSx5Jk3TXYk=; b=TH9oQngydTICbA1P922pQMW2Tu7UFQ1JHrtA/Y+fzM6ofaz4+BT4JlwI/0pRQ1aqr8 haOvYHGJZEYbRz3ScvR3XP5IKT6S34JTKnG7bKGwKr7wEcJeUcVHXFoTqttTnfhPpuJM ZytKpS/UrmWo1Xo+xWa1Sf/98/0VMirJh+l+c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=M/ZhIWYIfY5r4RddVyoWnRgXdqgFCk+iYSx5Jk3TXYk=; b=rsCUxVlXJ7X4fsMigrw6+sFBAsihDilX1a0ggIjVt1JxziXvy6LR1TX7siOxoRwFE7 bFgecNiotY2lzaehYVXJFr0IQdrJKwDwLLn1HYwgXY+RW1gDkj4cTkhEnumA/c5Srr/i uvI06pN6I7qWCL036z9PMRHeC6OVrsINETpeLk+/cgTPNElHu1JdZvmTBv5Y2boVyZpL LZt+5kogz5LEK1FaRxJgO6F2fjOqq8YEhsJPksVuyXdl4EMaGoYcr/5+nqP++/eHoADz liRGiORQkl4CdDpsESz/YdzFPEbTl4AFMH01nZDSZcll6QlIrliGBkmV8psr8vEdvPgr eAzA== X-Gm-Message-State: ABuFfojRag68ONiYAKtUres5oLkTFU9QGxvFfqxOgQ+OT3zGHrsQFXop 1cCtHGvM9wNHBDb9GKnJEskJvDVW1r8= X-Google-Smtp-Source: ACcGV6132TgjbSOMNf1+VE/eRIeq96zAI8PW9OJpv+CVo3vAJaJHY/PthDnWs+3b9GtbOaQOBq85Ig== X-Received: by 2002:a19:9585:: with SMTP id x127-v6mr10098054lfd.112.1539612667956; Mon, 15 Oct 2018 07:11:07 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id p24-v6sm2437537ljg.57.2018.10.15.07.11.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Oct 2018 07:11:05 -0700 (PDT) From: Linus Walleij To: linux-block@vger.kernel.org, Jens Axboe Cc: linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, Linus Walleij , Pavel Machek , Paolo Valente , Ulf Hansson , Richard Weinberger , Adrian Hunter , Bart Van Assche , Jan Kara , Artem Bityutskiy , Christoph Hellwig , Alan Cox , Mark Brown , Damien Le Moal , Johannes Thumshirn , Oleksandr Natalenko , Jonathan Corbet Subject: [PATCH v2] block: BFQ default for single queue devices Date: Mon, 15 Oct 2018 16:10:59 +0200 Message-Id: <20181015141059.26579-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.17.2 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This sets BFQ as the default scheduler for single queue block devices (nr_hw_queues == 1) if it is available. This affects notably MMC/SD-cards but also UBI and the loopback device. I have been running it for a while without any negative effects on my pet systems and I want some wider testing so let's throw it out there and see what people say. Admittedly my use cases are limited. I need to keep this patch around for my personal needs anyway. We take special care to avoid using BFQ on zoned devices (in particular SMR, shingled magnetic recording devices) as these currently require mq-deadline to group writes together. I have opted against introducing any default scheduler through Kconfig as the mq-deadline enforcement for zoned devices has to be done at runtime anyways and too many config options will make things confusing. My argument for setting a default policy in the kernel as opposed to user space is the "reasonable defaults" type, analogous to how we have one default CPU scheduling policy (CFS) that make most sense for most tasks, and how automatic process group scheduling happens in most distributions without userspace involvement. The BFQ scheduling policy makes most sense for single hardware queue devices and many embedded systems will not have the clever userspace tools (such as udev) to make an educated choice of scheduling policy. Defaults should be those that make most sense for the hardware. Cc: Pavel Machek Cc: Paolo Valente Cc: Jens Axboe Cc: Ulf Hansson Cc: Richard Weinberger Cc: Adrian Hunter Cc: Bart Van Assche Cc: Jan Kara Cc: Artem Bityutskiy Cc: Christoph Hellwig Cc: Alan Cox Cc: Mark Brown Cc: Damien Le Moal Cc: Johannes Thumshirn Cc: Oleksandr Natalenko Cc: Jonathan Corbet Signed-off-by: Linus Walleij Acked-by: Paolo Valente Reviewed-by: Ulf Hansson --- ChangeLog v1->v2: - Add a quirk so that devices with zoned writes are forced to use the deadline scheduler, this is necessary since only that scheduler supports zoned writes. - There is a summary article in LWN for subscribers: https://lwn.net/Articles/767987/ --- block/elevator.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index 8fdcd64ae12e..6e6048ca3471 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -948,13 +948,16 @@ int elevator_switch_mq(struct request_queue *q, } /* - * For blk-mq devices, we default to using mq-deadline, if available, for single - * queue devices. If deadline isn't available OR we have multiple queues, - * default to "none". + * For blk-mq devices, we default to using: + * - "none" for multiqueue devices (nr_hw_queues != 1) + * - "bfq", if available, for single queue devices + * - "mq-deadline" if "bfq" is not available for single queue devices + * - "none" for single queue devices as well as last resort */ int elevator_init_mq(struct request_queue *q) { struct elevator_type *e; + const char *policy; int err = 0; if (q->nr_hw_queues != 1) @@ -968,7 +971,18 @@ int elevator_init_mq(struct request_queue *q) if (unlikely(q->elevator)) goto out_unlock; - e = elevator_get(q, "mq-deadline", false); + /* + * Zoned devices must use a deadline scheduler because currently + * that is the only scheduler respecting zoned writes. + */ + if (blk_queue_is_zoned(q)) + policy = "mq-deadline"; + else if (IS_ENABLED(CONFIG_IOSCHED_BFQ)) + policy = "bfq"; + else + policy = "mq-deadline"; + + e = elevator_get(q, policy, false); if (!e) goto out_unlock;