From patchwork Tue Jun 30 13:33:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633939 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6901413B6 for ; Tue, 30 Jun 2020 13:35:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 414962068F for ; Tue, 30 Jun 2020 13:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hITITnzr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q6mGE5E3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 414962068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wtJNuH8iCjlbvPXvrpFhIP2mU33cSLtqiunoT8ddDt4=; b=hITITnzrCtrJ6xbAB/3/NoGJA gnemXuFVOCZySMoVgz0SDZarmV6jgMJPa6bsBvXMoKMVL6bKMVUeuKowz1nT221qmtTCw+qICJIKv 1JsVzTVVwXtqm/+ouE9SdpaUoyOUnTV/5u7RAzx+c0/jPrApM978k4kqcjp3zIqcpazJO5Jt1DkVJ IT739bljgB/Ld8uPkqGUZOGwXQb97Ih6iNgTQnhtXokxnF1a0doYD9W1Uckqb89eeLJ04qviLEWuD sPh93bt1Q5SacUGEbPd/VFHIc9xmC7T9clb+wysxoXZrs9WsLxGy0i+ErXRz0Ef8E848ST7SLW7sD ZR/TZlYpg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOg-0004Fo-FM; Tue, 30 Jun 2020 13:34:02 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOV-0004DC-O9 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:33:52 +0000 Received: by mail-wm1-x342.google.com with SMTP id g10so4563963wmc.1 for ; Tue, 30 Jun 2020 06:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zyIUTlmpGUcnH+LiKgtC/ATIX5960EbAPmpzyReDmls=; b=Q6mGE5E3X/8/+zlhENHURAJbLrEQhKKP61fNSre5+zd/awBDhaniAZCqLJv3T/K+xB LLaHcTkwe5z7mGfkbouNMs2GcI+AqRHhuq6Gz1QCCRJe0Y+hn/YHQuGUZWAqb7RUpdaE 70+NaU99UEzrWJmcUxMJBjS1r9r8XFy8753y04wH/FBtreZ39DbEg4yxDeqSHADl49s1 crYCHpqzEp8rRerMgtEmyT9czhG4JiM8cwA7eHXPiSnTgDUgjm80qrR51MCfCoBh7bds M2AxS/fr2tEVYfL0+cYxhEvrKD3lrdVVxo3BgjB+eZHFrUSXOVioVHn0oc/fAVoRStuq SWvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zyIUTlmpGUcnH+LiKgtC/ATIX5960EbAPmpzyReDmls=; b=Nu25mwKV6XsjYAPyChUEf2em0h3eYuekgO7NfxKhIM5I197ydzZrcINO+KeMwq0xTM gq964kZjtQEu+ZDiF9hMXzWgWFejtoFnULQK++YSWMdrG+uO5O86a+pvMnlEci0YDqSi sthvCd25+i51l3kYZsE2tihOL8WIUXrSMNUKdGuj9hFvkKMU7Qc0g9Sg3qEQAQ6jN2U3 boc0Q/kK7bet7mipdpwZDzollX38Zy9Ss/qOFqYlqJS/n+Pp7Q6IEZOXOEZ7wqQJaF8P zDOL0BNy2yx56EPIh3od3ZQS6AMfDG3WHNSwANuC61qi86M11J03PJ/wNObkCkX6x4xd /9vQ== X-Gm-Message-State: AOAM531zmTtT5TL+1vtlBXEBEhKtatpx8jSK8TMfa7bVBGjFcOeNWBiN h6Z1dKn4JPeoV0pBHJq1ekR3FDRpTZg= X-Google-Smtp-Source: ABdhPJw7St3BA3NSrWMeVnDiPKDDzNpn3UpLraNAHGKv+8L6f1Y/qEVIk8Dy7tAqPKp72fwVAxdgCg== X-Received: by 2002:a05:600c:2058:: with SMTP id p24mr21449910wmg.74.1593524029704; Tue, 30 Jun 2020 06:33:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:49 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 01/10] gpio: gpiolib-of: Provide documentation for of_gpio_spi_cs_get_count() Date: Tue, 30 Jun 2020 14:33:36 +0100 Message-Id: <20200630133345.2232932-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Anton Vorontsov , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Descriptions for of_gpio_spi_cs_get_count()'s 2 arguments are missing. Document both 'dev' and 'con_id'. Fixes the following W=1 kernel build warnings: drivers/gpio/gpiolib-of.c:36: warning: Function parameter or member 'dev' not described in 'of_gpio_spi_cs_get_count' drivers/gpio/gpiolib-of.c:36: warning: Function parameter or member 'con_id' not described in 'of_gpio_spi_cs_get_count' Cc: Anton Vorontsov Signed-off-by: Lee Jones --- drivers/gpio/gpiolib-of.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 219eb00542334..236985714ea92 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -25,6 +25,9 @@ /** * of_gpio_spi_cs_get_count() - special GPIO counting for SPI + * @dev: Consuming device + * @con_id: Function within the GPIO consumer + * * Some elder GPIO controllers need special quirks. Currently we handle * the Freescale GPIO controller with bindings that doesn't use the * established "cs-gpios" for chip selects but instead rely on From patchwork Tue Jun 30 13:33:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633943 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AB14C174A for ; Tue, 30 Jun 2020 13:35:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 846962068F for ; Tue, 30 Jun 2020 13:35:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BIVwr7oj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x/GhyMw3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 846962068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7lG6rsc1Gfdz7dZ5k521YWaN8jJOPoguPDAoyqTISiY=; b=BIVwr7ojL6lIZQ6IMNCPjOW8v zt2hJMjHOMQBB9NPhozY6LF80bsh5zpSK4F6bKhErZdLVogOgDDxe2xt8Hf7FJ0e2xf0z/ogeOn/N xYLGZhr99PygZxC2xwFAhB8L00wjN24NuRseGPtB0LqWPnmzl912aWSbTvgvijJBMnERkmsN7kas2 +iKN0pOkOfQpvDxXpJPh2JeFBfpp8l3PuMDnXtKIB9QSpNKpOycX3qcHemPTICuFQEQY56utuvOUK vJzMY9p7ffs+mpATNkwMH/sNmBgaG/Y4kU7mvy2AaZv/guxXjGi0m8xT94r06vTxi8BP3H0bcoVWb VhyBjEsZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOc-0004FB-KS; Tue, 30 Jun 2020 13:33:58 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOV-0004DD-OR for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:33:52 +0000 Received: by mail-wm1-x344.google.com with SMTP id g75so18824588wme.5 for ; Tue, 30 Jun 2020 06:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0KDVLpzHsMQDeKu96sh9LYIj12RVnAxA/ichztsrMZQ=; b=x/GhyMw3/PifnbCbFgYc7YsXMeDkSg5tTzV3oQIeQg6caOEYi+xswGvOI4ODzVR/8n iYpm0sI3ldVEWE09KVrxRclwDY+yPK6PRD4DJgs9uGscSp38D6ptpQ1FCdluuhPOl+3a fjUpiqUFSOdZEY8qRBCBH2z1Xp7eeoe0+lVECx17sZjtUMuLT84RMxJ1egmxJL5M4AyA FyjcF0JSFT6aIyLB57aBRZk7L9szqdI9Oh3iXaf7HgtrY7jWAvB45lA39yduqcbnBQ/4 YDdIIUEW1DQrsDmASh/wUS7qq16C1l2mnsG2iKBst8FVZG1WDGPO9hfscMSITQxIUidG 53Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0KDVLpzHsMQDeKu96sh9LYIj12RVnAxA/ichztsrMZQ=; b=e2AWajeSrKyfKErZCU6DQgf0ig+rbeTIAR48CpoA2Eh0Lo8PnC00hCH8JqC61793n+ RMMsGoor524eOmBHkNAnLRdc3aFoO0whXC/8KfxQxNYp3H5YrScKOzXuttYkt+CZggzT ahvx2//r0rw8jDgcua7ZaTChPIO9OnLPXYcBuIWSNPdR2AoTq4AETAqaLCC6N9hyMwn5 6PZrvoxtAnahGoVU5Ht3sXAAPjl4u1aN6X5F8Ylof2VTAsahGwXlw45E615E/4wycVf9 MZ2s8yY6nIN4uIfRBpr3QabgEHHukAj94fJmjlyZRHCf1uZKK/xaixmzm+qKkpXfKjrZ c8tA== X-Gm-Message-State: AOAM532gUTfiHxoIc7TUjkbY+WGXOEnPkTlc+/AnvRyxhAIF611+nlC4 fTYDu1pz8ukR6mMkvDKxkk+jpA== X-Google-Smtp-Source: ABdhPJyW4GtmRxifF3bHq9VjFlQY+qelF9g4jJYBP6hKH+QoodWUb+3zaFky4HbgEYJPkrGSE/VpMw== X-Received: by 2002:a1c:80d3:: with SMTP id b202mr22156497wmd.111.1593524030718; Tue, 30 Jun 2020 06:33:50 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:50 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 02/10] gpio: gpio-altera: Add missing kerneldoc entry and demote comment Date: Tue, 30 Jun 2020 14:33:37 +0100 Message-Id: <20200630133345.2232932-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tien Hock Loh , Joyce Ooi , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'struct altera_gpio_chip's 'irq_chip' property is undocumented. So add property description to the struct's kerneldoc header. Also demote comment block which is clearly not in kerneldoc format. Fixes the following W=1 warnings: drivers/gpio/gpio-altera.c:34: warning: Function parameter or member 'irq_chip' not described in 'altera_gpio_chip' drivers/gpio/gpio-altera.c:78: warning: Function parameter or member 'd' not described in 'altera_gpio_irq_set_type' drivers/gpio/gpio-altera.c:78: warning: Function parameter or member 'type' not described in 'altera_gpio_irq_set_type' Cc: Joyce Ooi Cc: Tien Hock Loh Signed-off-by: Lee Jones --- drivers/gpio/gpio-altera.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c index cc4ba71e4fe3c..b7932ecc3b613 100644 --- a/drivers/gpio/gpio-altera.c +++ b/drivers/gpio/gpio-altera.c @@ -24,6 +24,7 @@ * @interrupt_trigger : specifies the hardware configured IRQ trigger type * (rising, falling, both, high) * @mapped_irq : kernel mapped irq number. +* @irq_chip : IRQ chip configuration */ struct altera_gpio_chip { struct of_mm_gpio_chip mmchip; @@ -69,7 +70,7 @@ static void altera_gpio_irq_mask(struct irq_data *d) raw_spin_unlock_irqrestore(&altera_gc->gpio_lock, flags); } -/** +/* * This controller's IRQ type is synthesized in hardware, so this function * just checks if the requested set_type matches the synthesized IRQ type */ From patchwork Tue Jun 30 13:33:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633941 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0726E13BD for ; Tue, 30 Jun 2020 13:35:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D453E2068F for ; Tue, 30 Jun 2020 13:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ON3AkYFk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m5TXu/t5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D453E2068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5hjU9IOWkuMN43d8lNiDiK7lQ/qSh55dRSemkL6rX10=; b=ON3AkYFku5HIUoogtbYRvABzv gZerjy8giG3jCu+FYfSHw9MlyQ5tKcA7TVADHS31tmA4CX+m543o9sS1HrFZ3EaOb9wko0RES0tQC TaI7vUDCL+DDu3xMtMVV13wdvDQK9ljAGlnrgo7n+B4xLQ2PRG2Vw+qT6cBGzl02jWZzTtqBb+eRu T9Ru3IVoUXV2LU4iaLeRm3w1etsZDFASldC87O+I3521txl+LnLuQhiSmflG031bHr08ctFIAo8TL oxofw+FmS7cjhdWfwVGOLMK55UwrJLQIjiZz6TKm2CnrbKIKK5ZgIue1rIyPTK4XbyuIYlmJU7Adq 6509/oNPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOj-0004GQ-5u; Tue, 30 Jun 2020 13:34:05 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOW-0004DK-KX for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:33:53 +0000 Received: by mail-wm1-x342.google.com with SMTP id a6so15979920wmm.0 for ; Tue, 30 Jun 2020 06:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qGhRYBFyg4w70/+i8v0aKH3im1q1Wu84G6qHkN10ns=; b=m5TXu/t5DKfMXruQKZB68+3bIMiutcLyKBEStN8LN7fnI7W31+Ke2AzvBR8VwgqjKR LqwayMuHUVg/5efbOBN+c7Jr5PsEe+CE1FN9f+EDZU+XR2HKF77dvsLsvNzwSw9+Sszb /3M/mw8soiSberSwHv7Zi15ZVc7HUq0eVnUrtWiLDFwj5IJXDUbjclnJKU9rbOXe+LbB ONz02j168Rt3Gw6tn+TFBAHJ94k922AEa2refrxFnJrzSG1Zr+nOH/sHdeKLyXNxx50T hfXn4EeRnGQ/vOjTI860tqbnIymxlU+3sB0X9hZgmUyDUB3MDcTHNcsEB6oyKaSQOmbo Snvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+qGhRYBFyg4w70/+i8v0aKH3im1q1Wu84G6qHkN10ns=; b=mxArPG6L+6Lmn/kQRicNiC+H+SNXrf+w8w1OIDwkRKo+cW0AAnAU/cvaigqsyAWBqa K5ABbdlyv3iCYH8Hz5qGUHmvVvL4drRzgAI41H9tIIDc+QANwB2rYVJ0MLXYjPbP6rjR q/EbTSG29LEJElLbGg4eWYtEUrXyWPRkHmdgC2mNwu+onyfLsvT8B8g4c8DNbuKv1rdL o94yW6uHHnaUt20WNZOsWAzJbSfcT23AFxg6RLYnWphLUzFmsvUhsb4LMA996IbACXdj T1Qv8wfXJTS9qaeB81VllIt6nzcMMtNzhRu3kbuaLR9rFqNrFJQe6iElfdllQqCmPSYo sWMw== X-Gm-Message-State: AOAM530VsoF2v1Gi5Stl2llBMHAPa478qUKO5EWf5EO1VMZBjtzWIKHe s8QbohC7u/M2P4D/EiK48iMgUA== X-Google-Smtp-Source: ABdhPJwxspIcxssmP1G2rn5ofE8vN2GTlugAs3HTO7L+/ydE6J3tNErrAGTO6z80v51SGDcQuZLyCA== X-Received: by 2002:a1c:16:: with SMTP id 22mr20990748wma.42.1593524031756; Tue, 30 Jun 2020 06:33:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:51 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 03/10] gpio: gpio-ml-ioh: Fix missing ':' in 'struct ioh_gpio_reg_data Date: Tue, 30 Jun 2020 14:33:38 +0100 Message-Id: <20200630133345.2232932-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andy Shevchenko , linux-gpio@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'struct ioh_gpio_reg_data's 'ien_reg' property is missing a ':' which confuses the kerneldoc tooling/parsers/validators. Replacing it squashes the following W=1 warning: drivers/gpio/gpio-ml-ioh.c:63: warning: Function parameter or member 'ien_reg' not described in 'ioh_gpio_reg_data' Cc: Andy Shevchenko Signed-off-by: Lee Jones --- drivers/gpio/gpio-ml-ioh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c index 92b6e958cfed5..53d4abefa6ff2 100644 --- a/drivers/gpio/gpio-ml-ioh.c +++ b/drivers/gpio/gpio-ml-ioh.c @@ -44,7 +44,7 @@ struct ioh_regs { /** * struct ioh_gpio_reg_data - The register store data. - * @ien_reg To store contents of interrupt enable register. + * @ien_reg: To store contents of interrupt enable register. * @imask_reg: To store contents of interrupt mask regist * @po_reg: To store contents of PO register. * @pm_reg: To store contents of PM register. From patchwork Tue Jun 30 13:33:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633947 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0A96174A for ; Tue, 30 Jun 2020 13:35:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89F602068F for ; Tue, 30 Jun 2020 13:35:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ttVblHSd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a52p8zpD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89F602068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P+HVI8orRZxLtu/R72PFaYXLdRuHtcgq/jJSsJnOCqc=; b=ttVblHSd6/mtTnIJSwNReOsJ5 BNidI8zcZdkEiJx4bwD3+85gSmbQ0h53U8O40YoC9Dmafifl7eBySr1LGl9ZdHYezeDLCofOk9nqY WsKWUG9ggqbonmCe/2SIYhfQ7jFpsAk7afcE5yEOGlT+BLn8X9FI/415kn0Qyow/ITRiNtghiisz+ dVZu8M4vOGs10zcTbm1eFeOE+veXbpnmo7gPw/YU+/0fjEISt+fEJEd/6FdK2F+FOfh0UfaLbwGYc bRYrZDyLoYGd9tZ8YSKNSWidgeL2nJp7ISuPZwn1RwgXkV+OFFoNyWNotI/VUrUwXmr3zgO7y6Scz 7cK8oOJtQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOm-0004Hk-Uo; Tue, 30 Jun 2020 13:34:09 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOY-0004Dh-1P for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:33:55 +0000 Received: by mail-wm1-x343.google.com with SMTP id f139so19613210wmf.5 for ; Tue, 30 Jun 2020 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LxMqnKZ6/vF3Sz1VG4ZmVbGw0fGc694S11E5HGVbx6s=; b=a52p8zpDtHp2BZaKl7cLaCsGbQRImiqq+vdYMe+DEp24dRvPaj0y8e3Kju7zD0XhYx CLwU8KT53+rUeG44oD/jA/JijDdkch9F3RMzyJ1ppCeX6KBs/ucps8SozbJzpjtw6mOt jBoBo02vlcgoUfsxeIazznL9FhHExCEjjRFK8stugey1p6cx+rMZ1SxHayD+46hcaVCM 8V8ZwOXV3CqPMIqYBokS0zQGkEJG0UQuUU44tgL2m9+EtAqzEEXvqj+MCGmqaek2aBnk AuLUNAngsZhaTMBEpLkFjYtH/YvrrGCbOElVQH/o+cZUwBRqtDsh5w6OHa0fU394DeRV X+6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LxMqnKZ6/vF3Sz1VG4ZmVbGw0fGc694S11E5HGVbx6s=; b=KYbjyEq0zxDGb9H3k/O9EK3slsG5t69l4CK/uEPUvUex2evu/clgQjUxJt6S1Z6vNI pu93W5gx7KaOlMERbjb4jzBNrJ0WFL/tQvysnzKio8ngnd1w+WMaDv0ccqrp4Aj7sZnB BZ5GGhdUPdC0yYzM9WIMshReCsifxDbeYPD1yhmOgBI72qVjjpB1eNW8J+bHxc8pwrUi hbdLHGIAYlDXQ1NYbhjunRhdUtxiJPr0ynrZW7U3VEmkZ+QUFGiNwdegf41owWXAqgLm 0lH1+rQ8uvmttfSga7U9w4Z+2sV3IorN4KahvCS69rASRYPzIOKuZAIZUHbUqmL8pXtR 4+TQ== X-Gm-Message-State: AOAM532M9v7kKirmKkls6BgFmEMppXfHZ+IitParARYoWuMe2Cfw3bC2 sgDzaBgtF1Qn3/C+HgmPby72tw== X-Google-Smtp-Source: ABdhPJxjet3Fft4nPy2UchykKdNnrGWHxB31uPrnPEyWDLwTGsb3FgesECowF9Jy/VDozg8ma6IePQ== X-Received: by 2002:a1c:1d04:: with SMTP id d4mr22807105wmd.156.1593524032982; Tue, 30 Jun 2020 06:33:52 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:52 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 04/10] gpio: gpio-pmic-eic-sprd: Fix incorrectly named property 'map' Date: Tue, 30 Jun 2020 14:33:39 +0100 Message-Id: <20200630133345.2232932-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chunyan Zhang , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Baolin Wang , Orson Zhai , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org A good attempt has been made to properly document 'struct sprd_pmic_eic', but 'map' has been incorrectly described as 'regmap' since the driver's inception in 2018. Fixes the following W=1 kernel build warning: drivers/gpio/gpio-pmic-eic-sprd.c:65: warning: Function parameter or member 'map' not described in 'sprd_pmic_eic' Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Lee Jones Reviewed-by: Baolin Wang --- drivers/gpio/gpio-pmic-eic-sprd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c index 05000cace9b24..9382851905662 100644 --- a/drivers/gpio/gpio-pmic-eic-sprd.c +++ b/drivers/gpio/gpio-pmic-eic-sprd.c @@ -48,7 +48,7 @@ enum { * struct sprd_pmic_eic - PMIC EIC controller * @chip: the gpio_chip structure. * @intc: the irq_chip structure. - * @regmap: the regmap from the parent device. + * @map: the regmap from the parent device. * @offset: the EIC controller's offset address of the PMIC. * @reg: the array to cache the EIC registers. * @buslock: for bus lock/sync and unlock. From patchwork Tue Jun 30 13:33:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633949 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2D75213B6 for ; Tue, 30 Jun 2020 13:35:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAD19206B6 for ; Tue, 30 Jun 2020 13:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D94zgnle"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qgt19lMG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAD19206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=siZIknzeGg1nDpN4UqifR5zjyCk1x+AaLZn7v7epEQU=; b=D94zgnleJCXQL6E+6vw8UnkW2 bAgiueXBvbeJqahcVg248lEHFVmiZWaOySAmGKx9EF76pHkPr9pW0O9TbxcArik0mBHQ+qnw0G56u g7kFtPNDEF+keU2A1bCd6T8oY8cidG4xLoKDdoOo7NCSBHEWl9Azas26m8uJ1to5hQmDVf1tbwlBz MZy0IKSpbq83oD17M5yhRpQDdwD2ShRUdDKf8yviDtXwjy5QgDEb0CKD3W7wvsdthrlVgOjYPZvzk MNingARnd7UjvSlRzER9gNVlpMkufgBfrqqmrmzo6n9e59LXjVZ2bPIl/eP9oCw3LnJTi30WktsS2 n5eZkEvnQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOs-0004JO-L6; Tue, 30 Jun 2020 13:34:15 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOZ-0004E2-1f for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:33:56 +0000 Received: by mail-wm1-x341.google.com with SMTP id f139so19613269wmf.5 for ; Tue, 30 Jun 2020 06:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mVRFyI7gMPSCpFThQPOO71zLy3/PBdN3qWCTPbMiXks=; b=qgt19lMGK+EwYSjtxdGtnfQI+W4/0k5CuiIuR80c/9n/twpmcJ6PiG2Uu1mz5GFFkK AUTe0bdiZWK0juZgx80T2vbTxbfPXM+cjTrYjRQbjmsbmhbS9C0U6/shpZXE6Z5V5DqD KGdB2MA/Ap0lBLfXKNkTY/YevFiJ0KdsreHz/dM9+h2/Gntcfo7AhMM9o4Qb2RLQYdwj 1lfjqrZazfSzDW2nHscL+gd/e+98e4KmtSfApChaUTKTxwYIIDjTGbfIa+VDaUrRtsT5 F9Qv0dpXUaovM1dIRPgj9VJdlruRfLYko0xsY+TucjB+K42meBmljWjWADwwB4WClmzT O8XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mVRFyI7gMPSCpFThQPOO71zLy3/PBdN3qWCTPbMiXks=; b=l3wIoqDY1a8zJslfMAD11BDa5tEtVx9Oa0hj3h+O2DNxOo5ioTO3nimbbNIfNqBYw2 PIYITEbAQmVumKwFkxKNWAKEOlFHKe4mN2oVErcsXGsvc3pcaZp+mwm335AodJFa58kf nd8uo1zO53dhJCXedJR02nBpL+CkaoBkDjbI9TlzSfwKpuK4rChGV78z+2F4pe0YPAzK pP22eiwKueK+mAvWXRxkVVWfvUkf+FsP9nnYkgb7ttxlsjV56WUd7iIerg6IW5PHSpGP Lpu9xhJfk8J6iUj7siOtChMy8biOY/gbY4azInJKTY8TKQKbBJVqX/KJbyWlPrLBGa2M 9c0Q== X-Gm-Message-State: AOAM531d68Y/09aQ5K/AE2aWR58BxZdeye7Hbm+V8UI9h32W3SWAHr9/ Gy/xIg4RKYM+5Fcr3sFW4nZYHA== X-Google-Smtp-Source: ABdhPJwtQjgdwmmsWj1j8nXmCgvlDtGtfE76f3lplQO2CPaJKrzNdygk9VxYczxqVvfWrMamk5G93Q== X-Received: by 2002:a05:600c:2f17:: with SMTP id r23mr20601830wmn.167.1593524034128; Tue, 30 Jun 2020 06:33:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:53 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 05/10] gpio: gpio-sama5d2-piobu: Demote all kerneldoc headers to basic comment blocks Date: Tue, 30 Jun 2020 14:33:40 +0100 Message-Id: <20200630133345.2232932-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrei Stefanescu , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Ludovic Desroches , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to provide proper descriptions for each of the function arguments throughout the file. Simply demote all kerneldoc headers to basic function headers. Fixes the following W=1 kernel build warnings: drivers/gpio/gpio-sama5d2-piobu.c:59: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_setup_pin' drivers/gpio/gpio-sama5d2-piobu.c:59: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_setup_pin' drivers/gpio/gpio-sama5d2-piobu.c:81: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_write_value' drivers/gpio/gpio-sama5d2-piobu.c:81: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_write_value' drivers/gpio/gpio-sama5d2-piobu.c:81: warning: Function parameter or member 'mask' not described in 'sama5d2_piobu_write_value' drivers/gpio/gpio-sama5d2-piobu.c:81: warning: Function parameter or member 'value' not described in 'sama5d2_piobu_write_value' drivers/gpio/gpio-sama5d2-piobu.c:97: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_read_value' drivers/gpio/gpio-sama5d2-piobu.c:97: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_read_value' drivers/gpio/gpio-sama5d2-piobu.c:97: warning: Function parameter or member 'mask' not described in 'sama5d2_piobu_read_value' drivers/gpio/gpio-sama5d2-piobu.c:116: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_get_direction' drivers/gpio/gpio-sama5d2-piobu.c:116: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_get_direction' drivers/gpio/gpio-sama5d2-piobu.c:131: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_direction_input' drivers/gpio/gpio-sama5d2-piobu.c:131: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_direction_input' drivers/gpio/gpio-sama5d2-piobu.c:140: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_direction_output' drivers/gpio/gpio-sama5d2-piobu.c:140: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_direction_output' drivers/gpio/gpio-sama5d2-piobu.c:140: warning: Function parameter or member 'value' not described in 'sama5d2_piobu_direction_output' drivers/gpio/gpio-sama5d2-piobu.c:154: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_get' drivers/gpio/gpio-sama5d2-piobu.c:154: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_get' drivers/gpio/gpio-sama5d2-piobu.c:174: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_set' drivers/gpio/gpio-sama5d2-piobu.c:174: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_set' drivers/gpio/gpio-sama5d2-piobu.c:174: warning: Function parameter or member 'value' not described in 'sama5d2_piobu_set' Cc: Ludovic Desroches Cc: Andrei Stefanescu Signed-off-by: Lee Jones Acked-by: Ludovic Desroches --- drivers/gpio/gpio-sama5d2-piobu.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d2-piobu.c index 4d47b2c411868..b7c9506581701 100644 --- a/drivers/gpio/gpio-sama5d2-piobu.c +++ b/drivers/gpio/gpio-sama5d2-piobu.c @@ -49,7 +49,7 @@ struct sama5d2_piobu { struct regmap *regmap; }; -/** +/* * sama5d2_piobu_setup_pin() - prepares a pin for set_direction call * * Do not consider pin for tamper detection (normal and backup modes) @@ -73,7 +73,7 @@ static int sama5d2_piobu_setup_pin(struct gpio_chip *chip, unsigned int pin) return regmap_update_bits(piobu->regmap, PIOBU_WKPR, mask, 0); } -/** +/* * sama5d2_piobu_write_value() - writes value & mask at the pin's PIOBU register */ static int sama5d2_piobu_write_value(struct gpio_chip *chip, unsigned int pin, @@ -88,7 +88,7 @@ static int sama5d2_piobu_write_value(struct gpio_chip *chip, unsigned int pin, return regmap_update_bits(piobu->regmap, reg, mask, value); } -/** +/* * sama5d2_piobu_read_value() - read the value with masking from the pin's PIOBU * register */ @@ -108,7 +108,7 @@ static int sama5d2_piobu_read_value(struct gpio_chip *chip, unsigned int pin, return val & mask; } -/** +/* * sama5d2_piobu_get_direction() - gpiochip get_direction */ static int sama5d2_piobu_get_direction(struct gpio_chip *chip, @@ -123,7 +123,7 @@ static int sama5d2_piobu_get_direction(struct gpio_chip *chip, GPIO_LINE_DIRECTION_OUT; } -/** +/* * sama5d2_piobu_direction_input() - gpiochip direction_input */ static int sama5d2_piobu_direction_input(struct gpio_chip *chip, @@ -132,7 +132,7 @@ static int sama5d2_piobu_direction_input(struct gpio_chip *chip, return sama5d2_piobu_write_value(chip, pin, PIOBU_DIRECTION, PIOBU_IN); } -/** +/* * sama5d2_piobu_direction_output() - gpiochip direction_output */ static int sama5d2_piobu_direction_output(struct gpio_chip *chip, @@ -147,7 +147,7 @@ static int sama5d2_piobu_direction_output(struct gpio_chip *chip, val); } -/** +/* * sama5d2_piobu_get() - gpiochip get */ static int sama5d2_piobu_get(struct gpio_chip *chip, unsigned int pin) @@ -166,7 +166,7 @@ static int sama5d2_piobu_get(struct gpio_chip *chip, unsigned int pin) return !!ret; } -/** +/* * sama5d2_piobu_set() - gpiochip set */ static void sama5d2_piobu_set(struct gpio_chip *chip, unsigned int pin, From patchwork Tue Jun 30 13:33:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633951 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2DDB0174A for ; Tue, 30 Jun 2020 13:35:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06316206B6 for ; Tue, 30 Jun 2020 13:35:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lJDmUBFC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LDOoBlOc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06316206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1mdlrrjdRJbeP3fy4j7Wx1D+bKN6SxVOAzIg8HFkrI4=; b=lJDmUBFC8KcFNb1QXQPEnz9Yx niQ5UUZ0EkInKatOFZvW4eM9SLQAJxXTAHc86N6K8fHNqHvij4QSOrvhUAwWrX1aESGnPVHEI6unr wjUSlrcdsTrwpxj7HV/aMYSe7rGPdpJqzMFHDPjpILZc+AKcshfba6aEVq78ar+ejv3fJJ9T/OfwQ /JRxFa5P6tQluUQEJWQ0PniI8B3GZAw32Ny5VuDv+Wc3s4TIAT1tIDe0eLA71RASnfZn5m5Qmpcs3 pBxKZg8PukrfTYCTNV7aQU90GHFep1+dTqk1Aw8de2zcrSoNjix2oVU1ocURHwqiODBapZ85RW9zV +YWMy8YTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGP3-0004Mx-Np; Tue, 30 Jun 2020 13:34:26 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOa-0004ER-Nc for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:33:57 +0000 Received: by mail-wr1-x442.google.com with SMTP id z15so8920185wrl.8 for ; Tue, 30 Jun 2020 06:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ed8H2szCHThwNArdetIOxqgfOUbWnaN816hTwHMkdbs=; b=LDOoBlOcdm5PNPBUjDlyXJMjFJoTSFbyLvEFfk2MSUYrchcD9tFEd0BZXO9SrTscoH eA/vQ6GAXtpXOUjef9fBRpi0CJvg8ckXzJXuEz09kLvdNWWqgqE1w+ordm7P5ftaJrHD a0mfbn07kQRfTm7ePl7W2Q76YlUgaNcjabzztkrqEVWKBpwBuKDZpQ0ySSp7J3V99l2j FbzF3FM16U5AgKguFp3o6KOWA4WGAskO5BV+OW1Ott1uuGymscZa01d/Fo66kvqK+Cnd 3apKWuCiSlV53s2VaJ5tXUiP4AQaF9MKFHjnCVFdG0y9wiripankDZXkPRCESZJ47G42 r9QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ed8H2szCHThwNArdetIOxqgfOUbWnaN816hTwHMkdbs=; b=ChJxLh4NwT3BuJJev39UfIxSvB0SzoFSbyI2i5AazBSnsOrrahTrKW8vqY5+xzyqbn H30DGDatczfVrOPCE4xCta21SfLePAKxXq8B2Gzi9H0OtI2NALhJXHMz5jveHUk072QX LqNmkQXiX2MtiPuHLhkI+VnXmAwvqbvLlUnYaxKj9mW7lnJJWXzyQVvpYbMVa1lbUjxL pCftW1K99G26v8me74BEQhohT86dY2xVNEgzE8nCydgojZ/ZFtiuAbL3i4QPkfbMwBDv EwVGytvf9l7PHNJU7FtT4m2r+32cB/TXJ4N1QemcojV5o4DDjlIXkkrJtwAl7L0Q3BgY 5Ugg== X-Gm-Message-State: AOAM533F2AU7+1k87apedLmFLtzZIZnFebLqWnuRzP86vQ5Bz62x5scg jxw/wFgUUzg4y+mshbnWPepDdA== X-Google-Smtp-Source: ABdhPJyIWL/M5/vUrifTjtGsuJrzIOD9u8Z0C8MXhKYor95Ji0p/tqz8z4BB9eU13U9cbdzmuzJG4g== X-Received: by 2002:a05:6000:1006:: with SMTP id a6mr20905598wrx.332.1593524035124; Tue, 30 Jun 2020 06:33:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:54 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 06/10] gpio: gpio-syscon: Fix formatting issues which confuse kerneldoc Date: Tue, 30 Jun 2020 14:33:41 +0100 Message-Id: <20200630133345.2232932-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Alexander Shiyan , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc expects struct properties to be documented using the syntax '@.*: ', but no '@' has been provided in 'struct syscon_gpio_data's header. Add them to stop confusing kerneldoc. Fixes the following W=1 warnings: drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'compatible' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'flags' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'bit_count' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'dat_bit_offset' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'dir_bit_offset' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'set' not described in 'syscon_gpio_data' Cc: Alexander Shiyan Signed-off-by: Lee Jones --- drivers/gpio/gpio-syscon.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 31f332074d7d5..fdd3d497b5350 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -24,16 +24,16 @@ /** * struct syscon_gpio_data - Configuration for the device. - * compatible: SYSCON driver compatible string. - * flags: Set of GPIO_SYSCON_FEAT_ flags: + * @compatible: SYSCON driver compatible string. + * @flags: Set of GPIO_SYSCON_FEAT_ flags: * GPIO_SYSCON_FEAT_IN: GPIOs supports input, * GPIO_SYSCON_FEAT_OUT: GPIOs supports output, * GPIO_SYSCON_FEAT_DIR: GPIOs supports switch direction. - * bit_count: Number of bits used as GPIOs. - * dat_bit_offset: Offset (in bits) to the first GPIO bit. - * dir_bit_offset: Optional offset (in bits) to the first bit to switch + * @bit_count: Number of bits used as GPIOs. + * @dat_bit_offset: Offset (in bits) to the first GPIO bit. + * @dir_bit_offset: Optional offset (in bits) to the first bit to switch * GPIO direction (Used with GPIO_SYSCON_FEAT_DIR flag). - * set: HW specific callback to assigns output value + * @set: HW specific callback to assigns output value * for signal "offset" */ From patchwork Tue Jun 30 13:33:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633959 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2FB9913B6 for ; Tue, 30 Jun 2020 13:36:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFDBE206B6 for ; Tue, 30 Jun 2020 13:36:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rMmVQR6I"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wTYsKZg6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFDBE206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eHbUqjFWyyFDAGNRzRjR213bpli3QblPUk/yqitXJ84=; b=rMmVQR6IItw54ZkbDhVWaq03B NPR3srzyqSrryxRpubAy49rNn1yhJrTss6gThX0sQDwPRfMLQmsawBdFo/QgXDR6vRkBKeh8t7eUT nd7tuTD1q3OYWA7RL+xrzO4VWHyqGkystXTlxDlSChAdMIMj9S29Wg0gNwXrAIXGM0fVCuq9e/gqU 5yjZwO83UnZ+l4v5W+Dcni42vapH82AALFcGlukPSsvmlEq37p4CHGJRHyAlJBYW2Wp0XqBNw+Crv +6FfHi/d3lyPVewb34tHinCJy412VhjAh7t6JVBkDcrBXdK52WkgmsympQ4IQEfN8Fh3TYhx1P8Pz HJb+uvJ7g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGP9-0004QN-7A; Tue, 30 Jun 2020 13:34:31 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOb-0004Eu-3M for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:33:57 +0000 Received: by mail-wm1-x344.google.com with SMTP id o2so19624721wmh.2 for ; Tue, 30 Jun 2020 06:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qg/i7Z+DVHnxMJURbtuvnuqmQ2dblOKzOYHmn2TAyNw=; b=wTYsKZg6XOOwxF3oDluUk1u7aO7yNTj639l5CvuRCOC6RNDIbnTV/IcodT/0pqXNw5 pFneNKZwxITWnSGPM7dh/ReDTHF6g0AZZopWTNoTm3SVu8g3gabrkJMYF+fLUxsCAOtc g2sEqrZ62BMpGwWgQhxIyK1xLKtDhgVq7F4kMmb84oNfW36RuTgAnkrQ2AUiRMYHq5mb 5Z1wMXrCHXX73X50iSEhunoIGLBqslyiYCHs+Ekoh9ShjjyXgkgMDYMdvtVrgjQCiCAw crp4lzcA5lAPU0j8es+fPggZvMOjmHObzD87nJW7VuLRDGYln9cRTzANzvJR6PXgUd8P FLzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qg/i7Z+DVHnxMJURbtuvnuqmQ2dblOKzOYHmn2TAyNw=; b=Tl22epFrbJAkLF9OMQAO9PzOkX4fTpRdqJ7b8FBL8yEALuBjPQh1X2jRcN5v4FUjKq 9yAwS2h/L5aXJZzCqm4gevOvU9tZWFkCsFF7QJmlHK93eGNXW+yXKTddvHWv7/KrkFAA WkN/7iZYE1VwVW6XXc3REJ/FWAYyZht80uY194Hr/uqpn4yuzUSGwcRi9T4EXW0VKy3E lZ16A2c/EIgq3ek0jY/Ri4oXyotIeIhw4Y4AfrHHz/XwlD7fRcUZ3hkxR5ySUw/JGd+Y ZJtwQp6JpkzbtzqKF1wIgVbHupSyETYNEdlyODBV9JYdceT4JeTSxiHiQdjyAVENe2Y6 UQ7g== X-Gm-Message-State: AOAM532yKpW/hc8BQqL9eEnt6mCyC4Gt3ZfEd8pQch3HwNxQF/ismPkC yFWR/IvKh+BfB3G1hRPG6RuM5w== X-Google-Smtp-Source: ABdhPJxuB0GHncTea0p5EeyC3ow+2hK3Kp2Tm41ZPwIkJuIuPL7Leq57W4yxAyWNj5wXl7BWX7g3dQ== X-Received: by 2002:a1c:6102:: with SMTP id v2mr22253807wmb.6.1593524036198; Tue, 30 Jun 2020 06:33:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:55 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 07/10] gpio: gpio-it87: Fix formatting issues which confuse kerneldoc Date: Tue, 30 Jun 2020 14:33:42 +0100 Message-Id: <20200630133345.2232932-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Diego_Elio_Petten=C3=B2?= , linux-gpio@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc expects struct properties to be documented using the syntax '@.*: ', but no ':' has been provided in 'struct it87_gpio's header. Add them to stop confusing kerneldoc. Fixes the following W=1 warnings: drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'chip' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'lock' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'io_base' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'io_size' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'output_base' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'simple_base' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'simple_size' not described in 'it87_gpio' Cc: "Diego Elio Pettenò" Signed-off-by: Lee Jones --- drivers/gpio/gpio-it87.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c index b497a1d18ca9b..8f1be34953ce4 100644 --- a/drivers/gpio/gpio-it87.c +++ b/drivers/gpio/gpio-it87.c @@ -47,13 +47,13 @@ /** * struct it87_gpio - it87-specific GPIO chip - * @chip the underlying gpio_chip structure - * @lock a lock to avoid races between operations - * @io_base base address for gpio ports - * @io_size size of the port rage starting from io_base. - * @output_base Super I/O register address for Output Enable register - * @simple_base Super I/O 'Simple I/O' Enable register - * @simple_size Super IO 'Simple I/O' Enable register size; this is + * @chip: the underlying gpio_chip structure + * @lock: a lock to avoid races between operations + * @io_base: base address for gpio ports + * @io_size: size of the port rage starting from io_base. + * @output_base: Super I/O register address for Output Enable register + * @simple_base: Super I/O 'Simple I/O' Enable register + * @simple_size: Super IO 'Simple I/O' Enable register size; this is * required because IT87xx chips might only provide Simple I/O * switches on a subset of lines, whereas the others keep the * same status all time. From patchwork Tue Jun 30 13:33:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633953 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2FE7113B6 for ; Tue, 30 Jun 2020 13:35:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08DE1206B6 for ; Tue, 30 Jun 2020 13:35:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RdZqJV9/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XwN9XpGG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08DE1206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R6p270Nx1294q+HNz2WM+CGWL87ys8GOsbZodqnh9uo=; b=RdZqJV9/55aPcNas/y/vVhhYp vsIAlWzJiqPj/VP/V4jJYK6cSTn5VautFgFOQ5xIUSEUSBAEDwGOl1W6Ji3OOn2lJuY4lBLMIC+md KqbokgwEljtY/Sse7fyrO3HmjaH3AEg1ntcAgAXtWzjxhvFWvPhWt94lutFWIZsT+pWuodJggIyEm VUsuEc1EmNC4OUlFLFdq6yYz7h5bPN0Pt/PliKIE8q/qQO6cBNFtmeOmVus68GahYPj3aBdB8Jr1r 4uUd4qxxuPIRvPTcLi+xkctFbh1MvFTEB7HNW3tZnMIOPpeB92j0B2pQbJYP3xr6paZqlXOCZON/Y wiNDVr8OA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGPC-0004Rk-Ha; Tue, 30 Jun 2020 13:34:35 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOc-0004F4-3M for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:33:58 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so19613430wmf.5 for ; Tue, 30 Jun 2020 06:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7A8fd8K6Xg2GcpEMDl/hEl1oZDzE0C0aQNCJLDk0izk=; b=XwN9XpGGLLINb9bmDd9M7rq+kabOna2BscILWUe9Ys6KgtxEY+IvgWHLEoz0xXSSe1 tuwsdOmyH6jqNLGgiXb9sxAWHTg8xzvjeuK3NpnVTdmeORXc/6gyDSIH8o1nFbzHzJic 9mxzn+WvbvuC7gCHzWU847yTLCQ9aDVzScRidwsujRs5m/5XB7/akP33NYHmgwaLteWb 5IVrU1IZ+BCLITm0zbvFvVtao1FhFbrp1lU6tlXx+IWW1lpfOnrLK7No9Ji4DgdYUe7k eGwkbeAZy0xAdcYz2AkElYtIHM9E1mzVMV2z+gBLshSbpcRyFtkZNinm5+eXnkBBEgvl UAlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7A8fd8K6Xg2GcpEMDl/hEl1oZDzE0C0aQNCJLDk0izk=; b=qe6rs+E9RRxeBj05MZH2LLEsGHR3WoDsHTq9yhPxBmWR1dpC/WQwq7s1Mweqf/JST6 30ZBeqKM4+uKaSs34hVqpexDOPz4RKFC/hLO81Q30L0Fc/Yo5UMsfv8GrgJ7dpQkmqJ5 kS+CX4EMpEZm08jirmHnJBKWv2aijOZRumNjrMPkihcuzxpF4al32rtEsohBr1EsiTHM M7fQO4cHqWShdO+uM/ODabP+LHaCIK4sNoL5BL4pU3uUN9y+RWyGAVuDyRqpyikckrH8 bfnNR4zZb8cXR9qFvNk/7o3xAAYcpNIz/S6KuA0J91dq7N8LmOjg3UClZ4M+kn2Jbpyp HKXQ== X-Gm-Message-State: AOAM531AvWp854+JNd/mQnyCOGXdWoEVJm8x4HrlvETDsMtjn75pe9EE 8gUS6gaAPd4A63YhHbhCKF2M/g== X-Google-Smtp-Source: ABdhPJynqohsoRrFIShWDkghOLuISD4f4oZVbWRjLzqNeAhn5TwaZv0Qb5XUX2AFsAIp934hGFepEw== X-Received: by 2002:a1c:1bc4:: with SMTP id b187mr22909206wmb.105.1593524037244; Tue, 30 Jun 2020 06:33:57 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:56 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 08/10] gpio: gpio-mlxbf: Tell the compiler that ACPI functions may not be used Date: Tue, 30 Jun 2020 14:33:43 +0100 Message-Id: <20200630133345.2232932-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shravan Kumar Ramani , linux-gpio@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org ... as is the case when !CONFIG_ACPI. Fixes the following W=1 kernel build warning: drivers/gpio/gpio-mlxbf.c:130:36: warning: ‘mlxbf_gpio_acpi_match’ defined but not used [-Wunused-const-variable=] 130 | static const struct acpi_device_id mlxbf_gpio_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Shravan Kumar Ramani Signed-off-by: Lee Jones --- drivers/gpio/gpio-mlxbf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mlxbf.c b/drivers/gpio/gpio-mlxbf.c index 894aaf55fc96c..1fa9973f55b96 100644 --- a/drivers/gpio/gpio-mlxbf.c +++ b/drivers/gpio/gpio-mlxbf.c @@ -127,7 +127,7 @@ static int mlxbf_gpio_resume(struct platform_device *pdev) } #endif -static const struct acpi_device_id mlxbf_gpio_acpi_match[] = { +static const struct acpi_device_id __maybe_unused mlxbf_gpio_acpi_match[] = { { "MLNXBF02", 0 }, {} }; From patchwork Tue Jun 30 13:33:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633957 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D29D813B6 for ; Tue, 30 Jun 2020 13:36:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A611B206B6 for ; Tue, 30 Jun 2020 13:36:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bpJptay0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="b3TJl39h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A611B206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rmlI9PLpdS685uRRmrz4rCSG6yVV2c9SVsAY7ETrLCQ=; b=bpJptay04M7vPZDXD2JKQKVI6 b3gXdvK+sgRiVM86+gxRc97DgqAQssGBcejMChqAT8NSzRYgYxOyhx0/urAwLSrwE4r1pS4+p3Nhr l4eH+PPFdvARXAFSRiJqhu/vzCidOySVuXswFc6w7oVkgzW1kX9yxS9tU0cVqxiiiym1t1DM7rktw Dz6O2Ztdy/tE9toSf69j6hAo/IK8FuBvaB+s+ICiPDjLX0KScpz8IUqUJDYUtjI9Q0nzt3y/ubjYs qwkCcqYJ8xR87dP5+FtLht93DxhOi/5VwV93oCzAdV/DW3WFM8+AnW51mnX58ZMs6VZA4LZI/YMzS xpVN0KJtg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGPG-0004TP-3B; Tue, 30 Jun 2020 13:34:38 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOd-0004FH-KA for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:34:00 +0000 Received: by mail-wr1-x441.google.com with SMTP id f7so17189488wrw.1 for ; Tue, 30 Jun 2020 06:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EdUmnOFS5TbxKtJS43wBP3LOOE3V1mwzgMQ7fgYmUtc=; b=b3TJl39h/HPdI2rcHJlyhWwzcXi/la21VXhkpUf8MYbyH+xEy9gT+dwl26vyTyJJpN TKYzfmEoTP9+Q1yO4ACJSyyqiV5lmloZPd5X1g5PhacwvpOk6vPRbCgx6FvmWqfqnUEx 1JflzHOd2GaJyjWgT2sUZbp2H5sV9YJFC1Oy/2/HkAroipRDUy0VNFU2/35nhrr4XXSd zhCCnXHoaLbQJZO71+qjKO39/0wxT0NlDB7pNBpZbRoIkMdbdDJHxLtqe6ggwn7ejT6o RGd+Kf5hIBNxVTP+yMGrIexXx53Wi7fs0b/59vKSfzaYDlVAcmjdXLooHBLqFC1lFVVR tGlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EdUmnOFS5TbxKtJS43wBP3LOOE3V1mwzgMQ7fgYmUtc=; b=aZKGasruLHnIfP8N6+Nlhb8gWSieoMFu7qknP9udWGk0t9AyHmlk7uLf7+lc0L4acH WH35Yt+1cC+7Y42vePdOLmp7Z8OXo0rJT8c4AF3vhE0Q2fXPweOitxGLiw4c6ge4fFUb 16RJCGeG+bzD17zcPhFuA09uMwxfidfbe4ePSOC9JE68qzwkO2llAq7jmhO8xf47DR8/ yU4A0EiCEcgwbpuAfCgSRfGPruwUUkXqWYF9wWDzuhW6mWbNDL+uNoDhH/9yFqLijTa8 WyZ9ywt9ZXvKY/wJXcuMkTBNk+Pau6Qg1SRGA2q4+p6Q6RXAzaS8akdeUYugPoLyrEL4 8nSw== X-Gm-Message-State: AOAM531heyHlGQmWuBwzazpV4bG74rl/Hj4v3vqeEb+6SLjHLrrUYNtE oGLnodYpg8jy+ashUHjU05THP2v0W5g= X-Google-Smtp-Source: ABdhPJz0CEADFFk8XWxoF3NfWv5G61HuV3p9+cKSio2MeKeDa7JGlGUrYUDZ8uy5pr8X3Nl+M9pn8Q== X-Received: by 2002:a05:6000:11cc:: with SMTP id i12mr21614495wrx.224.1593524038502; Tue, 30 Jun 2020 06:33:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:57 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 09/10] gpio: gpio-mlxbf2: Tell the compiler that ACPI functions may not be use Date: Tue, 30 Jun 2020 14:33:44 +0100 Message-Id: <20200630133345.2232932-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Asmaa Mnebhi , linux-gpio@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org ... as is the case when !CONFIG_ACPI. Fixes the following W=1 kernel build warning: drivers/gpio/gpio-mlxbf2.c:312:36: warning: ‘mlxbf2_gpio_acpi_match’ defined but not used [-Wunused-const-variable=] 312 | static const struct acpi_device_id mlxbf2_gpio_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~~ Cc: Asmaa Mnebhi Signed-off-by: Lee Jones Reviewed-by: Asmaa Mnebhi Signed-off-by: Lee Jones --- drivers/gpio/gpio-mlxbf2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index 94d5efce1721c..861a8d0a84be0 100644 --- a/drivers/gpio/gpio-mlxbf2.c +++ b/drivers/gpio/gpio-mlxbf2.c @@ -309,7 +309,7 @@ static int mlxbf2_gpio_resume(struct platform_device *pdev) } #endif -static const struct acpi_device_id mlxbf2_gpio_acpi_match[] = { +static const struct acpi_device_id __maybe_unused mlxbf2_gpio_acpi_match[] = { { "MLNXBF22", 0 }, {}, }; From patchwork Tue Jun 30 13:33:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11633955 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 54DA113B6 for ; Tue, 30 Jun 2020 13:36:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 162AC206B6 for ; Tue, 30 Jun 2020 13:36:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nCmkopla"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tUr7wg3W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 162AC206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aszNcjHcFF3T7Gm4JbPlr//d7JOPfnB7zigMe/q6fks=; b=nCmkoplaIjK7UNY0Lz/jiQAJ9 InRKWVugePBc1Nz0xIv+7tEtkDsltWG4oIy8ErHwigmpwYV0KgkkbabxmqXxqCGLsCbdCWjj4I9SW Uit5CM3r/+QA0psA6T72QXHOtgAG9VIGkFq/MsFkQmNcTo6MndWucSaTln+yED5XSgCVBwOsbf5xf 7+ffdcw/NQ+19AIoJthtF01uwpVX5KPNV/fK+A+bFiL8j4U8STI7eWm+pEDSYIpPdk1SLwrwYKkct 8MeK2Ly3jhXmzJXvJcLLIps0uu3Cxp6CcB5YYtZmE1hcskMhE0fOfX8zqFCN6KLUuuEj9CiW1X+hc FJcnyO4wg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGPJ-0004V6-3T; Tue, 30 Jun 2020 13:34:41 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGOe-0004FQ-Dr for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:34:01 +0000 Received: by mail-wr1-x444.google.com with SMTP id o11so20199300wrv.9 for ; Tue, 30 Jun 2020 06:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Aqos2NxgL6TqV6vtAHFj09o8FM67bpNGP+lJI0qHUic=; b=tUr7wg3Wznr91hdBXq50eNTGAccm33bM6tBl1CH1AYKPp7JvNXSuZ0fLootAup+nLZ 7xkoMJq1lUn19jzjKvVfTuaHmloQm+V871dkMcRy9T/bH3j7+hJYql6Pv+wj15mhtdHE z+p3HQuk511W60JvRiiE4ZaHUMC3YYw6cpfddvAPSL7oz94GQ5JxL/eIwpYYN7AI7zER 02C7um3AfjHlBzqoZ7eQY2pLhJAu4hgYRRVaj6miRKRa0ZaL2ZCGcKELxqLOX9qJJhcc kU1S0ht8R33R/0IqyPDqJyOcr1Rc3GifN2tOTQKD40fTDw1T9liHtszfTp2Uvn3pJlru HMeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Aqos2NxgL6TqV6vtAHFj09o8FM67bpNGP+lJI0qHUic=; b=qPh4inQlyI0fvkNDG7tfKu7FfyVUhhvpn60lCYtcHNUArYUmz7ZPXH5uvfFzA0Vsam i/GhxJCHLdeVROx9AIogr/Qp7yO0esNPJj4EEGzpMuM5XeHn/xHKleTSu19capFNOO/x IU/IRqdW1WAAo4XXVADcTX/nSrdVUk4zOfD/jYimgY/T3hJdcVZ3Xd0hDHr37ucVvrDN K0TLNdix8QvTKM0sSwvK2reUbjOvKljGCZd/eX3BlFoSGNmbMHg2kAH88i7WdJG0J3XC 2LPBep5z1blu/nT/qO7lY8pRld1ODajqOaXiQMRwptVyK8YAqCrR8JMbTizVKcFSDkHt RZVA== X-Gm-Message-State: AOAM5304T4NDEMT8NS/+7gn3rYJaPzNsLSLgTi15BMZdfZsJm2y8UGDk bMrqC17Bru0lJNIPWRwFy1l2fw== X-Google-Smtp-Source: ABdhPJx9WxsVZ5j6ppbW2LpfgLfGN/iYhXnS9SqvRlEbRO7i3cfvBgwP5qkADNjWMaQO/b1FJ/QXnQ== X-Received: by 2002:a5d:68c7:: with SMTP id p7mr23139275wrw.16.1593524039424; Tue, 30 Jun 2020 06:33:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:58 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH 10/10] gpio: gpio-mlxbf2.c: Provide __releases() annotation to stop confusing Sparse Date: Tue, 30 Jun 2020 14:33:45 +0100 Message-Id: <20200630133345.2232932-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Asmaa Mnebhi , linux-gpio@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Sparse cannot peer into other functions to see when and if locks are acquired and released, thus it simply warns that a 'context imbalance' is detected instead. Let's be kind to Sparse and let it know that this behaviour is intentional. drivers/gpio/gpio-mlxbf2.c:125:12: warning: context imbalance in 'mlxbf2_gpio_lock_acquire' - different lock contexts for basic block drivers/gpio/gpio-mlxbf2.c:151:13: warning: context imbalance in 'mlxbf2_gpio_lock_release' - unexpected unlock Cc: Asmaa Mnebhi Signed-off-by: Lee Jones Reviewed-by: Asmaa Mnebhi Signed-off-by: Lee Jones --- drivers/gpio/gpio-mlxbf2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index 861a8d0a84be0..befa5e1099439 100644 --- a/drivers/gpio/gpio-mlxbf2.c +++ b/drivers/gpio/gpio-mlxbf2.c @@ -149,6 +149,8 @@ static int mlxbf2_gpio_lock_acquire(struct mlxbf2_gpio_context *gs) * Release the YU arm_gpio_lock after changing the direction mode. */ static void mlxbf2_gpio_lock_release(struct mlxbf2_gpio_context *gs) + __releases(&gs->gc.bgpio_lock) + __releases(yu_arm_gpio_lock_param.lock) { writel(YU_ARM_GPIO_LOCK_RELEASE, yu_arm_gpio_lock_param.io); spin_unlock(&gs->gc.bgpio_lock);