From patchwork Wed Jul 1 12:46:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636229 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AB0E314E3 for ; Wed, 1 Jul 2020 12:47:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9326920780 for ; Wed, 1 Jul 2020 12:47:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HJ/om3la" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730676AbgGAMrX (ORCPT ); Wed, 1 Jul 2020 08:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730667AbgGAMrW (ORCPT ); Wed, 1 Jul 2020 08:47:22 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 208A9C03E97E for ; Wed, 1 Jul 2020 05:47:22 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f7so20653371wrw.1 for ; Wed, 01 Jul 2020 05:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8hbNAtKSwUso7F6/Zo5X4haYX63XDsD/59rYslLWqBM=; b=HJ/om3laTlqrN4tbJ+hATe0qObMhqatwVBMmZnGQmvTJIYTLVQz8MxOl73Hvp4WjqF xqUHLf7YHf1hvrtoxKkTPx5vx4baewW61qxzhFuZVeIya9axCarl7l2dViHxrkwleodH dqRvX57EYA4mWlnOc3UXl84JE1fw1eqzsYGqhZglttgGNgeyeTENotbaLBbM3ZJAO6RO W6wL7H1TlNKqrdzCh8F+/x99y+cE9x8koVt002NOvQeOPt78Usfk5Y/7tdSB2HeTaHRe 5DHEEFclRVMMEY0UmZNQW+FvRnf4tsOiigh1L7ZLqnBfpOrsVbnL6LlOLwWrq5rZCYS4 IJAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8hbNAtKSwUso7F6/Zo5X4haYX63XDsD/59rYslLWqBM=; b=CVab0t6mAIo0GKVPP5BkSLmuIf5rs14wsy1K/VsdXLkWHRVmwehwv1iFX/xPWgWYgO XTvBX1iG3BN/p7qv+6hEkRMvNjzKiqlSsTLPSQ+Kg+trql9VMwKDaZBsBXuCrSqfoCtO XLC9zcSpSSqKT7rPwazs6ssThbDQD1h6y33zMeDv1r4j27qfnPXZvYjTdhZ3A0TYC2ZE iKHj4XDW20a4XXcrLi3n2ptNm81XMnnaZsIrRRoSMX4/P0nCQuLwaevuAV8vojSOB90f RWFBCewfHvR3xvL9MxkDK5UfABBllkgzkkq1tvqkSpQKANOp5ZPuonTe4D8dGh4qvfSq qJFg== X-Gm-Message-State: AOAM533xpPEhVoHeWHm62FmU7pWflQX4Gbxksob9cDfbJUI95VVo/m7n 5wTpZ5Jch98q8bLsMiAi/UNb7w== X-Google-Smtp-Source: ABdhPJxaxL/KUxiM37mz4pmYxkZ8JcArmoV2r74oObuQZwBjWSDWoMwdJUFYimiGE/2fmaa9tY0rNA== X-Received: by 2002:a5d:6a07:: with SMTP id m7mr27094488wru.324.1593607640839; Wed, 01 Jul 2020 05:47:20 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:20 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Adrian Hunter , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Subject: [PATCH 12/15] mmc: host: sdhci-msm: Staticify local function sdhci_msm_dump_vendor_regs() Date: Wed, 1 Jul 2020 13:46:59 +0100 Message-Id: <20200701124702.908713-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org sdhci_msm_dump_vendor_regs() is only used via the .dump_vendor_regs() call-back. It is never exported nor used externally, so it can be static. Squashes the following W=1 kernel build warning: drivers/mmc/host/sdhci-msm.c:1887:6: warning: no previous prototype for ‘sdhci_msm_dump_vendor_regs’ [-Wmissing-prototypes] 1887 | void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Adrian Hunter Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/host/sdhci-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index b277dd7fbdb5d..0c02f8a2d11ab 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1884,7 +1884,7 @@ static void sdhci_msm_reset(struct sdhci_host *host, u8 mask) #define SDHCI_MSM_DUMP(f, x...) \ pr_err("%s: " DRIVER_NAME ": " f, mmc_hostname(host->mmc), ## x) -void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) +static void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) { struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host); From patchwork Wed Jul 1 12:47:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636227 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0630B13B4 for ; Wed, 1 Jul 2020 12:47:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0C6520772 for ; Wed, 1 Jul 2020 12:47:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xIDiEYkl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730685AbgGAMr0 (ORCPT ); Wed, 1 Jul 2020 08:47:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730677AbgGAMrX (ORCPT ); Wed, 1 Jul 2020 08:47:23 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3858CC03E979 for ; Wed, 1 Jul 2020 05:47:23 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id o11so23669428wrv.9 for ; Wed, 01 Jul 2020 05:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RppFHH3LPgV9Fbxkc7EFxUD1a+LbYIuGU1AKsrw/uFk=; b=xIDiEYklS6lSZpP6D9pgP0igi/DuLWfHQtgqSxQrazIxDKzatFbofzd5A2lxZECBRp xgjtQ9qigjPm2I9PvVxfMtgVOIO3zEMvCEvi853x8QO6KLsAr0R7mmgVIfL4RruJlql+ xtvfOzVAj5ODP/aWq4ks/9xr7+uRNHZiDwRvvbfKMAlEFVGgBJ4MP7BztMTQk9lB1cy6 pO6NX2PcayLNiR9Ei7AhrqSWZWqG5xjsk2bCLWAueBI1qbYBzRjjcpWOaGChQi+lfluF 84QFziwLTyWWS1h3rphJzHL8TLCaYECg1Le1+RLbeX02xJMNoPAV4Pdm4iq52qPR7Z5X eakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RppFHH3LPgV9Fbxkc7EFxUD1a+LbYIuGU1AKsrw/uFk=; b=YZmU6byh3BeJV0NdzqKHBNym3SQPoAlgwvS+0dw7cnJSS4Q7lx/2MwZlT+QhQXGp5I cZAsmeJmFJNllUN0OwEROyZPbCU/c7PP0Lxa78ibvZusDs8Oyx7t4ajPGdrSScU7RpIo G4asbQZkD/9PZMDNoY+hm89V9sSY+/LeWTDDNZSwYLCGz/8jGK6zhzX2FW08PEGQjHKW W0uQHZ/mljU/qjCyGz09F7F/mIlZIZdoZdjd29TpmKXshyZI1rD7hqN8VwYlzQctvCcE 1yunpX5/v64b1r0FXlu4NIaSZXEMXMUPDzL3wwmXnDO8KGN4Yz98K4vP9/MoGjW7Mn8T fLcg== X-Gm-Message-State: AOAM5318n2tuTDqFeIKixQlJUKo/OksGIG9OJIM606D0giGjJP8N9nK2 tWbKkuwGGO6TdNuJz/89mEHf5A== X-Google-Smtp-Source: ABdhPJyC8rXxEDpXbOyCSZxcsN81UfnduDOhMYWpILYzv9Y/zpJP7ApdbBjcGjp+fUgrrteEcjr51Q== X-Received: by 2002:a5d:6907:: with SMTP id t7mr26577073wru.329.1593607641927; Wed, 01 Jul 2020 05:47:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:21 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Adrian Hunter , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Subject: [PATCH 13/15] mmc: host: sdhci-msm: Demote faux kerneldoc header down to basic comment block Date: Wed, 1 Jul 2020 13:47:00 +0100 Message-Id: <20200701124702.908713-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org __sdhci_msm_set_clock()'s function header is the only one in kerneldoc format. Which seems odd as it's not part of an external API and isn't referenced anywhere else. Seeing as there has also been no attempt to describe the expected function arguments either, we're going to assume that this is not actually a bona fide kerneldoc use-case. Fixes the following W=1 kernel build warnings: drivers/mmc/host/sdhci-msm.c:1595: warning: Function parameter or member 'host' not described in '__sdhci_msm_set_clock' drivers/mmc/host/sdhci-msm.c:1595: warning: Function parameter or member 'clock' not described in '__sdhci_msm_set_clock' Cc: Adrian Hunter Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/host/sdhci-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 0c02f8a2d11ab..7a574fc7635c4 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1583,7 +1583,7 @@ static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host) return SDHCI_MSM_MIN_CLOCK; } -/** +/* * __sdhci_msm_set_clock - sdhci_msm clock control. * * Description: