From patchwork Thu Jul 2 14:46:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639153 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 623AE6C1 for ; Thu, 2 Jul 2020 14:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A5E02089D for ; Thu, 2 Jul 2020 14:49:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rnd7ZVz1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729983AbgGBOtU (ORCPT ); Thu, 2 Jul 2020 10:49:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729968AbgGBOqo (ORCPT ); Thu, 2 Jul 2020 10:46:44 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D1AFC08C5DE for ; Thu, 2 Jul 2020 07:46:43 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 17so28253107wmo.1 for ; Thu, 02 Jul 2020 07:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zCvEYr43bmvAI4c/u02EnPe5wklhcOBr52WpV3Wdhnc=; b=rnd7ZVz1ZhbElscG9Bkyx7lA4/DyNELrmIlS9pFIxHeR0jZ64UUgjYI7/xmq7V/nBQ ZjeYBcOXpxnMVFhStvkm3qSrrk39Vbmp5EY9GY7i2drA52md+rN3AH5t9d8r0TgeFZNz tw/ORXRpXc9E6zjDPBTC35hNIHMr+7X2+Bt/wd9jC/lvPleiDxFGAMeKNMn6tZwOKAMw +Fr6OtBOW8Ck2cXOQadIEhvAe9qMjojndUc9IB+nRn8EfKDQNJv3QpZ+jbkkt3DrMn/x Qq4i23HE176PnzXDn8TVDQOGIPyiW8rEvw2ymMaPpVPUI/C+iiH4DcU3ekAl1SEKJ2/j EL8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zCvEYr43bmvAI4c/u02EnPe5wklhcOBr52WpV3Wdhnc=; b=qEJLDrA/2u4xpwk9mXpz6pcaRixeY4IaN3lDwh2pKd2nb683FKiaooz5gCT5Y6EPn4 t3sI9Z+pueSOo6wpZjj1MF0Uqj5unS69JkIJuxqS8yWx3yUyRtPdMxEYA4yG20DG1Qlx E6+mC7e+hSi0sa7ANOWFPKJeS2mSw/p3E1lcuV6LGEPEAf3mCoJBdG2gguoi1y1vdbge 9AnvwBMcMAfkpLNpi3eKikkqi83hriNqpgUgVpHCQtKiY+dGgflU+5ZeY3Nb8XU2bkAT cjKWepnc0re96d53FSm5mUxfgq5t4kWwwuyLViCaq44f79iRfuV8rwE0uY4w5itW80hs iohA== X-Gm-Message-State: AOAM532oFVnDm3QjBnEPuPDdXVmcGjRNGVSL86PPb2L7UnJo3aeoQf5E 4bIVoOetHi1oSffdDOHJTfOsgQ== X-Google-Smtp-Source: ABdhPJxTZlxUGKYXKggwnjvqFMcBCaf45y5q+liL9GM89JskjMNjlM3bEhXyNhYs3yNR7dMSBMPRZA== X-Received: by 2002:a1c:cc12:: with SMTP id h18mr30459205wmb.3.1593701202335; Thu, 02 Jul 2020 07:46:42 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:41 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Andrzej Siewior , linux-omap@vger.kernel.org Subject: [PATCH 08/30] usb: dwc3: dwc3-omap: Do not read DMA status Date: Thu, 2 Jul 2020 15:46:03 +0100 Message-Id: <20200702144625.2533530-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Commit af566a0be6e49 ("usb: dwc3: omap: get rid of dma_status") rendered reading DMA status from the H/W even more redundant. The variable hasn't been read/used since 2016. Remove the set but unused variable and the call which populates it. Fixes the following W=1 warning: drivers/usb/dwc3/dwc3-omap.c: In function ‘dwc3_omap_probe’: drivers/usb/dwc3/dwc3-omap.c:460:8: warning: variable ‘reg’ set but not used [-Wunused-but-set-variable] 460 | u32 reg; | ^~~ Cc: Felipe Balbi Cc: Andrzej Siewior Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/usb/dwc3/dwc3-omap.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index 8c3de2d258bf7..11288a370828c 100644 --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb/dwc3/dwc3-omap.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * dwc3-omap.c - OMAP Specific Glue layer * * Copyright (C) 2010-2011 Texas Instruments Incorporated - http://www.ti.com @@ -457,8 +457,6 @@ static int dwc3_omap_probe(struct platform_device *pdev) int ret; int irq; - u32 reg; - void __iomem *base; if (!node) { @@ -503,9 +501,6 @@ static int dwc3_omap_probe(struct platform_device *pdev) dwc3_omap_map_offset(omap); dwc3_omap_set_utmi_mode(omap); - /* check the DMA Status */ - reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG); - ret = dwc3_omap_extcon_register(omap); if (ret < 0) goto err1; From patchwork Thu Jul 2 14:46:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639093 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 41D516C1 for ; Thu, 2 Jul 2020 14:46:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 272A0208B8 for ; Thu, 2 Jul 2020 14:46:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D272CbLl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730001AbgGBOqu (ORCPT ); Thu, 2 Jul 2020 10:46:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729991AbgGBOqt (ORCPT ); Thu, 2 Jul 2020 10:46:49 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60863C08C5DD for ; Thu, 2 Jul 2020 07:46:48 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f18so28295144wml.3 for ; Thu, 02 Jul 2020 07:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PqDEsV0Ck+FNcXivlLFCVSGlGxhukzNkii5C/yRAQ+E=; b=D272CbLlqYE9XwhTGGNkOy3kKTQob4ZwxsVME5EGX5gMkHXxZcrMA1pMr8s9YEl6MV PGGJD1O6CzfIreM5GJPlte1v7+CCoZ6DW5if1ZQjQbLpw0NMcNcxUqFggpHYGovppt05 Cwx8Zkwsbkpf35qf8zMBgrMa4evocB4C6NwHMM/guVMeL+4hjxo+Xg+EXB3bMjlt3l6j QE14ppYiN/fYozy+KORlSqwt2sa3qJRfhpq5gSM91UDZ0cP+tWUmsa/CuiQ3k/uaGsd+ FLaClHPAo2mrk9SSnnR1xL8UXMJp+fTT5P2nNXpna2sBIAUz6nMX8ImmgM8fZBOW6cyG BYfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PqDEsV0Ck+FNcXivlLFCVSGlGxhukzNkii5C/yRAQ+E=; b=UvP+ebUUZ5CxncVQFBFIyNfMCtC7KfSJ8DGwkWlExFtpCwgqsNVu57hbV3FvNAuNvW lYeV1yxOAVIlXNk9UGWcf8lN/hkVdesr1yLTRdQ8GZ9+8BVOzRr3qsGefcULmmt/+q0w LbqN20Uo/HE2ssPJTFGP7H7eD0AiIVes4cjbADOnFEmTuLc1KZTd2skeqiviyL3aFF39 KHmChULJ5+D8QoSjhvyZOddQ7gLuDISnFxhV8H+F2EwnDRekSvZCofY2IFyhqIW9WpCC r/dZvluc3tKCb0uD6P8gIUqtSBw/4Y2Fk2AG6rxUDJgeLrl0AvpCtOa4+icc2vm1qm34 Ebag== X-Gm-Message-State: AOAM532kdoUBnz3/sZCCLuPNnnhc8kN7Y9BR2oWauPBuTPapOnzz1wHV NzaTa7s+X3BVIUex8uQcTpjdDw== X-Google-Smtp-Source: ABdhPJzVNf36Ya/k9DJuBz/EJ9+MpHowcfEHl6qa1yClZCcdX++IxMz5yyGSGjVqzQDKr0VxrpsqQA== X-Received: by 2002:a1c:81c1:: with SMTP id c184mr6925584wmd.120.1593701207158; Thu, 02 Jul 2020 07:46:47 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:46 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Alan Stern , Vikram Pandita , Anand Gadiyar , Keshava Munegowda , Roger Quadros , Felipe Balbi , linux-omap@vger.kernel.org Subject: [PATCH 12/30] usb: host: ehci-omap: Provide documentation for ehci_hcd_omap_probe()'s arg 'pdev' Date: Thu, 2 Jul 2020 15:46:07 +0100 Message-Id: <20200702144625.2533530-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Description for 'pdev' argument was missing from the function header. Fixes the following W=1 warning: drivers/usb/host/ehci-omap.c:87: warning: Function parameter or member 'pdev' not described in 'ehci_hcd_omap_probe' Cc: Alan Stern Cc: Vikram Pandita Cc: Anand Gadiyar Cc: Keshava Munegowda Cc: Roger Quadros Cc: Felipe Balbi Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/usb/host/ehci-omap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index fc125b3d06e7d..2ec686e28582a 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c @@ -78,6 +78,7 @@ static const struct ehci_driver_overrides ehci_omap_overrides __initconst = { /** * ehci_hcd_omap_probe - initialize TI-based HCDs + * @pdev: Pointer to this platform device's information * * Allocates basic resources for this USB host controller, and * then invokes the start() method for the HCD associated with it