From patchwork Fri Jul 3 17:41:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642521 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 225BD6C1 for ; Fri, 3 Jul 2020 17:44:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 091F72084C for ; Fri, 3 Jul 2020 17:44:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DiTMT+9T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726345AbgGCRmB (ORCPT ); Fri, 3 Jul 2020 13:42:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbgGCRl7 (ORCPT ); Fri, 3 Jul 2020 13:41:59 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B470C08C5DD for ; Fri, 3 Jul 2020 10:41:59 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l2so33372431wmf.0 for ; Fri, 03 Jul 2020 10:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YSysemk6/m3rdKU2ySMi9uU8qYuK0kuhW6Pw5qHpSnI=; b=DiTMT+9THBotFZ8hAPsnuIbDSlmH+WPn87U6MQV2wdUqBmGs3uF0tKCXEfU7478vwj hwRiHYDh4JpRpasNgymyRlZRKZYPomrYM9TJPmqWfJcxMLGduvnehwmmmjtysVHuv640 iQFbD58SHTQRqL/gBV171cuR8/WTeYhTRVk7h0EI46cXLbxvMZRbUIA5L7SH2rCkEbw6 NET+ildSzhaQAlJxNoSvdavC9aTyR7AzdS74FkZ+BefFZx0zPt+xwBXdSFYStsHg0rDd ky0+csRp4oiOhk+Bjw68pqKMRSCnHLd+2J+YF8NR5NMSJyMbowwOIgMWQhjToihJ5crY Azhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YSysemk6/m3rdKU2ySMi9uU8qYuK0kuhW6Pw5qHpSnI=; b=ZV8MoVGz3eUNC/rNj5S++KSvpXWJ6psZyBVtP7NgrQo82VlzbsVHBv7vaQMbLi8Yad z8froIra3elLihf0ZCek6P7e1yiO179LVkReLRHO8TKtqKeC+IDdExYzFxr0r0e6EnhS x09/o5mzXkBijlw+wYqk5gJmafl+8nnzJB3f1NrUrpaI0ePCS0rwsIrGYFmoLCDxhmjF DQHeSvG+EUy1sf+WNVRroHNJp2kd72/l3KVx+wIlewgQWw+a4TyHRu4Z1azD8uRA5gCF aA9aXlgPY2JaFQ02IOgogAQtus1QrMwpMkiYHL/YIvEnhQ1RW1OVRFGEyF20sOYFXsi2 PMUw== X-Gm-Message-State: AOAM532MZuFLZAtq4dZv1Unw0JLYHX5PeYcVV/xipfU8kfe/F+U/wPUN zkduZa2WhKdr9TnLAwtZhX3uPA== X-Google-Smtp-Source: ABdhPJwq6EJ8i4c07CyyjVONmZU0HR1br30HC+HrU3hY5Q/iNyS39dh2n8CRaJSQcQXq5fDuEcoNRg== X-Received: by 2002:a1c:9a02:: with SMTP id c2mr8726718wme.16.1593798117749; Fri, 03 Jul 2020 10:41:57 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:41:57 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Chunfeng Yun , linux-mediatek@lists.infradead.org Subject: [PATCH 01/30] usb: mtu3: mtu3_debug: Add forward declaration of 'struct ssusb_mtk' Date: Fri, 3 Jul 2020 18:41:19 +0100 Message-Id: <20200703174148.2749969-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Without it, the build system complains that it was declared inside the parameter list. Fixes the following W=1 kernel build warning(s): In file included from drivers/usb/mtu3/mtu3_trace.c:11: drivers/usb/mtu3/mtu3_debug.h:29:36: warning: ‘struct ssusb_mtk’ declared inside parameter list will not be visible outside of this definition or declaration 29 | void ssusb_dev_debugfs_init(struct ssusb_mtk *ssusb); | ^~~~~~~~~ drivers/usb/mtu3/mtu3_debug.h:30:35: warning: ‘struct ssusb_mtk’ declared inside parameter list will not be visible outside of this definition or declaration 30 | void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb); | ^~~~~~~~~ drivers/usb/mtu3/mtu3_debug.h:31:39: warning: ‘struct ssusb_mtk’ declared inside parameter list will not be visible outside of this definition or declaration 31 | void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb); | ^~~~~~~~~ drivers/usb/mtu3/mtu3_debug.h:32:39: warning: ‘struct ssusb_mtk’ declared inside parameter list will not be visible outside of this definition or declaration 32 | void ssusb_debugfs_remove_root(struct ssusb_mtk *ssusb); | ^~~~~~~~~ Cc: Chunfeng Yun Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/usb/mtu3/mtu3_debug.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/mtu3/mtu3_debug.h b/drivers/usb/mtu3/mtu3_debug.h index fb6b28277c9b1..3084c46017c37 100644 --- a/drivers/usb/mtu3/mtu3_debug.h +++ b/drivers/usb/mtu3/mtu3_debug.h @@ -12,6 +12,8 @@ #include +struct ssusb_mtk; + #define MTU3_DEBUGFS_NAME_LEN 32 struct mtu3_regset { From patchwork Fri Jul 3 17:41:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642447 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E12EE6C1 for ; Fri, 3 Jul 2020 17:42:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C716A2084C for ; Fri, 3 Jul 2020 17:42:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oPyrB8Pi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726573AbgGCRmF (ORCPT ); Fri, 3 Jul 2020 13:42:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726425AbgGCRmB (ORCPT ); Fri, 3 Jul 2020 13:42:01 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43E19C08C5DD for ; Fri, 3 Jul 2020 10:42:01 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id g75so32747479wme.5 for ; Fri, 03 Jul 2020 10:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GH9kLkzHctUtpjzMG5uKy/EUP0KmLjkarK3Zyi+F734=; b=oPyrB8PidDxQT0BDJL8ttUMskiiCjdZZjs3FWjc7sJiQ3GTGABuuowxYHEb4PXYO9R oUuXo2ZFCkIhfpc5FiL95BvY5X6H8sYdqjL+mtb7hHzsc5+VWC3YCMEvMqjGFbMZZtaG c0W+rgRjDKk9CsLqqPh94NHRplYLc6no40CMSS2sqVsosXrilmdr4P4sTUGhyv3MvAFi vSXEuHkzSkqfzBV05NAGb4G7gjUg4oLd7gld3YYCk6nJ6wyrZcO8NIGoeATjlSR43iDM sW57euHO4YC6uPitM6vEsxyXp4WxMo/dVFUtPPoeuuSx3jG9FAR8gNR65w2CAGjEPmjw QVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GH9kLkzHctUtpjzMG5uKy/EUP0KmLjkarK3Zyi+F734=; b=HzJw6JZTG+vmtnHRvo4iyQ1v4mInZEtm6H3AzLfeY0qdzpdxmM2I2K8FB8rFXioxUq ExsQcncDC8iMERKAJHQpYjFUJMv+IDHNWAQfQZ11+uXfsNJUO5cjealpTn2KlJAiSBX1 yh+pIqSWtZiSu2F14JTZv+aFiWWV1ON6bbDD3RvYMe0LEBsGjJ9NKZgfAMTlwiMDKWFg PI8nNWAEOnuTWCNRIOIAEflyWf5DlwBvLG1bO9mV7kGEtLpkzs5d/nuymz96rW9Or3bv M2ec+4b2+wQOwmSdLNE0SnavSq0s3PTRN6mWySsvku84NwTeJdawdJggfZNK1W+J5u57 KcOg== X-Gm-Message-State: AOAM533eFlUTHMIWjEVxzfy7GfiqRznrwMxcJFf71I5aC10dYIbeLem8 6IJO9tA5MEBfZyqQEQ80v0jaVA== X-Google-Smtp-Source: ABdhPJyR175xQdUE3YbXopU3B0c7WCXx8R0l/TMeTSCdkdTrAkW/AeSsiuMDCeOhzYob4uQ7e/uQvw== X-Received: by 2002:a05:600c:c1:: with SMTP id u1mr38510987wmm.48.1593798119975; Fri, 03 Jul 2020 10:41:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:41:59 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Alan Stern , Kukjin Kim , Krzysztof Kozlowski , Roman Weissgaerber , David Brownell , Christopher Hoover , Ben Dooks , linux-samsung-soc@vger.kernel.org Subject: [PATCH 02/30] usb: host: ohci-s3c2410: Demote obvious misuse of kerneldoc to standard comment block Date: Fri, 3 Jul 2020 18:41:20 +0100 Message-Id: <20200703174148.2749969-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document the function here. Fixes the following W=1 kernel build warning(s): drivers/usb/host/ohci-s3c2410.c:356: warning: Function parameter or member 'dev' not described in 'ohci_hcd_s3c2410_probe' Cc: Alan Stern Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Roman Weissgaerber Cc: David Brownell Cc: Christopher Hoover Cc: Ben Dooks Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/usb/host/ohci-s3c2410.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb/host/ohci-s3c2410.c index d961097c90f0e..de5e570c58bae 100644 --- a/drivers/usb/host/ohci-s3c2410.c +++ b/drivers/usb/host/ohci-s3c2410.c @@ -343,7 +343,7 @@ ohci_hcd_s3c2410_remove(struct platform_device *dev) return 0; } -/** +/* * ohci_hcd_s3c2410_probe - initialize S3C2410-based HCDs * Context: !in_interrupt() * From patchwork Fri Jul 3 17:41:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642517 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C567814B7 for ; Fri, 3 Jul 2020 17:44:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC2CD2145D for ; Fri, 3 Jul 2020 17:44:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V678svqB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726418AbgGCRmE (ORCPT ); Fri, 3 Jul 2020 13:42:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726479AbgGCRmD (ORCPT ); Fri, 3 Jul 2020 13:42:03 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCC54C061794 for ; Fri, 3 Jul 2020 10:42:02 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id z15so22287399wrl.8 for ; Fri, 03 Jul 2020 10:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oUjHYg6XEDC1PONs5ecYCAMD6hQ6HUyQ5SfKo5ZoAoI=; b=V678svqBj5ZEzdGJKB69Vodq9pQ31EIwBoLQP1As6lWOXIP/1kJzIqJLjtOvblSkXy MGxl0iGDkHU0uljNJKGH03hr+d07Q2Snp4haL9GaJ2ECnEqfljKwL6ibxma86kajreu8 TA9jvVxRARz9NQU8MvUH+6tDKzsNjuSpnqk6vImwQ4hXw35BuvZcyA+zSVh6APrv+3AX gmXxT3q/ZYNpFS1sGomuuZ5QRj5DfnK67GvuVpvUsP0YzvhguEnTqDR0J/QZNL57ZKIP TYqim9pcfdfTLug72OqEjJojTk83E5F+sCUgu8ZcofVXsYiA6JFIbxmSDf8sHNsVMx8a K4oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oUjHYg6XEDC1PONs5ecYCAMD6hQ6HUyQ5SfKo5ZoAoI=; b=HiokKQmK65Ad4shgr9GKuJPLgBIoqjjTA/EUVTwJkDXraru1DCSphfyiRwzGLYZOmd Imyf+xOUCzintrCjTmwa/JymYOHMxNzIQtEQjCkuVCebsjCD+rkwfIB+6Q+tbbIHV7H7 qNS1nfDpp//o6SZmnbTCtDjQSviTqlu22I6+ndX9n0PRxY2ZliuFHtPo2gfsfBQBIrkT jeF5CjmTOKJT6XBmgJNhPVnv/j1VA1KI1eqlXfp+sPJVIoWxSgN81p8VeiynVRB7wAVT R9FMGgwZws3nIeOT5DdV+W4a6aysemrunxczDjYt0EWajc8xg74g2Ke26uO6O6i5tD2j x8Tw== X-Gm-Message-State: AOAM531yXYLbD372oPN2SDM47+ggHd2vPSbHcPg+3A5OJ77YIiWxcP9T 4BOxpQyeoiSFJWkrpJ8nQ5yhdQ== X-Google-Smtp-Source: ABdhPJzGvTblYJ7UXyonhX71xr+CGK3bV2MNNRAwpzZl2DyxwAc9szCyt2n/Ezh4sar6tAoDQOPNeA== X-Received: by 2002:adf:f2c5:: with SMTP id d5mr38704827wrp.96.1593798121551; Fri, 03 Jul 2020 10:42:01 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:00 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH 03/30] usb: core: ledtrig-usbport: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 3 Jul 2020 18:41:21 +0100 Message-Id: <20200703174148.2749969-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/core/ledtrig-usbport.c:42: warning: Function parameter or member 'usbport_data' not described in 'usbport_trig_usb_dev_observed' drivers/usb/core/ledtrig-usbport.c:42: warning: Function parameter or member 'usb_dev' not described in 'usbport_trig_usb_dev_observed' drivers/usb/core/ledtrig-usbport.c:71: warning: Function parameter or member 'usbport_data' not described in 'usbport_trig_update_count' drivers/usb/core/ledtrig-usbport.c:131: warning: Function parameter or member 'usbport_data' not described in 'usbport_trig_port_observed' drivers/usb/core/ledtrig-usbport.c:131: warning: Function parameter or member 'usb_dev' not described in 'usbport_trig_port_observed' drivers/usb/core/ledtrig-usbport.c:131: warning: Function parameter or member 'port1' not described in 'usbport_trig_port_observed' Cc: Rafał Miłecki Signed-off-by: Lee Jones --- drivers/usb/core/ledtrig-usbport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core/ledtrig-usbport.c b/drivers/usb/core/ledtrig-usbport.c index c12ac56606c3f..ba371a24ff781 100644 --- a/drivers/usb/core/ledtrig-usbport.c +++ b/drivers/usb/core/ledtrig-usbport.c @@ -34,7 +34,7 @@ struct usbport_trig_port { * Helpers ***************************************/ -/** +/* * usbport_trig_usb_dev_observed - Check if dev is connected to observed port */ static bool usbport_trig_usb_dev_observed(struct usbport_trig_data *usbport_data, @@ -64,7 +64,7 @@ static int usbport_trig_usb_dev_check(struct usb_device *usb_dev, void *data) return 0; } -/** +/* * usbport_trig_update_count - Recalculate amount of connected matching devices */ static void usbport_trig_update_count(struct usbport_trig_data *usbport_data) @@ -123,7 +123,7 @@ static const struct attribute_group ports_group = { * Adding & removing ports ***************************************/ -/** +/* * usbport_trig_port_observed - Check if port should be observed */ static bool usbport_trig_port_observed(struct usbport_trig_data *usbport_data, From patchwork Fri Jul 3 17:41:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642449 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5F814159A for ; Fri, 3 Jul 2020 17:42:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D3CD2100A for ; Fri, 3 Jul 2020 17:42:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NdK2n2Dp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgGCRmG (ORCPT ); Fri, 3 Jul 2020 13:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbgGCRmF (ORCPT ); Fri, 3 Jul 2020 13:42:05 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C7E1C08C5DD for ; Fri, 3 Jul 2020 10:42:05 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id g75so32747639wme.5 for ; Fri, 03 Jul 2020 10:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t4Am4nB0l6cP03MwwNkPBQsYcEgNEnrA8UeKSYDKdUU=; b=NdK2n2DpMxDOF3DrquKU3xkbiaC9YSoi1d1FCLkUoMBOFz7LyhxtRa5hIwjvHXSg47 2hj1oK9S3I/+Kng2StiX0zC9Y7zR3jPg2QVPIq1X/apTA4LJyWyJ9mGwV29FHN15HANq cDVZuk8e3w8uyDN5GGNWw1IiLARZwflj49XLSPMJZjCMHJxDaJ+vFt5dUwOtgqtt6W89 WGjG4NBHIfTm888o4wKdLUL9aXBmw15h/qP9v4mBFll4tKxsht+vg9gkHkkhFiZxonrs OMROdPKaEZbbjfgXsdQOoSuSYKsCv8nd++hNVUHEIKIrlpJHzhDT1c2H3BtGlDU2X3x1 xkqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t4Am4nB0l6cP03MwwNkPBQsYcEgNEnrA8UeKSYDKdUU=; b=ZtgTgSrWgRX+YG1vf56MzjB0irEj6IHHZrKyAxm5juZQTeGXB9jS3kCMu1ngwtOHt4 j++dqc7o43eC0ZhpbB4NabAkzVPd6O6WyFTEXs54JAqUy+5ek84wzqxrGxYGacpBid/y PBxsAifeuEfIgi17NGOOn2yvJIoStRDbQ2wzwAiwWpzEda6Dne5uaw/AE5c1+cBXmJK/ 1D9CG8wb9EXDEIfTwbd0xMbkSdm6z5Jv358EXxBAkegWvUe98Dn5eOX1WuTNuYL2VbuI WhSwObSHWMCijIrf9C1jU8OhAzkdGgwso3O/lFd28HzKf9CzaYZ3UBVHKacNlznNS9Y6 zJHw== X-Gm-Message-State: AOAM533upQXCpexqRkFfkU0PusVCL5nRpoxRbhwFsyisGNkrCPAuJ+vA pn4nGD5X+F5F28y4c/jeTfv67rRfz0c= X-Google-Smtp-Source: ABdhPJwWNtPJkU57QkS7FkAUeMOZ01OWI1HHJuuDPjgWzvxvHzyMhCp3R2bITuvinyJ3dvhktbgg+g== X-Received: by 2002:a1c:7d54:: with SMTP id y81mr38985778wmc.110.1593798123829; Fri, 03 Jul 2020 10:42:03 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:03 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Thomas Winischhofer Subject: [PATCH 04/30] usb: misc: sisusbvga: sisusb_init: Mark all 'static const' arrays as __maybe_unused Date: Fri, 3 Jul 2020 18:41:22 +0100 Message-Id: <20200703174148.2749969-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org drivers/usb/misc/sisusbvga/sisusb_init.h is included by a few source files. Most of which do not use the majority of the shared static const arrays which have been declared. This causes the build system to spew 100's of warnings. Fixes the following W=1 kernel build warning(s) - and a whole lot more: In file included from drivers/usb/misc/sisusbvga/sisusb.c:54: drivers/usb/misc/sisusbvga/sisusb_init.h:695:34: warning: ‘SiSUSB_VCLKData’ defined but not used [-Wunused-const-variable=] 695 | static const struct SiS_VCLKData SiSUSB_VCLKData[] = { | ^~~~~~~~~~~~~~~ [10's of lines snipped] drivers/usb/misc/sisusbvga/sisusb_init.h:206:28: warning: ‘SiS_VGA_DAC’ defined but not used [-Wunused-const-variable=] 206 | static const unsigned char SiS_VGA_DAC[] = { | ^~~~~~~~~~~ [10's of lines snipped] drivers/usb/misc/sisusbvga/sisusb_init.h:171:29: warning: ‘ModeIndex_1280x1024’ defined but not used [-Wunused-const-variable=] 171 | static const unsigned short ModeIndex_1280x1024[] = { 0x3a, 0x4d, 0x00, 0x65 }; | ^~~~~~~~~~~~~~~~~~~ [10's of lines snipped] Cc: Thomas Winischhofer Signed-off-by: Lee Jones --- drivers/usb/misc/sisusbvga/sisusb_init.h | 66 ++++++++++++------------ 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/usb/misc/sisusbvga/sisusb_init.h b/drivers/usb/misc/sisusbvga/sisusb_init.h index aa33bc81ee526..927956d33e4d1 100644 --- a/drivers/usb/misc/sisusbvga/sisusb_init.h +++ b/drivers/usb/misc/sisusbvga/sisusb_init.h @@ -148,29 +148,29 @@ #define SIS_CRT2_PORT_04 0x04 - 0x30 /* Mode numbers */ -static const unsigned short ModeIndex_320x200[] = { 0x59, 0x41, 0x00, 0x4f }; -static const unsigned short ModeIndex_320x240[] = { 0x50, 0x56, 0x00, 0x53 }; -static const unsigned short ModeIndex_400x300[] = { 0x51, 0x57, 0x00, 0x54 }; -static const unsigned short ModeIndex_512x384[] = { 0x52, 0x58, 0x00, 0x5c }; -static const unsigned short ModeIndex_640x400[] = { 0x2f, 0x5d, 0x00, 0x5e }; -static const unsigned short ModeIndex_640x480[] = { 0x2e, 0x44, 0x00, 0x62 }; -static const unsigned short ModeIndex_720x480[] = { 0x31, 0x33, 0x00, 0x35 }; -static const unsigned short ModeIndex_720x576[] = { 0x32, 0x34, 0x00, 0x36 }; -static const unsigned short ModeIndex_768x576[] = { 0x5f, 0x60, 0x00, 0x61 }; -static const unsigned short ModeIndex_800x480[] = { 0x70, 0x7a, 0x00, 0x76 }; -static const unsigned short ModeIndex_800x600[] = { 0x30, 0x47, 0x00, 0x63 }; -static const unsigned short ModeIndex_848x480[] = { 0x39, 0x3b, 0x00, 0x3e }; -static const unsigned short ModeIndex_856x480[] = { 0x3f, 0x42, 0x00, 0x45 }; -static const unsigned short ModeIndex_960x540[] = { 0x1d, 0x1e, 0x00, 0x1f }; -static const unsigned short ModeIndex_960x600[] = { 0x20, 0x21, 0x00, 0x22 }; -static const unsigned short ModeIndex_1024x768[] = { 0x38, 0x4a, 0x00, 0x64 }; -static const unsigned short ModeIndex_1024x576[] = { 0x71, 0x74, 0x00, 0x77 }; -static const unsigned short ModeIndex_1152x864[] = { 0x29, 0x2a, 0x00, 0x2b }; -static const unsigned short ModeIndex_1280x720[] = { 0x79, 0x75, 0x00, 0x78 }; -static const unsigned short ModeIndex_1280x768[] = { 0x23, 0x24, 0x00, 0x25 }; -static const unsigned short ModeIndex_1280x1024[] = { 0x3a, 0x4d, 0x00, 0x65 }; +static const unsigned short __maybe_unused ModeIndex_320x200[] = { 0x59, 0x41, 0x00, 0x4f }; +static const unsigned short __maybe_unused ModeIndex_320x240[] = { 0x50, 0x56, 0x00, 0x53 }; +static const unsigned short __maybe_unused ModeIndex_400x300[] = { 0x51, 0x57, 0x00, 0x54 }; +static const unsigned short __maybe_unused ModeIndex_512x384[] = { 0x52, 0x58, 0x00, 0x5c }; +static const unsigned short __maybe_unused ModeIndex_640x400[] = { 0x2f, 0x5d, 0x00, 0x5e }; +static const unsigned short __maybe_unused ModeIndex_640x480[] = { 0x2e, 0x44, 0x00, 0x62 }; +static const unsigned short __maybe_unused ModeIndex_720x480[] = { 0x31, 0x33, 0x00, 0x35 }; +static const unsigned short __maybe_unused ModeIndex_720x576[] = { 0x32, 0x34, 0x00, 0x36 }; +static const unsigned short __maybe_unused ModeIndex_768x576[] = { 0x5f, 0x60, 0x00, 0x61 }; +static const unsigned short __maybe_unused ModeIndex_800x480[] = { 0x70, 0x7a, 0x00, 0x76 }; +static const unsigned short __maybe_unused ModeIndex_800x600[] = { 0x30, 0x47, 0x00, 0x63 }; +static const unsigned short __maybe_unused ModeIndex_848x480[] = { 0x39, 0x3b, 0x00, 0x3e }; +static const unsigned short __maybe_unused ModeIndex_856x480[] = { 0x3f, 0x42, 0x00, 0x45 }; +static const unsigned short __maybe_unused ModeIndex_960x540[] = { 0x1d, 0x1e, 0x00, 0x1f }; +static const unsigned short __maybe_unused ModeIndex_960x600[] = { 0x20, 0x21, 0x00, 0x22 }; +static const unsigned short __maybe_unused ModeIndex_1024x768[] = { 0x38, 0x4a, 0x00, 0x64 }; +static const unsigned short __maybe_unused ModeIndex_1024x576[] = { 0x71, 0x74, 0x00, 0x77 }; +static const unsigned short __maybe_unused ModeIndex_1152x864[] = { 0x29, 0x2a, 0x00, 0x2b }; +static const unsigned short __maybe_unused ModeIndex_1280x720[] = { 0x79, 0x75, 0x00, 0x78 }; +static const unsigned short __maybe_unused ModeIndex_1280x768[] = { 0x23, 0x24, 0x00, 0x25 }; +static const unsigned short __maybe_unused ModeIndex_1280x1024[] = { 0x3a, 0x4d, 0x00, 0x65 }; -static const unsigned char SiS_MDA_DAC[] = { +static const unsigned char __maybe_unused SiS_MDA_DAC[] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, 0x15, @@ -181,7 +181,7 @@ static const unsigned char SiS_MDA_DAC[] = { 0x3F, 0x3F, 0x3F, 0x3F, 0x3F, 0x3F, 0x3F, 0x3F }; -static const unsigned char SiS_CGA_DAC[] = { +static const unsigned char __maybe_unused SiS_CGA_DAC[] = { 0x00, 0x10, 0x04, 0x14, 0x01, 0x11, 0x09, 0x15, 0x00, 0x10, 0x04, 0x14, 0x01, 0x11, 0x09, 0x15, 0x2A, 0x3A, 0x2E, 0x3E, 0x2B, 0x3B, 0x2F, 0x3F, @@ -192,7 +192,7 @@ static const unsigned char SiS_CGA_DAC[] = { 0x2A, 0x3A, 0x2E, 0x3E, 0x2B, 0x3B, 0x2F, 0x3F }; -static const unsigned char SiS_EGA_DAC[] = { +static const unsigned char __maybe_unused SiS_EGA_DAC[] = { 0x00, 0x10, 0x04, 0x14, 0x01, 0x11, 0x05, 0x15, 0x20, 0x30, 0x24, 0x34, 0x21, 0x31, 0x25, 0x35, 0x08, 0x18, 0x0C, 0x1C, 0x09, 0x19, 0x0D, 0x1D, @@ -203,7 +203,7 @@ static const unsigned char SiS_EGA_DAC[] = { 0x2A, 0x3A, 0x2E, 0x3E, 0x2B, 0x3B, 0x2F, 0x3F }; -static const unsigned char SiS_VGA_DAC[] = { +static const unsigned char __maybe_unused SiS_VGA_DAC[] = { 0x00, 0x10, 0x04, 0x14, 0x01, 0x11, 0x09, 0x15, 0x2A, 0x3A, 0x2E, 0x3E, 0x2B, 0x3B, 0x2F, 0x3F, 0x00, 0x05, 0x08, 0x0B, 0x0E, 0x11, 0x14, 0x18, @@ -216,12 +216,12 @@ static const unsigned char SiS_VGA_DAC[] = { 0x0B, 0x0C, 0x0D, 0x0F, 0x10 }; -static const struct SiS_St SiSUSB_SModeIDTable[] = { +static const struct SiS_St __maybe_unused SiSUSB_SModeIDTable[] = { {0x03, 0x0010, 0x18, 0x02, 0x02, 0x00, 0x01, 0x03, 0x40}, {0xff, 0x0000, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00} }; -static const struct SiS_StResInfo_S SiSUSB_StResInfo[] = { +static const struct SiS_StResInfo_S __maybe_unused SiSUSB_StResInfo[] = { {640, 400}, {640, 350}, {720, 400}, @@ -229,7 +229,7 @@ static const struct SiS_StResInfo_S SiSUSB_StResInfo[] = { {640, 480} }; -static const struct SiS_ModeResInfo SiSUSB_ModeResInfo[] = { +static const struct SiS_ModeResInfo __maybe_unused SiSUSB_ModeResInfo[] = { {320, 200, 8, 8}, /* 0x00 */ {320, 240, 8, 8}, /* 0x01 */ {320, 400, 8, 8}, /* 0x02 */ @@ -266,7 +266,7 @@ static const struct SiS_ModeResInfo SiSUSB_ModeResInfo[] = { {960, 600, 8, 16} /* 0x21 */ }; -static const struct SiS_StandTable SiSUSB_StandTable[] = { +static const struct SiS_StandTable __maybe_unused SiSUSB_StandTable[] = { /* MD_3_400 - mode 0x03 - 400 */ { 0x50, 0x18, 0x10, 0x1000, @@ -297,7 +297,7 @@ static const struct SiS_StandTable SiSUSB_StandTable[] = { } }; -static const struct SiS_Ext SiSUSB_EModeIDTable[] = { +static const struct SiS_Ext __maybe_unused SiSUSB_EModeIDTable[] = { {0x2e, 0x0a1b, 0x0101, SIS_RI_640x480, 0x00, 0x00, 0x05, 0x05, 0x08, 2}, /* 640x480x8 */ {0x2f, 0x0a1b, 0x0100, SIS_RI_640x400, 0x00, 0x00, 0x05, 0x05, 0x10, 0}, /* 640x400x8 */ {0x30, 0x2a1b, 0x0103, SIS_RI_800x600, 0x00, 0x00, 0x07, 0x06, 0x00, 3}, /* 800x600x8 */ @@ -376,7 +376,7 @@ static const struct SiS_Ext SiSUSB_EModeIDTable[] = { {0xff, 0x0000, 0x0000, 0, 0x00, 0x00, 0x00, 0x00, 0x00, -1} }; -static const struct SiS_Ext2 SiSUSB_RefIndex[] = { +static const struct SiS_Ext2 __maybe_unused SiSUSB_RefIndex[] = { {0x085f, 0x0d, 0x03, 0x05, 0x05, 0x30, 800, 600, 0x40, 0x00, 0x00}, /* 0x0 */ {0x0067, 0x0e, 0x04, 0x05, 0x05, 0x30, 800, 600, 0x40, 0x00, 0x00}, /* 0x1 */ {0x0067, 0x0f, 0x08, 0x48, 0x05, 0x30, 800, 600, 0x40, 0x00, 0x00}, /* 0x2 */ @@ -434,7 +434,7 @@ static const struct SiS_Ext2 SiSUSB_RefIndex[] = { {0xffff, 0x00, 0x00, 0x00, 0x00, 0x00, 0, 0, 0, 0x00, 0x00} }; -static const struct SiS_CRT1Table SiSUSB_CRT1Table[] = { +static const struct SiS_CRT1Table __maybe_unused SiSUSB_CRT1Table[] = { {{0x2d, 0x27, 0x28, 0x90, 0x2c, 0x80, 0xbf, 0x1f, 0x9c, 0x8e, 0x8f, 0x96, 0xb9, 0x30, 0x00, 0x00, 0x00}}, /* 0x0 */ @@ -692,7 +692,7 @@ static const struct SiS_CRT1Table SiSUSB_CRT1Table[] = { 0x41}} /* 0x54 */ }; -static const struct SiS_VCLKData SiSUSB_VCLKData[] = { +static const struct SiS_VCLKData __maybe_unused SiSUSB_VCLKData[] = { {0x1b, 0xe1, 25}, /* 0x00 */ {0x4e, 0xe4, 28}, /* 0x01 */ {0x57, 0xe4, 31}, /* 0x02 */ From patchwork Fri Jul 3 17:41:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642461 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8EFD114B7 for ; Fri, 3 Jul 2020 17:42:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78EA420B80 for ; Fri, 3 Jul 2020 17:42:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vxZsHJwv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbgGCRm1 (ORCPT ); Fri, 3 Jul 2020 13:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726639AbgGCRmG (ORCPT ); Fri, 3 Jul 2020 13:42:06 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 851D2C08C5DD for ; Fri, 3 Jul 2020 10:42:06 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o8so32744464wmh.4 for ; Fri, 03 Jul 2020 10:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=As8A0RVzBKjotvgXeoxk2ZtBQ/Bg0sCNtYggCVfAltY=; b=vxZsHJwvvgk09IRk1MBBvInd06xDFaXaJSvUjtd1st5QBwE7HyMKZH7jepYLljpcQg zUHRMk04EnmsYB1tHOAEOToKbahfZNCxa2IgNpGUJzAY8RUNWCNGf5YJiWejTxgPu1E/ 0DNDIRZTdlSOPBhE42KiXRHEn84U1+zcJqILDik1LWMAVQR4OwHllAkevRZJAAxCxPdY Yrs0IHBWbngpyzHbb5g2+htPJdQxKakwoR0jr3Mtt3yPL6c8ag7wc5DkOdqUDX/rJBUU oD+k+3a0jVUSk5VbS3zeYPCF2xo/5RD7A7aQnMB21Z+a6om5KhL9zryyYKpkaJlLrsFB AacA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=As8A0RVzBKjotvgXeoxk2ZtBQ/Bg0sCNtYggCVfAltY=; b=lkqIqDsKPmoOjWx+3rsjbyZ4I5ZRv8GAbo3aDrXnhVydlBO6xMuV9kN4rjdUdF8K5G ibr9w+x+8UPY558XZQIcnRlNnTTSSqjw69VNp10vQrAIB2kADQ0RPmlwapDOHAnYQkCM tQH+blRRzbvrAtyxng1wfyhxrm8RyvpLUpSz8xgGZfgUS54Qrh5O3QnAT06x8B2jGzyH fRCa45QtRsr9u0IwTJ1UK6FS6fy+hhDGQVC+cX97xhgTgG5Jw65hHle8ZDUl3PzYHHwk +/88RnisZTwYTriKiiL/MTBJaruyo1H7D1N6erDoKqsWDqL3880FvnJ5n3uYoZ913o9C htBA== X-Gm-Message-State: AOAM533Mepohr79IS4pHVOhM767EuWLtqlPMcAjLkdy28ldPR89GxIdg bxcM6CNfnAsttjbl5TBDTcQwnw== X-Google-Smtp-Source: ABdhPJwolAxrC9FaOIOAI5J97mqd3etXuXAGwhxu+GQ5gnBfEv/QxrYF0gQrtBPhDn4CwIqSE6hE0g== X-Received: by 2002:a1c:398b:: with SMTP id g133mr36495525wma.76.1593798125273; Fri, 03 Jul 2020 10:42:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:04 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Matthieu CASTET , Stanislaw Gruszka , Damien Bergamini Subject: [PATCH 05/30] usb: atm: ueagle-atm: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 3 Jul 2020 18:41:23 +0100 Message-Id: <20200703174148.2749969-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/atm/ueagle-atm.c:578: warning: Function parameter or member 'usb' not described in 'uea_send_modem_cmd' drivers/usb/atm/ueagle-atm.c:578: warning: Function parameter or member 'addr' not described in 'uea_send_modem_cmd' drivers/usb/atm/ueagle-atm.c:578: warning: Function parameter or member 'size' not described in 'uea_send_modem_cmd' drivers/usb/atm/ueagle-atm.c:578: warning: Function parameter or member 'buff' not described in 'uea_send_modem_cmd' drivers/usb/atm/ueagle-atm.c:679: warning: Function parameter or member 'usb' not described in 'uea_load_firmware' drivers/usb/atm/ueagle-atm.c:679: warning: Function parameter or member 'ver' not described in 'uea_load_firmware' Cc: Matthieu CASTET Cc: Stanislaw Gruszka Cc: Damien Bergamini Signed-off-by: Lee Jones --- drivers/usb/atm/ueagle-atm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index e9fed9a887377..786299892c7f4 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c @@ -570,7 +570,7 @@ MODULE_PARM_DESC(annex, #define LOAD_INTERNAL 0xA0 #define F8051_USBCS 0x7f92 -/** +/* * uea_send_modem_cmd - Send a command for pre-firmware devices. */ static int uea_send_modem_cmd(struct usb_device *usb, @@ -672,7 +672,7 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry, uea_leaves(usb); } -/** +/* * uea_load_firmware - Load usb firmware for pre-firmware devices. */ static int uea_load_firmware(struct usb_device *usb, unsigned int ver) From patchwork Fri Jul 3 17:41:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642451 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 365406C1 for ; Fri, 3 Jul 2020 17:42:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ECD8208FE for ; Fri, 3 Jul 2020 17:42:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y2SU5Y10" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgGCRmJ (ORCPT ); Fri, 3 Jul 2020 13:42:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726670AbgGCRmI (ORCPT ); Fri, 3 Jul 2020 13:42:08 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DF90C061794 for ; Fri, 3 Jul 2020 10:42:07 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f2so5597603wrp.7 for ; Fri, 03 Jul 2020 10:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F6U6du2cLEW6hsEFJ/YlMHhYAq991XScHIIikwh94ck=; b=Y2SU5Y10snNBVm4aLkU7fk0EzfCxFtMtC2t6XTYj/cZvEvyIk4JHi4IzvP1Q84NMJb wp3/StQ4VnPEvn10ZvSQjYAQoaEXHwEQT4aUyHcryjLofn34gYEQYBX9KR5uIygZqkN6 c8U7oJkzVqsT/LFEegC/GHVUwFXrl2/ZhWuLrxRxPNjIUcCh5M1zV79xpQ30M6cB6ga7 QWgSinALKbHXOtbxbW8M3V/Iiah/Cu+ACH7HTP3WaFgoG4gBY45UTg5GU2giIEBzvnLg iBZ1Uq8pwToe0JQnN0zwI96iPtfuryHBRuGoe5iyK5uIGgRfcs1vA3hqc87ZlrAGsbuR pCCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F6U6du2cLEW6hsEFJ/YlMHhYAq991XScHIIikwh94ck=; b=p9C8iNUP+rrOR5cQ/BzhDhaqocKHy/ek10j8FanYlRQr7x5vBrGHcFOhmBWjXtXKrV SsYnKMr+XjluHlGkq3kTZhQecycYgx1YiMXsoUBspx+Svi3SyumfIDqGP/2DBpxPZWvf 0PQVn1H5uxwnLFnNfwBg+x8gw/iwlU79dpuBTHMfqiuJNK9c6NlNwjmFGyr4D8n6i4sA 46EtwQnPSNfLVjyJmMUCX/2uxAf4bSx+cSc0YIRrtmt05gRv1CCITe5ZGQpVeNkYuLAI pZ2DbLiodlddA8fh9eC2ZsiGoDA41k+M2Of4aMBnJy0rAW9FbV8OoJiCeLflde3Co99E MXFw== X-Gm-Message-State: AOAM531z9DeaBMpGtb2ZgzcbmdL9iVxHV1miJy9ZUTrdpIDoCexf66oW XTNBzV1f0pwlH37luZmvS74slQ== X-Google-Smtp-Source: ABdhPJzRUz7YIJkc5rXRh4EaTG+LenxNZrmqTf7CVLD+POjSpAcpZFSCLy+UvmQirb+yuYnlUSpq1g== X-Received: by 2002:adf:fcc5:: with SMTP id f5mr41966929wrs.60.1593798126416; Fri, 03 Jul 2020 10:42:06 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:05 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Johan Hovold , David Glance , Juergen Stuber Subject: [PATCH 06/30] usb: misc: adutux: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 3 Jul 2020 18:41:24 +0100 Message-Id: <20200703174148.2749969-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/misc/adutux.c:117: warning: Function parameter or member 'dev' not described in 'adu_abort_transfers' drivers/usb/misc/adutux.c:653: warning: Function parameter or member 'interface' not described in 'adu_probe' drivers/usb/misc/adutux.c:653: warning: Function parameter or member 'id' not described in 'adu_probe' drivers/usb/misc/adutux.c:762: warning: Function parameter or member 'interface' not described in 'adu_disconnect' Cc: Johan Hovold Cc: David Glance Cc: Juergen Stuber Signed-off-by: Lee Jones --- drivers/usb/misc/adutux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index d8d157c4c271d..a7eefe11f31aa 100644 --- a/drivers/usb/misc/adutux.c +++ b/drivers/usb/misc/adutux.c @@ -109,7 +109,7 @@ static inline void adu_debug_data(struct device *dev, const char *function, function, size, size, data); } -/** +/* * adu_abort_transfers * aborts transfers and frees associated data structures */ @@ -642,7 +642,7 @@ static struct usb_class_driver adu_class = { .minor_base = ADU_MINOR_BASE, }; -/** +/* * adu_probe * * Called by the usb core when a new device is connected that it thinks @@ -753,7 +753,7 @@ static int adu_probe(struct usb_interface *interface, return retval; } -/** +/* * adu_disconnect * * Called by the usb core when the device is removed from the system. From patchwork Fri Jul 3 17:41:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642457 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 327E46C1 for ; Fri, 3 Jul 2020 17:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 172122100A for ; Fri, 3 Jul 2020 17:42:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YxY130Fy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726710AbgGCRmL (ORCPT ); Fri, 3 Jul 2020 13:42:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbgGCRmJ (ORCPT ); Fri, 3 Jul 2020 13:42:09 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4CE7C08C5DD for ; Fri, 3 Jul 2020 10:42:08 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id g10so11353197wmc.1 for ; Fri, 03 Jul 2020 10:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rg3aFGb8OfRKBHM94n8q4FN1ZasqFE+4EzVqNDg7yKc=; b=YxY130FyIPR9Gm07AHbGYOGYZ5uDSYNgEhKE/C8aNhqL0yl8qgwg6rJUkdr2CCU2YW AtopIVNMNXMk47KxDB72Sj9A0L+dPsHtfXJA12sLuN2SWhKv+LkgOVOmMbDdpCr2Br75 OmCUEdF/2uQ58MLoN0jVA4nrwnOU7TVriTfuR2ggV0OueDEdCv0f27/TDEJKITw+vl2c X9eJHC4Z6ZZC594uHVV1hjOQpMWfai3gaKh2m+Map4HqjdepflZHEKdAbyCzC0gpr14j MBKxodujMzGU+ZAD48XZM8Gx6heyNRAfAjRvj9Z2FUJNpiG/EVBOcsd+KbZYw2BG6Rnw t5+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rg3aFGb8OfRKBHM94n8q4FN1ZasqFE+4EzVqNDg7yKc=; b=s1GIcb2+ZyRi9JNWyVjgVnDSxYjWd9/odM57UW4LLnL5tctZnKtosA2IEA2whaOcS6 +cIJ8+Marf4IxZYmSmNyjyjSJS9/ryhFon2y/2r58Ts9Rvb76Es4YpmWNp1sDwGR5KoI oBfnhvEUQukCl/3XboiBCfqdrb4h+nfm6kQUdQjHiTPxkPwCAtgnqMvltPed795DOZRi VKpiIMzhzlinoxpQZKbyol27qdj4KNBtnjIjXHxGbI8U4te7MWXzNhO2l03Dwxnzxoqm du3FgV8sCeD82Yb3MzPWN3ocf0v3Oyy23q08ozgMbwfqX+KU3nSwjAAmm0cUfWwTvwHm mZGQ== X-Gm-Message-State: AOAM532gwzC0IgZmg5NK1T/ZkbpFXpPNcJ+DpRnWz/4NeYhUYuD4szD2 7ZpDoDmHJWINR4DURwrx+WSBIA== X-Google-Smtp-Source: ABdhPJy+9vIk0iVFK825nCyPVCUC0qAi9muP8YyXvlu55JUrNIhVbPA9fpJn844SKSTCo2SOUdiiIg== X-Received: by 2002:a7b:c5c1:: with SMTP id n1mr39360654wmk.21.1593798127542; Fri, 03 Jul 2020 10:42:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:06 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Peter Chen , David Lopo Subject: [PATCH 07/30] usb: chipidea: core: Document hw_port_test_set()'s missing 'ci' argument Date: Fri, 3 Jul 2020 18:41:25 +0100 Message-Id: <20200703174148.2749969-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/core.c:163: warning: Function parameter or member 'ci' not described in 'hw_port_test_set' Cc: Peter Chen Cc: David Lopo Signed-off-by: Lee Jones --- drivers/usb/chipidea/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 9a7c53d09ab4f..1016596532a9e 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -155,6 +155,7 @@ u32 hw_read_intr_status(struct ci_hdrc *ci) /** * hw_port_test_set: writes port test mode (execute without interruption) + * @ci: the controller * @mode: new value * * This function returns an error code From patchwork Fri Jul 3 17:41:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642459 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 68E006C1 for ; Fri, 3 Jul 2020 17:42:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50E6B2100A for ; Fri, 3 Jul 2020 17:42:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oiU0dmtO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726795AbgGCRmY (ORCPT ); Fri, 3 Jul 2020 13:42:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbgGCRmL (ORCPT ); Fri, 3 Jul 2020 13:42:11 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71481C061794 for ; Fri, 3 Jul 2020 10:42:11 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o2so34856099wmh.2 for ; Fri, 03 Jul 2020 10:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xjIIWeYNclz40pA7bk2Qh3oqQG2tAVOyN4aYQkn6OiY=; b=oiU0dmtOVMkBf6TzSeh/ny3md+5yRm4OM/IM4zkiiOFwgo/Qi47cQKLIay8N30COvv nFCgi9+MuTJUdQoM+EYjFAVSSXHFDahthwfrL2L0uG8tX9INuhlJ7/cmRhrmdxrLtuFz oJKhV9g+/B0+eQoFWwl2PcOTlD1idbOo5vbWQavXnyYORLwCMEqSIw3W8buDHcalnHaF MERyReX3fR+NEYYYVX4PHBzMSPy0uiKfTR+qpcIAq0s5oyM5UQiVkJVZ3hVqKAq+kN3d XFrtBQe2kaUyEK2PovU4zqVElnVtkGu+bfCfgt47nCsd0sAKqBjbKOLLmRrOqVDszAd0 jxjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xjIIWeYNclz40pA7bk2Qh3oqQG2tAVOyN4aYQkn6OiY=; b=NMed4P5V0IznYkyM8vQlcrmaVOIrqBX2Xxl+QgVqloUqJDOQgQ9ysQ9okhJlqBVlKv 54yscTA0ZU+ckB1tdJEuqHf6Wx3vgUip08RYjgaZjWJj98eAC0t54Bj4RUV3A3JxVXBo /NzwGlgg8ySAfE9xjzVmdf7GD5RV+i6uOsFjMRCXtSWqHdrRkQm5VLprTHf5l2DlxUUJ iy2Riqh/hiZSOd34pXpKUb90ENgJht9rzHKoUuQi43VsSe2qJNoG/4wANLgncIEwWTt9 vvtDAJ6tMn5ZBQqOWz74sPAkEIP7alFRYQd4cg029+vKIUyDBzrQnUeH4g50LAb6Cddj aFIA== X-Gm-Message-State: AOAM532euzcGfryMP02NsqdyEpZB+KQ0b3u6YUFAUREeu6l1n5/COL4I TkjWwM4glvRBtTFxTgjqPFbwzA== X-Google-Smtp-Source: ABdhPJw4mjZPthdniRStWHtZC5npFeRT01E/oMZEzrllITbRXHeQCaCUndaY9yDxanGEL4ylb/oaYg== X-Received: by 2002:a7b:c14a:: with SMTP id z10mr36486119wmi.19.1593798130185; Fri, 03 Jul 2020 10:42:10 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:09 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Felipe Balbi Subject: [PATCH 08/30] usb: gadget: udc: core: Fix a bunch of kerneldoc misdemeanours Date: Fri, 3 Jul 2020 18:41:26 +0100 Message-Id: <20200703174148.2749969-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Firstly, file headers should not be in kerneldoc format. Function args should be in the format '@.*: '. We also take the time to add some descriptions for various argument which have been previously left out. Finally we remove descriptions for absent arguments. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/core.c:25: warning: Incorrect use of kernel-doc format: * struct usb_udc - describes one usb device controller drivers/usb/gadget/udc/core.c:36: warning: cannot understand function prototype: 'struct usb_udc ' drivers/usb/gadget/udc/core.c:901: warning: Function parameter or member 'ep' not described in 'usb_gadget_giveback_request' drivers/usb/gadget/udc/core.c:901: warning: Function parameter or member 'req' not described in 'usb_gadget_giveback_request' drivers/usb/gadget/udc/core.c:1098: warning: Function parameter or member 'udc' not described in 'usb_gadget_udc_stop' drivers/usb/gadget/udc/core.c:1098: warning: Excess function parameter 'gadget' description in 'usb_gadget_udc_stop' drivers/usb/gadget/udc/core.c:1098: warning: Excess function parameter 'driver' description in 'usb_gadget_udc_stop' Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/core.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 2e28dde8376f6..16790c02a530c 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * udc.c - Core UDC Framework * * Copyright (C) 2010 Texas Instruments @@ -23,11 +23,11 @@ /** * struct usb_udc - describes one usb device controller - * @driver - the gadget driver pointer. For use by the class code - * @dev - the child device to the actual controller - * @gadget - the gadget. For use by the class code - * @list - for use by the udc class driver - * @vbus - for udcs who care about vbus status, this value is real vbus status; + * @driver: the gadget driver pointer. For use by the class code + * @dev: the child device to the actual controller + * @gadget: the gadget. For use by the class code + * @list: for use by the udc class driver + * @vbus: for udcs who care about vbus status, this value is real vbus status; * for udcs who do not care about vbus status, this value is always true * * This represents the internal data structure which is used by the UDC-class @@ -891,6 +891,9 @@ EXPORT_SYMBOL_GPL(usb_gadget_unmap_request); /** * usb_gadget_giveback_request - give the request back to the gadget layer + * @ep: the endpoint to be used with with the request + * @req: the request being given back + * * Context: in_interrupt() * * This is called by device controller drivers in order to return the @@ -1084,8 +1087,7 @@ static inline int usb_gadget_udc_start(struct usb_udc *udc) /** * usb_gadget_udc_stop - tells usb device controller we don't need it anymore - * @gadget: The device we want to stop activity - * @driver: The driver to unbind from @gadget + * @udc: The UDC to be stopped * * This call is issued by the UDC Class driver after calling * gadget driver's unbind() method. From patchwork Fri Jul 3 17:41:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642455 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 45EFA6C1 for ; Fri, 3 Jul 2020 17:42:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EB52208FE for ; Fri, 3 Jul 2020 17:42:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wq2eX9jG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbgGCRmP (ORCPT ); Fri, 3 Jul 2020 13:42:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbgGCRmO (ORCPT ); Fri, 3 Jul 2020 13:42:14 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29741C08C5DD for ; Fri, 3 Jul 2020 10:42:14 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 17so34829939wmo.1 for ; Fri, 03 Jul 2020 10:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xrkMNgFq6kjSqpaCA+XSVAlQbJi5HEny4uddp4894Fo=; b=wq2eX9jGfiXqkmXfLTj6mEEM2DpZg01ZXm7M/28lM017rbrQHv08Hx3W5hVLkdvmFs cvQdic5dr1Kq+Q9SQvJOlJ0Um9yIR+Y5uLRgIgCiIyPKB+8SrlN67FMkH9I8POq9Tl99 +hMw+MdBOJx/zy0bvat2TNmCBkFSWbZmsToJ9vMSa5EOAXM8Car+SJkpsfivOXFgNdE/ 6OAuqi/2/eHEu3UadPeyfjssCvcTNhCKm7ljorj8hYXKdL8F5lln2bdGPwryANInysfn p6uUI7Z/tSUbPtLZ/HmaXeu93dZ6mryZK5EOYSHV/jxy8VcCQlvYpf7cgzBj9yLjwsAv LKiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xrkMNgFq6kjSqpaCA+XSVAlQbJi5HEny4uddp4894Fo=; b=egOevl8YZesA9Ue5xLj6GPPe4KKH/swab7rC/mK9tOEwfAH+UnAIVEmWWjWbyUJW7V DMByuoG+BvPsvLHDiJ8XeJBY26iT3v3cSuvVdNypmfRhKys8xg1fzmz3uOXAI3TIQr+y 1v63+xWKWzGcOwBrPbkhOQBoV+6Fec606IEWrqHZqO68KZtv4QseNcvBHytZ6e006Gs1 Ezf79eduFQ3bzjTYy/LCyF3JEiXbRa3eeMw6Ra5jkd2RjZNmW0tkmMyL3Z7KXevu8uW2 XQCayGOMaKfR+mKist0eS9//OIJBWfUTUEHDX6xhEFVH1xEljOE4Vl/XmX5lYJwM79iF PWig== X-Gm-Message-State: AOAM5314qRHNqqTzspYeBmi57ISVZyxpkyFo0u91ioiUz+aQeRjmwlHJ ogoyWSddI+g8OFPr3lXgASwRbg== X-Google-Smtp-Source: ABdhPJxF4+w/X3XbjJY6K8JuqOts4/0aCaGlb0DEvCdqQgBeAb0DrB1QpZ3cPKmGntf65MNAAWWkgQ== X-Received: by 2002:a7b:c041:: with SMTP id u1mr39858082wmc.56.1593798132797; Fri, 03 Jul 2020 10:42:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:12 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Peter Chen Subject: [PATCH 09/30] usb: chipidea: otg: Fix kerneldoc issues relating to description of 'ci' Date: Fri, 3 Jul 2020 18:41:27 +0100 Message-Id: <20200703174148.2749969-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Firstly we add some missing descriptions. Then we fix some formatting issues. Kerneldoc expects arguments to be in the format '@.*: '. If either the '@' or ':' is omitted, kerneldoc gets confused. Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/otg.c:29: warning: Function parameter or member 'ci' not described in 'hw_read_otgsc' drivers/usb/chipidea/otg.c:82: warning: Function parameter or member 'ci' not described in 'hw_write_otgsc' drivers/usb/chipidea/otg.c:235: warning: Function parameter or member 'ci' not described in 'ci_hdrc_otg_init' drivers/usb/chipidea/otg.c:254: warning: Function parameter or member 'ci' not described in 'ci_hdrc_otg_destroy' Cc: Peter Chen Signed-off-by: Lee Jones --- drivers/usb/chipidea/otg.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c index be63924ea82ef..d3aada3ce7ec2 100644 --- a/drivers/usb/chipidea/otg.c +++ b/drivers/usb/chipidea/otg.c @@ -23,6 +23,7 @@ /** * hw_read_otgsc returns otgsc register bits value. + * @ci: the controller * @mask: bitfield mask */ u32 hw_read_otgsc(struct ci_hdrc *ci, u32 mask) @@ -75,6 +76,7 @@ u32 hw_read_otgsc(struct ci_hdrc *ci, u32 mask) /** * hw_write_otgsc updates target bits of OTGSC register. + * @ci: the controller * @mask: bitfield mask * @data: to be written */ @@ -229,7 +231,7 @@ static void ci_otg_work(struct work_struct *work) /** * ci_hdrc_otg_init - initialize otg struct - * ci: the controller + * @ci: the controller */ int ci_hdrc_otg_init(struct ci_hdrc *ci) { @@ -248,7 +250,7 @@ int ci_hdrc_otg_init(struct ci_hdrc *ci) /** * ci_hdrc_otg_destroy - destroy otg struct - * ci: the controller + * @ci: the controller */ void ci_hdrc_otg_destroy(struct ci_hdrc *ci) { From patchwork Fri Jul 3 17:41:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642463 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 398EC6C1 for ; Fri, 3 Jul 2020 17:42:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 205B92145D for ; Fri, 3 Jul 2020 17:42:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t2+CoUJs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbgGCRmd (ORCPT ); Fri, 3 Jul 2020 13:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726801AbgGCRmb (ORCPT ); Fri, 3 Jul 2020 13:42:31 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 977F0C061794 for ; Fri, 3 Jul 2020 10:42:31 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id q15so32756185wmj.2 for ; Fri, 03 Jul 2020 10:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qi+0OF4ODQNxSO8LjvEMR71lEcthMzByu7Tr2x6qWes=; b=t2+CoUJs3bBmjlIR70pAcQdTHlv4TviWf+b2aA4YJe6LJeTqVDlg5vwidfJj6CBS8l Oc6IOSVUnLsIh6PdyDYr1ELmexj4PMuORbBHyUQXFoDAv+Vzrd6snchLVIi4QGuPfEX0 BLF1y/cS/favJLDEvlezs/jNoBZZ5s8RLXv8/gw1CxmGrSNEcCwMgeToiRTBhTKO4CNl Y4iFnlx9iyVMXYokxxNrocJzJc6KUdzpfLuDPbFZwAVzokRZuNHosggTHDuvXhsNU3xA TLRE3LraSkdan5rLoZS5IwUxltwAQn+sPS79B9N5JzVM5fVjV0AGKQn0qyYczDTgXPb0 NW/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qi+0OF4ODQNxSO8LjvEMR71lEcthMzByu7Tr2x6qWes=; b=SyR0geAv3oV7nif3JvcTzlWmYTZ7d+WT2bEX1cXCmus89BWCOcEh0ww1OOauN4hGUl 48ZZaEo304u6Fkq69+X9K2NBi9vtzAOYvA9Oi7FC+PjlnO9+V6LDaBCaXVjI9QSPrS1G I9lOhvqwRtLyuJYuYstUdUFHAjfFTRFv+K6jP7RxcPlj2hT/Ndxlvy3aWVLtoiFmqMGi YvFRhLG9I3IAzHySIW7rcSSXSOH5wzk71edW0uu2B21/CaqirEhWLogSnfWeYzrUqGBl 61QgpFY17FYd3Y1O0aHGBTy3I7FyszSh0rd7G4U0QpwL6+d9GImo8PTJvcjB6FFh07gi IRlg== X-Gm-Message-State: AOAM530VW2tUgfCMACEotQtGHq0De/D7fMidP+sNQP99Gq5hqNWk+491 xwsF6nlQoRIV992frpDMwPeeKBLRvh8= X-Google-Smtp-Source: ABdhPJxZeKq2kXp5maw2pou0t9HUknsokrf7o+MtWg1zXkBtDIjsv4yrGgRAE9d2iNVgqYk35P99+Q== X-Received: by 2002:a05:600c:2154:: with SMTP id v20mr40912679wml.185.1593798150305; Fri, 03 Jul 2020 10:42:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:29 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Peter Chen Subject: [PATCH 10/30] usb: chipidea: debug: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 3 Jul 2020 18:41:28 +0100 Message-Id: <20200703174148.2749969-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/debug.c:25: warning: Function parameter or member 's' not described in 'ci_device_show' drivers/usb/chipidea/debug.c:25: warning: Function parameter or member 'data' not described in 'ci_device_show' drivers/usb/chipidea/debug.c:54: warning: Function parameter or member 's' not described in 'ci_port_test_show' drivers/usb/chipidea/debug.c:54: warning: Function parameter or member 'data' not described in 'ci_port_test_show' drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'file' not described in 'ci_port_test_write' drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'ubuf' not described in 'ci_port_test_write' drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'count' not described in 'ci_port_test_write' drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'ppos' not described in 'ci_port_test_write' drivers/usb/chipidea/debug.c:122: warning: Function parameter or member 's' not described in 'ci_qheads_show' drivers/usb/chipidea/debug.c:122: warning: Function parameter or member 'data' not described in 'ci_qheads_show' drivers/usb/chipidea/debug.c:154: warning: Function parameter or member 's' not described in 'ci_requests_show' drivers/usb/chipidea/debug.c:154: warning: Function parameter or member 'data' not described in 'ci_requests_show' Cc: Peter Chen Signed-off-by: Lee Jones --- drivers/usb/chipidea/debug.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c index e0376ee646adf..da5d18cf68406 100644 --- a/drivers/usb/chipidea/debug.c +++ b/drivers/usb/chipidea/debug.c @@ -18,7 +18,7 @@ #include "bits.h" #include "otg.h" -/** +/* * ci_device_show: prints information about device capabilities and status */ static int ci_device_show(struct seq_file *s, void *data) @@ -47,7 +47,7 @@ static int ci_device_show(struct seq_file *s, void *data) } DEFINE_SHOW_ATTRIBUTE(ci_device); -/** +/* * ci_port_test_show: reads port test mode */ static int ci_port_test_show(struct seq_file *s, void *data) @@ -67,7 +67,7 @@ static int ci_port_test_show(struct seq_file *s, void *data) return 0; } -/** +/* * ci_port_test_write: writes port test mode */ static ssize_t ci_port_test_write(struct file *file, const char __user *ubuf, @@ -115,7 +115,7 @@ static const struct file_operations ci_port_test_fops = { .release = single_release, }; -/** +/* * ci_qheads_show: DMA contents of all queue heads */ static int ci_qheads_show(struct seq_file *s, void *data) @@ -147,7 +147,7 @@ static int ci_qheads_show(struct seq_file *s, void *data) } DEFINE_SHOW_ATTRIBUTE(ci_qheads); -/** +/* * ci_requests_show: DMA contents of all requests currently queued (all endpts) */ static int ci_requests_show(struct seq_file *s, void *data) From patchwork Fri Jul 3 17:41:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642507 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8934B159A for ; Fri, 3 Jul 2020 17:44:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6838E208C7 for ; Fri, 3 Jul 2020 17:44:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DMqJkwcM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727817AbgGCRoF (ORCPT ); Fri, 3 Jul 2020 13:44:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbgGCRmd (ORCPT ); Fri, 3 Jul 2020 13:42:33 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39FF7C061794 for ; Fri, 3 Jul 2020 10:42:33 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id j18so32753949wmi.3 for ; Fri, 03 Jul 2020 10:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hkP3qVBNEk6Kc5YTDzguCBFbl645cyK8MIjoauSGcJc=; b=DMqJkwcMFbE16h4BXCAlhproq9OY9OTMS6yMlTWhnyElmGkSam1Nhg2OxHZdPKcjAV fWMh1JQtMrUG+nF+S5TM02kB7g2XlgSG0aUiH2N7fo4tvH0W6QcegBqOL5TlgE4Tb8uU sD9IP3QVUcbeuuFmEbW75bpiS8sTsnVeAORASEMdFtjTrJ4paWH3MEuIz3TiYhm7/jdO pYSCxncRB6biQIICoD2NYpo69H8bsraYRPIqQXuhynZl7lIBGzwCSQfo53knK+w9zgNW mlKrkddtqqQsp49JGkEEW3Fcd2AHsUc5Epv0TXK3FjLoSF05qYCsLrQGcCTF3+iVJENG UPdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hkP3qVBNEk6Kc5YTDzguCBFbl645cyK8MIjoauSGcJc=; b=lahqz4oAtgzDylU98yeWmG/H+7lWRAzJAacPGxhcatkILYw7tFsTq3OI9/BZJYTl6Q mnxDk04pvOOnMElAgTXoYSB0oy6/zhsKgMJFFwdDDMwW16EiUz7SXInrRJv2ON1s2LoG gjlP9kw/Sjzc4iRCwFEuaTNSOLNiiwbH59k9Bg+EPV+Z3rjoq+w0z5JpEEAibPU63rvy hnYzUTE2frtWuXAQSBr/Iv+Lc40bgKXv4MAfI8P1/BbIv8MRC9kGNx5xUfCXWHIfBbjt qPwN7OJrxYqXLNJaW3UoCpc3tP7jI9cHeJH0TMn2W7WQYJ6Q+bLlMvwnqRngWplT4dpe llPQ== X-Gm-Message-State: AOAM530PIrGUZDspOsV+CIqed1r2tS1gV0RY5R1QQj7Lv51OHIlYEE9b HkIJkU3evRqynLeZ/wSnpCwZeQ== X-Google-Smtp-Source: ABdhPJyBCYm3ryMjBcp1zoZ4Rl9KiNphQ9CcsrkGIBJR3Mk9yN41fsP6rocveGpS/R7FreNKHpirUg== X-Received: by 2002:a1c:2d0d:: with SMTP id t13mr22258434wmt.43.1593798151974; Fri, 03 Jul 2020 10:42:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:31 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Peter Chen Subject: [PATCH 11/30] usb: chipidea: udc: Add missing descriptions for function arg 'ci' Date: Fri, 3 Jul 2020 18:41:29 +0100 Message-Id: <20200703174148.2749969-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Looks like a very popular argument to omit descriptions for. Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/udc.c:80: warning: Function parameter or member 'ci' not described in 'hw_device_state' drivers/usb/chipidea/udc.c:100: warning: Function parameter or member 'ci' not described in 'hw_ep_flush' drivers/usb/chipidea/udc.c:121: warning: Function parameter or member 'ci' not described in 'hw_ep_disable' drivers/usb/chipidea/udc.c:136: warning: Function parameter or member 'ci' not described in 'hw_ep_enable' drivers/usb/chipidea/udc.c:170: warning: Function parameter or member 'ci' not described in 'hw_ep_get_halt' drivers/usb/chipidea/udc.c:185: warning: Function parameter or member 'ci' not described in 'hw_ep_prime' drivers/usb/chipidea/udc.c:215: warning: Function parameter or member 'ci' not described in 'hw_ep_set_halt' drivers/usb/chipidea/udc.c:238: warning: Function parameter or member 'ci' not described in 'hw_port_is_high_speed' drivers/usb/chipidea/udc.c:251: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_complete' drivers/usb/chipidea/udc.c:263: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_intr_active' drivers/usb/chipidea/udc.c:277: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_setup_guard' drivers/usb/chipidea/udc.c:288: warning: Function parameter or member 'ci' not described in 'hw_test_and_set_setup_guard' drivers/usb/chipidea/udc.c:300: warning: Function parameter or member 'ci' not described in 'hw_usb_set_address' drivers/usb/chipidea/udc.c:312: warning: Function parameter or member 'ci' not described in 'hw_usb_reset' Cc: Peter Chen Signed-off-by: Lee Jones --- drivers/usb/chipidea/udc.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index db0cfde0cc3cb..c42b98c84f2f1 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -72,6 +72,7 @@ static inline int ep_to_bit(struct ci_hdrc *ci, int n) /** * hw_device_state: enables/disables interrupts (execute without interruption) + * @ci: the controller * @dma: 0 => disable, !0 => enable and set dma engine * * This function returns an error code @@ -91,6 +92,7 @@ static int hw_device_state(struct ci_hdrc *ci, u32 dma) /** * hw_ep_flush: flush endpoint fifo (execute without interruption) + * @ci: the controller * @num: endpoint number * @dir: endpoint direction * @@ -112,6 +114,7 @@ static int hw_ep_flush(struct ci_hdrc *ci, int num, int dir) /** * hw_ep_disable: disables endpoint (execute without interruption) + * @ci: the controller * @num: endpoint number * @dir: endpoint direction * @@ -126,6 +129,7 @@ static int hw_ep_disable(struct ci_hdrc *ci, int num, int dir) /** * hw_ep_enable: enables endpoint (execute without interruption) + * @ci: the controller * @num: endpoint number * @dir: endpoint direction * @type: endpoint type @@ -161,6 +165,7 @@ static int hw_ep_enable(struct ci_hdrc *ci, int num, int dir, int type) /** * hw_ep_get_halt: return endpoint halt status + * @ci: the controller * @num: endpoint number * @dir: endpoint direction * @@ -175,6 +180,7 @@ static int hw_ep_get_halt(struct ci_hdrc *ci, int num, int dir) /** * hw_ep_prime: primes endpoint (execute without interruption) + * @ci: the controller * @num: endpoint number * @dir: endpoint direction * @is_ctrl: true if control endpoint @@ -205,6 +211,7 @@ static int hw_ep_prime(struct ci_hdrc *ci, int num, int dir, int is_ctrl) /** * hw_ep_set_halt: configures ep halt & resets data toggle after clear (execute * without interruption) + * @ci: the controller * @num: endpoint number * @dir: endpoint direction * @value: true => stall, false => unstall @@ -243,6 +250,7 @@ static int hw_port_is_high_speed(struct ci_hdrc *ci) /** * hw_test_and_clear_complete: test & clear complete status (execute without * interruption) + * @ci: the controller * @n: endpoint number * * This function returns complete status @@ -291,6 +299,7 @@ static int hw_test_and_set_setup_guard(struct ci_hdrc *ci) /** * hw_usb_set_address: configures USB address (execute without interruption) + * @ci: the controller * @value: new USB address * * This function explicitly sets the address, without the "USBADRA" (advance) @@ -610,8 +619,9 @@ static int _hardware_enqueue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) return ret; } -/* +/** * free_pending_td: remove a pending request for the endpoint + * @ci: the controller * @hwep: endpoint */ static void free_pending_td(struct ci_hw_ep *hwep) From patchwork Fri Jul 3 17:41:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642513 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0E9C06C1 for ; Fri, 3 Jul 2020 17:44:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC919208C7 for ; Fri, 3 Jul 2020 17:44:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="puwTBHNe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727810AbgGCRoE (ORCPT ); Fri, 3 Jul 2020 13:44:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbgGCRme (ORCPT ); Fri, 3 Jul 2020 13:42:34 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E61DC08C5DE for ; Fri, 3 Jul 2020 10:42:34 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id a6so22766813wmm.0 for ; Fri, 03 Jul 2020 10:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=friu7Jy2tbGy4d1jkwCWtPbcYZ7luQZlKvwgWbPNKHg=; b=puwTBHNe/kKkCwFXmN8z3mDpSXWfiQead8Enhc8NAveHB7gPPpt7FdFAXjUpGKqRzB 5UCtk2MkA/aOAi6ZLSNSue9EVSnABo8Bar7fdGElfaNvOVIxa6hYraT6+FwH8zCkKuLD D0JYQtlRicpA3up3Bg/z46LJD9lLCKBo0RA6Tbe/TR1br6YxNhgJuwc7aqueQusdxSPb hcp50co1fGmITC2AKrpJLLcxXraOWoPk3cxehodDCbNn4rDK41bGFXvUuMBT+EXct2Wp 72BK4A6l39lw/1nZInaeNeFhqmsZdnIxwJEvlFDnyKyU9M7PeM4E6oy811xI3BB+2b/m VMKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=friu7Jy2tbGy4d1jkwCWtPbcYZ7luQZlKvwgWbPNKHg=; b=bCDLLSKykQLx0HAS0LrKgxPL/YvMu+3q2n25PX3NvtUYYbyw9CWZFUZvoseREdTkZ8 gYOdlovZtJ6KtstHunfY8ES9mvqY2hDpyCci5cELoj/JL2K1d440qDiaLeUok5Us+Y7x lFP0ryzqpgi5b3TzJcbmP/c5FjlaszqZDOBddxvSUyazoxDVJE0SzNZhVgKVgP4ux9/c gZCUJrnq5MBCLOTAnW7vUpB+PkBNPFrzyIGuAqISh3F46hirTQIhv28HhgCw4c9h08JZ 2CNcjt+3MKlB1gPFRFK/UxUb+55Bt2iahaPIY4Mh7A2LiBhvr8kw44WcJ0QunH/H1e/C 1ohA== X-Gm-Message-State: AOAM533BRZ0gtQ9iCH/t5t74WBUTUJIPEBUCqbNYOc818qOzTRB1wjTv YlWRnqu5R5aaMNeFeWwkgol6gA== X-Google-Smtp-Source: ABdhPJzXpNP74qpR3EeiVntXOr7SPzrzUEG4ppyJ5gSdCrYd4MG9xzn0OnsJRyIkwygTnHOUwNwQtQ== X-Received: by 2002:a1c:1d46:: with SMTP id d67mr40352418wmd.152.1593798153264; Fri, 03 Jul 2020 10:42:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:32 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Peter Chen Subject: [PATCH 12/30] usb: chipidea: udc: Help out kerneldoc headers that have tried, demote the others Date: Fri, 3 Jul 2020 18:41:30 +0100 Message-Id: <20200703174148.2749969-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Help with adding the odd description where they have been omitted or where the format isn't quite right. Demote all function headers which are lacking any attempt of describing their arguments. Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/udc.c:645: warning: Function parameter or member 'hwreq' not described in '_hardware_dequeue' drivers/usb/chipidea/udc.c:645: warning: Excess function parameter 'gadget' description in '_hardware_dequeue' drivers/usb/chipidea/udc.c:1326: warning: Function parameter or member 'ep' not described in 'ep_enable' drivers/usb/chipidea/udc.c:1326: warning: Function parameter or member 'desc' not described in 'ep_enable' drivers/usb/chipidea/udc.c:1393: warning: Function parameter or member 'ep' not described in 'ep_disable' drivers/usb/chipidea/udc.c:1433: warning: Function parameter or member 'ep' not described in 'ep_alloc_request' drivers/usb/chipidea/udc.c:1433: warning: Function parameter or member 'gfp_flags' not described in 'ep_alloc_request' drivers/usb/chipidea/udc.c:1454: warning: Function parameter or member 'ep' not described in 'ep_free_request' drivers/usb/chipidea/udc.c:1454: warning: Function parameter or member 'req' not described in 'ep_free_request' drivers/usb/chipidea/udc.c:1488: warning: Function parameter or member 'ep' not described in 'ep_queue' drivers/usb/chipidea/udc.c:1488: warning: Function parameter or member 'req' not described in 'ep_queue' drivers/usb/chipidea/udc.c:1488: warning: Function parameter or member 'gfp_flags' not described in 'ep_queue' drivers/usb/chipidea/udc.c:1512: warning: Function parameter or member 'ep' not described in 'ep_dequeue' drivers/usb/chipidea/udc.c:1512: warning: Function parameter or member 'req' not described in 'ep_dequeue' drivers/usb/chipidea/udc.c:1556: warning: Function parameter or member 'ep' not described in 'ep_set_halt' drivers/usb/chipidea/udc.c:1556: warning: Function parameter or member 'value' not described in 'ep_set_halt' drivers/usb/chipidea/udc.c:1566: warning: Function parameter or member 'ep' not described in 'ep_set_wedge' drivers/usb/chipidea/udc.c:1586: warning: Function parameter or member 'ep' not described in 'ep_fifo_flush' drivers/usb/chipidea/udc.c:1610: warning: cannot understand function prototype: 'const struct usb_ep_ops usb_ep_ops = ' drivers/usb/chipidea/udc.c:1629: warning: Function parameter or member '_gadget' not described in 'ci_hdrc_gadget_connect' drivers/usb/chipidea/udc.c:1629: warning: Function parameter or member 'is_active' not described in 'ci_hdrc_gadget_connect' drivers/usb/chipidea/udc.c:1780: warning: cannot understand function prototype: 'const struct usb_gadget_ops usb_gadget_ops = ' drivers/usb/chipidea/udc.c:1931: warning: Function parameter or member 'gadget' not described in 'ci_udc_stop' drivers/usb/chipidea/udc.c:1965: warning: Function parameter or member 'ci' not described in 'udc_irq' drivers/usb/chipidea/udc.c:2095: warning: Function parameter or member 'ci' not described in 'ci_hdrc_gadget_destroy' drivers/usb/chipidea/udc.c:2144: warning: Function parameter or member 'ci' not described in 'ci_hdrc_gadget_init' Cc: Peter Chen Signed-off-by: Lee Jones --- drivers/usb/chipidea/udc.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index c42b98c84f2f1..0dfbc31843fc8 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -647,7 +647,7 @@ static int reprime_dtd(struct ci_hdrc *ci, struct ci_hw_ep *hwep, /** * _hardware_dequeue: handles a request at hardware level * @gadget: gadget - * @hwep: endpoint + * @hwreq: request * * This function returns an error code */ @@ -1326,7 +1326,7 @@ __acquires(ci->lock) /****************************************************************************** * ENDPT block *****************************************************************************/ -/** +/* * ep_enable: configure endpoint, making it usable * * Check usb_ep_enable() at "usb_gadget.h" for details @@ -1394,7 +1394,7 @@ static int ep_enable(struct usb_ep *ep, return retval; } -/** +/* * ep_disable: endpoint is no longer usable * * Check usb_ep_disable() at "usb_gadget.h" for details @@ -1434,7 +1434,7 @@ static int ep_disable(struct usb_ep *ep) return retval; } -/** +/* * ep_alloc_request: allocate a request object to use with this endpoint * * Check usb_ep_alloc_request() at "usb_gadget.h" for details @@ -1455,7 +1455,7 @@ static struct usb_request *ep_alloc_request(struct usb_ep *ep, gfp_t gfp_flags) return (hwreq == NULL) ? NULL : &hwreq->req; } -/** +/* * ep_free_request: frees a request object * * Check usb_ep_free_request() at "usb_gadget.h" for details @@ -1488,7 +1488,7 @@ static void ep_free_request(struct usb_ep *ep, struct usb_request *req) spin_unlock_irqrestore(hwep->lock, flags); } -/** +/* * ep_queue: queues (submits) an I/O request to an endpoint * * Check usb_ep_queue()* at usb_gadget.h" for details @@ -1513,7 +1513,7 @@ static int ep_queue(struct usb_ep *ep, struct usb_request *req, return retval; } -/** +/* * ep_dequeue: dequeues (cancels, unlinks) an I/O request from an endpoint * * Check usb_ep_dequeue() at "usb_gadget.h" for details @@ -1557,7 +1557,7 @@ static int ep_dequeue(struct usb_ep *ep, struct usb_request *req) return 0; } -/** +/* * ep_set_halt: sets the endpoint halt feature * * Check usb_ep_set_halt() at "usb_gadget.h" for details @@ -1567,7 +1567,7 @@ static int ep_set_halt(struct usb_ep *ep, int value) return _ep_set_halt(ep, value, true); } -/** +/* * ep_set_wedge: sets the halt feature and ignores clear requests * * Check usb_ep_set_wedge() at "usb_gadget.h" for details @@ -1587,7 +1587,7 @@ static int ep_set_wedge(struct usb_ep *ep) return usb_ep_set_halt(ep); } -/** +/* * ep_fifo_flush: flushes contents of a fifo * * Check usb_ep_fifo_flush() at "usb_gadget.h" for details @@ -1613,7 +1613,7 @@ static void ep_fifo_flush(struct usb_ep *ep) spin_unlock_irqrestore(hwep->lock, flags); } -/** +/* * Endpoint-specific part of the API to the USB controller hardware * Check "usb_gadget.h" for details */ @@ -1632,7 +1632,7 @@ static const struct usb_ep_ops usb_ep_ops = { /****************************************************************************** * GADGET block *****************************************************************************/ -/** +/* * ci_hdrc_gadget_connect: caller makes sure gadget driver is binded */ static void ci_hdrc_gadget_connect(struct usb_gadget *_gadget, int is_active) @@ -1782,7 +1782,7 @@ static struct usb_ep *ci_udc_match_ep(struct usb_gadget *gadget, return NULL; } -/** +/* * Device operations part of the API to the USB controller hardware, * which don't involve endpoints (or i/o) * Check "usb_gadget.h" for details @@ -1934,7 +1934,7 @@ static void ci_udc_stop_for_otg_fsm(struct ci_hdrc *ci) mutex_unlock(&ci->fsm.lock); } -/** +/* * ci_udc_stop: unregister a gadget driver */ static int ci_udc_stop(struct usb_gadget *gadget) @@ -1965,7 +1965,7 @@ static int ci_udc_stop(struct usb_gadget *gadget) /****************************************************************************** * BUS block *****************************************************************************/ -/** +/* * udc_irq: ci interrupt handler * * This function returns IRQ_HANDLED if the IRQ has been handled @@ -2096,7 +2096,7 @@ static int udc_start(struct ci_hdrc *ci) return retval; } -/** +/* * ci_hdrc_gadget_destroy: parent remove must call this to remove UDC * * No interrupts active, the IRQ has been released @@ -2146,7 +2146,7 @@ static void udc_id_switch_for_host(struct ci_hdrc *ci) /** * ci_hdrc_gadget_init - initialize device related bits - * ci: the controller + * @ci: the controller * * This function initializes the gadget, if the device is "device capable". */ From patchwork Fri Jul 3 17:41:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642495 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ECA20159A for ; Fri, 3 Jul 2020 17:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5D9A208FE for ; Fri, 3 Jul 2020 17:43:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j++rmjLV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbgGCRml (ORCPT ); Fri, 3 Jul 2020 13:42:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726904AbgGCRmh (ORCPT ); Fri, 3 Jul 2020 13:42:37 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E7E9C061794 for ; Fri, 3 Jul 2020 10:42:37 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j4so31132945wrp.10 for ; Fri, 03 Jul 2020 10:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4LyTKYUD/bNIDavfKIyBUK2+LGfEs6fHGIsN/epbMTo=; b=j++rmjLVKGE8pJOki7KEkXap+ttuF0IaSJ6R4tm+0X3EML73Vhjgu0DH7+NuuLNCCD JyEYJgF4AJO9OF9F+dXlSbcsZ4hfZmufRZ7mHKpB0uGilNC44Gf015+rpII0D+viBkxj th5S9AKZbZ8/b3gT9djqWXTdE7pZIsUj4216ALlqOzZpsBv6E58rP1JsDo+zuz9pejHN 838vbI10run4HOjp04xPaHKpJehh2FowRbeqDSSxGX/WpviiO0Cp2cyDOOqvHiaAasyk c14zkprb8zMmm9IuQ1yiY5UF103BP4+ILRruwvIcyNUtvwFlonPCnBrjhZIEnLf/lL0S 2AdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4LyTKYUD/bNIDavfKIyBUK2+LGfEs6fHGIsN/epbMTo=; b=cotOg6y7bF6yvkdmWdV8gYu8IwyyOXE2y25GvpFGo6MVK5o71+tYTqEe7h34DI9yOc +e5V1g87KLZUoDFviFmKPP54DDwGG6oaSxv5JL6fSsgJ3cbnqqSFSFbATkhcEY5GM5+Q UYY6sAo1phKRmkO+dekp2EKTsuJi0N6r9eLpC71b3H/VL/G4phuai4rsGgA7rkG66K4j ik/NGmMa4nZkCA/XeeGfr3mI2JjD60xiTVuXHto0krMROPwd/242UzfKQKfGQv8qsua3 pOh2sOqRmjp95MASChYhP+RPTwAUpIE+F9T1+bivzcXTLSC7hfhog4gVaxyZBW/QwSCP ++dg== X-Gm-Message-State: AOAM533eM7nIG0m/E7LgmAxgdSk8vkta1cOYVcANVGESpx0KOeFI2el0 OV56cwUAxN6d32WVHVSgTmmTWQ== X-Google-Smtp-Source: ABdhPJwDyJ5bpWGdeInLOmwfSiVTjWV3CNpmNKaDGXCbrJXjPxmjv+Mf9nL5utsePleC77WQ0REJMw== X-Received: by 2002:adf:edd0:: with SMTP id v16mr37170423wro.214.1593798156340; Fri, 03 Jul 2020 10:42:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:35 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Mathias Nyman Subject: [PATCH 13/30] usb: host: xhci: Demote obvious misuse of kerneldoc to standard comment block Date: Fri, 3 Jul 2020 18:41:31 +0100 Message-Id: <20200703174148.2749969-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): drivers/usb/host/xhci.c:1285: warning: Function parameter or member 'desc' not described in 'xhci_get_endpoint_index' Cc: Mathias Nyman Signed-off-by: Lee Jones --- drivers/usb/host/xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index bee5deccc83d8..b90d61bb84144 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -1271,7 +1271,7 @@ static int xhci_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb, return usb_hcd_map_urb_for_dma(hcd, urb, mem_flags); } -/** +/* * xhci_get_endpoint_index - Used for passing endpoint bitmasks between the core and * HCDs. Find the index for an endpoint given its descriptor. Use the return * value to right shift 1 for the bitmask. From patchwork Fri Jul 3 17:41:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642497 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B427014B7 for ; Fri, 3 Jul 2020 17:43:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99FFB20870 for ; Fri, 3 Jul 2020 17:43:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vMQ8eZA1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726920AbgGCRmk (ORCPT ); Fri, 3 Jul 2020 13:42:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbgGCRmj (ORCPT ); Fri, 3 Jul 2020 13:42:39 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0F7FC061794 for ; Fri, 3 Jul 2020 10:42:38 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z15so22289154wrl.8 for ; Fri, 03 Jul 2020 10:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7eNVLa4hjk02Jz2SQUwzwLQ41aN0q3Km5pJHjYU/rio=; b=vMQ8eZA1CVkGFvX8S60GAhdmZPsB9rQNsmkoQFo2oYnXndISyZCgsg+4zxHt6jdFwd +Jr9x7VcoLu8QL2a+ksPn6/BHqcB/BxvRdM7XeF5wlOqwC465GuHkedkU/DomxW3+G9g o8M4UHC7PgYI9IHEbJRrXkZRFEyibaCx5yj1L1IjA34jJhLJmOEFoWL5TSZB9xbQzti0 n0hAtXHU95HcmA/LY31X2Wyr44VjZSdGjf22nMg2VaDPHj5pSMR0+rol5lpSmMDnkS6R L5lDo/RWgKUglug4pXnH6NcSkbqZmTV19sMvhpBHX+0z3HunhrUo4tR+y7awHGLQuWd5 icMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7eNVLa4hjk02Jz2SQUwzwLQ41aN0q3Km5pJHjYU/rio=; b=dZLR9rE9T/da4BSo43vGLaiZY3nSyCtS6MdlN9S4QDXQb7EFsmMqjfx7+Pvk3b2qEd KBdo/WsOUlAFqcqK/tRI4oov+Zclt8vNEhu0HxapVO/s76T/LSHnshZHGSMFjrTpB87N er8fHWOK8T33TkvPQQKZV7LFlSKldqq2oqMj5YTCp2DwCFcAnl+bIi+wp1y14epg6KHz 6koXvGH9eqbxD1rcMDXihj3z/heXwCeGZfVJJtvTed2/fUDKgM1/7LDpM2SbM3P7zlUi uAyjx7KlUvZYUC62yg2u3s756WNnonh3e8pEzcuI2VsCgG/oZqg3t3ZmPiKnwzsyOCT/ sMDw== X-Gm-Message-State: AOAM533vm8A+Yt9QTJe7xprXs1HY/AbF/wBVKJJJGJqRyteoPG6e/V1t 7W0ornyucdOi4x3s5H3jXDg8Fs+bjE8= X-Google-Smtp-Source: ABdhPJx2o0YkTTmj44f3mUJGFAhlHMkc6BactSo26Kbv16QRGRZrY63SVbxt7C9PpaVBYfWIgzuQSg== X-Received: by 2002:adf:e50a:: with SMTP id j10mr40298877wrm.71.1593798157484; Fri, 03 Jul 2020 10:42:37 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:36 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Mathias Nyman Subject: [PATCH 14/30] usb: host: xhci-mem: Demote obvious misuse of kerneldoc to standard comment block Date: Fri, 3 Jul 2020 18:41:32 +0100 Message-Id: <20200703174148.2749969-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'xhci' not described in 'xhci_ring_alloc' drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'num_segs' not described in 'xhci_ring_alloc' drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'cycle_state' not described in 'xhci_ring_alloc' drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'type' not described in 'xhci_ring_alloc' drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'max_packet' not described in 'xhci_ring_alloc' drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'flags' not described in 'xhci_ring_alloc' Cc: Mathias Nyman Signed-off-by: Lee Jones --- drivers/usb/host/xhci-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 9764122c9cdf2..fb221c0914780 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -352,7 +352,7 @@ static int xhci_alloc_segments_for_ring(struct xhci_hcd *xhci, return 0; } -/** +/* * Create a new ring with zero or more segments. * * Link each segment together into a ring. From patchwork Fri Jul 3 17:41:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642501 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E92D36C1 for ; Fri, 3 Jul 2020 17:44:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2315208C7 for ; Fri, 3 Jul 2020 17:44:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v3Wh3lvw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726447AbgGCRoD (ORCPT ); Fri, 3 Jul 2020 13:44:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726914AbgGCRmk (ORCPT ); Fri, 3 Jul 2020 13:42:40 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DE5FC061794 for ; Fri, 3 Jul 2020 10:42:40 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l17so32763021wmj.0 for ; Fri, 03 Jul 2020 10:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nrHavSfwF9zAzDxN+izm9d2TdfMW/Gzo00Jgx4fI6x0=; b=v3Wh3lvwukp/VboEADjur5pV3CgcRQ5RkHq6J0z1dtnbvy+t8z27eXoBypluVuR9M9 gMJ2vWmKe3aCAcLApcN3rjLts+Br5bLcuqfQQIp5OgANFlNv9Wi7KG5tV6nVcJXepR3r v5qTQt6JhwEqc5+DytL3t6eMYc9yHBIdaVzI92jZ3uw4Fs8bcZSzoR+arUihmQkTgbtC qCNNhTqAkpyTMo9UHUjOouAGRnQl2nZrV8JJlwp1JwtPtzan/g8IERYJNLj2X2aY2Z5w kZY/PYvdMzmHhzvMrvbr+ZM5B12KTRMQK5jANWzIOYrKLgHcCZl0R2TUUNE88t13kyAd I7DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nrHavSfwF9zAzDxN+izm9d2TdfMW/Gzo00Jgx4fI6x0=; b=EdfAotERvf8PS782LuPsv0aWOeoR8+zybT8lFsOgBRekRl9vCjULgETRxRjvLBsDa8 RJ5Hrd3g+QVnuysZZqReoSxTbnHRuesT+QQLHm4+IGKO0EniXdZhWw+QgE1DDlq8tSaV kLggCClqMTj0EOmDpop5WnFONENotNCS+Q5w6CUkcEJWDFJ4A/ZBs/dcjpdr9rqKLisK 7S3tnyheNaw4KUhXt2sjpWow78Zq8u54fhz7BUguU1ludpdv9JDbjyd0Kr6+8dKbRZJt 3LMwuFp0Q90PA3U3zFs5HoazGiLzESAlZ+EFiISrMb3XCe4IE7fKqmLzhq8fwUP/mvAj yIOQ== X-Gm-Message-State: AOAM533hP48uanuCZNqaUBG+ykrUJ1S8Zd0UbrXYx/AlpNunQicthxWn AC/5DQrPUuG5S/ZAyDdsJX+pwA== X-Google-Smtp-Source: ABdhPJzi/uWfkCbo8xC3My6JR+VXn+MbLHVx87b8vwenP30eUAYU/lrCQXZAAU72yIqMQn2cgDaH3A== X-Received: by 2002:a1c:3504:: with SMTP id c4mr4440719wma.177.1593798159020; Fri, 03 Jul 2020 10:42:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:38 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Mathias Nyman , Lu Baolu Subject: [PATCH 15/30] usb: host: xhci-dbgcap: File headers are not good candidates for kerneldoc Date: Fri, 3 Jul 2020 18:41:33 +0100 Message-Id: <20200703174148.2749969-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Demote xhci-dbgcap's file header to a standard comment block. Fixes the following W=1 kernel build warning(s): drivers/usb/host/xhci-dbgcap.c:20: warning: Function parameter or member 'xhci' not described in 'dbc_dma_alloc_coherent' drivers/usb/host/xhci-dbgcap.c:20: warning: Function parameter or member 'size' not described in 'dbc_dma_alloc_coherent' drivers/usb/host/xhci-dbgcap.c:20: warning: Function parameter or member 'dma_handle' not described in 'dbc_dma_alloc_coherent' drivers/usb/host/xhci-dbgcap.c:20: warning: Function parameter or member 'flags' not described in 'dbc_dma_alloc_coherent' Cc: Mathias Nyman Cc: Lu Baolu Signed-off-by: Lee Jones --- drivers/usb/host/xhci-dbgcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c index 93e2cca5262d1..987f893e941c7 100644 --- a/drivers/usb/host/xhci-dbgcap.c +++ b/drivers/usb/host/xhci-dbgcap.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * xhci-dbgcap.c - xHCI debug capability support * * Copyright (C) 2017 Intel Corporation From patchwork Fri Jul 3 17:41:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642493 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D0C9D6C1 for ; Fri, 3 Jul 2020 17:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6E102100A for ; Fri, 3 Jul 2020 17:43:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Kh13Uagu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbgGCRnw (ORCPT ); Fri, 3 Jul 2020 13:43:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726928AbgGCRmm (ORCPT ); Fri, 3 Jul 2020 13:42:42 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6C87C08C5DD for ; Fri, 3 Jul 2020 10:42:41 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o2so34857298wmh.2 for ; Fri, 03 Jul 2020 10:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ic4rIp6i7w+ExunilNL5OmgeWajYHUPztrk1dypeX68=; b=Kh13UaguKQVWZFolCXDG/NLuzB1QO3j36+LCgHs0O7rS+7DqMoCuWWNcQ11blivh+9 dmI7sC/uh/PeO3GdENZNw361HKDmGWW249ewSbEtsbmiKtrKmSGSA967yvwctkeGD2Da VQ1SEwKsnpSDkC/rvNDOTjd9yA5gsSNcV+5uECRNmdRpH60hkKMAvdMXpMUbCaZlUx9C ZwGVg4SIA/ENzxh+txpPPoOGa7sRuj2rJyJrywTxVAIHqAJeWZG72zTo4ATX+cVf5/jP sRPxQhFwld2UHWmSMu/iYzjgb9dHOG7zTYUMLIcDSGW/lq6c6c9jCPdi1G/4E97SPsN0 8LBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ic4rIp6i7w+ExunilNL5OmgeWajYHUPztrk1dypeX68=; b=YsadPPj5h6mk/WRLJAtzW4nNYd/nfX9rmxsfPjwhOmd87pNyENHjHoXuoPOnz6jXfd 5I4o9vhdqLqwx7fG1neXqAn6FTQfSSgd/WFwY3YZxdstRGepQu7HKZZBXQadpv9wC6p8 l/ZE9lAQThLQmOrf2ef7Y7G5xXY6M4iWRxX0RAq78Zlo2z9R2XbLEYWKcJR+lUk5TjHZ gd6DKfYWN02QR0Uo32J6OSM5tcOMLfc1J0Ro0KbYTnmgao828jtEFCm8Lmp4G8MA+DQn R4n8h/Fdefz8VqgC8Ex8idttheNpnnBaRQ/nlerhKwxdHmX/mBmFHHRdAxwuzvHgA2U4 cypg== X-Gm-Message-State: AOAM533wXURt9TBQLDdVEh1GZ8B40o+ktCVZcjq6i/M6/4YupJWbM3qY QDZaE1XrF7MGb3iOYHYfCQwGbQ== X-Google-Smtp-Source: ABdhPJyTuGeahpIZr9wBtU7PsnWawkpr7E89M9tw5DuGJg8R1ACU8WRWAMYfSi26BXhuCQn07ZcVLg== X-Received: by 2002:a1c:b386:: with SMTP id c128mr39576677wmf.133.1593798160504; Fri, 03 Jul 2020 10:42:40 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:40 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Mathias Nyman , Lu Baolu Subject: [PATCH 16/30] usb: host: xhci-dbgtty: File headers are not good candidates for kerneldoc Date: Fri, 3 Jul 2020 18:41:34 +0100 Message-Id: <20200703174148.2749969-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Demote xhci-dbgtty's file header to a standard comment block. Fixes the following W=1 kernel build warning(s): drivers/usb/host/xhci-dbgtty.c:19: warning: Function parameter or member 'port' not described in 'dbc_send_packet' drivers/usb/host/xhci-dbgtty.c:19: warning: Function parameter or member 'packet' not described in 'dbc_send_packet' drivers/usb/host/xhci-dbgtty.c:19: warning: Function parameter or member 'size' not described in 'dbc_send_packet' Cc: Mathias Nyman Cc: Lu Baolu Signed-off-by: Lee Jones --- drivers/usb/host/xhci-dbgtty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c index be726c791323a..9a1d384425782 100644 --- a/drivers/usb/host/xhci-dbgtty.c +++ b/drivers/usb/host/xhci-dbgtty.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * xhci-dbgtty.c - tty glue for xHCI debug capability * * Copyright (C) 2017 Intel Corporation From patchwork Fri Jul 3 17:41:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642489 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 31AFF6C1 for ; Fri, 3 Jul 2020 17:43:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18F7D208FE for ; Fri, 3 Jul 2020 17:43:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jn2FpAOU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbgGCRmq (ORCPT ); Fri, 3 Jul 2020 13:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726942AbgGCRmn (ORCPT ); Fri, 3 Jul 2020 13:42:43 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E901C061794 for ; Fri, 3 Jul 2020 10:42:43 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o8so32745955wmh.4 for ; Fri, 03 Jul 2020 10:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ObQbMmeWDMLVhtsXWDC1B0aBD5PkI/uWeU7dXCk6FlM=; b=jn2FpAOUPnZM069KYrVVfbxt1St8s7u9aejs2316lLyFC8QicNEuaQpIqyiqJJoy6C O4vsFZ6bk3aach7toVLh8omoClMF7OLDlCzPYK4eWBpCVKSUQlWr5i1G/rLt2i8/VweZ sSg80UU1XpFSFVcxfOxDpnl/9ztoRoZmbt6zAOJ2u3FhcuWqSgpehMIFMtWHfBUA0xXX ikyr40G5+YBJtgJcJXPwZzwN9sk6THJMUK1RommOcPasQY+6xFoT5k9uRBU1A0uAVrAg g7qf2oq6gxZeeX09UgLWhVJ/wmtYGjB6Qg8WuTAh9AXezXcLDgyH62NaLTcw/cIpj1yF 1MrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ObQbMmeWDMLVhtsXWDC1B0aBD5PkI/uWeU7dXCk6FlM=; b=tKqyMJ19nxYBk2Mue9k/Rqua0atBvldyvQTFtmucGmE5uA4hPhGDTyuIJ73iMvKoC0 PXF/vl3NNc4yQ0e1VQPeYnL3xO82oTQog4MctlCbi1f04pfnldZVAcA73WNAjm+ZU8/3 5TDZ2kgiQiJCg8v1wR0aOEksE6nz/0J5Al5IBDikuItrSLBC7GEA1JkVLCykuYYUkQMM l0Hka0tCQncUB9suvBm0961CNNX6BC75f+YdSXKWxTnNmM4go5t7JEJsyXluoCsVyVNi aZIQ/LhI6o2takbSG8CnhO7sbolWUD2OL4USGO7PtW/XIDsPiFI6rwdTk7ahj0F3Xoz1 Mm+g== X-Gm-Message-State: AOAM530Av895/U9esKhE5LSnWWOnErOc5Hc2oRxYdIJ2kInPgTD25Lcc j+K0rJWkhO+eRjcHrIcET6JSNg== X-Google-Smtp-Source: ABdhPJztrlr52atDjF3/+UOTLHYOF7+PmOGAz6sBBDjCc2z9cg29j3l9cqY7+6NiEdsJROG6JiGr7w== X-Received: by 2002:a1c:9a02:: with SMTP id c2mr8729231wme.16.1593798162149; Fri, 03 Jul 2020 10:42:42 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:41 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Peter Chen Subject: [PATCH 17/30] usb: chipidea: udc: Fix a few kerneldoc issues Date: Fri, 3 Jul 2020 18:41:35 +0100 Message-Id: <20200703174148.2749969-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Descriptions were missing for 'ci' almost throughout. There was one instance of over-documenting. Finally one function argument was incorrectly documented (probably down to bitrot). Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/udc.c:245: warning: Function parameter or member 'ci' not described in 'hw_port_is_high_speed' drivers/usb/chipidea/udc.c:271: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_intr_active' drivers/usb/chipidea/udc.c:285: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_setup_guard' drivers/usb/chipidea/udc.c:296: warning: Function parameter or member 'ci' not described in 'hw_test_and_set_setup_guard' drivers/usb/chipidea/udc.c:321: warning: Function parameter or member 'ci' not described in 'hw_usb_reset' drivers/usb/chipidea/udc.c:628: warning: Excess function parameter 'ci' description in 'free_pending_td' drivers/usb/chipidea/udc.c:655: warning: Function parameter or member 'hwep' not described in '_hardware_dequeue' drivers/usb/chipidea/udc.c:655: warning: Excess function parameter 'gadget' description in '_hardware_dequeue' Cc: Peter Chen Signed-off-by: Lee Jones --- drivers/usb/chipidea/udc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 0dfbc31843fc8..6a20ef396543b 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -238,6 +238,7 @@ static int hw_ep_set_halt(struct ci_hdrc *ci, int num, int dir, int value) /** * hw_is_port_high_speed: test if port is high speed + * @ci: the controller * * This function returns true if high speed port */ @@ -264,6 +265,7 @@ static int hw_test_and_clear_complete(struct ci_hdrc *ci, int n) /** * hw_test_and_clear_intr_active: test & clear active interrupts (execute * without interruption) + * @ci: the controller * * This function returns active interrutps */ @@ -278,6 +280,7 @@ static u32 hw_test_and_clear_intr_active(struct ci_hdrc *ci) /** * hw_test_and_clear_setup_guard: test & clear setup guard (execute without * interruption) + * @ci: the controller * * This function returns guard value */ @@ -289,6 +292,7 @@ static int hw_test_and_clear_setup_guard(struct ci_hdrc *ci) /** * hw_test_and_set_setup_guard: test & set setup guard (execute without * interruption) + * @ci: the controller * * This function returns guard value */ @@ -314,6 +318,7 @@ static void hw_usb_set_address(struct ci_hdrc *ci, u8 value) /** * hw_usb_reset: restart device after a bus reset (execute without * interruption) + * @ci: the controller * * This function returns an error code */ @@ -621,7 +626,6 @@ static int _hardware_enqueue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) /** * free_pending_td: remove a pending request for the endpoint - * @ci: the controller * @hwep: endpoint */ static void free_pending_td(struct ci_hw_ep *hwep) @@ -646,7 +650,7 @@ static int reprime_dtd(struct ci_hdrc *ci, struct ci_hw_ep *hwep, /** * _hardware_dequeue: handles a request at hardware level - * @gadget: gadget + * @hwep: endpoint * @hwreq: request * * This function returns an error code From patchwork Fri Jul 3 17:41:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642487 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B67556C1 for ; Fri, 3 Jul 2020 17:43:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CD9A208FE for ; Fri, 3 Jul 2020 17:43:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ducnwHyY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbgGCRmr (ORCPT ); Fri, 3 Jul 2020 13:42:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726949AbgGCRmp (ORCPT ); Fri, 3 Jul 2020 13:42:45 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F225C08C5DD for ; Fri, 3 Jul 2020 10:42:45 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l2so33374392wmf.0 for ; Fri, 03 Jul 2020 10:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iR7UBjy9b+GnDxxSAohGssAzGZu9g74Tp/QmVOl6H2Q=; b=ducnwHyYnt1Euvl0f4+BWCbuzEg8Fov/NpURhw5+20HmnMl1J/sAR30xHQb54zWlsc 8ylR62njZpvZKMYJmXQzbyCwGAGVC8pDWzbyYh2po23NCMBqyIkNgsIyxX/9JgCgQJfu I7QGyxJMasm839b6jGVpSsPgPAzSGAsHKJmm7kTyFg+rp1Y95hEhQdGu/Du80koYKyPI WAdK4rpXnQ5sgM9wxlRx6YPlGLmvvxZXNCMjFdWC2cqVVfV1lkU01XJjo9uvmAuMZ3PY pR9Z4zPWOgalslyfm3pr3/mQgbVeJFyzo4rb8b/EaMS/2q/D4HOl0yVvz21fy5HYW2es 6iyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iR7UBjy9b+GnDxxSAohGssAzGZu9g74Tp/QmVOl6H2Q=; b=uU+iFrKoEOmtLV3GXFufsvbNqv+O6Wu7NUv1m/YumMj+mmmwPV94HycfSJKBPr/XZy zLl7UhXh9Xpr1ZaK54+UTxWMGIWB133+LM8Tex3OVXUA7MJCtMQZpWeNg8fTIwDbOseM c+9kZcPdvdSToudyoAry0FyC1g6Pp4bCS3vCgw41vzvcTAYSOwAET+LbkuhyB+RK5KXs 3r+eCYRdOTSbqWozu6uqMKhAESn94I6KdnPia1RHPmgV5bWh1nrLOlahoU7WdkEf1TJ6 j92fXePf9dUPuivtMxnBpKFvUE6qym3+23xdtkVo9V0RNI5ttRQO5ACtGTfK7P7tsXtd CwBw== X-Gm-Message-State: AOAM5318JImisOXgxm7FhwyDPD9IXJgrMDX6NJ5NbIri33TNY1h5e4zN +b922L5gU8mU6w7X//eZEyxktltTQSI= X-Google-Smtp-Source: ABdhPJzWDElIsWsgZs5aFyQnkGgXFAh1NXyvJLsupvxSIpseD/CGSj1lFbaE7ttaa7WKZibdweL68Q== X-Received: by 2002:a1c:81d3:: with SMTP id c202mr24362378wmd.54.1593798163896; Fri, 03 Jul 2020 10:42:43 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:43 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Mathias Nyman , Lu Baolu Subject: [PATCH 18/30] usb: host: xhci-debugfs: Use 'gnu_printf' format notation Date: Fri, 3 Jul 2020 18:41:36 +0100 Message-Id: <20200703174148.2749969-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/host/xhci-debugfs.c:128:2: warning: function ‘xhci_debugfs_regset’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] 128 | vsnprintf(rgs->name, sizeof(rgs->name), fmt, args); | ^~~~~~~~~ Cc: Mathias Nyman Cc: Lu Baolu Signed-off-by: Lee Jones --- drivers/usb/host/xhci-debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-debugfs.c b/drivers/usb/host/xhci-debugfs.c index 76c3f29562d2b..92e25a62fdb5b 100644 --- a/drivers/usb/host/xhci-debugfs.c +++ b/drivers/usb/host/xhci-debugfs.c @@ -110,6 +110,7 @@ static void xhci_debugfs_free_regset(struct xhci_regset *regset) kfree(regset); } +__printf(6, 7) static void xhci_debugfs_regset(struct xhci_hcd *xhci, u32 base, const struct debugfs_reg32 *regs, size_t nregs, struct dentry *parent, From patchwork Fri Jul 3 17:41:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642491 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1E95B6C1 for ; Fri, 3 Jul 2020 17:43:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05BB3208FE for ; Fri, 3 Jul 2020 17:43:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mWYGekfi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727776AbgGCRnq (ORCPT ); Fri, 3 Jul 2020 13:43:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726956AbgGCRmq (ORCPT ); Fri, 3 Jul 2020 13:42:46 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52D22C08C5DD for ; Fri, 3 Jul 2020 10:42:46 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id k6so33581471wrn.3 for ; Fri, 03 Jul 2020 10:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BRma9lRqEYDVOCUnxuxL1ar6KYSuaKRVNlo6MvalKh8=; b=mWYGekfinDDvmP/iCmqV/aGkYJf6TP1fCPcz7wB25vsA8+FLckg8N9Orh4YU9GBn/J LnXRemGrce3PfQHQ02bLqOsJwHZSgzTTaFULUBk7HNn6wHu/7bJM2WWusHZKqVQseNTF TUmfsyRjzeqzo7RG5Arncs7yNnvFLUcMyADe7l3VoDzFTFRXeCc/P4bBM/NE4J9N4xRz uiuCZAVBHkjJ2NG1VnhYVRhKfwuMfIFpsty3kYsap8/Aa7O5rfvZCED2Jpn+WZsIuk/n 6huQcc3LZJY6QqbtVD/W7yN5yad9GobhUVi6igXsbAQcfy04fJ1fVqcE1mmm/UtI1ixZ B7Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BRma9lRqEYDVOCUnxuxL1ar6KYSuaKRVNlo6MvalKh8=; b=thEdA1OPeUeoyeHuzeS8l7lQnzt3yu0SfFJpGYhZ29livbMLYe2cqxM7/r1QignM6T PlN1olxSxxTkosipaAUtVytQB1QpQRlqLWNC4Oqe/nCzD+G6ISPlslPJkfo7zwla8BkF c060Ow3NPGMKKtmkQLqHJJCxnE+suRz1Vo0FNlAovPkxPt9Jc/CVRTNGBxNxrYFxravK 2X04sgmOmRNfrqXIBnlp2JB5NVQ/fo1OoyUdAkC/GdtMiu0zFXC3UDZKWyYgNMCVqZpj hlUqdbU8kU0flsb+WYZ2tVNALp0d7ytgDAa+SB88hFQ6mW+32yhxdpB4X6lnSwVZO+An 2cyQ== X-Gm-Message-State: AOAM533OkPJxMFCOW9aU4pAGYGRA5bxJaJSuByMPtm0oq2kaB4YbcnkF H7MekglPYPI/PhM8rLu+48PybmLgY64= X-Google-Smtp-Source: ABdhPJyONWDFPwyDvztIk4FcoSOK/rZ5PGRPGACL6sxaodQwaxlQC+PL+MLJ6JrU2yDAbU41YE1QXA== X-Received: by 2002:a05:6000:d0:: with SMTP id q16mr4673145wrx.166.1593798165048; Fri, 03 Jul 2020 10:42:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:44 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Alan Stern , Daniel Drake , usb-storage@lists.one-eyed-alien.net Subject: [PATCH 19/30] usb: storage: alauda: Remove set but unchecked variable Date: Fri, 3 Jul 2020 18:41:37 +0100 Message-Id: <20200703174148.2749969-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The return value of alauda_get_media_status() hasn't been checked since the driver's inception back in 2005. If nothing have gone wrong/been detected until this point, it's probably safe to just remove the variable. Fixes the following W=1 kernel build warning(s): drivers/usb/storage/alauda.c: In function ‘alauda_check_media’: drivers/usb/storage/alauda.c:456:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] 456 | int rc; | ^~ Cc: Alan Stern Cc: Daniel Drake Cc: usb-storage@lists.one-eyed-alien.net Signed-off-by: Lee Jones --- drivers/usb/storage/alauda.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c index ddab2cd3d2e75..20b857e97e60c 100644 --- a/drivers/usb/storage/alauda.c +++ b/drivers/usb/storage/alauda.c @@ -453,9 +453,8 @@ static int alauda_check_media(struct us_data *us) { struct alauda_info *info = (struct alauda_info *) us->extra; unsigned char status[2]; - int rc; - rc = alauda_get_media_status(us, status); + alauda_get_media_status(us, status); /* Check for no media or door open */ if ((status[0] & 0x80) || ((status[0] & 0x1F) == 0x10) From patchwork Fri Jul 3 17:41:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642485 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4D53B6C1 for ; Fri, 3 Jul 2020 17:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3450420870 for ; Fri, 3 Jul 2020 17:43:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gbM9zgU/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727049AbgGCRnj (ORCPT ); Fri, 3 Jul 2020 13:43:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726966AbgGCRms (ORCPT ); Fri, 3 Jul 2020 13:42:48 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CBECC08C5DE for ; Fri, 3 Jul 2020 10:42:48 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id j4so31133378wrp.10 for ; Fri, 03 Jul 2020 10:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xdK7p0WR4ZFrApshqcY/qhz6yObzd2ZId4hOv0Jm2xo=; b=gbM9zgU/ZtQMixrhY58EOrWoPPgzazeywce2gbfK5P1I84SGNf8Nu0SBKX+d68YMTv wi9405Ct0dsRs4puQmviTl91AT3FHELIv4KYmc6/uBxqOQVfGxIchVRWLT39VOsnD9dj iv/XQSGzxJTBXmvi/aCCRJxLysPARMi+m7S1+S4XfBcQY0JvZF9xAToZCKGTRJqm2fGc /jgKshjliUS0c9vtSW24xzpTKdikiD/Lc+TKcOQDdjiHZuChpAD3COK7Fa4YNd3QmsYd vagHiB2r6sq6uBbnY/IDijHrZIvE1qwTXYPWChLKhJcBZgnvvXhQjBI6w6xZqGm3Eip7 DRJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xdK7p0WR4ZFrApshqcY/qhz6yObzd2ZId4hOv0Jm2xo=; b=OWjri/t3DwYjcQjJGTC22exBIZArmd5GPZbMiHOIs6lu4KdQ0mTnrCpHwGoBMBTIdX UZ13jqgNE4HgtKt27vHCWf5l9YAp1YcvwovcbuzqXbGJwPKjmVq2kUM/LufoZi5gcb+7 BGieXP8pXJl63kvBLxGUHpoEoY2a7aHg88fHTC6sIBxtt2o2uQomZ1M9tRhSVDRH8Xsn mOyYH1MGZhK6UsHiWjsXgm5pDVxab8L3XbUwX2seOKYCyke38r0X3y5PM0pH9ySOkqbm OuTCA1ZgfZYw9qZ6Ij+7npXJ69wjVaS7lsKc4b3Ww9ZH7nm0SDedXSQkuMDgcVOxUIkF YA6w== X-Gm-Message-State: AOAM532HlZ0cfQMwolS9ieXoUjT+WIJBDCqrsax9oDZXwJbmueUmUXwg 8sKPO92A/x4phbmafcY2/lSqUw== X-Google-Smtp-Source: ABdhPJwaEUB7JhVt7ciPlaLA41ZcKUyXrM0MReikrMV76Gdvn4PvB0S1CBTLkWBqgXpEpkcO7tMK4g== X-Received: by 2002:a5d:54c9:: with SMTP id x9mr40004482wrv.247.1593798167196; Fri, 03 Jul 2020 10:42:47 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:46 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Heikki Krogerus Subject: [PATCH 20/30] usb: typec: altmodes: displayport: File headers are not good candidates for kerneldoc Date: Fri, 3 Jul 2020 18:41:38 +0100 Message-Id: <20200703174148.2749969-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Demote displayport's file header to a standard comment block. Fixes the following W=1 kernel build warning(s): drivers/usb/typec/altmodes/displayport.c:18: warning: Function parameter or member '_dp' not described in 'DP_HEADER' drivers/usb/typec/altmodes/displayport.c:18: warning: Function parameter or member 'cmd' not described in 'DP_HEADER' Cc: Heikki Krogerus Signed-off-by: Lee Jones --- drivers/usb/typec/altmodes/displayport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c index 0edfb89e04a86..d617663b981dd 100644 --- a/drivers/usb/typec/altmodes/displayport.c +++ b/drivers/usb/typec/altmodes/displayport.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * USB Typec-C DisplayPort Alternate Mode driver * * Copyright (C) 2018 Intel Corporation From patchwork Fri Jul 3 17:41:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642467 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CC266159A for ; Fri, 3 Jul 2020 17:42:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B386921473 for ; Fri, 3 Jul 2020 17:42:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dl3E5r/+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727004AbgGCRmx (ORCPT ); Fri, 3 Jul 2020 13:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726976AbgGCRmu (ORCPT ); Fri, 3 Jul 2020 13:42:50 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4569C08C5E0 for ; Fri, 3 Jul 2020 10:42:49 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id q5so33547083wru.6 for ; Fri, 03 Jul 2020 10:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=piaZjSKwN5mcD2WCsbLuxlkVKn2CDEU6jf4+7AdAFG0=; b=Dl3E5r/+ISNoKksiACvDF+AOJrMn8bNdiaS9+MMjXnyV7h+/tY761qxP6vpaTVO5hV m7KXm2vbCYtzbm/e6PB6/xlexgvuvMv3oDf8axHZks1ki2lYz/sQ7w+DyCufp4t32Pme Xbfd0e387SdGAJ9oE7JpPgQyS3h+Nutxu1tQoz0vTADACnL6ioQfDw+aA9HjCBXED5v4 g0b4fm2MWSHFmv8lLrjJQqZyfvkM73myX3Tj/9pWFpkuw0jo2WZNxJ5/GxdTXjsJUejg JZ8HaIXZf6UoZA4CWj2d/5xj2lDYNjttntoG3XyQ0pLG7APG05lj0DVBGSJEos+i/Isv V5bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=piaZjSKwN5mcD2WCsbLuxlkVKn2CDEU6jf4+7AdAFG0=; b=eswb2IsD69SSqk0i31oDt+qyfOzjT85F4PvVv79M8NVj8LV/jB2hayhFrj2So1uJaU MpVCi+MFTQEo+Xx051+eYmE/o64n6Kcea2S0H+CNhf97Y+r1WFJ4VddHwue+L0AQAdLZ 7M0mVo5XeVBXAj2H6NstX2V3V8MuLbeu/Vvb+BqsBGG8oaRZ9/XO8AFKNEIllPMDKz7Q HRUtXy188O4VZBObzi2aZ1Ydi9WEsbc+VxCQJpkLwq/EbcP333itCrByEe0tXKEpakYR NRI5snGXBI46YbMtstNbxk8sR0qGsNCx70ycshxyxM0N8npmXkSgC9OaN8/Aiynnj9vJ wCKw== X-Gm-Message-State: AOAM530tXYT4VyHvq9RB94rD5CKoetv9NHTUpp7b44J5hq0D0PmwFxP5 amHfhF+fN+bVi22lm14BTnHV7Q== X-Google-Smtp-Source: ABdhPJxhEOpZuuHTnIVb62hGJQJQm3MlFDlRAJw3+Es5D9qbc2oy4oi5j5/PHHfCqHf75Lcu2tEXCg== X-Received: by 2002:a5d:4986:: with SMTP id r6mr36384666wrq.424.1593798168464; Fri, 03 Jul 2020 10:42:48 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:47 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Heikki Krogerus Subject: [PATCH 21/30] usb: typec: altmodes: displayport: Supply missing displayport.h include file Date: Fri, 3 Jul 2020 18:41:39 +0100 Message-Id: <20200703174148.2749969-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org If the header file containing a function's prototype isn't included by the sourcefile containing the associated function, the build system complains of missing prototypes. Fixes the following W=1 kernel build warning(s): drivers/usb/typec/altmodes/displayport.c:511:5: warning: no previous prototype for ‘dp_altmode_probe’ [-Wmissing-prototypes] drivers/usb/typec/altmodes/displayport.c:551:6: warning: no previous prototype for ‘dp_altmode_remove’ [-Wmissing-prototypes] Cc: Heikki Krogerus Signed-off-by: Lee Jones --- drivers/usb/typec/altmodes/displayport.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c index d617663b981dd..7b20073d7fc0a 100644 --- a/drivers/usb/typec/altmodes/displayport.c +++ b/drivers/usb/typec/altmodes/displayport.c @@ -13,6 +13,7 @@ #include #include #include +#include "displayport.h" #define DP_HEADER(_dp, cmd) (VDO((_dp)->alt->svid, 1, cmd) | \ VDO_OPOS(USB_TYPEC_DP_MODE)) From patchwork Fri Jul 3 17:41:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642465 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 77E7214B7 for ; Fri, 3 Jul 2020 17:42:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F52721473 for ; Fri, 3 Jul 2020 17:42:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uY+ZNl+v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726995AbgGCRmx (ORCPT ); Fri, 3 Jul 2020 13:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726989AbgGCRmv (ORCPT ); Fri, 3 Jul 2020 13:42:51 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82AF6C08C5DD for ; Fri, 3 Jul 2020 10:42:51 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o8so32746262wmh.4 for ; Fri, 03 Jul 2020 10:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vJCnefTtfM/FBJNDBw7Za4SdXSiMtlhk/VCZxXdb06o=; b=uY+ZNl+vJh/8ZKEUOcnoazw3UlFZGm64iZn/WQXAwEShl1+iT+iTmIwEf/Jx8IskjI qBGw7nEY6dEUOrexC4u1LRiL9SdnCegSf0mmgfxfcOWxwdeLf3ed6L/OqNpxGK26weBn P6pJRNCWqcN47c2iFGRdlwjvm8DQ+zhYqMhC9+oOVs11vB18NiKjt4ivDufF1t9LyG6c 2Vqb/BytWBtmCSbCzXvhZ7vvo8HHeT2aQdv9LAr4huXaOY+bdb3hBCPNb6vxYp2qU/FE /eiep166NE/4yENCBpA6DvdVcZ9Sjm38FZTnd9C08GGzcfk6owQqxVxS4TUlvGJ3iMH6 yhvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vJCnefTtfM/FBJNDBw7Za4SdXSiMtlhk/VCZxXdb06o=; b=MOt0AnIxcV2oXHYTe75Jc4hG0OKzu+vw7r1vz9vXNyWBQRadYU6bTvUHo7rZhvHN1c //SdV2A9rGcnDmSTQW3vJr8N3zQfgTBuPDcMWwg32rrdKRpaEYxZswUG2YbZDZd/GDPN JyVISNIbWMb372NVpDSWJJrdg8jr+XuJ0c2vMxcqXYTL8wvmKjaL5fR1PFzULW5oxhlF rZJHYt87Ijc5/T6vS0vzu+SEz1uqUL2lBM20pK2osC4NhtMvAfHzqZk17bIv7KPFaMLy FWWk2hs+jkJzMKjFoCUGjY26XXJ0KcyJEuTWE6RcgFsjR1Cn2FXkJTV8RQ0TUcm30aIJ CRRQ== X-Gm-Message-State: AOAM530s4Lvc1TmKYI174vGJMuqn+YSz/5FOpNSnprUJqbMXEzHr8LgB V5LXfgN3xwoD3Ktt27/CTCI4XQ== X-Google-Smtp-Source: ABdhPJysKzxS4hjJTRoccGdJEFKt9Uhy6x3GEl2dYE9hZrX5YGXPDhlo2QS2O0WssrmUH0r3f2lOtw== X-Received: by 2002:a1c:398b:: with SMTP id g133mr36497818wma.76.1593798170305; Fri, 03 Jul 2020 10:42:50 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:49 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Guenter Roeck , Heikki Krogerus , Yueyao Zhu Subject: [PATCH 22/30] usb: typec: tcpm: fusb302: Use 'gnu_printf' format notation Date: Fri, 3 Jul 2020 18:41:40 +0100 Message-Id: <20200703174148.2749969-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/typec/tcpm/fusb302.c: In function ‘fusb302_log’: drivers/usb/typec/tcpm/fusb302.c:186:2: warning: function ‘fusb302_log’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] 186 | _fusb302_log(chip, fmt, args); | ^~~~~~~~~~~~ Cc: Guenter Roeck Cc: Heikki Krogerus Cc: Yueyao Zhu Signed-off-by: Lee Jones Reviewed-by: Guenter Roeck --- drivers/usb/typec/tcpm/fusb302.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c index b28facece43c4..99562cc65ca69 100644 --- a/drivers/usb/typec/tcpm/fusb302.c +++ b/drivers/usb/typec/tcpm/fusb302.c @@ -178,6 +178,7 @@ static void _fusb302_log(struct fusb302_chip *chip, const char *fmt, mutex_unlock(&chip->logbuffer_lock); } +__printf(2, 3) static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...) { va_list args; From patchwork Fri Jul 3 17:41:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642481 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 497AB6C1 for ; Fri, 3 Jul 2020 17:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 302CD2088E for ; Fri, 3 Jul 2020 17:43:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E+eqmQcJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbgGCRn3 (ORCPT ); Fri, 3 Jul 2020 13:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726999AbgGCRmx (ORCPT ); Fri, 3 Jul 2020 13:42:53 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FAD3C061794 for ; Fri, 3 Jul 2020 10:42:53 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o2so34857714wmh.2 for ; Fri, 03 Jul 2020 10:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kET32cWBEbf+azZpl4b9S5hhud6fCuzb1HVS2JBoyeg=; b=E+eqmQcJjcmnr2u4Nr9qPSNrgPa0cqnh4p53vmQ7P1dwDX9UnVYEjQxvClD1uAJ9Et uzhmv5h+j90jPdmZ2+ERqI5c22248cZINxdUx6F+2myWrFrXFgqpf6eNpKYa0O/MBx3m eev4UTe30wi7JJHgf7OfYcxQTuv4BeTaWmQJIpWM9KzuYepaK8oC+fcYIppNmp23TMX2 G/yTZk7ZYVnMpw77HcYQ80Pw2EvMp3Q2JJV932kBQn/XCfqsumQIuKyABQHBYFREEhwR 3HBMjRlr2ascNOBsgGi8i4ez9fFsEC2RFybCAEcAcHKjodJycriwHG1mFqRAFz/TlBla o7+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kET32cWBEbf+azZpl4b9S5hhud6fCuzb1HVS2JBoyeg=; b=Dba3xjIyOC3Mg4TQ3wOJsLGlJ3eqF8ratO9iiu9EzkEjvyoQtA8OKYJBVA8Gb7Ee6O c/RCHBzL1+gdEGk9j4/E113pGfBKMrS53M9Q1IUpF4SoK+PnAtmV9PoARvAq+B/aspeX G3DmNktVwjSAS8EKJ216yD8DX5n6ATGiiVaiPmIrbdIMdVBw9hK1kOumUx/yjCOLu90d xWGyZ8H5YGX5HZwzfsY95CpVAcnqcS6VnDs6MCvlrXsvUCbWUF1wGhAXXcvt3hOpK0ie UexWWyqBsTWuSbglRdgP/3i9L/KdBZNRao9ye2bjkhqwFCLI0pieMHNYlZhfJBX7f2pf kFHA== X-Gm-Message-State: AOAM5326klASI6Xw/AKOuLt+I6AFg25rYm3wUJeibl3LHtZaPE4/f7vi MwCuxwNiUbmABdBxxGEz3VG6SA== X-Google-Smtp-Source: ABdhPJx+kvzQZ7rH7eOuqZcSpRb7jmBkzPEVOp4RMNOQJpQ/CkWOVZU3h/qUTZDxWMj0S80UE1YZlA== X-Received: by 2002:a1c:3504:: with SMTP id c4mr4441366wma.177.1593798171685; Fri, 03 Jul 2020 10:42:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:51 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Peter Chen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Richard Zhao Subject: [PATCH 23/30] usb: chipidea: usbmisc_imx: Demote obvious misuse of kerneldoc to standard comment block Date: Fri, 3 Jul 2020 18:41:41 +0100 Message-Id: <20200703174148.2749969-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/usbmisc_imx.c:801: warning: Function parameter or member 'data' not described in 'imx7d_charger_detection' Cc: Peter Chen Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Richard Zhao Signed-off-by: Lee Jones --- drivers/usb/chipidea/usbmisc_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c index f136876cb4a30..8a8e7ad928a61 100644 --- a/drivers/usb/chipidea/usbmisc_imx.c +++ b/drivers/usb/chipidea/usbmisc_imx.c @@ -789,7 +789,7 @@ static int imx7d_charger_primary_detection(struct imx_usbmisc_data *data) return 0; } -/** +/* * Whole charger detection process: * 1. OPMODE override to be non-driving * 2. Data contact check From patchwork Fri Jul 3 17:41:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642479 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 886C26C1 for ; Fri, 3 Jul 2020 17:43:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BEA2208E4 for ; Fri, 3 Jul 2020 17:43:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZJ9YkqRC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727108AbgGCRn2 (ORCPT ); Fri, 3 Jul 2020 13:43:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726945AbgGCRmy (ORCPT ); Fri, 3 Jul 2020 13:42:54 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA271C08C5DD for ; Fri, 3 Jul 2020 10:42:54 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id g75so32749650wme.5 for ; Fri, 03 Jul 2020 10:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ar/8CXa0JGn4ACsDbJKg13GYxeqcnHfkQOqZqxVb5Xk=; b=ZJ9YkqRCR08W7D/BoyIV25JCVqlnsEAFqL/a7+GssUrikvJ3UgUMYFFVr4kb6PlfkP PbEu/8Uy/n+c6uq+uHe3+nd6v/dr7FD5VjlMHCvl3xObQ5xGJshqkgN+Jxtt7679kskB QR6eC0Jr+WTrpNO/QE2ddYQ3aCYDTWlt0Zmc8ijuvi1X7m1BFEK4o9ssVxNpSo5a9Lg3 DI5y2oxQ+iaeIfSi30Qo4bcIEd+idvYXfrz7+waxin9TDsyAFkMhisTWqauwWGKu2Hv2 tmRh3A+nSgtNzrT5raJfpL0gBQUD8a/vgo3jBXXMWiSgBaf1Aof3yoiB0TXmXdxMNFhE u9KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ar/8CXa0JGn4ACsDbJKg13GYxeqcnHfkQOqZqxVb5Xk=; b=G7QdBq9IU7JkoQ1OciGFW8oKxfiW7+oni4ytbwlWCJg2QhwreIsD/+kGCNFNgyf3n9 ARZCiimHuFt07vL+pADDHlRfXsyYCbhFwB8QZIPMAJMQ9nwRl+OvxQU4qmHK2Gy2FUUY 2b2QP9KbD2lnAgIcihKBHQcwNi9sIPpU+p/ryTABHBPGXagsEiqyRast54zp+iKfpGJB oXwKS/8YY/vYOh46NtsER/04nBSJNRS8btKmA4VqCYs8Mb0bYsRrrIGB4Bo2ij2AWUGk 8H7FaXm9nKshpVVbjdbm2MiYS3rCC0Ldxo7A/6MF5KmrKJPDmabwdroByfQB8OwpvAFO GgTQ== X-Gm-Message-State: AOAM530sbT8vk5JKFECxvI8oER6HfgO8bvaHMZ8K4QfUn9FfOQ8Fs6F8 8JJbkXEvq+dRRZb/y09ksh4ZuQ== X-Google-Smtp-Source: ABdhPJz/OvxTAkEUca7rh74VV65Ur3XQuwUIc/y51MuJ27q7FM/HDh2vT2rioaHvtnLRjIXkbXLZig== X-Received: by 2002:a7b:c099:: with SMTP id r25mr40040224wmh.159.1593798173424; Fri, 03 Jul 2020 10:42:53 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:52 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Johan Hovold , Christian Lucht , Stephane Dalton , Stephane Doyon Subject: [PATCH 24/30] usb: misc: iowarrior: Fix odd corruption issue in the file header Date: Fri, 3 Jul 2020 18:41:42 +0100 Message-Id: <20200703174148.2749969-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Looks although Stephane's name was corrupted somehow. Cc: Johan Hovold Cc: Christian Lucht Cc: Stephane Dalton Cc: Stephane Doyon Signed-off-by: Lee Jones --- drivers/usb/misc/iowarrior.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index dce20301e367a..40e8c06894bff 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -9,7 +9,7 @@ * usb-skeleton.c by Greg Kroah-Hartman * brlvger.c by Stephane Dalton - * and St�hane Doyon + * and Stephane Doyon * * Released under the GPLv2. */ From patchwork Fri Jul 3 17:41:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642483 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 805336C1 for ; Fri, 3 Jul 2020 17:43:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BABD2088E for ; Fri, 3 Jul 2020 17:43:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hdDJM1wU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727105AbgGCRn2 (ORCPT ); Fri, 3 Jul 2020 13:43:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727014AbgGCRm4 (ORCPT ); Fri, 3 Jul 2020 13:42:56 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0750FC08C5DD for ; Fri, 3 Jul 2020 10:42:56 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id o11so33585696wrv.9 for ; Fri, 03 Jul 2020 10:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ISJzLOqlSFQczkvc3nK58bGo6HT98YijZfD9JIzoDdI=; b=hdDJM1wUbe6Ydmnsq4OtW1IpkqyR5cZyO21yDrMUJB1fPRtE9PXgy9WLg9uyjpLjDk 02rvMWgwad9utS1g6bYTUJKX7YVCsq7Xs7//+phOH0Oi67PsV5lSVQdrkOAxOaz4tsQW KY+BgAb4/zf/Edqb5LDhPlUnPqTljgNt1UPtf3jD3WyDnAvR0z99qifIMbsQ0kwKpBKV Ite1MzW2DvZHvyOU6ALS9uUvdSlb6fFhLsh8xPfS7tsakPpgDNHMum8UEPMF5+ekR/rR nFk+JrvtjyhLapCvYjvvytXS9fNnf2ED2grHZRNAmLSgpIQYeigPbYlkngsCTR8BeljI +WZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ISJzLOqlSFQczkvc3nK58bGo6HT98YijZfD9JIzoDdI=; b=fFmts81q8LPInFlH0kuGpzHjQ215KEIphGrIaVeCR555a6IXHfEk20NP5VhDteqwKH OIf5z/Zo8l8WsTUd6BLvEDhjPpCvaeLVeimwhZMwVDB6Dc0JIfwZsuOsqsm27fqdIll7 I++BeVeO1jv92bFMv1Tw/bV3xL5m9XjCt2R4CY0pXFegXElaX266tBosTCISjZz1TFHF CUy7JYtayKG7I3UMJJSQ4+fuc9rtpFckKcHbivMjT3pk55c86FJC52UWBFgZfR+XQw53 ZailO2vzuf2pqTXYKZ2d0CxptGpPkQP78I04FyNPympLkYjJljaQMI7xVEt1e/I3HOLL wuhQ== X-Gm-Message-State: AOAM531moz8uf/8xXKHSiL/qv1HiquvRQLhPFMvKCf+zPQkIpXPYpkGk sHTSIdkwuUNElaMd9wh1KdZcsg== X-Google-Smtp-Source: ABdhPJwhbYBajzI+AeT8gPceWRCmWE8E9ElSc7oYeCmS6lqdip6cntrVuot3YBb3WbRXMC6UURMhIg== X-Received: by 2002:adf:fcc5:: with SMTP id f5mr41969478wrs.60.1593798174786; Fri, 03 Jul 2020 10:42:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:54 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Johan Hovold , Christian Lucht , Stephane Dalton , Stephane Doyon Subject: [PATCH 25/30] usb: misc: iowarrior: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 3 Jul 2020 18:41:43 +0100 Message-Id: <20200703174148.2749969-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/misc/iowarrior.c:251: warning: Function parameter or member 'dev' not described in 'iowarrior_delete' drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'file' not described in 'iowarrior_read' drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'buffer' not described in 'iowarrior_read' drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'count' not described in 'iowarrior_read' drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'ppos' not described in 'iowarrior_read' drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'file' not described in 'iowarrior_ioctl' drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'cmd' not described in 'iowarrior_ioctl' drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'arg' not described in 'iowarrior_ioctl' drivers/usb/misc/iowarrior.c:599: warning: Function parameter or member 'inode' not described in 'iowarrior_open' drivers/usb/misc/iowarrior.c:599: warning: Function parameter or member 'file' not described in 'iowarrior_open' drivers/usb/misc/iowarrior.c:647: warning: Function parameter or member 'inode' not described in 'iowarrior_release' drivers/usb/misc/iowarrior.c:647: warning: Function parameter or member 'file' not described in 'iowarrior_release' drivers/usb/misc/iowarrior.c:753: warning: Function parameter or member 'interface' not described in 'iowarrior_probe' drivers/usb/misc/iowarrior.c:753: warning: Function parameter or member 'id' not described in 'iowarrior_probe' drivers/usb/misc/iowarrior.c:879: warning: Function parameter or member 'interface' not described in 'iowarrior_disconnect' Cc: Johan Hovold Cc: Christian Lucht Cc: Stephane Dalton Cc: Stephane Doyon Signed-off-by: Lee Jones --- drivers/usb/misc/iowarrior.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 40e8c06894bff..4afd1ace3d32c 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -244,7 +244,7 @@ static void iowarrior_write_callback(struct urb *urb) wake_up_interruptible(&dev->write_wait); } -/** +/* * iowarrior_delete */ static inline void iowarrior_delete(struct iowarrior *dev) @@ -271,7 +271,7 @@ static int read_index(struct iowarrior *dev) return (read_idx == intr_idx ? -1 : read_idx); } -/** +/* * iowarrior_read */ static ssize_t iowarrior_read(struct file *file, char __user *buffer, @@ -475,7 +475,7 @@ static ssize_t iowarrior_write(struct file *file, return retval; } -/** +/* * iowarrior_ioctl */ static long iowarrior_ioctl(struct file *file, unsigned int cmd, @@ -592,7 +592,7 @@ static long iowarrior_ioctl(struct file *file, unsigned int cmd, return retval; } -/** +/* * iowarrior_open */ static int iowarrior_open(struct inode *inode, struct file *file) @@ -640,7 +640,7 @@ static int iowarrior_open(struct inode *inode, struct file *file) return retval; } -/** +/* * iowarrior_release */ static int iowarrior_release(struct inode *inode, struct file *file) @@ -742,7 +742,7 @@ static struct usb_class_driver iowarrior_class = { /*---------------------------------*/ /* probe and disconnect functions */ /*---------------------------------*/ -/** +/* * iowarrior_probe * * Called by the usb core when a new device is connected that it thinks @@ -870,7 +870,7 @@ static int iowarrior_probe(struct usb_interface *interface, return retval; } -/** +/* * iowarrior_disconnect * * Called by the usb core when the device is removed from the system. From patchwork Fri Jul 3 17:41:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642477 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F39914B7 for ; Fri, 3 Jul 2020 17:43:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0737F20870 for ; Fri, 3 Jul 2020 17:43:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FIagus93" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727091AbgGCRnV (ORCPT ); Fri, 3 Jul 2020 13:43:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727022AbgGCRm5 (ORCPT ); Fri, 3 Jul 2020 13:42:57 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70283C08C5DF for ; Fri, 3 Jul 2020 10:42:57 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id k6so33581878wrn.3 for ; Fri, 03 Jul 2020 10:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SYWwkgSPDIgouMfzyNf8caHaLbWDeyv2rcH01GGvlwk=; b=FIagus93ZBIMXIzVrgZHDBEEUg/b5rSvyh4Hjl1apX65iTrYxfN7M6m0U1se57NfwG AMAnabxTOjXzH+qeXftOTmXkt6iVi+tFloOT1b75k5tBrPL4F3Pz6ByWaNMda2fUKvBQ Nfsvnq9vuXjPog2ODt9TYrvxJcIRCbWYQYwc0PBNoUrXDPhB44nPxdeBnvVmzqSzxgTD LJV4eItrfpTRuqhRhIkWVigXqwyl+VrP/HaPOwOJ7p2s3AXAkJUopVPwmD8gGCG4RfJr TMTV7FTl1+RO7WMt+3zzPXGZ11hrR3JJ4e0srVy5hAsMi1qcO0shJjmlXn4otHv5LVZZ JC7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SYWwkgSPDIgouMfzyNf8caHaLbWDeyv2rcH01GGvlwk=; b=GrWCw3nWVlAr4KouNIDWw2gYEvstLN3/4x0KzUYQL6CqSDeDEYIQFs75HzEqK6aeDe 7gomRbfufwSL9crwsyCFhdbex8goU+U1RJV0YeydA3kaj0nXVjnAPenyT5XQsoqa/7IM a1meBlTd6Fq1/hecEIEbPuJ6ATN2EoKWk2SF7zfsW+sWwFuv9TJywzu11FGBVNw+hPZc LzJX+AmAx4/fbOgEjUwREHNUp6BOU+0A/XagJevKkNZWy7V1AicfwujakGsFY1S3M5SF 4LuzaqF0R+il2p89r49o3XSIYXPXBYxTkFGFwxpQHDVa3/F/E8F4BUdjbyRKB6hnHAdB qZYA== X-Gm-Message-State: AOAM5326kvF5Jjf05fH4h6LiNbl8eQNXXV894jjKUHPb7Wv6KdfzYkFO A7TrQQoEBJsqkbigRsIK4Hbo6g== X-Google-Smtp-Source: ABdhPJx0xhAIeeMVJ7701j/QMOLoGiJ8xgSFIS82zFsNrKSO5MmnhpfCqseg2k0p0otT85xs0+B7GA== X-Received: by 2002:a05:6000:1008:: with SMTP id a8mr39019528wrx.416.1593798176240; Fri, 03 Jul 2020 10:42:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:55 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Felipe Balbi , =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= , Al Borchers , Peter Berger Subject: [PATCH 26/30] usb: gadget: function: u_serial: Repair misdocumented function argument Date: Fri, 3 Jul 2020 18:41:44 +0100 Message-Id: <20200703174148.2749969-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Looks as though this has been an issue since the driver's inception back in 2014. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/u_serial.c:538: warning: Function parameter or member 'port' not described in 'gs_start_io' drivers/usb/gadget/function/u_serial.c:538: warning: Excess function parameter 'dev' description in 'gs_start_io' Cc: Felipe Balbi Cc: "Michał Mirosław" Cc: Al Borchers Cc: Peter Berger Signed-off-by: Lee Jones --- drivers/usb/gadget/function/u_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c index 3cfc6e2eba71a..c295defe7ecd3 100644 --- a/drivers/usb/gadget/function/u_serial.c +++ b/drivers/usb/gadget/function/u_serial.c @@ -527,7 +527,7 @@ static int gs_alloc_requests(struct usb_ep *ep, struct list_head *head, /** * gs_start_io - start USB I/O streams - * @dev: encapsulates endpoints to use + * @port: port to use * Context: holding port_lock; port_tty and port_usb are non-null * * We only start I/O when something is connected to both sides of From patchwork Fri Jul 3 17:41:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642469 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E50056C1 for ; Fri, 3 Jul 2020 17:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C70132084C for ; Fri, 3 Jul 2020 17:43:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PqlMQ+89" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbgGCRnB (ORCPT ); Fri, 3 Jul 2020 13:43:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727045AbgGCRm7 (ORCPT ); Fri, 3 Jul 2020 13:42:59 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B928C08C5E0 for ; Fri, 3 Jul 2020 10:42:59 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j4so31133838wrp.10 for ; Fri, 03 Jul 2020 10:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VAH0h+7DeZ3eQjU7VALJC/mf2qMz8anOgwTIw8YZObw=; b=PqlMQ+89zMViNPk7JL5130tgUlbfPGYO64AK9MX0N4n06iS4TcAGsDGRMlCqj/pLc4 J7LXAhiaUeGsjyG6alIrflqs8cE9EUzRJxrzjIgV4Yn8DOhedEbVURZIu8RG6k3K0+k1 vDuR7IPN3O/ymZb5dVv1YzrGrTJwsbIF/ioCS5GI0RU1XrxXvWedyGPmAP4IhR/CuSjo itAnCnYz27iOwJdYedBW9z+9UFp06jyHOZAY5e9JzO2IDH2ldJlKr6OPo2600mUwNwY+ +4RWwtan+5aC8XkRvuarA9Nrm5tJYS29s4fJWjGzdwrw6u2kCnRtykuQ1yQzyQOYA+Is hRlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VAH0h+7DeZ3eQjU7VALJC/mf2qMz8anOgwTIw8YZObw=; b=r2VgChHMuwnQJgYIEPJGkApMxSFFzknJy5i/gFpmLNhWscWM6hYxoj5CHCAAijitnG dkgu2wkLth0j0axTAWk5/kRbeIjMC44TjL5ePapoWG+q3LbN/hWlmh8JNBq52nHef7EK w1SgNybHzkyu9CGhYRDIRulznZDhfagcWcBdO5Y9Y9kFohirIiUe8DHHC4AlGx2hcr1E Ql5Yiu8tp1+T05LTCtYchVxyCod2ImwBcQNQ7UYkQt6yx31l/eTwLAgqgxIHIRWbk46c tiVT3i3rnbQfC/qtaEMRJupc0N+KjPkYFvK3hCNv9Mq36aso4CCzVXz8+qeXR+np1riq UywA== X-Gm-Message-State: AOAM533sBax9ZUQwht3fCs8txpogG3eOYccES3AZO+sz8+N4fGBinFrf DED50NQb/VKFX+Tgr1q7HVXf3A== X-Google-Smtp-Source: ABdhPJwvENXbvIfsvJuGeCkbqKnfV/8/YK5NLdOwN0orSzzJI2mmMqY6taVoPjgC6b3Rw9Xggnm+pA== X-Received: by 2002:a5d:6748:: with SMTP id l8mr42092231wrw.347.1593798178228; Fri, 03 Jul 2020 10:42:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:57 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Johan Hovold , Michael Hund , David Glance , Juergen Stuber Subject: [PATCH 27/30] usb: misc: ldusb: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 3 Jul 2020 18:41:45 +0100 Message-Id: <20200703174148.2749969-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/misc/ldusb.c:192: warning: Function parameter or member 'dev' not described in 'ld_usb_abort_transfers' drivers/usb/misc/ldusb.c:206: warning: Function parameter or member 'dev' not described in 'ld_usb_delete' drivers/usb/misc/ldusb.c:220: warning: Function parameter or member 'urb' not described in 'ld_usb_interrupt_in_callback' drivers/usb/misc/ldusb.c:281: warning: Function parameter or member 'urb' not described in 'ld_usb_interrupt_out_callback' drivers/usb/misc/ldusb.c:301: warning: Function parameter or member 'inode' not described in 'ld_usb_open' drivers/usb/misc/ldusb.c:301: warning: Function parameter or member 'file' not described in 'ld_usb_open' drivers/usb/misc/ldusb.c:372: warning: Function parameter or member 'inode' not described in 'ld_usb_release' drivers/usb/misc/ldusb.c:372: warning: Function parameter or member 'file' not described in 'ld_usb_release' drivers/usb/misc/ldusb.c:414: warning: Function parameter or member 'file' not described in 'ld_usb_poll' drivers/usb/misc/ldusb.c:414: warning: Function parameter or member 'wait' not described in 'ld_usb_poll' drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'file' not described in 'ld_usb_read' drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'buffer' not described in 'ld_usb_read' drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'count' not described in 'ld_usb_read' drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'ppos' not described in 'ld_usb_read' drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'file' not described in 'ld_usb_write' drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'buffer' not described in 'ld_usb_write' drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'count' not described in 'ld_usb_write' drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'ppos' not described in 'ld_usb_write' drivers/usb/misc/ldusb.c:651: warning: Function parameter or member 'intf' not described in 'ld_usb_probe' drivers/usb/misc/ldusb.c:651: warning: Function parameter or member 'id' not described in 'ld_usb_probe' drivers/usb/misc/ldusb.c:754: warning: Function parameter or member 'intf' not described in 'ld_usb_disconnect' Cc: Johan Hovold Cc: Michael Hund Cc: David Glance Cc: Juergen Stuber Signed-off-by: Lee Jones --- drivers/usb/misc/ldusb.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index 8f86b4ebca898..670e4d91e9cae 100644 --- a/drivers/usb/misc/ldusb.c +++ b/drivers/usb/misc/ldusb.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0+ -/** +/* * Generic USB driver for report based interrupt in/out devices * like LD Didactic's USB devices. LD Didactic's USB devices are * HID devices which do not use HID report definitons (they use @@ -184,7 +184,7 @@ struct ld_usb { static struct usb_driver ld_usb_driver; -/** +/* * ld_usb_abort_transfers * aborts transfers and frees associated data structures */ @@ -199,7 +199,7 @@ static void ld_usb_abort_transfers(struct ld_usb *dev) usb_kill_urb(dev->interrupt_out_urb); } -/** +/* * ld_usb_delete */ static void ld_usb_delete(struct ld_usb *dev) @@ -213,7 +213,7 @@ static void ld_usb_delete(struct ld_usb *dev) kfree(dev); } -/** +/* * ld_usb_interrupt_in_callback */ static void ld_usb_interrupt_in_callback(struct urb *urb) @@ -274,7 +274,7 @@ static void ld_usb_interrupt_in_callback(struct urb *urb) wake_up_interruptible(&dev->read_wait); } -/** +/* * ld_usb_interrupt_out_callback */ static void ld_usb_interrupt_out_callback(struct urb *urb) @@ -294,7 +294,7 @@ static void ld_usb_interrupt_out_callback(struct urb *urb) wake_up_interruptible(&dev->write_wait); } -/** +/* * ld_usb_open */ static int ld_usb_open(struct inode *inode, struct file *file) @@ -365,7 +365,7 @@ static int ld_usb_open(struct inode *inode, struct file *file) return retval; } -/** +/* * ld_usb_release */ static int ld_usb_release(struct inode *inode, struct file *file) @@ -407,7 +407,7 @@ static int ld_usb_release(struct inode *inode, struct file *file) return retval; } -/** +/* * ld_usb_poll */ static __poll_t ld_usb_poll(struct file *file, poll_table *wait) @@ -431,7 +431,7 @@ static __poll_t ld_usb_poll(struct file *file, poll_table *wait) return mask; } -/** +/* * ld_usb_read */ static ssize_t ld_usb_read(struct file *file, char __user *buffer, size_t count, @@ -518,7 +518,7 @@ static ssize_t ld_usb_read(struct file *file, char __user *buffer, size_t count, return retval; } -/** +/* * ld_usb_write */ static ssize_t ld_usb_write(struct file *file, const char __user *buffer, @@ -641,7 +641,7 @@ static struct usb_class_driver ld_usb_class = { .minor_base = USB_LD_MINOR_BASE, }; -/** +/* * ld_usb_probe * * Called by the usb core when a new device is connected that it thinks @@ -745,7 +745,7 @@ static int ld_usb_probe(struct usb_interface *intf, const struct usb_device_id * return retval; } -/** +/* * ld_usb_disconnect * * Called by the usb core when the device is removed from the system. From patchwork Fri Jul 3 17:41:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642473 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B963C6C1 for ; Fri, 3 Jul 2020 17:43:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9274F21556 for ; Fri, 3 Jul 2020 17:43:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k1VNV8Cq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbgGCRnD (ORCPT ); Fri, 3 Jul 2020 13:43:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727051AbgGCRnC (ORCPT ); Fri, 3 Jul 2020 13:43:02 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6E99C08C5DD for ; Fri, 3 Jul 2020 10:43:01 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z15so22290265wrl.8 for ; Fri, 03 Jul 2020 10:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pvsQ2j2MIPqkZ3jkOQAkyhlMqXenxaz7Doasiynl+ug=; b=k1VNV8Cq6YZ7ALXAmL5SY7ZkZfumiTzDFOzauoO28aylJDHFQFNlPWaN6vTjNXCwp7 8pA/rt/83pE8YtL+zcZUXuRVoFtqfnp7lThQHbVkywE49Yko32o288yP4Ap725xsFmNy u0AbX34iOhF9iVrTlF8M8O98Bhmq3RhZ3ArhLg8gNPwyg1MQHzEQ5ATD7+W4aHbxOjxR +IiPmILgTdIinpTc97X9LofUDKxr/mU/xEmv+I8GeMYxioHZvlDPcbe3YiTbDW9rluOS r9aQUCOhNZ2UIoi4q2atKUd2YUrddfAmU//sgzTcbNN2qn9sssku+0kCWIRhF7YoIcKS hZtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pvsQ2j2MIPqkZ3jkOQAkyhlMqXenxaz7Doasiynl+ug=; b=aIWEFsRw6ld+g1PY35AhIRlkB6LrqYp3yr15HtcibAoarqlUpPS6EBvSg4WWz/uqdh QzP+qYgcqxmb3NHo36MmP/eeVE88dWLfdxAJkqi9XMMoOppBBZtf9EIolhBHPMy51IrY 8r2yvAWFWCAdzqVihU0xNlqczMwcKRjmiz+rmVpTQzdg4vGLPBF6Wp4LVD5ImBMpaq6A KxOhvOkG0WPVVG9lQK3iuwZQy9BfNk90+M/qf/6mw0ohQg5Pkbpw73hvCKEJTgkx+ndF WOCG1vZxhU62miEqMcBfXaa9tLZpHMAoQqymRDU5WMxiffy2QcOC2gQwVkuiisOCJzSE VcQQ== X-Gm-Message-State: AOAM531TMTFPYoRzso4znjkJKHhuH9OIU/zrJq32Fgabv2xe3MM+YEjA GGSvu7GpfIyDs1kfy86TFKm80uLj4OY= X-Google-Smtp-Source: ABdhPJz1kSkGpmf1AnLPdELh2Lnx7y6qmm+BDs31oGtdoZk4KTfJ9gMkrVTg58SfWr2MzMbZhcatcg== X-Received: by 2002:adf:f203:: with SMTP id p3mr9397409wro.331.1593798180531; Fri, 03 Jul 2020 10:43:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:59 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Bin Liu , Ravi B , Kumar Gupta Subject: [PATCH 28/30] usb: musb: musb_dsps: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 3 Jul 2020 18:41:46 +0100 Message-Id: <20200703174148.2749969-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/musb/musb_dsps.c:44: warning: cannot understand function prototype: 'struct dsps_musb_wrapper ' drivers/usb/musb/musb_dsps.c:102: warning: cannot understand function prototype: 'struct dsps_glue ' drivers/usb/musb/musb_dsps.c:169: warning: Function parameter or member 'musb' not described in 'dsps_musb_enable' drivers/usb/musb/musb_dsps.c:195: warning: Function parameter or member 'musb' not described in 'dsps_musb_disable' Cc: Bin Liu Cc: Ravi B Cc: Kumar Gupta Signed-off-by: Lee Jones --- drivers/usb/musb/musb_dsps.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 88923175f71e5..71660491557f8 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -36,7 +36,7 @@ static const struct of_device_id musb_dsps_of_match[]; -/** +/* * DSPS musb wrapper register offset. * FIXME: This should be expanded to have all the wrapper registers from TI DSPS * musb ips. @@ -96,7 +96,7 @@ struct dsps_context { u32 rx_mode; }; -/** +/* * DSPS glue structure. */ struct dsps_glue { @@ -162,7 +162,7 @@ static void dsps_mod_timer_optional(struct dsps_glue *glue) #define USBSS_IRQ_PD_COMP (1 << 2) -/** +/* * dsps_musb_enable - enable interrupts */ static void dsps_musb_enable(struct musb *musb) @@ -188,7 +188,7 @@ static void dsps_musb_enable(struct musb *musb) dsps_mod_timer(glue, -1); } -/** +/* * dsps_musb_disable - disable HDRC and flush interrupts */ static void dsps_musb_disable(struct musb *musb) From patchwork Fri Jul 3 17:41:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642475 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3868D159A for ; Fri, 3 Jul 2020 17:43:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2048C208C7 for ; Fri, 3 Jul 2020 17:43:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e0AkldCM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726839AbgGCRnO (ORCPT ); Fri, 3 Jul 2020 13:43:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727061AbgGCRnD (ORCPT ); Fri, 3 Jul 2020 13:43:03 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DA2BC08C5DE for ; Fri, 3 Jul 2020 10:43:03 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id o8so32746797wmh.4 for ; Fri, 03 Jul 2020 10:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8mQF2FZ0jrrVdFBW6SrV/K5PDC372enpc401EmGJ4RU=; b=e0AkldCMprpPWh+rbnVgZVxtLG2y6OltUwnk8439ZxDnC/6jYt0uqjTtRQx/Zfn+tZ nZwYhZtVgJfVHRbI+zDxMYK30uzPBABrlnWYCO5TBFx8Ja+jSCZxw+jYI87lsm2y3xy9 QxNGqinBdVqBcWPtpWsTduPgpEaxe4O9LOEpO7wvmc9DsueDiifOLfghcb/KulrhUqxf wqW3D4u1FpOkgd+198fconKRrhY2PlpFbZ7tRgjc+8sbucSyMdhhLxMddDMHSRsTiSrH pW1rKrPD0pEqCqMth1P2WdyD9ox3TMqkEkXTBSCnyAtV9BTy92b2xKgq3yRK+wVYMwCQ inCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8mQF2FZ0jrrVdFBW6SrV/K5PDC372enpc401EmGJ4RU=; b=cevf9PUIv97mpoxxJWC1byPqUhYF96Lb5IDyx09fuBf/fP6iZg/KyDTFyFe6NdmlRU bguRKoHXGj0HQ8IxouZL9e6ujLSX7Nx9cucOzuxszsF3GaJa6urhaTV3JiUjP9ZcLdzH hwcciWoKgDdcibqQRONyTZ7v+hEvPG7/dtt+C7Li/vk5tG/SJ4GeB61Y39coXAEqEfnP Qbb4MOjjCtIMkSEFWXB/0Y/YlX+uISEeRyu9przeL9A82JNfP+DgY+uFvlnQqsAVI7yT yADXxvfPzqCgVmhWvwevNobMGC53X5tU2L12LpxDGg7uRDjwNEXnex2eUacEl7afSC6V iXJA== X-Gm-Message-State: AOAM531KfTM742MSlgpecIjzKBkPSgKEgXwuX31Yq/YaAMh7X5dA/A0y tMg0XRAlbc4HHq6MT/zFNbxeuQ== X-Google-Smtp-Source: ABdhPJymDh7yO/0xPFzXc6z8/96jHurwQBojFV24c+PsUXFn1Um5Euz/ljx89ZFYhzbITSni3XCkHw== X-Received: by 2002:a1c:f007:: with SMTP id a7mr37726297wmb.103.1593798181776; Fri, 03 Jul 2020 10:43:01 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:43:01 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Felipe Balbi Subject: [PATCH 29/30] usb: gadget: usbstring: Repair misspelled function argument 'langid' Date: Fri, 3 Jul 2020 18:41:47 +0100 Message-Id: <20200703174148.2749969-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org An attempt was made to document the functions in 'usbstring', but a simple spelling mistake was made. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/usbstring.c:76: warning: Function parameter or member 'langid' not described in 'usb_validate_langid' drivers/usb/gadget/usbstring.c:76: warning: Excess function parameter 'lang' description in 'usb_validate_langid' Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/usbstring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/usbstring.c b/drivers/usb/gadget/usbstring.c index 58a4d33250902..119505fac7776 100644 --- a/drivers/usb/gadget/usbstring.c +++ b/drivers/usb/gadget/usbstring.c @@ -68,7 +68,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_get_string); /** * usb_validate_langid - validate usb language identifiers - * @lang: usb language identifier + * @langid: usb language identifier * * Returns true for valid language identifier, otherwise false. */ From patchwork Fri Jul 3 17:41:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11642471 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4222D6C1 for ; Fri, 3 Jul 2020 17:43:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 287FA208E4 for ; Fri, 3 Jul 2020 17:43:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xDC8fIaK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbgGCRnH (ORCPT ); Fri, 3 Jul 2020 13:43:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbgGCRnF (ORCPT ); Fri, 3 Jul 2020 13:43:05 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DAD9C061794 for ; Fri, 3 Jul 2020 10:43:05 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id 22so32763498wmg.1 for ; Fri, 03 Jul 2020 10:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4V6rwO8B/5QxcmzyBtTB5IourUHauOiv8oEVPOqaOuQ=; b=xDC8fIaK5cyXv1Gyh3x1BMrLUIzhbFutpqYYDoz2u726Z3VIgmmNR2ruE04GGXEcAw aGuTq6k4zQfmgqsuNecc1AG3AGrqxgz7l8lcO+CqOTX55bno5XRVwTM5wnkCiTK1KGRo 4cqhlQ46ZFHiMQ7ZlM2U2vJJsxIMnKQarCojzcguzEY+pM0zog//2dDTrJy+XJZjw3eX K638g22lJj5Iykle0Hv+fOitBoF+mba79KsRLj+046IA0MlGRNZdpvJ+EqOf1Q9WLWUB T7+DNb/QGE+zN8ST8O7KBKPI9lw81iVVqMhvWMk28t2EV4PdVxkGc7ie2+B/1Vwctkjf hMFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4V6rwO8B/5QxcmzyBtTB5IourUHauOiv8oEVPOqaOuQ=; b=jPIwlgroeVPdo5AElr6CwUeEYfrsX6/z/IguM4l/TmcDO6Md5Fc0GOYNvwGEd8/xCd wfvO1oYDN+mojG8hD/hl/EoCU8XRlZvQSNMXsDIM7wt2t6KoqWHJJRpsJUlnwlvPi65p 1aYE7DM/lzaEtLEWPrVM6eCU4DRtwSBLQtQ5SsLrQubkElWg2HJ9e3r+7ApaMKKCYJCc HINAMRA6T/5RwGqT8W/heVccBoS59UTkuUZ/IXwUUOcqUZ0K2LT3yWXoGftUElAl9sFK fbz1c5CNhB26XdJLRI9hSTZjCF/58+QjfCAL0w6T4Yhm0QLhHxiGZCoJkKKQ49fadgPZ DeLw== X-Gm-Message-State: AOAM530xelWdFXXv6OqKV633DzGEuH/fO5N3KFpmDJEiBIpxDrALi1nn FLSl4HoE7+CP2Lk7/FCIrU9fkg== X-Google-Smtp-Source: ABdhPJyWZ41PNKg/DEnuOx29cG3N8Pn3AUS9iFQCLEigdnAYIlm7v8dyg3JZ2T2lM88Cbh0PxNRO4g== X-Received: by 2002:a05:600c:2154:: with SMTP id v20mr40914551wml.185.1593798183818; Fri, 03 Jul 2020 10:43:03 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:43:03 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Felipe Balbi , Andrey Konovalov , Alan Stern Subject: [PATCH 30/30] usb: gadget: udc: dummy_hcd: Repair misspelled function argument 'dummy_hcd' Date: Fri, 3 Jul 2020 18:41:48 +0100 Message-Id: <20200703174148.2749969-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org An attempt was made to document the functions in 'dummy_hcd', but a simple spelling mistake was made. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/dummy_hcd.c:1597: warning: Function parameter or member 'dum_hcd' not described in 'handle_control_request' drivers/usb/gadget/udc/dummy_hcd.c:1597: warning: Excess function parameter 'dum' description in 'handle_control_request' Cc: Felipe Balbi Cc: Andrey Konovalov Cc: Alan Stern Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/dummy_hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c index 0eeaead5acea3..ac3db28fd7779 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -1581,7 +1581,7 @@ static struct dummy_ep *find_endpoint(struct dummy *dum, u8 address) /** * handle_control_request() - handles all control transfers - * @dum: pointer to dummy (the_controller) + * @dum_hcd: pointer to dummy (the_controller) * @urb: the urb request to handle * @setup: pointer to the setup data for a USB device control * request