From patchwork Mon Jul 6 13:33:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645835 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C87BF13B6 for ; Mon, 6 Jul 2020 13:36:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E5A220720 for ; Mon, 6 Jul 2020 13:36:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CTaO2rb4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tb+/K0K1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E5A220720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1ntlEQ4ZEHkSkhb/f2ZquZT1n7Iibff0vHvHS8R41rE=; b=CTaO2rb4nU5ChB8BGs3+xGXvd givNRfjPPJhwxdsap3CEPkVmADh6OjyOGh6BZadCYNKPhroTUB+4n01gT3lp37e+DicqoQp1ok3dI nSF4mzkcKs0vKyPuegpvEjZ6F9nz3MUP9mFm0csiee0wj5AhpUft7MfvFVqqs4nMOtz07iVZqYzWi o2wbYDR+hW6ZJkHqA8lyGSvaCgPuV1i3DUtyg3Br5d9AabR1dEcE+S0TRLJVG21BgFoAAH3/rA5Jp YRNjWC+pBPdin3u3qJrVg3M95Pv+mFIfDo/l6th0wrmVF8kSt1ozM1U7rbn3/cJtwnRv4NY+pGcyW 39s3HvkdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFl-000887-5K; Mon, 06 Jul 2020 13:33:49 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFi-000870-NG for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:47 +0000 Received: by mail-wm1-x341.google.com with SMTP id o8so39366439wmh.4 for ; Mon, 06 Jul 2020 06:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KtWn8hsOXI1tl0MUhSmyvGeFes81dlof0v8VW7+fdbw=; b=tb+/K0K1eA704mpMyghl55v/zWI4mSEucjEWMkto05EJAwtt81Tuc5Ialuiq8LeS2R x7eNhrR5yGpofVpGMlUc+dGvW6hOfzZAKfuPvTYOL9cr6csy+Q7aT4rJAe+QBVgDpCWB JmX38nI6hJKRDaLdaCbKahq0CK0atprPWa2Wn5hZzUEnnjAXQrcx+95LGiam9CAdWbmM QFxzd5VOEiDqMgyMUKWN0JEn5Yco8m9QTRctmmUjIDZ2rJKKvS/HJF17k9YJnzu5eULF XF3nsJOJPonHF1SaySMBGld80Ol8vOnadKhByaY0CkSeG7cHOObHZPhTkBpFLNt2aOaX OXrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KtWn8hsOXI1tl0MUhSmyvGeFes81dlof0v8VW7+fdbw=; b=GigbTk+5Jj+61MSlPkX4Y8+OpdDUfyg7jZ15Htm8XMB5k6f83ZnQcKk+bbr4KIj+vl rEvzQ7tQjYa165n8IssSHfyR0skiZBdqeX+D1nd9LgBkODB2sKj8qL2djyyWgpongyck atmZ0QBM5r0rshTpn3QbK8LBmeHzdkRABQSv3ZO97f5mm6jkYmK5gkihOWSv+hlQadNG G2/NFUNvxOzHBXvDnwe5MwAhv5gsHQKnYw21BzP9TEpFH3wmzWrlhvCQ8Sel1zk6GbXG Qamaa8yKpgHhbqgBeG22R731UFoJkkLoeXrECxs8cui4NYVhlQLxcNlAA8whI3lphJgk mTaQ== X-Gm-Message-State: AOAM532BqHP43nMJSvSJbdXdyaY5tdsqmsrHHu3LObPmPUR0qoeMuEmb HDNZe1T7Y5j0R54OJ+3KhQopqQ== X-Google-Smtp-Source: ABdhPJxVTByOnTI298yDjNpJQ+8K3fWLg5oZdMazHD2udtCJrLX53D0eLnbVRozcdO4IHjwxa9apZQ== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51110615wma.4.1594042425621; Mon, 06 Jul 2020 06:33:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:45 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 01/32] usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:10 +0100 Message-Id: <20200706133341.476881-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093346_801151_85062578 X-CRM114-Status: GOOD ( 12.73 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david , Juergen Stuber , linux-usb@vger.kernel.org, David Glance , linux-kernel@vger.kernel.org, legousb-devel@lists.sourceforge.net, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:290: warning: Function parameter or member 'dev' not described in 'tower_delete' drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'inode' not described in 'tower_open' drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'file' not described in 'tower_open' drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'inode' not described in 'tower_release' drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'file' not described in 'tower_release' drivers/usb/misc/legousbtower.c:452: warning: Function parameter or member 'dev' not described in 'tower_check_for_read_packet' drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'file' not described in 'tower_poll' drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'wait' not described in 'tower_poll' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'file' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'off' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'whence' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'file' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'buffer' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'count' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'ppos' not described in 'tower_read' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'file' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'buffer' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'count' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'ppos' not described in 'tower_write' drivers/usb/misc/legousbtower.c:669: warning: Function parameter or member 'urb' not described in 'tower_interrupt_in_callback' drivers/usb/misc/legousbtower.c:724: warning: Function parameter or member 'urb' not described in 'tower_interrupt_out_callback' drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'interface' not described in 'tower_probe' drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'id' not described in 'tower_probe' drivers/usb/misc/legousbtower.c:863: warning: Function parameter or member 'interface' not described in 'tower_disconnect' Cc: Juergen Stuber Cc: David Glance Cc: david Cc: legousb-devel@lists.sourceforge.net Signed-off-by: Lee Jones --- drivers/usb/misc/legousbtower.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index ab4b98b041158..8aca55c4c95f1 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -283,7 +283,7 @@ static inline void lego_usb_tower_debug_data(struct device *dev, } -/** +/* * tower_delete */ static inline void tower_delete(struct lego_usb_tower *dev) @@ -299,7 +299,7 @@ static inline void tower_delete(struct lego_usb_tower *dev) } -/** +/* * tower_open */ static int tower_open(struct inode *inode, struct file *file) @@ -398,7 +398,7 @@ static int tower_open(struct inode *inode, struct file *file) return retval; } -/** +/* * tower_release */ static int tower_release(struct inode *inode, struct file *file) @@ -440,7 +440,7 @@ static int tower_release(struct inode *inode, struct file *file) return retval; } -/** +/* * tower_check_for_read_packet * * To get correct semantics for signals and non-blocking I/O @@ -461,7 +461,7 @@ static void tower_check_for_read_packet(struct lego_usb_tower *dev) } -/** +/* * tower_poll */ static __poll_t tower_poll(struct file *file, poll_table *wait) @@ -487,7 +487,7 @@ static __poll_t tower_poll(struct file *file, poll_table *wait) } -/** +/* * tower_llseek */ static loff_t tower_llseek(struct file *file, loff_t off, int whence) @@ -496,7 +496,7 @@ static loff_t tower_llseek(struct file *file, loff_t off, int whence) } -/** +/* * tower_read */ static ssize_t tower_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) @@ -580,7 +580,7 @@ static ssize_t tower_read(struct file *file, char __user *buffer, size_t count, } -/** +/* * tower_write */ static ssize_t tower_write(struct file *file, const char __user *buffer, size_t count, loff_t *ppos) @@ -662,7 +662,7 @@ static ssize_t tower_write(struct file *file, const char __user *buffer, size_t } -/** +/* * tower_interrupt_in_callback */ static void tower_interrupt_in_callback(struct urb *urb) @@ -717,7 +717,7 @@ static void tower_interrupt_in_callback(struct urb *urb) } -/** +/* * tower_interrupt_out_callback */ static void tower_interrupt_out_callback(struct urb *urb) @@ -742,7 +742,7 @@ static void tower_interrupt_out_callback(struct urb *urb) } -/** +/* * tower_probe * * Called by the usb core when a new device is connected that it thinks @@ -854,7 +854,7 @@ static int tower_probe(struct usb_interface *interface, const struct usb_device_ } -/** +/* * tower_disconnect * * Called by the usb core when the device is removed from the system. From patchwork Mon Jul 6 13:33:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645829 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BA9D51709 for ; Mon, 6 Jul 2020 13:36:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 550CE20720 for ; Mon, 6 Jul 2020 13:36:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xmoCjXF9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NkRY2E/H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 550CE20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jjhfk4nVcoNcNqhHsIAuFZo5F2fZ2WI0x1wahRvkXMk=; b=xmoCjXF9q4A4ZTnAL4kBHuP0C 1KgLJ+OZHc/O0ABAe55zfbCFFVyAF4wLxk4tAmaXr32W656xGVotRooIt0pJ5/GbOw4qiSI9oUJ8U alHtwODK328gawg1+XG3vrZqR1nUwVVOOYB6YB5A3PC+rIQmhbCRNLjqcK796iSdXaaGyg+XJCrrB zmgssvFqOexyHO7/uPQQpX0T0EI+g+8xQuJCM8zT6kF71o9KhL6zjwkzfPjrwRBVpK8xYzGyio3v4 NzwvQshJxrzgQCJB8xmG5ZPZeHZPxJhgP0GRVA7VXDDt2fZk4tNzX2ODoVVD/RjKYgj/8oKj1xTFj 7KwBWOtgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG4-0008H2-DO; Mon, 06 Jul 2020 13:34:08 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFj-00087U-N0 for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:50 +0000 Received: by mail-wm1-x342.google.com with SMTP id f18so42147595wml.3 for ; Mon, 06 Jul 2020 06:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WNaU7ol+N7ICBJATYVP9nw4MVbukWo2xxwQRmnXSWuw=; b=NkRY2E/HSC6TCiGYYeAp7Ij0MVWlfjDJVXmJchaUI3rMunKmwloMDjVwIp6WkePzX/ zebB66G53xUr0ZsJFMrQhXE1gWX/AxLXp0tbYzYz+lCr6MH6Z9gTFrD1OfaR+kij4/1e 2NzT2rvVJrW4SvM//cDtdM/tfm4y/E8QoRFFxL2ksnPMJ1Kp2LcVIiLEjXgEkiSAokKK hFp2tTqg+WJ9LgX/G1frCemjOnFGdmZY3t5IEYxNaXbrue949/A0rRh6O9KbRzWpzsYL dWP09kh1fL33PDeBGoUY6awH4Adfw8S3qvhYakuSG2YCXfUEfR/XdT+fSm0Rukc4Wopr vteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WNaU7ol+N7ICBJATYVP9nw4MVbukWo2xxwQRmnXSWuw=; b=D/tEJHDLKMZdH+B9JyDDMMoQzOdJVkdxXHoelIw/oHGs5DCmJmAp54nTyH5NEdP8CJ Cwa48h2kqImKyeHlVkQkNX8fACdXXrDyOg13z4F8jmbyRLfqQ6rkYTg/c+FhMqKrAdRA OWmaix0CY4kkT7ivhIXzupDFRLomLp2OBebeW8dFnMekFex35RfSYepDJ7AE4G7IZZpd YsLbZfw77s14r3870OnfqRORzhUuc/0vgFBxoUct8joYgQCaeR3HgjyU5vH+JyDtO1tY Du3ZhY34rA9l+BQtiKE302gCzeTTbEtdEFovzPoXvhbMt11jqHAgvLPYoI+b299PvYef H0xA== X-Gm-Message-State: AOAM531ugNnm5xaJ69DNVU1Up7NTNOttHSi574F+U3xVIyi3Hoo9N9oQ s/80bDN6N52Ua4CiVRZGflfJcw== X-Google-Smtp-Source: ABdhPJzV6Ohv7aXVOIIpA3ZhF5c1WJsv9HI1KNboAwezr33m6B8+3YAS3pk85zXnZUZoeM+YxtgKZg== X-Received: by 2002:a1c:1bc4:: with SMTP id b187mr52514926wmb.105.1594042426613; Mon, 06 Jul 2020 06:33:46 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:46 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 02/32] usb: chipidea: ci_hdrc_pci: Fix improper use of kerneldoc format Date: Mon, 6 Jul 2020 14:33:11 +0100 Message-Id: <20200706133341.476881-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093347_812842_63764F7E X-CRM114-Status: GOOD ( 11.76 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , linux-usb@vger.kernel.org, David Lopo , linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document any of the structure's properties here. Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/ci_hdrc_pci.c:132: warning: cannot understand function prototype: 'const struct pci_device_id ci_hdrc_pci_id_table[] = ' Cc: Peter Chen Cc: David Lopo Signed-off-by: Lee Jones --- drivers/usb/chipidea/ci_hdrc_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_pci.c b/drivers/usb/chipidea/ci_hdrc_pci.c index 49a61549cee67..d63479e1ad104 100644 --- a/drivers/usb/chipidea/ci_hdrc_pci.c +++ b/drivers/usb/chipidea/ci_hdrc_pci.c @@ -120,7 +120,7 @@ static void ci_hdrc_pci_remove(struct pci_dev *pdev) usb_phy_generic_unregister(ci->phy); } -/** +/* * PCI device table * PCI device structure * From patchwork Mon Jul 6 13:33:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645817 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2469117C7 for ; Mon, 6 Jul 2020 13:35:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A64892067D for ; Mon, 6 Jul 2020 13:35:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VHWXaAiH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RLGORxri" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A64892067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pOBGjl9cxdFNT1fWRLAxXoCQsoCM51v85lIA5t/6hJ8=; b=VHWXaAiH3Da88zKs+ETXmqFvy AUsCHAj3R6/bMlN4Ldn+Q4vdgsHE78F1hRHkRxugi6k0eOxT6Qe+at7beZGLA7rJ+D1oKtAiFGaJO SpK4Qi9gr0WC4gON1CwAn55K2dOkyVC/ZzJT3NtsgB8V8d9S1+mhXK7Auoha6RfsHVuV4tIbUwkgw OM1NUPe1P56ufRDOhpWdHVye3NHmgLDLz4qAtz5kC7GwfXpFxP8BTsh5RDQbX4EeOhiVKlfWnzTs0 iswlYKgHx4A9190X/116enIbrq74KWMendVibN2TIQIroht+JOhm/C5T0aLUS1Cn4nvUntPeZieAG qOSkU3NJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFt-0008CP-RP; Mon, 06 Jul 2020 13:33:57 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFl-000886-La for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:50 +0000 Received: by mail-wr1-x444.google.com with SMTP id s10so40898361wrw.12 for ; Mon, 06 Jul 2020 06:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Da1l6YoL6n3bU+jKdqHFRQjokYKz+vBJsiPCL0gGolc=; b=RLGORxri111/tc0Sf0mSoMmtk2VwtRaHx86WcvDwSf1/2SpW+CMz1rr253sGKsrvUK uK22hb403LtPowLnwcDgpTXUfLiAzl7Ehka5hCIWxZK6tjJrXH/wyoVJgONMo5Vu0Nlj JOVU+F2Tj3eJNLPuV+P6fh0BlaNOe3kQimvqE0cUCtSdVVV++6OkgHXYK9XMdK6fCCjd iZNN4s0Qp4aWOgSDwztx886A+qDLbMjw6kR7XG7HJvjUgbm3GyBPHn2A4CX1p7G+5fJG RBZDMLNZSD0KaU+9REz4lAenuUrsvBhPyngaO9nQBPnshwM8sSoFKRwQJe7F/lZ+K4W/ mSlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Da1l6YoL6n3bU+jKdqHFRQjokYKz+vBJsiPCL0gGolc=; b=MxCY7tUjzceW96SMsYQ71gF1PZU4p2kKfX4Qndxn7G2G5ojMNC3ALk5o44AFprLu+q xwawt0fDfRPkALQjg2q1XAd8BhwTHGZpXCAm9OoiLy0n5CsLQjqL9o2vVjH/xKYRozsX aJ+m+mgsv9tSoeUlzytRDfYnz3H2ST1HpsKCgJiK3FSHoMa0HAmxTLPxiuSz40Wi8+zn Znq4hFyGUPoB+Q0YEPecb2f5VcBsra3LP8nU+/pcje+YtgfwnSjfR3pKDGtTRWE7EpCA iGEs6DdyQZDU3yRTTCIzrjn2g8lzCBnY/8F0/yniyNQHi2S1vDP28k0Tql3MQKDd/Jux euYA== X-Gm-Message-State: AOAM531EOPJzzuPd8MuIb+QDet6xaV3HWd5rzja7nPxhEX/ZS5p4gHkS mOPbVXUTmEBl6BDRuXLYoeYPDg== X-Google-Smtp-Source: ABdhPJxATiVCCEdpbl6fe+AbCMEAVhovrhkPLT0ovW8Huxs2dGyxJI6Eppza+UQYGaCLyWLadV5R2g== X-Received: by 2002:a5d:504b:: with SMTP id h11mr47735862wrt.160.1594042428510; Mon, 06 Jul 2020 06:33:48 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:47 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 03/32] usb: gadget: legacy: printer: Remove unused variable 'driver_desc' Date: Mon, 6 Jul 2020 14:33:12 +0100 Message-Id: <20200706133341.476881-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093349_755100_9D80646F X-CRM114-Status: GOOD ( 10.48 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/legacy/printer.c:24:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=] Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/legacy/printer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/legacy/printer.c b/drivers/usb/gadget/legacy/printer.c index 57858f0c2b6c9..2cd389575084b 100644 --- a/drivers/usb/gadget/legacy/printer.c +++ b/drivers/usb/gadget/legacy/printer.c @@ -21,7 +21,6 @@ USB_GADGET_COMPOSITE_OPTIONS(); #define DRIVER_VERSION "2015 FEB 17" static const char shortname [] = "printer"; -static const char driver_desc [] = DRIVER_DESC; #include "u_printer.h" From patchwork Mon Jul 6 13:33:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645841 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9442613B6 for ; Mon, 6 Jul 2020 13:36:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CB882084C for ; Mon, 6 Jul 2020 13:36:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2jLPtUeB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G1JoL1Da" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CB882084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r3pPq+DY5bzJG/jx7glqZyJBn0nEeMaJQd5GlKA8PC0=; b=2jLPtUeByReANN3aRJxmkSgUm 5dRZC9Efk4RUfKXNgr5RDt2flg//ksKIli4qdadJZkHFl5/2Cx5uK24dKlRKdlRlHANJnR3ntRPYQ BIQqIIP3V6LQDvk2eD0qpckxmRGHW/9UzJlUPZY/ByCKGWt3F6wx8MGqkaEajdFjD5gd72ycNUjYY V5jR/gdwNOuji/tRX2SD8fU2DCtfiQqzzQjK/NDHFSsQ1wF06Q1zHsAnRpYtoBIR9y24Lex4yNicQ 5lNxzmfXj0gDcwDJBc/tKH/wzlsxBttqQemDRZTZ3pnAdf6FG0xpqzq6obVK7XgIKCOWX4tlO9aOx APr9GBL6w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGL-0008NB-Ld; Mon, 06 Jul 2020 13:34:25 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFm-00088h-KA for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:51 +0000 Received: by mail-wr1-x441.google.com with SMTP id z15so29657813wrl.8 for ; Mon, 06 Jul 2020 06:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2vBJeRBU9C8xa/2tDAV3EYv6FtdJQoWad8hFtUeL0Ic=; b=G1JoL1Daorj+JI1ZRbOm0BsITxlYPCPhqAXR8booNKNusooKx24v80Dl9rC+dERNjZ 1wDaFAseXrhBUGr/nbWDDAg/16r5MFQ9cICHpdVqoKiFiyiwWy/N6B6OmFsQ5NXGyjc9 YYrEKmJpZh64Xww7sSEG5VmFi3dtB3DobR83PDYZV5cTCGpwS6PSwpL/XGycHcTpzTWc KSpxBlGnI3+pIfmjl4b1LGJvFxbn3iOWQV/oCNEbTR+EPdh+h7R8qux7lxvt8n7chmMt 6dbFgzTJ0owILMLo/els7olUo+4e0lOaKULvAdId+iS9nhTGGBE4kGFBKvyANowDHPnf XWng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2vBJeRBU9C8xa/2tDAV3EYv6FtdJQoWad8hFtUeL0Ic=; b=FqySyQ4dV7B3SwHuf2Ug2X2e2Hxf3/kxVnbFItTjeL//fIxmWQhlANAXkg4ItWmAzW AxVMsABvy7dgfQ2gZYEBAqEs+o2XYRePffHJ+SaGYpMdoA4SjWauoUmpZVS3KpeI4I+Z 7Al2vCnur71mSBAZWIJpwaAL1uyWj/S604qebuPjLaM7qqjangm/61WT/pRY5QxbC4SQ 7XiuwqQUVRIoLKtIuGYnRtBjbVYaY6jeqdPPTnXidu0uQVFr5+acPvqWFkYoUegGO30x 6HXSs9IlJy+zbut3PDZC/IImUTxecdwd3VhqK3mT2MpaBr/86+dX9tEX8lBrBQQ8PhtG 7z2w== X-Gm-Message-State: AOAM532+pMx+lIblFYbxgXtzj+1YRrrrHQzx2jvqjZ/ZpwyK8to+TmfM WxakCAkY6KGQIztjWZD1CzGCNA== X-Google-Smtp-Source: ABdhPJxwyl8nugjLp5ZVCs5jjXRLq7y1skE4cNELfOaMcl4PfNxE/98yrBxip9g69YujC40tpLTZeg== X-Received: by 2002:a5d:5706:: with SMTP id a6mr13465102wrv.328.1594042429481; Mon, 06 Jul 2020 06:33:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:48 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 04/32] usb: gadget: udc: amd5536udc_pci: Remove unused variable 'mod_desc' Date: Mon, 6 Jul 2020 14:33:13 +0100 Message-Id: <20200706133341.476881-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093350_775006_5BE5CA41 X-CRM114-Status: GOOD ( 11.20 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/amd5536udc_pci.c:52:19: warning: ‘mod_desc’ defined but not used [-Wunused-const-variable=] Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/amd5536udc_pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/amd5536udc_pci.c b/drivers/usb/gadget/udc/amd5536udc_pci.c index 80685e4306f31..56258d076abc4 100644 --- a/drivers/usb/gadget/udc/amd5536udc_pci.c +++ b/drivers/usb/gadget/udc/amd5536udc_pci.c @@ -49,7 +49,6 @@ static struct udc *udc; /* description */ -static const char mod_desc[] = UDC_MOD_DESCRIPTION; static const char name[] = "amd5536udc-pci"; /* Reset all pci context */ From patchwork Mon Jul 6 13:33:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645845 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 995D413B6 for ; Mon, 6 Jul 2020 13:36:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71867206F5 for ; Mon, 6 Jul 2020 13:36:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KVfFvs18"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bWfrC2CT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71867206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5CWOzewwHn9D5dlz1al3l+RB2zBd6E1CvwoNGmbWzzM=; b=KVfFvs18T9mQPo4UI7nMSfIx0 1CLZGzOgG7tGJp18mlKKMVwkgoNjfZbDAm1w5APjGZF1uZQFy9bckoINOb1b8zvgBEP+bAeBzDAoG k1rx6uLmq83qpbj5NsUMfdK6Dkc/pxbHYgFbeMtKoL3UuV5euOEmrEsygkPS3rdtnhYzVkzb+YAM9 jM1ZhIF98rxceYLb1ihwmO+pVYmeOOMQPTH7huXx/sSCwIArgqoODDPwpvsPmTmdEb/8pXPy1bXHD j9mhCjIv0nmmgYpv1lRZfS6jS2B6Bz+oPNjV4/rPZOY8D+WxCN2JKoFSqxsS6Ja3h2KqwRQRf/M8J VUDdoz4DQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGT-0008Rp-BH; Mon, 06 Jul 2020 13:34:33 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFn-00089O-IF for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:52 +0000 Received: by mail-wr1-x444.google.com with SMTP id q5so40920627wru.6 for ; Mon, 06 Jul 2020 06:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+1uVBpjaOD4IpY3ZVlXbRV81yiri13+tuf6A/llAK/Q=; b=bWfrC2CT864d48e8sCwLNN6S649Z7RUI6pO1r+dF7OQw0XBZ0w+YwQQRCgFTULa6lO pUTSNHqHo5MEMTKVVgMIK7+bkfHfqxXFMNgjUdN4S6S7nnMVygMuDMWlbsNhPfyl68jD avi2zqxlw+3PRHuC+6tM753fGejds5lVDT+akNypUQ2JCcQvMzLNJF+A2Xe6mKVZPj7x ZLRC8d3qGcXfT5kgnn66HLzFcO6h8g/DsDcpAsMjN5bQHWZPSbai4i1du/j4Cmeb9Ml5 5lJ4DfLAuw09P70HDlLAaeKYQp/cHK5Eh+xJMsB+5p8ptypyUIV1/p+NtWybWXuYyrVB AiVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+1uVBpjaOD4IpY3ZVlXbRV81yiri13+tuf6A/llAK/Q=; b=KBKaLzti2dV+iNm1DKjwyHgxsg2NZnt41AY6KocJ1M3YnMrBZKzjz+xTZKZN+CrE+/ jRmqSETMVEpptgmACJLo7F4hZd1SVdlKE8joaYPajtNLmjx1I2ybGYgstU7jEx4GjoVD KjUMrFsjfOTL02lak0C9Y0mkpWkwps7UrL+4BdHP/DAjf7G+xj7jlO2sEe0j7UoPdnIA ToR+owpBzZbFNULkxxyzxuqAqmG3+xFIVYeLHxijwWXO/CLX6FxcP8Hhfj30krjTfsKI uBKNMcHc+xH7OpcBTzTisUokraloDwClQyiGhAOMBEmQXSGYT7MeH7KHF62s9bsQeWXN oKpA== X-Gm-Message-State: AOAM5331lGfNSyefDEH4ncaNyzGcMk1LTqviGQNmpq+stfU6sAC6dLsX 0JGZ/c9E8qGmyVjHPwI5Y7txtQ== X-Google-Smtp-Source: ABdhPJwkx0wriCmaCekhauRjWoIcIVTFPWenfRaZ3yayXF3PWVnJO9SnWMwPmaPvsVmH1dWjO20j+Q== X-Received: by 2002:a5d:470b:: with SMTP id y11mr50991135wrq.101.1594042430666; Mon, 06 Jul 2020 06:33:50 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:50 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 05/32] usb: gadget: function: u_ether: Downgrade kerneldoc headers which to not make the mark Date: Mon, 6 Jul 2020 14:33:14 +0100 Message-Id: <20200706133341.476881-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093351_664189_93D108C8 X-CRM114-Status: GOOD ( 13.91 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc expects all function arguments to be documented. If any are missed it will complain. Downgrade one header with 3 missing argument descriptions and one which makes no attempt. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'dev_addr' not described in 'gether_setup_name' drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'host_addr' not described in 'gether_setup_name' drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'qmult' not described in 'gether_setup_name' drivers/usb/gadget/function/u_ether.c:1022: warning: Function parameter or member 'dev' not described in 'gether_cleanup' Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/function/u_ether.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c index fbe96ef1ac7a4..f01e3e21ecf21 100644 --- a/drivers/usb/gadget/function/u_ether.c +++ b/drivers/usb/gadget/function/u_ether.c @@ -730,7 +730,7 @@ static struct device_type gadget_type = { .name = "gadget", }; -/** +/* * gether_setup_name - initialize one ethernet-over-usb link * @g: gadget to associated with these links * @ethaddr: NULL, or a buffer in which the ethernet address of the @@ -1012,7 +1012,7 @@ int gether_get_ifname(struct net_device *net, char *name, int len) } EXPORT_SYMBOL_GPL(gether_get_ifname); -/** +/* * gether_cleanup - remove Ethernet-over-USB device * Context: may sleep * From patchwork Mon Jul 6 13:33:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645855 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 14FD51709 for ; Mon, 6 Jul 2020 13:36:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1274206F5 for ; Mon, 6 Jul 2020 13:36:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HRKtoqQt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EQlHDXEO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1274206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VVifEBH7fsv3T+guJZ4gNtMS0OYN5YiTQakX5dX2rH4=; b=HRKtoqQt/R5bT+z1ai+sfIKux oCTebyDLXE8Ch0S/J3+2J3F81yzV/14+kPv+6eViQQV4vD/PQjD56bt17bbOQsgNivfFFJQY2vdma G4kDaXCbL22kRRoxdU+6yyIKXs7w/fqQ4RUptCjsBHa+wblhBDhbxB6RlB5xjbOzrLFIXaG72B008 6ocWTvIqGfGqwsPaVXE36iYcaMyF7LGK82NJwuWTBWj6ddEWeiCiBFX9fy7DaOaDeCF+almrkICNt yxVbui6bKaMZK8uoKstlJmg1fa6ANjSvMzQbHIz+JMq0YmoLilkaj4DZmnLUr4I2afJOzqLqzMZMa QC8SYtyTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGY-00006g-IP; Mon, 06 Jul 2020 13:34:38 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFo-0008AB-Tq for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:54 +0000 Received: by mail-wm1-x343.google.com with SMTP id f139so42143113wmf.5 for ; Mon, 06 Jul 2020 06:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+2CvC0dcY8mKf0yUeXARfEMP6PiuGQCwRdvUKfmvdsM=; b=EQlHDXEOu5c3/xdYpeddQYBFy4VeGzctriOoYrhCEIoajtAlPrNE3FLI4QCGC5nYfM 7ZiHnbWq+YynONBW3qBawaRo36Ul1xVRH5XE+6GrHGxZpgH++Oh7NYaLgGeCsmYbSpwP 3tLYXhtCdK1wHAoNxnOXADLy8CMSkwXWQzkN7wW8SQo5YOCf6fp0RzSk5OGqctOCLZQg GL8Eg2Y3+FtPHIX6Tpv5cIHjwTba4ZLTCzpqUq8COYY3u/kKfbWo0BR2b9t04dS8/eyk O6chMiqAeUlB1WPYKpr1wK9FhkOq2ULHnyFhs1yRG0AzM4NIL04PlaplMvLyE4hRCsAl Qcgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+2CvC0dcY8mKf0yUeXARfEMP6PiuGQCwRdvUKfmvdsM=; b=tnBGfQoXTnzrbz3qQNuEkXmhhyU1JVsFBIsSlh3xKTbyQWCPudByUzvg8ltcPCvjik KipOBcqMV2FoPflDtiKHfwWQYmYxO2k0A76+vqsN+JedqAkTAo2P2OIyz4diNnJ+tzY9 e0dRHeoqpOgAQ7TOa6e/l/Mu80RAYLfZKda1YrANqHweof3W1OaGlb/AyPKlVhB5o1u2 DcI1qKS3q8/CjwFoEImOvqYkdviukAITd5OejauVPaPVGGdboL56P9D0hQjByPk1FsfD wiRSmiMv+BMzUns0PsbBLsauVUi6leNItl1+i1H+vNQbVWwcV/wtCjzhNHj9zEpjIb/h L2nw== X-Gm-Message-State: AOAM532tMhoDuxEodvfcqjFqHoTdRiITUVnJDDvgZ0dFTzN0Ak0q5oP3 HYCCq1jrGGlM6QkJEW0MFq63Tg== X-Google-Smtp-Source: ABdhPJyadCCkqtZcRNQihNkuxmJXSitEdNZGZi4AKQmzoDsvlBAO2i+Ti9nTcPFs+SJ97X4I3lcvfQ== X-Received: by 2002:a1c:a589:: with SMTP id o131mr46569094wme.12.1594042431959; Mon, 06 Jul 2020 06:33:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:51 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 06/32] usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues Date: Mon, 6 Jul 2020 14:33:15 +0100 Message-Id: <20200706133341.476881-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093353_050058_F1059BF8 X-CRM114-Status: GOOD ( 14.42 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Robert Jarzmik , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Haojian Zhuang , linux-arm-kernel@lists.infradead.org, Lee Jones , Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Mostly bitrotted argument descriptions/names. Also the removal of a blank line in the middle of a kerneldoc header, which is not allowed. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/pxa27x_udc.c:398: warning: Function parameter or member 'ep' not described in 'ep_write_UDCCSR' drivers/usb/gadget/udc/pxa27x_udc.c:398: warning: Excess function parameter 'udc' description in 'ep_write_UDCCSR' drivers/usb/gadget/udc/pxa27x_udc.c:479: warning: Function parameter or member 'udc' not described in 'set_ep0state' drivers/usb/gadget/udc/pxa27x_udc.c:479: warning: Excess function parameter 'dev' description in 'set_ep0state' drivers/usb/gadget/udc/pxa27x_udc.c:506: warning: Excess function parameter 'req' description in 'inc_ep_stats_reqs' drivers/usb/gadget/udc/pxa27x_udc.c:1476: warning: bad line: drivers/usb/gadget/udc/pxa27x_udc.c:1697: warning: Function parameter or member 'udc' not described in 'udc_enable' drivers/usb/gadget/udc/pxa27x_udc.c:1697: warning: Excess function parameter 'dev' description in 'udc_enable' drivers/usb/gadget/udc/pxa27x_udc.c:1750: warning: Function parameter or member 'g' not described in 'pxa27x_udc_start' drivers/usb/gadget/udc/pxa27x_udc.c:1750: warning: Excess function parameter 'bind' description in 'pxa27x_udc_start' drivers/usb/gadget/udc/pxa27x_udc.c:1784: warning: Excess function parameter 'driver' description in 'stop_activity' drivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Function parameter or member 'g' not described in 'pxa27x_udc_stop' drivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Excess function parameter 'driver' description in 'pxa27x_udc_stop' drivers/usb/gadget/udc/pxa27x_udc.c:2358: warning: Function parameter or member 'pdev' not described in 'pxa_udc_probe' drivers/usb/gadget/udc/pxa27x_udc.c:2358: warning: Excess function parameter '_dev' description in 'pxa_udc_probe' Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Cc: Felipe Balbi Signed-off-by: Lee Jones Acked-by: Robert Jarzmik --- drivers/usb/gadget/udc/pxa27x_udc.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 78902d13fc275..cfaeca457fa72 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -386,7 +386,7 @@ static inline void udc_clear_mask_UDCCR(struct pxa_udc *udc, int mask) /** * ep_write_UDCCSR - set bits in UDCCSR - * @udc: udc device + * @ep: udc endpoint * @mask: bits to set in UDCCR * * Sets bits in UDCCSR (UDCCSR0 and UDCCSR*). @@ -472,7 +472,7 @@ static int epout_has_pkt(struct pxa_ep *ep) /** * set_ep0state - Set ep0 automata state - * @dev: udc device + * @udc: udc device * @state: state */ static void set_ep0state(struct pxa_udc *udc, int state) @@ -498,7 +498,6 @@ static void ep0_idle(struct pxa_udc *dev) /** * inc_ep_stats_reqs - Update ep stats counts * @ep: physical endpoint - * @req: usb request * @is_in: ep direction (USB_DIR_IN or 0) * */ @@ -1473,7 +1472,6 @@ static void udc_disable(struct pxa_udc *udc); * Context: any * * The UDC should be enabled if : - * - the pullup resistor is connected * - and a gadget driver is bound * - and vbus is sensed (or no vbus sense is available) @@ -1688,7 +1686,7 @@ static void udc_init_data(struct pxa_udc *dev) /** * udc_enable - Enables the udc device - * @dev: udc device + * @udc: udc device * * Enables the udc device : enables clocks, udc interrupts, control endpoint * interrupts, sets usb as UDC client and setups endpoints. @@ -1732,8 +1730,8 @@ static void udc_enable(struct pxa_udc *udc) /** * pxa27x_start - Register gadget driver + * @g: gadget * @driver: gadget driver - * @bind: bind function * * When a driver is successfully registered, it will receive control requests * including set_configuration(), which enables non-control requests. Then @@ -1775,7 +1773,6 @@ static int pxa27x_udc_start(struct usb_gadget *g, /** * stop_activity - Stops udc endpoints * @udc: udc device - * @driver: gadget driver * * Disables all udc endpoints (even control endpoint), report disconnect to * the gadget user. @@ -1792,7 +1789,7 @@ static void stop_activity(struct pxa_udc *udc) /** * pxa27x_udc_stop - Unregister the gadget driver - * @driver: gadget driver + * @g: gadget * * Returns 0 if no error, -ENODEV, -EINVAL otherwise */ @@ -2349,7 +2346,7 @@ MODULE_DEVICE_TABLE(of, udc_pxa_dt_ids); /** * pxa_udc_probe - probes the udc device - * @_dev: platform device + * @pdev: platform device * * Perform basic init : allocates udc clock, creates sysfs files, requests * irq. From patchwork Mon Jul 6 13:33:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645857 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 15DE992A for ; Mon, 6 Jul 2020 13:36:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91DE520715 for ; Mon, 6 Jul 2020 13:36:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oA0fm0qu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xT+yupj9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91DE520715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tRC+2XxnLSpV6kf/q6JzbCFb8VDciw9LzgaGqsWBSnU=; b=oA0fm0quOge5abhqAqGR7US45 3Q4WV2v5kkoO43v/mNicdqQmTlkSOuIETqF4j11e/Ge8mOZ2u0JRmtq6N3R/NCtSV/U3u+9+vWiVZ KjMa8DCv8BDqh+ZJRm+QzaQFkC98fav0GVnQpFeVHBepmIFSSFOyKCEJAYCNoAw92vvCsgHjVTv/o mF2F0nZsb3TZ69m+z2rhG+liRfp1gGSH4mw2uNI8DxL7pe3183m0r2lnz/NQAiwA3RGlD+gipisGh 7Ob9nYBiq+MMN9+VU7rUcZyAapHaPNIGS8MfFMPORFQKmvEiMNJaTNqZO4EPOcAAGc5I90BPYXmg1 n5CMITFhg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGq-0000Fq-En; Mon, 06 Jul 2020 13:34:56 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFp-0008An-VV for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:55 +0000 Received: by mail-wm1-x341.google.com with SMTP id o2so42118007wmh.2 for ; Mon, 06 Jul 2020 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WegnVZ9DGyLW+kA2xpWSNAlVRAFvD3JLviW2wF/jZ6s=; b=xT+yupj9MavimR1wa5EZqEYTVTre9t7Il8BFvnEd4FOqKCV1obJEBkXayBjU4VTUpX EjG552aZP/iWzX7n5uCIBks2UnXw89KPGuPpFaGTfGBxeYUsPeDHCRpN2j7upHhRcoYp LKHDSdNN49TKwN3vrQQ3LH7oPAr3gSKkrpECRhZdCSuAfuNJxBkCyB4HSP+vs2T3balU /FH7pNPZ2YwlCJegT6qTrUN/oM2ejngS3tbIbVpgI0Y4EN1R+c5gIurEWJ+OMaofmHf4 Xrrez6/t4LlVxxsjlS3b8/S+W4A2pXlnJB+OuOGyM5adoBRjPyRVSYVu37lfQ1r3xGMk vtNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WegnVZ9DGyLW+kA2xpWSNAlVRAFvD3JLviW2wF/jZ6s=; b=SxzM1Y6UfGwMksd1BEkmRW0YOva/B8oUU5On8t6xjtHoHcfflmOR+yIM0aWWkbCF+r Qsa6lErwGOLhIXL3b9LyOvPp2Cd4YKuLpe+UXXSjHBlo437C4xkCKlHoacgJXyUq2ZkP SSlpcJdogELLSEoZNlVXhDv9MGiijMLsKFJPotnF7jZZeHQ9TV66gaYR/jAUiG2O4xSe 9k5MEgy5SZ3SWfLfA0lJq0Ojz7XBh8CRZa4/JmmbZbtsX5eafLi9Tb3ifw1FFsqy5IdM RXNsKuKZwC0imZEioWJ7A2nKFistze/Ow2Yv6qriNmxa3vESOZ/XbLIhw847mvlwK0HK TSQw== X-Gm-Message-State: AOAM532HTkP3JdwXFo5sF1MujIip1KCOu9ns3NNA2Zs9YFuAJKPH7kNr qCN6ob/GuX3oGoKjQ1g1qA6lOg== X-Google-Smtp-Source: ABdhPJyatwtDUIcCOL7ndILXzFNTrMtzJVDI0NWp8JnniRlD+OLzf4loG/6E3grgYnwIqqMACnTmYg== X-Received: by 2002:a1c:48:: with SMTP id 69mr51473365wma.32.1594042433108; Mon, 06 Jul 2020 06:33:53 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:52 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 07/32] usb: misc: legousbtower: Demote function header which is clearly not kerneldoc Date: Mon, 6 Jul 2020 14:33:16 +0100 Message-Id: <20200706133341.476881-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093354_095253_E59E96A3 X-CRM114-Status: GOOD ( 13.23 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david , Juergen Stuber , linux-usb@vger.kernel.org, David Glance , linux-kernel@vger.kernel.org, legousb-devel@lists.sourceforge.net, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data' Cc: Juergen Stuber Cc: David Glance Cc: david Cc: legousb-devel@lists.sourceforge.net Signed-off-by: Lee Jones --- drivers/usb/misc/legousbtower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 8aca55c4c95f1..f922544056de4 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -271,7 +271,7 @@ static struct usb_driver tower_driver = { }; -/** +/* * lego_usb_tower_debug_data */ static inline void lego_usb_tower_debug_data(struct device *dev, From patchwork Mon Jul 6 13:33:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645859 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EB1CE60D for ; Mon, 6 Jul 2020 13:36:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2EA1206F5 for ; Mon, 6 Jul 2020 13:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WBtiehno"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vTKBeOy8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2EA1206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U33x4RU//6/zuXTDTx/dubnUAXZ2YVqc16WP5/dvjpM=; b=WBtiehnoru108SPPuaVgWSTxN PKImB1sMAfDxlnmfzUP6gISC3MDnDqaVnJROfDjWpjSxP+OrBvQTw0tNMU/yhgKHFZvXrw/hp1JBi DRUAOxsjLAOB2jf6MwtdSLwumekbgSXSW+XZ20gxI5Y5HzC6sqoLWiiGLOnqOJP0+fgdXkq/C8zDT IRNvq+l5UrFvaXscbl3iEVkw/cKCe/n8Ka2Quv6LyUNv/b043y70sJL6Oyc1OHtFoLuVF1ReQgv5/ uukxluSPvlwEVCnHoYZo1UPOOiakDHZbJjkiYUO/wPbwCV00kD0zpUShjYvIiQXLOfF1sx4SDFX7s Q1weRcNgg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGz-0000KR-UN; Mon, 06 Jul 2020 13:35:06 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFr-0008Bd-50 for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:57 +0000 Received: by mail-wm1-x342.google.com with SMTP id f139so42143347wmf.5 for ; Mon, 06 Jul 2020 06:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P8CBq5D9tY/rIxd8Q9bScU/Lf3c39zfJPjGb95MJ1ho=; b=vTKBeOy8iUfSZmKMM4EVVOzgbmiCgEA6KMhIW9ctG3K+ahehKKx7a1sXbFvVZtjfS6 innuNalMpnrsqCB+v/QEOP7FDE8Ix5qjbmsU7xSdjpWQDRLoEvBKLlFRGs5HkWKupr5o F/sjXi24nPO0VtY4D2xhTt/xEQPYTXmWfpNum1ncVbzONuISe7B5N2oXZLn+/JAMhw5Z QO2Fo4cOg3XCdfDsBNaMPBVmVx+jBtFeW/lsaUdDr7JemyEnLj8QFk1YWkHg6Xu3O4lQ eq2usXfgODMDCtLx9nv9djz2KGH7YngG/1Y5dAF0iGn6+u6x99vRJjfYVKZCkXX4Zsir JK8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P8CBq5D9tY/rIxd8Q9bScU/Lf3c39zfJPjGb95MJ1ho=; b=Kfwy5gW99W1QnVMSdNNTUhEJc5QgDyT+yDRxCZAl47gjIdlQ3FgRfQCah2edBBsecz qpXvDn04r7ZVrJuX1v1oW71Kuxxt4VtsVKtDPAEKBMSrSD573n6CVRJo95OKXZJNVu+q A2SCF9dFW0H5NqDOtmf0x3lV1bG1hnRlapYxWUzr8eLPc4pWzht3bTuNT1YzxHPA4xz5 xlIdx9xjOuR+5ALpux6mU41qhnuOK7w0+bnASljJenlfQj9GsCbYL53JoKd9Tt8s4fA+ akvkZh6Zhmm4CJNeABe2EulE6hXjjxiUp4px1zadMrX7wNGQJSngEFhl4fVQOhMcRrg5 kzaw== X-Gm-Message-State: AOAM533fW19DHCXkeLVwtWKji8KJDpDIx0XHhWBxZIOEWTYABkNggu78 FXEP+wW3LoXvgY3agP4b6DsTLA== X-Google-Smtp-Source: ABdhPJwGkG53Re/6SkdDHQA3k1u5KCj1bTpxlVndoEvZves+WsU//tEO5Ud0kwzSsc+dh7IMKvG2EQ== X-Received: by 2002:a1c:2157:: with SMTP id h84mr48334366wmh.35.1594042434299; Mon, 06 Jul 2020 06:33:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:53 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' Date: Mon, 6 Jul 2020 14:33:17 +0100 Message-Id: <20200706133341.476881-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093355_368448_0F620EDB X-CRM114-Status: GOOD ( 12.06 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede , Guenter Roeck , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config configuration mechanism") pulled out the only use of 'tcpm_altmode_ops' last year. No need to keep it around. Fixes the following W=1 kernel build warning(s): drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=] 1551 | static const struct typec_altmode_ops tcpm_altmode_ops = { | ^~~~~~~~~~~~~~~~ Cc: Guenter Roeck Cc: Heikki Krogerus Cc: Hans de Goede Signed-off-by: Lee Jones --- drivers/usb/typec/tcpm/tcpm.c | 51 ----------------------------------- 1 file changed, 51 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 82b19ebd7838e..d6913eb0ea54d 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -1503,57 +1503,6 @@ static int tcpm_validate_caps(struct tcpm_port *port, const u32 *pdo, return 0; } -static int tcpm_altmode_enter(struct typec_altmode *altmode, u32 *vdo) -{ - struct tcpm_port *port = typec_altmode_get_drvdata(altmode); - u32 header; - - mutex_lock(&port->lock); - header = VDO(altmode->svid, vdo ? 2 : 1, CMD_ENTER_MODE); - header |= VDO_OPOS(altmode->mode); - - tcpm_queue_vdm(port, header, vdo, vdo ? 1 : 0); - mod_delayed_work(port->wq, &port->vdm_state_machine, 0); - mutex_unlock(&port->lock); - - return 0; -} - -static int tcpm_altmode_exit(struct typec_altmode *altmode) -{ - struct tcpm_port *port = typec_altmode_get_drvdata(altmode); - u32 header; - - mutex_lock(&port->lock); - header = VDO(altmode->svid, 1, CMD_EXIT_MODE); - header |= VDO_OPOS(altmode->mode); - - tcpm_queue_vdm(port, header, NULL, 0); - mod_delayed_work(port->wq, &port->vdm_state_machine, 0); - mutex_unlock(&port->lock); - - return 0; -} - -static int tcpm_altmode_vdm(struct typec_altmode *altmode, - u32 header, const u32 *data, int count) -{ - struct tcpm_port *port = typec_altmode_get_drvdata(altmode); - - mutex_lock(&port->lock); - tcpm_queue_vdm(port, header, data, count - 1); - mod_delayed_work(port->wq, &port->vdm_state_machine, 0); - mutex_unlock(&port->lock); - - return 0; -} - -static const struct typec_altmode_ops tcpm_altmode_ops = { - .enter = tcpm_altmode_enter, - .exit = tcpm_altmode_exit, - .vdm = tcpm_altmode_vdm, -}; - /* * PD (data, control) command handling functions */ From patchwork Mon Jul 6 13:33:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645863 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5A73E92A for ; Mon, 6 Jul 2020 13:37:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 326E3206F5 for ; Mon, 6 Jul 2020 13:37:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="onFhKJp5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I8l3xiex" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 326E3206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AqLNvHxILUPQqKbuKVUPG6JQdVWU+IQA/w38fDwSfpU=; b=onFhKJp5vziqgzilAmV6zxwLS Cs01+PMkXkdZ5TNbcR+nHbSEcI+cjFJ+7+ecFTfXcdqBkstH+3gNDGiBKEzqUqzQ9OcxrXs9oRCQc r7ytrtjmkELWgfQs4NImGMlYZoNqql0Ah+TfNJj5SXhcB509dURwTc156B/g52LjpTzGdJfJaswqi n0VLhNpMZkRG+T0A9860wZA9NcIrepcEKmc9TcvjPD4WP9seT2vhMQKwHtv5UEko6XlwainQbXr0i 9OfLJoJMjYQ0yfk1pTiZMjNgZ1tniOJnOfx34mh1EcS4lexbmBoH7CKWP3lVKPlfPs7C5wt6ih9gz +SB63Y0kQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRH9-0000Pd-Du; Mon, 06 Jul 2020 13:35:15 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFs-0008CA-By for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:57 +0000 Received: by mail-wm1-x342.google.com with SMTP id o8so39367052wmh.4 for ; Mon, 06 Jul 2020 06:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ji1N62aOzIlUoLXMMPXkjOjy05RAsl1PzqHcrZ4EBKA=; b=I8l3xiexa/B1JIJEy1ir1PTxhlP/Lj9nM5zUnk6opUF/S6bgIchyQgbqNywo7zJNiU CoQXFx15q77CxSXe0ZRx0B6u3hwF7yxGPD7hJYpfn2bPzbIVajT32LzABpWqvW/U963W rUfVYKYz0ltiAGwB2k/N9DNXTj1wqtMBeV3wSCHJspqZ6qVlC/PJj7n8N2Tb7Ciy5Hs1 YD5+rf7z0Dd+Kbwx1fUXzNmr9b19aJ2JgHb6AopyQqJZZVptVhkZMnlql+lUz0ue0xbF 8kR979vuUk/grhSLXPoSlAHDyv5f75q8fcqNYTPokp9FBt6qc7wkfcTDvRW9v3MCYpNU OHKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ji1N62aOzIlUoLXMMPXkjOjy05RAsl1PzqHcrZ4EBKA=; b=mJQQ3QiP+zo6cy4SM1zk8iifI4f4Mf/fUDXMSPfmw8VelXEJjkkMlZvmuRSQBAFAx/ VKoyYeWI5lj3C1v+FdyR/KJwE/lk+eH9gVPOjsphixa5lpXV4aqKVhvQigqSk15EbeZk oOgxxkS6aH6TisYOkKn63NM+r0Ycmz0+3rw8BCTX8tFsQPN6ltT9dlLbp4sw6GMlnjCt 5MvTvMhpDsdB4raZ3BGUIPbeoALbrylgxNyd4r7P6z0qQIUbFwyqbunLB9Ot304z9Zvn 5sIXwka4b8wmLA+do5D6WG6KjUgwR2yow32IzOfgEHvIHqJRJsKCuLErDL5ZMfOZGGJp k8eQ== X-Gm-Message-State: AOAM533mCoAI0xJWznk33E8O+47/Tin61A+rpSJ/54ujv3XCLxus++kf vALqxyU0/88ab288wojLpjEYFQ== X-Google-Smtp-Source: ABdhPJzhwy+WhKHOCtml4H28kvQrBHwIYwg1EY7OKr3wVvJUBRZghnh3fq3dov0lUX5F0Rb16y1JmA== X-Received: by 2002:a1c:7306:: with SMTP id d6mr39593585wmb.113.1594042435462; Mon, 06 Jul 2020 06:33:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:54 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 09/32] usb: gadget: udc: atmel_usba_udc: Remove set but unused variable 'pp' Date: Mon, 6 Jul 2020 14:33:18 +0100 Message-Id: <20200706133341.476881-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093356_492294_0FA1A842 X-CRM114-Status: GOOD ( 11.91 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Alexandre Belloni , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic Desroches , Cristian Birsan , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Commit e78355b577c4b ("usb: gadget: udc: atmel: Don't use DT to configure end point") pulled out all functionality dealing with 'pp'. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/atmel_usba_udc.c: In function ‘atmel_udc_of_init’: drivers/usb/gadget/udc/atmel_usba_udc.c:2106:22: warning: variable ‘pp’ set but not used [-Wunused-but-set-variable] 2106 | struct device_node *pp; | ^~ Cc: Cristian Birsan Cc: Felipe Balbi Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/atmel_usba_udc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index d69f61ff01819..a10b8d406e62b 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -2103,7 +2103,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, { struct device_node *np = pdev->dev.of_node; const struct of_device_id *match; - struct device_node *pp; int i, ret; struct usba_ep *eps, *ep; const struct usba_udc_config *udc_config; @@ -2128,7 +2127,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, GPIOD_IN); if (fifo_mode == 0) { - pp = NULL; udc->num_ep = udc_config->num_ep; udc->configured_ep = 1; } else { @@ -2144,7 +2142,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, INIT_LIST_HEAD(&eps[0].ep.ep_list); - pp = NULL; i = 0; while (i < udc->num_ep) { const struct usba_ep_config *ep_cfg = &udc_config->config[i]; From patchwork Mon Jul 6 13:33:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645861 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7336960D for ; Mon, 6 Jul 2020 13:37:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B207206F5 for ; Mon, 6 Jul 2020 13:37:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nZSlqXpn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="os0d0dx8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B207206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3GoRqW2SZgQAr5rt1nrB4e+KYvfDH7GEgjiD/K9S3hY=; b=nZSlqXpnR9DlNg4ruSqoE0GJf 7c2U/tV85UG1Xp6iPd848z9745MzOHA0r4LR9kVUspm4WY07Hu/gRYZqIMGAnJ86f3d7gzFmXrmAU NCf5/rE0EDZMSDu/yWsTlYFI4Nf+MRZ6rkdS44aYQRT5SQV7X3ugE4SMDhbWUnjwTwj8BhjIyIFTI LnGeSDsn/Rjm+um4PDJYJjUmMeEMxqUQNPwtx8cIcUCF6qloQ1wwpyEl6vIWWFLr+YgDBsL7D77HK hWi2v3UVtqUbRGTpfkj4yvv7/GJeANwsC64bkenSsq+HARSUiAiNPN8G7bDs/gMcOQUD5uD/Ue96A tAnxQwKLA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRHD-0000S8-3C; Mon, 06 Jul 2020 13:35:19 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFu-0008D5-2i for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:00 +0000 Received: by mail-wr1-x443.google.com with SMTP id b6so40927706wrs.11 for ; Mon, 06 Jul 2020 06:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n7/LG8QKfAsUZ5xCCuI2vnf7Sj+c5EJvPq+Icl9Ejy0=; b=os0d0dx8lY4PrV0VCx4VZCbRVDM3s7vVVnY/vA+18e1qU3P3/R/bJTVXFEoxZBax3b H1evzJuHhO3Vf9lGtD/CevHBEjo0+SNdxVktW9IoKWmB/6rtywuxMeCHzwvvtwgP0gZv iDOnInpllmtroWuWZ0seJrk6D1D3YOVkjFObAGw+RXxVOq6bTk9TABngguksuBbbeMSb E+fx0zxFxP07AGEaRcKKn+ANTY3M6cY1izjCqRv23X6tLJUCdKZ3+bll9J/WTLpLQIvX SNlAaXxAnaPkVju6B1V7ZJ03U6SKfOX+L1LAEHgGxR58QOar2re6Pj23qdjIRBLb/rre aXJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n7/LG8QKfAsUZ5xCCuI2vnf7Sj+c5EJvPq+Icl9Ejy0=; b=LPm6Y9OkTm/vQli3ujgTMbFgGQrat5+iJTYwSfc3aTVUQFeIwkUj+zF+OubT2nPxcd XYm7xdsfgeI2O/1t8U22ZEDWWmQ8uhemgDAMpnFtsUWTk+H/ES8EGp+vfBYQONfyCoAy 9S66S1r6cMXPC+HAlGL0f/gMQCencJ8tJPjfctqO9oG1RSo9XglrsQx02H3uCfdcW95U C+H9sVwBWfuhmuw2cfgL2uGfcdey0QnAZZTDFYI0vBpbwl89PgdJXjblWAY14caxVdFB ru0WNmjtwe324LNPI+yRHaixCS4p2TvKycSiEJjgMnmQR8NyrRViXf2Wp9I2/LWnZ2K8 Shnw== X-Gm-Message-State: AOAM533qU8iSUi7HZ/e777OD20jBb5k4tb/ONdVz0jr01oymvtUItBP7 QPU4ZZfP5he9zwFDs4HviYMsQQ== X-Google-Smtp-Source: ABdhPJxDvbV0BLobErzaVbEqiNwKzRAQTJlQ4Ma/Du+Zq1WMwRCa/vj3m927hR86GBAms5PrHXR14w== X-Received: by 2002:a5d:4a42:: with SMTP id v2mr45407084wrs.33.1594042436907; Mon, 06 Jul 2020 06:33:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:56 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 10/32] usb: gadget: legacy: nokia: Remove unused static variable 'product_nokia' Date: Mon, 6 Jul 2020 14:33:19 +0100 Message-Id: <20200706133341.476881-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093358_282191_3A1F113E X-CRM114-Status: GOOD ( 11.77 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Al Borchers , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though it's never been used. Driver was introduced in 2010. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/legacy/nokia.c:65:19: warning: ‘product_nokia’ defined but not used [-Wunused-const-variable=] 65 | static const char product_nokia[] = NOKIA_LONG_NAME; | ^~~~~~~~~~~~~ Cc: Felipe Balbi Cc: Al Borchers Signed-off-by: Lee Jones --- drivers/usb/gadget/legacy/nokia.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/legacy/nokia.c b/drivers/usb/gadget/legacy/nokia.c index 978c1a34a9320..2e15f9a32ce9f 100644 --- a/drivers/usb/gadget/legacy/nokia.c +++ b/drivers/usb/gadget/legacy/nokia.c @@ -62,7 +62,6 @@ FSG_MODULE_PARAMETERS(/* no prefix */, fsg_mod_data); #define STRING_DESCRIPTION_IDX USB_GADGET_FIRST_AVAIL_IDX static char manufacturer_nokia[] = "Nokia"; -static const char product_nokia[] = NOKIA_LONG_NAME; static const char description_nokia[] = "PC-Suite Configuration"; static struct usb_string strings_dev[] = { From patchwork Mon Jul 6 13:33:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645867 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7BA6892A for ; Mon, 6 Jul 2020 13:37:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3017120715 for ; Mon, 6 Jul 2020 13:37:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1SSYVnj+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BpLIhIM9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3017120715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fuqphksy1IJA2OjaIbw5nloUgi7uv6DYizTbLtvpxhE=; b=1SSYVnj+GQ3A/mImCa5xuaThw FRm41bkFLETIy5AGa/P5qtdPkgn4bcAzJt5/aVULrPgkfYd5oy4w+7zgqwg21ZJSB+oHbYB2Pjs3U fm70nzJnqv77s8f+q8RiM4zUvbmIBcjY01DlJ++VCbZXTETiAdA1LL6nYORn/F71JzOCKAWmOnvJi n86faxqy/3cPP/ZthRiIZlBDIcybR2X2rF5BfS+g4gim42i4+OU5tTVR8JOno1p4ZS2GFiOQceRP0 lNmingyUeGkQPhGKVnxwPpnMMfOyVMWInbk1c2I3fIfkW8OprPl2ghSUXwhe+cjUun2OwccqQNpmg bvWc+8hiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRHJ-0000V7-7T; Mon, 06 Jul 2020 13:35:25 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFv-0008Di-4Z for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:01 +0000 Received: by mail-wm1-x341.google.com with SMTP id o2so42118504wmh.2 for ; Mon, 06 Jul 2020 06:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F3N+fzezv1MWYIkYTGHlx08nxeXYi/20m77vgS5T6os=; b=BpLIhIM9HO9QX/91QqPb0axOZ+f3MusDB+2c/VFHx/69xTyIJRCZQeP3ZiC1KHq3cQ MPMyfOETWx+kDYSAp2ES8FPPerVyUzUHVoDK4ZE3kx0lHJumW3So3ckLNKz1ZjU/aRgM 9UPBYbokmdIFpUzxdVL/M8Xe6mMwTbF2QrISRvdMpcpb/a4z6XCoUGhvmgYxiOia5lXw fF0G+NETlZp53qRczU0psHvtC9Do08Z+EKc5a0LRflRb6uiSioO1p6Oi7nnKQIyPsFsS iyd7IeCm1h4s1m2dHMRE4UnfHf2FurtJS8GyFbNTXVkCDhdfO9Xv5XIEDIGWp6x38Uyb stNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F3N+fzezv1MWYIkYTGHlx08nxeXYi/20m77vgS5T6os=; b=itIErAZ7AiUxeIEmaYHj5DtyZWtGOQvB5kIeoiZ1M571nMA9r1qoMioLfxxKhw9tIn GUI+t6JzX2M0LPIAiFaU/l5MKe6uPywVKn3gQvRipT+8nKULPl5DCj1eqB0moVCiJEuy rC7ftdAJUdSllT0U8p9lOGa1uB/hmW3A0pc5BAIyEnRkxyijQyvODTjRTJT1doefCtzx gU6F606jxhYQmKI4SllCZlBmFmja02XtwGbo93EI8Q6FD3/47qalZMFdPCHsJhfGeJUg tQXJUuAQsBDo/zIV7k2D3AOFyvmeTEv+u3lcxzKt02Yx8IiQwVBe2O3Ay+EtuR/voy0Y AR8Q== X-Gm-Message-State: AOAM532euXKk1F73CqVsAjPy/bGifopXxzU1h2VyBD8QRjz/47BGERsk pPXehG1t73MfYBIrusS2bz+WSg== X-Google-Smtp-Source: ABdhPJw84chABX+3T3NQgrsvaRU3aLogEgRaFQd3ljAQ8Bw2zi12v8ZyS4JXvweac2ZKGE4NngEQgA== X-Received: by 2002:a7b:c013:: with SMTP id c19mr48981840wmb.158.1594042438048; Mon, 06 Jul 2020 06:33:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:57 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 11/32] usb: gadget: function: f_fs: Demote function header which is clearly not kerneldoc Date: Mon, 6 Jul 2020 14:33:20 +0100 Message-Id: <20200706133341.476881-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093359_277686_B0D26568 X-CRM114-Status: GOOD ( 13.40 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Nazarewicz , David Howells , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'type' not described in '__ffs_data_do_os_desc' drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'h' not described in '__ffs_data_do_os_desc' drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'data' not described in '__ffs_data_do_os_desc' drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'len' not described in '__ffs_data_do_os_desc' drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'priv' not described in '__ffs_data_do_os_desc' Cc: Felipe Balbi Cc: David Howells Cc: Michal Nazarewicz Signed-off-by: Lee Jones --- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 490d353d5fdec..2d00ba0726453 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -2352,7 +2352,7 @@ static int __must_check ffs_do_os_descs(unsigned count, return _len - len; } -/** +/* * Validate contents of the buffer from userspace related to OS descriptors. */ static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, From patchwork Mon Jul 6 13:33:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645865 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CEDDB60D for ; Mon, 6 Jul 2020 13:37:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7624206F5 for ; Mon, 6 Jul 2020 13:37:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WCWv2Klq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bn951av1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7624206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U/QlL2NAPXiqHmAPHImqMmZ6wkicScMvT11ZKJzAqkg=; b=WCWv2KlqRDAJz7U5G+qbnh/OH zGdblwuAq7bBEvdh0H5oyDXAmmPy2UQ2Q0LOevb3lgW1LwRulc7G4solHrRbNAMj6PKy0wksWjZ9O 3YeBKqUnnX9Ss2u+gIfafYliWPVdFgjJs1xhlV5hg9BSA0xo+48DLKysrrPmDH8HE3lIPW8BHOdEG lMhFXu/SqqX1HCxlyuyA4csIk+yzxaToe+rkyvN12V57mt+0oW6dkRmWKc5yNJqsbD6IuSjHnmcqT NRcirQQS8gPtqxxLqazG0soQTf9VYzleRl1uQIsNTtFp45BKvDv9L6RZTTZMJumhKc0YATFpZPdHy j5LInLVqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRHN-0000Yv-PL; Mon, 06 Jul 2020 13:35:29 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFw-0008EJ-4a for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:02 +0000 Received: by mail-wm1-x342.google.com with SMTP id 17so42073251wmo.1 for ; Mon, 06 Jul 2020 06:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FTimBbBqnMIcQ4eF+VH5m9hye6WMpkC2MlXIy//Z9tM=; b=bn951av1tIBYht5lk9qvY08u0Jgt22BUCKc6vohyqII3OtrGaVeusFgOTPFhqV+i2k p06vfQqGi7JFF4w8LRU6xPFLkIdxuI9J0W8p4lHaQpIytn8kmIblmkWpEIO17UKu+gPf FXeWg/QFad9y2n/5Q8UzWgI3E11IBWoAiWlUX7yiymCFcvPQex79oxP8yohjP6Wsdjol SVkyuBtzjZ/SHYPWMfIDXcXPdKkuaWT6aAmYFvyBne/hm6iaMSsqC427PTvk+2Dq8+ki W7eZeeuLkAhkX4IudL6VGhPcZ6DO+hSxad4t9YaHQaSXU7OGASjpxkSL2XDydREO5DXp giBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FTimBbBqnMIcQ4eF+VH5m9hye6WMpkC2MlXIy//Z9tM=; b=k7zih7jdktHi7Pzy9L/Tq3+w2apwey6FpShPKZ9nXE7Xt1DeOGEcYxp5XPYPrGIz5u V3lis8UvHVefau21kAl5CAVh7fF6++M0oasRMY2O3Shby3Hr3eZdXFdoA03V60wTqybo ZnXWaN3wUwA371pc3IOeeayTwY1FgNODf6GdJkH+BWb2brMDZPCiwM3RiAF9AoG24OX0 kad/aQe5aMgE5HsrPPRXFdxEdPeGEb4npKpMcuFLombKzYaVWFWIfJNG+UF3FavTIL4/ f9IVmZygFhJIxFKM2CJMb5Dory59ifW1o+QCA2xfQdOj5DbtxMFNwglqHty1Hy17DyZA B9NQ== X-Gm-Message-State: AOAM532d+RvR0RGVr5xXx1MUx9kHiMmkXKKJlGldRr0t2PcexhiaWay7 Q5//XU9bHfpQ7cTfBub1tuZefa+hHAs= X-Google-Smtp-Source: ABdhPJy2ORInauH49b7tohotkeMYtKjc4Phc6yZfNYXtKYgAdNWMLI138LZhx0E2XlgFikEOm95mpA== X-Received: by 2002:a1c:dfd6:: with SMTP id w205mr52128827wmg.118.1594042439124; Mon, 06 Jul 2020 06:33:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:58 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 12/32] usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions Date: Mon, 6 Jul 2020 14:33:21 +0100 Message-Id: <20200706133341.476881-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093400_278774_F562848C X-CRM114-Status: GOOD ( 13.76 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roland Stigge , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kevin Wells , Vladimir Zapolskiy , Sylvain Lemieux , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org These are not used outside of this sourcefile, so make them static. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/lpc32xx_udc.c:1929:6: warning: no previous prototype for ‘udc_send_in_zlp’ [-Wmissing-prototypes] 1929 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) | ^~~~~~~~~~~~~~~ drivers/usb/gadget/udc/lpc32xx_udc.c:1943:6: warning: no previous prototype for ‘udc_handle_eps’ [-Wmissing-prototypes] 1943 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) | ^~~~~~~~~~~~~~ Cc: Felipe Balbi Cc: Vladimir Zapolskiy Cc: Sylvain Lemieux Cc: Kevin Wells Cc: Roland Stigge Signed-off-by: Lee Jones Acked-by: Vladimir Zapolskiy --- drivers/usb/gadget/udc/lpc32xx_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index 465d0b7c6522a..4a112670cc6c4 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -1926,7 +1926,7 @@ static const struct usb_ep_ops lpc32xx_ep_ops = { }; /* Send a ZLP on a non-0 IN EP */ -void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) +static void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) { /* Clear EP status */ udc_clearep_getsts(udc, ep->hwep_num); @@ -1940,7 +1940,7 @@ void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) * This function will only be called when a delayed ZLP needs to be sent out * after a DMA transfer has filled both buffers. */ -void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) +static void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) { u32 epstatus; struct lpc32xx_request *req; From patchwork Mon Jul 6 13:33:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645871 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5CA4814DD for ; Mon, 6 Jul 2020 13:37:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF58720702 for ; Mon, 6 Jul 2020 13:37:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zmoSzK+G"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OmZFfKsZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF58720702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gn+jStk1qZg8t1ve/6xSWhZw7kXq+gPg5VsMT0YGmX0=; b=zmoSzK+GwezZkXzp+CTZ3J/Eg g5I6cgW2lp7koD+HHRowuvcU6YIEiY8D2knaqoFE7bjbpa2YpjGqFm85z6FYSYaQdNuyPEKOkDZ0s g0e/Kg5aBexfumABl65IMdccR7B6W4VxKFJ3o3TNkuHI5rSeIV7GOQ9Q7AVihaqSGr5sK4W26FpQs 6LAkx3sPyjLxf2D4WdFEqR/ZV13koseGF9LWGfzJrvXh9Fkvj1V2rkaXdoShQtFrtZPj/TI0Tsc5b 5LJ8EpoqcWnT1hFpgGZ5lSdwboCiM6PFaV4xx44Bs9PxEpW6OcZVrZeHOr+M3W7UFA7ozOazrVAil xE1xxI/9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRHS-0000c9-4V; Mon, 06 Jul 2020 13:35:34 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFx-0008Ei-5S for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:04 +0000 Received: by mail-wm1-x343.google.com with SMTP id o8so39367323wmh.4 for ; Mon, 06 Jul 2020 06:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=OmZFfKsZE3nw2Rx7QazBJNlNeA+U8z1Z2PcNhcqjoK68z1sVetkUL2vJdCbMgfCx+z GQ5OdTbXa+xGGweQRAIjQY+yIMbO16Ik2oUI+cRDjkln/G96vTY+Sv3Hmg9wjeMj9Moe wjup2WRBceFy+RvHDn6sGC88K+miXgtBtFdiQiKW7ax7JwncaSGkDlPgFdll46+6/YiB c2Hvox1thv7IHBF2cFtkUXRSO0tVbQdaKgKzefw5AxbQcMOI86AnSy5xCXNu/8SdAEfj tMQN++j0iRkOEy/9hGk3KCKGViLlrFbGp+lhcUlgAE3JBu5bqpBfe9atSyQizMIJsTA+ txEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=ochUlcE0geJU0l8j7gQOl6b8xSPcHhz/11noLyhZ+1D77laRbGMbfLGfXYUibEtNbu 6gnKXjI92O76hX3s8SMUfqIxkrs75RHY7sxtTbjm1o8ZFRUrHzTje0uimAZTmm9q6jJm 6fgkJVXwPJak7xQ8Xeri+tpNprDcP0ETX8+GCkFnHWeEqT+PLmpvZs43YVWtAssRK2PK Uzz2KQFzokE029RoKqwKgbGdIaEISC3zyiiQBAbv6iUVHe/hkCRiwLirzBuE2qvDaLbf XcS7WEINXhWoBTRMDVzaB/4acfAyjpaOpiHjW6PBzuyaBWKsCh6g3gcuPIT6v+5/rWhl cBcw== X-Gm-Message-State: AOAM530zrPh5OWlm2CRj/nRl7owKaxaHa8XgqLJhVTtd58Z61cTPsFIX Xx7pJeeBlWWOLcSHwhtXX7rHhQ== X-Google-Smtp-Source: ABdhPJzHeQs23/qyFcnX4TERiDrg/KCZCBqe16Wspkyc46J1cIxb5+c8wXVxLRMwjJxdzWxMdM1HWA== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr2416268wmh.121.1594042440115; Mon, 06 Jul 2020 06:34:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:59 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 13/32] usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' Date: Mon, 6 Jul 2020 14:33:22 +0100 Message-Id: <20200706133341.476881-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093401_277794_E77DEBA0 X-CRM114-Status: GOOD ( 11.18 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yoshihiro Shimoda , linux-usb@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks like it's been this way since the driver's inception in 2007. Fixes the following W=1 kernel build warning(s): drivers/usb/host/r8a66597-hcd.c: In function ‘clear_all_buffer’: drivers/usb/host/r8a66597-hcd.c:478:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] 478 | u16 tmp; | ^~~ Cc: Yoshihiro Shimoda Signed-off-by: Lee Jones --- drivers/usb/host/r8a66597-hcd.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c index 0c03ac6b02137..63719cdf6a4e6 100644 --- a/drivers/usb/host/r8a66597-hcd.c +++ b/drivers/usb/host/r8a66597-hcd.c @@ -475,16 +475,14 @@ static void pipe_stop(struct r8a66597 *r8a66597, struct r8a66597_pipe *pipe) static void clear_all_buffer(struct r8a66597 *r8a66597, struct r8a66597_pipe *pipe) { - u16 tmp; - if (!pipe || pipe->info.pipenum == 0) return; pipe_stop(r8a66597, pipe); r8a66597_bset(r8a66597, ACLRM, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); r8a66597_bclr(r8a66597, ACLRM, pipe->pipectr); } From patchwork Mon Jul 6 13:33:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645873 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F31BE60D for ; Mon, 6 Jul 2020 13:37:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC39B206F5 for ; Mon, 6 Jul 2020 13:37:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kDXqYevI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d1ILBA/2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC39B206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3gL0uYHIwcpjyoidcfqtSqSkPWHjmvd4nfa7jpXIRi8=; b=kDXqYevIRLS9wbtp4U3rbkVg+ bEFHe1FgTYZBbLCLyziO7m6wSxpp+7LuS3cJfstlHfS0S6Lz4RyisS1fu2DwR6Vuc3Sbk1Mga8+NH 00oiv6snmJrFhrnYYLGxdtWVJJQnzOCwqtktzbpXqpMigJV+l+7vXWbWfrvQYVzy4ks/aVpSRz5Aq GaW1ux6OBXnhUit6eA/IFFkHStKY7PIChXIY0vjXM8C6x7C9PF86X+qJ9aIL9a2Xj6k+L0XQwM1oV Wz8yTG2n+JRmcoBoLtdgcyE0YA8aGH4U/knliVIg1TmlqD29tgcGrxQ1Xk8bIzUQnV6xkVYSOkZ+/ 1+EAm328A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRHZ-0000h6-E9; Mon, 06 Jul 2020 13:35:41 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFy-0008FH-AU for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:04 +0000 Received: by mail-wr1-x441.google.com with SMTP id s10so40899278wrw.12 for ; Mon, 06 Jul 2020 06:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KCHAGi+yis7rT4RcJ1xkGNsqK+uVMhPXLaq/wOq2nXg=; b=d1ILBA/20Tq+wf0tqPOsJ+Q7ruJ9GVdOks6k+ffLS4tTGE0XaURNCIQ3lPi3D8MqNy 6bfpQGGIvvkd7dqLML2B/x3dDVz1X2KSrKeKImRiplCftwatlzk4iTY1bSQWuRoNS6CN n+d6tzIzTcqwW84lCy7LOKRcFOHHbSATtvadCsaCKyNI8wsUmOMuAtEzSoIoYXzf4TsO Pa25MqF0q1O3Onbn/OmoYNR44areZTUJ7E38CrsTHRAwH9fameB3YKH/n/EwJedUzvzp PiJOKFvVHKVlf5cdnE+5q7vJa6crbxjM7PG0iwmBGNtpdFRf+AbWmusFYIrj9TqmKxao h3pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KCHAGi+yis7rT4RcJ1xkGNsqK+uVMhPXLaq/wOq2nXg=; b=U7kxQs7V86cVf4mOoP1aKUwgT7UdE8RMKL++M17EUb8UwUTQfDD4QB1UxcR9ki0jAo uvecPSFACRVB+UJ/c26ECJJbWQXHXetL6zJEc4KS9xnrdbCfaBHXPyptIsCU/Dby4KXl uZqgBlwh+DhUoHXnCrIc7kCHCAcBIJEz02duQ+COm9FMUrqEMiMXeR5uY9BbYVNKIVsO +FwzRJLKFCl76aAKwYalSqC60pdbRQQGMz+Zke5w9O+WYmh7BlQMiALG4JoVj+ipcIbd YGAsJbzkvQIlK5xe/fBFvpUdxoGbYsXeySK6UTQl/jDD03Mp2JwDBLXhFfe0h/zSDq3g iFLQ== X-Gm-Message-State: AOAM532g2dIW8kK2+E2wDgk7PR35TKDtmwjipHnVcs4A2DoVvWVkScbI IwXo8o7VtC6luOXRr6WTpUKfZA== X-Google-Smtp-Source: ABdhPJy2Eg3D1zjnU2FxioIxSHD9bWpgEVorUJ2S4pILADo+vEbjB7rEn1A92h/ru5KDKIiVhqYg/w== X-Received: by 2002:a5d:5706:: with SMTP id a6mr13466028wrv.328.1594042441319; Mon, 06 Jul 2020 06:34:01 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:00 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 14/32] usb: gadget: udc: mv_udc_core: Remove unused static const variable 'driver_desc' Date: Mon, 6 Jul 2020 14:33:23 +0100 Message-Id: <20200706133341.476881-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093402_456555_91DF925B X-CRM114-Status: GOOD ( 11.40 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Xie , Neil Zhang , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though it's never been used. Driver was introduced in 2014. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/mv_udc_core.c:56:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=] 56 | static const char driver_desc[] = DRIVER_DESC; | ^~~~~~~~~~~ Cc: Felipe Balbi Cc: Chao Xie Cc: Neil Zhang Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/mv_udc_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index 2384b55f9d3e8..0fb4ef464321d 100644 --- a/drivers/usb/gadget/udc/mv_udc_core.c +++ b/drivers/usb/gadget/udc/mv_udc_core.c @@ -53,7 +53,6 @@ static DECLARE_COMPLETION(release_done); static const char driver_name[] = "mv_udc"; -static const char driver_desc[] = DRIVER_DESC; static void nuke(struct mv_ep *ep, int status); static void stop_activity(struct mv_udc *udc, struct usb_gadget_driver *driver); From patchwork Mon Jul 6 13:33:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645877 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D59860D for ; Mon, 6 Jul 2020 13:38:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36C6D206F5 for ; Mon, 6 Jul 2020 13:38:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mXQOr7I6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LmBVebwT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36C6D206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J3R759iw51M+7ugxSb90pT4nrwJxl0VMKA2P4dGBwD4=; b=mXQOr7I6jw2XIrCVJFMgL0hd1 erdocaHkFDPJixHeJvKplZWrKdihosYWX2tIWMSAp7Ed2Fx00AQKniUZeJZhH1Px4QLSCqOeZR6/1 rCsNmupv5fkuxCY5FyW2odMKyU6qi+4Bd+sfQd9hh3NxPnT0cePq+f1xmopkXldwwnX0WxCkIBRAA dzG3lTA9DOY07Qg8n+CEfNoZ2WWDNxIvyKZz+brJrE6WRoeKgSF10Mami0c4lS7ebf4Z1FYT5Aaxi LDt/bm+5lKSZCA53guzxzg6SbBJoOu50hO0KMfGnuPB7S6wvDOlhkBMB7zebqWtZ/OFdLY73oPVVO bHXZnabmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRI7-00014P-JF; Mon, 06 Jul 2020 13:36:15 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFz-0008Fl-O5 for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:10 +0000 Received: by mail-wm1-x344.google.com with SMTP id o8so39367489wmh.4 for ; Mon, 06 Jul 2020 06:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sSBmUEMtRAkmV+CU8DDs33V6Fj7L3lkyKFBYAuPbnWo=; b=LmBVebwTpb3hcf8Ha93SPa2Exe83aigE3ZaCUunazh7JTvq3EWJEWpqGePjMgFSTjb 48vX7pAPemaRg1gLv34mqX7sXrAi3nrEJ9sw6OthtRsStvw4ItfWxnkvnggDsy34E5w9 WqaT5ePM1xzwUTGIf+o6kze7UQ0iHA8TpdfyoA1ZsJFnmAtVIBK+7EYZrAfk4G5wpN3X DAZteStJ5xgL7d1H4sT7JSE2FDseqOLiRfTspauoOJoTD/bnthzve1DhYXa8UH4/DtPU ZUosrpWbfoqcwxEE3GUSHibRfFB/Wq9aZfcqyMgKtusOkeJUIQXfa9x+iX+fjUXlR0QD mQiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sSBmUEMtRAkmV+CU8DDs33V6Fj7L3lkyKFBYAuPbnWo=; b=IbBzg1I3QPf33Pvg+mcbDjToI+WrNko52Q2PNzrzqojljrUfnHnLWVm66hYWB1bsgc 6JxJBLJzzrdFqk57+aWaikVV6mWpgTQLm/0Zaa10MYmjxowajMuZX0WPNA2U52hapWNW NHidd6vd/MwW4lSYIIOTBtu41Ms8hOfp0E9ym46H7TMswG5bltxvhOYg5tEQZKzA+rHG qvXFuFsKjLi+BxiIPPLJb5iyOguPVncJ55H+0ObQCYD7mwHYpzFIygn8J8DWzxx3iBgK cxEGLP74YaLOpHYJYhi+mstslkERKumTLM9PxHmtY3FcPSV82sRmhyoacjtQIAmXNwAp 7YeA== X-Gm-Message-State: AOAM533yHGzp2WTOuSucV/XdBUmky/wWL1Jq5bETLCRl4zwfaPZIMKec IcuaMNm3LGd9z4A+lQT5oAnNgQ== X-Google-Smtp-Source: ABdhPJwZleEIJJnG0EATdvDaGTM4S+5gihL8GAeq5hVd5bhEGIlxo/v6c7sPofOnyiwJwZX1XOuX0g== X-Received: by 2002:a1c:e914:: with SMTP id q20mr47371295wmc.145.1594042442456; Mon, 06 Jul 2020 06:34:02 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:01 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 15/32] usb: gadget: udc: pch_udc: Fix a plethora of function documentation related issues Date: Mon, 6 Jul 2020 14:33:24 +0100 Message-Id: <20200706133341.476881-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093403_977977_0B877634 X-CRM114-Status: GOOD ( 16.09 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb@vger.kernel.org, Chuhong Yuan , linux-kernel@vger.kernel.org, LAPIS Semiconductor , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Ranging from missing descriptions and formatting mishaps to over-documenting of missing arguments, likely due to bitrot. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/pch_udc.c:239: warning: Function parameter or member 'request' not described in 'pch_udc_stp_dma_desc' drivers/usb/gadget/udc/pch_udc.c:315: warning: Function parameter or member 'irq_work_fall' not described in 'pch_vbus_gpio_data' drivers/usb/gadget/udc/pch_udc.c:315: warning: Function parameter or member 'irq_work_rise' not described in 'pch_vbus_gpio_data' drivers/usb/gadget/udc/pch_udc.c:482: warning: Function parameter or member 'ep' not described in 'pch_udc_write_csr' drivers/usb/gadget/udc/pch_udc.c:482: warning: Excess function parameter 'addr' description in 'pch_udc_write_csr' drivers/usb/gadget/udc/pch_udc.c:498: warning: Function parameter or member 'ep' not described in 'pch_udc_read_csr' drivers/usb/gadget/udc/pch_udc.c:498: warning: Excess function parameter 'addr' description in 'pch_udc_read_csr' drivers/usb/gadget/udc/pch_udc.c:662: warning: Function parameter or member 'ep_in' not described in 'pch_udc_ep_set_bufsz' drivers/usb/gadget/udc/pch_udc.c:977: warning: Function parameter or member 'ep' not described in 'pch_udc_ep_enable' drivers/usb/gadget/udc/pch_udc.c:977: warning: Function parameter or member 'cfg' not described in 'pch_udc_ep_enable' drivers/usb/gadget/udc/pch_udc.c:977: warning: Excess function parameter 'regs' description in 'pch_udc_ep_enable' drivers/usb/gadget/udc/pch_udc.c:1010: warning: Function parameter or member 'ep' not described in 'pch_udc_ep_disable' drivers/usb/gadget/udc/pch_udc.c:1010: warning: Excess function parameter 'regs' description in 'pch_udc_ep_disable' drivers/usb/gadget/udc/pch_udc.c:1030: warning: Function parameter or member 'ep' not described in 'pch_udc_wait_ep_stall' drivers/usb/gadget/udc/pch_udc.c:1030: warning: Excess function parameter 'dev' description in 'pch_udc_wait_ep_stall' drivers/usb/gadget/udc/pch_udc.c:1341: warning: Function parameter or member 'data' not described in 'pch_vbus_gpio_irq' drivers/usb/gadget/udc/pch_udc.c:1341: warning: Excess function parameter 'dev' description in 'pch_vbus_gpio_irq' drivers/usb/gadget/udc/pch_udc.c:1365: warning: Function parameter or member 'vbus_gpio_port' not described in 'pch_vbus_gpio_init' drivers/usb/gadget/udc/pch_udc.c:1510: warning: Function parameter or member 'dev' not described in 'pch_udc_free_dma_chain' drivers/usb/gadget/udc/pch_udc.c:1510: warning: Function parameter or member 'req' not described in 'pch_udc_free_dma_chain' drivers/usb/gadget/udc/pch_udc.c:1717: warning: Function parameter or member 'usbep' not described in 'pch_udc_pcd_ep_disable' drivers/usb/gadget/udc/pch_udc.c:2006: warning: Excess function parameter 'halt' description in 'pch_udc_pcd_set_wedge' drivers/usb/gadget/udc/pch_udc.c:2756: warning: Function parameter or member 'pdev' not described in 'pch_udc_isr' drivers/usb/gadget/udc/pch_udc.c:2756: warning: Excess function parameter 'dev' description in 'pch_udc_isr' drivers/usb/gadget/udc/pch_udc.c:2906: warning: Function parameter or member 'dev' not described in 'init_dma_pools' drivers/usb/gadget/udc/pch_udc.c:2906: warning: Excess function parameter 'pdev' description in 'init_dma_pools' Cc: Felipe Balbi Cc: Chuhong Yuan Cc: LAPIS Semiconductor Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/pch_udc.c | 36 ++++++++++++++++---------------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index 3344fb8c41811..8afc31d94b0e4 100644 --- a/drivers/usb/gadget/udc/pch_udc.c +++ b/drivers/usb/gadget/udc/pch_udc.c @@ -229,8 +229,7 @@ struct pch_udc_data_dma_desc { * for control data * @status: Status * @reserved: Reserved - * @data12: First setup word - * @data34: Second setup word + * @request: Control Request */ struct pch_udc_stp_dma_desc { u32 status; @@ -304,8 +303,8 @@ struct pch_udc_ep { * for detecting VBUS * @port: gpio port number * @intr: gpio interrupt number - * @irq_work_fall Structure for WorkQueue - * @irq_work_rise Structure for WorkQueue + * @irq_work_fall: Structure for WorkQueue + * @irq_work_rise: Structure for WorkQueue */ struct pch_vbus_gpio_data { int port; @@ -475,7 +474,7 @@ static void pch_udc_csr_busy(struct pch_udc_dev *dev) * pch_udc_write_csr() - Write the command and status registers. * @dev: Reference to pch_udc_dev structure * @val: value to be written to CSR register - * @addr: address of CSR register + * @ep: end-point number */ static void pch_udc_write_csr(struct pch_udc_dev *dev, unsigned long val, unsigned int ep) @@ -490,7 +489,7 @@ static void pch_udc_write_csr(struct pch_udc_dev *dev, unsigned long val, /** * pch_udc_read_csr() - Read the command and status registers. * @dev: Reference to pch_udc_dev structure - * @addr: address of CSR register + * @ep: end-point number * * Return codes: content of CSR register */ @@ -656,6 +655,7 @@ static inline void pch_udc_ep_set_trfr_type(struct pch_udc_ep *ep, * pch_udc_ep_set_bufsz() - Set the maximum packet size for the endpoint * @ep: Reference to structure of type pch_udc_ep_regs * @buf_size: The buffer word size + * @ep_in: EP is IN */ static void pch_udc_ep_set_bufsz(struct pch_udc_ep *ep, u32 buf_size, u32 ep_in) @@ -968,7 +968,8 @@ static void pch_udc_ep_fifo_flush(struct pch_udc_ep *ep, int dir) /** * pch_udc_ep_enable() - This api enables endpoint - * @regs: Reference to structure pch_udc_ep_regs + * @ep: reference to structure of type pch_udc_ep_regs + * @cfg: current configuration information * @desc: endpoint descriptor */ static void pch_udc_ep_enable(struct pch_udc_ep *ep, @@ -1004,7 +1005,7 @@ static void pch_udc_ep_enable(struct pch_udc_ep *ep, /** * pch_udc_ep_disable() - This api disables endpoint - * @regs: Reference to structure pch_udc_ep_regs + * @ep: reference to structure of type pch_udc_ep_regs */ static void pch_udc_ep_disable(struct pch_udc_ep *ep) { @@ -1024,7 +1025,7 @@ static void pch_udc_ep_disable(struct pch_udc_ep *ep) /** * pch_udc_wait_ep_stall() - Wait EP stall. - * @dev: Reference to pch_udc_dev structure + * @ep: reference to structure of type pch_udc_ep_regs */ static void pch_udc_wait_ep_stall(struct pch_udc_ep *ep) { @@ -1331,7 +1332,7 @@ static void pch_vbus_gpio_work_rise(struct work_struct *irq_work) /** * pch_vbus_gpio_irq() - IRQ handler for GPIO interrupt for changing VBUS * @irq: Interrupt request number - * @dev: Reference to the device structure + * @data: Reference to the device structure * * Return codes: * 0: Success @@ -1354,8 +1355,8 @@ static irqreturn_t pch_vbus_gpio_irq(int irq, void *data) /** * pch_vbus_gpio_init() - This API initializes GPIO port detecting VBUS. - * @dev: Reference to the driver structure - * @vbus_gpio Number of GPIO port to detect gpio + * @dev: Reference to the driver structure + * @vbus_gpio_port: Number of GPIO port to detect gpio * * Return codes: * 0: Success @@ -1499,8 +1500,8 @@ static void empty_req_queue(struct pch_udc_ep *ep) /** * pch_udc_free_dma_chain() - This function frees the DMA chain created * for the request - * @dev Reference to the driver structure - * @req Reference to the request to be freed + * @dev: Reference to the driver structure + * @req: Reference to the request to be freed * * Return codes: * 0: Success @@ -1707,7 +1708,7 @@ static int pch_udc_pcd_ep_enable(struct usb_ep *usbep, /** * pch_udc_pcd_ep_disable() - This API disables endpoint and is called * from gadget driver - * @usbep Reference to the USB endpoint structure + * @usbep: Reference to the USB endpoint structure * * Return codes: * 0: Success @@ -1996,7 +1997,6 @@ static int pch_udc_pcd_set_halt(struct usb_ep *usbep, int halt) * pch_udc_pcd_set_wedge() - This function Sets or clear the endpoint * halt feature * @usbep: Reference to the USB endpoint structure - * @halt: Specifies whether to set or clear the feature * * Return codes: * 0: Success @@ -2750,7 +2750,7 @@ static void pch_udc_dev_isr(struct pch_udc_dev *dev, u32 dev_intr) /** * pch_udc_isr() - This function handles interrupts from the PCH USB Device * @irq: Interrupt request number - * @dev: Reference to the device structure + * @pdev: Reference to the device structure */ static irqreturn_t pch_udc_isr(int irq, void *pdev) { @@ -2900,7 +2900,7 @@ static int pch_udc_pcd_init(struct pch_udc_dev *dev) /** * init_dma_pools() - create dma pools during initialization - * @pdev: reference to struct pci_dev + * @dev: reference to struct pci_dev */ static int init_dma_pools(struct pch_udc_dev *dev) { From patchwork Mon Jul 6 13:33:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645875 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C91AA92A for ; Mon, 6 Jul 2020 13:37:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BCD4206F5 for ; Mon, 6 Jul 2020 13:37:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hANQ43I8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n9EIrN7G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BCD4206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XkFBxSlBsveBDB0sCio2P/Kx1DGQf9aQE3weYCbI9QI=; b=hANQ43I8LGKkY2M+OMS+mIRKc 348xoyrPm8SfXiHowsW4NZiUDL1jA502JWY1+Hq9ZeVkHai187IRekQPiXBSy0/lJBjskplfcaX1q M1I7XZMRhwloQhM0+QnIIEv7Pl5UgUhpr14x36Gp8EYxqGhxlrdvfnyb/JafA+qrwMsOZZ/W7XmOE 7/F/9szOnTjBXl7BT4TcY9tcctkVJxQEIKVgYU81klkIawghCDEgP9+1XUW9l3PhF498HWir+jssv yQl4yJqLXF53fGtncj26F6I+Ra4rQIVbm8tQCjMeEs17RMf62qo1I6H+HbfYp9wQt9sLs+KbV1b8b RKXkA3e0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRHp-0000s1-In; Mon, 06 Jul 2020 13:35:57 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG0-0008GD-Lw for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:08 +0000 Received: by mail-wr1-x444.google.com with SMTP id z2so18681393wrp.2 for ; Mon, 06 Jul 2020 06:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GNre9OCmAxyss+/an4xQhs3AGuEV6paz8+9ZDHvC1J4=; b=n9EIrN7G3akIgWOBqzyERxZhfzrR9fJGgAr0I5uOS7PMKd2/If2vceE3yjXA1b/eZZ qN3X40tIDqUzGlEgMn0NMHgN6bPz+FRCzIjbeU5YntfppHpfycT/2OcjyBD9MbXMHH02 OAP80qDZ/zvXp0E2Jnb7TOliZnTx2ngHJYqDWJHlo/tMh8+1qQfVZkuz2a58o08kRx4M zF3huI5CGRipEwA6l9h/nCGNATepgZn8qDH7q91rmF3uOAt3E5xdsJAmRFnaRysZtFNy ShO/sIOYPlLSWlNUwKcP5X+GpzdLohe7Jl5tgxA/WU0feCd8kmHyPcohnDu2G/JQnpLS 2TVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GNre9OCmAxyss+/an4xQhs3AGuEV6paz8+9ZDHvC1J4=; b=ISOSf9t3RfzvVAoFwBw5T4KIbIcp7z9snoO8zuYHfJu5+TcMP/KXuDmj3L7F715iNv H0cWoKY4HmH4PaXsxYeZIilAuBhSA6Bv9iM5vXr3yWvTcoNxj4Snwy6TQBSJo6pwmr6u nsxy5CCUSXOrU0aUOs26j8i9P4w3pMaxVzpoT3sh2Ujcbki1TGKI4S+KR+jIDAHxvpss aZ3tlA7p2OlNlz8kcZXqH/Orw0Uah0KacBC5W3PrPbJt28QO/RpsJsyWDt9j0lfZ0zcD fjU99y1GJXsQXCzp5J22kvUeVbqufJGAnxrPEyQQV2HTrAdS6uzlweWr+qn830hiTNt8 hP2g== X-Gm-Message-State: AOAM533NBRFzuxG2SJMCubqAssNWcoAc9K96aENZiMEz8xlbn/xBnLYf yGnpHpKAJN19B+xBb7IaYWnWXw== X-Google-Smtp-Source: ABdhPJx5Dq5C1EhkZdMxsgfApXgr0cOIhDoivpkexRKYjAKcjnC2QN2Yq3ue3sIKyjTLwO40wsMNQg== X-Received: by 2002:adf:e74e:: with SMTP id c14mr51614270wrn.143.1594042443610; Mon, 06 Jul 2020 06:34:03 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:03 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 16/32] usb: host: imx21-hcd: Demote function header which is clearly not kerneldoc Date: Mon, 6 Jul 2020 14:33:25 +0100 Message-Id: <20200706133341.476881-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093404_780315_97987F3A X-CRM114-Status: GOOD ( 13.80 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Jay Monkman , Lee Jones , Sascha Hauer , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'imx21' not described in 'copy_to_dmem' drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'dmem_offset' not described in 'copy_to_dmem' drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'src' not described in 'copy_to_dmem' drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'count' not described in 'copy_to_dmem' Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Stephen Boyd Cc: Jay Monkman Signed-off-by: Lee Jones --- drivers/usb/host/imx21-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/imx21-hcd.c b/drivers/usb/host/imx21-hcd.c index 5835f99662046..b2716cb724719 100644 --- a/drivers/usb/host/imx21-hcd.c +++ b/drivers/usb/host/imx21-hcd.c @@ -224,7 +224,7 @@ static void setup_etd_dword0(struct imx21 *imx21, ((u32) maxpacket << DW0_MAXPKTSIZ)); } -/** +/* * Copy buffer to data controller data memory. * We cannot use memcpy_toio() because the hardware requires 32bit writes */ From patchwork Mon Jul 6 13:33:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645879 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7308860D for ; Mon, 6 Jul 2020 13:38:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12B69206F5 for ; Mon, 6 Jul 2020 13:38:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ys8FtxUw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fczPaGVo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12B69206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Afn/LDhAP99v52upo4ejeTgxwp3Ls+DDxVkshJjqx8I=; b=Ys8FtxUwFJIg6j/KWaRoOuhve 0u/pMA0XuoQ/NExIRcmlJcCAnxurXGgwOKA3DaURqHD2ZAI56juNtckrHFhSXCjphxZRe0tkba9fR HXP9BMW72pHe6hnVID59zS4d6z8njY39WK6oLonvvrC7ErkprnoWKFYV9sWQP3H4h1krCq/0pXDin z/b0vWVNl0W2WOjLsCAluVyUQzSVFmWuxc7pXEeHxlFBFzteSvb+rzOdCkg3ObBduSK/Dax5jzgio G//V0T0PReT7/2pc9o1H1HB/rl2xXZbobE6rEtJsCQHIYt0rSxiKM1Bk9T0s7JXD9cs3aCwkMi1Cb MI5Wt1ceA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRIU-0001KZ-Cd; Mon, 06 Jul 2020 13:36:38 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG2-0008Go-1h for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:10 +0000 Received: by mail-wm1-x342.google.com with SMTP id j18so39372538wmi.3 for ; Mon, 06 Jul 2020 06:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2XV6WS/bjGR5kvGNxTMlo6KlRGNUtCcJKS3bvPtDJNg=; b=fczPaGVofLQoIlvYv0yf39Kkx0ejpT8IQpmzlyEiDrJUrZ/MVqPYhOAJMwVAKoB1ZU 6J89HvSTdqwH4sVQ9ehrAlrY3rUMG4ReE6aDw3yaZbWeVDRbwD2ZN/LGf5R7IYcwl16l pUjsgPJLFd9N9yyj+ewLUNlIVcCseEtDtuxb+wQFF8GdHXhG4QBEmkxfd/G1ipCvMoRm jh5DxCSHMunlB+DcdKO4cvt+K41fR+0zlKIzEj8el/peWXv+2bbw3u3V69lc+c9I2loI xLGaaq388tf6iFV/oZSWojK8abf0KikizWybxZt7Q1cMFodxZXt0vZUlLJkj3kNY/f/5 TaaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2XV6WS/bjGR5kvGNxTMlo6KlRGNUtCcJKS3bvPtDJNg=; b=gr/aLAmKXiKWUvJoS3MZcpE3cFQGKcn8F6L939NNc23W+cgP8TzzXNpxy5bPiIfgoD /7RA3bbxCxtSMux0dJF4yWH/F3dxn5r5meUgPN7NM+bhlcXIAs/aWQchrLuHo6j6fs4v bdAdqw8Uy346VRlZlqIUvSYi7DKnqKxM9Urj4muCsFfrEJxBDtw7Yqiwqxmr94CcR4gU wfwPPKX/UARnDhn1EK47l990wGHlfhn1ZkM5qZixB9CNjOPw9fI3+wTCWQIQG2oLV3fM rQiLTQ2zxGQEcphOC0TMne08UzEfWyKE/jRSHeNXunEQMr7MDM3Mz7dDgG6O+/JHmJG3 kvGQ== X-Gm-Message-State: AOAM533pHC3JPlt8qfJ+TdJLIadi8RzRVZ52L+esql8/If7viQLfjvTb J5JfTLa8AsZcuP0SY766VJortksLWwo= X-Google-Smtp-Source: ABdhPJzh1m0Q8D26lQhCsRUAqNMwqePsc1dSEF5Rz1dklZVY+dBtULcNL8uqxOmLNNODWphQLHWsxg== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51112164wma.4.1594042445108; Mon, 06 Jul 2020 06:34:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:04 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 17/32] usb: host: ehci-fsl: Fix incorrectly named function argument Date: Mon, 6 Jul 2020 14:33:26 +0100 Message-Id: <20200706133341.476881-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093406_183035_06535A14 X-CRM114-Status: GOOD ( 12.00 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jerry Huang , linux-usb@vger.kernel.org, Dave Liu , linux-kernel@vger.kernel.org, Alan Stern , Randy Vinson , Anton Vorontsov , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/usb/host/ehci-fsl.c:694: warning: Function parameter or member 'pdev' not described in 'fsl_ehci_drv_remove' drivers/usb/host/ehci-fsl.c:694: warning: Excess function parameter 'dev' description in 'fsl_ehci_drv_remove' Cc: Alan Stern Cc: Randy Vinson Cc: Dave Liu Cc: Jerry Huang Cc: Anton Vorontsov Signed-off-by: Lee Jones --- drivers/usb/host/ehci-fsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index 9e9c232e896fa..1ebe4d425277d 100644 --- a/drivers/usb/host/ehci-fsl.c +++ b/drivers/usb/host/ehci-fsl.c @@ -683,7 +683,7 @@ static const struct ehci_driver_overrides ehci_fsl_overrides __initconst = { /** * fsl_ehci_drv_remove - shutdown processing for FSL-based HCDs - * @dev: USB Host Controller being removed + * @pdev: USB Host Controller being removed * Context: !in_interrupt() * * Reverses the effect of usb_hcd_fsl_probe(). From patchwork Mon Jul 6 13:33:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645883 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2A96260D for ; Mon, 6 Jul 2020 13:38:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03E4C20702 for ; Mon, 6 Jul 2020 13:38:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AJr9WqMo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X6m4FfX9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03E4C20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XHQvoWuufNHBQkVpszijzCKAISk3pICem3EoRwlr5jQ=; b=AJr9WqMoUUrBH8LphopSBeYPn BSDw2EWsC/8Ly+4T5r/kf02g3WJO8yMDAIyiJUShWlXEcAqXUC14hobY1ZTd8J6FZ9k1jl8pemub1 fqj/in/0h8JCXPLYI9lRT9Qu39DHz3eONYwnua21Yw8KB3TLY0I7+0DvP7VhArIWkGTOIl8xwspqf 2NP9q9RDlym+c8sH9ViJVja3GcOfEZh3Nq0rF/q5+0BSfIevtUSUhA5tHkYN/wb1iiKACIxE3ujJ7 IQY9koVlYqMaEJIN/TJjQizITLP7gxSBbUxvBAxOZl16HC+nKPe2JpMq+9k7Rhd/1xY8MDLLzD+iF CyXUmPC+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRIk-0001UV-DY; Mon, 06 Jul 2020 13:36:54 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG3-0008HM-6W for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:11 +0000 Received: by mail-wm1-x344.google.com with SMTP id 22so39377234wmg.1 for ; Mon, 06 Jul 2020 06:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9AX8kUBEDyEZkkrAQRSTc56qB4suyJ5w028cqL1Y9nI=; b=X6m4FfX9HVkIRr8hUC5SaedwmejM6tHKMtWNuYYdOU9/56+ZZC56eTIFTX8DjtS4ei zSEhErkoaN6DfMdi+KsFgHeCmraKSYyUDTDBvwE/NCDhuOL2MzmazL5R1kxb0lRkL57E 0VCH1foQu1eLxq00OzM0aq/zolR4GeCqxx9kPmH0iG1YSvxUN+IFUnR+g7vO2/B1H963 +qy2O46U+JBmheOcj0HsXB/yrv+qOhS2qFnevyOLLYNtUuzADE+5fNDvPnKj35lP87aG DkkfR99J7Nsi0YY/wEHEgayT1PyA0037NW+/sIVocVBF9dVaHhoNijkk9NzyIV3eTstA gKwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9AX8kUBEDyEZkkrAQRSTc56qB4suyJ5w028cqL1Y9nI=; b=lsMmtDw9/xWifdh208IzJM3acdTRaeNcPZkLTakPkqowA2lKE+yxpoRRytUltyO8vj 9pI1eynSagd0izD4khfW2X01ulvsd+S9lydxRZdsVpub7gbPqrUySoEQqIs9tIpkRrMD 8t7KwY+SNQ/PEkWls4sZKDkds9wtL2TUYUPAfuhfsRdjqnwb+cZ07je/fKx++Vja/CZg NY+3H8hSNJtgT+V0cKzomrZsOevRc66O/es/u3sXcZ9Tz3ik6yhxcKnwoQ36dR10lcXx qtxB1KVRKfVmqg5oWEVOfRJj9AzNRnDL6DSbJAx60Mf4ZKMTqGEcUdQS9v0AD9tlXTGY 1Ovg== X-Gm-Message-State: AOAM530OFmdbZgajbxThbjJAxlXFrbLiwLifvEh8FTPydmflI9r8gV4q 8iDkkUiREsZD6jCP3bhvKAzVCw== X-Google-Smtp-Source: ABdhPJy/vW4eBdtZFwh7RKJcvlKpAd8CeAoqiMJQAacobWRvOb+MQ1KwteySTGzaqMrxvN2XhuOPgg== X-Received: by 2002:a1c:7306:: with SMTP id d6mr39594381wmb.113.1594042446244; Mon, 06 Jul 2020 06:34:06 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:05 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 18/32] usb: host: fotg210-hcd: Remove unused variable 'hcc_params' Date: Mon, 6 Jul 2020 14:33:27 +0100 Message-Id: <20200706133341.476881-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093407_333114_68B0B37B X-CRM114-Status: GOOD ( 13.72 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Feng-Hsin Chiang , Po-Yu Chuang , Lee Jones , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Yuan-Hsin Chen , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The result is actually read into fotg210->caps->hcc_params. No need to popuate an unused varible with the unchecked return value from fotg210_readl(). Fixes the following W=1 kernel build warning(s): drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’: drivers/usb/host/fotg210-hcd.c:5013:6: warning: variable ‘hcc_params’ set but not used [-Wunused-but-set-variable] 5013 | u32 hcc_params; | ^~~~~~~~~~ Cc: Yuan-Hsin Chen Cc: Feng-Hsin Chiang Cc: Po-Yu Chuang Signed-off-by: Lee Jones --- drivers/usb/host/fotg210-hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index f967adf2d8dfc..51dbbb0e768bc 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb/host/fotg210-hcd.c @@ -5010,7 +5010,6 @@ static int fotg210_run(struct usb_hcd *hcd) { struct fotg210_hcd *fotg210 = hcd_to_fotg210(hcd); u32 temp; - u32 hcc_params; hcd->uses_new_polling = 1; @@ -5033,7 +5032,7 @@ static int fotg210_run(struct usb_hcd *hcd) * Scsi_Host.highmem_io, and so forth. It's readonly to all * host side drivers though. */ - hcc_params = fotg210_readl(fotg210, &fotg210->caps->hcc_params); + fotg210_readl(fotg210, &fotg210->caps->hcc_params); /* * Philips, Intel, and maybe others need CMD_RUN before the From patchwork Mon Jul 6 13:33:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645889 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A8D9B60D for ; Mon, 6 Jul 2020 13:40:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7ED1420702 for ; Mon, 6 Jul 2020 13:40:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dkVc5A86"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zWvdvBnN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ED1420702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PHqqlzRo1XR+mH3DX3YSuZAv0Wxk1ojQC7nc4laHQIM=; b=dkVc5A86tk/cTOYIolW9CZ40/ XPVlEaIXwv8Q8r6v4fG56pLDbgzZU3sWcWbWOVqt/rmIkblYt4BCEIGnwb/OrIMZZRqEqu6ghub6e MhEj8vFXk1NuX5oOtvzHnrqxVdZKKV0/YkCDCgfSMZQ3auwy4YqCI1BCVeluFiYw+VixbKrJGZJqA KL0qEwSQPAUEat0lumE4M+GcbUGACfhXWbDcs2mmDQv1jU2kRoyxGvifnkLc0oDMpjr8zljVW73DI sTIaa2EDDomSyoa/LUM2lnUDi+wcR5Qpc7nckiZ4MqAV3OZcIFN4D0tU3io7yQQXokmGs3N+4ouyy 6QVD39v9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRJU-0001zO-NL; Mon, 06 Jul 2020 13:37:40 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG4-0008Hr-C6 for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:13 +0000 Received: by mail-wm1-x344.google.com with SMTP id q15so39371185wmj.2 for ; Mon, 06 Jul 2020 06:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d5p91PYLOlGL5eAhTI+TgOkI4utTlM6UStiViuCSA4I=; b=zWvdvBnN7uGI3YJYG8xAKLYiRJh1mm0+0r6YAQ/ht+c+2n5/aaoZ24CrC6+hTOq75q UZgksZ/ftaNvfFjflqPGT6LMkwCqQ9dhF/YRFHAvqu+DdxqoYp7Ex3s1nB1x0kw/i8Wy 2EWBhwE38eGBFN2TO5wcJ4Q22ru3uU3QZ8WgSOUDl0W5yggF2tD93sA22eOBatapWahz hIdy7n8K4yNPhE7VlJWZ1XdjDn1HYu1O7Ot1DZPO9MIdEvoyXtF65q5zuvF5LY1rfRHI zO4HmtSixQQmvk/yfC0Oeo3PAQMsM6lPTWYiYiuQvARvCD45XF9IVh8ATkXIOd6W0kfn nG5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d5p91PYLOlGL5eAhTI+TgOkI4utTlM6UStiViuCSA4I=; b=TE13jUdCjCj22fz5JJnWeAIfZjf3I9G3lPD/OKuo2kEa8V9/mm0GDa4f5UmvFLBx4P p6RQNwsgo2fL+PxlgfQ1GtO7A5s76FP0hsQ2TFMBtEwrzK6TY82biqGKgUReQmmS3Pww 0KpZ9nUQ1l8gZFhbaqLPTZ402PxLzbb0BM6++MZUcawKayIC/F079HUhxbLZjYfKazSK Etbz0XU/Dqy/Bx3XeaLdUUhbriP19x3zm/LN23zwWett+nN7aP3+N6nsxqN2q+W7R+q6 bn+7+RkI5Ag6155WDfw7sme19ftg8pKDvirbmiPFk5DD6erbLi0uudYFfcqZDOdl3TBu xaKQ== X-Gm-Message-State: AOAM531xJacbSK/jeSTW27xYxtCL8IYzQfz857e/ry9jPTT8r4etzYjR AGDTdxDLW44h9PWd2ZVwtQvcbQ== X-Google-Smtp-Source: ABdhPJweO4LHH0YuesEFBL8qRBzNi8brrKp2TuduBLyEDI7/Vj9+MgTEjdpThiWYval39YIjbESx5Q== X-Received: by 2002:a1c:8117:: with SMTP id c23mr47262716wmd.157.1594042447424; Mon, 06 Jul 2020 06:34:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:06 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 19/32] usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:28 +0100 Message-Id: <20200706133341.476881-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093408_512622_B365C811 X-CRM114-Status: GOOD ( 11.33 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Bryan Wu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'i' not described in 'snd_interval_refine_set' drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'val' not described in 'snd_interval_refine_set' drivers/usb/gadget/function/u_uac1_legacy.c:93: warning: Function parameter or member 'snd' not described in 'playback_default_hw_params' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'card' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'buf' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'count' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:197: warning: Function parameter or member 'card' not described in 'gaudio_open_snd_dev' drivers/usb/gadget/function/u_uac1_legacy.c:257: warning: Function parameter or member 'gau' not described in 'gaudio_close_snd_dev' drivers/usb/gadget/function/u_uac1_legacy.c:286: warning: Function parameter or member 'card' not described in 'gaudio_setup' drivers/usb/gadget/function/u_uac1_legacy.c:303: warning: Function parameter or member 'the_card' not described in 'gaudio_cleanup' Cc: Felipe Balbi Cc: Bryan Wu Signed-off-by: Lee Jones --- drivers/usb/gadget/function/u_uac1_legacy.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/u_uac1_legacy.c b/drivers/usb/gadget/function/u_uac1_legacy.c index 5393e5c37a4ba..60ae8b2d3f6a2 100644 --- a/drivers/usb/gadget/function/u_uac1_legacy.c +++ b/drivers/usb/gadget/function/u_uac1_legacy.c @@ -23,7 +23,7 @@ /*-------------------------------------------------------------------------*/ -/** +/* * Some ALSA internal helper functions */ static int snd_interval_refine_set(struct snd_interval *i, unsigned int val) @@ -86,7 +86,7 @@ static int _snd_pcm_hw_param_set(struct snd_pcm_hw_params *params, } /*-------------------------------------------------------------------------*/ -/** +/* * Set default hardware params */ static int playback_default_hw_params(struct gaudio_snd_dev *snd) @@ -146,7 +146,7 @@ static int playback_default_hw_params(struct gaudio_snd_dev *snd) return 0; } -/** +/* * Playback audio buffer data by ALSA PCM device */ size_t u_audio_playback(struct gaudio *card, void *buf, size_t count) @@ -189,7 +189,7 @@ int u_audio_get_playback_rate(struct gaudio *card) return card->playback.rate; } -/** +/* * Open ALSA PCM and control device files * Initial the PCM or control device */ @@ -250,7 +250,7 @@ static int gaudio_open_snd_dev(struct gaudio *card) return 0; } -/** +/* * Close ALSA PCM and control device files */ static int gaudio_close_snd_dev(struct gaudio *gau) @@ -275,7 +275,7 @@ static int gaudio_close_snd_dev(struct gaudio *gau) return 0; } -/** +/* * gaudio_setup - setup ALSA interface and preparing for USB transfer * * This sets up PCM, mixer or MIDI ALSA devices fore USB gadget using. @@ -294,7 +294,7 @@ int gaudio_setup(struct gaudio *card) } -/** +/* * gaudio_cleanup - remove ALSA device interface * * This is called to free all resources allocated by @gaudio_setup(). From patchwork Mon Jul 6 13:33:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645885 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1DC7060D for ; Mon, 6 Jul 2020 13:39:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB2B220702 for ; Mon, 6 Jul 2020 13:39:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mjU3Drlq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w6hRYUO7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB2B220702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Li9SIQz9dzEgdzOckyFqLMM3X/IeSbv8e64i88AT3ow=; b=mjU3DrlqUk4fUAC1yHnTZLuuE VWJOfc7Z67NJyIXyjrG9EW5EZbxoNXUgm1Jrd2A/dZervT7jYZ1OsvHKDKqJvEwEwasF7pLpe58X6 ia0B5Eo+7iFL56HUgWFCxWBDq9+DLc8lH6NYrYftny+30HHit1r+hnxj/Q8AyR8pPPeAPWLvAOWQp bLXk0cu2ITZEPriLd/UJvPu6H/2UR5A7mVlRVYJO7Y2q/jnRVU6K/t34aB/OvsybgRGfmv9DKyPP3 Wb4QEw0azzpLt2LS/60PXBaNFFM8FXUFv/XycQf7xHXn/vXghVPxiwVVL3EfD1oXYCO8TluD01sBU B8iA7U+yw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRIy-0001fa-0f; Mon, 06 Jul 2020 13:37:08 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG5-0008IN-Jq for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:13 +0000 Received: by mail-wm1-x344.google.com with SMTP id 22so39377409wmg.1 for ; Mon, 06 Jul 2020 06:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=atQQd6B48grrwp+3FZv95LUICx56wwJRa1SpQXxMQxY=; b=w6hRYUO7YyVcZnrxkVQcL9i+DIcegwSxOpJpusHM7ek+/DIU5QwFI/PAYc6YFHkaCT k8FRF534bpubL0B0OmFF5oq6wY03Rw6yEomh35Tmx6FPDE/waGSczpU5Cgzrn5Uju7Cc bCaXLGQifZRD/R4nbrn64owZsuCBcCb1EC0ImDhAGAXd/cc+WlULEQCijrABf+IpaKDT 3EKntJe03seySO6FPX3ZDocV61TFxZ1D1a4x8qhefwdg2zdjfgFY86PiagDVLamwPJy8 Cryz85XcxwCCMuv2nwLw+AXH9YXajlbSNY8nVxl/zMp1+gxb+292tL9mvtsS+CABRwnw YPYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=atQQd6B48grrwp+3FZv95LUICx56wwJRa1SpQXxMQxY=; b=Tv8UqKYkq+U7JGcudXGHlIz5VD03B/EZuMQyKBcP5oi9gcKlhiLxNirYL7gP+dBxM0 Pi7oOV1hFvaXsuaAhju4KtXrBRHH+Y0rJLcujpxI/WXzYj9SWer4zSNNZy/99/ZN0RmS qzleyazgiS9u6NwpyuEZOj2GLAD5A5KCntaG9yhPACXKXBb9YKCZMGHbEuzFtjZdNpnt kzJMu1r2eh5QxmXZsT8w+P6gfHswQoXToYMWgWl5fv4OoyuKGjxffhqPl+ZKkD8puGbQ mX4gDUTanvNdWqZj9am69mv1gRuw+7q2VwTYlTp1qWde7B5lHbkTAis/DmCnOkGT6xPv cLoA== X-Gm-Message-State: AOAM532BfUxab5GWCJ2HU4XrEW/OAXoNvxdPNQaSPEMWZ9kJQadUQX2Q j+ZbEte9jENcxnQnfze+BjNVGw== X-Google-Smtp-Source: ABdhPJwn3KSyjv54N4scU2QXm9bSuHZxzD4jVab9Us5MgbW3y2o+Nt2CodWPVpAjqv1powTZgDaF9Q== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr2416931wmh.121.1594042448527; Mon, 06 Jul 2020 06:34:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:07 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 20/32] usb: host: bcma-hcd: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:29 +0100 Message-Id: <20200706133341.476881-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093409_777116_9768E9E7 X-CRM114-Status: GOOD ( 13.07 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felix Fietkau , Hauke Mehrtens , linux-usb@vger.kernel.org, Chuhong Yuan , linux-kernel@vger.kernel.org, Michael Buesch , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/host/bcma-hcd.c:180: warning: Function parameter or member 'usb_dev' not described in 'bcma_hcd_usb20_old_arm_init' drivers/usb/host/bcma-hcd.c:268: warning: Function parameter or member 'bcma_hcd' not described in 'bcma_hcd_usb20_ns_init' Cc: Chuhong Yuan Cc: Hauke Mehrtens Cc: Felix Fietkau Cc: Michael Buesch Signed-off-by: Lee Jones --- drivers/usb/host/bcma-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/bcma-hcd.c b/drivers/usb/host/bcma-hcd.c index 652fa29beb273..b1b777f33521e 100644 --- a/drivers/usb/host/bcma-hcd.c +++ b/drivers/usb/host/bcma-hcd.c @@ -168,7 +168,7 @@ static void bcma_hcd_init_chip_mips(struct bcma_device *dev) } } -/** +/* * bcma_hcd_usb20_old_arm_init - Initialize old USB 2.0 controller on ARM * * Old USB 2.0 core is identified as BCMA_CORE_USB20_HOST and was introduced @@ -261,7 +261,7 @@ static void bcma_hcd_usb20_ns_init_hc(struct bcma_device *dev) usleep_range(1000, 2000); } -/** +/* * bcma_hcd_usb20_ns_init - Initialize Northstar USB 2.0 controller */ static int bcma_hcd_usb20_ns_init(struct bcma_hcd_device *bcma_hcd) From patchwork Mon Jul 6 13:33:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645887 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3810992A for ; Mon, 6 Jul 2020 13:39:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1DC4206F5 for ; Mon, 6 Jul 2020 13:39:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fuc8yv6y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nrBdfUXO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1DC4206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9WbOscSW+uaPuBDDTxRI09+QrBUNdmODcdY60cNnUk4=; b=Fuc8yv6yGX/e68+wBLGRuTUBj G6eezOqeEyiEU1rtVrS8gHXCXFGUj5JQhvlpZzXR5QQp6hsjAx2gQOGyn49Xh+2URjGx01vcUo+UX VHM9hXkEAAJgT5oeBWxgnu8A7gqrMFv4YVXjBqo1wRp4eWU+3Tq84zbkGSvsq08VTKo9ftd9FKp/Z lndT/E9agXrVLHRk/ZI7xDBbnRZ2zwGD4TCD16R/plWGbwGtaXD5fEbS3TpcRV0zTm+DplPcBylFR 7Y8HY+5b3NvJ+i3OjqkjY9kx4f9dZ6GqOO6e1ySFApKvem+gfRh7d/g+LaPlAILVwZQWrYjY955QR f8cOsZjxQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRJ7-0001oH-Ti; Mon, 06 Jul 2020 13:37:17 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG6-0008JA-Lk for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:14 +0000 Received: by mail-wm1-x344.google.com with SMTP id g75so39363995wme.5 for ; Mon, 06 Jul 2020 06:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oDXPXE1ejSNiTZPmJzCEijdYryKHjxn03JTJMf6IP7Q=; b=nrBdfUXO6LY8W3UqebH3OTR13trp34J0vuEI51RUElQ285ST0V0W0G2+PO4jsv+hxc iLQUwUgSA6VUbu9JTOnHYL/gAiz0ajtk6cAXF8AMBAsmzGLH6OCX7lVStmeEtWmNOokn aqQKVBO/ffzZ9ykuNxvhdS86TyGMm4i/2UFi+wW2xNk4ccagDL0o1j90UxuPFljjkjfI ZvywJxRPhH6jSNIidaJ1ghg7Mi8s1U56J14BPT8gLE+P9e0dXdBExlvcO33c1B9NM2Ht tquR7H/k+Mz3WARXMH1/ra6tRevWfrzSNRlIwGgwDOvIVGWMlhLrf5xgRhr+0xutyrWT fg2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oDXPXE1ejSNiTZPmJzCEijdYryKHjxn03JTJMf6IP7Q=; b=LI/a2LNWbRSvjdiBM+VifXOuSWjqTS5wmo6YFtjt+jaMwE5zYCHDuGFbfp/35irh7r UV79g3X27ChL94ekx9s0YGq8zHaCQ7Tp2WxopPBCORrFxXNCfl1A3ewRjjCTQUFravfT v14zyofsv3WNtBWqf3+H3Q0xKVYHDwt2DNO/OtgLFLMPLdJf02FWMUtYAL+6gQeroq8Z Exb6DtLHrxCQcv1LRzSoY/mdjwCRz/WsWICF2jmzSysxHK4rsW2AUgVWTXHQfymv7ju+ cI7X7LNwVIQxJYMz5NUt8Hcud095Xcz+eKTojOltB4FkhDbDEoEtDkaxvM/CANJjZF/e X3Nw== X-Gm-Message-State: AOAM5329EcBvrdsML+0zlQ5cX3Epi0BQWgfPQDHwwBTidB32NCQoEtnZ d/GH1h3g3LoLnv2HvNkEgI/2FoDNzdk= X-Google-Smtp-Source: ABdhPJwIxV2zfyTQ46CXR54rzVA+3y6gCIKQuS9jzSbWYCHADjbdXTgdAvhaPHfM7G6AYqJMnSZhEw== X-Received: by 2002:a7b:cb98:: with SMTP id m24mr49126433wmi.98.1594042449766; Mon, 06 Jul 2020 06:34:09 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:09 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 21/32] usb: host: fotg210-hcd: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:30 +0100 Message-Id: <20200706133341.476881-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093410_881615_A6B69E9D X-CRM114-Status: GOOD ( 11.86 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Feng-Hsin Chiang , Po-Yu Chuang , Lee Jones , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Yuan-Hsin Chen , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Only 2 functions attempted to use kerneldoc in this massive file. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’: drivers/usb/host/fotg210-hcd.c:5013:6: warning: variable ‘hcc_params’ set but not used [-Wunused-but-set-variable] drivers/usb/host/fotg210-hcd.c:5569: warning: Function parameter or member 'pdev' not described in 'fotg210_hcd_probe' drivers/usb/host/fotg210-hcd.c:5666: warning: Function parameter or member 'pdev' not described in 'fotg210_hcd_remove' drivers/usb/host/fotg210-hcd.c:5666: warning: Excess function parameter 'dev' description in 'fotg210_hcd_remove' Cc: Yuan-Hsin Chen Cc: Feng-Hsin Chiang Cc: Po-Yu Chuang Signed-off-by: Lee Jones --- drivers/usb/host/fotg210-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index 51dbbb0e768bc..633df2e927bb3 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb/host/fotg210-hcd.c @@ -5557,7 +5557,7 @@ static void fotg210_init(struct fotg210_hcd *fotg210) iowrite32(value, &fotg210->regs->otgcsr); } -/** +/* * fotg210_hcd_probe - initialize faraday FOTG210 HCDs * * Allocates basic resources for this USB host controller, and @@ -5656,7 +5656,7 @@ static int fotg210_hcd_probe(struct platform_device *pdev) return retval; } -/** +/* * fotg210_hcd_remove - shutdown processing for EHCI HCDs * @dev: USB Host Controller being removed * From patchwork Mon Jul 6 13:33:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645891 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6515560D for ; Mon, 6 Jul 2020 13:40:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF70A20702 for ; Mon, 6 Jul 2020 13:40:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rlJNF5IG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VcXzc+ei" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF70A20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r8YJ0XcW7MscA9r4Edd4RMw0t+qLFk8/FBAuJswePz0=; b=rlJNF5IGlPXWCsH9vWRqu1tg3 e4CxZoiXPaYLJ+8DZyt19SK+xAhD8Zm22mbOEcyEump6stxoNiMa9Kzpg1e7w+V9jT224o+ykxC6K ObDYoStwrwwH6PlvaN6qwsqgBdViHkpYhYDSckQDYkHfvGNLTgozHA5ZGB+6Rn6VyQlPuxPBCgXT0 Kynr0W0P58bAnNwjK90UfkXLmMtea4BF6Quc0ifU70EFsZRS72JoO7ui98O+CddJ0N9/1f3/T0Cde GLO/ovg+cwmm22KXDFUHyw1VpbOBNUj1wP6tEu4Xtl1ykx78+0kL2TtX5W+6jE9bqPOJ5+bW/W4mh g4CoMUFeQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRJo-0002Fu-09; Mon, 06 Jul 2020 13:38:00 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG7-0008Jm-UN for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:15 +0000 Received: by mail-wr1-x444.google.com with SMTP id q5so40922050wru.6 for ; Mon, 06 Jul 2020 06:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OciwYyOFlkXAJUScx7SVNAsT2ixoj+EcNyfWn6Xsafg=; b=VcXzc+ei6oAKh0w9DGfsZ7yETc5sXN+3CKC6KObuvLUoH3M6ejWS+WNh038+jerj1h KI4cAa0tpwKF8qImVnIfbBVmuIpuZXmutsi83s3amfRemr24wtyYXdFrVYFykResp+mG qSAP9l84fi+Dt0Fnu3Cb2A14nb4o0z0JBuqtUyrjUfF6KCeBfoBEAO5gWLv/tqgaBMBI YLCG0Yb6MCy94d4x5KSxVAJ+aVCnKF9vdxqfslNV7uGTtNVTyuugED/g2wBXF3lcN4ep 1swxoIWib4nm7mySMmzgcmGIskZ388OV4ojyM0vWXISGi3/m8ZetblrkAo0WynFU/xn3 tkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OciwYyOFlkXAJUScx7SVNAsT2ixoj+EcNyfWn6Xsafg=; b=PZpX4Qkp88Fx6CBqXeD01BtwVsIKbh9ExZGqh+rAC+CO/5mQVEPvHimTa79C/56A60 IHQrngcQs7BVMaJ4uL6RzDsNnm8+YC/RIRvvo/atFl9ktVm+dE+cCmBj+3A46eoJlJng 2mDhMs3lXofuYChe6XuA2v18R349bOUcvGmlZ09eWNf9VDsvi9b31lyfbm3kkT8SaJj2 Rosin3CWnshOt5FaepPMP9ypGxOnUOCcjHxCNlKFRAPNVU2izeE3oXRQqRlndVpp7Ptf jn9khIY6zHGl1STU7uyyWN2GBV0c6oE0HaGB3mxtYkMtnPi7fxyanJeHUOj11vv+Pd5b VJGw== X-Gm-Message-State: AOAM532cbx42snRrlg0CHGizjmWfuliddH3z10dgICo7guAorDHAz/Av fdRcytZr3zgE2xxEZqwX3zrVFQ== X-Google-Smtp-Source: ABdhPJwafQcWQ5lx2OMY4PDcOm8GgrMZIhHBn7VBMVREZs6ut8V4qlC9AB2XOFs67IvmSh8lOCpxuQ== X-Received: by 2002:adf:e44c:: with SMTP id t12mr21898286wrm.103.1594042450943; Mon, 06 Jul 2020 06:34:10 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:10 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 22/32] usb: gadget: udc: mv_u3d_core: Remove unused static const 'driver_desc' Date: Mon, 6 Jul 2020 14:33:31 +0100 Message-Id: <20200706133341.476881-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093412_090735_204A51F0 X-CRM114-Status: GOOD ( 11.78 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Jason Yan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Xu , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks like it's never been used. Driver was mainlined in 2014. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/mv_u3d_core.c:35:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=] 35 | static const char driver_desc[] = DRIVER_DESC; | ^~~~~~~~~~~ Cc: Felipe Balbi Cc: Jason Yan Cc: Yu Xu Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/mv_u3d_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c index 5bb0568b934e1..5486f5a708681 100644 --- a/drivers/usb/gadget/udc/mv_u3d_core.c +++ b/drivers/usb/gadget/udc/mv_u3d_core.c @@ -32,7 +32,6 @@ #define DRIVER_DESC "Marvell PXA USB3.0 Device Controller driver" static const char driver_name[] = "mv_u3d"; -static const char driver_desc[] = DRIVER_DESC; static void mv_u3d_nuke(struct mv_u3d_ep *ep, int status); static void mv_u3d_stop_activity(struct mv_u3d *u3d, From patchwork Mon Jul 6 13:33:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645895 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1547460D for ; Mon, 6 Jul 2020 13:41:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4E0A206F5 for ; Mon, 6 Jul 2020 13:41:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ne46kQBH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xDhKb4d1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4E0A206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=spyirFgNvYuHXnk8iiAC//r2Qvc/0yy7DMZT8orcGc4=; b=Ne46kQBHj38z6eLwhJICnGHV7 R4RTliGwG5Upv1xN4ZcaYnPTSeNBkAgm6GjsBCunRm2zgEUO2gcgEapjNlwkrJ+MTUHBq4Jqohf9r pTiQfCFJTcN3FmXdAAKS7IigbYt8immPkyt3fRkIztq0hEm4UyR6fuTfBXJ98aUfbsJ/GNRYskMD1 PhwZAGaQciUu1XoTlMr00PjRuOgeWw150+D8pGTJ9T6i3A5Sanr51BI3MAPLYOlyijff7z1hBTZi6 BLwFxaHEFyK8ZPB6MxBEgW23M9VuCGYJNVQEHcvA5Ncll0sh3jjw2NxZ8h14q45X3jlGUskDTr0as MHZPZvvnQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRKD-0002bM-Va; Mon, 06 Jul 2020 13:38:26 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG9-0008KP-4k for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:17 +0000 Received: by mail-wm1-x341.google.com with SMTP id g75so39364146wme.5 for ; Mon, 06 Jul 2020 06:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=xDhKb4d1kq4g63PE6Kw+d0pJTKLnw/IIJQRWCvGGBRKLAySHr3nXCYdnP0FF+KYdgl vilMW0c0k6s1Ego/Dne9r8otV3SFOpks3w1DdJX6EPTI97pwdrKlIb2UKkbKdM3aDVlj oSrJ9yzAacAEyGyCdl7WGdOS1ZgDlhAHAlm1LeHkd9CpJeixRsVwXY0hZ/8oKIB1aA7R tQf8xNsPpdj7GOKICfWv8NpWcwtVpUjJFXZFlcmBUynkOisE2Sqp7YJSGA42CjzUdB7j d48tqL2Z+IA4acMLvxU18EamPKiWgdTtUL2LpLPFNEyrurJ1mT7m8OpdBkl5rzIdpn3b 0snA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=Vt5v2K583/cQ9arBK+rsPiNQmlu5WJ2YUCVjs5GMAqvR7bmePKlHGNFwGOZcWMHyVe 6bkAhdAcJpb7rsAPWjdYNxMQXrgWKY5WdRYe03YuQEHC39LMUG0KeBBq6DwHRii6QdqN VlFHIRA7gQ16HMgybgkju5L0JML/0TKhEcjb6nTTeQplaXE7+wEWYwzhdeUPCLlHu2oo oIe0OYp9YmsVBuyMVh3Fk8fXp7UTg5Oum+JasFXXy7LnqKtvUb90jZllZLeNNkHc93aE VhS37OZLlk81vcWwPgk8rehvMojTV9N/JVrZO+aoDVQNPjVfCJbPX+erNKVFmK5E4pCs Dpzw== X-Gm-Message-State: AOAM530DXAh75+gNtpM0uj8YCdaVXFI0darUbknL4LJhGhE3LTSveum2 H9kEAiwGQ1tfyOL71lCU1KtVdw== X-Google-Smtp-Source: ABdhPJz+ya1juxEYdu8hRa5da9rRY9b7wU9z75P/hBna1EEO/zxK6KolWddZ+pI9eP30hH8G324USg== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51112738wma.4.1594042452163; Mon, 06 Jul 2020 06:34:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:11 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr' Date: Mon, 6 Jul 2020 14:33:32 +0100 Message-Id: <20200706133341.476881-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093414_703627_C546E0C9 X-CRM114-Status: GOOD ( 13.23 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jassi Brar , Christophe JAILLET , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/max3420_udc.c: In function ‘max3420_handle_setup’: drivers/usb/gadget/udc/max3420_udc.c:626:5: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable] 626 | u8 addr; | ^~~~ Cc: Felipe Balbi Cc: Jassi Brar Cc: Christophe JAILLET Signed-off-by: Lee Jones Acked-by: Jassi Brar --- drivers/usb/gadget/udc/max3420_udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/max3420_udc.c b/drivers/usb/gadget/udc/max3420_udc.c index 23f33946d80c4..52884bae4af11 100644 --- a/drivers/usb/gadget/udc/max3420_udc.c +++ b/drivers/usb/gadget/udc/max3420_udc.c @@ -623,7 +623,6 @@ static void max3420_set_clear_feature(struct max3420_udc *udc) static void max3420_handle_setup(struct max3420_udc *udc) { struct usb_ctrlrequest setup; - u8 addr; spi_rd_buf(udc, MAX3420_REG_SUDFIFO, (void *)&setup, 8); @@ -647,7 +646,7 @@ static void max3420_handle_setup(struct max3420_udc *udc) USB_TYPE_STANDARD | USB_RECIP_DEVICE)) { break; } - addr = spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); + spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); dev_dbg(udc->dev, "Assigned Address=%d\n", udc->setup.wValue); return; case USB_REQ_CLEAR_FEATURE: From patchwork Mon Jul 6 13:33:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645897 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 639B592A for ; Mon, 6 Jul 2020 13:41:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13E4E20702 for ; Mon, 6 Jul 2020 13:41:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jhBVoydK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Fw8KkupQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13E4E20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O/2DXr/JsP1GxY8uHXhJEeWUaIM6dTeKDUBRcrBmGA4=; b=jhBVoydKlAwI67BJDKM0W47vU MxPhs3LW6scxRK6H2iVhODQnB6U7EaZMd2f6kyjENCiTh8se+AbOzobnrQ6y7iaDesOMBBLaa07q+ UjxwJj+z37Bp73XKC/D8QKJniWJBqNoYKgxln+QGiTl3wb7s8vPJQZVZjikP3IN+ZcqyeFXuEnERh pb74BuzVm+m/KPOd8TXsI5US/03UCnAyu/87uzgmNpn3d3vbHBaSDZ52nFw1F6uePxkZwIQWF+CRB u/fcnLkTlQ4T9tMtO1W6tEWX1peHLAbJKUUrQlwbDjuj3ETfC+vR4KEi18LMT/8atqSyhM8TlmjCG mjAyj/1Fg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRKg-0002pZ-8t; Mon, 06 Jul 2020 13:38:55 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGA-0008Kd-5U for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:17 +0000 Received: by mail-wm1-x342.google.com with SMTP id w3so29668449wmi.4 for ; Mon, 06 Jul 2020 06:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wF0TEpLE3+8aSfCpSueulEs3qt7dUTbs4ZXmnn02trY=; b=Fw8KkupQWP1sjuNARANgDth/I4E8Dw60dO13hOJ8P5eNzx1H61J9+oaoJEz4UW+eLB x1QdMZF9StP7c7hyy5JUC2MkPAqAt8qlfDb0usPVJ896zJWoOIBxIxiB9t3WJWOp41wc QWQfUyGB9r0pZlKQ/l7gJrP8c9Azan7WlFLNpgl++8vrM1xNTg4t8bQ7iLn1cUPL5RBW AG42p5PbmHJ8Frm71710QTtIrNhkU5qAvSTsYC97K1PrCm5ql9h7VGbzShVHn/cTrI73 fL7PPdPg+3dvqO2vSDnwUP0ahpRMP1oWeMlfwjY87k/1h79BGuI02uv9lh8MDmd3wbOb XMdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wF0TEpLE3+8aSfCpSueulEs3qt7dUTbs4ZXmnn02trY=; b=fOdgnPCVryxKIyR1+HUOhHAVXsMz4wuOQsPWxMPATymcRWCGYCpMwoJ6XLYBq0yRX5 gKOlcD+4HyuCWIQJXKn7Ofoj8yy/U7KXHJWGZhl/8IQ/Lavufqcoc8H7WcsB9OPqHkLm ktSbQ2lNWZif75/94PehOxiY2XM0lX7s64LkcPEhNueMDDWQj0XxMElRKDu6aHzTLO2J PXcEeweLzKtBwyv+QFhjUcfF1a+Fm8OPgOhbslyluCOFvBeALLKzGCyA3kwgiaU9qGoT tVqNtxfpGhx03szmzmgG4Bb71u78LJGckYizG18cG+gWk9/+T8R84gnOBs5g+oFGyW/n d+iQ== X-Gm-Message-State: AOAM531dSiEnctidDjQG4yPHfM6vs2rllIcXBKpbJCmX3DuaHbl1HlLP DpmD63xwRoJxRU6M1rxIoNj8WQ== X-Google-Smtp-Source: ABdhPJxHHFnEPojgYRMIoE3DnTDn2rSpOXSQ2WwvPUtq97j/0sE7IvNfbZmEFXNMp63VwfwkukEpMg== X-Received: by 2002:a1c:c3c5:: with SMTP id t188mr51930563wmf.53.1594042453242; Mon, 06 Jul 2020 06:34:13 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:12 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 24/32] usb: typec: ucsi: ucsi: Staticify and stop export of ucsi_init() Date: Mon, 6 Jul 2020 14:33:33 +0100 Message-Id: <20200706133341.476881-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093414_815042_C0572520 X-CRM114-Status: GOOD ( 12.08 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , linux-usb@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org It isn't called from anywhere outside of ucsi.c. Fixes the following W=1 kernel build warning(s): drivers/usb/typec/ucsi/ucsi.c:1005:5: warning: no previous prototype for ‘ucsi_init’ [-Wmissing-prototypes] 1005 | int ucsi_init(struct ucsi *ucsi) | ^~~~~~~~~ Cc: Heikki Krogerus Signed-off-by: Lee Jones --- drivers/usb/typec/ucsi/ucsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index d0c63afaf345d..affd024190c91 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -1002,7 +1002,7 @@ static int ucsi_register_port(struct ucsi *ucsi, int index) * * Registers all ports @ucsi has and enables all notification events. */ -int ucsi_init(struct ucsi *ucsi) +static int ucsi_init(struct ucsi *ucsi) { struct ucsi_connector *con; u64 command; @@ -1078,7 +1078,6 @@ int ucsi_init(struct ucsi *ucsi) return ret; } -EXPORT_SYMBOL_GPL(ucsi_init); static void ucsi_init_work(struct work_struct *work) { From patchwork Mon Jul 6 13:33:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645893 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AFB0A60D for ; Mon, 6 Jul 2020 13:40:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 649ED206F5 for ; Mon, 6 Jul 2020 13:40:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PnYb3lkW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tDxm68x6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 649ED206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UKh0oYl1rlugqYeTagDI62ou+KJUsLQRlYyAcT1/7Ao=; b=PnYb3lkWvmxDkPx7CkWoNT9Ma 5hQHfapFsjWO1UeQK8brij1Km8gI8iHhxLQWexArcwlbbQFVLxP03laUnn8ugN+cSD2ki4bte/9cy FWUQpFvo9EaA6P71xMo6kvg+I9rnXkv9teR3DgFBHAHmxbc/FM5Z2MlZ+BEjT60Tw5K56a2KCyXvq Qvcm98wWPUziruljiAHpO+Cahuz8Nt3VwNBeulACE72I0byEcX8+5PJpXfszRp9oJbPvoGwSsr98Z RipJnoVaMsxwpV+CncQnkHEhHeu+wJHZDT2TOvi54wnyF7hNghXafln+UGf+zhRvSHKOEf9cGfgCQ 5ibvpwmHQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRK2-0002SN-Ez; Mon, 06 Jul 2020 13:38:14 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGB-0008Kw-I9 for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:17 +0000 Received: by mail-wm1-x343.google.com with SMTP id 22so39377787wmg.1 for ; Mon, 06 Jul 2020 06:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tuuvgBdpWU3P+bBrTu/2KsiGO4ss74gkTJhNI/l0mkY=; b=tDxm68x6EEuzSyF8zb1P7MNnLA1RLSLV7ALNXgP2jbhLbdEirodV/LE4bXzaJbsPRg SUs25JhonwmI4Zqrwaw4zG1N8CYo4lAXlnF26lpK/OFRkQCBCsW93WEi1lCMj5UWQUmj QMnuck2Ci0chN7EEaR5qWLPh9Nag2b7j1MCcb9/mrCXgV+WBZ7ijQZzXPdT8Hjg0PTNS goxdYPMOU0X2sc2aE1VXEpQk/0hLVxQjbMvmUCXhN28efa29/LuSc8kkdAhJT0CG2LUK rVz1fvRtUKDbzGwTdNfqJrgIE5j/IDqenQl2BErSZqG2pPSnQFEsUwi3TsrnXUWaGjxc gQXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tuuvgBdpWU3P+bBrTu/2KsiGO4ss74gkTJhNI/l0mkY=; b=QsBr0xlDnPrKQQE2wI+qFmGtuFnmndJitxV6eD7K4qg8HFeCC7y9njOxo4lMsa51zj IDcnGHE9rCSSIBJlNb8hHIexBU87UJtlNWNhU+9Nd3t6DAzmJsPup1rvtrjJ4vkKoW/1 hj4WX0oHZnieV/74D/AT3uDSSvXlZorPKYOINH8hp7ZMoTa7rUBP9C1mAiYDPlrAUZGH sZ27c15U3+nKdLkQZkOe2mEneU7AZZG292Djv4zzG45waty44GbUyYTnZAY7D8eq3uyl MOXiv+qpTbMOIaqwerYWDHyUxTibd2i1Ls0zVkXQwbDwm1lT+pW3BcVi7cWsfuLZemzy eIDQ== X-Gm-Message-State: AOAM532xbs6S1i2htjVj1PU8fdtJ6ly0ehtcnAWNzFXzBm1LCcPuAcSI cdxSWu/irJvicjqhek1myMn4BA== X-Google-Smtp-Source: ABdhPJzuzYNNW71b23BvSLPHgO5D0LojminjFAQt3G/egnKeifhMWhpTDqlAyYc41PSyJlYXg/HnVQ== X-Received: by 2002:a1c:49d4:: with SMTP id w203mr50012638wma.13.1594042454380; Mon, 06 Jul 2020 06:34:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:13 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' Date: Mon, 6 Jul 2020 14:33:34 +0100 Message-Id: <20200706133341.476881-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093415_806056_88C61047 X-CRM114-Status: GOOD ( 12.18 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Daniel Thompson , Petr Mladek , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson , "Eric W. Biederman" , Jason Wessel , Lee Jones , linux-arm-kernel@lists.infradead.org, Yinghai Lu Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'ret' hasn't been checked since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’: drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 915 | int chunk, ret; | ^~~ Cc: Sumit Garg Cc: Daniel Thompson Cc: Douglas Anderson Cc: Petr Mladek Cc: "Eric W. Biederman" Cc: Yinghai Lu Cc: Jason Wessel Signed-off-by: Lee Jones Acked-by: "Eric W. Biederman" --- drivers/usb/early/ehci-dbgp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c index 775cf70cfb3ed..b075dbfad730f 100644 --- a/drivers/usb/early/ehci-dbgp.c +++ b/drivers/usb/early/ehci-dbgp.c @@ -912,7 +912,7 @@ int __init early_dbgp_init(char *s) static void early_dbgp_write(struct console *con, const char *str, u32 n) { - int chunk, ret; + int chunk; char buf[DBGP_MAX_PACKET]; int use_cr = 0; u32 cmd, ctrl; @@ -951,8 +951,8 @@ static void early_dbgp_write(struct console *con, const char *str, u32 n) buf[chunk] = *str; } if (chunk > 0) { - ret = dbgp_bulk_write(USB_DEBUG_DEVNUM, - dbgp_endpoint_out, buf, chunk); + dbgp_bulk_write(USB_DEBUG_DEVNUM, + dbgp_endpoint_out, buf, chunk); } } if (unlikely(reset_run)) { From patchwork Mon Jul 6 13:33:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645901 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9B6FD60D for ; Mon, 6 Jul 2020 13:42:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59E5820702 for ; Mon, 6 Jul 2020 13:42:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HYQiax2l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w5P2aU6D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59E5820702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W20TzFQ1okw/1vLNnzmVsYELLjMU1bI1CoH4LI6Hr80=; b=HYQiax2lq906c78E07eM9ujRs HYy92QP/Z3fJSZBWGYIehEjyfcTVHbJGV9lBqiegQQ4CQE2QZBKofDP6pDJwMJSVzfBaYydhmWlLa rNefmA+LXr4mAD8NjHVYzIXtAdIHvs4twqsGO6hVntQ5CJxUB2s6+WLaXtz8ODEPTr00YYpT/lfqW 1rrM9BK9RhSN7aJizpiKoPceZft7RIHXv2c0qHkdjOmXJDp0qJkQAzGVriUnDm5ufnYYheKzsqCHB PdEn/zR02U0Io3AwOYIXUoyN7giyS8ZzgTkr6C4XrsNIWUdHLPEanShS5gM9iIqNNXr6jKGi/yPEt gMpTQrueA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRLV-0003HO-9X; Mon, 06 Jul 2020 13:39:45 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGC-0008Lz-Rs for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:19 +0000 Received: by mail-wr1-x443.google.com with SMTP id f18so32882166wrs.0 for ; Mon, 06 Jul 2020 06:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hOxuOAzmvEV55alflVuCU5810VX9tcA35muYC7R0MbA=; b=w5P2aU6Doeac9XeMuviG7stwJdgM6WsIR+NBZVf+lZt+//ND6hJ0DXWizpA/m6bvwD B2u0ApOKmiuQOBKM1YTtRRJXFMhrqsqF5Ykg3yCIhM78pF2i9vIJFL96Ve0I6gQrZww+ hipLqHTD9shzTQ0ixY1kUN5YsF9v2aMQynbFnVU+Qu+aWu0Ikiy2sbwjO0WWC78XIlyu Jukm9EtNycZtWgB8LT/DwQWNu306tPsdPdKJ6yBLniVQ1uduG5/SYh+Cis1o7XDA4U9y bpXkmFKaaIGenZXim6OybyyfkysmnYGI7GTOso3LNOgCj400PgZI42jXMSjLkXY+Bfio 7O8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hOxuOAzmvEV55alflVuCU5810VX9tcA35muYC7R0MbA=; b=IEeIBGFPpNy5RsJd2fZHZ4MJMX663TOhAaP5PcSIiJunnNzKGL4A487KOimFkUAnOq qagAhBsMBg+HYY86O7HVTBHGzsfRt4n9PXfdJSpgpYrtmKGXKGYiyS9ICOnACL49HwdA tzcZ+QiPp4ZDBnE1aI1tVsIdmPCcXt9qyFTNjSFdTto+7AfhCHkTW5M6KGHI6Dxergk+ wqjY9bFwys4H3UAhOLiAS53gSpPxCpiYRRoWDF3CJcsNK8md3cz1igtzZ++5zLYxjBtF H18a4qKWWda1mpo865upaKKhtEFPJ4pslbdrzV77pxKrS3RtlOUiVjlWKStqp77KdmPK 2j0w== X-Gm-Message-State: AOAM5324gWlqWQnKT6aNAAVid7Cm0rWdZBYSxo2SitjUCEODdN2UDoJJ 4O5y2HlPGwGRwqwv9rBt3WSjvw== X-Google-Smtp-Source: ABdhPJwQLKXTvfX4Y1+2PDutR0rJsq3ap9TgpalSECU387DommfB6/zibSUcLtGWIgZ9/g+LfFUx5A== X-Received: by 2002:adf:8024:: with SMTP id 33mr52421656wrk.117.1594042455545; Mon, 06 Jul 2020 06:34:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:14 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile Date: Mon, 6 Jul 2020 14:33:35 +0100 Message-Id: <20200706133341.476881-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093417_834759_D592722C X-CRM114-Status: GOOD ( 13.42 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jann Horn , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org, Lu Baolu Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If the header file containing a function's prototype isn't included by the sourcefile containing the associated function, the build system complains of missing prototypes. Fixes the following W=1 kernel build warning(s): drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’: drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 915 | int chunk, ret; | ^~~ drivers/usb/early/xhci-dbc.c:600:12: warning: no previous prototype for ‘early_xdbc_parse_parameter’ [-Wmissing-prototypes] 600 | int __init early_xdbc_parse_parameter(char *s) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/usb/early/xhci-dbc.c:653:12: warning: no previous prototype for ‘early_xdbc_setup_hardware’ [-Wmissing-prototypes] 653 | int __init early_xdbc_setup_hardware(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/usb/early/xhci-dbc.c:910:13: warning: no previous prototype for ‘early_xdbc_register_console’ [-Wmissing-prototypes] 910 | void __init early_xdbc_register_console(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Jann Horn Cc: Lu Baolu Signed-off-by: Lee Jones Reviewed-by: Jann Horn --- drivers/usb/early/xhci-dbc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c index 04ba11fff0edc..a9932c1ff20f7 100644 --- a/drivers/usb/early/xhci-dbc.c +++ b/drivers/usb/early/xhci-dbc.c @@ -21,6 +21,7 @@ #include #include #include +#include #include "../host/xhci.h" #include "xhci-dbc.h" From patchwork Mon Jul 6 13:33:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645903 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A8B4392A for ; Mon, 6 Jul 2020 13:42:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DD8C20702 for ; Mon, 6 Jul 2020 13:42:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rS+u1ezm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e7KtGYdj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DD8C20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YtOJMPUEkAfYnHTMDJZqwnxtnh2LAEgrT71PzEeP7YM=; b=rS+u1ezmVJpTbTONWaRNyB+AD KBD2eiVeNLaOCx2GbzLnF1oSzs8IZrhoHy/dOzg6TbcH0ccvQetoyDpi5i21sivTOuHw2rQCtbIZi CMR5tagEERF1e0HTjV95N8z6psMqRbfBOctSsBIbFcPpFQ+CPPnNx7DtqoIjH4GZ5ZWIEfd/JqMYq FXXYGKXWSiFdHHnp4XE3aC//R3hLEBP0ayEFLlMRLFcZd/CaMqsOruMCCu1EidwAK8SAnu/P/xIgc LcxXp9iGOby2LYT+IP9lE4wNk7DvDlrP8idMCtNmWJsAQDKbJJ1/qLOTdFaqlXe0/yO+ySFe1s3Js JYyST2jsQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRM2-0003XH-5r; Mon, 06 Jul 2020 13:40:18 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGE-0008MG-5r for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:19 +0000 Received: by mail-wm1-x341.google.com with SMTP id f18so42150201wml.3 for ; Mon, 06 Jul 2020 06:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nPVZRZLDqwpPhO4RC/GUsbLkf95aQVfMZw3d44goLsA=; b=e7KtGYdjynUM1W1lVC4D+RIRR4fBD8poghJ6q+calXuw04pQafBm+5FCXwnEGJDTjX BDzvFqtTHsd9hwMREut6OdZzkcQHEC0l2dZjb9VdPRyWH2aZ5LABMONQ2vCB9wK9tp1E zEM6m4tqjYBKq8REuplcACGfj3pwaKAES50KYRAyjwak7AC03Z7nKSoYgGR4tClPuoiM +CxlNKfmQVhp8aKa3Hs4YubZpnJHKn5GFtivVZFBW6CY5w0GlhBeXoh2rigyRtBmRuKn ZF7+SX/Ys14HAbuDA36aa4fev+VbZ5zLdYDDq0g5UecpKwPDPbJBaNBfdLa8wx3hwrnU bMsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nPVZRZLDqwpPhO4RC/GUsbLkf95aQVfMZw3d44goLsA=; b=qggdTqFXp1ZFyGs6DV+5+OHmNzQWVoymriJeH0cKujpGkM1APQPOTTm8OB650tscS+ /lTSgXovq6d0iG0ZCdJFhQubtplW5YwHjHG841QnFylCLQwhAzAj32hCLf5BeEgQ0urD /lJyhv0xs+hDsjQoTTdgBwEBoSnCqHfg7XTtFBItdtbFzVNNHoiGZH41dQUlMSrOOcwq X6sTpvrtRlZgzGh0Kfum67bXa1OYunBcJfX/sOoDriMqb+gxtImyxwgKzFknPuvheoqa GreoMyGTALit2KJ40Bcwm8gl0Z446y3NYX1pdqHidvlHtDaNgiW27rIszjQS0IrWm8zd Mkhw== X-Gm-Message-State: AOAM531doK/uMsmScD4yEzqc3LuppYIS8DboeSZwAIOoruoDlhimIt/0 A/afuw770VCfN4ODOys5IF/HvA== X-Google-Smtp-Source: ABdhPJyAcv25bdv6OoMfwgsx5XUgRwu6m6klXGx12+TUQBLMsDvexy8Kv11aX3pyM5ps2Xh49QyLrw== X-Received: by 2002:a7b:c013:: with SMTP id c19mr48983261wmb.158.1594042456784; Mon, 06 Jul 2020 06:34:16 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:16 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 27/32] usb: early: xhci-dbc: File headers are not good candidates for kerneldoc Date: Mon, 6 Jul 2020 14:33:36 +0100 Message-Id: <20200706133341.476881-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093418_332947_BD251102 X-CRM114-Status: GOOD ( 12.40 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lu Baolu Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Demote xhci-dbc's file header to a standard comment block. Fixes the following W=1 kernel build warning(s): drivers/usb/early/xhci-dbc.c:10: warning: Function parameter or member 'fmt' not described in 'pr_fmt' Cc: Lu Baolu Signed-off-by: Lee Jones --- drivers/usb/early/xhci-dbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c index a9932c1ff20f7..c0507767a8e34 100644 --- a/drivers/usb/early/xhci-dbc.c +++ b/drivers/usb/early/xhci-dbc.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * xhci-dbc.c - xHCI debug capability early driver * * Copyright (C) 2016 Intel Corporation From patchwork Mon Jul 6 13:33:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645905 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 166C192A for ; Mon, 6 Jul 2020 13:43:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B542B20702 for ; Mon, 6 Jul 2020 13:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hzLpuR9U"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FiUwhiwO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B542B20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7Ot3yRzW5BU9f6EEK+mMOCNCJzoc5BfAUSFU1n6AX5w=; b=hzLpuR9Us19UAsQyPGKP2xkX1 tVRelmymesnM119l9n4o9BcGAYaU80Ukji71KhsXfTs+bKWRfpYlp3TpkogdlPIhURC/7QV7p7uI+ uessVX+n0lGR1OokaPh+plIVxryR7P49pxunwDiF8Qov7SMdXsxr5ZtVzk5WxNTv24ua5O5YiarW0 XshFJ2BL0FHlOTAfEAs/41WQEutBxcQaRoT4acn9QS+p8Oxc4prDyONzaMwP6bnq0pUeVDB61NUVN R73JvyEycHE6dR9TeMHXUhodl4VydlqKmgqAv/XjrDHCARPsEs1TE40RmmcoB52X2GVyoZO1A8yb/ KCE2EDw2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRMZ-0003lK-Pp; Mon, 06 Jul 2020 13:40:52 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGF-0008N4-DM for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:21 +0000 Received: by mail-wr1-x441.google.com with SMTP id z2so18682305wrp.2 for ; Mon, 06 Jul 2020 06:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mWltuWttrG3KiDQZY2idnG8bvke04NKb60bkJdZCmM8=; b=FiUwhiwORfJUq6xcQw08ePbp4jFq9zkCsBOJbY5wttUElOMB2DgHr2Ko3zvst7bvYB Ui9P6o+mRZcelsc5C9tXcPKLLoFC/iS6qar8Ip5fBxVFMZRZJVsSsyS5ef/QT9kTop8z UGOpptvK9HXjs+3AGo+o6Ivd4xWy7PRMnw7Zkoe+bSm8NQQJFGxdnxnaHaktnGlOtkIN yfyBY5qfjjE8G+G03wwUI6G05iBnT19J8s7Ok43KhKvri0eGH7E8GHp4zy+syeBHiNS0 n72Yictau5/AGSpOoyLakFPr6cSNAGIFJ5miYw5mNg249KRRQV1WtpJcuWU6y6G34G+9 pVRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mWltuWttrG3KiDQZY2idnG8bvke04NKb60bkJdZCmM8=; b=UhJ1fTie8z9tpRjiP+vYPHNqQNjvGiBYV+X8A2LUT7hYxRoAKPeap9yN3RrG+lgMWF gSMp1GAvmKMRZOAFZ5f6Tcxgc90gjcv6DNkOiO7XyHBeu4mJ95uJ5aqpkzZJwFJ+1tyJ HgPpuU1DpmH0gK34cz0XEPBvbXqtRfVuFduRNN3U5KBYvmfIam7HpGi8maoCYfSDEMKC L6U0w3Nk65df69DIdTlO3RUBh/CdKlHJPGAJ/jHh42qbM59DkJIz4kRJURaP/8DgewwV xuLuwWTgqQuB0+KwIYoty4XFclz7aHQCBx8SYq9qizD4i2/O6QiFPspvBaF6qnyerU5W 53sQ== X-Gm-Message-State: AOAM531gGKNh0Q00s3MWx95oF7YK53wz7t3HBIJtGhLdzB0CJZydxfRS rNrsTKDrT0gWCm9TZIHQHv7vXA== X-Google-Smtp-Source: ABdhPJz2SSPMu/jcrYODKBmxh4uV8oCWzAS1ZBr1rHvKRDtTIyhN/9NwzeNIP28/M6BupUGAaPu+pg== X-Received: by 2002:a05:6000:1290:: with SMTP id f16mr21627350wrx.66.1594042458073; Mon, 06 Jul 2020 06:34:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:17 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 28/32] usb: host: ehci-platform: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Mon, 6 Jul 2020 14:33:37 +0100 Message-Id: <20200706133341.476881-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093419_674072_1293A41D X-CRM114-Status: GOOD ( 14.03 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Buesch , Hauke Mehrtens , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Prisk , de Goede , Alan Stern , Steven Brown , Philipp Zabel , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct ehci_acpi_match becomes defined by unused. Fixes the following W=1 kernel build warning(s): drivers/usb/host/ehci-platform.c:478:36: warning: ‘ehci_acpi_match’ defined but not used [-Wunused-const-variable=] 478 | static const struct acpi_device_id ehci_acpi_match[] = { | ^~~~~~~~~~~~~~~ Cc: Tony Prisk Cc: Alan Stern Cc: Philipp Zabel Cc: Steven Brown Cc: Hauke Mehrtens Cc: de Goede Cc: Michael Buesch Signed-off-by: Lee Jones --- drivers/usb/host/ehci-platform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c index e9a49007cce4a..006c4f6188a52 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c @@ -475,11 +475,13 @@ static const struct of_device_id vt8500_ehci_ids[] = { }; MODULE_DEVICE_TABLE(of, vt8500_ehci_ids); +#ifdef CONFIG_ACPI static const struct acpi_device_id ehci_acpi_match[] = { { "PNP0D20", 0 }, /* EHCI controller without debug */ { } }; MODULE_DEVICE_TABLE(acpi, ehci_acpi_match); +#endif static const struct platform_device_id ehci_platform_table[] = { { "ehci-platform", 0 }, From patchwork Mon Jul 6 13:33:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645907 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4763192A for ; Mon, 6 Jul 2020 13:44:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D858F206F5 for ; Mon, 6 Jul 2020 13:44:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2DKpo7rw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NVlmUCpq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D858F206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MZxO2vSnR9Wi4KV5g7QhFB2aUgo6bfwcVORDkaX7TzI=; b=2DKpo7rwtIhhIofLCKgoHglON VEFefog8TCO1EGsG/9uz0wenajz8gWX0KOUUwZIBsTTJi263KwOXNMXVYTAsCiFC/nsGsnnyTt1+t qMFc+hVQk99AnhYkpT2sWEOXDIJU70W42MkmBbTbRfGtRo5q3HhA6WgFIs9svA6CeJMqMmg4a7XeF f2ZN4PcJpJJzCQcoYi8bU9hLjDK3OW/FeQojsRAIjUhIKIE9Af9PaGw6+ZgblB9HBGTFY619XFFys rTldvUGFl+X1YweQqSMlnkH06ia6GcRnpczR8NwDv9WKiyAQPS84HmraY85nJ/w63O4o4vFK6Z0X1 ujodsQ5GQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRN4-00045v-RX; Mon, 06 Jul 2020 13:41:23 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGH-0008Nx-AO for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:23 +0000 Received: by mail-wm1-x341.google.com with SMTP id q15so39372103wmj.2 for ; Mon, 06 Jul 2020 06:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JwlPz1VQoWtw/PPAMkJDslP79wmZUbGedUK151UzPVM=; b=NVlmUCpq/lKEqVs2LNex5jpihdjoioJToXMlmV7xJlur5bBqqxQQ0ZA/CPEMp/YFYN zo06ci+Iy0l18umuNeYhgFhN14h8r6U7kxH24seP3QCInrax1OBWeKQ1SE9H70pcJnMY Y+3zvLqxSlGJHUh9Rzg3ntB0br++CashYLBwH4dCl6PYtf69SG4bkCjzXWpVyre6jT7Z bs9jKtCs/nALiRvYyYsz/k1abSGU0I7VVN+9TLc1NZl+ZuCNQZNWPap0lcFqJXgO9nJp JQTT4IqiZ5ED2DtL16qAF0f01uKhcxkAIoUDFBjNrhu/dSUyHaMzolCNKJUKIkCUvEqy +HuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JwlPz1VQoWtw/PPAMkJDslP79wmZUbGedUK151UzPVM=; b=II/nNDFG87oXjzTUp8cC3UvlPhc1CwumxaiLFU1NqaQU4H5a9mrv/t5ZO43XN0nex1 J9QsZzgbn4S9w/1zk7nRcZskvN4WGRDcy5MJ4DBERWC6xXC2+dbuCzSVyuyqra9sHv1U FRyfe3tyj9DpemjpY4JW5bemYtrQGdHTAs4gRgCbFglZGNKi+X185CoiX9l0jS8EGSHr MSuSmQsMFhztwVNKFwX97nROA/A6lMqvfk1DmiWGb2gJ9S+rqzaxgxVGdkHilmQN5+gd i+69TQbFZyvf3tBYUJ42SVGFArgsNIL8zegkchdw/oXJGDXRjFdrqGfmgb6kMHkt1ORx 1apw== X-Gm-Message-State: AOAM5301ewfw1rSASdbpHI1/oEFso11Q91MwI0JhzTzPnhrcS+L9Frh0 WMWJ6Vp30bFv+wMp9HgUwkKy3A== X-Google-Smtp-Source: ABdhPJwWAM9YUcyOeIqwvk9EC4yw+4vx9TJztDtgcS6azkPjILD4VT5pv7bUKjKcnm3I1NN1jBI33A== X-Received: by 2002:a1c:e914:: with SMTP id q20mr47372571wmc.145.1594042459982; Mon, 06 Jul 2020 06:34:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:19 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 29/32] usb: dwc3: dwc3-qcom: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Mon, 6 Jul 2020 14:33:38 +0100 Message-Id: <20200706133341.476881-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093421_598920_04107710 X-CRM114-Status: GOOD ( 14.67 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Andy Gross , Philipp Zabel , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct dwc3_qcom_acpi_match becomes defined by unused. Also need to place the platform data obtained via the matching process inside the #ifdef, else that becomes unused too. Fixes the following W=1 kernel build warning(s): drivers/usb/dwc3/dwc3-qcom.c:761:36: warning: ‘dwc3_qcom_acpi_match’ defined but not used [-Wunused-const-variable=] 761 | static const struct acpi_device_id dwc3_qcom_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~ Cc: Andy Gross Cc: Bjorn Andersson Cc: Felipe Balbi Cc: Philipp Zabel Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/usb/dwc3/dwc3-qcom.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 1dfd024cd06b1..e1e78e9824b16 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -540,16 +540,6 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev) return 0; } -static const struct dwc3_acpi_pdata sdm845_acpi_pdata = { - .qscratch_base_offset = SDM845_QSCRATCH_BASE_OFFSET, - .qscratch_base_size = SDM845_QSCRATCH_SIZE, - .dwc3_core_base_size = SDM845_DWC3_CORE_SIZE, - .hs_phy_irq_index = 1, - .dp_hs_phy_irq_index = 4, - .dm_hs_phy_irq_index = 3, - .ss_phy_irq_index = 2 -}; - static int dwc3_qcom_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; @@ -758,11 +748,23 @@ static const struct of_device_id dwc3_qcom_of_match[] = { }; MODULE_DEVICE_TABLE(of, dwc3_qcom_of_match); +#ifdef CONFIG_ACPI +static const struct dwc3_acpi_pdata sdm845_acpi_pdata = { + .qscratch_base_offset = SDM845_QSCRATCH_BASE_OFFSET, + .qscratch_base_size = SDM845_QSCRATCH_SIZE, + .dwc3_core_base_size = SDM845_DWC3_CORE_SIZE, + .hs_phy_irq_index = 1, + .dp_hs_phy_irq_index = 4, + .dm_hs_phy_irq_index = 3, + .ss_phy_irq_index = 2 +}; + static const struct acpi_device_id dwc3_qcom_acpi_match[] = { { "QCOM2430", (unsigned long)&sdm845_acpi_pdata }, { }, }; MODULE_DEVICE_TABLE(acpi, dwc3_qcom_acpi_match); +#endif static struct platform_driver dwc3_qcom_driver = { .probe = dwc3_qcom_probe, From patchwork Mon Jul 6 13:33:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645909 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0900060D for ; Mon, 6 Jul 2020 13:44:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D16AF206F5 for ; Mon, 6 Jul 2020 13:44:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E0aQWJAA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uusCAAiM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D16AF206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+8lJYqwxkP/XB4tD1jzVgkONKD/iFuvXWiCWDXF5+9o=; b=E0aQWJAAQKSN5ptKvvHGl9rF7 SfV+UJU0npL2U39+zWRf+3AIfNKnnwoLxeFb+i3VEIjDw4E4zXsXPMLxhDQIWWqFS/bOXeUheXJaI ZMlacptwiz2J7Z7mLGqurNnx/JRc24+9NrQajQGNao7PtLtgmZxoq8U30ka4owdwzAi9WJpXVrlrn w3A+lrRjwoXGOpySHVj4srkJ6PcCh88TScMsLxL/iiDwPdYifCLLQPVUdy08cnwvA+xeKs8iPj7gG ve8YMnAw7QI1WoSoQYOm9Fl1zWQWXfZPtumMAEUi9APhThnAHzxxDUzcE6O7jhveLN3rYoF9xblNP 1JpMYVvkg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRNw-0004Sl-01; Mon, 06 Jul 2020 13:42:16 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGI-0008OP-Kl for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:24 +0000 Received: by mail-wr1-x442.google.com with SMTP id f2so12971052wrp.7 for ; Mon, 06 Jul 2020 06:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wUFrKyBE/rqHQUVcokgEiKeaeYpvOr+KJ0Q9vYwpje8=; b=uusCAAiMYRyZu2CfIvDS4HCRjCXdZtQhAdbkpOMuxK8zvkQgvAiWP7osHCg5j0Lxi5 16z2up3T4hzLGYGUj30PuZuH/B1ZOaCs7UsgLTYfLAopJ+wzvauVq5wsuRkhS9mODBVO xu3HpYfIRTGCABdG6OuYwyuSubTIL9fv8KfITH2PVNH6p+KU2u/VSZ88VFCHVaBSnUEE qCSCG4xa+6MOhyRfi5aRon2mI3zyyZNLPzHx0yYiSZHLP1iZQY77tCT0GZB2yW+6Np0Z oepj3m1na2bZFY8S7xZRfDmdzIbt82vIVRQ30dBiAEz2EguVEQm+DlN2OGXrSjBKXDOb Soig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wUFrKyBE/rqHQUVcokgEiKeaeYpvOr+KJ0Q9vYwpje8=; b=ZRUAaAfdWmlXmmWH7QlRCBTEI4bSOhLgIDi+Nr0QkJVYA4TJ3LXhv0cHqONezJY+/3 +lAi7KDWYMs2vyM+Bz8SRDVZV1ah5d74tarHh7dhkbkgrM6FmKrP4922EmGHeeUZ8kKF wjXm2+JP/f/ACu8uJJ6oymO3Pm0CQ8kS5Up2nJ2f2BSumHdanbafiJqBw3BRVIqb04+W AyBnq0GxPEnehKGHCDZ4tR8+ARn0l25TD0PAVj7CZIypjx4yCwcLDixRX9vYXNoLZyjW wizyWOSWHjfiToc9XPx3Lg41mACuxYq40iNJoxZhAlX8JgPPkUi5jA2pN+MjPL4bGw+8 hJrw== X-Gm-Message-State: AOAM530YGNu3K2JWGyqW0wx3XpQDwZZafvXz0+hQ9Bh8z/LGt8JzxePi MP5ZQ+rFAMVx3wLa3DsFJYy/0Q== X-Google-Smtp-Source: ABdhPJyyqkr63bgakviOF8q+Q3TQCXiWUrHVNA65wDA49vqE6L9e5OtXIB/BD5KAE97IICp4FfjQqQ== X-Received: by 2002:a5d:470b:: with SMTP id y11mr50993618wrq.101.1594042461212; Mon, 06 Jul 2020 06:34:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:20 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 30/32] usb: host: fhci-tds: Remove unused variables 'buf' and 'extra_data' Date: Mon, 6 Jul 2020 14:33:39 +0100 Message-Id: <20200706133341.476881-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093422_781356_54E77465 X-CRM114-Status: GOOD ( 11.12 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jerry Huang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Barada , Shlomi Gridish , Anton Vorontsov , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Neither have been used since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fhci-tds.c: In function ‘fhci_flush_bds’: drivers/usb/host/fhci-tds.c:472:6: warning: variable ‘buf’ set but not used [-Wunused-but-set-variable] 472 | u32 buf; | ^~~ drivers/usb/host/fhci-tds.c:470:6: warning: variable ‘extra_data’ set but not used [-Wunused-but-set-variable] 470 | u16 extra_data; | ^~~~~~~~~~ drivers/usb/host/fhci-tds.c: In function ‘fhci_flush_actual_frame’: drivers/usb/host/fhci-tds.c:527:6: warning: variable ‘extra_data’ set but not used [-Wunused-but-set-variable] 527 | u16 extra_data; | ^~~~~~~~~~ Cc: Shlomi Gridish Cc: Jerry Huang Cc: Peter Barada Cc: Anton Vorontsov Signed-off-by: Lee Jones --- drivers/usb/host/fhci-tds.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c index f3308ce250438..d98fd9e1af0bc 100644 --- a/drivers/usb/host/fhci-tds.c +++ b/drivers/usb/host/fhci-tds.c @@ -467,17 +467,15 @@ u32 fhci_host_transaction(struct fhci_usb *usb, /* Reset the Tx BD ring */ void fhci_flush_bds(struct fhci_usb *usb) { - u16 extra_data; u16 td_status; - u32 buf; struct usb_td __iomem *td; struct endpoint *ep = usb->ep0; td = ep->td_base; while (1) { td_status = in_be16(&td->status); - buf = in_be32(&td->buf_ptr); - extra_data = in_be16(&td->extra); + in_be32(&td->buf_ptr); + in_be16(&td->extra); /* if the TD is not empty - we'll confirm it as Timeout */ if (td_status & TD_R) @@ -524,7 +522,6 @@ void fhci_flush_actual_frame(struct fhci_usb *usb) { u8 mode; u16 tb_ptr; - u16 extra_data; u16 td_status; u32 buf_ptr; struct usb_td __iomem *td; @@ -538,7 +535,7 @@ void fhci_flush_actual_frame(struct fhci_usb *usb) td = cpm_muram_addr(tb_ptr); td_status = in_be16(&td->status); buf_ptr = in_be32(&td->buf_ptr); - extra_data = in_be16(&td->extra); + in_be16(&td->extra); do { if (td_status & TD_R) { out_be16(&td->status, (td_status & ~TD_R) | TD_TO); @@ -552,7 +549,7 @@ void fhci_flush_actual_frame(struct fhci_usb *usb) td = next_bd(ep->td_base, td, td_status); td_status = in_be16(&td->status); buf_ptr = in_be32(&td->buf_ptr); - extra_data = in_be16(&td->extra); + in_be16(&td->extra); } while ((td_status & TD_R) || buf_ptr); fhci_td_transaction_confirm(usb); From patchwork Mon Jul 6 13:33:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645911 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DED2F92A for ; Mon, 6 Jul 2020 13:44:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B72BE206F5 for ; Mon, 6 Jul 2020 13:44:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DBa0uflf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pIQ9uuVn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B72BE206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gL0Bs1KyBF3uK4rFX51G9sGQjiCrRBHC/LBfh7JgVQ8=; b=DBa0uflfGrniHfNe3VBqBXc90 Tv95Q9ZnFKkXHhYYblxorRDt/8Ppi0eEKR8oau5uCadHjMUPUYa25eZ46uEGqCwqRXBQAHoVLj9ZP oshCTkpUUZ7SySGWo97wY1Ci0J/299SZ5xXTf4V3j2wieQHbtID0fP0s+D5CxpD/1+T8uv4NdRorQ laclrj3V4vxl+gw9kpnU1itZHtwWRWzzaKWvzRwYEkLUqeLOqxroWDiEz8QcvYFgYrgYKd19eA9by 8gW7cUMccHPcNuHAtJhAftl5Fh8OoBeQ8cbqDVt3KbuZ9Kjrep7vfKRuToA3EXbN5rNtQbnCuO+KW H90SqXqtQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsROO-0004jP-FM; Mon, 06 Jul 2020 13:42:44 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGJ-0008Os-No for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:25 +0000 Received: by mail-wm1-x342.google.com with SMTP id l2so40631529wmf.0 for ; Mon, 06 Jul 2020 06:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fYphPHtOnqXpEOjqEtrG2eQ5inMeigGW8H35HCVLb4A=; b=pIQ9uuVnn+fW6hJfQP519yESrX2DO/yRDUtbTlObfQ7JiXoQk1gUB8izw+sRf4uiP8 0qRPMoy8V3fOjyBkwCzS9AG6yUdgQccA81mMdgPqR8VCUf9uNV6P4+i3drgluWiyuTmT MQEXMjrNdksYTFKqr2MlVEY2y1S2VnIj7ZkoLfXk5UAfT4JD5GUm5dHUV+1okA6gW4No 9O2oZmH1/5mtvpALvC7xYtm7gHR72y8RzKnIJ29P1F/sxS16DaKnI1wHAtggBbdw+i3T am7aikxGnPnMayMpGLeH64fpGjUAHyfWf/ZsNROTefX8AI4c+3cIjlt2iV9Amf5+79BV DbAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fYphPHtOnqXpEOjqEtrG2eQ5inMeigGW8H35HCVLb4A=; b=myuByrsCBmEmruT4ybAJzptWjVc3fZDHiokHsmPNIw3vmda+4T694xuWH50MCaT4sZ QdShh//OK7eV+Evl2fQCbzPfsTfiBe+6QoqibSbbaLW3MRaSSzMLIh3TTFNrodFNhdDj dezZCu7VTkl4mOmwtNWPEpurvS5CL6Eqrczhj3eKya+9e5hrgQ7TclKMkRCW/PtmQcFD c/R80G6PTTNsvulTPsl2FLRO8npSSEIaEtvoTUPPBvUtKkh3J8Q/AyKnNV6V6YOzP/1f deqsu6eckJ9ZTU5Y4iEAS+DH1qLHbpvxHXbdYduJViVfvgOl4yeHlo18GEjO3DMKD8RY 3lew== X-Gm-Message-State: AOAM530DxwMoPZbtDlB9aAvd6I5MYM+dd8MNh81M6sfFt/WxFfRgJYQU 4diJ0L9fZH20zqxqbBwuOdqvGA== X-Google-Smtp-Source: ABdhPJxX/0H3QT2+4IGeuZMzXZfirJMCquWrp7wTX/H7qNjAS315WxUrQkgO2PIZ78d0/7Tv01PEFA== X-Received: by 2002:a05:600c:2219:: with SMTP id z25mr6860737wml.154.1594042462367; Mon, 06 Jul 2020 06:34:22 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:21 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 31/32] usb: host: fhci-sched: Remove unused variable 'td' Date: Mon, 6 Jul 2020 14:33:40 +0100 Message-Id: <20200706133341.476881-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093423_951134_9753DA9A X-CRM114-Status: GOOD ( 10.95 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jerry Huang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Barada , Shlomi Gridish , Anton Vorontsov , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'td' has been completely unused since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fhci-sched.c: In function ‘fhci_queue_urb’: drivers/usb/host/fhci-sched.c:704:13: warning: variable ‘td’ set but not used [-Wunused-but-set-variable] 704 | struct td *td; | ^~ Cc: Shlomi Gridish Cc: Jerry Huang Cc: Peter Barada Cc: Anton Vorontsov Signed-off-by: Lee Jones --- drivers/usb/host/fhci-sched.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/fhci-sched.c b/drivers/usb/host/fhci-sched.c index 3235d53074038..63c646c8f7d62 100644 --- a/drivers/usb/host/fhci-sched.c +++ b/drivers/usb/host/fhci-sched.c @@ -701,7 +701,6 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) u32 data_len = urb->transfer_buffer_length; int urb_state = 0; int toggle = 0; - struct td *td; u8 *data; u16 cnt = 0; @@ -770,7 +769,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) usb_endpoint_maxp(&urb->ep->desc)) == 0)) urb_state = US_BULK0; while (data_len > 4096) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, cnt ? USB_TD_TOGGLE_CARRY : @@ -781,7 +780,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) cnt++; } - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, cnt ? USB_TD_TOGGLE_CARRY : toggle, data, data_len, 0, 0, true); @@ -789,7 +788,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) if (urb->transfer_flags & URB_ZERO_PACKET && cnt < urb_priv->num_of_tds) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_CARRY, NULL, 0, 0, 0, true); @@ -798,7 +797,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) break; case FHCI_TF_INTR: urb->start_frame = get_frame_num(fhci) + 1; - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA0, data, data_len, urb->interval, urb->start_frame, true); @@ -808,12 +807,12 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) ed->max_pkt_size = usb_endpoint_maxp(&urb->ep->desc); /* setup stage */ - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_SETUP, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_SETUP, USB_TD_TOGGLE_DATA0, urb->setup_packet, 8, 0, 0, true); /* data stage */ if (data_len > 0) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA1, data, data_len, 0, 0, @@ -822,12 +821,12 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) /* status stage */ if (data_len > 0) - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, (usb_pipeout(urb->pipe) ? FHCI_TA_IN : FHCI_TA_OUT), USB_TD_TOGGLE_DATA1, data, 0, 0, 0, true); else - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_IN, USB_TD_TOGGLE_DATA1, data, 0, 0, 0, true); @@ -844,7 +843,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) */ frame += cnt * urb->interval; frame &= 0x07ff; - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA0, From patchwork Mon Jul 6 13:33:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645913 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 11EE413B4 for ; Mon, 6 Jul 2020 13:45:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D485E20663 for ; Mon, 6 Jul 2020 13:45:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qYtqJijO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gbx/6YjT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D485E20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=luxGRQ/t0OmZVFjeCn8iz0Rt5d2LCVhv1GUgnsyob0U=; b=qYtqJijOY8lPA/k+bQYaK+Cn7 AYLLcVEajKpSgV/ZTTRKof7Xaa1BbkdvxVhfRbdxQb6I0ticrnmZtY2BX67T2oxK1cTeijGrbgujB D9Gri1jbCAh3nrJnqHL2HOi3BuZ+qjwou3yorTfcZLupxL9QvcKeqN3wxvLXDV8QpxPiakS4brTMu StrVZs6QPyNB8GH+CRp4lw5gBfeg9Lh8KNLQ4jIyKOZgWwsrKEQ7veNmvIraWEzXbVrJ9/kNg4DVQ d6aZ/SHCykleZhtn6jqJxmfLvKf68a5/avu6Skv3fYQKQITYzk/6JvNBwmlQ0QT21dRnDn9LlDYgX 13vAIGlFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsROf-0004v9-TW; Mon, 06 Jul 2020 13:43:02 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRGK-0008PJ-Q8 for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:25 +0000 Received: by mail-wr1-x442.google.com with SMTP id f18so32882805wrs.0 for ; Mon, 06 Jul 2020 06:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+aWkOnJjbe/7IK7NRoDvxRwORV+t2eCxVhOYLY5eRmU=; b=gbx/6YjTbDOXIW4LuH0gXQ/axZ6vtr5Q+IM30lN6HSd2IbKna7uTyK10teMAt6y0Lk 0xliIWmuFyYSKC28K8Txu3/u3lIpSijGtDQGknnxxqv2omOKry0M4wAsRTesMW1jTCkw /Ba0dcFpT+psH9sKfyWZCtE7LsLorCxeXUV4QsTez0/QuWDq2MrS6syfLhb7J2VnpAbZ q2Q119ypezf9Whp4PGxmTQ+bdWH+i0HCBUEBAsa0C1SfsMKNGakHeNCRHHdN1ynTWw5y 33tnFoqLPdDQh4A3ja91qaZ+9hK40F/VuKoKaVKroSwGPK31KwufTLIdetqfGKmilXP3 l4yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+aWkOnJjbe/7IK7NRoDvxRwORV+t2eCxVhOYLY5eRmU=; b=ljVq6nfX0JxiphTJqRDF6CFp1Rw2oqCgaakU4HSxmpDoXFOGdGDOQp+y5E79MMeJft +YCc0NPbXGdW2t85HbCT/6briCwhFFCt6NkGmJPGE54iPWOxFY/BRJjhLjNUXTxSqNyA e3DCgE9aWuA5KdrJvyfMlHYjKEckIXSsnhayV7H7ocAHRKpnAiZqxXY9GzEmyYze2CnP L8EiAEmz7Ix6tthOuZVOuUFIs/cIHsiiMlLZxtbK18Y5ck1BBfePGnqUskRDVyldp66h 1srdSoMdah1ap9562p0ib6C6MGzPAbBpvSOzg6UPLtclXvNBjITJqoKdnXw4OufwwEY1 8Dqg== X-Gm-Message-State: AOAM532xaBwRc7z1SPvCoLcZ2jwg2AGjN4q779rauBoL4PXZOfKoMwp5 RNE06sTMv69l/fd9LZ8uh8gwcIYfPW4= X-Google-Smtp-Source: ABdhPJxzVzY9SwrV/olyY4sGtNbsNmUZ7ypHADkmoDe0zZ4QHpbHLQ5OWEWVzQ/lT81AhxcLun8qWw== X-Received: by 2002:adf:8024:: with SMTP id 33mr52422302wrk.117.1594042463436; Mon, 06 Jul 2020 06:34:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:22 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 32/32] usb: host: xhci-plat: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Mon, 6 Jul 2020 14:33:41 +0100 Message-Id: <20200706133341.476881-33-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093424_919149_5D03447D X-CRM114-Status: GOOD ( 13.12 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathias Nyman , Andrzej Siewior , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct usb_xhci_acpi_match becomes defined by unused. Fixes the following W=1 kernel build warning(s): drivers/usb/host/xhci-plat.c:457:36: warning: ‘usb_xhci_acpi_match’ defined but not used [-Wunused-const-variable=] 457 | static const struct acpi_device_id usb_xhci_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~ Cc: Mathias Nyman Cc: Andrzej Siewior Signed-off-by: Lee Jones --- drivers/usb/host/xhci-plat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index f6b4089bfc4a5..3e15b70a6fc99 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -454,12 +454,14 @@ static const struct dev_pm_ops xhci_plat_pm_ops = { NULL) }; +#ifdef CONFIG_ACPI static const struct acpi_device_id usb_xhci_acpi_match[] = { /* XHCI-compliant USB Controller */ { "PNP0D10", }, { } }; MODULE_DEVICE_TABLE(acpi, usb_xhci_acpi_match); +#endif static struct platform_driver usb_xhci_driver = { .probe = xhci_plat_probe,