From patchwork Tue Oct 16 14:31:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 10643669 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C995813AD for ; Tue, 16 Oct 2018 14:31:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B48BD2A2C9 for ; Tue, 16 Oct 2018 14:31:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B31772A2B8; Tue, 16 Oct 2018 14:31:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4EB012A221 for ; Tue, 16 Oct 2018 14:31:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727006AbeJPWWW (ORCPT ); Tue, 16 Oct 2018 18:22:22 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:37200 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726760AbeJPWWV (ORCPT ); Tue, 16 Oct 2018 18:22:21 -0400 Received: by mail-io1-f65.google.com with SMTP id m16-v6so16660797ioj.4 for ; Tue, 16 Oct 2018 07:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=HQCxJ8je1SZU3UvvqJ5DZ7s28UU+jboLV+tSAWRaSiM=; b=dxataAF/jne+AK6529wDaVG6nVkPFFEcJSw3OfOg+SdcUJLUp5fG434nJPvwatGAVg 6bJU3iBz5+kxS2udNkVR1zA8xKYFuh3EXPKnMnCxy3IylSwsC4XQEOsI7hzZp/0hd34z vyu/FWKt8atXz/XvCec9FHrXi1w9pG+u0ooaCP9yFg7uNzSQtx3BOU6taAemZeySLy79 qILh2kiKuhk2VRSGHLk/BEyakXI9VpG6MhcheX8a+dtBScUXx1HOE/ULEchUzZu/FZec 5tKXtCBiwbm0yRQaDdXvf1KAR5sYu6pJC12fJUMY1uuwwiYwfwFcdMsKykpagqzVLzHc aboA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=HQCxJ8je1SZU3UvvqJ5DZ7s28UU+jboLV+tSAWRaSiM=; b=blX1gu3zN4Uk2ZgnTR29ncDsg2mToeP6SPwXsXZknrZMJdBpZJd3t7juSF/rplNSYZ FNs3iGC4Fk/EaqkRWanJhWJeyTZSJbMVvoqpQSXjkG+TKwNuQj6B/KuXpYM1z8QvvDpW zuZ8Ev4lXsrlqsMPm1EhObu73rsEMhC6SENP/CzDRWGPqfAOF5uq5MeNq+VdbKNYj0rF UsowoyGwhLYp560aVmHCaiKTahIehz1jTcp0ooGxYd3WjdcusxP3ijpgLzxrFWRsn2gv f68JL1R6lOBwyXSJIB0BCRggmX7+A/BK7tC04kW1Kv8YzxGlbA+3Uc0vLKQDgsJ1PPGs 5NWg== X-Gm-Message-State: ABuFfojaN2rWjwrarFJFbfAhIZGKwD+ntLY+bjpoCY1+FxnvrVxyFHAo 4+ExMkmwGgAIv2w4b7uftUpHlIanbNU= X-Google-Smtp-Source: ACcGV63BXnvoy5hi/femBYwdmhl0xnIDRCk3w+5IfE2lGQZiU4f3S5CA5SK0k5Orxjj4q9J7usTDPA== X-Received: by 2002:a6b:9108:: with SMTP id t8-v6mr16415003iod.112.1539700297069; Tue, 16 Oct 2018 07:31:37 -0700 (PDT) Received: from [192.168.1.56] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id k17-v6sm3967067ioa.72.2018.10.16.07.31.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 07:31:35 -0700 (PDT) To: Parav Pandit , Bart Van Assche Cc: linux-scsi From: Jens Axboe Subject: [PATCH] IB/srp: remove old request_fn_active check Message-ID: <943d4f75-f12b-6ff4-711c-27a3a17465e7@kernel.dk> Date: Tue, 16 Oct 2018 08:31:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This check is only viable for non scsi-mq. Since that is going away, kill this legacy check. Cc: Bart Van Assche Cc: Parav Pandit Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe Reviewed-by: Bart Van Assche --- drivers/infiniband/ulp/srp/ib_srp.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 0b34e909505f..5a79444c2f3c 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -1334,13 +1334,6 @@ static void srp_terminate_io(struct srp_rport *rport) struct scsi_device *sdev; int i, j; - /* - * Invoking srp_terminate_io() while srp_queuecommand() is running - * is not safe. Hence the warning statement below. - */ - shost_for_each_device(sdev, shost) - WARN_ON_ONCE(sdev->request_queue->request_fn_active); - for (i = 0; i < target->ch_count; i++) { ch = &target->ch[i];