From patchwork Fri Jul 10 03:50:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Song Bao Hua (Barry Song)" X-Patchwork-Id: 11655597 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D233113BD for ; Fri, 10 Jul 2020 03:52:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 93AAA2072E for ; Fri, 10 Jul 2020 03:52:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93AAA2072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A4E346B0006; Thu, 9 Jul 2020 23:52:33 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 9FFCE6B0007; Thu, 9 Jul 2020 23:52:33 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9153C6B0008; Thu, 9 Jul 2020 23:52:33 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 79D3F6B0006 for ; Thu, 9 Jul 2020 23:52:33 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0FEDA180ACC20 for ; Fri, 10 Jul 2020 03:52:33 +0000 (UTC) X-FDA: 77020794186.02.lip09_400ef6326ecb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id D1CCF2000328F26E for ; Fri, 10 Jul 2020 03:52:32 +0000 (UTC) X-Spam-Summary: 1,0,0,26a3a3405840ee1a,d41d8cd98f00b204,song.bao.hua@hisilicon.com,,RULES_HIT:2:41:355:379:421:541:582:800:960:966:973:988:989:1152:1260:1261:1277:1311:1313:1314:1345:1431:1437:1515:1516:1518:1535:1605:1730:1747:1777:1792:1963:2194:2196:2198:2199:2200:2201:2393:2559:2562:2689:2693:2731:2741:3138:3139:3140:3141:3142:3167:3865:3866:3867:3868:3870:3871:3872:3874:4049:4118:4250:4321:4385:4605:5007:6261:6630:6742:7875:8603:8660:9592:10004:11026:11473:11658:11914:12043:12295:12296:12297:12438:12555:12895:12986:13141:13148:13161:13229:13230:13894:13972:14394:21080:21451:21627:21939:30012:30045:30054:30056:30064,0,RBL:45.249.212.35:@hisilicon.com:.lbl8.mailshell.net-62.2.2.100 64.100.201.201;04yf3bgyt5qju7mwszdbzbowzwmhyypio8wdhjw1gqnnpa5sbqany5pyeay1x48.yhwbenxo19pgh5uppf3ts7quunrgdrgxbm1zetwec7sjx1mp8ibj4gxojdztur5.h-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:none,Custom_rules:0:0 :0,LFtim X-HE-Tag: lip09_400ef6326ecb X-Filterd-Recvd-Size: 7760 Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 03:52:23 +0000 (UTC) Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 352C5E318CA7A956C58D; Fri, 10 Jul 2020 11:52:20 +0800 (CST) Received: from SWX921481.china.huawei.com (10.126.201.126) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Fri, 10 Jul 2020 11:52:12 +0800 From: Barry Song To: CC: , , , , , Barry Song , Roman Gushchin , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Mike Kravetz , Mike Rapoport , "Anshuman Khandual" , Jonathan Cameron Subject: [PATCH v2] mm/hugetlb: split hugetlb_cma in nodes with memory Date: Fri, 10 Jul 2020 15:50:14 +1200 Message-ID: <20200710035014.25244-1-song.bao.hua@hisilicon.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.126.201.126] X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: D1CCF2000328F26E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Rather than splitting huge_cma in online nodes, it is better to do it in nodes with memory. Without this patch, for an ARM64 server with four numa nodes and only node0 has memory. If I set hugetlb_cma=4G in bootargs, without this patch, I got the below printk: hugetlb_cma: reserve 4096 MiB, up to 1024 MiB per node hugetlb_cma: reserved 1024 MiB on node 0 hugetlb_cma: reservation failed: err -12, node 1 hugetlb_cma: reservation failed: err -12, node 2 hugetlb_cma: reservation failed: err -12, node 3 With this patch, I got the below printk: hugetlb_cma: reserve 4096 MiB, up to 4096 MiB per node hugetlb_cma: reserved 4096 MiB on node 0 So this patch makes the hugetlb_cma size consistent with users' setting on ARM64 platforms. Jonathan Cameron tested this patch on x86 platform. Jonathan figured out the boot code of x86 is much different with arm64. On arm64 all nodes are marked online at the same time. On x86, only nodes with memory are initially marked as online: initmem_init()->x86_numa_init()->numa_init()-> numa_register_memblks()->alloc_node_data()->node_set_online() So at time of the existing cma setup call only the memory containing nodes are online. The other nodes are brought up much later. Therefore, on x86 platform, hugetlb_cma size is actually consistent with users' setting even though system has nodes without memory. The problem is always there if N_ONLINE != N_MEMORY. In x86 case, it is just hidden because N_ONLINE happen to match N_MEMORY during the boot process when hugetlb_cma_reserve() gets called. This patch documents this problem in the comment of hugetlb_cma_reserve() and makes hugetlb_cma size optimal. Cc: Roman Gushchin Cc: Catalin Marinas Cc: Will Deacon Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: H. Peter Anvin Cc: Mike Kravetz Cc: Mike Rapoport Cc: Andrew Morton Cc: Anshuman Khandual Cc: Jonathan Cameron Signed-off-by: Barry Song --- -v2: document better according to Anshuman Khandual's comment arch/arm64/mm/init.c | 19 ++++++++++--------- arch/x86/kernel/setup.c | 12 +++++++++--- include/linux/hugetlb.h | 7 +++++++ mm/hugetlb.c | 4 ++-- 4 files changed, 28 insertions(+), 14 deletions(-) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 1e93cfc7c47a..420f5e55615c 100644 --- a/arch/arm64/mm/init.c +++ b/arch/arm64/mm/init.c @@ -420,15 +420,6 @@ void __init bootmem_init(void) arm64_numa_init(); - /* - * must be done after arm64_numa_init() which calls numa_init() to - * initialize node_online_map that gets used in hugetlb_cma_reserve() - * while allocating required CMA size across online nodes. - */ -#ifdef CONFIG_ARM64_4K_PAGES - hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT); -#endif - /* * Sparsemem tries to allocate bootmem in memory_present(), so must be * done after the fixed reservations. @@ -438,6 +429,16 @@ void __init bootmem_init(void) sparse_init(); zone_sizes_init(min, max); + /* + * must be done after zone_sizes_init() which calls free_area_init() + * that calls node_set_state() to initialize node_states[N_MEMORY] + * because hugetlb_cma_reserve() will scan over nodes with N_MEMORY + * state + */ +#ifdef CONFIG_ARM64_4K_PAGES + hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT); +#endif + memblock_dump_all(); } diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index a3767e74c758..a1a9712090ae 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -1164,9 +1164,6 @@ void __init setup_arch(char **cmdline_p) initmem_init(); dma_contiguous_reserve(max_pfn_mapped << PAGE_SHIFT); - if (boot_cpu_has(X86_FEATURE_GBPAGES)) - hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT); - /* * Reserve memory for crash kernel after SRAT is parsed so that it * won't consume hotpluggable memory. @@ -1180,6 +1177,15 @@ void __init setup_arch(char **cmdline_p) x86_init.paging.pagetable_init(); + /* + * must be done after zone_sizes_init() which calls free_area_init() + * that calls node_set_state() to initialize node_states[N_MEMORY] + * because hugetlb_cma_reserve() will scan over nodes with N_MEMORY + * state + */ + if (boot_cpu_has(X86_FEATURE_GBPAGES)) + hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT); + kasan_init(); /* diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 50650d0d01b9..6df411d91040 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -909,6 +909,13 @@ static inline spinlock_t *huge_pte_lock(struct hstate *h, } #if defined(CONFIG_HUGETLB_PAGE) && defined(CONFIG_CMA) +/** + * hugetlb_cma_reserve() -- reserve CMA for gigantic pages on nodes with memory + * + * must be called after free_area_init() that updates N_MEMORY via node_set_state(). + * hugetlb_cma_reserve() scans over N_MEMORY nodemask and hence expects the platforms + * to have initialized N_MEMORY state. + */ extern void __init hugetlb_cma_reserve(int order); extern void __init hugetlb_cma_check(void); #else diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bc3304af40d0..f2071f2d8c1f 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -5685,12 +5685,12 @@ void __init hugetlb_cma_reserve(int order) * If 3 GB area is requested on a machine with 4 numa nodes, * let's allocate 1 GB on first three nodes and ignore the last one. */ - per_node = DIV_ROUND_UP(hugetlb_cma_size, nr_online_nodes); + per_node = DIV_ROUND_UP(hugetlb_cma_size, num_node_state(N_MEMORY)); pr_info("hugetlb_cma: reserve %lu MiB, up to %lu MiB per node\n", hugetlb_cma_size / SZ_1M, per_node / SZ_1M); reserved = 0; - for_each_node_state(nid, N_ONLINE) { + for_each_node_state(nid, N_MEMORY) { int res; size = min(per_node, hugetlb_cma_size - reserved);