From patchwork Fri Jul 10 21:37:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 11657413 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7410D739 for ; Fri, 10 Jul 2020 21:38:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52BB22078B for ; Fri, 10 Jul 2020 21:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594417089; bh=voaw5zogeDEPtBupN3rvnArHqvP6llFW4mbuvf6Xffo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NqP1rpUsj78vHN+I/bxTBKwGCgI+qmj7mvnpRGDJcxgwWtmv5D3WJanX6OP3CFnpq +4DexL+a2sFNwNt+forNDbxKDnfHbBOmgjwcFgmrNUCLuc5XW8I+gxjOc9hExXzBfK DRfMW8TXTO3kfSjehu693vh5tl3o6oQ7Ag5P4znI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726367AbgGJViJ (ORCPT ); Fri, 10 Jul 2020 17:38:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:44656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726251AbgGJViI (ORCPT ); Fri, 10 Jul 2020 17:38:08 -0400 Received: from localhost (mobile-166-175-191-139.mycingular.net [166.175.191.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CDC43206C3; Fri, 10 Jul 2020 21:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594417088; bh=voaw5zogeDEPtBupN3rvnArHqvP6llFW4mbuvf6Xffo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FO8jE0iqjJnkmrLxpkOmyeOfdtp3zUbsvRMLgb3XSfomgPrqbfGlPCKpXP9hqovJm sTeQWLOoBXZIXHE8idFbJCWM0WAE+s3cLSd2ctCx8bUWbSESrWlW/phjxxVGyTU5Kr UWgw1R+2oVwAOboEIUV0ckMNP62xSPiVbbfSo8yk= From: Bjorn Helgaas To: "Rafael J . Wysocki" , Len Brown Cc: Sean V Kelley , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH 1/2] PCI/ACPI: Unexport acpi_pci_osc_control_set() Date: Fri, 10 Jul 2020 16:37:52 -0500 Message-Id: <20200710213753.83420-2-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200710213753.83420-1-helgaas@kernel.org> References: <20200710213753.83420-1-helgaas@kernel.org> MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Bjorn Helgaas acpi_pci_osc_control_set() is called only inside pci_root.c and there's no need for it to be called by modules. Make it static and unexport it. Signed-off-by: Bjorn Helgaas --- drivers/acpi/pci_root.c | 4 ++-- include/linux/acpi.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c index f90e841c59f5..b6da9745efcd 100644 --- a/drivers/acpi/pci_root.c +++ b/drivers/acpi/pci_root.c @@ -355,7 +355,8 @@ EXPORT_SYMBOL_GPL(acpi_get_pci_dev); * _OSC bits the BIOS has granted control of, but its contents are meaningless * on failure. **/ -acpi_status acpi_pci_osc_control_set(acpi_handle handle, u32 *mask, u32 req) +static acpi_status acpi_pci_osc_control_set(acpi_handle handle, u32 *mask, + u32 req) { struct acpi_pci_root *root; acpi_status status = AE_OK; @@ -408,7 +409,6 @@ acpi_status acpi_pci_osc_control_set(acpi_handle handle, u32 *mask, u32 req) mutex_unlock(&osc_lock); return status; } -EXPORT_SYMBOL(acpi_pci_osc_control_set); static void negotiate_os_control(struct acpi_pci_root *root, int *no_aspm, bool is_pcie) diff --git a/include/linux/acpi.h b/include/linux/acpi.h index d661cd0ee64d..bb20a872729e 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -581,9 +581,6 @@ extern bool osc_pc_lpi_support_confirmed; #define ACPI_GSB_ACCESS_ATTRIB_RAW_BYTES 0x0000000E #define ACPI_GSB_ACCESS_ATTRIB_RAW_PROCESS 0x0000000F -extern acpi_status acpi_pci_osc_control_set(acpi_handle handle, - u32 *mask, u32 req); - /* Enable _OST when all relevant hotplug operations are enabled */ #if defined(CONFIG_ACPI_HOTPLUG_CPU) && \ defined(CONFIG_ACPI_HOTPLUG_MEMORY) && \ From patchwork Fri Jul 10 21:37:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 11657417 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E43FA14DD for ; Fri, 10 Jul 2020 21:38:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC502207FC for ; Fri, 10 Jul 2020 21:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594417093; bh=isY0pS9oGm7dGtxlL9m4aLsA5EJIEBlakrUHURN2ht0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=v4cGBNA9M3k8IQeBchvkTEcRJb/+nN5UTxmkI8mvdd8d39yGmNRxvzzOK8KDD1BfK 6luqzRPn8dSDGhXzmkrQu2kOevNDP75vqPF/sB3dSNJKfWg5A+QgrDNfMrzAB5aonL +AVIlQUNiHb4N/kNyEDQ7EQHSsJ5U4r44LB5R37M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726465AbgGJViN (ORCPT ); Fri, 10 Jul 2020 17:38:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:44740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726251AbgGJViM (ORCPT ); Fri, 10 Jul 2020 17:38:12 -0400 Received: from localhost (mobile-166-175-191-139.mycingular.net [166.175.191.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3865920772; Fri, 10 Jul 2020 21:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594417092; bh=isY0pS9oGm7dGtxlL9m4aLsA5EJIEBlakrUHURN2ht0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qzBtSTV5wS1vLwn1ewmhaZpMbH2Sj9LaladOMvk6RCzyJ48ljQ/ZeHxpW8BjuyNlX dkqx/FLR54+gqNiz6bKVN99d4X6OMYOGMSB2zJ0b/EVAueY7NAJVgHW8Z6DKNAkz95 8JNtFVBZgrz0tz2F4jlNRcJczX0yTCJwt2/vovp8= From: Bjorn Helgaas To: "Rafael J . Wysocki" , Len Brown Cc: Sean V Kelley , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH 2/2] PCI/ACPI: Unexport acpi_pci_find_root() Date: Fri, 10 Jul 2020 16:37:53 -0500 Message-Id: <20200710213753.83420-3-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200710213753.83420-1-helgaas@kernel.org> References: <20200710213753.83420-1-helgaas@kernel.org> MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Bjorn Helgaas acpi_pci_find_root() is called only from pci_root.c and drivers/pci/hotplug/acpi_pcihp.c, neither of which can be modules. Unexport it. Signed-off-by: Bjorn Helgaas --- drivers/acpi/pci_root.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c index b6da9745efcd..933890f97720 100644 --- a/drivers/acpi/pci_root.c +++ b/drivers/acpi/pci_root.c @@ -246,7 +246,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle) return root; } -EXPORT_SYMBOL_GPL(acpi_pci_find_root); struct acpi_handle_node { struct list_head node;