From patchwork Mon Jul 13 13:04:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 11659613 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BE50D138C for ; Mon, 13 Jul 2020 13:06:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9232F20738 for ; Mon, 13 Jul 2020 13:06:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XNh/3XFq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bUkScf4m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9232F20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=OxuVqOjeS5C1VdrAioQVkDvurWWGMy1zE9+05vyUKc0=; b=XNh/3XFqdT7g7/jZyht8CZ/9yj XW07o55PoMfyEDayQR76aI43orDJD6JIqP11PCE3fqH8EU5FpNAVL4m33EvLoFKvLInc/W0yJOZSt W4mAlDdnxQlMpFH/kGeJS6fzsNc4dtjtz6ztVS8wacsStsMNfySm0HUU7xrQb0U1WL/f/Rd0H47EP dqq0sduse1r44WomTVPywkV77BRGLooWZUplKUA1wOtDXOxgaEbCGTKcl66sjrmr+9LEP36By4ClB cSCO9i6QX9BA/BjrSySd5mDBcmd8rX8yMEveIjcGoxVe4sByLBdFclGj9HyjnkxKkbKH7hSpQU+Eq XffKqfPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juy8K-0003Wb-S3; Mon, 13 Jul 2020 13:04:36 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juy8H-0003Vt-A9 for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 13:04:35 +0000 Received: by mail-qk1-x743.google.com with SMTP id e11so12039427qkm.3 for ; Mon, 13 Jul 2020 06:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=+Y4KsJfOUBFO+dGHuoBuX13lxdndr3CQ4NdNFygROTs=; b=bUkScf4mVuFTE5zWM9ilGyHfbRZ8PK3PbjhmDwGnJRiKZErj6MRxo3LlUm/yH42VI3 wKLFwy9N8taM2FZxVRCIFrWbudC/GXh9Y2brmoQWXGTa0aN0F7Kue2ZmGx2EHLKr5KUY hJvb2CzhGQGnvd6gtE8+9T2GRJ460EkveFBwLHVHrbD7SOa0i/17061xMZVy3XuA6hTr I1Ryjr5RVG60euELqhCdxn021nCp2+XrEMipN0O0XU/c/aoY+76woPIX4N2HwVwYA5+n l5Qle1wgomc7qZcKW1VjzOo0RVuXgTyT5y6aDRQme3/NBuIhWZ5N1ZnGgIwqZDodvJI/ rn0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+Y4KsJfOUBFO+dGHuoBuX13lxdndr3CQ4NdNFygROTs=; b=SENZDReoD/6+xY7nPsH5BmtZzNx96nvzhGqNYZdT1033sJ8I1RIvqeZ6In+E7SwfXq XTXpJEFA+XMuOazBz/nTnTiNOHU7D3rq/n13GTEAjkHk+qzacI+buGQbI69CMaUmCWDh vz7BoJCPt0pBr+Z4kf6M6tITN+Ml7M0eDB/4jSbaQFj2zKrobEaIbhsLjFcq5YWYjzjS c1hO0l5XChZN8My+KOyOWtRsrQAq2ut0stE2iRLN5L3/ev8PM8rS3Dc2SjoRr4dChgrE 3xlY9/iNiNAcgXnGFBCOJ05oJLfn9EJZOlxRNfO8rSwrE8j/muyEXuyILPAkmayweHAI r/kw== X-Gm-Message-State: AOAM532+WCKrp5GObIbLryC8yXJAOeTIrIG1zpVvoo/WXYEgJMMlvNy6 XEwfLvAOhcgATQ2jl8Udrmo= X-Google-Smtp-Source: ABdhPJxX0V5miYJ43u6apIKBuTYCYeSWvWSKDi8jUyBt57tfPuGjujbdWWytW2qjiuKu/C1yr5A5pQ== X-Received: by 2002:ae9:e841:: with SMTP id a62mr81983057qkg.497.1594645470026; Mon, 13 Jul 2020 06:04:30 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:482:92b:9d6d:2996:7c26:fb1d]) by smtp.gmail.com with ESMTPSA id i22sm17668651qki.4.2020.07.13.06.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 06:04:28 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Subject: [PATCH v2 1/2] ARM: dts: imx6qdl-sabresd: Add an mdio node Date: Mon, 13 Jul 2020 10:04:15 -0300 Message-Id: <20200713130416.20040-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_090433_366544_75EDF451 X-CRM114-Status: GOOD ( 11.51 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:743 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [festevam[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: smoch@web.de, Fabio Estevam , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org imx6qdl-sabresd has an Atheros AR8031 Ethernet PHY at address 1. The AR8031 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin. Improve the Ethernet representation by adding an mdio node with such information. An advantage of adding the mdio node is that the AR8031 initialization code in the mx6sabresd board file in U-Boot can totally be removed. Signed-off-by: Fabio Estevam Reviewed-by: Soeren Moch --- Changes since v1: - None. Only inverted the order of the patches arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index 28b35ccb3757..6524ad4b0010 100644 --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi @@ -203,9 +203,20 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; + phy-handle = <&phy>; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; fsl,magic-packet; status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + phy: ethernet-phy@1 { + reg = <1>; + qca,clk-out-frequency = <125000000>; + }; + }; }; &hdmi { From patchwork Mon Jul 13 13:04:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 11659619 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BFE97618 for ; Mon, 13 Jul 2020 13:08:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95A7520771 for ; Mon, 13 Jul 2020 13:08:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mqKgHTQe"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hMPYRLvr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95A7520771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7g6Qxs7fiThGwSfblZOWNvoIMu4i2rXPuRBiDt+itdY=; b=mqKgHTQeCMGDubGrWxkQfygajJ JzKlSzQCzzNjL+B7uLAI/3xI/5ygQTm7xdbrYBTigLc8FrtKNQKkIo+9GUPX1udMC+md9YEGxFmbF bobvDzygeZQSG2lc2KGsl0o9+/iuUxWy9LVVGh+XXqalZ8czTLi8R9j4q9ZJgSYrU3CLHW8/ExqB9 XUolj7N+w+0B1aA55fOUj1aWNiAktyctyro7l5Suo+utszU/Og2PICvp6QMaC1cDrBSem/iJfWvHT Lj7RkCpSmKpWvdNRed4zfRrkr72nkE8HcwD00v6286q+cFwLHgh7mA1LgVWQvjGZDGuNBeWT3M0/p ItYcgHUg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juy8N-0003XF-Is; Mon, 13 Jul 2020 13:04:39 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juy8K-0003WG-Eh for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 13:04:37 +0000 Received: by mail-qk1-x72e.google.com with SMTP id b185so12038586qkg.1 for ; Mon, 13 Jul 2020 06:04:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=35FSK4JprrQBmLx1X0YrsVK7ghOdSoHhCzZCBs8WDmc=; b=hMPYRLvrOSkID0zynlcZutt5VkEwwsgpDWe7HbC9hIoKE141gUE9gTt/jyWuyYj0bR qG6NX+keBdxQJGZc6DMrVh6A0P663ezG8nNf0s+J7yKbB/rEkIyY0fPtLCp0gzvavtfq OcX7W3tkKc+yEN1GaoxGJOqCbfF3ifHK2I0IcYEh/xUCyCpb3BADWgJo1hH8BS35u0rm dupiuGwj85RSeL7cUAW7nEJswWl2tVpqj6B7NlFxux2Y9gu6TyiTP+uKcWVG1b4nif7v Egc3E7MC5UAN6QDsymYHjL11xRB5U9t8/dZp2mb3HLAW4fZKICGlNsDQ2TSG/4wFpwyf UKjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=35FSK4JprrQBmLx1X0YrsVK7ghOdSoHhCzZCBs8WDmc=; b=nVXjwYC9jd6ZdlVUSYB9kPaeNM2F5s2t6i/Da3FqnXo7ZSkLTC00g9tpJHz5QRgNuM n+eZiTvlDMTMan0iPn6uqF0AhGD7LHEiROJQ6izPCcDtFNTaA4kfIf9Te2jsENcVLbuU ZnHE64Qq9bPZBWPhRiyxLDygOZNYPr5zjq1Ig5An2CxZZVPtuj/4hA8Zgt13Io/PQf4e 1JzcjT0LusYVWYrFFdGBtIr0wX7t9M+9pwd44O4wZ2PZdM4rxjXYfxowayMBEoopign6 +UeR6yBRiVwAJ5337zDR6IAg1Jgmgxn3inROvlET46ozF/S+RzJz2An+2kbswHsYMZUA EP7A== X-Gm-Message-State: AOAM530HvGHZptPWeMsSkFOWJex3TB68Y4F7vIOajckmCAFatuN7ZIPq OmLMYHic0HnwizyQ8YvIQ68= X-Google-Smtp-Source: ABdhPJybj+smwPkr5HX1yROAJs6G+H6x908mGnOVmjyFAR9tNQu/e/jg74NlG2V0L5m0wz9eLOALDw== X-Received: by 2002:a37:45c4:: with SMTP id s187mr82014160qka.246.1594645472758; Mon, 13 Jul 2020 06:04:32 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:482:92b:9d6d:2996:7c26:fb1d]) by smtp.gmail.com with ESMTPSA id i22sm17668651qki.4.2020.07.13.06.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 06:04:32 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Subject: [PATCH v2 2/2] ARM: dts: imx6qdl-sabresd: Pass reset-assert-us Date: Mon, 13 Jul 2020 10:04:16 -0300 Message-Id: <20200713130416.20040-2-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200713130416.20040-1-festevam@gmail.com> References: <20200713130416.20040-1-festevam@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_090436_577796_DE57F96B X-CRM114-Status: GOOD ( 12.98 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:72e listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [festevam[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: smoch@web.de, Fabio Estevam , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org According to the AR8031 datasheet: "When using crystal, clock is generated internally after the power is stable. In order to get reliable power-on-reset, it is recommended to keep asserting the reset low signal long enough (10 ms) to ensure the clock is stable and clock-to-reset (1 ms) requirement is satisfied." Pass the 'reset-assert-us' property to describe such requirement. While at it, use the 'reset-gpios' property inside the the mdio node instead of the deprecated usage of 'phy-reset-gpios'. Signed-off-by: Fabio Estevam Reviewed-by: Soeren Moch --- Changes since v1: - Use reset-gpios and reset-assert-us inside the mdio node instead of the deprecated usage of phy-reset-gpios (Soeren) arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index 6524ad4b0010..5597d45fffda 100644 --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi @@ -204,7 +204,6 @@ pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; phy-handle = <&phy>; - phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; fsl,magic-packet; status = "okay"; @@ -215,6 +214,8 @@ phy: ethernet-phy@1 { reg = <1>; qca,clk-out-frequency = <125000000>; + reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; + reset-assert-us = <10000>; }; }; };