From patchwork Tue Jul 14 14:50:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663033 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6A9D7722 for ; Tue, 14 Jul 2020 14:53:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB12D21D6C for ; Tue, 14 Jul 2020 14:53:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xnFmQbVF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mPwQpN+Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB12D21D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zEVDjHWro2ZNOy/Ga2nhxH17hoOZB41LhAXGrFqOfFY=; b=xnFmQbVFzTpsW/cLP44erdCXX vCKs79vme8vT02TOcOoHEOtRtWJBwJHedauiFHNoobmPRzxKVhWynVy6CsATExmgyC2BnNDRKduUB dHBXjwR1yiPkzP/cH0lFWig1VcTT5uAVALlQQruFHlPssGzQEfmLFQstzg2C74YLvhXBxaQv4t2tQ 9gd0ViW83o9amXlM6R8dvWIEqJaX61W6OtIZ6uuuv2dNPprBX3n5AIUE/c7aeoH67iD6KbK20qaqE LAJnlaPSxZI9lyE2hahnOzEOlQBZHm5JJE/qnFJbUVW5y0TNF7RTQr4h5//0351GMXhvqWbjJ4gQL hr3F+E3Cw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGs-0004T0-SF; Tue, 14 Jul 2020 14:51:03 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGk-0004Pf-3o for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:50:54 +0000 Received: by mail-wr1-x444.google.com with SMTP id a6so22167544wrm.4 for ; Tue, 14 Jul 2020 07:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PyDCzRLu9Rp5ffLvCZoaXuGAE+qn3bcIj12X3rgDaY8=; b=mPwQpN+Qu91QZ2MKryhuGiiJzJqon/gMYBCzo8EhqXVyHMQU0f+SMVudmHG3byrsFK JJYM1icU5EgZZbY6UYqyJwH565d2EsGYC3ePxJSqwzt3Sa2srbEpSqLjlpkYKxWjp1tw ujqOlhVyy3Yhl2YAiVxMF+wEXe1nzyw7RUCYva3xlELef2BJOfsvWrUonzTeAAs2K2cl +OI1ZY/+TGOGmYtPt09UgSnQS0g97Lw8dAr+PkDKclYLsAo6vPt4dQpPqsTDRb+XCLLN +QPntCH68/N596jApxTdK3oGeuqqT+RPWpopbMCXmfq3KHiUYiEjhSsk2tsn5jF4REAr 5jDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PyDCzRLu9Rp5ffLvCZoaXuGAE+qn3bcIj12X3rgDaY8=; b=L48RnkXtFGTwyELTYY0+Jgb3wpCTLl3E/HuYwOAQDN9KnQOJP+sLUQiHO//IHtmKAU 0/8yAp3k++QPLsY41YFBgNvBOOZnsnqCelKFgcDQWXrPlviWX+1f90Alb5r0MaAVxtIy 53CL2iTLkRqpQyidOCm7t6UBfKaiV0UFDGwXEIZdc3Bo2Jwzslaefac6uoE8VyEIXIKu G+ilQXIynmWHz4Yek+YBjI3lI8hBxSBXaYvafdTJq/uIgVTMOjYyhr0iEmtxIS08lAEd Qw+NgbjH5g1hoI0zVZk7JpCguOZMQZ1NrABJr0Zb+LKYW4Lwtv3ol4xGvGrs5wRm4XMD FNlw== X-Gm-Message-State: AOAM532cAAUvJhxg2do5OHvbANQGDhIDkiIl95Va02/P20cErNyIZ4Jf eUKuUrETbi5dxTYQwHvvklZCtg== X-Google-Smtp-Source: ABdhPJyfB1Tf3EHgK0lx0lDBNPNcHN0//kJ4X5HF1TFk9KcRccYA9FoOD6xF1iEC2VIyddc1Jc7SAA== X-Received: by 2002:a5d:4c82:: with SMTP id z2mr5923643wrs.287.1594738253227; Tue, 14 Jul 2020 07:50:53 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:52 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 01/13] cpufreq: freq_table: Demote obvious misuse of kerneldoc to standard comment blocks Date: Tue, 14 Jul 2020 15:50:37 +0100 Message-Id: <20200714145049.2496163-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105054_201283_2DF1E3E8 X-CRM114-Status: GOOD ( 11.16 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dominik Brodowski , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/freq_table.c:229: warning: Function parameter or member 'policy' not described in 'show_available_freqs' drivers/cpufreq/freq_table.c:229: warning: Function parameter or member 'buf' not described in 'show_available_freqs' drivers/cpufreq/freq_table.c:229: warning: Function parameter or member 'show_boost' not described in 'show_available_freqs' drivers/cpufreq/freq_table.c:269: warning: Function parameter or member 'policy' not described in 'scaling_available_frequencies_show' drivers/cpufreq/freq_table.c:269: warning: Function parameter or member 'buf' not described in 'scaling_available_frequencies_show' drivers/cpufreq/freq_table.c:281: warning: Function parameter or member 'policy' not described in 'scaling_boost_frequencies_show' drivers/cpufreq/freq_table.c:281: warning: Function parameter or member 'buf' not described in 'scaling_boost_frequencies_show' Cc: Dominik Brodowski Signed-off-by: Lee Jones Acked-by: Viresh Kumar --- drivers/cpufreq/freq_table.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c index e117b0059123e..f839dc9852c08 100644 --- a/drivers/cpufreq/freq_table.c +++ b/drivers/cpufreq/freq_table.c @@ -221,7 +221,7 @@ int cpufreq_frequency_table_get_index(struct cpufreq_policy *policy, } EXPORT_SYMBOL_GPL(cpufreq_frequency_table_get_index); -/** +/* * show_available_freqs - show available frequencies for the specified CPU */ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf, @@ -260,7 +260,7 @@ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf, struct freq_attr cpufreq_freq_attr_##_name##_freqs = \ __ATTR_RO(_name##_frequencies) -/** +/* * show_scaling_available_frequencies - show available normal frequencies for * the specified CPU */ @@ -272,7 +272,7 @@ static ssize_t scaling_available_frequencies_show(struct cpufreq_policy *policy, cpufreq_attr_available_freq(scaling_available); EXPORT_SYMBOL_GPL(cpufreq_freq_attr_scaling_available_freqs); -/** +/* * show_available_boost_freqs - show available boost frequencies for * the specified CPU */ From patchwork Tue Jul 14 14:50:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663041 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 963FF1392 for ; Tue, 14 Jul 2020 14:53:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F09F21973 for ; Tue, 14 Jul 2020 14:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cgYn45gP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YEcBJ/q7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F09F21973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KOrxGlSUHOgo3naEAqb28Ig4Q7KsYseBdqMR0cYOTMA=; b=cgYn45gPFhITsECmgZtXLmxt8 kLPHeUILOx0Kmtx6nxvyz7bf3hK8G1qAf3OtaIdDLiQJdHQuN/od8NwRLyEbBrxBInW/6aPU1zaog jOA12d4GEveeh8APbAp9Y6qgDFzrBLA5RdeCEJzBdLHg/3iFr32wrgPjIao2YTLnH+/MUWAAVYRyi 5hB5NiHSi7mq8LHnl3cwGZlOdiumgFW4i0Ps712kXdpgRvuRRZN/sHMMp1ZPq8vpycEPMZufnDWxy ghwvICyJdUOy1g/eOBY+47XDGcZkywm1IhxX1vuHfSJh8PT4NmAYKwJpK3iQdHATmzs0nyly438UJ 8d8dssxew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMH0-0004Wx-IF; Tue, 14 Jul 2020 14:51:10 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGl-0004Q1-IR for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:50:57 +0000 Received: by mail-wr1-x442.google.com with SMTP id o11so22218687wrv.9 for ; Tue, 14 Jul 2020 07:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ihjHslCIw8qoMVK4GXrRB+3Lj/xZDniOVXUYfLOZNm8=; b=YEcBJ/q7/mLdEyofaH1QpMzFdOfql2c06Deu4Gj8zwMCMhKcM5c8YQYC+jEM7HJq2u liLKBjUuGd8RudZiUYzZrrWTRL/RaYpcFJ1xzgCLo9lbT2hEK4trRnz+BCDJx2QAz3M0 nIw/VRbG5eFVnIz7UzRsPMth8wn9XdhvZsGxmaOgGGldEVpyDiIZSKn/Gy1//wNd5tcF gelOWreE6XE15uo39TT7C5n8hnFfJCn8mhhn99cu5DUJMAYAL4RB1/HndMjU7qi3rhye brmqOvYtDeXs6fO08TuvEMIW3EMKQzskdg4lh+AhfPJMUzslv3vPIwI7fNtv9NhKbGcH adIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ihjHslCIw8qoMVK4GXrRB+3Lj/xZDniOVXUYfLOZNm8=; b=lE1NA/s/NTnGfRu8SM2lXU/LO1JJxpgBRWw4nLvjCzJirh9qJaOW51hyiBRVAhftJ7 BtczzvIuum/mU5tHHvQKUfIy9X15WIgGMBJ5uMeUelRC+jtjVzDUqSnmfjBbSidNEyQ5 iMRBhyEznk5kKZi7v2XTiOeza1Yb0dRl5ClaBVxjAUEU1dWAEx6eKK1x1LyTWVuBRkcY Lf8AJRuqCfdHKLHXzDd/o+c5v4JIEO01rz2PUu3KcC4naG7WEnbWwaUXN+d2NOzguZJ9 rqQf6/Oy42resEtKel3ngSov0+dMuDHBj1LVNqxFY5PpkSbOMbYDJQeMknbj/hDt7Jww ydIA== X-Gm-Message-State: AOAM533U5kNvw6oZr5tafC+8jen07sTd87qEr4aq8SL1ODF/JbByjbSh 0PIm5xPVTTxFjpyNmoe++tbQYg== X-Google-Smtp-Source: ABdhPJwzq69EoF6A0ryhfZcTCDHp9k1EFZj2+M3oKKC0bVvjPj1f1QUC3IU6l7A16+RPYZFneZO5UA== X-Received: by 2002:adf:f18c:: with SMTP id h12mr5882500wro.375.1594738254389; Tue, 14 Jul 2020 07:50:54 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:53 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 02/13] cpufreq: cpufreq: Demote lots of function headers unworthy of kerneldoc status Date: Tue, 14 Jul 2020 15:50:38 +0100 Message-Id: <20200714145049.2496163-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105055_656755_038ABBF3 X-CRM114-Status: GOOD ( 15.97 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashok Raj , linux-pm@vger.kernel.org, Jacob Shin , linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org, Dominik Brodowski Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Also provide missing function parameter description for 'cpu' and 'policy'. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/cpufreq.c:60: warning: cannot understand function prototype: 'struct cpufreq_driver *cpufreq_driver; ' drivers/cpufreq/cpufreq.c:90: warning: Function parameter or member 'cpufreq_policy_notifier_list' not described in 'BLOCKING_NOTIFIER_HEAD' drivers/cpufreq/cpufreq.c:312: warning: Function parameter or member 'val' not described in 'adjust_jiffies' drivers/cpufreq/cpufreq.c:312: warning: Function parameter or member 'ci' not described in 'adjust_jiffies' drivers/cpufreq/cpufreq.c:538: warning: Function parameter or member 'policy' not described in 'cpufreq_driver_resolve_freq' drivers/cpufreq/cpufreq.c:686: warning: Function parameter or member 'file_name' not described in 'show_one' drivers/cpufreq/cpufreq.c:686: warning: Function parameter or member 'object' not described in 'show_one' drivers/cpufreq/cpufreq.c:731: warning: Function parameter or member 'file_name' not described in 'store_one' drivers/cpufreq/cpufreq.c:731: warning: Function parameter or member 'object' not described in 'store_one' drivers/cpufreq/cpufreq.c:741: warning: Function parameter or member 'policy' not described in 'show_cpuinfo_cur_freq' drivers/cpufreq/cpufreq.c:741: warning: Function parameter or member 'buf' not described in 'show_cpuinfo_cur_freq' drivers/cpufreq/cpufreq.c:754: warning: Function parameter or member 'policy' not described in 'show_scaling_governor' drivers/cpufreq/cpufreq.c:754: warning: Function parameter or member 'buf' not described in 'show_scaling_governor' drivers/cpufreq/cpufreq.c:770: warning: Function parameter or member 'policy' not described in 'store_scaling_governor' drivers/cpufreq/cpufreq.c:770: warning: Function parameter or member 'buf' not described in 'store_scaling_governor' drivers/cpufreq/cpufreq.c:770: warning: Function parameter or member 'count' not described in 'store_scaling_governor' drivers/cpufreq/cpufreq.c:806: warning: Function parameter or member 'policy' not described in 'show_scaling_driver' drivers/cpufreq/cpufreq.c:806: warning: Function parameter or member 'buf' not described in 'show_scaling_driver' drivers/cpufreq/cpufreq.c:815: warning: Function parameter or member 'policy' not described in 'show_scaling_available_governors' drivers/cpufreq/cpufreq.c:815: warning: Function parameter or member 'buf' not described in 'show_scaling_available_governors' drivers/cpufreq/cpufreq.c:859: warning: Function parameter or member 'policy' not described in 'show_related_cpus' drivers/cpufreq/cpufreq.c:859: warning: Function parameter or member 'buf' not described in 'show_related_cpus' drivers/cpufreq/cpufreq.c:867: warning: Function parameter or member 'policy' not described in 'show_affected_cpus' drivers/cpufreq/cpufreq.c:867: warning: Function parameter or member 'buf' not described in 'show_affected_cpus' drivers/cpufreq/cpufreq.c:901: warning: Function parameter or member 'policy' not described in 'show_bios_limit' drivers/cpufreq/cpufreq.c:901: warning: Function parameter or member 'buf' not described in 'show_bios_limit' drivers/cpufreq/cpufreq.c:1625: warning: Function parameter or member 'dev' not described in 'cpufreq_remove_dev' drivers/cpufreq/cpufreq.c:1625: warning: Function parameter or member 'sif' not described in 'cpufreq_remove_dev' drivers/cpufreq/cpufreq.c:2380: warning: Function parameter or member 'cpu' not described in 'cpufreq_get_policy' drivers/cpufreq/cpufreq.c:2771: warning: Function parameter or member 'driver' not described in 'cpufreq_unregister_driver' Cc: Dominik Brodowski Cc: Ashok Raj Cc: Jacob Shin Signed-off-by: Lee Jones --- drivers/cpufreq/cpufreq.c | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 036f4cc42ede2..17c1c3becd925 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -52,7 +52,7 @@ static LIST_HEAD(cpufreq_governor_list); static char default_governor[CPUFREQ_NAME_LEN]; -/** +/* * The "cpufreq driver" - the arch- or hardware-dependent low * level driver of CPUFreq support, and its spinlock. This lock * also protects the cpufreq_cpu_data array. @@ -80,7 +80,7 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, struct cpufreq_governor *new_gov, unsigned int new_pol); -/** +/* * Two notifier lists: the "policy" list is involved in the * validation process for a new CPU frequency policy; the * "transition" list for kernel code that needs to handle @@ -300,7 +300,7 @@ struct cpufreq_policy *cpufreq_cpu_acquire(unsigned int cpu) * EXTERNALLY AFFECTING FREQUENCY CHANGES * *********************************************************************/ -/** +/* * adjust_jiffies - adjust the system "loops_per_jiffy" * * This function alters the system "loops_per_jiffy" for the clock @@ -526,6 +526,7 @@ EXPORT_SYMBOL_GPL(cpufreq_disable_fast_switch); /** * cpufreq_driver_resolve_freq - Map a target frequency to a driver-supported * one. + * @policy: associated policy to interrogate * @target_freq: target frequency to resolve. * * The target to driver frequency mapping is cached in the policy. @@ -670,7 +671,7 @@ static struct cpufreq_governor *cpufreq_parse_governor(char *str_governor) return get_governor(str_governor); } -/** +/* * cpufreq_per_cpu_attr_read() / show_##file_name() - * print out cpufreq information * @@ -712,7 +713,7 @@ static ssize_t show_scaling_cur_freq(struct cpufreq_policy *policy, char *buf) return ret; } -/** +/* * cpufreq_per_cpu_attr_write() / store_##file_name() - sysfs write access */ #define store_one(file_name, object) \ @@ -733,7 +734,7 @@ static ssize_t store_##file_name \ store_one(scaling_min_freq, min); store_one(scaling_max_freq, max); -/** +/* * show_cpuinfo_cur_freq - current CPU frequency as detected by hardware */ static ssize_t show_cpuinfo_cur_freq(struct cpufreq_policy *policy, @@ -747,7 +748,7 @@ static ssize_t show_cpuinfo_cur_freq(struct cpufreq_policy *policy, return sprintf(buf, "\n"); } -/** +/* * show_scaling_governor - show the current policy for the specified CPU */ static ssize_t show_scaling_governor(struct cpufreq_policy *policy, char *buf) @@ -762,7 +763,7 @@ static ssize_t show_scaling_governor(struct cpufreq_policy *policy, char *buf) return -EINVAL; } -/** +/* * store_scaling_governor - store policy for the specified CPU */ static ssize_t store_scaling_governor(struct cpufreq_policy *policy, @@ -799,7 +800,7 @@ static ssize_t store_scaling_governor(struct cpufreq_policy *policy, return ret ? ret : count; } -/** +/* * show_scaling_driver - show the cpufreq driver currently loaded */ static ssize_t show_scaling_driver(struct cpufreq_policy *policy, char *buf) @@ -807,7 +808,7 @@ static ssize_t show_scaling_driver(struct cpufreq_policy *policy, char *buf) return scnprintf(buf, CPUFREQ_NAME_PLEN, "%s\n", cpufreq_driver->name); } -/** +/* * show_scaling_available_governors - show the available CPUfreq governors */ static ssize_t show_scaling_available_governors(struct cpufreq_policy *policy, @@ -851,7 +852,7 @@ ssize_t cpufreq_show_cpus(const struct cpumask *mask, char *buf) } EXPORT_SYMBOL_GPL(cpufreq_show_cpus); -/** +/* * show_related_cpus - show the CPUs affected by each transition even if * hw coordination is in use */ @@ -860,7 +861,7 @@ static ssize_t show_related_cpus(struct cpufreq_policy *policy, char *buf) return cpufreq_show_cpus(policy->related_cpus, buf); } -/** +/* * show_affected_cpus - show the CPUs affected by each transition */ static ssize_t show_affected_cpus(struct cpufreq_policy *policy, char *buf) @@ -894,7 +895,7 @@ static ssize_t show_scaling_setspeed(struct cpufreq_policy *policy, char *buf) return policy->governor->show_setspeed(policy, buf); } -/** +/* * show_bios_limit - show the current cpufreq HW/BIOS limitation */ static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf) @@ -1616,7 +1617,7 @@ static int cpufreq_offline(unsigned int cpu) return 0; } -/** +/* * cpufreq_remove_dev - remove a CPU device * * Removes the cpufreq interface for a CPU device. @@ -2373,6 +2374,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor); * cpufreq_get_policy - get the current cpufreq_policy * @policy: struct cpufreq_policy into which the current cpufreq_policy * is written + * @cpu: CPU to find the policy for * * Reads the current cpufreq policy. */ @@ -2759,7 +2761,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) } EXPORT_SYMBOL_GPL(cpufreq_register_driver); -/** +/* * cpufreq_unregister_driver - unregister the current CPUFreq driver * * Unregister the current CPUFreq driver. Only call this if you have From patchwork Tue Jul 14 14:50:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663037 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 81585722 for ; Tue, 14 Jul 2020 14:53:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59BFA21973 for ; Tue, 14 Jul 2020 14:53:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KL7Xmx+9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QHrJMslm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59BFA21973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4g07HvrgdcKC0OnQJPA03psXTie9vp+nI0S/GldGUB0=; b=KL7Xmx+9O391uKtnD2HjgFiG9 Djiu5cE4otExAdmBmNZ720XiQ4pu0oYwJGf9/PK/H502WyZII+wLvD5X2qDl6sZDBa7RQdEOlxtPu KsTJH4HQ6x+X3k3iXevwEkerdD1HASj5n6/G2ubiuVb4BAsOM711rGEfvJzxvp1Lr+j41kUBUp9t1 cpdncVIB2SePSnJPQ96pA3uM0srjKy2dBGV90uRhuRF9MpKXVn0gphLzmcxxkLw3S3rePR/1FXdrU cEN/GjbV9Ot3DoXNwisI1TPU2j0APK5HwieqXy0r0t0q9YCjszYzDIFAevf2uS03HofLEy18BBBLl /+CJtHisA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMH4-0004YD-71; Tue, 14 Jul 2020 14:51:14 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGm-0004QY-9C for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:50:57 +0000 Received: by mail-wr1-x443.google.com with SMTP id s10so22128151wrw.12 for ; Tue, 14 Jul 2020 07:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JqiGjo2A+JuWYmJhOxUeBH7YynB0Z20iJW99N6uR5uY=; b=QHrJMslmP0Kh8UfmYvSOG0q4hByvfx/EPXrsCJO7U06cWI5RsbB6FO/K0J4OQ20T3j RBSFiYd9YHmUsFIbhn61Ge90cJT0vVd9vMRFr2EWRb1rkIHD8mMz/JY2ZZYwATz7auHu 18qgce0k8NfkRreMk/6e8YOBYMNHETPxUAHrQe2cFWQJRL/XweHeVtQEfMjN4YFvAnWL iIGlreeiHb8EF/eZQZCNRcHzlxKZv4+L5IkxmQFPUubbWI4G7B4xk0u1kk6T2CxnXRGo Jhw6lNuhbQ/AQS6p3QF5pvEy8QaJWxBEzyv1VQLjejUm4KkJTim9bBrnVEfdT59BlKQV Liyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JqiGjo2A+JuWYmJhOxUeBH7YynB0Z20iJW99N6uR5uY=; b=S7gUJhi4nhnLPmSYhshErZGT2YfFll0+wjeqQYBBqc+uzZZv9p3/CPz+TlsNTjGio6 9WWyBLuFmqCtGnKTUPX1krvUWk2G9fF0BdLIGAQYJM5XxtvbWe1TQhNNnxLkV40QBPfM 1wNWKJ0Rs17/pdTe+3WrA6SueJx1e0MeDHWU43k/ETpXN3W/tIn7/2L8BbRFWWrWHbQu T3aZUDAeN3AcnQN6BsJT3qGYySbMXl2xgEY15f1ejBt/DiSVwT0WQ/vpOuam9AeoNz/P gmylcw4V8o7n4lGcgMdA83gx350cO0sSvZlhKykdnNhzcbrmtmx1uw7Ly+gC2Hzy5lE1 TdsQ== X-Gm-Message-State: AOAM530QFVEsnxRkHo05FHmGGdEONXB/7+ZrIX/Y44cbSful+Yd9yYBc 2GVfun9VYhaJNLOhSqtPS3q7/chEKsQ= X-Google-Smtp-Source: ABdhPJz0D8DB83PkawksqyN2zvcSXy61SCN97inRz7exzjOwhX1N4sU7xjVlExKi+/mgYquJYu+oog== X-Received: by 2002:adf:fa8f:: with SMTP id h15mr6113893wrr.211.1594738255423; Tue, 14 Jul 2020 07:50:55 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:54 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 03/13] cpufreq: cpufreq_governor: Demote store_sampling_rate() header to standard comment block Date: Tue, 14 Jul 2020 15:50:39 +0100 Message-Id: <20200714145049.2496163-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105056_426234_60AEC140 X-CRM114-Status: GOOD ( 12.71 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Clouter , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jun Nakajima , Venkatesh Pallipadi , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org There is no need for this to be denoted as kerneldoc. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/cpufreq_governor.c:46: warning: Function parameter or member 'attr_set' not described in 'store_sampling_rate' drivers/cpufreq/cpufreq_governor.c:46: warning: Function parameter or member 'buf' not described in 'store_sampling_rate' drivers/cpufreq/cpufreq_governor.c:46: warning: Function parameter or member 'count' not described in 'store_sampling_rate' Cc: Venkatesh Pallipadi Cc: Jun Nakajima Cc: Alexander Clouter Signed-off-by: Lee Jones --- drivers/cpufreq/cpufreq_governor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index f99ae45efaea7..63f7c219062b9 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -26,7 +26,7 @@ static DEFINE_PER_CPU(struct cpu_dbs_info, cpu_dbs); static DEFINE_MUTEX(gov_dbs_data_mutex); /* Common sysfs tunables */ -/** +/* * store_sampling_rate - update sampling rate effective immediately if needed. * * If new rate is smaller than the old, simply updating From patchwork Tue Jul 14 14:50:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663035 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 040B3722 for ; Tue, 14 Jul 2020 14:53:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D015021973 for ; Tue, 14 Jul 2020 14:53:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qJ6p6PoJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vBZqRin9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D015021973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TcwSyx6grIjP+FwQt/tvZuzJS+WbNTvC8RICjV6zFeg=; b=qJ6p6PoJFZIKroy2Vw52D/nkn XoNMcTAxCLjJ3ZIqvno+2stGpBJrONybz9qcQ+HJFnsumKVyAndDm26Xp2ihVQZqThMyxaenltviY QbFOsIbOXjWCbT7KxxN29XtyOgcvraweEswNKSZTBJimzw/k5TVqyAhdhil6geQ0rQbA2Aey15rlG wF94gns3f+Zd7OeaP0q0+FzS7v/oYUwRURbqLY1TSETsac5YGKRy95WRFF1kC+yntQSU8kcUHFxt7 1gbG/c1mReTr1CXkPgjhsJpNmmeMO4tcNggh4KNZtb/LzCGFL9LBcVwMw2ku/X+W4Dn0P+UUuGxvT x7AlVDq1g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMHC-0004aI-Vd; Tue, 14 Jul 2020 14:51:23 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGn-0004R8-Aa for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:50:59 +0000 Received: by mail-wr1-x442.google.com with SMTP id f18so22197446wrs.0 for ; Tue, 14 Jul 2020 07:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CMXxo9aOlmaJXA2Fa0TTzO8LQVMEninajvd8D9uCCWE=; b=vBZqRin9ErymR0h6YWFtX6OzZP7QsHPxUOwJ1TB67Z1qz2iAYJvnsWx2gcLuhJy4lb hDDc4aeOkm27SRzf8X1k2WIAObsAJND5revrzkP/m7ZCMP80546Bxq3T3UndYTS8OzUC JRsd6UB7YHbFJbx8g2t1uiz5Y+e8rX83mYC50waDpkpo5tPFH0kwV8nCXZvv/pkzP297 KtwmqwGgdm6Um5BEKSCxhXmSf67vT0WeoxDQQEouLXVk2MTiwej9lYE4yeXcO2AgZFPY 1n2hO29e3beuwFoHJWMa6cOWi5ut2YKBxpnhv1OpHJLS9ZZ8+unvn3Q7bOKY5dKnNGed ooaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CMXxo9aOlmaJXA2Fa0TTzO8LQVMEninajvd8D9uCCWE=; b=Y1DhwPaFUAjvBztuDPFpszYlFPBexNh1EsAajHaWahrIirYuihA+CHkAPX5apiAvKy wgcVBAUkKvC62qEZ8cmxt1Mxp67AV1S71mWMfSoLukTKbci7xfgcQ063OAOJ93d8Oa/V fmnTOWHYmbRI9haq3syeyhl19YBeiIXmyXj4DE1U23+C9JS5HG5V96m7slSLfsdsKQmm +lZ1rH2BRCfmS5uvfhuThxkuG6z8wlF40Bet90l0YZYI39M7U7ET8Ufk5TBSEEv/mIsi hOd0YLMIC24v854PB8YyiVnIzihTlsyL13bIY5OTffkpFP8YTcaj5r3yJbZPHrT5DSBP Qjnw== X-Gm-Message-State: AOAM531wxHxAb9byn1yHQLX9AQvRp68qL+xvlNsT+tdWot9p7iH0Kmuz X6SGJvWtQhrIRGK/YECHTlb/Hw== X-Google-Smtp-Source: ABdhPJwYqf/NbTXIZQ6P2+Ae9aB7yAhOCiew0QjfGjYt6pXaaft/XHPCaQXykUjtuNfRA79JvHAIRA== X-Received: by 2002:adf:81c8:: with SMTP id 66mr6172511wra.348.1594738256436; Tue, 14 Jul 2020 07:50:56 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:55 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 04/13] cpufreq: sti-cpufreq: Fix some formatting and misspelling issues Date: Tue, 14 Jul 2020 15:50:40 +0100 Message-Id: <20200714145049.2496163-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105057_424655_6894F965 X-CRM114-Status: GOOD ( 10.65 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Lee Jones , Patrice Chotard , linux-kernel@vger.kernel.org, Pal Singh , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc format for attribute descriptions should be '@.*: '. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/sti-cpufreq.c:49: warning: cannot understand function prototype: 'struct sti_cpufreq_ddata ' Cc: Patrice Chotard Cc: Pal Singh Signed-off-by: Lee Jones --- drivers/cpufreq/sti-cpufreq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c index 8f16bbb164b84..a5ad96d29adca 100644 --- a/drivers/cpufreq/sti-cpufreq.c +++ b/drivers/cpufreq/sti-cpufreq.c @@ -40,11 +40,11 @@ enum { }; /** - * ST CPUFreq Driver Data + * struct sti_cpufreq_ddata - ST CPUFreq Driver Data * - * @cpu_node CPU's OF node - * @syscfg_eng Engineering Syscon register map - * @regmap Syscon register map + * @cpu: CPU's OF node + * @syscfg_eng: Engineering Syscon register map + * @syscfg: Syscon register map */ static struct sti_cpufreq_ddata { struct device *cpu; From patchwork Tue Jul 14 14:50:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663049 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 547FC1392 for ; Tue, 14 Jul 2020 14:54:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2935F21973 for ; Tue, 14 Jul 2020 14:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j/8xSC+l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Yr1SJcM2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2935F21973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P+S7kSkYk1LOUEDqATorED5Whm3l4GJW6OyjQILg2P4=; b=j/8xSC+l9mA422sY0fptdu8Dk LfHSYMO8yUzDPzltgPt36IkBG/fpPNIL277omWxMQ1fhBEWm42pPohl7fv54immwaCWcp6oGZuoMQ sdCh4ch0ZWh7bRQmszhAFnZqh5eX9h8KTqbKr/akM4OaU3eqGcbbgWpKnUAzlc4cwMH7jcr+fhRX2 RfoXehLhwyKpnBK3hojqHotQg2DzMziEiEFB183yC/7etrU3vucK58yRpP+hqd0EyaZXgm6W7tA79 Bj5jQB4tpJp5ZDKXbkwiefchYhRXhuhO061wIgVbDUmnA+5mDGO7VlHHdPEsqkz/68TGF3xlEWxo/ 5e90Re3Sw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMHL-0004dW-Md; Tue, 14 Jul 2020 14:51:31 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGo-0004Rf-GD for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:51:00 +0000 Received: by mail-wr1-x442.google.com with SMTP id f7so22196869wrw.1 for ; Tue, 14 Jul 2020 07:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sa7IFFvEjkUEYkKGNfZ4AaOfAhDNPotc0mtcZbr7pMU=; b=Yr1SJcM2AwK2hW8wKdiFtlaK6rKbZ3NlkGx8d1Od6cqVH4nDmmoGCDQVhLHIDws+3d 2OVvC3aJXzU/ZjRq+haMRmCsqS9W94aOftUL13uUTXk4ZnJIiwTbqrjSFcSQ6+MBToTA Wlf9HuAi0Aza+9dtw/LHZF7rOTCDvLKrgawrfm5e6w/OV2eflKYPT6fW2ypIM7ewVmNc 6sZcE8UtKJDkeu8wqVxcoXJajhBkeReoa/7FhnEB2BS2H5Z5vYRvhfarz4C2XXTsWwBv aBmWOuw/i4Vdi3oCKJV1Zdhv/857tPWI3NzjMDJuHyaPTGpybciaeB3NKBD0sTczkWGs so9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sa7IFFvEjkUEYkKGNfZ4AaOfAhDNPotc0mtcZbr7pMU=; b=Zx/j9KHUmVD2wu9s1Fn9vimXFgsX43jHWmQtOe8AVDE/iHJJ+2TOcwpDYQb2xQwDK2 C0eIL0z8iF5iqyuwSzE4vW8O+xkfLXflgxSlczfdBDwcDVtycyb33Jlr8TnRnXbpp6q5 ENiy7ds+T6n1ztmnB6Epils2c2zGmuNcq18t7GveVWUlbNA64qwh58NJQ/nQvbr/VF+X hnlbzXNzcYaR1lJVbw0tMgr/noFPrASJVuCzMKPTdEkQwqP3nqRQWsossPRDUGif9CdP gHWLoaetACe5q7k5p+1YT0DOC4EXPXgVQm+zzuX9i3rBCKQuCgIanMRpgomIfara0gnV S/pA== X-Gm-Message-State: AOAM533fJI7yBZIGRmuQaxuKc49SwmO+VAsrNsXHOekDgvG6HTmbE6Jc cPTPtYILyLTysm8mi1UJqr7eMg== X-Google-Smtp-Source: ABdhPJzNf9Z+WHkT0D9c7/YKzZVAjpjagqUFxoxaf/blhTxuH25LgfvUKpph8N2tIaWR9WV7qZZ8hg== X-Received: by 2002:adf:82f5:: with SMTP id 108mr6084464wrc.218.1594738257584; Tue, 14 Jul 2020 07:50:57 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:57 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header Date: Tue, 14 Jul 2020 15:50:41 +0100 Message-Id: <20200714145049.2496163-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105058_640239_4A03CBFC X-CRM114-Status: GOOD ( 18.48 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , Olof Johansson , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If function callers and providers do not share the same prototypes the compiler complains of missing prototypes. Fix this by moving the already existing prototypes out to a mutually convenient location. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes] 109 | int check_astate(void) | ^~~~~~~~~~~~ drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes] 114 | void restore_astate(int cpu) | ^~~~~~~~~~~~~~ Cc: Olof Johansson Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ arch/powerpc/platforms/pasemi/powersave.S | 2 ++ drivers/cpufreq/pasemi-cpufreq.c | 1 + include/linux/platform_data/pasemi.h | 28 +++++++++++++++++++++++ 4 files changed, 31 insertions(+), 15 deletions(-) create mode 100644 include/linux/platform_data/pasemi.h diff --git a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/platforms/pasemi/pasemi.h index 70b56048ed1be..528d81ef748ad 100644 --- a/arch/powerpc/platforms/pasemi/pasemi.h +++ b/arch/powerpc/platforms/pasemi/pasemi.h @@ -15,21 +15,6 @@ extern void __init pasemi_map_registers(void); extern void idle_spin(void); extern void idle_doze(void); -/* Restore astate to last set */ -#ifdef CONFIG_PPC_PASEMI_CPUFREQ -extern int check_astate(void); -extern void restore_astate(int cpu); -#else -static inline int check_astate(void) -{ - /* Always return >0 so we never power save */ - return 1; -} -static inline void restore_astate(int cpu) -{ -} -#endif - extern struct pci_controller_ops pasemi_pci_controller_ops; #endif /* _PASEMI_PASEMI_H */ diff --git a/arch/powerpc/platforms/pasemi/powersave.S b/arch/powerpc/platforms/pasemi/powersave.S index d0215d5329ca7..7747b48963286 100644 --- a/arch/powerpc/platforms/pasemi/powersave.S +++ b/arch/powerpc/platforms/pasemi/powersave.S @@ -5,6 +5,8 @@ * Maintained by: Olof Johansson */ +#include + #include #include #include diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c index c66f566a854cb..c6bb3ecc90ef3 100644 --- a/drivers/cpufreq/pasemi-cpufreq.c +++ b/drivers/cpufreq/pasemi-cpufreq.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include diff --git a/include/linux/platform_data/pasemi.h b/include/linux/platform_data/pasemi.h new file mode 100644 index 0000000000000..3fed0687fcc9a --- /dev/null +++ b/include/linux/platform_data/pasemi.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (C) 2020 Linaro Ltd. + * + * Author: Lee Jones + */ + +#ifndef _LINUX_PLATFORM_DATA_PASEMI_H +#define _LINUX_PLATFORM_DATA_PASEMI_H + +/* Restore astate to last set */ +#ifdef CONFIG_PPC_PASEMI_CPUFREQ +int check_astate(void); +void restore_astate(int cpu); +#else +static inline int check_astate(void) +{ + /* Always return >0 so we never power save */ + return 1; +} +static inline void restore_astate(int cpu) +{ +} +#endif + +#endif /* _LINUX_PLATFORM_DATA_PASEMI_H */ + + From patchwork Tue Jul 14 14:50:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663047 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1952E14DD for ; Tue, 14 Jul 2020 14:54:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5D9321D6C for ; Tue, 14 Jul 2020 14:54:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uDhiThsY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YaPkEvwk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5D9321D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6KD8ZHZymTvMMQE9BgSrJM/6V61X5+CCgtK66w1u0Oc=; b=uDhiThsYAYwq2vCDf9kfOZhm1 4MMTfwScfFTYUFQsVxflpDYIsULR9eUobYYdR9QTJ6w4Nt9pTWK043+dfc9rq1SUfPX5huyRprubf iL2UwtDfcX8cwt4sHfneohp7xkKTdyujC9nprI335dXPUxzXId/tlV2j1eAtztMaUsSSJC71FWqJd MzPRfnlqcwT9c52zz+vAlLn5tq0BsaqsRGJWz+mY8UQ1JMZohkpfvyEk0eDieHH4MHBTiRvtmHyh9 jcAcoAxpj6RWvE92vjQCXUYFhelKAfVftmG58GNsGu4/lEprFo4LcY0QsHu7wyKFB/ypFAbf51GLQ LP6O3KN2Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMHS-0004gE-4s; Tue, 14 Jul 2020 14:51:38 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGp-0004S9-Gk for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:51:02 +0000 Received: by mail-wr1-x443.google.com with SMTP id a6so22168260wrm.4 for ; Tue, 14 Jul 2020 07:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6pwz2ffWzBJ40s4OQQcEx95BGb6IW3I0JlI9ImusOaw=; b=YaPkEvwkRMrXCrAr3GD3Lq5esr1zvrFowgkVtFLyXE9aeQ+n6qHPlhaUhK4AYO4xUs hm5M2HAtd3m5JHJjY2xKUYjnMD1tdtfs5OPz2xXGUBp2zizzY0ZWTKvQ9U0A5cXFSIRJ j3yMdMtUprKvhoEl35KqZAv8e37m9RfHJ9JDTy287GDX+MDLsV7UmkJ7LDgRcd0qsysv Ia93V3kAPH4VDyioq5fO47gOCGnLqoR2QLu1mPSgJAUAUCITRKMczfB1Ec4oXyA2jWHx PQLY4by7vk9xQhpkcw3oZfR/uB2heai2vAqu8clRrz2QEmp5oM3aCK3aViE9BDI4b5mz 3u7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6pwz2ffWzBJ40s4OQQcEx95BGb6IW3I0JlI9ImusOaw=; b=WvMg4MLKfE3J4t1CJbCo/C7VL+pBVN6dYzId3vTqtByvPFTXCa9+Ho4YWlOX1Z6dVe m/qWs71DYkkBmABoiftqY/IUK/BqhWk1XsRHtMRaiPpK9Q052UWzWCL5nwHXH7KsDYgA cT1Gi+3thBiwayzRodzWjfgaZZk3nDVuXxwCEWyzhXTRsEXeMZ3nP7NTkvgtK0ibiYKB /b/fnYxkpmllaFwZY+yZYnmDz8lG6oWEI1hxCMF1nXEVnJSe1SJyNHDlQDxZ/zRqi+iv ccPZgknGwtE9Vqszju653Hvvxm0PceiMGcSCoXccUF2JO40TKicNYQo4t26JidVsGVfi 6Kvw== X-Gm-Message-State: AOAM531AZL/QxSgLNVWXlFdtGOW8jA94UkwBIMFaxxbAesdUq7si3BW9 BtEXhyquS8fkFx+LJTRjE3edFA== X-Google-Smtp-Source: ABdhPJxR1XkWPEdO/OToyZfeyPk6VSF/2G2O+HfpfRXS3rTqGgoQ4md522X2INCeZPPwNAHNuFWGZw== X-Received: by 2002:a5d:650e:: with SMTP id x14mr6401946wru.187.1594738258660; Tue, 14 Jul 2020 07:50:58 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:58 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 06/13] cpufreq: powernv-cpufreq: Functions only used in call-backs should be static Date: Tue, 14 Jul 2020 15:50:42 +0100 Message-Id: <20200714145049.2496163-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105100_505569_D15DB793 X-CRM114-Status: GOOD ( 14.44 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/cpufreq/powernv-cpufreq.c:669:6: warning: no previous prototype for ‘gpstate_timer_handler’ [-Wmissing-prototypes] drivers/cpufreq/powernv-cpufreq.c:902:6: warning: no previous prototype for ‘powernv_cpufreq_work_fn’ [-Wmissing-prototypes] Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Viresh Kumar --- drivers/cpufreq/powernv-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 8646eb197cd96..068cc53abe320 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -666,7 +666,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates) * according quadratic equation. Queues a new timer if it is still not equal * to local pstate */ -void gpstate_timer_handler(struct timer_list *t) +static void gpstate_timer_handler(struct timer_list *t) { struct global_pstate_info *gpstates = from_timer(gpstates, t, timer); struct cpufreq_policy *policy = gpstates->policy; @@ -899,7 +899,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = { .notifier_call = powernv_cpufreq_reboot_notifier, }; -void powernv_cpufreq_work_fn(struct work_struct *work) +static void powernv_cpufreq_work_fn(struct work_struct *work) { struct chip *chip = container_of(work, struct chip, throttle); struct cpufreq_policy *policy; From patchwork Tue Jul 14 14:50:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663053 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4D46A722 for ; Tue, 14 Jul 2020 14:54:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2598121973 for ; Tue, 14 Jul 2020 14:54:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vIToKh3w"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oan2KmRn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2598121973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eH8eXSIk1YGoLFo12st+ZqnwAbNp0M0JtpPBNr0dnwg=; b=vIToKh3wYV3GpGoAl+GbBW5xZ 0m3ytmDyF0l5NDwJMJoZxrEblaEPeNJjxza8D6GXD/4kHbRs+gXltqI5YvQ9omPezkQiYs9+M/3Aq jVRKy3B0x6fCWj3dhow4obASQq6MDwjqt2xz9OpYd8K+C3S+ot70xHGCAoDenwyNfZIYWZeFYFTq4 C04/ItZBzIKAbn0G2/udfgCp1WpRTmjUlK4xo4SXzOxDBJ+dg18/PyxPx2BCd/YEs5EYNbsdJuEli dT8FMLl4aaYFz74Qf6z2/bzxEIpbBd7JT+vJgRlvw5ivQ6RcZsN06ll1AmHBfejFJWRhXjwXr2R6F EaaljLklA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMHc-0004kE-Ox; Tue, 14 Jul 2020 14:51:49 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGq-0004SA-Sc for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:51:02 +0000 Received: by mail-wr1-x443.google.com with SMTP id k6so22174874wrn.3 for ; Tue, 14 Jul 2020 07:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=87fYCk78HvnEcHEWI8252kKdAErne/JGHZaNtIMV4DM=; b=oan2KmRnlmziHA33dlWeKxYSz99uymPx4Upt4DdPZqzkE7Pn6aNbVFcS4EqijPPT1b epm+Z0+gabomO1htq+2nGq7mfGaa4AQjVGvinv2W7rG4Yf4zrX1lLQEsQqp/IxzwJsZK KsU3lyQE4BSuu7m+y0e17j3xQipWcaeFlmiHFAjUhm+t5oiOf17IImiudspjVz2Gr4Np +3ggtvvQ+Y0p36Roz5hpma2QxOSlmCwdpxC50LPbuzXaY/z9L0dMBVjNrKdi9Dd18Pfz bjl9EDQ3qx3ytSsCNXEZ3bn0ERkPJPoJyn67O07VbJKTig+xN3S9JouZaVPvYAKfp92V EHyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=87fYCk78HvnEcHEWI8252kKdAErne/JGHZaNtIMV4DM=; b=LJr3KPhEw+1RnvLuJyylECKXG7eGutYpR8iShYjDYIf+9RttCH6wz+AjQMw35ku2O5 aLPZ246EVXAfNOKypM78Z4rMkXMIGZEj4tGfm5UY4srpkSqXdl3S6zes4TGbsyP44cOn DqHm15USSakBz1I4/d5X5+04d9QK2c4Xhd9ApqQgBp6w2NYWpgA0kkqJH6yGaNOpj4YN Avhc70PGWKA2L210Nv2dHVwkJqHluOIPn5jNqaBnHqf2ka3E5CiuDtj+t8GPxhRRDueU t4masPQXvtmrEJtKsfofIOvU5atCHErwsDu7mNGUAU7JWq8Cv9NIHE1NB5HbWWePrGPQ MkGg== X-Gm-Message-State: AOAM531CeqfmiWALtbeu3zjjLZufkCrBmRTkx1t1Dpjfwj1QimjWWxHW E89N9OtNmeRp3Wxfci6A67d00g== X-Google-Smtp-Source: ABdhPJyholUMWz/5/8DrxA2fX1xTdZCmREnCcugfLGT0R3+RARPOD0BiRca7mzrYbDfRATUmPfhpCg== X-Received: by 2002:a5d:6990:: with SMTP id g16mr6060756wru.131.1594738259994; Tue, 14 Jul 2020 07:50:59 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:59 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 07/13] cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues Date: Tue, 14 Jul 2020 15:50:43 +0100 Message-Id: <20200714145049.2496163-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105101_016305_0E905DF0 X-CRM114-Status: GOOD ( 14.79 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Repair problems with formatting and missing attributes/parameters, and demote header comments which do not meet the required standards applicable to kerneldoc. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_lpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_gpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'policy' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:182: warning: Function parameter or member 'i' not described in 'idx_to_pstate' drivers/cpufreq/powernv-cpufreq.c:201: warning: Function parameter or member 'pstate' not described in 'pstate_to_idx' drivers/cpufreq/powernv-cpufreq.c:670: warning: Function parameter or member 't' not described in 'gpstate_timer_handler' drivers/cpufreq/powernv-cpufreq.c:670: warning: Excess function parameter 'data' description in 'gpstate_timer_handler' Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Viresh Kumar --- drivers/cpufreq/powernv-cpufreq.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 068cc53abe320..2e5a8b8a4abaa 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -64,13 +64,14 @@ * highest_lpstate_idx * @last_sampled_time: Time from boot in ms when global pstates were * last set - * @last_lpstate_idx, Last set value of local pstate and global - * last_gpstate_idx pstate in terms of cpufreq table index + * @last_lpstate_idx: Last set value of local pstate and global + * @last_gpstate_idx: pstate in terms of cpufreq table index * @timer: Is used for ramping down if cpu goes idle for * a long time with global pstate held high * @gpstate_lock: A spinlock to maintain synchronization between * routines called by the timer handler and * governer's target_index calls + * @policy: Associated CPUFreq policy */ struct global_pstate_info { int highest_lpstate_idx; @@ -170,7 +171,7 @@ static inline u8 extract_pstate(u64 pmsr_val, unsigned int shift) /* Use following functions for conversions between pstate_id and index */ -/** +/* * idx_to_pstate : Returns the pstate id corresponding to the * frequency in the cpufreq frequency table * powernv_freqs indexed by @i. @@ -188,7 +189,7 @@ static inline u8 idx_to_pstate(unsigned int i) return powernv_freqs[i].driver_data; } -/** +/* * pstate_to_idx : Returns the index in the cpufreq frequencytable * powernv_freqs for the frequency whose corresponding * pstate id is @pstate. @@ -660,7 +661,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates) /** * gpstate_timer_handler * - * @data: pointer to cpufreq_policy on which timer was queued + * @t: Timer context used to fetch global pstate info struct * * This handler brings down the global pstate closer to the local pstate * according quadratic equation. Queues a new timer if it is still not equal From patchwork Tue Jul 14 14:50:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663045 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02522722 for ; Tue, 14 Jul 2020 14:54:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE91E21973 for ; Tue, 14 Jul 2020 14:54:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SICWjc4g"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kw0j6YyJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE91E21973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lUhq4KIMoMjb7Klp1PsrsqYcowfS9aLrOhnJZD0gFhg=; b=SICWjc4gNQRMiJ9kgHXAZti+X JZZrrs9OCvixbpkKGqgpiZ0ivMbiUb8Z2mfcmir2SFzu0e0QOy7jAAg8DgYLCQL8KXj2ABuuRp9LJ b8d3nsVj3MIzg6wryPb0hnyQy766ZhGx8SfWSWEHr3q62FMMGXI7bUNcVg2VTy2oZFbjrz3Jq2+hV Amobly8BVR8FPX2v92Z/E2kGUzmcyeI6+64vTzFjSGeMIH0ywmThdaCUl1mY7J+EI29XGci10yf7N /tNMNShMtk1KvOIq/GwCH/CdfvUY37f5nGApHc8rlat0ExUZoePtWohSyF+SpQVs88aUSHVD7oWuo I0FOpeyBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMHl-0004oU-Um; Tue, 14 Jul 2020 14:51:57 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGs-0004T1-2H for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:51:03 +0000 Received: by mail-wr1-x444.google.com with SMTP id j4so22189251wrp.10 for ; Tue, 14 Jul 2020 07:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oYBUe5BwYsr/R2phlHidQsm6+vzt4cxxnkc0JimKqEE=; b=kw0j6YyJsiIk2n3yX5+GkWGHEPOb5rpZONh1AHETutb3Im0RIS6q17btR7I5qt+Y3G Cr1hhv/Kwb4+WIS0DNHRjmc1aw52YDL0xbevlEKg7TJLPfD4wiKMTStgnlv9QSESRuy2 ud15ingoco58gPEiG8JkpQosiAAkovGqjbIlBoloUt9rOcx2anemoSqTP2ATqz6NrUQt tulqxTx3pqJ1mnmLEsWngWkqghXlkZjKVXZb6FZTVVe+ZC2J0MR1r2jQ+V86qR4QnhyQ LWrTAK+0ruiFBAkkrUIWJlkdAkSpEDrtau+/OBkjXFh5ifl7sURfmnAjGYLKjcVCRWk7 J80Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oYBUe5BwYsr/R2phlHidQsm6+vzt4cxxnkc0JimKqEE=; b=HyfxO6F2tLIxULdL8Dik18Ae6bzESbJJDPtxzDaJC5Ieed1sunFh1ZIMDIViwhc9si Oz+ZiCNCZByv6WlMS1075PafCGFnSpO70NNy8fKcNW06n1Ta3nmn8oFGTwYFFoQ84lQe ggIZNvbc9LM8Gm+of7H7J8Nb0bns6arHXG6bgFxZKlbxyvwDC6fMfulVIT3x/DKN2yge 3Fo6qKEpEXCamMaERcnHubnQ3a5MisXJiEaZSlKkeyPk29g2a+a3thcIHyoNu7U7+SxS z8RstmSu3izHzAFGkdeJuWUXwxma42VuyXGvvSA2UNLxkv+B3zlx2XWyJsFGkjhHhg62 VQXw== X-Gm-Message-State: AOAM530kr717RHQEGvDWis8ZnT8Lco6qwSdy6t1l8fOCpkQRb1fn5M5s Ve5PQ7TzkI6hfMCNpiygD2S9BQ== X-Google-Smtp-Source: ABdhPJz8xLGj6PyHHnWxNk1fB9l9swenCZNjFdqaoHR4cK01bpPaXCLBFCFf4j5xacHn27d9sC7Xrw== X-Received: by 2002:a5d:5151:: with SMTP id u17mr6280720wrt.154.1594738261236; Tue, 14 Jul 2020 07:51:01 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:00 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 08/13] cpufreq: acpi-cpufreq: Take 'dummy' principle one stage further Date: Tue, 14 Jul 2020 15:50:44 +0100 Message-Id: <20200714145049.2496163-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105102_205875_277659E9 X-CRM114-Status: GOOD ( 12.35 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Denis Sadykov , Andy Grover , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Diefenbaugh , Lee Jones , linux-arm-kernel@lists.infradead.org, Dominik Brodowski Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If we fail to use a variable, even a 'dummy' one, then the compiler complains that it is set but not used. We know this is fine, so we set it to its own value here. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/acpi-cpufreq.c: In function ‘cpu_freq_read_intel’: drivers/cpufreq/acpi-cpufreq.c:247:11: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] drivers/cpufreq/acpi-cpufreq.c: In function ‘cpu_freq_read_amd’: drivers/cpufreq/acpi-cpufreq.c:265:11: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: Andy Grover Cc: Paul Diefenbaugh Cc: Dominik Brodowski Cc: Denis Sadykov Signed-off-by: Lee Jones --- drivers/cpufreq/acpi-cpufreq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index 429e5a36c08a9..d38a693b48e03 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -247,6 +247,7 @@ static u32 cpu_freq_read_intel(struct acpi_pct_register *not_used) u32 val, dummy; rdmsr(MSR_IA32_PERF_CTL, val, dummy); + dummy &= dummy; /* Silence set but not used warning */ return val; } @@ -264,6 +265,7 @@ static u32 cpu_freq_read_amd(struct acpi_pct_register *not_used) u32 val, dummy; rdmsr(MSR_AMD_PERF_CTL, val, dummy); + dummy &= dummy; /* Silence set but not used warning */ return val; } From patchwork Tue Jul 14 14:50:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663039 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C627722 for ; Tue, 14 Jul 2020 14:53:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6476021D6C for ; Tue, 14 Jul 2020 14:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Glf/c224"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t6daXhKQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6476021D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=82dioECext+78vXoTJo2ly9TWPjgH/wdB6r9ego5eyk=; b=Glf/c224d5IRNc4y/EDCwPJXG UqiRffYOdzQ4edLEOhpGuEFWVxfK/G5TqaAPMxofl9GZizBt2/8/5b3/9GGcFYFC0w5PTDMBl9Kxx 4cARAHkDsKNoK5YiWWK82VnNxWYAYc0Zr2EvHs5po1H+BnOEEAMrPR4wrE2QKbevLs+zm9utCp7nR PuBNW2HLdn0UjnaDcwbkXsgeBtHnmN4XFBYgSoD2hiQfaH0PUr3JICjcd7RdggKE6CoBntU9mtH0M 42ZNAT0FNoF2uY2HTYQBBtZUEl66QwrvKY5IFN0NjbfbQCVMovyI1j+JQ5t3UDOoPOSLMKEO6b4ks Musrzitlw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMHq-0004py-As; Tue, 14 Jul 2020 14:52:02 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGt-0004Tg-BW for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:51:04 +0000 Received: by mail-wr1-x443.google.com with SMTP id k6so22175173wrn.3 for ; Tue, 14 Jul 2020 07:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ov8mkUGBo3MkEAlxc2kYHhcoEYaszqjEJyXig/T1tiI=; b=t6daXhKQWGdOTczm6qL35xc0fppGdojfryPU3Yy+9b2M42Lz9lDVXu8Z+oQPer8/wn 66lWCuWHscF79MDsDWoRINbL+J3DI3JwRywYtB3y/yDN2fYApJvODwK9fVhtnK1i5TrR 6PwVmrMyZL9diMFGKxmlNMcb/U/bTKAABaKdcywqnPyqnVG8Qf3AUAoJpdZ/2pUkQHF/ JNbL4G/kUrCSGBLIjO7xXY9Eqm4CKdYlM/6mJNq99ZnUxi1hI/38z3KoHgnowKzwqcF5 DuKh916+E7/PuxfrO02rdsDIELOoLKt8hH+gN8cgun3vPBAXSTxr4R8r6rhWs+4/y9qb Zpdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ov8mkUGBo3MkEAlxc2kYHhcoEYaszqjEJyXig/T1tiI=; b=fDCuDhHSH8fQab4lmjmIqm/EyUO9LdOpM+cLfv7MxVY6B1W6rEWDImr55Y4QGIKsar bU5GL9VbGN2Fpsb+5jQuy4K1hh0iYFQsotKF0KJaLxeLA6YUKWx4j8jc/yhNoThEdpZm k7KGZScO2TFW39EADtiqtq0Ze4LV6AvMDuWZ36BosFEnxVNaDFQbzdXwFxDTux9GcRx+ btsZosJ/NMVkeJ7ufqtCJdQnfwhvHaQ6Fu+fPYvP6E+6IYZ6uPotlZo7oEJx/QCDicp6 OLOg5YFiTGVkheHPMAL2vV6s+qf64S2K2URz1KwRm4DRkQJSEgOy0g3wHCeHBFG0MhtA z72g== X-Gm-Message-State: AOAM531juSknJs5LuBoi5vVVfC3DHz9Usca5KoLg3L61LF5h2knNOy6d bQIAvH7rc3PnxtI2ki9CY+fg6w== X-Google-Smtp-Source: ABdhPJwXO/T/LF1NI7ZgnyJQbsl2c1EL4iDXIFBRbgGKB7Pv7E0G1E9GvN5Ys7i50Jv2Wiu8MXJf4g== X-Received: by 2002:adf:f18c:: with SMTP id h12mr5883468wro.375.1594738262394; Tue, 14 Jul 2020 07:51:02 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:01 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 09/13] cpufreq: acpi-cpufreq: Remove unused ID structs Date: Tue, 14 Jul 2020 15:50:45 +0100 Message-Id: <20200714145049.2496163-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105103_505505_5B4B20EE X-CRM114-Status: GOOD ( 10.73 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Denis Sadykov , Andy Grover , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Diefenbaugh , Lee Jones , linux-arm-kernel@lists.infradead.org, Dominik Brodowski Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Can't see them being used anywhere and the compiler doesn't complain that they're missing, so ... Fixes the following W=1 kernel build warning(s): drivers/cpufreq/acpi-cpufreq.c:1004:36: warning: ‘processor_device_ids’ defined but not used [-Wunused-const-variable=] 997 | static const struct x86_cpu_id acpi_cpufreq_ids[] = { | ^~~~~~~~~~~~~~~~ drivers/cpufreq/acpi-cpufreq.c:997:32: warning: ‘acpi_cpufreq_ids’ defined but not used [-Wunused-const-variable=] 619 | static const struct acpi_device_id processor_device_ids[] = { | ^~~~~~~~~~~~~~~~~~~~ Cc: Andy Grover Cc: Paul Diefenbaugh Cc: Dominik Brodowski Cc: Denis Sadykov Signed-off-by: Lee Jones --- drivers/cpufreq/acpi-cpufreq.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index d38a693b48e03..fc68f13352695 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -995,18 +995,4 @@ MODULE_PARM_DESC(acpi_pstate_strict, late_initcall(acpi_cpufreq_init); module_exit(acpi_cpufreq_exit); -static const struct x86_cpu_id acpi_cpufreq_ids[] = { - X86_MATCH_FEATURE(X86_FEATURE_ACPI, NULL), - X86_MATCH_FEATURE(X86_FEATURE_HW_PSTATE, NULL), - {} -}; -MODULE_DEVICE_TABLE(x86cpu, acpi_cpufreq_ids); - -static const struct acpi_device_id processor_device_ids[] = { - {ACPI_PROCESSOR_OBJECT_HID, }, - {ACPI_PROCESSOR_DEVICE_HID, }, - {}, -}; -MODULE_DEVICE_TABLE(acpi, processor_device_ids); - MODULE_ALIAS("acpi"); From patchwork Tue Jul 14 14:50:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663057 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 46F49722 for ; Tue, 14 Jul 2020 14:54:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F17B222C8 for ; Tue, 14 Jul 2020 14:54:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3PQDtO/Y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MHULfHb/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F17B222C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8UPKh99E7X3XH6i9Ty/DZP1FeLQ2XgIgn+JXa1+46ZQ=; b=3PQDtO/YfsoGD4bWDQNJd7vs6 1fxGjZMwtZvoc3l7vUae3DGvJA/HjkJDBEkkskMGtaen0UEt0sSTLv3fQNrLO734HH1c/SgGZvQ9d 2TEP3oTcE97nOdqrOamu+8o0gENtxMbjYS41rgpiMODiW+n9G1G5Tj81LFfUqCtlwDL239iB0HtAe PAKidHGy1carnTlU+Peitb/YPqZyAcxE305DjKYA0iKQs5NNA8BfMvAUhPmabW5pmQjdHubyNpu31 6C2AfB2zXQtR+4GLCqCT9rBVaCMrIv7Kc2Jw/lOYEpd4ijuLO43NIgmanYQKHmTBy8a6b3m0YaHU8 H10+PY+7w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMHx-0004tR-1f; Tue, 14 Jul 2020 14:52:09 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGu-0004UK-If for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:51:06 +0000 Received: by mail-wr1-x444.google.com with SMTP id z13so22179399wrw.5 for ; Tue, 14 Jul 2020 07:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xAmlwZf9FF5B+fNw3FLwoudWl6EScDCCxEL7TtadPBI=; b=MHULfHb/qq2DdPxVtZdND+73JTuMCaIpc5HvzUeGk6dbIqMsJzHFttAq159KGZhl+E uc32b1iIIALtw+ydZp8fFCVf22oX/ZdWCauKax3caYhdVkySmLHWnfqsCdIC72Zkwchc 0HSG5fFKVugqRl0OpEK9Pw86gfD9D3MreYxK7XhNMk+0Inko/tj6sj1308edItjH6uo6 E5+EcxAVfNcEsuIU/t2HPJ2VjGAKGSOfJyddVycUripolPiZXCNSEbtHOJSdnPoQdyBC z5kKNMEq5B9YxP3pmvcBN6urA6s4KBar6ixz9U4qx3EMF/Ca6qnZHRoNaYFvLzVkUo89 chLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xAmlwZf9FF5B+fNw3FLwoudWl6EScDCCxEL7TtadPBI=; b=fAcKr9U/WrDVHmspgaEhcVv4f3n9bwDRREpL+R0mZMwj04ppNsP6doGYQCoYeZc7gx bEGgcJHpPlLq54XeefpQyLw81C7sCb+/znud2QkMmZWaNEj3sXeX9OshSrISJWmrP9BC s4r11X4mF6XC1YV6dKJi8+m8W1U/FMjWcR86wcE69RnplovdZt8PYLww4Vk5N9x01Bhj zuIDPUad6YRNKU0wHxdRs4TDiYCw+n8BVWLL+5bsoKLCUahjIBaKhpGXFIHAp0LWHLYC OUBIpfgRwoXhpDEomb/wd4aW5ZXhYRp6MO0msJJvpmNo6vTdsLodnH7ER8mmplavq2eL pPKg== X-Gm-Message-State: AOAM532X+0//9BrmSXprwEuYmzMYu37Ld6+JldBdfsq62n8U79qhxF6A GBFGsJxJ3ZHGUuhnRNguET95RA== X-Google-Smtp-Source: ABdhPJyoziaq49v5CTUiEUg6/TO+E0QrGY8bGLFPGBYZLqb4ZcvlqiI8gGMCMznhtGm8VhY3kHmpDA== X-Received: by 2002:adf:82f5:: with SMTP id 108mr6085256wrc.218.1594738263620; Tue, 14 Jul 2020 07:51:03 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:03 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 10/13] cpufreq: powernow-k8: Make use of known set but not used variables Date: Tue, 14 Jul 2020 15:50:46 +0100 Message-Id: <20200714145049.2496163-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105105_070239_9D2EFC19 X-CRM114-Status: GOOD ( 13.17 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Paul Devriendt , Andreas Herrmann , linux-kernel@vger.kernel.org, Mark Langsdorf , Pavel Machek , Lee Jones , linux-arm-kernel@lists.infradead.org, Dominik Brodowski Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If we fail to use a variable, even a 'dummy' one, then the compiler complains that it is set but not used. We know this is fine, so we set it to its own value here. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/powernow-k8.c: In function ‘pending_bit_stuck’: drivers/cpufreq/powernow-k8.c:89:10: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable] 89 | u32 lo, hi; | ^~ drivers/cpufreq/powernow-k8.c: In function ‘core_voltage_pre_transition’: drivers/cpufreq/powernow-k8.c:285:14: warning: variable ‘lo’ set but not used [-Wunused-but-set-variable] 285 | u32 maxvid, lo, rvomult = 1; | ^~ Cc: Andreas Herrmann Cc: Dominik Brodowski Cc: Pavel Machek Cc: Paul Devriendt Cc: Mark Langsdorf Signed-off-by: Lee Jones --- drivers/cpufreq/powernow-k8.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index 3984959eed1d5..b76df81044c4f 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -89,6 +89,7 @@ static int pending_bit_stuck(void) u32 lo, hi; rdmsr(MSR_FIDVID_STATUS, lo, hi); + hi &= hi; /* Silence set but not used warning */ return lo & MSR_S_LO_CHANGE_PENDING ? 1 : 0; } @@ -292,6 +293,7 @@ static int core_voltage_pre_transition(struct powernow_k8_data *data, rvomult = 2; rvosteps *= rvomult; rdmsr(MSR_FIDVID_STATUS, lo, maxvid); + lo &= lo; /* Silence set but not used warning */ maxvid = 0x1f & (maxvid >> 16); pr_debug("ph1 maxvid=0x%x\n", maxvid); if (reqvid < maxvid) /* lower numbers are higher voltages */ From patchwork Tue Jul 14 14:50:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663043 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 00E2D1392 for ; Tue, 14 Jul 2020 14:53:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBB9421973 for ; Tue, 14 Jul 2020 14:53:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rLG0z4Dw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qjP2GZD7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBB9421973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IaO5u30OrjEyHDsL+gJvlhTvWdoV1EfZHuXDiD7mUFM=; b=rLG0z4DwxgC4g9ccqE8C3AgsJ aOp7hNHr/qtNPO7I8OxPIbd7pTa8T03iYp5AS4quEEoqcIG2/zfEyUSM+k0wtfyMQp3tMIVKwKGXt DQNejOzHgvpSeRZfXBNDg++IcVZbj6j0NDtvNkNRu70sS7z5/mIULARF7iiv1SJT6K55Mo3/c0Kg4 nfMx3E3TnuI8B8NGVPMXXVJsowQ05IOgdadLRtrvTSbQQkVNgBQvzk4JFGi2wbhLxRuf2/1MY8BJY Qq8kF7y4qCZSngCcLbLGb+yKw8x8XrqmcsbZE/rY/EY5NxDprzmxfBCjW85ajjvZkpMaJo+Lhz2RA 6AU461Tnw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMI1-0004wJ-D2; Tue, 14 Jul 2020 14:52:13 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGv-0004Uo-OM for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:51:07 +0000 Received: by mail-wr1-x444.google.com with SMTP id f7so22197719wrw.1 for ; Tue, 14 Jul 2020 07:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c4FLx3muVHP2pCB5GbFp6A725ffqNGbokYtDZodR17k=; b=qjP2GZD7DEKVihUDEr8DOQw2jWLp1ateuBsMjM0zK6Bb2UqoHJmPYlUHozDy416wNM WrAuxkpdR4itLlHHdt6zK11R6J+YF3H2X9qJZ66q2VApdxJKRjggHHHabWQwZw7hB96T QWs5bcfcqHQm4RaN+IvzHqT8YkR/SDeIgCjE/O23h5GB6yX7uF3f+mu5tH4VFffzfF2E fIKqvH4tnupS9kNadhZE35Og9MwXuvniL9jmbgbMP0p9qLqc/WadErfR6kfmfJxcmI4T vuRdQt4/I+wCmwLpf95BYtk6T5qUhTEM2vcn+XQP1s8jt4AyNsu7U5RSJOLSG0O1B47Q SZtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c4FLx3muVHP2pCB5GbFp6A725ffqNGbokYtDZodR17k=; b=s+YmeDxTTwm4H065eTAjEM/tMDN9Hqbl7HDqv254+L9dpOMbdBqf1x3WGTJipl3TP+ tphnzH6wUJ7H9qC1mTTB70YVAXz++1ZEp9X0hgIaKuOW1o7pmSPrCg1CjeMZ97gncRCk rvMewBWcHt/NUlsycTCcvon84e078NV12n4Czwo3+M3P/iA0gqBghl5LKM9AUu49cMrl B1cXU88JgTHDPU8cH88VmZm2VNU6s6ChzKbb3RQXPIvNaY476TrcWp23ShRBJ6NFvOxE qHw2H8XbErlRBqgu8pVTl4JUyMKBk3nm7wW3KHszgu82Qm/hgT6HqGEdXAl/F92GWO1i N50A== X-Gm-Message-State: AOAM531/wEEiRIVN/N2DStkqjuxsQCuJGOu6+NSAwLQspKxoR25t9JVy Ot1iSj7WujDFI+COs6FKIKehyDTHNUw= X-Google-Smtp-Source: ABdhPJyQdxIA4lIDbDulsvOs0NZhV4S0UZCnh86sCShA7ZRuRfPhL4qVQmpdKI2T4VJMz3HcRktgOA== X-Received: by 2002:adf:8442:: with SMTP id 60mr6633538wrf.276.1594738264728; Tue, 14 Jul 2020 07:51:04 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:04 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 11/13] cpufreq: pcc-cpufreq: Remove unused ID structs Date: Tue, 14 Jul 2020 15:50:47 +0100 Message-Id: <20200714145049.2496163-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105105_966517_0D19DE53 X-CRM114-Status: GOOD ( 10.70 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Nagananda Chumbalkar , Lee Jones , linux-arm-kernel@lists.infradead.org, Matthew Garrett Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Can't see them being used anywhere and the compiler doesn't complain that they're missing, so ... Fixes the following W=1 kernel build warning(s): drivers/cpufreq/pcc-cpufreq.c:619:36: warning: ‘processor_device_ids’ defined but not used [-Wunused-const-variable=] 619 | static const struct acpi_device_id processor_device_ids[] = { | ^~~~~~~~~~~~~~~~~~~~ Cc: Matthew Garrett Cc: Nagananda Chumbalkar Signed-off-by: Lee Jones --- drivers/cpufreq/pcc-cpufreq.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c index 5789fe7a94bd3..99cf8b78c032a 100644 --- a/drivers/cpufreq/pcc-cpufreq.c +++ b/drivers/cpufreq/pcc-cpufreq.c @@ -616,13 +616,6 @@ static void __exit pcc_cpufreq_exit(void) free_percpu(pcc_cpu_info); } -static const struct acpi_device_id processor_device_ids[] = { - {ACPI_PROCESSOR_OBJECT_HID, }, - {ACPI_PROCESSOR_DEVICE_HID, }, - {}, -}; -MODULE_DEVICE_TABLE(acpi, processor_device_ids); - MODULE_AUTHOR("Matthew Garrett, Naga Chumbalkar"); MODULE_VERSION(PCC_VERSION); MODULE_DESCRIPTION("Processor Clocking Control interface driver"); From patchwork Tue Jul 14 14:50:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663055 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F2A341392 for ; Tue, 14 Jul 2020 14:54:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB6FC21973 for ; Tue, 14 Jul 2020 14:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OrQXXu1j"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zNeMYDIH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB6FC21973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wdf+JYnqMrH2Qpjhb7CuTRzfTUcayWVhGgu8SIWxdi8=; b=OrQXXu1jgw8KSCQAoNG9p/nYk tcO80PeZthFdLKHF5czbt4cCEDp9BmGJ71cobgx2DjrvQYOgWDyTqSEKlfQKb6C0N8UhjUQKJeyUW Pk+1HmTL2HGh0bg9FFJ2rp6QaR9WftMXv/o+L4fLsWyRKy7JaOTEo24pUZIOlKIA5lWgDnu+XssuP y88uSAT9WNgt1QP5l79nfp7hMv90tedD5hyGgnf1X13/SdSUVbCSGtMboF940Le6/N2S0godI5Ytq kRLMxFu70Xy/D1G1o5jcdgKSHSrOHWiJb9SWyoKl30NTVRzZY6ZFqwxtEa0qCWRKovArO0HNFHdoO p2A0G1LMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMI7-0004z4-5i; Tue, 14 Jul 2020 14:52:19 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGw-0004VR-Oh for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:51:07 +0000 Received: by mail-wr1-x444.google.com with SMTP id j4so22189917wrp.10 for ; Tue, 14 Jul 2020 07:51:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AqdFH5K7w1Gi1dVNyBHBLmEyEPDpMkPLQqFOgpWKb8k=; b=zNeMYDIHJED7se7OqmcmpxTYUyzehCUyRtWunJvcBfdAuICVelAnfmYtw7GuBPUBlc d/pXNoafB+fgqXtmn64mKrwZUYXTYjtMFTGUq0m9bhqCqfyPWpUaGr3WxPKCpSVkmTSY I+J/jDnePhbC2x0dIJzFW1sMHCnzz6NUnsO3VS0J9KbDeaWvpubida+OLoO33PkJ2MXo fmSqLnpptDjn4oQRgS69BQWwUpgKj7EGqA+PEo2vsGs3tVdEl5/gZkixdlC5Ebd2Ss9E izf49OWpwU7LNnFdDt3iddBnPoOU9ThybroR8ocRIEK/NwuMVN9KLWb3ziUx09mL/sOu q0fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AqdFH5K7w1Gi1dVNyBHBLmEyEPDpMkPLQqFOgpWKb8k=; b=GIRzRQbrTjbISgQRH+/5JYTemRmYz5c/ANE4JxoljFIhQ6kNu99qgOaE1R2/tqonuK rCu+ieJ0z2iMwNYunigRMrXSKI/IWjjJzTXvOUX7BnlBd3esJF1FtWn5L1zlmUoC3eC9 8UFx+cjD3vJ15QV1S/yMJzLNkCp4p3+tA112+/YoNSejRNUrrcJ3fIcVajpa/h5Tk8Xv zscZjVGZEDxUi+xyg5KWBHKW10LGq8ObigQ/m1bhgRcS1ICQPL+5JGAKv6vVvxSZRVFB Ht1WZJIq0LJhsNpmNcicX1jkFErADFp3g4amvePJwmICah0EVD8vKOu56RoLXeAe3JUJ wglA== X-Gm-Message-State: AOAM531A5+ptoU9yahZWY+0DYtwSDnQfdHlByCw1lVchdSt4NBDh/4Y8 imb9PEAotL51FJJTvLq65booGA== X-Google-Smtp-Source: ABdhPJz408nOqlOdcCH2rmaB0MOSljVm9QafGiYYQORYvAR+a4nRgn2T/Gr31RWc8hp64O0RPEjK1g== X-Received: by 2002:a05:6000:1107:: with SMTP id z7mr6077015wrw.355.1594738265886; Tue, 14 Jul 2020 07:51:05 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:05 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 12/13] cpufreq: intel_pstate: Supply struct attribute description for get_aperf_mperf_shift() Date: Tue, 14 Jul 2020 15:50:48 +0100 Message-Id: <20200714145049.2496163-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105106_876956_12FD2877 X-CRM114-Status: GOOD ( 12.02 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Dirk Brandewie , linux-kernel@vger.kernel.org, Srinivas Pandruvada , Lee Jones , linux-arm-kernel@lists.infradead.org, Len Brown Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/cpufreq/intel_pstate.c:293: warning: Function parameter or member 'get_aperf_mperf_shift' not described in 'pstate_funcs' Cc: Srinivas Pandruvada Cc: Len Brown Cc: Dirk Brandewie Signed-off-by: Lee Jones --- drivers/cpufreq/intel_pstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 44c7b4677675d..f92fc69c87269 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -275,6 +275,8 @@ static struct cpudata **all_cpu_data; * @get_min: Callback to get minimum P state * @get_turbo: Callback to get turbo P state * @get_scaling: Callback to get frequency scaling factor + * @get_aperf_mperf_shift: Callback to get the number of clock cycles after + * aperf, merf is incremented * @get_val: Callback to convert P state to actual MSR write value * @get_vid: Callback to get VID data for Atom platforms * From patchwork Tue Jul 14 14:50:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663051 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B2BE61392 for ; Tue, 14 Jul 2020 14:54:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85A8721D6C for ; Tue, 14 Jul 2020 14:54:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ebx+nE5R"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wn2diMwB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85A8721D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Was+0W1kzxNrezeOvLJeN1/rlQltZwpCMa9+gjxDQvY=; b=Ebx+nE5R1190TCBdFAQUHBbV9 RwWQerTQiQ5H3fQhiZ7Fsva7/aXVHrThl8PZZUIOGgJcf1qAbLrQm92ZofQJv5RfTaAusUJBEUp2I Br8hA6pTG954WUl6lahyQl81IFz/EztA+5UXSOwm39rjqHAy7ksuhtIz4vzQOVOgX5NaNEH5HSIfM YTRi0Bq3U3tg1O7W18jHlMNCIYPjPmvdS1azt4HxqlklsxQk5Hx1So36/g8/uuaViZO0mMQ8q5+u/ MEmmfUF6tFTlgdq6UTdunxayCwkvI4oXUogkAHauICB1ReDMNjiD14TQtmajYLWoQ6rR+cNTEDdLr aQzVPCqCw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMIB-00052D-84; Tue, 14 Jul 2020 14:52:23 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMGx-0004W2-Rv for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:51:09 +0000 Received: by mail-wr1-x443.google.com with SMTP id f7so22197961wrw.1 for ; Tue, 14 Jul 2020 07:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1l4G4IRouZ0WTRSlZcy5MrRuoV79BSQEwt+8MDC1zos=; b=wn2diMwBztTukWV3a+OQNb47W076q9O5m4hlY8WUNk2ANeNPaT/CQqfi3zwQR1nGOg VSSBNKiAlDKVFIJkOH+19zNKugRcw4cpro7kI2dybo1tFgi8XfZSUt3XWqaoBeR3z+Av +BpmcNzyT53w8bXQHF125EFE/q99zFhEemyIkgKezuFYO+m6Wrr3L3utp3V8ZyiYB1a+ o30rqYQ6cOqjoSrfZS3gdzIETNcvOBwh9eiVRnEkHsqSZKnsldi6j2CGj6wyxxwcW7sN 6DdTvdz7/e/Gkt4GbQ+f9viLiUUW0EP2OA+J4uLKVRwzUHrW9D8fZA2LFwU5mGcjfEJU A74w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1l4G4IRouZ0WTRSlZcy5MrRuoV79BSQEwt+8MDC1zos=; b=FEXgw8s4w50HT6msU2lWR2/MIYra5hHel+N0yEXv50QlbidezR4ROlFObmL/A9ldE/ R58qiUJWGd3LFLLODwxdd+tEDb6BOhf1jQLRLhAkQhhJRz2X4MHqCG27VcaWMVMepGJp c0O+9Jk3fY2Ml2TmZzNaLOBnvpJCREt3a58lUVnMTaIcb3Ly6FtJJOcr++l3rte2NvCi +Cu3c6SLz/sJ8J9RYtOKMqIrRJ6tM2KlBbRUe3DWlqU/dlt+AqAmCKDFcl6163sIF8AQ +oOs8N+YqYFOUgy2WO6ucVQC4y5P1kSj5UIRI99cstydr1OnGHBxvNjgyYVkgLzFhHcT t+ug== X-Gm-Message-State: AOAM5309yFU/oQkaZrMhd7LQFAEltvUPGp6JJFAqrKEOJydOYomdemRn SvrQC957MEk4H6QiHYfh5UZzzQ== X-Google-Smtp-Source: ABdhPJxU9G/etho4iPMM3oDyoMPF/f2Brrlm1RMB2kEg+iD0TtRcr3nqndDSPblNhCAw+mZZ27YJig== X-Received: by 2002:a5d:4845:: with SMTP id n5mr6034582wrs.353.1594738266949; Tue, 14 Jul 2020 07:51:06 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:06 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Date: Tue, 14 Jul 2020 15:50:49 +0100 Message-Id: <20200714145049.2496163-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_105108_067352_C57166CA X-CRM114-Status: GOOD ( 10.83 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jacob Shin , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Can't see them being used anywhere and the compiler doesn't complain that they're missing, so ... Fixes the following W=1 kernel build warning(s): drivers/cpufreq/amd_freq_sensitivity.c:147:32: warning: ‘amd_freq_sensitivity_ids’ defined but not used [-Wunused-const-variable=] 147 | static const struct x86_cpu_id amd_freq_sensitivity_ids[] = { | ^~~~~~~~~~~~~~~~~~~~~~~~ Cc: Jacob Shin Signed-off-by: Lee Jones --- drivers/cpufreq/amd_freq_sensitivity.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/cpufreq/amd_freq_sensitivity.c b/drivers/cpufreq/amd_freq_sensitivity.c index f7c4206d4c90b..a17093729511b 100644 --- a/drivers/cpufreq/amd_freq_sensitivity.c +++ b/drivers/cpufreq/amd_freq_sensitivity.c @@ -144,12 +144,6 @@ static void __exit amd_freq_sensitivity_exit(void) } module_exit(amd_freq_sensitivity_exit); -static const struct x86_cpu_id amd_freq_sensitivity_ids[] = { - X86_MATCH_FEATURE(X86_FEATURE_PROC_FEEDBACK, NULL), - {} -}; -MODULE_DEVICE_TABLE(x86cpu, amd_freq_sensitivity_ids); - MODULE_AUTHOR("Jacob Shin "); MODULE_DESCRIPTION("AMD frequency sensitivity feedback powersave bias for " "the ondemand governor.");