From patchwork Wed Jul 15 09:32:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11664597 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2E952138C for ; Wed, 15 Jul 2020 09:32:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 034FD206F4 for ; Wed, 15 Jul 2020 09:32:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WNl14dX6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ot1YDljs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 034FD206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4E3974TVGrtXtu5O7NLKsxHojg2H19UN30BK2Bxd+J8=; b=WNl14dX6dupleolhaAWUSzEa0 yQmKrNRusEJepy+9m0+xv0h3RYPJ50KDRUuums0JhmDdk4md0REV7j2/4f2N2JI3TC2Wy9I0anvqk ChcXXcBUC4Q4EUADWN/G2lXEdyLHyanAh3XMVFsMljVH/+NWUhtRnl6+nWlb5okfS6S51RExIbqLn BfGKzs617d5Nk/9NUhEUaEJTZS+PqAmUuLmwXhuCJqpG9mGT0RgTQl5Z3GOUp4KgpKvz9R/xuGLrH 6xb9M6NhClLgDe81bWc8PCXtzD0ZVtSQTr1S8XrmA8XN+JNjTkonfaRF+q4drmjHDSwjwsYxjx/Ut dhLOXSDkA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvdmH-0003SU-85; Wed, 15 Jul 2020 09:32:37 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvdlx-0003LL-I4 for linux-mediatek@lists.infradead.org; Wed, 15 Jul 2020 09:32:20 +0000 Received: by mail-wm1-x343.google.com with SMTP id q15so4689302wmj.2 for ; Wed, 15 Jul 2020 02:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9PiTITbm2Lxqlt8bG5B7tvFplfBvl1yIo6Kmzl56a8E=; b=ot1YDljse6ITmipQNFdp/KcP8xZbzbxOBK4qefcNjgnfHxNw60L2lro5mVv0rW9trB xr2Npa1kR2uT7uymOuPRZNgM2ZhGFlMSbV0mo3Kgzya3FmBYENGlsCqMUYUQgp1d9tvr /P8dABajdryamvwlrBC+ByuqqP+zC6hXna+N5dwZL1CFNdhB3gD4golA6UMyTdyuNmv0 0ZlgVVU6O5mQfZbJm3f0Ky3AsQphpOiLi455stO9nHMXi4mJSLcGSN6Rf0yi1F/4c8pH DQnX4W7hWsD9tMc5lpqioldm4TvV3YYEVULshS4NijjO70jTD/tcHlIWD+pWrJ0VZ0AY LL2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9PiTITbm2Lxqlt8bG5B7tvFplfBvl1yIo6Kmzl56a8E=; b=Q1enxxCDHInlol1dL/enmeyfDfv+ZD9g9WbatbSSRNDa8DxnAKeZgJ0mJ6btTti0iG xXrzyvOs3GG/mbHvz5kIwPpKvldUoh6MudxquCgHun0qtPIRc94/tNAsZRew5681sY/N 9vncfzqHbPshleJfFQb5/7HGDWITaUAKj8toVWiD6qJF4FUQ/Bko2GkS/NlS3N1V/+vE B1X0Hi0F31162hDLtasp4LLV/1L2fZm+gmZVamXgJyJaq0P/qaHqz8LRNf2b5KLA4Wjs WYEqJSpWzpNSfAaEkgHyGRoOASIeXaUlVPV/gZ9/d1wBBlN07SWaFW4o6MW6gFXkTwFF YXTw== X-Gm-Message-State: AOAM532oUev1tJwAQGY9+dwnHscniqfITav0PiZ6WX5O/robFtnxI6CS IVVCUJvelcWZHWF+CzYKLZI6Cg== X-Google-Smtp-Source: ABdhPJzLcC4/hBG4W1UXFYDrQ8+TkBT6n/tQXy5dSXrQ+pSmxaZ5D+Fy9bfnLvg14NXYp0de96+xHg== X-Received: by 2002:a1c:44e:: with SMTP id 75mr7879408wme.139.1594805536549; Wed, 15 Jul 2020 02:32:16 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id s203sm2686991wms.32.2020.07.15.02.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 02:32:15 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH v2 3/8] usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc Date: Wed, 15 Jul 2020 10:32:04 +0100 Message-Id: <20200715093209.3165641-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715093209.3165641-1-lee.jones@linaro.org> References: <20200715093209.3165641-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_053217_694495_C4F17318 X-CRM114-Status: GOOD ( 11.06 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chunfeng Yun , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org Kerneldoc headers should only be used to document functions and data structures. Cc: Chunfeng Yun Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- Changelog v2: Removed unrelated reference to build warning drivers/usb/mtu3/mtu3_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/mtu3/mtu3_trace.c b/drivers/usb/mtu3/mtu3_trace.c index 4f5e7857ec312..155eae126e5e2 100644 --- a/drivers/usb/mtu3/mtu3_trace.c +++ b/drivers/usb/mtu3/mtu3_trace.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * mtu3_trace.c - trace support * * Copyright (C) 2019 MediaTek Inc. From patchwork Wed Jul 15 09:32:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11664601 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C1F32618 for ; Wed, 15 Jul 2020 09:33:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 818A2206F4 for ; Wed, 15 Jul 2020 09:33:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iSyE52bX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LdQed/Ih" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 818A2206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9IinYvkGuE03ZGSqu2qfWan4yYFPV1a8UrxxT4X8i0U=; b=iSyE52bXdF2ryjX4vhCpbfTDE PPLtBopBdiduSUmB3GRIMLpPn1EOnA1ZURr6cw5p80PIx6FJDTKZlbGWT9BzIYL/GJEG+ZUlefv+E Imco2i0bpx/PZoC9SNzPmM5sMg3pWV3cVPW8+jWo9HLb9XzpR0pCSHt4ZhID/YkjBjLGl/bLcnGHs d9cwTV9dsDdpZyEgslZUOER0y2LR9mHESPYXAteOlsetLWa3uEDT7FMDEhnCeUeEAlvlNWs/XUBak w8Nc27tOFHz9mZEq5JOZ7GNiNNtGwkgWTf1OXp9704OHDyZrh40dZ4h2fzqR8/ecOIXWk1EI3V3w+ H/8zwwjDw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvdmM-0003Un-LR; Wed, 15 Jul 2020 09:32:42 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvdly-0003Lx-MC for linux-mediatek@lists.infradead.org; Wed, 15 Jul 2020 09:32:21 +0000 Received: by mail-wm1-x342.google.com with SMTP id c80so4687529wme.0 for ; Wed, 15 Jul 2020 02:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tDADXb7FAzSw8X5lKDm1Tv4eULkfL4pe/oWt/8u/tjI=; b=LdQed/Ih0lqZSe0CCBXFgRaZlWuEjjDKJxIpKs/nPHffEQP1EdCkcHyMLyH37Yz6LS hw3npNiL3hzjRYUd1n4AFDMrT0loBlTdv1mSuVODZjFfdKA5HWic/IoHbOHOa4zkFowx OXx9B97n+b4Kxs2zb/p5G3JVDB52/VcKxYcfzDBFm9RCqeUtgBLq4ThSGCTp8HmC33Rp 7iPo+vyJiyamddgrr3wrjR3t40fA+jCSFuS/YmUgy7j8Iw+0aw8ElXPK457oReUWs2jO /kew5bxhd7rV2rtWYpK2FoaxwlADY6SqfwuWS/+eX/L8KjU/C3IKG2NuQqIg+YdDhOXJ ar2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tDADXb7FAzSw8X5lKDm1Tv4eULkfL4pe/oWt/8u/tjI=; b=qXX0msND9hRnvBASJnnWauVDup4MoVFqW23mcIqUngXwbRrTubA7TLq3iH2lvEFxCW CJPyTVg86WKbO+EWP+5+5j0oiUb0vN0U2XsVVOibBFZJARWG4fP2OoPt73dqj+nf9i7z OPG+r4xdFnjUbZxOnySl9KlTKBwGGdzkfSNlhvJwlOvjB9rh2dKkF5b+T2Fets9RTgCn QURAYScofWAdQjAeIfKIN+WTG7Miss5rv8VuK0HmeQdME7wA4oYQTxPwaf11+Pu3D/zk 0khNwUH8YRdODKrIi7E3bFQA9HMzpEc4XjZJksQej0MOx+guQM/7NnnK+yO63N8HTIiS 5lRw== X-Gm-Message-State: AOAM532DpIcwDbU9/V5atim48/WBhFoSdlz7qG+XYE+7K8jabElUdnuO YLsi/kwJuHwBcsT6R1b2b58Uj7vsnP4= X-Google-Smtp-Source: ABdhPJxO/xBg6hX1tW1/OdfO23Yl4NCWnZHIuTxnlzd6rvRZWjW7iMR0nFemLByMXCsySd2r1950Wg== X-Received: by 2002:a7b:c348:: with SMTP id l8mr8206612wmj.54.1594805537724; Wed, 15 Jul 2020 02:32:17 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id s203sm2686991wms.32.2020.07.15.02.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 02:32:17 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH v2 4/8] usb: mtu3: mtu3_trace: Supply missing mtu3_debug.h include file Date: Wed, 15 Jul 2020 10:32:05 +0100 Message-Id: <20200715093209.3165641-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715093209.3165641-1-lee.jones@linaro.org> References: <20200715093209.3165641-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_053218_846046_AB878A49 X-CRM114-Status: GOOD ( 11.42 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chunfeng Yun , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org If the header file containing a function's prototype isn't included by the sourcefile containing the associated function, the build system complains of missing prototypes. Fixes the following W=1 kernel build warning(s): drivers/usb/mtu3/mtu3_trace.c:13:6: warning: no previous prototype for ‘mtu3_dbg_trace’ [-Wmissing-prototypes] 13 | void mtu3_dbg_trace(struct device *dev, const char *fmt, ...) | ^~~~~~~~~~~~~~ Cc: Chunfeng Yun Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- Changelog v2: No change - robot warning did not appear to be valid drivers/usb/mtu3/mtu3_trace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/mtu3/mtu3_trace.c b/drivers/usb/mtu3/mtu3_trace.c index 155eae126e5e2..d17ddb87cdcf2 100644 --- a/drivers/usb/mtu3/mtu3_trace.c +++ b/drivers/usb/mtu3/mtu3_trace.c @@ -8,6 +8,7 @@ */ #define CREATE_TRACE_POINTS +#include "mtu3_debug.h" #include "mtu3_trace.h" void mtu3_dbg_trace(struct device *dev, const char *fmt, ...)