From patchwork Fri Jul 17 16:55:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670779 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0A7D21751 for ; Fri, 17 Jul 2020 16:58:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E385120704 for ; Fri, 17 Jul 2020 16:58:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sOXt9VbP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726949AbgGQQ4C (ORCPT ); Fri, 17 Jul 2020 12:56:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbgGQQ4B (ORCPT ); Fri, 17 Jul 2020 12:56:01 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AABDAC0619D5 for ; Fri, 17 Jul 2020 09:56:00 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id z2so11926828wrp.2 for ; Fri, 17 Jul 2020 09:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W0NdwY9SbjwHcTXsovlQ3v7LbQPLWjEb4KHf8LUGjbY=; b=sOXt9VbPlc5N0UZ4A4vCRWgtuBbT/N0Cs1uY6oUQWBDzdCPYc9I3EUBsJ95AWLQQsu GbjmozZBJ4upGfnc1kkJk2MjNUqZU2a1ffzF8z/w2Fs+iuvoyVfBx+Gx+qdGqhT2LAQA mxZPTYpRDMTmJMnqhoJVNVqXJ0dwiQ8FZ4b3GmnGn2To1L2WMslwLpjP7IZ9VbghGxqa gzzBN1Diq5Epf+1OTF3zOHVeiq85oExuTc8CfHdmBoNPC1IHwdipDyJ5qQMHDDguiCu4 87MbEySCThUvuSCjBgDqYRBg0NXqbuPn8MdGHj/va7T6rUxlxbrMwFxaj3TJDy7DkGaI 5kuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W0NdwY9SbjwHcTXsovlQ3v7LbQPLWjEb4KHf8LUGjbY=; b=MKV9n6W4kj4TFQ65GDj4xnMJW8yzXY4Fy8wKoetRx8CM33DkjMM94MywXvnnbxW1S5 edhCV5eQq87rRVVidXqZBsQmNhr38P7Dboupozk5DV8cW53Yi5IAHZ8DBzthtdJAnEvx HiV8qQL1/k9e7gtpigMs/tTPD2Q2Lzirm0++K7+qNhGEzB7QjedaKDZOo86N+0YXqsaw +OyXb/EfrFB6r+s+Fb4fNgvSaUFAbNx/iATC4wGerGCFON0ROmttcWRzu2LP6oDkxOrB y+Zut/Ltz7VJGM/ROVrD9d9Y14Df9X5msrYlw5xHDhNvXcCoY+oS40dzI99ukc5NV0oi T2IA== X-Gm-Message-State: AOAM531GURf9E2O+BPm0bR26A6Zj4S/K3hhWIE3sjwXYBnC8/3CeCDv6 A35VM/isdb7XeQxlrAkHRXVWdQ== X-Google-Smtp-Source: ABdhPJwgRPbtjNyvrRZZorKrXJsoK0TE02TWb6iUUdarbMSRUJWwlu4GZ6e7rfb/OwhWQRKDjbkOFg== X-Received: by 2002:a5d:630c:: with SMTP id i12mr12302586wru.158.1595004959310; Fri, 17 Jul 2020 09:55:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.55.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:55:58 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Rachna Patil Subject: [PATCH 01/30] iio: adc: ti_am335x_adc: Remove a couple of unused 'read' variables Date: Fri, 17 Jul 2020 17:55:09 +0100 Message-Id: <20200717165538.3275050-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/iio/adc/ti_am335x_adc.c: In function ‘tiadc_buffer_preenable’: drivers/iio/adc/ti_am335x_adc.c:297:21: warning: variable ‘read’ set but not used [-Wunused-but-set-variable] 297 | int i, fifo1count, read; | ^~~~ drivers/iio/adc/ti_am335x_adc.c: In function ‘tiadc_buffer_predisable’: drivers/iio/adc/ti_am335x_adc.c:346:21: warning: variable ‘read’ set but not used [-Wunused-but-set-variable] 346 | int fifo1count, i, read; | ^~~~ Cc: Rachna Patil Signed-off-by: Lee Jones --- drivers/iio/adc/ti_am335x_adc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c index 9d984f2a8ba74..93b67bb165044 100644 --- a/drivers/iio/adc/ti_am335x_adc.c +++ b/drivers/iio/adc/ti_am335x_adc.c @@ -294,7 +294,7 @@ static int tiadc_start_dma(struct iio_dev *indio_dev) static int tiadc_buffer_preenable(struct iio_dev *indio_dev) { struct tiadc_device *adc_dev = iio_priv(indio_dev); - int i, fifo1count, read; + int i, fifo1count; tiadc_writel(adc_dev, REG_IRQCLR, (IRQENB_FIFO1THRES | IRQENB_FIFO1OVRRUN | @@ -303,7 +303,7 @@ static int tiadc_buffer_preenable(struct iio_dev *indio_dev) /* Flush FIFO. Needed in corner cases in simultaneous tsc/adc use */ fifo1count = tiadc_readl(adc_dev, REG_FIFO1CNT); for (i = 0; i < fifo1count; i++) - read = tiadc_readl(adc_dev, REG_FIFO1); + tiadc_readl(adc_dev, REG_FIFO1); return 0; } @@ -343,7 +343,7 @@ static int tiadc_buffer_predisable(struct iio_dev *indio_dev) { struct tiadc_device *adc_dev = iio_priv(indio_dev); struct tiadc_dma *dma = &adc_dev->dma; - int fifo1count, i, read; + int fifo1count, i; tiadc_writel(adc_dev, REG_IRQCLR, (IRQENB_FIFO1THRES | IRQENB_FIFO1OVRRUN | IRQENB_FIFO1UNDRFLW)); @@ -358,7 +358,7 @@ static int tiadc_buffer_predisable(struct iio_dev *indio_dev) /* Flush FIFO of leftover data in the time it takes to disable adc */ fifo1count = tiadc_readl(adc_dev, REG_FIFO1CNT); for (i = 0; i < fifo1count; i++) - read = tiadc_readl(adc_dev, REG_FIFO1); + tiadc_readl(adc_dev, REG_FIFO1); return 0; } From patchwork Fri Jul 17 16:55:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670777 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C060214E3 for ; Fri, 17 Jul 2020 16:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A80402074B for ; Fri, 17 Jul 2020 16:58:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VGtCMRlR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbgGQQ4C (ORCPT ); Fri, 17 Jul 2020 12:56:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726944AbgGQQ4C (ORCPT ); Fri, 17 Jul 2020 12:56:02 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE1BAC0619D3 for ; Fri, 17 Jul 2020 09:56:01 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id j18so15951263wmi.3 for ; Fri, 17 Jul 2020 09:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7pd6ShoPrm0jZpbjskrRfnA1hCGWtl3SFnepd2S/QNM=; b=VGtCMRlRyKO1bci+KeMExFH/2APwqhMYP6S3B9+EOf6gpg1qNARu0VHR3LvT61Neyg nm3rd+el8yz8XmTP2+zYHKNdshyA6ue/Nj/FWIZzGGJX8oqDJOz+Ct5Ou1DzYG54qFDH V3B7uywTdM+fb7kdwwIBORo/PJ0J8/kF+HGGc4mzFysjY89jf0bkZPJrq+15EKzqE7Yw LmZadfjDmnuJ4YH7zpONh4thewCq9vVBYbQ7vvaAJN/1cPTt5xt+0JbtOkStyaj3FdAG Y0yTXp9azBD9EZhNwWD5+SxbEosCZnQPQm0L27uCb61jiO13Y9ZD9xrZFWxUU1MyYrkU 8PSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7pd6ShoPrm0jZpbjskrRfnA1hCGWtl3SFnepd2S/QNM=; b=Y6mFdJD7Jp2kH6890WjXMDLOA5TC4vr4q2NaqEYyHL57qCQhn0f2TjyTTGLI31zR+O yGH0CXWuXyD2kwOzrARA8QzHLFYQNvHg4mAHJ5o25LybwU4IjmMbtvz25ZIexFFMcfYD vbZUVO84EjDXGzxZ11ZE7I/cym3oAiJ1QImnpR330Jvv93lZnEY5AY3d0IHDGFtO9Xz8 HeKHgZK4b6mAq7CDesdCPawiUad7RVvRSlYdmpXYytCZTvZr4TNSNoyDu2lZuZ2NAp3b M9o0uzkVsizibvAILDH4eiE4Bq3oNdLPjKAvCQBtlFf+fvGuMiOrzvESZJR4ExH6fAUt KwXw== X-Gm-Message-State: AOAM5336bIwYhPFavXh3JlwbBtkoki3cGDRsZZrK7klBA2CTR7MMwps6 xkwxiQS6tvcCgJoLWhuHUZaRFQ== X-Google-Smtp-Source: ABdhPJzMIXHm3ytdzPTg/jzS+f+DoP3PtJaIUny4rj64gipaY/71JD/hoOkN+ChIiten42HePer0ZA== X-Received: by 2002:a1c:3b02:: with SMTP id i2mr9952267wma.24.1595004960384; Fri, 17 Jul 2020 09:56:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:55:59 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Sebastian Reichel , J Keerthy , Mikko Ylinen , Amit Kucheria Subject: [PATCH 02/30] iio: adc: twl4030-madc: Remove set but unused variables 'len' Date: Fri, 17 Jul 2020 17:55:10 +0100 Message-Id: <20200717165538.3275050-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/iio/adc/twl4030-madc.c: In function ‘twl4030_madc_threaded_irq_handler’: drivers/iio/adc/twl4030-madc.c:475:9: warning: variable ‘len’ set but not used [-Wunused-but-set-variable] 475 | int i, len, ret; | ^~~ Cc: Sebastian Reichel Cc: J Keerthy Cc: Mikko Ylinen Cc: Amit Kucheria Signed-off-by: Lee Jones --- drivers/iio/adc/twl4030-madc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c index 472b08f37feae..826d8295e9b3c 100644 --- a/drivers/iio/adc/twl4030-madc.c +++ b/drivers/iio/adc/twl4030-madc.c @@ -472,7 +472,7 @@ static irqreturn_t twl4030_madc_threaded_irq_handler(int irq, void *_madc) struct twl4030_madc_data *madc = _madc; const struct twl4030_madc_conversion_method *method; u8 isr_val, imr_val; - int i, len, ret; + int i, ret; struct twl4030_madc_request *r; mutex_lock(&madc->lock); @@ -504,8 +504,8 @@ static irqreturn_t twl4030_madc_threaded_irq_handler(int irq, void *_madc) continue; method = &twl4030_conversion_methods[r->method]; /* Read results */ - len = twl4030_madc_read_channels(madc, method->rbase, - r->channels, r->rbuf, r->raw); + twl4030_madc_read_channels(madc, method->rbase, + r->channels, r->rbuf, r->raw); /* Free request */ r->result_pending = false; r->active = false; @@ -525,8 +525,8 @@ static irqreturn_t twl4030_madc_threaded_irq_handler(int irq, void *_madc) continue; method = &twl4030_conversion_methods[r->method]; /* Read results */ - len = twl4030_madc_read_channels(madc, method->rbase, - r->channels, r->rbuf, r->raw); + twl4030_madc_read_channels(madc, method->rbase, + r->channels, r->rbuf, r->raw); /* Free request */ r->result_pending = false; r->active = false; From patchwork Fri Jul 17 16:55:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670775 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A300F6C1 for ; Fri, 17 Jul 2020 16:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 895DD20737 for ; Fri, 17 Jul 2020 16:58:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C7HneBkE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbgGQQ6D (ORCPT ); Fri, 17 Jul 2020 12:58:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726944AbgGQQ4D (ORCPT ); Fri, 17 Jul 2020 12:56:03 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8320C0619D2 for ; Fri, 17 Jul 2020 09:56:02 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id o11so11886720wrv.9 for ; Fri, 17 Jul 2020 09:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lIupI+tKAOz6AMhKMQ/MUZEWjIHVvy3yhlR142kJJzQ=; b=C7HneBkEgxiePq6cP+uc0msARkXKZ68uMEWX9XvHJk51XE/BiAVtq27WtsiRaWpZOl blIPdgePFo/nZeZ1gGvbiyp6TXMBSerIKtneJiwHtDGhX3/19NJd9qNmpRmEAOcUInjE Joe3OOs7tX+fan+SF++O2aDxnMg6VJQNfwqM/hTuZ4VIQcR8NDL0ukAmnVHHLyhL6cjA BiPU9T/6ho43X4D/ukf7LCo72Ha6TdYmz7wne2DouxCak7hk442qzdOgHuEiGgKAx4Of JA16zWN7T2bMrYEvs/D+rqAHHbROXFn23jNHTHTADeK4nBcwhUjM5TBGRGvGVLOWMKZU mKmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lIupI+tKAOz6AMhKMQ/MUZEWjIHVvy3yhlR142kJJzQ=; b=Jj0O7UZyUZJLvbjSKtu55PZETIMRVrBzTKD1FIL1jvjGcqFlv4TjUHp2/Op025gnBE pxTNL7eiVcN7UMjR99zB9ntGUqzrd+/XxfO3HgepyF+IeoEMnvrrVSYMXmZNu/JnLv5L FV842GKarZkm0NkwpNSWByr+rN5LMOzuIJo5HiCYbPHYGl9qNTmXKwloWKy/PxK1J7QA I3rm3YAbmJqO1ibwKZy/Q10sb33lGavicb0TPIrSqrzBWTZEFZW5vhgdZyGTgxK6C5Ur q/skeT5QL7DdNTfAmRrOOM7pOsKXoyCrXcHCFQBpX+8Ckk+aqj/Uffs2C2y+gprN8AZa 5NMg== X-Gm-Message-State: AOAM530RPvogeAHE/lLHPHbmiNKqfeAJ0VNOEz91MLLtOgAoHgZsi5iN logeYXLHJ2VK2QLiViIAi4ryww== X-Google-Smtp-Source: ABdhPJzK3GbkD2rzZrYM3yoqQYRKGWTe1avEC7a2sRHmTBdmjWCN1HXe7dJK1gVWJjCwVAE7KRFK0Q== X-Received: by 2002:a5d:69c5:: with SMTP id s5mr11229093wrw.197.1595004961514; Fri, 17 Jul 2020 09:56:01 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:01 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , J Keerthy , Mikko Ylinen , Amit Kucheria Subject: [PATCH 03/30] iio: adc: twl4030-madc: Fix misnamed struct attribute Date: Fri, 17 Jul 2020 17:55:11 +0100 Message-Id: <20200717165538.3275050-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/iio/adc/twl4030-madc.c:170: warning: Function parameter or member 'usb3v1' not described in 'twl4030_madc_data' Cc: J Keerthy Cc: Mikko Ylinen Cc: Amit Kucheria Signed-off-by: Lee Jones --- drivers/iio/adc/twl4030-madc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c index 826d8295e9b3c..882a678b44690 100644 --- a/drivers/iio/adc/twl4030-madc.c +++ b/drivers/iio/adc/twl4030-madc.c @@ -153,7 +153,7 @@ enum sample_type { * struct twl4030_madc_data - a container for madc info * @dev: Pointer to device structure for madc * @lock: Mutex protecting this data structure - * @regulator: Pointer to bias regulator for madc + * @usb3v1: Pointer to bias regulator for madc * @requests: Array of request struct corresponding to SW1, SW2 and RT * @use_second_irq: IRQ selection (main or co-processor) * @imr: Interrupt mask register of MADC @@ -161,7 +161,7 @@ enum sample_type { */ struct twl4030_madc_data { struct device *dev; - struct mutex lock; /* mutex protecting this data structure */ + struct mutex lock; struct regulator *usb3v1; struct twl4030_madc_request requests[TWL4030_MADC_NUM_METHODS]; bool use_second_irq; From patchwork Fri Jul 17 16:55:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670773 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D28766C1 for ; Fri, 17 Jul 2020 16:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA30920704 for ; Fri, 17 Jul 2020 16:58:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="diGqESAP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbgGQQ4E (ORCPT ); Fri, 17 Jul 2020 12:56:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726996AbgGQQ4E (ORCPT ); Fri, 17 Jul 2020 12:56:04 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCD07C0619D2 for ; Fri, 17 Jul 2020 09:56:03 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id q15so15965817wmj.2 for ; Fri, 17 Jul 2020 09:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fAAjM1mVIkO+nJSIb50glO5h9HOq0tsEwp52kRso+4M=; b=diGqESAPD2yg592c8LXDZUadk/s4W30i0sy1gOfHfVL8rkg/bSc9SLulra7mzvbh6q tuEL6z3Ah/YSeL14hltOCwWppAmPt9ShSHMKVUYb1l9qxcXUKIq3zTM4yzvIsbo3iu4q Ykl7tRihGTqXOJZh9Cs0qp94pb/2FYwjxDujVZoKALn49L4H3l4V5PCd5jLqVtsS7beD 22JzY3Ro0UmLJsBfPgiEIAOxKd3eSn0tZAWAokfmdtwS1UnVx4x70bW1Hh+KxeUgefEx u0NqUPGOR33Su4RnGuvF9P8VjlNBWNlC/ezdUIbKIArdrdAqQTZGQ9DjBwz8xh5LjUs3 uwFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fAAjM1mVIkO+nJSIb50glO5h9HOq0tsEwp52kRso+4M=; b=gjE1/m8MqI0Tp4EG6fwENUAWEoo9QReHXR8qUDtfGeoFEuSIDa1KjzPn0Jmf8vUxpz UMddv/3lKfHmaos9rbP9ncdKBEitD4P6yADCWexY6ZjzawvGuJsT+11xE6CTDBd+EebU 6URGhDQjDTeL4wkoSwQ8HHdts5ReXISaaHhqpHJp2LCc9o74MuwRuXIQcF1typts+TZu JwhWFlOWsbw7e9WCzmUDHw3ftzClSdhRn+Kzhgel/IRCSQ5ud2afAjJQy8Kb88iwj/qk 9Tm/sMwmzZg0/yPjsxQ0liv5RHaHjJDva1bNf94jPTBBWv+T+8TzHMqSAZvWOn4uTS5I dHcQ== X-Gm-Message-State: AOAM533e3NTX3KMMlr7pR01LeZCMCU9fEE/Z2CFv3bB70a2WHLWa+Oa2 WcexuOq4JC5XhL8gq+un28K9Qw== X-Google-Smtp-Source: ABdhPJxBjePr/D/nJshvCMDW+pFxohRxj6BB8ic0aMowVQ5331Lh4fFUBQZq7R8GCcKKIDDyto7/3g== X-Received: by 2002:a05:600c:2154:: with SMTP id v20mr10975426wml.185.1595004962476; Fri, 17 Jul 2020 09:56:02 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:02 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Josef Gajdusek Subject: [PATCH 04/30] iio: magnetometer: hmc5843: 'hmc5843_pm_ops' is unused in 1 of 3 files including hmc5843_core.h Date: Fri, 17 Jul 2020 17:55:12 +0100 Message-Id: <20200717165538.3275050-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org We know that it's okay for 'hmc5843_pm_ops' to be unused here. Fixes the following W=1 kernel build warning(s): In file included from include/linux/device.h:25, from include/linux/iio/iio.h:10, from drivers/iio/magnetometer/hmc5843_core.c:16: drivers/iio/magnetometer/hmc5843.h:55:26: warning: ‘hmc5843_pm_ops’ defined but not used [-Wunused-const-variable=] 55 | static SIMPLE_DEV_PM_OPS(hmc5843_pm_ops, | ^~~~~~~~~~~~~~ include/linux/pm.h:354:25: note: in definition of macro ‘SIMPLE_DEV_PM_OPS’ 354 | const struct dev_pm_ops name = { | ^~~~ Cc: Josef Gajdusek Signed-off-by: Lee Jones --- drivers/iio/magnetometer/hmc5843.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/magnetometer/hmc5843.h b/drivers/iio/magnetometer/hmc5843.h index b0dee87a8b20e..3f6c0b6629415 100644 --- a/drivers/iio/magnetometer/hmc5843.h +++ b/drivers/iio/magnetometer/hmc5843.h @@ -52,9 +52,9 @@ int hmc5843_common_suspend(struct device *dev); int hmc5843_common_resume(struct device *dev); #ifdef CONFIG_PM_SLEEP -static SIMPLE_DEV_PM_OPS(hmc5843_pm_ops, - hmc5843_common_suspend, - hmc5843_common_resume); +static __maybe_unused SIMPLE_DEV_PM_OPS(hmc5843_pm_ops, + hmc5843_common_suspend, + hmc5843_common_resume); #define HMC5843_PM_OPS (&hmc5843_pm_ops) #else #define HMC5843_PM_OPS NULL From patchwork Fri Jul 17 16:55:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670771 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A11B113B6 for ; Fri, 17 Jul 2020 16:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 889CA2074B for ; Fri, 17 Jul 2020 16:58:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="upRwI5gM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727040AbgGQQ5z (ORCPT ); Fri, 17 Jul 2020 12:57:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727026AbgGQQ4F (ORCPT ); Fri, 17 Jul 2020 12:56:05 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6AEFC0619D2 for ; Fri, 17 Jul 2020 09:56:04 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id 88so1607530wrh.3 for ; Fri, 17 Jul 2020 09:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dnBtmSOMI3qCFo9FmJWl9WfxHjSJK5KQqVLRraKU05I=; b=upRwI5gMeGvdCbgPj9Hbz2zOy3eA+/cM1dWqW4XaF8zVm1a/FK+TCaV2C0+85l3dlo Xhhscxuy1lIt4yUbirxN3IkC3t/t1umvWhZkXmccs6CG5EHwXYsQGPurvMgCK+ZNpF80 Ggmfa+5tbctui2lwO4pl42VaoSS7xt6YaY4jQAtlAzBemaUl3t4znnhATvkfFEvPWc1v Z6Tkx/Q4qD56HI9w8YKnZoJwIVhYKKkjPiFCgJZdvsYuS5WnyM0pCP/4yVkew1pUHA8p Sl7kfF2E0kkyBw8Lr6gDxebP4MvXkkRTzPPJUu145D1vAWp22creWVT6dvf50LY296bo LQ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dnBtmSOMI3qCFo9FmJWl9WfxHjSJK5KQqVLRraKU05I=; b=iEadjqU7p8/GRQr+Vd0zKZOTtSOjpLilcT7qfL6EJ3474cYcmgIRwfEcRdrSO7dIN6 vmJKAzap8imz6XqGNW524BiMM4DkMavHQ0NsdDhLg03y1h9CVDVeLRPZImJ+ze5rXhEb EPXbo+4+f/DVLgS2Zm5YDRZCQiA3tGFlzRvHHUovU3zBqFp665PEcEzRATfjF5w8BkFw a1GgFKS/hHNOIyaQu7jbZna0uK4pJnr3eQWAI9eIH8JQfRWrfFTVv75O9rlyL+LvpybL j5+QeIz6FAI1W3x3a8BOvQPJ76qLLbwokaNBN3XeugRyhyAMPhuOUr+RrZYp/OeFNjiL gR8Q== X-Gm-Message-State: AOAM530cDL7HglxsUf7kn1iIdSQ6shYa0Wh8Qed16vbMgMEqCxqDeJkZ zocETxFjA72QHEVuyKlMnFEXgQ== X-Google-Smtp-Source: ABdhPJw78hm6xyry1788msKvDaJiA9KH6AqlvKTZo56vyvYluhOxS8hz+N6ckrFwd9dGFHPH4WvFyw== X-Received: by 2002:adf:e50a:: with SMTP id j10mr12017980wrm.71.1595004963587; Fri, 17 Jul 2020 09:56:03 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:03 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Stephen Boyd , Nishant Kamat , Balaji T K , Graeme Gregory , Girish S Ghongdemath , Ambresh K , Oleksandr Kozaruk , Mikko Ylinen Subject: [PATCH 05/30] iio: adc: twl6030-gpadc: Fix some misdocumentation and formatting issues Date: Fri, 17 Jul 2020 17:55:13 +0100 Message-Id: <20200717165538.3275050-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Kerneldoc expects attributes/parameters to be in '@*.: ' format. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/twl6030-gpadc.c:110: warning: Function parameter or member 'ideal' not described in 'twl6030_gpadc_platform_data' drivers/iio/adc/twl6030-gpadc.c:110: warning: Function parameter or member 'channel_to_reg' not described in 'twl6030_gpadc_platform_data' Cc: Stephen Boyd Cc: Nishant Kamat Cc: Balaji T K Cc: Graeme Gregory Cc: Girish S Ghongdemath Cc: Ambresh K Cc: Oleksandr Kozaruk Cc: Mikko Ylinen Signed-off-by: Lee Jones --- drivers/iio/adc/twl6030-gpadc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c index f24148bd15de4..a19a6ce65e390 100644 --- a/drivers/iio/adc/twl6030-gpadc.c +++ b/drivers/iio/adc/twl6030-gpadc.c @@ -94,9 +94,9 @@ struct twl6030_gpadc_data; * struct twl6030_gpadc_platform_data - platform specific data * @nchannels: number of GPADC channels * @iio_channels: iio channels - * @twl6030_ideal: pointer to calibration parameters + * @ideal: pointer to calibration parameters * @start_conversion: pointer to ADC start conversion function - * @channel_to_reg pointer to ADC function to convert channel to + * @channel_to_reg: pointer to ADC function to convert channel to * register address for reading conversion result * @calibrate: pointer to calibration function */ From patchwork Fri Jul 17 16:55:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670767 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 99E9E13B6 for ; Fri, 17 Jul 2020 16:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 814272074B for ; Fri, 17 Jul 2020 16:57:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PKIGtM3D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727049AbgGQQ4I (ORCPT ); Fri, 17 Jul 2020 12:56:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727034AbgGQQ4G (ORCPT ); Fri, 17 Jul 2020 12:56:06 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 587D4C0619D4 for ; Fri, 17 Jul 2020 09:56:06 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id q5so11887781wru.6 for ; Fri, 17 Jul 2020 09:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Nb/tQ5HxMJdwcZU2zmj2JX73dDo4qPaNgdilk8WGn+Q=; b=PKIGtM3D2mbpyKmn3TKhhnoylY/9SJkUrY4ltLFIvfTnvtK22ZcRqj+nCxV7ManVNH PM6fCgKXbO3du9XZekl35+F/HNFxILIuNr89nGvO8ZykWn3ZxeCXbyz16VaOu4wO2s0A Q9DcmJ2djcG9N6cZJyM9u6x9govSwTDegiSXdbmxvOQIY1Z878AgbNMG0RuKNv+rnemV EzgMJbROJp64FD8fLqBQ5/x6fMR5DUBqrLlF4wjYn+UEH7VnSn6FdaexPbS8sXcwCEOv E0U3cqvHiAiXh07wKOKILeRvzBXnnw1GarLo4j//BBH50lLMEkNNCJKmnH4XQX149h+t Qyaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Nb/tQ5HxMJdwcZU2zmj2JX73dDo4qPaNgdilk8WGn+Q=; b=XPu/UuzqXc0prXm3buY9jhIbJ3re2EtyMC6izJKo4dKQG1awqtiCKPChH4bGIYKAl/ A8FNgjcaIhiZTEuqGr+jopzWia0LIdNzi5xsK/8jwwNhMJEfsCSlhN9drQ+P7pDgVMcr tYLKPLVkvl6OQ3Xzy5AJmaZ8ad0yLTxJwj0M5BrcB0Hwgg/yjbY3A/+OUD+lOWy2F4lW ST5lrMPB1S3uojGE4l3ZmRiVFhB43e8+4ZGo3ofIvabFzq18MEygDuiQ81O7pnOqiGvr OuaDb4DMEekCTPXK9MVsRoqF6q8iV8Do801gtKR/IkZbGQM+j/jteMxmtE9Dh9/0tyZd Pqzw== X-Gm-Message-State: AOAM531DXQhpmFIeOTsaiD1T6SZLRMVS7iGp0keP3mwlQ0EEgiqE03jj /uEa4VQfLKCjTPF966uj1mZSVg== X-Google-Smtp-Source: ABdhPJztkgQ/mGf0gxIVfj/VajfXJbHIhm8tYxqIPUW3TqJw+AzgcxbVjtmnL0yYGvZxxCqshqRMsg== X-Received: by 2002:a5d:6452:: with SMTP id d18mr11020033wrw.284.1595004965111; Fri, 17 Jul 2020 09:56:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:04 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Liam Girdwood , Mark Brown , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Silvan Murer , Maxime Roussin-Belanger Subject: [PATCH 06/30] iio: dac: ltc2632: Fix formatting in kerneldoc struct header Date: Fri, 17 Jul 2020 17:55:14 +0100 Message-Id: <20200717165538.3275050-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Kerneldoc expects attributes/parameters to be in '@*.: ' format. Fixes the following W=1 kernel build warning(s): drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'powerdown_cache_mask' not described in 'ltc2632_state' drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'vref_mv' not described in 'ltc2632_state' drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'vref_reg' not described in 'ltc2632_state' Cc: Liam Girdwood Cc: Mark Brown Cc: "Uwe Kleine-König" Cc: Silvan Murer Cc: Maxime Roussin-Belanger Signed-off-by: Lee Jones --- drivers/iio/dac/ltc2632.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c index f891311f05cfe..733f13d3e5df4 100644 --- a/drivers/iio/dac/ltc2632.c +++ b/drivers/iio/dac/ltc2632.c @@ -38,9 +38,9 @@ struct ltc2632_chip_info { /** * struct ltc2632_state - driver instance specific data * @spi_dev: pointer to the spi_device struct - * @powerdown_cache_mask used to show current channel powerdown state - * @vref_mv used reference voltage (internal or external) - * @vref_reg regulator for the reference voltage + * @powerdown_cache_mask: used to show current channel powerdown state + * @vref_mv: used reference voltage (internal or external) + * @vref_reg: regulator for the reference voltage */ struct ltc2632_state { struct spi_device *spi_dev; From patchwork Fri Jul 17 16:55:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670769 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9FE26C1 for ; Fri, 17 Jul 2020 16:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91A3E208DB for ; Fri, 17 Jul 2020 16:57:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nlLaOOQY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbgGQQ5y (ORCPT ); Fri, 17 Jul 2020 12:57:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727040AbgGQQ4I (ORCPT ); Fri, 17 Jul 2020 12:56:08 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DEB7C0619D6 for ; Fri, 17 Jul 2020 09:56:07 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o8so15943409wmh.4 for ; Fri, 17 Jul 2020 09:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E5VMi11gyu7YagowBqZgb+iOtuPEVBAr50ImKPiNX6s=; b=nlLaOOQYdj6COawHywehL+uIslG8GGW7Zd+HR8CE/RBqDIxrYnRaXheKONmsk/d4z4 1253X+HPxeJsfuyIVd2P1SxvASoQnF+ZjxdXfC5/g9ti2j2E8je61o06ktuvArxxQqJa yh919W9bswOHr1uURS4wbh2wOBiJAaL4nsHRFZfXSJH1ThZptLnYShcnAVhUvXEKk4xp SxTodoxyQtaFK7JN7tUzlLsMmDeIGuhoVSUbdJ7LmLjpC8Ccf/J2w43MEkmrYIIhZsZC HuoSVtXelnZqc9x+znqgll3nvr7TUE7ZK0S5MrDyp/FPGH7BFmtvBFv0JIXKlEjm39kX MdoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E5VMi11gyu7YagowBqZgb+iOtuPEVBAr50ImKPiNX6s=; b=kP5efySmZO5fiW39xOh3Rvg8RdPhcfnlPObd6ro6aTsBpbSZdZqvq0dYXEjrF6Bvnl oiIBoDiuMAvCJbvKFv8D4LM2YCATFmut1VQIBmzLAUBuxRN0qoCaP9ivfJBLYn+2T2/t ugfAC2DhtDbJjdOGzZGqn9b/i8LlDUlBMMkikpyDe4qZF9rY80V/iUEkK5WlsNIVsRzb aPjQWNqDxmBx+fzroq+L4N8Z7whE0tJnSu8Pthk/ZZUUGgrhjN0M9/Xm9qnnZ0QDkgNV vuGTC+kXhT9L+5iRHzpWe1wqTn+32+kZD+VUGKi41IYBux63dZoSczyPdOtenm0KziBD LAgw== X-Gm-Message-State: AOAM530cL3xyPQqDORlTh18o4fIyFvdEktgfA4gBV8VwQcHyf54gi+qL 2g4mQuGzhhLhM7ROL4dcLm7ntA== X-Google-Smtp-Source: ABdhPJz/dnU1oVaIfi3DiolGTqevMFpFyFT/sUC0KZbrG5hWrZl4hIOPfOv6eihpEOTuuE/XSpLb7A== X-Received: by 2002:a1c:a986:: with SMTP id s128mr10887191wme.121.1595004966324; Fri, 17 Jul 2020 09:56:06 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:05 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Chuhong Yuan , Dan Leonard Subject: [PATCH 07/30] iio: light: si1145: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 17 Jul 2020 17:55:15 +0100 Message-Id: <20200717165538.3275050-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org No attempt has been made to document any of the demoted functions here Fixes the following W=1 kernel build warning(s): drivers/iio/light/si1145.c:192: warning: Function parameter or member 'data' not described in '__si1145_command_reset' drivers/iio/light/si1145.c:228: warning: Function parameter or member 'data' not described in 'si1145_command' drivers/iio/light/si1145.c:228: warning: Function parameter or member 'cmd' not described in 'si1145_command' drivers/iio/light/si1145.c:1186: warning: Function parameter or member 'trig' not described in 'si1145_trigger_set_state' drivers/iio/light/si1145.c:1186: warning: Function parameter or member 'state' not described in 'si1145_trigger_set_state' Cc: Chuhong Yuan Cc: Dan Leonard Signed-off-by: Lee Jones --- drivers/iio/light/si1145.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c index 0476c2bc81384..37a6a59030929 100644 --- a/drivers/iio/light/si1145.c +++ b/drivers/iio/light/si1145.c @@ -181,7 +181,7 @@ struct si1145_data { int meas_rate; }; -/** +/* * __si1145_command_reset() - Send CMD_NOP and wait for response 0 * * Does not modify data->rsp_seq @@ -215,7 +215,7 @@ static int __si1145_command_reset(struct si1145_data *data) } } -/** +/* * si1145_command() - Execute a command and poll the response register * * All conversion overflows are reported as -EOVERFLOW @@ -1176,7 +1176,7 @@ static const struct iio_buffer_setup_ops si1145_buffer_setup_ops = { .validate_scan_mask = si1145_validate_scan_mask, }; -/** +/* * si1145_trigger_set_state() - Set trigger state * * When not using triggers interrupts are disabled and measurement rate is From patchwork Fri Jul 17 16:55:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670765 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 42C7913B6 for ; Fri, 17 Jul 2020 16:57:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A9DA207DD for ; Fri, 17 Jul 2020 16:57:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eTKat4s5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727101AbgGQQ5n (ORCPT ); Fri, 17 Jul 2020 12:57:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727060AbgGQQ4J (ORCPT ); Fri, 17 Jul 2020 12:56:09 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D88D6C0619D3 for ; Fri, 17 Jul 2020 09:56:08 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 22so15959515wmg.1 for ; Fri, 17 Jul 2020 09:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YT0JMRu5eQoXCKZAUBFbS9kdf7HqY+KCePcGHxfvNYY=; b=eTKat4s5/E2CjyBQFfD4OL1Ried9ygggeHKRbE97/qquwCB2+CYfFiIS6FYHPLNsx5 3bvHk49rpmbB7hewemhLQokS/V6/KSynXxRNFacpI5IIVQ+fMQrB1RyK/ewDBVY73ToY ako+0yfuwsc6WN8/S4LT22mJVi28aSWaKEI8EbCNebD6upedRCYsYFg/7LwdcTjXzG/t jFXi4H8Z4gXXgZ6RanUmbysgAER+yapMU6ZDtSaCQX0aOfrvxKiNpmZpbq9NZSN7EWoN vUY+SBWM+Pe0yMnFXI41l/n+N/+BHK5CFTQDwMCOBeE3d7zZlpHyMJPSUywTDPbWVuJc kaTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YT0JMRu5eQoXCKZAUBFbS9kdf7HqY+KCePcGHxfvNYY=; b=tUGfm6DhEJR4H0IE1w8Spisao59k1p5wSU9u4urLZoQ7XdF7VVltJJ6oL9eYF4leNg aPPu0xo4fVugACEOWwlA1T66oSPEdXVH1VxJFr7WvDXaOhH1IRSZ/DSwxNPRvEF6LY85 kyVxAQZuCOrvIjBLcMxwprQ90Yxj2zjk/6tAZ/oI6Ck+CPyr3ITYpCHExbLzmzM7ejtM e21jptUFDbg8Ac2F8KauOhWvGo6CusPjVjbYNyFgufMHD8MIree9bVbpjtFbqTwkv+MJ 2p8WpZYnfuuCSvsKB6T6YB2RwSjMtTfxWIIokRwSVzsEDV16OhkjMAyi82blXQlLHYax NBtQ== X-Gm-Message-State: AOAM533xKxBfwEuFtjw2uEtibujC77N6DGYUXAAG1kREB9HeZPotfkUI mLIOVortyFRfu5SIo4+FpyDtUA== X-Google-Smtp-Source: ABdhPJzJZIsoV7iAoqalIXWp6mzGqQalHQtp2jPJU/OINo7Arv9yvyl5bvzrXnJxJul0lIZXe1sF6A== X-Received: by 2002:a1c:2e57:: with SMTP id u84mr10869481wmu.52.1595004967573; Fri, 17 Jul 2020 09:56:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:07 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Michael Hennerich , David Veenstra , Graff Yang Subject: [PATCH 08/30] iio: resolver: ad2s1200: Change ordering of compiler attribute macro Date: Fri, 17 Jul 2020 17:55:16 +0100 Message-Id: <20200717165538.3275050-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Kerneldoc gets confused if the variable does not follow the type/attribute definitions. Fixes the following W=1 kernel build warning(s): drivers/iio/resolver/ad2s1200.c:44: warning: Function parameter or member '____cacheline_aligned' not described in 'ad2s1200_state' Cc: Michael Hennerich Cc: David Veenstra Cc: Graff Yang Signed-off-by: Lee Jones --- drivers/iio/resolver/ad2s1200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/resolver/ad2s1200.c b/drivers/iio/resolver/ad2s1200.c index a391f46ee06b7..29cfd57eff9e7 100644 --- a/drivers/iio/resolver/ad2s1200.c +++ b/drivers/iio/resolver/ad2s1200.c @@ -40,7 +40,7 @@ struct ad2s1200_state { struct spi_device *sdev; struct gpio_desc *sample; struct gpio_desc *rdvel; - __be16 rx ____cacheline_aligned; + __be16 ____cacheline_aligned rx; }; static int ad2s1200_read_raw(struct iio_dev *indio_dev, From patchwork Fri Jul 17 16:55:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670763 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E541E6C1 for ; Fri, 17 Jul 2020 16:57:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD8E020775 for ; Fri, 17 Jul 2020 16:57:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZJrx999g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727095AbgGQQ4L (ORCPT ); Fri, 17 Jul 2020 12:56:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727080AbgGQQ4K (ORCPT ); Fri, 17 Jul 2020 12:56:10 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2039C0619D2 for ; Fri, 17 Jul 2020 09:56:09 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id g10so7563406wmc.1 for ; Fri, 17 Jul 2020 09:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aaAEngpMWZcocEAV7ao9KvOaMLVn8ta5ctXWHocndM4=; b=ZJrx999gJcsSLac1AZ9jE6z8jV20FHjvtuuZDeNZG7HmMiRiV1M2DywOLcnLAFsliW fG+mlXYbAxvnbjjZkWjHuF9BYWR/7wF3kKCap0LZMvllWDGAhHjxxvxOQKqYEr+llUqA NGjfzKwMotju6ppU4nTnZ0p+f8xe6VW8fbuxm+mu0xl9f6Y6LXu2vNQ5CnT2vFx49svh vUd1XaBFV/TrXYr+xcMOpmBojGd8ANfmaU/xCxHv9xNfL+9mlNYne7VyXjDAYOWM1sI6 ZG5W9UHH+n2yJf3nXLdLpAC6rmDWlUr25+GdyIS40DPqFWAP68ByyY2LCuBjhNWmyPk1 0V3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aaAEngpMWZcocEAV7ao9KvOaMLVn8ta5ctXWHocndM4=; b=oB0BdGbvyPLo0pp9qk6pwnUx7h31k4TioPnHzL2wTnx5MBd+xCJWioECmPzwvQ4Bw9 ArrMZWmCekQ2DCZ5bfChaQZg6sOUQk05JIFkknwsX8YpLD2alx75TajWpKcdtUCzoEkM tP77lxyLgNstOlKsfHV7+Pbe2ZA+yctD+XWhpBCyvYMPJFfM3/BPobbjlm1sEPECyfdC PDiTNCV19SWbhebMPfEqSOThb0wrcG8MguXkwpDQYPlky3S2nGn8weaTYmFjoR0e9MAf 4VAwvhfnGPfBOLoUb+OR5aA3XB+dVZcpTuucCpxHi4bWqP5MiyJep/4GYWaQgDon+Qbl D1sw== X-Gm-Message-State: AOAM530OsJSdVh/L7omYCvptfs4gSbxffsbYiB5ETcRaM9PizlulQ/qT DRJQ3ymd4YgCZLQZQDW7R3rb5g== X-Google-Smtp-Source: ABdhPJwurLCgsUKBH4m6dcESQTptlhoR0rEHbjcOfc+k2e9gB4ZDfT9hTuuRh6BlyqKKP1waMkjOXA== X-Received: by 2002:a7b:cb92:: with SMTP id m18mr9877767wmi.94.1595004968669; Fri, 17 Jul 2020 09:56:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:08 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Crt Mori Subject: [PATCH 09/30] iio: temperature: mlx90632: Function parameter descriptions must match exactly Date: Fri, 17 Jul 2020 17:55:17 +0100 Message-Id: <20200717165538.3275050-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org '*'s are not welcome in kerneldoc parameter names. Fixes the following W=1 kernel build warning(s): drivers/iio/temperature/mlx90632.c:175: warning: Function parameter or member 'data' not described in 'mlx90632_perform_measurement' Cc: Crt Mori Signed-off-by: Lee Jones Acked-by: Crt Mori --- drivers/iio/temperature/mlx90632.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c index eaca6ba068646..b9a8089be3f63 100644 --- a/drivers/iio/temperature/mlx90632.c +++ b/drivers/iio/temperature/mlx90632.c @@ -164,8 +164,8 @@ static s32 mlx90632_pwr_continuous(struct regmap *regmap) } /** - * mlx90632_perform_measurement - Trigger and retrieve current measurement cycle - * @*data: pointer to mlx90632_data object containing regmap information + * mlx90632_perform_measurement() - Trigger and retrieve current measurement cycle + * @data: pointer to mlx90632_data object containing regmap information * * Perform a measurement and return latest measurement cycle position reported * by sensor. This is a blocking function for 500ms, as that is default sensor From patchwork Fri Jul 17 16:55:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670719 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 692706C1 for ; Fri, 17 Jul 2020 16:56:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5001A208E4 for ; Fri, 17 Jul 2020 16:56:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S9lD2Fgc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbgGQQ4M (ORCPT ); Fri, 17 Jul 2020 12:56:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727086AbgGQQ4L (ORCPT ); Fri, 17 Jul 2020 12:56:11 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0246CC0619D3 for ; Fri, 17 Jul 2020 09:56:11 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id w3so18193551wmi.4 for ; Fri, 17 Jul 2020 09:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hYRcY09U97CVxzwpsH08LkHk/eW62/WS+I9jHKij00E=; b=S9lD2Fgc5UI10/qScFay1KtnmHz3np9XzTgCMLkNWXkkHSEUblJu5387F4Amn6iIwy 6Xo5Ixfr4lMmOoDZ4iinaU70w0+tcHGMflhwfBixXPjyprx4xfBtHrKs3nEbQ2A3I6ba PH9h+zF6K4gmX8i97SRg/00OkGBSw/v7S59w0j3GUhBvDhegdC/XVKBrLXCScupMj3a0 qaCf+F3g1vYRFDRPqBt+2oebbS7YTGjCzxT8dTeXOlB8TMUxtUmkYX0qtGx6xn2eFKl/ bsrIyOak559L1U3wXrbod/rH63Uu/+NP9ZD2bcK/7HiEhpJYvharcDRcBUaZxzyjCERC VvFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hYRcY09U97CVxzwpsH08LkHk/eW62/WS+I9jHKij00E=; b=CwMOhGxuM/NiknhL1ntxc6UfE8ajMfUD0wNLa+ooacLJmOGRN7Kt4FxO1zOjmoRNRA SDFr9M1QLzTeKUZANauYH3YziGcmY+nDG9KmmWLKNnP3HL+KmndQXZOkKS9kFjJBeQ5/ nP1pb/wrQu4KV+kkuzCuct1q5QlH62+atJ8QPiME6z14SONgFpGAt2NDZg7cuZmvtJQK nabqq+Y0wFBW0yHIrZX+iYxglGu9u6xdgaykJNCkmTs0v/ymSPglWxufslM15d+cQ2Im GLMvnIqJzisL5kZWc2TvvGB5hK4KCJgq06Orq6ebxv0Or3Nmo+jJaoidgEWVbMZULZct 8AyQ== X-Gm-Message-State: AOAM533f3FXlqjfh0/RtERTo903ywDwuBomdilzgndxAYSgSOXLrQdRk ChIcLBCY9vBm3W7LI0Zh9wMw3bfrKUbfjw== X-Google-Smtp-Source: ABdhPJwM2SKJU6PP5MTF4FYuwv93umVSuD72RMLXGtklHukYXUTZ51NU5+N+dxBdDALw+BaMxkAJhA== X-Received: by 2002:a1c:dd86:: with SMTP id u128mr9977983wmg.131.1595004969731; Fri, 17 Jul 2020 09:56:09 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:09 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Adriana Reus Subject: [PATCH 10/30] iio: light: us5182d: Fix formatting in kerneldoc function block Date: Fri, 17 Jul 2020 17:55:18 +0100 Message-Id: <20200717165538.3275050-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Kerneldoc expects attributes/parameters to be in '@*.: ' format. Fixes the following W=1 kernel build warning(s): drivers/iio/light/us5182d.c:457: warning: Function parameter or member 'data' not described in 'us5182d_update_dark_th' drivers/iio/light/us5182d.c:457: warning: Function parameter or member 'index' not described in 'us5182d_update_dark_th' drivers/iio/light/us5182d.c:479: warning: Function parameter or member 'data' not described in 'us5182d_apply_scale' drivers/iio/light/us5182d.c:479: warning: Function parameter or member 'index' not described in 'us5182d_apply_scale' Cc: Adriana Reus Signed-off-by: Lee Jones --- drivers/iio/light/us5182d.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c index b995f21a33479..24843597beba5 100644 --- a/drivers/iio/light/us5182d.c +++ b/drivers/iio/light/us5182d.c @@ -446,8 +446,8 @@ static int us5182d_read_raw(struct iio_dev *indio_dev, /** * us5182d_update_dark_th - update Darh_Th registers - * @data us5182d_data structure - * @index index in us5182d_dark_ths array to use for the updated value + * @data: us5182d_data structure + * @index: index in us5182d_dark_ths array to use for the updated value * * Function needs to be called with a lock held because it needs two i2c write * byte operations as these registers (0x27 0x28) don't work in word mode @@ -469,8 +469,8 @@ static int us5182d_update_dark_th(struct us5182d_data *data, int index) /** * us5182d_apply_scale - update the ALS scale - * @data us5182d_data structure - * @index index in us5182d_scales array to use for the updated value + * @data: us5182d_data structure + * @index: index in us5182d_scales array to use for the updated value * * Function needs to be called with a lock held as we're having more than one * i2c operation. From patchwork Fri Jul 17 16:55:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670721 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4604B6C1 for ; Fri, 17 Jul 2020 16:56:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DFDC208E4 for ; Fri, 17 Jul 2020 16:56:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yNPkHK1z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727001AbgGQQ4N (ORCPT ); Fri, 17 Jul 2020 12:56:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727106AbgGQQ4M (ORCPT ); Fri, 17 Jul 2020 12:56:12 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C27EC0619D5 for ; Fri, 17 Jul 2020 09:56:12 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o2so18257237wmh.2 for ; Fri, 17 Jul 2020 09:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p0oUjKd59zMZaiGxgNRXSn/6+OSkd6Llst+aM8IBTWc=; b=yNPkHK1zRA5ix6G8yWlcUoKNJIibFKAQ4kphl5pebJ5dbhCkkiDDttAbMDpxtPjbOf ANaEw0YL+Z4RRuoY6dGRbsFDJMtrLMEWHjNyhtm72oiR0PLfCa3p/a6awZAV4JepQY8G t38WX2mNBcRNYhoMkmNrlEcNUeX5W3rLp0fRirHfA7d9RaK9OdLglhBvRRq5oRKv5ntJ SUxrPXSBg7BMtMtwuoy6k0UQRoamSfOSNgW229eFCxWEJqh0qnJ0wf8DWlweGjaS8NqT z3MKcL49zcmAVUmHLmpdHY98sz+Vm4GuPO3dlQw7xOMzHSuNAomXLDnptzQSM+jKW3tl zgqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p0oUjKd59zMZaiGxgNRXSn/6+OSkd6Llst+aM8IBTWc=; b=rB2YxEoKU+1RdtuaxJDxqqjEaK8+KrZEfF1VRnVX54BzwTjQs8PSncDEjeunAHpNPQ dxFndk3Y3W6lFH5kgHvA6k6RqRvJrWBz/QiRXTD5jQ6u2XmrapOhgCdOtxc37uA0FX4F 0i/oO7IbNiQielGomOMGOrcqefgILvWJWBXPL7DgIp1vY23CX88dlBJKCWHBv+03SnK9 IAS0rV2I4SEUeh9lmk265/XuHNar8mH/XplMfRkXR3lXLmJJiyujkpr+KINMNnGOg8Lp zYOe15kwb4epCigfoPDkvBBcUhJ1YyWM/C7OcZpujBiTazqUXaK0b/j4albOEkQn/C5i VU8g== X-Gm-Message-State: AOAM531nj+IQHrj92laAyJvwZo8TsnQy9O+GkNua6cCUkH/U383mZuYc bhH7fzYl5GusHeuCdpR6aQemrQ== X-Google-Smtp-Source: ABdhPJzGx0h8an30IqO75LbxvOE6R1dZce6G1gw/E5yjUFHsKN1Rz4cLrUZ2G69jijBs0tNvFkzJbg== X-Received: by 2002:a1c:2602:: with SMTP id m2mr10749472wmm.50.1595004970818; Fri, 17 Jul 2020 09:56:10 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:10 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Michael Hennerich Subject: [PATCH 11/30] iio: adc: ad799x: Demote seemingly unintentional kerneldoc header Date: Fri, 17 Jul 2020 17:55:19 +0100 Message-Id: <20200717165538.3275050-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This is the only use of function related kerneldoc in the sourcefile and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/ad799x.c:192: warning: Function parameter or member 'irq' not described in 'ad799x_trigger_handler' drivers/iio/adc/ad799x.c:192: warning: Function parameter or member 'p' not described in 'ad799x_trigger_handler' Cc: Michael Hennerich Signed-off-by: Lee Jones --- drivers/iio/adc/ad799x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c index ef013af1aec07..007ec7ad94752 100644 --- a/drivers/iio/adc/ad799x.c +++ b/drivers/iio/adc/ad799x.c @@ -182,7 +182,7 @@ static int ad799x_update_config(struct ad799x_state *st, u16 config) return 0; } -/** +/* * ad799x_trigger_handler() bh of trigger launched polling to ring buffer * * Currently there is no option in this driver to disable the saving of From patchwork Fri Jul 17 16:55:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670761 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 652DD13B6 for ; Fri, 17 Jul 2020 16:57:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D162207DD for ; Fri, 17 Jul 2020 16:57:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jk/vAi33" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbgGQQ4O (ORCPT ); Fri, 17 Jul 2020 12:56:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727112AbgGQQ4N (ORCPT ); Fri, 17 Jul 2020 12:56:13 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50BDEC0619D2 for ; Fri, 17 Jul 2020 09:56:13 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z15so11863546wrl.8 for ; Fri, 17 Jul 2020 09:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/zlqMOdNrENttDVuszECzN7q6TWwHlOYVdLftB/3VJQ=; b=jk/vAi339AA/fMk2szczMEaYiyDqaysIObBKL143epOkzEsbrOy/ajjwOTrA0vwMUT /bWyfvCp6TXGEVnhaZ4ZaDcBRVN4RJDnXqpooBRlEUvPaDsdpVYgIjGTlXCdj5o6EtuO 0YDQw0X5WWkOKtkQqMOtP7vbDRe4gXA/NdbR9y9+ZmdNhTcjdUNtuu6thLbID5H3K01G QJah2TZW7poRboocoqLyZDaNAvzNKd9wX0hUN2OkQQidQ+xOlloDfaeznOKSx5cAto9v BHqHGIPCLmoThO3pkhPdzzGNZOyT/tVCuucvteQ2aoojXztz82MJxYD8YnYpebsdtTEp Geow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/zlqMOdNrENttDVuszECzN7q6TWwHlOYVdLftB/3VJQ=; b=oJXtjN8fH3UX3WhuNkW7TRAUnUtAXteBkxgix5cp548AwRYiV8zMar9UTo9wccj8Dg ca6wMhq58YN53sZ9dagGArEFFEMQfN6dytqfcLCKbLNQ/WjQE1xGpv365f9Dqsrv83/9 W7ZPvgwicdt8Kl0nRIQeKxALghSnz363Ij/ivnzMtmvL1Dn3EbZtJgoMh2HTKLVS2z05 qZkHP47CGc1TW1mFqG8Rezbi1DoWWqBM2KUrmZUVVc4i7hKpmRitPxrmm64n0xSdciHk +X87DnuO+8mJRnLGUCXUyZn008+CwlG2/UrLkzQOJlny6B04MRCiBVQXXghg1WCPr5ix yzVg== X-Gm-Message-State: AOAM532Zfildc4LRgWxAnbtdUNqwF2IBIuqqOo9QKXNzLW2VyrYHhvRl 1EKBbxlT4IdQIkGEDcdS3J2bNA== X-Google-Smtp-Source: ABdhPJz43TiHR92LcHgmi7oLqVKfizS8glyxX3f/hvC7+wHREvkx8o08FuWHzRz6eQITQ90++yqHPQ== X-Received: by 2002:adf:fcc5:: with SMTP id f5mr12497884wrs.60.1595004972103; Fri, 17 Jul 2020 09:56:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:11 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Michael Hennerich Subject: [PATCH 12/30] iio: dac: ad5504: Fix formatting errors and demote non-compliant kerneldoc Date: Fri, 17 Jul 2020 17:55:20 +0100 Message-Id: <20200717165538.3275050-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Kerneldoc expects attributes/parameters to be in '@*.: ' format. Fixes the following W=1 kernel build warning(s): drivers/iio/dac/ad5504.c:58: warning: Function parameter or member 'pwr_down_mask' not described in 'ad5504_state' drivers/iio/dac/ad5504.c:58: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5504_state' drivers/iio/dac/ad5504.c:64: warning: cannot understand function prototype: 'enum ad5504_supported_device_ids ' Cc: Michael Hennerich Signed-off-by: Lee Jones --- drivers/iio/dac/ad5504.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index c64e6898ff20a..7e4e422ddfefc 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -43,8 +43,8 @@ * @spi: spi_device * @reg: supply regulator * @vref_mv: actual reference voltage used - * @pwr_down_mask power down mask - * @pwr_down_mode current power down mode + * @pwr_down_mask: power down mask + * @pwr_down_mode: current power down mode * @data: transfer buffer */ struct ad5504_state { @@ -57,10 +57,9 @@ struct ad5504_state { __be16 data[2] ____cacheline_aligned; }; -/** +/* * ad5504_supported_device_ids: */ - enum ad5504_supported_device_ids { ID_AD5504, ID_AD5501, From patchwork Fri Jul 17 16:55:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670723 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0BE3B13B6 for ; Fri, 17 Jul 2020 16:56:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E75BB2083B for ; Fri, 17 Jul 2020 16:56:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bgDHQZAm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727790AbgGQQ4Q (ORCPT ); Fri, 17 Jul 2020 12:56:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727782AbgGQQ4P (ORCPT ); Fri, 17 Jul 2020 12:56:15 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B35F4C0619D3 for ; Fri, 17 Jul 2020 09:56:14 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id g10so7563527wmc.1 for ; Fri, 17 Jul 2020 09:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cyqL66bhaPo6pUJYftE+BouP+W8ifTKxcOtS6pP8tIA=; b=bgDHQZAm1Y7zGqco6LHcPFImygLo/eaYHhgO4zR4uqMXJXBH/9/wUXvkgURQEgEcPf vRFq3fHY/XmeaUh/vIQRfq1bADE7GHYiWQH+exNS6KTPZddIkQaaSOTeEE1bi7W2D1mY VxSPWjFBYAHsExqDJeVWJD9VpQGNiY/CcKTKKEjWbytzE9T9GORFrOXAmRDKAUscog6q vSo5MTT6YhP/nJK4HnudqudhwFB9qB4kRLz1I2/7IrgKaw858ntypQ4Hps0xQ8t6V+Ef ySaRfcZdo60TpEiSnm9Cf26IdXLDFZ1NvK3lpAsBAF9Jmw26IZJc/czIvlbIyh/c7XP1 xz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cyqL66bhaPo6pUJYftE+BouP+W8ifTKxcOtS6pP8tIA=; b=lVT7ChefAerqi9Z3uyYl35oRe9X8i3cnGq56uaYFL2CSyR0AX9+fw6cunkxnzR01XZ UdLcseCbLDQ0pVDS7QMYSePA2cQ4m3n9SFvyMjQvjbBZp7niWZoRswpPA8bVruKGeJZ3 kRmQstt3wN+iQ0MZyHm4cIaizzcH+bAxYrxeCOpb3iEhM+EEHWCBxxmcvSGg1YuoBTpP lRGf7iWO/BdCkDDsD4/TOxJEurMLI6KvgSSlqdhxOOdwdioB0htmlsPpVwhDUrHLpwYI 9bfdhAUX7gxRPEGyPlmng9QIc2dI2XE+I/desbxmaY/xlVnJLK0oLSywSwz6JwUfHiWy 3KpA== X-Gm-Message-State: AOAM531uiwDp8xvErsODJ06lovO3NH6o+Y4ppBm5Ar+wBO2MNkt5ls3n s398OsgLzV/rm20Oa0JIExgGkA== X-Google-Smtp-Source: ABdhPJzkOkfui+os8Qw2Xmd5y3cEYFZKIpsg38EFiEnyePI47o5q7jh1WVLfiLgGxOTQOSGbdLUnzQ== X-Received: by 2002:a1c:3b02:: with SMTP id i2mr9952906wma.24.1595004973487; Fri, 17 Jul 2020 09:56:13 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:12 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Maxime Ripard Subject: [PATCH 13/30] iio: adc: at91_adc: Fix 'bad line' warning Date: Fri, 17 Jul 2020 17:55:21 +0100 Message-Id: <20200717165538.3275050-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org All lines should start with ' *'. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/at91_adc.c:160: warning: bad line: (Interruptions registers mostly) Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: Maxime Ripard Signed-off-by: Lee Jones --- drivers/iio/adc/at91_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c index 0368b6dc6d60a..c5ea75cd88fa8 100644 --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -157,7 +157,7 @@ * struct at91_adc_reg_desc - Various informations relative to registers * @channel_base: Base offset for the channel data registers * @drdy_mask: Mask of the DRDY field in the relevant registers - (Interruptions registers mostly) + * (Interruptions registers mostly) * @status_register: Offset of the Interrupt Status Register * @trigger_register: Offset of the Trigger setup register * @mr_prescal_mask: Mask of the PRESCAL field in the adc MR register From patchwork Fri Jul 17 16:55:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670759 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3CB076C1 for ; Fri, 17 Jul 2020 16:57:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2482F207DD for ; Fri, 17 Jul 2020 16:57:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J3pv3dEp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727815AbgGQQ5c (ORCPT ); Fri, 17 Jul 2020 12:57:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727787AbgGQQ4Q (ORCPT ); Fri, 17 Jul 2020 12:56:16 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9C1BC0619D2 for ; Fri, 17 Jul 2020 09:56:15 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id l2so18247231wmf.0 for ; Fri, 17 Jul 2020 09:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=plt40HpdQkbHvQwXOxo5if7eJzPHGlolB+ggPBJMqPY=; b=J3pv3dEpGgwSpIhA8EtE+KYVOjgrt0YdOk9dunGzbdUkQbLEYxYoGZMXA/1+5Dsf6J LAnr+hUnpEB7AeU8OqxnfF26WEuXm4lWDRmDeoL36lGILsADFMR1IdvzckJY3SYYlldF mibf5B2agpVngiFAxjk+7s7m4/KAg4HlPudlDNLfPq99WLoEt87yffqOweAlSfAS4Lur 2FXPzVUcW/EXE7IGVR8sfgl4V7kWJPQDfJfT/YdlIKr2Hc744g9gwCSIJhZqkogyavXZ E2HzHQB5DFaRVAv3VkczC5FPPAZ0IFvDeBTdDxXn+EMXhCNSx8CwhmhfIpZvHttn0fuI m+cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=plt40HpdQkbHvQwXOxo5if7eJzPHGlolB+ggPBJMqPY=; b=feE00SJy78s6CXl9hUMcvrfjDX0D99j1aCzI8rx6bG6gAlN0nz141N3YnAXB8+7JeS iRSGvSJKu1CIDA1Tzdgb0T1rRPG04pdkVeAfHEDxjavUtjgAQXxPPNWqnZDOi3vH73o4 lWhV2F0oZmdQT8HDhxZ5tV3WUZa9Mm0xNVnEN4m9xDvGMG83sf2A61ZDyD9NfHjp4yXa qPUAg5zMRbfz2hp4qBcrzSLSL0nkU6ixqxWuzFNhS9RPfw1t3olKWbXMEzkW6VfyRsPb 9b8Q6fXGDK16HKnW80tqIRmm45YIfXLQ71dCEx9C4lRFjcwChX81Dq6UtZ2U9L8E5NhQ XTSw== X-Gm-Message-State: AOAM532KgT4Rg8FxrUurx4zvpLC3O7uw8EigidNu1l+9XzngWeYUyvsA ENlandVsaT/VJG8Qo2fIoWAM0A== X-Google-Smtp-Source: ABdhPJyP6B7HseRg5kS7ZkPAzot7yMGjQw7JXKLcdP34P/c6n3iGcQGWvUN176x3H3wgk3Zx9jh1xQ== X-Received: by 2002:a1c:8117:: with SMTP id c23mr9735654wmd.157.1595004974509; Fri, 17 Jul 2020 09:56:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:13 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Ludovic Desroches , Eugen Hristev , Nicolas Ferre , Alexandre Belloni Subject: [PATCH 14/30] iio: adc: at91-sama5d2_adc: Struct kerneldoc titles need to start with 'struct ' Date: Fri, 17 Jul 2020 17:55:22 +0100 Message-Id: <20200717165538.3275050-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/iio/adc/at91-sama5d2_adc.c:360: warning: cannot understand function prototype: 'struct at91_adc_dma ' drivers/iio/adc/at91-sama5d2_adc.c:379: warning: cannot understand function prototype: 'struct at91_adc_touch ' Cc: Ludovic Desroches Cc: Eugen Hristev Cc: Nicolas Ferre Cc: Alexandre Belloni Signed-off-by: Lee Jones --- drivers/iio/adc/at91-sama5d2_adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 9abbbdcc74200..c7fe749419b28 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -347,7 +347,7 @@ struct at91_adc_trigger { }; /** - * at91_adc_dma - at91-sama5d2 dma information struct + * struct at91_adc_dma - at91-sama5d2 dma information struct * @dma_chan: the dma channel acquired * @rx_buf: dma coherent allocated area * @rx_dma_buf: dma handler for the buffer @@ -369,7 +369,7 @@ struct at91_adc_dma { }; /** - * at91_adc_touch - at91-sama5d2 touchscreen information struct + * struct at91_adc_touch - at91-sama5d2 touchscreen information struct * @sample_period_val: the value for periodic trigger interval * @touching: is the pen touching the screen or not * @x_pos: temporary placeholder for pressure computation From patchwork Fri Jul 17 16:55:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670757 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E69EB6C1 for ; Fri, 17 Jul 2020 16:57:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8E82207DD for ; Fri, 17 Jul 2020 16:57:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WmxyBLdP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727826AbgGQQ52 (ORCPT ); Fri, 17 Jul 2020 12:57:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727817AbgGQQ4R (ORCPT ); Fri, 17 Jul 2020 12:56:17 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E5D4C0619D3 for ; Fri, 17 Jul 2020 09:56:17 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id q5so11888286wru.6 for ; Fri, 17 Jul 2020 09:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u3fyiDGFdlbLNYGeR71nnz3VOwvLrObA2piXc/v38Go=; b=WmxyBLdPFiTMIB9rmrspNDNftuqma7nAEm/9RcMOSzJjAD6D4inZeyskwPmwX//ID1 OShWYYXvlSNN4qj0U0acKpFl7lOtvjTsxso+bNYIMiLzRTdfLMGwxcGgpVzjS8IEpKUm Xowpf4oECwAHxwFRyVWwGAevH72O9bR1DZ/huytShBk8GwpB947CDWPSNqFeS4MfQPqM l/hX8yK68gPPR9uQogO9Xow2x3akFFCq42VLZ0RmTJzyYmFkbBd37ORm+y863MZshCgY ZbsAXTLVmyhKDyocDIzGMAUUtGb98XbPdJx3c0uGTY+yRQ2nb+VTKGcX4CQ/AB0ri0xw I3kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u3fyiDGFdlbLNYGeR71nnz3VOwvLrObA2piXc/v38Go=; b=e4yujTxvJ3/1kFBzVyYZLgabAJXeB1kgG5EoKSuoxfYz65WjIchNDSIptet5BwmW/y k/5x7cZnoeGGlDJKjPAXd2vYVQ4Lc+NWniLNz9E72jG/Nnmx4yM3ySWwHdRItpbCZRMK yh/AgQfcrF1ISQJhqJMbenVL/M94Hym1eUBkLM3oIHBosHqwOvQeZTNb9h+BRRohJwp7 BCcUuVxShA9U50l0bH24QHvB32ZenBea2wk6hA/L8vlO+XxLiQuRoEfEWetPy4i2snCK 2eaoxYSqZKy+O8xL1PQVhfrCdmYLNcEQ57VHJ2tE/erKed2JXD+qDw/eKEyJyp9NiGU6 9jRw== X-Gm-Message-State: AOAM533OOqbb9sPFdtHMeWUEsGrR2eaqElXfbw7uonJ/uZbAgb+jKctO bJni+wtq1Qul2unKS2KHXcLszw== X-Google-Smtp-Source: ABdhPJyxGlgmwpdyXgtW7B3rqiCsiz02bfeSDBMqpGeL+5khgX6H2eUvHJBFwak6Kl9QbaLMkwZ5Sg== X-Received: by 2002:adf:ef46:: with SMTP id c6mr11237076wrp.34.1595004975766; Fri, 17 Jul 2020 09:56:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:15 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Tony Lindgren Subject: [PATCH 15/30] iio: adc: cpcap-adc: Demote seemingly unintentional kerneldoc header Date: Fri, 17 Jul 2020 17:55:23 +0100 Message-Id: <20200717165538.3275050-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org None of the headers demoted here provide any descriptions. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'ato_in' not described in 'cpcap_adc_ato' drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_in' not described in 'cpcap_adc_ato' drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'adc_ps_factor_in' not described in 'cpcap_adc_ato' drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_ps_factor_in' not described in 'cpcap_adc_ato' drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'ato_out' not described in 'cpcap_adc_ato' drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_out' not described in 'cpcap_adc_ato' drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'adc_ps_factor_out' not described in 'cpcap_adc_ato' drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_ps_factor_out' not described in 'cpcap_adc_ato' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD0' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTP' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_VBUS' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD3' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BPLUS_AD4' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_CHG_ISENSE' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTI' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_USB_ID' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD8' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD9' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_LICELL' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_HV_BATTP' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSX1_AD12' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSX2_AD13' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSY1_AD14' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSY2_AD15' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTP_PI16' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTI_PI17' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_CHANNEL_NUM' not described in enum 'cpcap_adc_channel' drivers/iio/adc/cpcap-adc.c:165: warning: Enum value 'CPCAP_ADC_TIMING_IMM' not described in enum 'cpcap_adc_timing' drivers/iio/adc/cpcap-adc.c:165: warning: Enum value 'CPCAP_ADC_TIMING_IN' not described in enum 'cpcap_adc_timing' drivers/iio/adc/cpcap-adc.c:165: warning: Enum value 'CPCAP_ADC_TIMING_OUT' not described in enum 'cpcap_adc_timing' Cc: Tony Lindgren Signed-off-by: Lee Jones --- drivers/iio/adc/cpcap-adc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/cpcap-adc.c b/drivers/iio/adc/cpcap-adc.c index 5086a337f4c9a..be638fcec03f6 100644 --- a/drivers/iio/adc/cpcap-adc.c +++ b/drivers/iio/adc/cpcap-adc.c @@ -82,7 +82,7 @@ #define CPCAP_ADC_MAX_RETRIES 5 /* Calibration */ -/** +/* * struct cpcap_adc_ato - timing settings for cpcap adc * * Unfortunately no cpcap documentation available, please document when @@ -121,7 +121,7 @@ struct cpcap_adc { bool done; }; -/** +/* * enum cpcap_adc_channel - cpcap adc channels */ enum cpcap_adc_channel { @@ -152,7 +152,7 @@ enum cpcap_adc_channel { CPCAP_ADC_CHANNEL_NUM, }; -/** +/* * enum cpcap_adc_timing - cpcap adc timing options * * CPCAP_ADC_TIMING_IMM seems to be immediate with no timings. From patchwork Fri Jul 17 16:55:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670755 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 46CB96C1 for ; Fri, 17 Jul 2020 16:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D7B62076D for ; Fri, 17 Jul 2020 16:57:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gaLDHhRp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727870AbgGQQ51 (ORCPT ); Fri, 17 Jul 2020 12:57:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727826AbgGQQ4S (ORCPT ); Fri, 17 Jul 2020 12:56:18 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1391DC0619D4 for ; Fri, 17 Jul 2020 09:56:18 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o2so18257630wmh.2 for ; Fri, 17 Jul 2020 09:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Rc1gRiFLnICYkzZdrxG6wdBxb95IGqTfJLICTNXyrKU=; b=gaLDHhRpwR3ip7ByImygRyE6T8KMhCeOwINKf9nI53AuRbCKThVlZPnVDsTMqvNHJr 6eHtvKSEeHZjAueJq6jCt0C+F6/cIB+tiCdInlV3ZF9xmO3wWYA0yy5/VwsJOPWe2/8q +VfSlqQz/dug0MDcHgCo/egx2F0DXeTGm0/phPlQlUgla81RscMXC/yUh0b7+1im/Y4A 7LV1NJT/INVpyBK42/jJ4xS8iUBaMYfzX+LyFdTfCdoFBM/1K26iPwbzAFVnFpJin3l9 xYMHogy8enMH8Ek2t1lbTVQxdDlwuYwKO9RREuiWNY0pTU7erHOC062a7K11ocyst6xX 3/cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Rc1gRiFLnICYkzZdrxG6wdBxb95IGqTfJLICTNXyrKU=; b=MUBNFs8eL9kD8VLwKrJkMjys15LmDjuLPKbqiZZ0SUwuaC4kDkkVGOx1P6sL/e8UmD 6qg6EEpnynQcrO6I2s/TFR5pTIY7wKRG202k8yGm3RPtiKE7bIB94U4ET3ny1FAAdkab GEC13SrVsP+WF0bTD1tPz4G8jKXcs5XmegHwDwRvhsBNfcIqC9bbdWZJ7o5ZUPyeOXjK YjG6PooYuzCiA3B4Bk5DeXKDmEOTInbT2sbV1ECVk0g0LekY9JSfYc2I8jldMBeALw01 BT4kPZPtPE+XH6O49lbcGx5czPTN+XOUzPNVT27CWcXPiw355KN8+rUmnJSbkkuzwLfo +YEg== X-Gm-Message-State: AOAM532MD/eADEq6BYKoEMYayEHoJzsTcEumRyDBEcfuMhiIh4Gbm8Db S/OihlQnB2r9LIJsnma5CAUiOg== X-Google-Smtp-Source: ABdhPJw/s3gzHYxgswWOyt+xbyCAaW5RvtiZ/PHKOLabQjqpNF/+Uib5bhmOWwZTw4eLFK5k75RoBQ== X-Received: by 2002:a7b:c313:: with SMTP id k19mr10345994wmj.67.1595004976743; Fri, 17 Jul 2020 09:56:16 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:16 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Christophe JAILLET Subject: [PATCH 16/30] iio: accel: sca3000: Fix 2 misspellings and demote nonconforming kerneldocs Date: Fri, 17 Jul 2020 17:55:24 +0100 Message-Id: <20200717165538.3275050-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/iio/accel/sca3000.c:210: warning: Function parameter or member 'mot_det_mult_xz' not described in 'sca3000_chip_info' drivers/iio/accel/sca3000.c:210: warning: Function parameter or member 'mot_det_mult_y' not described in 'sca3000_chip_info' drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'indio_dev' not described in 'sca3000_read_event_value' drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'chan' not described in 'sca3000_read_event_value' drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'type' not described in 'sca3000_read_event_value' drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'dir' not described in 'sca3000_read_event_value' drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'info' not described in 'sca3000_read_event_value' drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'val' not described in 'sca3000_read_event_value' drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'val2' not described in 'sca3000_read_event_value' drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'indio_dev' not described in 'sca3000_read_event_config' drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'chan' not described in 'sca3000_read_event_config' drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'type' not described in 'sca3000_read_event_config' drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'dir' not described in 'sca3000_read_event_config' Cc: Christophe JAILLET Signed-off-by: Lee Jones --- drivers/iio/accel/sca3000.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 6e429072e44a4..3952187166ffa 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -186,9 +186,9 @@ struct sca3000_state { * @option_mode_2_freq: option mode 2 sampling frequency * @option_mode_2_3db_freq: 3db cutoff frequency of the low pass filter for * the second option mode. - * @mod_det_mult_xz: Bit wise multipliers to calculate the threshold + * @mot_det_mult_xz: Bit wise multipliers to calculate the threshold * for motion detection in the x and z axis. - * @mod_det_mult_y: Bit wise multipliers to calculate the threshold + * @mot_det_mult_y: Bit wise multipliers to calculate the threshold * for motion detection in the y axis. * * This structure is used to hold information about the functionality of a given @@ -859,9 +859,9 @@ static ssize_t sca3000_read_av_freq(struct device *dev, */ static IIO_DEV_ATTR_SAMP_FREQ_AVAIL(sca3000_read_av_freq); -/** +/* * sca3000_read_event_value() - query of a threshold or period - **/ + */ static int sca3000_read_event_value(struct iio_dev *indio_dev, const struct iio_chan_spec *chan, enum iio_event_type type, @@ -1100,9 +1100,9 @@ static irqreturn_t sca3000_event_handler(int irq, void *private) return IRQ_HANDLED; } -/** +/* * sca3000_read_event_config() what events are enabled - **/ + */ static int sca3000_read_event_config(struct iio_dev *indio_dev, const struct iio_chan_spec *chan, enum iio_event_type type, From patchwork Fri Jul 17 16:55:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670751 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3CAC613B6 for ; Fri, 17 Jul 2020 16:57:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23CE520737 for ; Fri, 17 Jul 2020 16:57:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uGY7fLW6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727786AbgGQQ4U (ORCPT ); Fri, 17 Jul 2020 12:56:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727848AbgGQQ4T (ORCPT ); Fri, 17 Jul 2020 12:56:19 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55522C0619D7 for ; Fri, 17 Jul 2020 09:56:19 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id w3so18194037wmi.4 for ; Fri, 17 Jul 2020 09:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l9KL9HYXYgn6Rpl6BIijuJhUjr4NXdIWWmHfn/aX7y4=; b=uGY7fLW6qHw0et20UC3kHdd/8MYDxlSOWeQea54xURu68895NqIfNpQmb7zeDx2jal BmiDZWuiJCPY/VZmfubpUqLVnO0T3Yb+tul7GQODb1HKyfDZYhhVgDQtoUOTznE8TWSc eZggPH8MYF1UZ14ZnuOAa7P6PU/qpUjLaXR9oxCQDwwx6AvPeadxxoGS7680CWMDBcIV 9iQoaCYJy918i0CcOWNFVJvBmnFRBZerJZOffW7GOLXYRm/kAzI6ECQ9+TcVqmt43rRY 58jPPxGOl6Zn8kf63cwptde45XH8vb5uxq+thHdJFhAi495FjquGtGjXoCZgiaB0z9K9 o3/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l9KL9HYXYgn6Rpl6BIijuJhUjr4NXdIWWmHfn/aX7y4=; b=o655yx7zXHd6cmhu03pXcQ2CF45xrLCYUB956glHMPTpoai/djsxO4Jzt7t7wIN2iQ mxmKQ0fsZnAB6O4ZWzK2WMZKnFOMP4nXzCjooz8fxxNfkBWnxYwVy9nP1yqAbj5nENvw 0NbJ7dyIcV1oIkJ9M3C4hA0E0OmugRchiqsfvkyg+ZQnURh4zeX+y1WJNBrKDgq5MQB9 jsaqyP+S2iNlSY4T06nj5JWPr4vhCHjaIoSUEvd7YuPqhSa/LP6Snp2k/YbJNiqGcLlC w3M3AR6K7w0AtFJVAvsLgNpdTf5mylrv0U5ljb/h0zb39WOSoANm/U1D/d3df4EqiLeg Gbgw== X-Gm-Message-State: AOAM532vM5YyQpDFcFoPepjqm8G+d5OaJLz/D3hgSQ9XCsFseQaI5dzJ PZIb75/IkRB4F8eZ69yDTkrmKw== X-Google-Smtp-Source: ABdhPJwolaFtALJ8b06cyO8m7AqyQP6KwwYk6G75p3joMVOgZdxFOGPzU5mARmnYEYjb71TVU+u7tQ== X-Received: by 2002:a1c:2e57:: with SMTP id u84mr10870067wmu.52.1595004978069; Fri, 17 Jul 2020 09:56:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:17 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Michael Hennerich Subject: [PATCH 17/30] iio: gyro: adxrs450: Change ordering of compiler attribute macro Date: Fri, 17 Jul 2020 17:55:25 +0100 Message-Id: <20200717165538.3275050-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Kerneldoc gets confused if the variable does not follow the type/attribute definitions. Fixes the following W=1 kernel build warning(s): drivers/iio/gyro/adxrs450.c:79: warning: Function parameter or member '____cacheline_aligned' not described in 'adxrs450_state' Cc: Michael Hennerich Signed-off-by: Lee Jones --- drivers/iio/gyro/adxrs450.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/adxrs450.c b/drivers/iio/gyro/adxrs450.c index b00c0eb442493..e00b97e30cf9d 100644 --- a/drivers/iio/gyro/adxrs450.c +++ b/drivers/iio/gyro/adxrs450.c @@ -73,7 +73,7 @@ enum { struct adxrs450_state { struct spi_device *us; struct mutex buf_lock; - __be32 tx ____cacheline_aligned; + __be32 ____cacheline_aligned tx; __be32 rx; }; From patchwork Fri Jul 17 16:55:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670753 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 35E8D6C1 for ; Fri, 17 Jul 2020 16:57:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14C572076D for ; Fri, 17 Jul 2020 16:57:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y7RlUwAs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728153AbgGQQ5V (ORCPT ); Fri, 17 Jul 2020 12:57:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727851AbgGQQ4U (ORCPT ); Fri, 17 Jul 2020 12:56:20 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75525C0619D2 for ; Fri, 17 Jul 2020 09:56:20 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z13so11893527wrw.5 for ; Fri, 17 Jul 2020 09:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gU9V9XkM8BF33+dessG5HjZWXsyJ+CY9nfoKsET9XrM=; b=y7RlUwAslcn20lp8Q6SpuGsHWuita63J2y2jjuB8dmc/mBaZ7SlPEDXR7fanf3VyzI 1352ALTbrGTho7FXytizcfKFHDcO0FLAlvBNzGeleG9gw0gkAoh96E01Lxa+/j739tl2 viGPbwRrL4WROvMh987Sw75+d8S9I/XomS4NeO2SA52GVt8FFh/zR0EFT+BNxgQDxFIo NN/FoAK5coZrft4UlsByb0qsDexRW2md4Ps9aCZnp3gI5VRHW7ABGsHKZH6y7r/FRche 8VJYzki7ycyJTl/sQ63y5IqOaM4k6pUDy24kZX972b4M8MCml6LQUsTQXPr/qc7CUDBX Eb9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gU9V9XkM8BF33+dessG5HjZWXsyJ+CY9nfoKsET9XrM=; b=Wx8hjvgyjOj48oBhmDBzuDwbTcwYLDSMzLMYJyRLhFNjd5H3bbLdXC1eRIElf0swGO KDoHKemjQMTP1X64wsA0uVfknaslJa9sX5fSxWFS2fLyM5ylGm1agLMkt6mw7KO7aVVk PsxW5Ktrk6UnS10O40yZB8ehHelcfgl+fe0FQpz+iy3kKO0f9fwMsW6O4e+OV8+rB6Hk YOhBtTKtAmcScZ2dvPjNPU3aHVxRDTwHxDCy1IeT+1mlk/mH1Mak9G+w/8cmvbTg5Npq GSHwdP2B4/pidGHisl73X858yDgb4EShw5yX5H5FsV8XH75GKaezD+onAiWyoYu3eY1H AC1Q== X-Gm-Message-State: AOAM531BYod+/p6N9TGFHbQtap1BGN9JCVLV76AIRuPCfHOcqw7yy14Y Wv2cpBbyQFsy7WnS75hmh9k7xA== X-Google-Smtp-Source: ABdhPJxjeIkO2njxZz5mp9JeV+CXLQhFTO2U0LCW9SQqZCLrasHLZto3lxVp/kjGWy/fZItglO6EnQ== X-Received: by 2002:a5d:5441:: with SMTP id w1mr10743231wrv.381.1595004979124; Fri, 17 Jul 2020 09:56:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:18 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Rui Miguel Silva Subject: [PATCH 18/30] iio: gyro: fxas21002c: Move 'fxas21002c_reg_fields' to the only file its used Date: Fri, 17 Jul 2020 17:55:26 +0100 Message-Id: <20200717165538.3275050-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org 'fxas21002c_reg_fields' is only used in '*core*', meaning that '*i2c*' and '*spi*' complain of a defined but not used const variable. Let's move it into the source file. Fixes the following W=1 kernel build warning(s): In file included from drivers/iio/gyro/fxas21002c_i2c.c:14: drivers/iio/gyro/fxas21002c.h:79:31: warning: ‘fxas21002c_reg_fields’ defined but not used [-Wunused-const-variable=] 79 | static const struct reg_field fxas21002c_reg_fields[] = { | ^~~~~~~~~~~~~~~~~~~~~ In file included from drivers/iio/gyro/fxas21002c_spi.c:14: drivers/iio/gyro/fxas21002c.h:79:31: warning: ‘fxas21002c_reg_fields’ defined but not used [-Wunused-const-variable=] 79 | static const struct reg_field fxas21002c_reg_fields[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Rui Miguel Silva Signed-off-by: Lee Jones Acked-by: Rui Miguel Silva --- drivers/iio/gyro/fxas21002c.h | 66 ------------------------------ drivers/iio/gyro/fxas21002c_core.c | 66 ++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+), 66 deletions(-) diff --git a/drivers/iio/gyro/fxas21002c.h b/drivers/iio/gyro/fxas21002c.h index 566d92de26763..c81cecee121cb 100644 --- a/drivers/iio/gyro/fxas21002c.h +++ b/drivers/iio/gyro/fxas21002c.h @@ -76,72 +76,6 @@ enum fxas21002c_fields { F_MAX_FIELDS, }; -static const struct reg_field fxas21002c_reg_fields[] = { - [F_DR_STATUS] = REG_FIELD(FXAS21002C_REG_STATUS, 0, 7), - [F_OUT_X_MSB] = REG_FIELD(FXAS21002C_REG_OUT_X_MSB, 0, 7), - [F_OUT_X_LSB] = REG_FIELD(FXAS21002C_REG_OUT_X_LSB, 0, 7), - [F_OUT_Y_MSB] = REG_FIELD(FXAS21002C_REG_OUT_Y_MSB, 0, 7), - [F_OUT_Y_LSB] = REG_FIELD(FXAS21002C_REG_OUT_Y_LSB, 0, 7), - [F_OUT_Z_MSB] = REG_FIELD(FXAS21002C_REG_OUT_Z_MSB, 0, 7), - [F_OUT_Z_LSB] = REG_FIELD(FXAS21002C_REG_OUT_Z_LSB, 0, 7), - [F_ZYX_OW] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 7, 7), - [F_Z_OW] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 6, 6), - [F_Y_OW] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 5, 5), - [F_X_OW] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 4, 4), - [F_ZYX_DR] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 3, 3), - [F_Z_DR] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 2, 2), - [F_Y_DR] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 1, 1), - [F_X_DR] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 0, 0), - [F_OVF] = REG_FIELD(FXAS21002C_REG_F_STATUS, 7, 7), - [F_WMKF] = REG_FIELD(FXAS21002C_REG_F_STATUS, 6, 6), - [F_CNT] = REG_FIELD(FXAS21002C_REG_F_STATUS, 0, 5), - [F_MODE] = REG_FIELD(FXAS21002C_REG_F_SETUP, 6, 7), - [F_WMRK] = REG_FIELD(FXAS21002C_REG_F_SETUP, 0, 5), - [F_EVENT] = REG_FIELD(FXAS21002C_REG_F_EVENT, 5, 5), - [FE_TIME] = REG_FIELD(FXAS21002C_REG_F_EVENT, 0, 4), - [F_BOOTEND] = REG_FIELD(FXAS21002C_REG_INT_SRC_FLAG, 3, 3), - [F_SRC_FIFO] = REG_FIELD(FXAS21002C_REG_INT_SRC_FLAG, 2, 2), - [F_SRC_RT] = REG_FIELD(FXAS21002C_REG_INT_SRC_FLAG, 1, 1), - [F_SRC_DRDY] = REG_FIELD(FXAS21002C_REG_INT_SRC_FLAG, 0, 0), - [F_WHO_AM_I] = REG_FIELD(FXAS21002C_REG_WHO_AM_I, 0, 7), - [F_BW] = REG_FIELD(FXAS21002C_REG_CTRL0, 6, 7), - [F_SPIW] = REG_FIELD(FXAS21002C_REG_CTRL0, 5, 5), - [F_SEL] = REG_FIELD(FXAS21002C_REG_CTRL0, 3, 4), - [F_HPF_EN] = REG_FIELD(FXAS21002C_REG_CTRL0, 2, 2), - [F_FS] = REG_FIELD(FXAS21002C_REG_CTRL0, 0, 1), - [F_ELE] = REG_FIELD(FXAS21002C_REG_RT_CFG, 3, 3), - [F_ZTEFE] = REG_FIELD(FXAS21002C_REG_RT_CFG, 2, 2), - [F_YTEFE] = REG_FIELD(FXAS21002C_REG_RT_CFG, 1, 1), - [F_XTEFE] = REG_FIELD(FXAS21002C_REG_RT_CFG, 0, 0), - [F_EA] = REG_FIELD(FXAS21002C_REG_RT_SRC, 6, 6), - [F_ZRT] = REG_FIELD(FXAS21002C_REG_RT_SRC, 5, 5), - [F_ZRT_POL] = REG_FIELD(FXAS21002C_REG_RT_SRC, 4, 4), - [F_YRT] = REG_FIELD(FXAS21002C_REG_RT_SRC, 3, 3), - [F_YRT_POL] = REG_FIELD(FXAS21002C_REG_RT_SRC, 2, 2), - [F_XRT] = REG_FIELD(FXAS21002C_REG_RT_SRC, 1, 1), - [F_XRT_POL] = REG_FIELD(FXAS21002C_REG_RT_SRC, 0, 0), - [F_DBCNTM] = REG_FIELD(FXAS21002C_REG_RT_THS, 7, 7), - [F_THS] = REG_FIELD(FXAS21002C_REG_RT_SRC, 0, 6), - [F_RT_COUNT] = REG_FIELD(FXAS21002C_REG_RT_COUNT, 0, 7), - [F_TEMP] = REG_FIELD(FXAS21002C_REG_TEMP, 0, 7), - [F_RST] = REG_FIELD(FXAS21002C_REG_CTRL1, 6, 6), - [F_ST] = REG_FIELD(FXAS21002C_REG_CTRL1, 5, 5), - [F_DR] = REG_FIELD(FXAS21002C_REG_CTRL1, 2, 4), - [F_ACTIVE] = REG_FIELD(FXAS21002C_REG_CTRL1, 1, 1), - [F_READY] = REG_FIELD(FXAS21002C_REG_CTRL1, 0, 0), - [F_INT_CFG_FIFO] = REG_FIELD(FXAS21002C_REG_CTRL2, 7, 7), - [F_INT_EN_FIFO] = REG_FIELD(FXAS21002C_REG_CTRL2, 6, 6), - [F_INT_CFG_RT] = REG_FIELD(FXAS21002C_REG_CTRL2, 5, 5), - [F_INT_EN_RT] = REG_FIELD(FXAS21002C_REG_CTRL2, 4, 4), - [F_INT_CFG_DRDY] = REG_FIELD(FXAS21002C_REG_CTRL2, 3, 3), - [F_INT_EN_DRDY] = REG_FIELD(FXAS21002C_REG_CTRL2, 2, 2), - [F_IPOL] = REG_FIELD(FXAS21002C_REG_CTRL2, 1, 1), - [F_PP_OD] = REG_FIELD(FXAS21002C_REG_CTRL2, 0, 0), - [F_WRAPTOONE] = REG_FIELD(FXAS21002C_REG_CTRL3, 3, 3), - [F_EXTCTRLEN] = REG_FIELD(FXAS21002C_REG_CTRL3, 2, 2), - [F_FS_DOUBLE] = REG_FIELD(FXAS21002C_REG_CTRL3, 0, 0), -}; - extern const struct dev_pm_ops fxas21002c_pm_ops; int fxas21002c_core_probe(struct device *dev, struct regmap *regmap, int irq, diff --git a/drivers/iio/gyro/fxas21002c_core.c b/drivers/iio/gyro/fxas21002c_core.c index 89d2bb2282eac..f20033afc714c 100644 --- a/drivers/iio/gyro/fxas21002c_core.c +++ b/drivers/iio/gyro/fxas21002c_core.c @@ -42,6 +42,72 @@ enum fxas21002c_mode_state { #define FXAS21002C_AXIS_TO_REG(axis) (FXAS21002C_REG_OUT_X_MSB + ((axis) * 2)) +static const struct reg_field fxas21002c_reg_fields[] = { + [F_DR_STATUS] = REG_FIELD(FXAS21002C_REG_STATUS, 0, 7), + [F_OUT_X_MSB] = REG_FIELD(FXAS21002C_REG_OUT_X_MSB, 0, 7), + [F_OUT_X_LSB] = REG_FIELD(FXAS21002C_REG_OUT_X_LSB, 0, 7), + [F_OUT_Y_MSB] = REG_FIELD(FXAS21002C_REG_OUT_Y_MSB, 0, 7), + [F_OUT_Y_LSB] = REG_FIELD(FXAS21002C_REG_OUT_Y_LSB, 0, 7), + [F_OUT_Z_MSB] = REG_FIELD(FXAS21002C_REG_OUT_Z_MSB, 0, 7), + [F_OUT_Z_LSB] = REG_FIELD(FXAS21002C_REG_OUT_Z_LSB, 0, 7), + [F_ZYX_OW] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 7, 7), + [F_Z_OW] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 6, 6), + [F_Y_OW] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 5, 5), + [F_X_OW] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 4, 4), + [F_ZYX_DR] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 3, 3), + [F_Z_DR] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 2, 2), + [F_Y_DR] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 1, 1), + [F_X_DR] = REG_FIELD(FXAS21002C_REG_DR_STATUS, 0, 0), + [F_OVF] = REG_FIELD(FXAS21002C_REG_F_STATUS, 7, 7), + [F_WMKF] = REG_FIELD(FXAS21002C_REG_F_STATUS, 6, 6), + [F_CNT] = REG_FIELD(FXAS21002C_REG_F_STATUS, 0, 5), + [F_MODE] = REG_FIELD(FXAS21002C_REG_F_SETUP, 6, 7), + [F_WMRK] = REG_FIELD(FXAS21002C_REG_F_SETUP, 0, 5), + [F_EVENT] = REG_FIELD(FXAS21002C_REG_F_EVENT, 5, 5), + [FE_TIME] = REG_FIELD(FXAS21002C_REG_F_EVENT, 0, 4), + [F_BOOTEND] = REG_FIELD(FXAS21002C_REG_INT_SRC_FLAG, 3, 3), + [F_SRC_FIFO] = REG_FIELD(FXAS21002C_REG_INT_SRC_FLAG, 2, 2), + [F_SRC_RT] = REG_FIELD(FXAS21002C_REG_INT_SRC_FLAG, 1, 1), + [F_SRC_DRDY] = REG_FIELD(FXAS21002C_REG_INT_SRC_FLAG, 0, 0), + [F_WHO_AM_I] = REG_FIELD(FXAS21002C_REG_WHO_AM_I, 0, 7), + [F_BW] = REG_FIELD(FXAS21002C_REG_CTRL0, 6, 7), + [F_SPIW] = REG_FIELD(FXAS21002C_REG_CTRL0, 5, 5), + [F_SEL] = REG_FIELD(FXAS21002C_REG_CTRL0, 3, 4), + [F_HPF_EN] = REG_FIELD(FXAS21002C_REG_CTRL0, 2, 2), + [F_FS] = REG_FIELD(FXAS21002C_REG_CTRL0, 0, 1), + [F_ELE] = REG_FIELD(FXAS21002C_REG_RT_CFG, 3, 3), + [F_ZTEFE] = REG_FIELD(FXAS21002C_REG_RT_CFG, 2, 2), + [F_YTEFE] = REG_FIELD(FXAS21002C_REG_RT_CFG, 1, 1), + [F_XTEFE] = REG_FIELD(FXAS21002C_REG_RT_CFG, 0, 0), + [F_EA] = REG_FIELD(FXAS21002C_REG_RT_SRC, 6, 6), + [F_ZRT] = REG_FIELD(FXAS21002C_REG_RT_SRC, 5, 5), + [F_ZRT_POL] = REG_FIELD(FXAS21002C_REG_RT_SRC, 4, 4), + [F_YRT] = REG_FIELD(FXAS21002C_REG_RT_SRC, 3, 3), + [F_YRT_POL] = REG_FIELD(FXAS21002C_REG_RT_SRC, 2, 2), + [F_XRT] = REG_FIELD(FXAS21002C_REG_RT_SRC, 1, 1), + [F_XRT_POL] = REG_FIELD(FXAS21002C_REG_RT_SRC, 0, 0), + [F_DBCNTM] = REG_FIELD(FXAS21002C_REG_RT_THS, 7, 7), + [F_THS] = REG_FIELD(FXAS21002C_REG_RT_SRC, 0, 6), + [F_RT_COUNT] = REG_FIELD(FXAS21002C_REG_RT_COUNT, 0, 7), + [F_TEMP] = REG_FIELD(FXAS21002C_REG_TEMP, 0, 7), + [F_RST] = REG_FIELD(FXAS21002C_REG_CTRL1, 6, 6), + [F_ST] = REG_FIELD(FXAS21002C_REG_CTRL1, 5, 5), + [F_DR] = REG_FIELD(FXAS21002C_REG_CTRL1, 2, 4), + [F_ACTIVE] = REG_FIELD(FXAS21002C_REG_CTRL1, 1, 1), + [F_READY] = REG_FIELD(FXAS21002C_REG_CTRL1, 0, 0), + [F_INT_CFG_FIFO] = REG_FIELD(FXAS21002C_REG_CTRL2, 7, 7), + [F_INT_EN_FIFO] = REG_FIELD(FXAS21002C_REG_CTRL2, 6, 6), + [F_INT_CFG_RT] = REG_FIELD(FXAS21002C_REG_CTRL2, 5, 5), + [F_INT_EN_RT] = REG_FIELD(FXAS21002C_REG_CTRL2, 4, 4), + [F_INT_CFG_DRDY] = REG_FIELD(FXAS21002C_REG_CTRL2, 3, 3), + [F_INT_EN_DRDY] = REG_FIELD(FXAS21002C_REG_CTRL2, 2, 2), + [F_IPOL] = REG_FIELD(FXAS21002C_REG_CTRL2, 1, 1), + [F_PP_OD] = REG_FIELD(FXAS21002C_REG_CTRL2, 0, 0), + [F_WRAPTOONE] = REG_FIELD(FXAS21002C_REG_CTRL3, 3, 3), + [F_EXTCTRLEN] = REG_FIELD(FXAS21002C_REG_CTRL3, 2, 2), + [F_FS_DOUBLE] = REG_FIELD(FXAS21002C_REG_CTRL3, 0, 0), +}; + static const int fxas21002c_odr_values[] = { 800, 400, 200, 100, 50, 25, 12, 12 }; From patchwork Fri Jul 17 16:55:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670725 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3D5C66C1 for ; Fri, 17 Jul 2020 16:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25181208DB for ; Fri, 17 Jul 2020 16:56:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OReukPQJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbgGQQ4W (ORCPT ); Fri, 17 Jul 2020 12:56:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727863AbgGQQ4V (ORCPT ); Fri, 17 Jul 2020 12:56:21 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 738CAC0619D5 for ; Fri, 17 Jul 2020 09:56:21 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id g75so15938794wme.5 for ; Fri, 17 Jul 2020 09:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GLQMRZhAcaiH98XmK2nRHQzjjK7ctPbh4JOJq8lN/Zg=; b=OReukPQJ3TIWhVLoquVjq+BeXvQT7cuSvvCcBFb0FD3W6ukPwpAZ3t+VKU2KQZDNJB uLfyuKrtlK2hf/RZvQ5c7JhBXi0h3LBcNPrdTaNSCZkHimnuOwlFsIT3mlpVFlTjtA87 LGIALjoVGtVa8I28KhjT+QpMYCyq/cjQHimfvPZ2gkcdCnVDw6I+/8aL7CU1xb+MmNCP BNCsb4Npwo3oQMvEUKza2FYOXeRL/MmcQNwHelQNf7luezRVKDgfbLJtjmQXtukgnet1 e2GKWxtR2vqawEYMOPl1xWO7n/UrcD9/dzfAKj8XSMioQbV9BRnBvA3cxsxOWW0gsbFx tamg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GLQMRZhAcaiH98XmK2nRHQzjjK7ctPbh4JOJq8lN/Zg=; b=uZaMnGeteU8MQRBx2u5VHICwTg7UZnO7T+VKQj3VlareKFW7lLVklypjYLsaRmxOAE CwhN0yGqHYqy/9iDZK0ucnOF5Uss2xgxVSz9Rod19BMgpd+cVbHC4izkV5/k+zIHmfGK Zr308xtmWoHPhx7Dzp530K2lHYA1F2DZyeARS0TDMo/dnDK4pclLvgLCXNg8iMrJRm/C Ispb8WoD2zsNEJrGdCkKzxJdDNcvgfOjGcYy82sncqNn2nw0ptnWmbDEt7NFDDpUL67y yB+6Pp6k/IYW6HN0yQDOeNE7ALttkbEVzDsh6DUUlpfd3Qjanfq6j1u+A/H7SyUYpTTe XcQQ== X-Gm-Message-State: AOAM530iOX4zPekU0aOoYoKMtcKg1kTVi52tfSjzYPdLf9iwHDpRZ1Yf 2gA4DE6MAJHY1YPg2/wvBwjxUg== X-Google-Smtp-Source: ABdhPJzKZPc/M/DK0dDuqHn74s8nL8cUXwq6RyA/6MudfzQXS/4hRjICV/HEuGEK7f9Kwc9NxblCwg== X-Received: by 2002:a1c:7413:: with SMTP id p19mr10064679wmc.60.1595004980122; Fri, 17 Jul 2020 09:56:20 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:19 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Lorenzo Bianconi , Denis Ciocca Subject: [PATCH 19/30] iio: imu: st_lsm6dsx: st_lsm6dsx: Reorder 'inline' declaration Date: Fri, 17 Jul 2020 17:55:27 +0100 Message-Id: <20200717165538.3275050-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:487:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:497:44: warning: ‘st_lsm6dsx_accel_ext_info’ defined but not used [-Wunused-const-variable=] Cc: Lorenzo Bianconi Cc: Denis Ciocca Signed-off-by: Lee Jones --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h index b56df409ed0fa..3e47a9287938b 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h @@ -484,7 +484,7 @@ st_lsm6dsx_write_locked(struct st_lsm6dsx_hw *hw, unsigned int addr, return err; } -static const inline struct iio_mount_matrix * +static inline const struct iio_mount_matrix * st_lsm6dsx_get_mount_matrix(const struct iio_dev *iio_dev, const struct iio_chan_spec *chan) { From patchwork Fri Jul 17 16:55:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670727 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 893D413B6 for ; Fri, 17 Jul 2020 16:56:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FEAE207DD for ; Fri, 17 Jul 2020 16:56:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gax7Woqu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbgGQQ4Y (ORCPT ); Fri, 17 Jul 2020 12:56:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgGQQ4W (ORCPT ); Fri, 17 Jul 2020 12:56:22 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52DE6C0619D3 for ; Fri, 17 Jul 2020 09:56:22 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f7so11908235wrw.1 for ; Fri, 17 Jul 2020 09:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rHQ/jO1LhjZqNtelCIEh1tkpMHr7F5JhR3YsKGdMJak=; b=gax7WoquXCNWbtQ32PKWdu+p6CINIYPJ64653qBVA7k6sICf8rlMQTpk2nd/sPyRKW LzPBfRVamHkdO/sf1vEGjrOjSxv++JfIprn9Igv21SDOyw2b73cXNm/p13aUAO4bPVeG WIT5jOcosEKJUAYL0iK5CZDiwYlIKtNdEhpYpzmJXMMaybPSuowQUpX1UDiOOU0fVhXZ T0L2WJ7tvFvMmBIaiRVmwnMn2Zq7b7PNO6Ho3bca5LjWdsG0ksj+Wal/Mcu7eJyB4RsF 6sPolkV1LjvVteKTcBo+aU3tvd18BW7yUcfWp8dJDRcQDrBMvIJnSS6v4mihpd5MjcZI cpHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rHQ/jO1LhjZqNtelCIEh1tkpMHr7F5JhR3YsKGdMJak=; b=FolUd6/ThsSM0kDi4j695meFt3qlAxBLpBkegRiVMHbYfuCl/KWE4+8PuskAe5ul33 cspyv2IBd529Jl8jGsfisuOgtEO6eZ8nbsO3vz7uxzV8u+xnZKMd5weQQVD6qgrMB5ML rsdPgTGEzcljpaOQWe7nTXqCw8rQ3xgQ87F10L280qCzLG/2UGf++5fcIstwHEnQxox3 eCAeJn5/VH/Rn9AiS9fVHM1kMk1o54LyapJ3u14lDpdy+fcwxrxMd6TXorVyAjs+0+y4 043mM0Fa5/Yrxc/aT7YSk5SqTDqf5njcpvSG6G6nwHAba0FXMkSMSVHy1tZHRZLhA1Po SooA== X-Gm-Message-State: AOAM531f5USKNxzxT57me5txUIfLLe59pzMW6cZJ+WqtMM19hvmZMy1X GU7U4mv5bQlGnYOyP6tQj6Bz2A== X-Google-Smtp-Source: ABdhPJwoHoY99/X6VnON+9Fq/TFQG3iB3igVuAL6ttNu5GBSpTuN7C9MiiUk2XrtnDU7l2HXLI8KqQ== X-Received: by 2002:adf:efca:: with SMTP id i10mr3678182wrp.278.1595004981099; Fri, 17 Jul 2020 09:56:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:20 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Liam Girdwood , Mark Brown , Rohit Sarkar Subject: [PATCH 20/30] iio: adc: max1363: Fix kerneldoc attribute formatting for 'lock' Date: Fri, 17 Jul 2020 17:55:28 +0100 Message-Id: <20200717165538.3275050-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Kerneldoc expects attributes/parameters to be in '@*.: ' format. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/max1363.c:190: warning: Function parameter or member 'lock' not described in 'max1363_state' Cc: Liam Girdwood Cc: Mark Brown Cc: Rohit Sarkar Signed-off-by: Lee Jones --- drivers/iio/adc/max1363.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c index 9d92017c79b2d..0fe348a47fe01 100644 --- a/drivers/iio/adc/max1363.c +++ b/drivers/iio/adc/max1363.c @@ -150,7 +150,7 @@ struct max1363_chip_info { * @current_mode: the scan mode of this chip * @requestedmask: a valid requested set of channels * @reg: supply regulator - * @lock lock to ensure state is consistent + * @lock: lock to ensure state is consistent * @monitor_on: whether monitor mode is enabled * @monitor_speed: parameter corresponding to device monitor speed setting * @mask_high: bitmask for enabled high thresholds From patchwork Fri Jul 17 16:55:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670747 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 35CAB14E3 for ; Fri, 17 Jul 2020 16:57:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F81D2074B for ; Fri, 17 Jul 2020 16:57:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rmUQhPd0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727916AbgGQQ4Z (ORCPT ); Fri, 17 Jul 2020 12:56:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727888AbgGQQ4X (ORCPT ); Fri, 17 Jul 2020 12:56:23 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ED7DC0619D4 for ; Fri, 17 Jul 2020 09:56:23 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id o11so11887790wrv.9 for ; Fri, 17 Jul 2020 09:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3yCjZzdqVBjfabIra8KmWX21RZUH0S4lOrIP/Y6t4jI=; b=rmUQhPd0dNStDC+2Z/NUOcKEElQLXqhPkITlP2X7v1qD5nVOC1XVqDMgcIkmF9jena NiddjeEjlHYmNjv3YAI+tgN1axWWTlnmwk7XEJvJA4yUHBqWjPob7ivHsrjynV/o7h89 t7b0uBQ9Tp7B7XRVWinbi5yWBFhvI5fNmVzh5Ecm1N9PYZYltSHjRBoW0ptN8G0IuWlt R/wWGxwJnEzGy7H7bMCFgP3Q5WLgVKqC1NAd7nlw9co70FapzFoWhU4bThNXIzNJ7/oN N42VGywbYYbw1uUlT67iWdwO13+R4covjdL190KEWPvaGGVFamNHMDzELRa9vMKAmxWU mqSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3yCjZzdqVBjfabIra8KmWX21RZUH0S4lOrIP/Y6t4jI=; b=Icos8xmvFXEdJpmigdMzeIzirIGVhvw2YhaAl3GgpgAvm1hxM1B/DQ0XKfW5yC6rdZ McgCuSVnxMVY/4wmIZ1sHIb2Jo6ZWeTTWufA1rdLBytYg2iFUbtuJvePYsRPsirh+RcS 3ack9761FBTZVxFvZQVkg7rscpuKYOrqtn6F/4PUmZNUO0k6s7MauTa7wP7w0Y0tBKH4 i6CKdGxgaU5122mZ5OvTElNLCimWmWLkgdn2c2oXD+wd+KTL2K8aTmu0e9PUNm8IqSwd Zlp5F/NBrHezjWzB/i1LzIpA/svSmzO8PvKh4/783N7w6aCZJsJdyQbWD6Zsi52lwZLv VPxA== X-Gm-Message-State: AOAM533nsYZzhdJnE7u6HV80mqrmGEfg49xEl80I/TztlMi8LxzxDaGU XrnreBrPYsjK64RM8+ks+2jrVQ== X-Google-Smtp-Source: ABdhPJws+AORrTjb6PwxGFZBmbZXNWopNyC6Ln4tgH2AO7EQW5uDtQ4Lj/rjWAAuzac+5ArTk0DDcw== X-Received: by 2002:a5d:4c91:: with SMTP id z17mr10935922wrs.267.1595004982145; Fri, 17 Jul 2020 09:56:22 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:21 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Jacopo Mondi , Geert Uytterhoeven Subject: [PATCH 21/30] iio: adc: max9611: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 17 Jul 2020 17:55:29 +0100 Message-Id: <20200717165538.3275050-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org No attempt has been made to document any of the demoted structs here. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/max9611.c:117: warning: cannot understand function prototype: 'const unsigned int max9611_mux_conf[][2] = ' drivers/iio/adc/max9611.c:145: warning: cannot understand function prototype: 'const unsigned int max9611_gain_conf[][2] = ' Cc: Jacopo Mondi Cc: Geert Uytterhoeven Signed-off-by: Lee Jones --- drivers/iio/adc/max9611.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c index 04d5ff7d2c8ec..3a361299a70f4 100644 --- a/drivers/iio/adc/max9611.c +++ b/drivers/iio/adc/max9611.c @@ -110,7 +110,7 @@ enum max9611_conf_ids { CONF_TEMP, }; -/** +/* * max9611_mux_conf - associate ADC mux configuration with register address * where data shall be read from */ @@ -133,7 +133,7 @@ enum max9611_csa_gain_params { CSA_GAIN_OFFS_RAW, }; -/** +/* * max9611_csa_gain_conf - associate gain multiplier with LSB and * offset values. * From patchwork Fri Jul 17 16:55:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670749 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4223D6C1 for ; Fri, 17 Jul 2020 16:57:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BB312074B for ; Fri, 17 Jul 2020 16:57:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZcVlGaOL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728112AbgGQQ5I (ORCPT ); Fri, 17 Jul 2020 12:57:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727915AbgGQQ4Y (ORCPT ); Fri, 17 Jul 2020 12:56:24 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 687D5C0619D3 for ; Fri, 17 Jul 2020 09:56:24 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o2so18258009wmh.2 for ; Fri, 17 Jul 2020 09:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=31Tvqv5NM4OFlqEMdtTKPK1d2uzVylaWVS7jDebvxGA=; b=ZcVlGaOL/eDTv4lz5JNlb4hvtqD+61w7PMNxH3NBGKRHyPqzJ4uTAIwYuWJ3ev4dFT 5ehYJVF7nzM9II9CEoOhTa5w10VsHMdfcTywQSHOaEckBYNSBkF+sGd21ZfrWfQIlEBL qgQPBZ0oVg2jhGx6D3/GJrJ7VfP/4KBF/PtN6vkRzd4z/rXUzkcOw01OfBXm95uVCErX lKoBUJ2uPi9lXqc/vfY3vePmqyzN6UUSmJO6WeZa9wZw1PmU+UxCbVUiYkom0kazHefl ngHnsxDuAtEVfKz7u+Q4npgGQh/o4Y/5k2CT7Ca7cmyxxW5Z1s1cBljlyLx11/+NZJdw cQGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=31Tvqv5NM4OFlqEMdtTKPK1d2uzVylaWVS7jDebvxGA=; b=JIT/jtvyPA4mqueboONVLYNgft7hOjPzy7CKxLrqSrKwVdEaZTFb87qr7CdcJHdU13 UqYRRqXZ+2XLEGUXJh0F4Fpb057QCaLe+TDBYtnG67bxQOhza1qciKTjbtZNLZDOo8rz qvs6YPKavYV4yGQEXhuA7bWsdBXRkjOY2jjYinNoCqzwkAFgBxQn3lbBTRlsdzksKnu+ fb87AGtNQxj4vvSMmQsoZI6jJCRbaEg/QBIpXh4Zvap/YTrm2FIr0nbzIRECQnoY37Ui qMCGom8rm7pQDEm8brbZRQmr0JuWein8TX+vLZTcWCWWPbeZr9z6gSO+b2WPAkCG6qEr UcvA== X-Gm-Message-State: AOAM532HP9C/8X3LVCvHUqinL7KqoFyiWzPPJDy+L/lKlwIlHreko82i wLRvFs2q6aC61DfdtUx0GKchJg== X-Google-Smtp-Source: ABdhPJznCryOGiaapGhkR1ssu1klQe40/wpuzaMcITlbW08G7kOfQATkKGR7vsCaF9kKxBdVSbniuQ== X-Received: by 2002:a7b:c8c8:: with SMTP id f8mr10596923wml.142.1595004983177; Fri, 17 Jul 2020 09:56:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:22 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Oskar Andero , Bendorff Jensen , Soren Andersen Subject: [PATCH 22/30] iio: adc: mcp320x: Change ordering of compiler attribute macro Date: Fri, 17 Jul 2020 17:55:30 +0100 Message-Id: <20200717165538.3275050-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Kerneldoc gets confused if the variable does not follow th type/attribute definitions. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/mcp320x.c:96: warning: Function parameter or member '____cacheline_aligned' not described in 'mcp320x' Cc: Oskar Andero Cc: Bendorff Jensen Cc: Soren Andersen Signed-off-by: Lee Jones --- drivers/iio/adc/mcp320x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c index 2c0eb5de110ca..191a8f644ffe7 100644 --- a/drivers/iio/adc/mcp320x.c +++ b/drivers/iio/adc/mcp320x.c @@ -91,7 +91,7 @@ struct mcp320x { struct mutex lock; const struct mcp320x_chip_info *chip_info; - u8 tx_buf ____cacheline_aligned; + u8 ____cacheline_aligned tx_buf; u8 rx_buf[4]; }; From patchwork Fri Jul 17 16:55:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670745 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A2A426C1 for ; Fri, 17 Jul 2020 16:57:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AF9D2074B for ; Fri, 17 Jul 2020 16:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JoPHqajg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727940AbgGQQ5G (ORCPT ); Fri, 17 Jul 2020 12:57:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727924AbgGQQ4Z (ORCPT ); Fri, 17 Jul 2020 12:56:25 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 703E1C0619D3 for ; Fri, 17 Jul 2020 09:56:25 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j4so11853852wrp.10 for ; Fri, 17 Jul 2020 09:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VxERIJkNFUQ5ozpJhehQBvzBnN2ugWiIznLPwHBPnFk=; b=JoPHqajgOW42YICPAe8k9IXDr8Oq0uyPpS778IQ3CfxvDtIbl5D8zR0Df+QDdALhPU por7Z1VCalQYriqoUWjMGqkkEBx9qImCE5FFvIaMi8hJpomwggTqQgOJ19UYPdPO8rBY I5PSktHvzMysiadqwkX2LWNDAzwUcNS7uAwz2NvAxFZ/Iy+S1Ud5WLrixqzfdLf/pbGg yxYjRYaAjHvYP+zH3MJwVQX8O0kle7SSULEcwJKMfkMqnqKsaCZyjvK/G3JNJRGNdFjx zJ/JJ2pXTBy6xWQXBvuRm3uIllaX05mGTqtnfXfw3uviQ82rG8NtpnmP3o0TmmXYzwHb XSQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VxERIJkNFUQ5ozpJhehQBvzBnN2ugWiIznLPwHBPnFk=; b=om7DND5RO7eKz7QcskOdaXwouPjLIE3AIGAf87Rcddg0iCgnr7pIjwMTBRP5ynJIaM KrkgdwZAjR2QdpLl2mB4zFQdTRvyKVzMJlAHN98V25Paa0ielWeqn+IDEB9FA7PVgjoj owc60GwUXRbAe9TMcvUx0Y6IVWXrPmbJIZcWUUAlY7jA9CRB1YpRT2XYyxHlsMXTkiv5 gF8RkOBUnE61nLp5ccqD4zoBKVS3+3Qf7fjpyFZXFCHRQGpBY+/LEekgiWsSYD2mEhBM 7Wie5kIbasPKUb9ZmY5sr2g2zJtVJwgqH2FANnBZrpzMRH0Hx9TwDU/HaMV8M/4THaUi 3RJA== X-Gm-Message-State: AOAM531yNF75K65joeUcKvUfVShuxK0II/gsplaMc8R+wMn3Cf+feAr9 /3otff4zRJjnX3aAt8A8ihVXcg== X-Google-Smtp-Source: ABdhPJyoyi3KXxofIeitDa3r5dXgzfyGk9VTWMvKp/iCGqvFymG0cwak1NwrvETpg7f4cCGxPyMThw== X-Received: by 2002:adf:dfd1:: with SMTP id q17mr10668408wrn.94.1595004984144; Fri, 17 Jul 2020 09:56:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:23 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Pradeep Goudagunta Subject: [PATCH 23/30] iio: adc: palmas_gpadc: Demote non-conforming kerneldoc header Date: Fri, 17 Jul 2020 17:55:31 +0100 Message-Id: <20200717165538.3275050-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Very few of the struct attributes have been documented here. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'dev' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'palmas' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'irq' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'irq_auto_0' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'irq_auto_1' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'adc_info' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'conv_completion' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup1_data' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup2_data' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup1_enable' not described in 'palmas_gpadc' drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup2_enable' not described in 'palmas_gpadc' Cc: Pradeep Goudagunta Signed-off-by: Lee Jones --- drivers/iio/adc/palmas_gpadc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c index 46e595eb889fa..81b0a76a767e8 100644 --- a/drivers/iio/adc/palmas_gpadc.c +++ b/drivers/iio/adc/palmas_gpadc.c @@ -76,7 +76,7 @@ static struct palmas_gpadc_info palmas_gpadc_info[] = { PALMAS_ADC_INFO(IN15, 0, 0, 0, 0, INVALID, INVALID, true), }; -/** +/* * struct palmas_gpadc - the palmas_gpadc structure * @ch0_current: channel 0 current source setting * 0: 0 uA @@ -94,7 +94,6 @@ static struct palmas_gpadc_info palmas_gpadc_info[] = { * This is the palmas_gpadc structure to store run-time information * and pointers for this driver instance. */ - struct palmas_gpadc { struct device *dev; struct palmas *palmas; From patchwork Fri Jul 17 16:55:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670739 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3EC036C1 for ; Fri, 17 Jul 2020 16:57:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25F432074B for ; Fri, 17 Jul 2020 16:57:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nmzt8PjW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727946AbgGQQ42 (ORCPT ); Fri, 17 Jul 2020 12:56:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727935AbgGQQ40 (ORCPT ); Fri, 17 Jul 2020 12:56:26 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79108C0619D3 for ; Fri, 17 Jul 2020 09:56:26 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l2so18247898wmf.0 for ; Fri, 17 Jul 2020 09:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hi8qOFeRWHwGMDY6+jyfXlM1WO1ALepxa0e5DvrODkg=; b=nmzt8PjWuuA+nerSb1mT8vWtyIVb8t6x0n1ZjmUMFFq5nUEXV/oEb1bfhDKmv7k0gk dtQ1sP5wZzl/3gBZtwoaFXnsSqL5WgnKFggNptn+AV63jQsWjtQsjjXKmjofXcKnyBeK +xYZY5QnWpRDeoxkEJ0MMoq9xiPv+IeWZyiFTBI7SbJsWGxadSH9GsLR67Xm+oKbIeX0 nuo5jzYM6uzv7wSQh4Rt5ZujXneQexwZNsSvFxFcChybReyai11tjhaMjA7Y3vfXHdnh B/JcJMpxxDj7ysxOz8ds+DYZBb/Db+Xp5fLrbSvEzRCE4IMRR84Zs0V7JjFubZ8mxKJR C5fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hi8qOFeRWHwGMDY6+jyfXlM1WO1ALepxa0e5DvrODkg=; b=i0ectxRGvch2VDpNfNLhubFOeEh336WVLrsIfpngEDDbdoivvdKtiYOHt31tP4E6wl 09lraA7pjbqHvzPQp9qy59tsD7RhyVvfoSO1LffzVhe790M9YO8xxaRMucZJcKyNVx4r /o5cKQVQAbELFWfFWXD6voL5x6iWsr9lDdplCcs+AYZmO+RMl2x7AECcPGv2J9DGLODB WtQa52qrFFYLen+/MQTfjduZuOuanSb9vntbhLdTvveaa6c249wAsIFgLHkaEIXmk06s xiSUjgIfL4tJfGtZ1o0l1Zh37dOEj+z4RsEJi/OGWGyszb86ACLLgI9x5jzcUpJRu61T T5Tg== X-Gm-Message-State: AOAM530eNM6Jng2SpkbZqGVavss4uwNIFdM1oy6SpBqJ8nCmVzgxwemy V8+9UUuO9pbVXUlAsv18sLtoog== X-Google-Smtp-Source: ABdhPJzfenz4Z0x8Hd0PIQJbMUlVocb/ARj5dXJtbJSeh57vwPJPM27nkqMYuDx53bhXG4kR8UKxXQ== X-Received: by 2002:a1c:e90d:: with SMTP id q13mr10497071wmc.187.1595004985201; Fri, 17 Jul 2020 09:56:25 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:24 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Jean-Baptiste Maneyrol Subject: [PATCH 24/30] iio: imu: inv_mpu6050: inv_mpu_core: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 17 Jul 2020 17:55:32 +0100 Message-Id: <20200717165538.3275050-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:444: warning: Function parameter or member 'st' not described in 'inv_mpu6050_set_lpf_regs' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:444: warning: Function parameter or member 'val' not described in 'inv_mpu6050_set_lpf_regs' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:480: warning: Function parameter or member 'indio_dev' not described in 'inv_mpu6050_init_config' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:862: warning: Function parameter or member 'st' not described in 'inv_mpu6050_set_lpf' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:862: warning: Function parameter or member 'rate' not described in 'inv_mpu6050_set_lpf' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'dev' not described in 'inv_mpu6050_fifo_rate_store' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'attr' not described in 'inv_mpu6050_fifo_rate_store' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'buf' not described in 'inv_mpu6050_fifo_rate_store' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'count' not described in 'inv_mpu6050_fifo_rate_store' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'dev' not described in 'inv_fifo_rate_show' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'attr' not described in 'inv_fifo_rate_show' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'buf' not described in 'inv_fifo_rate_show' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'dev' not described in 'inv_attr_show' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'attr' not described in 'inv_attr_show' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'buf' not described in 'inv_attr_show' drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:1282: warning: Function parameter or member 'st' not described in 'inv_check_and_setup_chip' Cc: Jean-Baptiste Maneyrol Signed-off-by: Lee Jones --- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c index 4d604fe842e5d..f6b2b2e8f1010 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -433,7 +433,7 @@ static int inv_mpu6050_set_gyro_fsr(struct inv_mpu6050_state *st, return regmap_write(st->map, st->reg->gyro_config, data); } -/** +/* * inv_mpu6050_set_lpf_regs() - set low pass filter registers, chip dependent * * MPU60xx/MPU9150 use only 1 register for accelerometer + gyroscope @@ -467,7 +467,7 @@ static int inv_mpu6050_set_lpf_regs(struct inv_mpu6050_state *st, return regmap_write(st->map, st->reg->accel_lpf, val); } -/** +/* * inv_mpu6050_init_config() - Initialize hardware, disable FIFO. * * Initial configuration: @@ -847,7 +847,7 @@ static int inv_mpu6050_write_raw(struct iio_dev *indio_dev, return result; } -/** +/* * inv_mpu6050_set_lpf() - set low pass filer based on fifo rate. * * Based on the Nyquist principle, the bandwidth of the low @@ -884,7 +884,7 @@ static int inv_mpu6050_set_lpf(struct inv_mpu6050_state *st, int rate) return 0; } -/** +/* * inv_mpu6050_fifo_rate_store() - Set fifo rate. */ static ssize_t @@ -945,7 +945,7 @@ inv_mpu6050_fifo_rate_store(struct device *dev, struct device_attribute *attr, return count; } -/** +/* * inv_fifo_rate_show() - Get the current sampling rate. */ static ssize_t @@ -962,7 +962,7 @@ inv_fifo_rate_show(struct device *dev, struct device_attribute *attr, return scnprintf(buf, PAGE_SIZE, "%u\n", fifo_rate); } -/** +/* * inv_attr_show() - calling this function will show current * parameters. * @@ -1275,7 +1275,7 @@ static const struct iio_info mpu_info = { .debugfs_reg_access = &inv_mpu6050_reg_access, }; -/** +/* * inv_check_and_setup_chip() - check and setup chip. */ static int inv_check_and_setup_chip(struct inv_mpu6050_state *st) From patchwork Fri Jul 17 16:55:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670743 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E47CD13B6 for ; Fri, 17 Jul 2020 16:57:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC06120737 for ; Fri, 17 Jul 2020 16:57:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gXP1A1aP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727953AbgGQQ5C (ORCPT ); Fri, 17 Jul 2020 12:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727942AbgGQQ41 (ORCPT ); Fri, 17 Jul 2020 12:56:27 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 501E8C0619D4 for ; Fri, 17 Jul 2020 09:56:27 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id a6so11907019wrm.4 for ; Fri, 17 Jul 2020 09:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IXd86YlqxBtW7UZeHgyTcDp4G0PhvbjWGBrB0jc0maI=; b=gXP1A1aPqfzAOvdHNbPtLs+jIhv54GQIbTAccgxgr1wt1kn9EpupuLOyas02qh3Fc4 aAXKauKVOUBG3l+VRgo/RdfDeZ1G42tkVR3s4aIDxL5dUHdbg/5/xQN5dZahRXDmPmkt xLwL3x7xHoSEQo3Jxl84dEa2RWgcLgAZxPwEl2aOD7W00BdoLQ+h1AAIEcGGPCS2LYR0 y0igGQBBnKCGKDevvhCzrkAAkKfKwxwsWq6rybKHU6asMYRQPgysnadd/5iHvMcqn9dJ KIAQPpOk464Eu5Jl1xNAEjwKkq9Q/MpFYoWxHU25xXjFhMdHwjM8IDe51XIF8biw6Cde c7+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IXd86YlqxBtW7UZeHgyTcDp4G0PhvbjWGBrB0jc0maI=; b=FGZF8uihOqcvgaS9B1Wv/AML+Yv2X0z9fMusYkV6IKPVZJ8kH8j+huJqAPWJ3fUQgH J3OtL1/isAIUPoSgD7QsTs4rD7Kd+uLKrvdtUbcPR+D5IrMyPSgkQdhjy68Zj9jer+hS Xqly7MI6LXyIiDxXnqu6FHy4PQhnaQyHql02h1wfbYZUZvD7jdwEQbHE3d36e5JlQXhC mjKv51VDb2xufbFkRWSQh98OpA3u9UM0CC/4zMP30IAkGeopA+vN8uIEaYCBB50Rtx7L UVOYBXdk6epuQPZn9joui8XC+5ZHiTy42TodpqT8rc+zXpY/CRtABQkLvmGbTq5iSaoU dzbw== X-Gm-Message-State: AOAM533XTG9e1bDZJhGLEOZ7/DugpbU+efVEmj/ENd7GzY62F1LANtBz Ma9Noy56p1Ih3uN7B257GNyQbg== X-Google-Smtp-Source: ABdhPJxhKbEduZnoaaEhkBeqsaOavVhq+n3Sa8BgaDFiVmZt2/qoLy17eSHZ1GVMU3+BfR0KoDuf9w== X-Received: by 2002:a5d:630c:: with SMTP id i12mr12304154wru.158.1595004986049; Fri, 17 Jul 2020 09:56:26 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:25 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Jean-Baptiste Maneyrol Subject: [PATCH 25/30] iio: imu: inv_mpu6050: inv_mpu_ring: Demote seemingly unintentional kerneldoc header Date: Fri, 17 Jul 2020 17:55:33 +0100 Message-Id: <20200717165538.3275050-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This is the only use of kerneldoc in the source file and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c:118: warning: Function parameter or member 'irq' not described in 'inv_mpu6050_read_fifo' drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c:118: warning: Function parameter or member 'p' not described in 'inv_mpu6050_read_fifo' Cc: Jean-Baptiste Maneyrol Signed-off-by: Lee Jones --- drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c index 9511e4715e2c1..b533fa2dad0ab 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c @@ -111,7 +111,7 @@ static int inv_reset_fifo(struct iio_dev *indio_dev) return result; } -/** +/* * inv_mpu6050_read_fifo() - Transfer data from hardware FIFO to KFIFO. */ irqreturn_t inv_mpu6050_read_fifo(int irq, void *p) From patchwork Fri Jul 17 16:55:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670741 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9C8EA14E3 for ; Fri, 17 Jul 2020 16:57:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 824952076D for ; Fri, 17 Jul 2020 16:57:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DTRhBaRQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728100AbgGQQ5B (ORCPT ); Fri, 17 Jul 2020 12:57:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727953AbgGQQ42 (ORCPT ); Fri, 17 Jul 2020 12:56:28 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F65FC0619D5 for ; Fri, 17 Jul 2020 09:56:28 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id l2so18248016wmf.0 for ; Fri, 17 Jul 2020 09:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TkOYSGltdOXnfd+0tERuVE54MScMlmkqbTAm2yNvNuQ=; b=DTRhBaRQRjcS7sPkr9Rcnr/ZtOhPRL+7IF+l/wRBS2gE9kpSsDvBNkY1IN5u5fqxqB o5GtUs99QqTzB+GPfDYrOO/z73yzT80INXtnSU7PmyKIFScL028ddBUUfEcTsKIho0tB d9ZDQnCAz0Y79xLwcfKFME9mVwP+k3/Jpvt3I5obTkR0VZJWPtkreuwFZWKrig3QYEof cYw432EsBY3NSGuvktvzvG1iM4ODBUnX667Lwi5H/+NtBEON8qqnvJEqV1b4l6eOz/4D kcid0oyZblGB0+CHV+G8Tjwau5JZO1Iaz7fA2wYm00DWcdxEzJt5TXiHOMpFAokVG397 tHvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TkOYSGltdOXnfd+0tERuVE54MScMlmkqbTAm2yNvNuQ=; b=S99DleQnpJzI9leqGakIQoPTVZWsYaYvG95uxDz+BlUbdUipy/3c8MgU/OFmGIqFDI x78ZTUlYDJRadX6+afBDlovDu+n6Uc9gAkZghjF1DKcrTQ0EPs0i0MTUd5HeBwjRAlLj JbntzCi1vsGhtJffDQMpC8UHG3KVB99BECaYaVs3+nas3vhFqnS5JuD7cTyqOOboc6t4 qRpwGu4N8LTrtllfxQbQScwYnQLcndnotmRU5u+Wmc+Wl9jFci/m4ozgHHdREQxCoK8K OoPbG8pl4/P6IJO8lXJh8AY10RGuGfKS8Uy96M2mgRKACqfScvP0PR6SfN/y3fQg/kve K0jA== X-Gm-Message-State: AOAM533+zMt8nWBloVWAHJeYPcaVlt7S6NOaDLxIVVMN154Pqjfef4n1 OZtqjzckU/Iyy3LIirHITBbKRQ== X-Google-Smtp-Source: ABdhPJxDjfQUnVh6/KkbozE7NYDq+1TjlinAums8GsbsNOoTvRInXHpBx5zHQFNjp3F29RMu3UBUOw== X-Received: by 2002:a1c:2602:: with SMTP id m2mr10750323wmm.50.1595004987141; Fri, 17 Jul 2020 09:56:27 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:26 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Andy Gross , Bjorn Andersson , Linus Walleij , linux-arm-msm@vger.kernel.org Subject: [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description Date: Fri, 17 Jul 2020 17:55:34 +0100 Message-Id: <20200717165538.3275050-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Kerneldoc is only suitable for documenting functions and struct/enums. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL' description in 'PM8XXX_CHANNEL_INTERNAL' drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_125V' description in 'PM8XXX_CHANNEL_INTERNAL' drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL_2' description in 'PM8XXX_CHANNEL_INTERNAL' drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_MUXOFF' description in 'PM8XXX_CHANNEL_INTERNAL' drivers/iio/adc/qcom-pm8xxx-xoadc.c:412: warning: Function parameter or member 'variant' not described in 'pm8xxx_xoadc' Cc: Andy Gross Cc: Bjorn Andersson Cc: Linus Walleij Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson --- drivers/iio/adc/qcom-pm8xxx-xoadc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c index c599ffa45a04c..cd5fa30e77df4 100644 --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c @@ -120,7 +120,7 @@ #define ADC_ARB_USRP_DATA0 0x19D #define ADC_ARB_USRP_DATA1 0x19C -/** +/* * Physical channels which MUST exist on all PM variants in order to provide * proper reference points for calibration. * @@ -388,6 +388,7 @@ struct pm8xxx_chan_info { * struct pm8xxx_xoadc - state container for the XOADC * @dev: pointer to device * @map: regmap to access registers + * @variant: XOADC variant characteristics * @vref: reference voltage regulator * characteristics of the channels, and sensible default settings * @nchans: number of channels, configured by the device tree From patchwork Fri Jul 17 16:55:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670737 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BD3C613B6 for ; Fri, 17 Jul 2020 16:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A57E72076D for ; Fri, 17 Jul 2020 16:57:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XYmAwbic" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728091AbgGQQ45 (ORCPT ); Fri, 17 Jul 2020 12:56:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727969AbgGQQ43 (ORCPT ); Fri, 17 Jul 2020 12:56:29 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75652C0619D3 for ; Fri, 17 Jul 2020 09:56:29 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id j18so15954134wmi.3 for ; Fri, 17 Jul 2020 09:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HA5KB0sL+kEMYPMfqRb/LMvZqE0HiKOu7GwHruCFgr8=; b=XYmAwbiceHH7jCfIcdW9ZdUBAKaLcD2MIwfgwFhIF7hoj781v/vZfidaXkIS3u7G/z LGK74R9BA+p931oPHmCKsFSQT/9Le7zJsVIhecUcsFC3tF3GBhERnuo7AyNPoGTshMuN DvxMvtHNy064UBqjC3eGlTL7HyKl7Bw6EZ+dnsddW0ngKs3QrZWGWFx/x4LmYlmcHggg 6p9spcXFsX+7E4AKzyakXst+lzt/e0Bk8hH9Tocpwujhjs5dc7pXZEDF6LosYeMn2sMP uBmlAekKAF1qAeKtkvXIml7kAyT6CmKgxkCpTSF4/rqD+df0W9nWcoP+ROzG25xOlX39 M6Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HA5KB0sL+kEMYPMfqRb/LMvZqE0HiKOu7GwHruCFgr8=; b=lfcawG9XdTs4udfcT/MC3J2XI5v1ghTeVbDhxb4vBXhxoWNxaF9z63+TrNESc00APl a1sVldJk+e+5URw9LCzPxYnDPV+wnYbvyxmnGQvUncZypNss0vgE0kwAPftHhzNIasiW 5we7/35vcK6ozZrnFtVOUyKiGCQszfFh14A29b6KcTgtBRRGh2FJi8xcYW41xWN2q/Y3 hU4mhqdvhd7J7UDZd0YUer4wOMELq3r7zqTpnD7ywog7efXQNtHJstuH8VoNX6qt2VQv FkXsUpdEXNYOo2B2IkPcMWdZZ9WZDnPGtyRjOGFtGTTceWVPXqJhcDqgJ+h8Uu81hObG fdGQ== X-Gm-Message-State: AOAM530gyWvOSKs3EUnOTGxJbg7J9nAEJI9oYJoR5SGa9HpnfZ3pe/Ev N5+09R62pTceUEMzatFYWgVsWQ== X-Google-Smtp-Source: ABdhPJwk96D/etDyzrzif8dB+/0xJfCPzpvzLJ6j9vx1QxRMZQs/rb8F3g2zzaRoqCFrli23m0pveg== X-Received: by 2002:a1c:4b09:: with SMTP id y9mr10556037wma.46.1595004988192; Fri, 17 Jul 2020 09:56:28 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:27 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Linus Walleij , Samu Onkalo Subject: [PATCH 27/30] iio: magnetometer: ak8974: Add description for ak8974's 'scan' attribute Date: Fri, 17 Jul 2020 17:55:35 +0100 Message-Id: <20200717165538.3275050-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/iio/magnetometer/ak8974.c:200: warning: Function parameter or member 'scan' not described in 'ak8974' Cc: Linus Walleij Cc: Samu Onkalo Signed-off-by: Lee Jones --- drivers/iio/magnetometer/ak8974.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c index 91c39352fba26..4d6d8b699f037 100644 --- a/drivers/iio/magnetometer/ak8974.c +++ b/drivers/iio/magnetometer/ak8974.c @@ -180,6 +180,7 @@ * @drdy_irq: uses the DRDY IRQ line * @drdy_complete: completion for DRDY * @drdy_active_low: the DRDY IRQ is active low + * @scan: timestamps */ struct ak8974 { struct i2c_client *i2c; From patchwork Fri Jul 17 16:55:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670733 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6532A6C1 for ; Fri, 17 Jul 2020 16:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E25D2076D for ; Fri, 17 Jul 2020 16:56:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wQ7Ugx06" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbgGQQ4c (ORCPT ); Fri, 17 Jul 2020 12:56:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727983AbgGQQ4b (ORCPT ); Fri, 17 Jul 2020 12:56:31 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99FBAC0619D3 for ; Fri, 17 Jul 2020 09:56:30 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f7so11908660wrw.1 for ; Fri, 17 Jul 2020 09:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tTJcvgjzl2WbUv1DoWCwg8M9V9xkPx+Mjqd/3WwERQw=; b=wQ7Ugx06tN6cTgqiNlaXBffnekPJRqU00QjgzCQhxWIuL8gije7a+9CvJopiZdwZ42 xmMMHVYjRR60uIgrUXKgsDqI1foEG7CnSP7PS9zLvjjojE/rjZOpW8zzjbcaij+tlV8x T0+OM7uBOO5sfstYeewTYjBpnRLiovsAJX2rfupkih7IJ3CQ2attrMSvO36KpUBPS/6T BieP8fbRrmubmFrQ8inIjB8jD3eMRxeCinYdPucssXC+TdUu7xCR6ZHXdWir6gZ6hgvG MQOacYTHPIh60MZnd0vTVCNrG22ZZvv7f9EdTv4NCCJ/VRlqPjNZPWqESJbKG5FVFZc7 0tGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tTJcvgjzl2WbUv1DoWCwg8M9V9xkPx+Mjqd/3WwERQw=; b=q68zNc0h5cPkKmSyI20VbIu5auRks/73LE+rEtTsurqSIus1Z1zTEBRPNV8w7q3wF9 whY4Dee13/5zVEkDdMlqsznEDIjfkx3+P1ONTqvc+iBtGIga28/EoJuBsuasIlcWi/jC otuTxgguVCxIo+a+dpNDhPcQsYfVR10VQ3FsxaL84oksdjJmp0TXuRC97t5+7AZfn3dJ 26ChLr4/bXmkPegAhndaGMjUGTNO7NsTsIuO7jhOxQhnSMY97bmWUWKK3qcNz8L4j19P vqD9OMjiQoP3YIlOqQQW37WVTXWInWzg2FsfcIENevQGrCZri4Fw11Zst8AAOYdJ5Npl k4oA== X-Gm-Message-State: AOAM533ogD/blw0WzievQQZ203aQ4Xlaop6t5FuPWeqNU0LPn7lFrpHH yFffY48UKMYTB+fI55mHgHzIvKH+eKENNQ== X-Google-Smtp-Source: ABdhPJynhOgEH/VlqaCMSOVSk5ppB3HKEr8nqE5CqXXyCcH8EMQR2+Bp2CW+mJfmtbUrFUJezl8plA== X-Received: by 2002:adf:e50a:: with SMTP id j10mr12019425wrm.71.1595004989278; Fri, 17 Jul 2020 09:56:29 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:28 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Lorenzo Bianconi Subject: [PATCH 28/30] iio: imu: st_lsm6dsx: st_lsm6dsx_shub: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 17 Jul 2020 17:55:36 +0100 Message-Id: <20200717165538.3275050-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:174: warning: Function parameter or member 'hw' not described in 'st_lsm6dsx_shub_read_output' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:174: warning: Function parameter or member 'data' not described in 'st_lsm6dsx_shub_read_output' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:174: warning: Function parameter or member 'len' not described in 'st_lsm6dsx_shub_read_output' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:205: warning: Function parameter or member 'hw' not described in 'st_lsm6dsx_shub_write_reg' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:205: warning: Function parameter or member 'addr' not described in 'st_lsm6dsx_shub_write_reg' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:205: warning: Function parameter or member 'data' not described in 'st_lsm6dsx_shub_write_reg' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:205: warning: Function parameter or member 'len' not described in 'st_lsm6dsx_shub_write_reg' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:285: warning: Function parameter or member 'sensor' not described in 'st_lsm6dsx_shub_read' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:285: warning: Function parameter or member 'addr' not described in 'st_lsm6dsx_shub_read' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:285: warning: Function parameter or member 'data' not described in 'st_lsm6dsx_shub_read' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:285: warning: Function parameter or member 'len' not described in 'st_lsm6dsx_shub_read' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:335: warning: Function parameter or member 'sensor' not described in 'st_lsm6dsx_shub_write' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:335: warning: Function parameter or member 'addr' not described in 'st_lsm6dsx_shub_write' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:335: warning: Function parameter or member 'data' not described in 'st_lsm6dsx_shub_write' drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:335: warning: Function parameter or member 'len' not described in 'st_lsm6dsx_shub_write' Cc: Lorenzo Bianconi Signed-off-by: Lee Jones --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c index c1f83fe0d8dad..9a14dde4795da 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c @@ -163,7 +163,7 @@ static void st_lsm6dsx_shub_wait_complete(struct st_lsm6dsx_hw *hw) msleep((2000000U / odr) + 1); } -/** +/* * st_lsm6dsx_shub_read_output - read i2c controller register * * Read st_lsm6dsx i2c controller register @@ -195,7 +195,7 @@ st_lsm6dsx_shub_read_output(struct st_lsm6dsx_hw *hw, u8 *data, return err; } -/** +/* * st_lsm6dsx_shub_write_reg - write i2c controller register * * Write st_lsm6dsx i2c controller register @@ -273,7 +273,7 @@ static int st_lsm6dsx_shub_master_enable(struct st_lsm6dsx_sensor *sensor, return err; } -/** +/* * st_lsm6dsx_shub_read - read data from slave device register * * Read data from slave device register. SLV0 is used for @@ -323,7 +323,7 @@ st_lsm6dsx_shub_read(struct st_lsm6dsx_sensor *sensor, u8 addr, sizeof(config)); } -/** +/* * st_lsm6dsx_shub_write - write data to slave device register * * Write data from slave device register. SLV0 is used for From patchwork Fri Jul 17 16:55:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670731 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3F7D513B6 for ; Fri, 17 Jul 2020 16:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26E3B2076D for ; Fri, 17 Jul 2020 16:56:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ivqSuFwJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728001AbgGQQ4c (ORCPT ); Fri, 17 Jul 2020 12:56:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727990AbgGQQ4c (ORCPT ); Fri, 17 Jul 2020 12:56:32 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1F80C0619D5 for ; Fri, 17 Jul 2020 09:56:31 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f139so18223358wmf.5 for ; Fri, 17 Jul 2020 09:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SjCKbpOQYkAjrdgAsqIA/xWvJJA5FtP0GGnZ8k9FnTs=; b=ivqSuFwJF4H6NAcbUhesIqowLDzidp+Q6Cgsz6IjVOhNdsxaKBhzss9ugyry3dFrG9 fQBBBXEoej+fOoDSGBnxdVz4CD13TQB1T+4cVVZGFzQvWpki0ODmu5u0v8v0yt+41hPZ 1mXsEez3J1Iat433csy4cV4yJDHoaj+RVbK7fHmvFa9nVwOztrPrIJZkY9DI5PaTo8D+ YuZFDeHGjalJQa0UxKX6Ael4XD7z+KkPZCYKNEMG+IzrADbDZHezMpzqZroHmMKs3PyT 9PQIrqjsIt04NXtb0AP3+bwWH7ZWRo98fJpOTcrHezrFH14KJOj3pX+9SuOaq0LtKqnf eTGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SjCKbpOQYkAjrdgAsqIA/xWvJJA5FtP0GGnZ8k9FnTs=; b=UwI4ia9X2GNQkSPoXhiAvMcTNMYIbi5t9gmWO2//XMF8b+ZfA2C0skBvLbAryP1De2 UhLmtcyH3gv3DkE2prZqx4gCv6euMpcel7dEnEpTvQbtnK5V/WBHI1oq2gUzD3WfWs3c nTgl6cL5lBat8+HbSlriw68wUN+AxDnpzrP9+DPPt9FQ2c1GlE9kQgQTzGEEepuxKRwc Dv0z4+LiPHh9ji33APnD4G78kPNRY8TcXNZ4Ub9nsHMpbrLDxt1VdnqFJrP4zTd3ifFh KTQaq8n7pAKVGOzHbkHrzaiSJquPBnse4G9EVDyx6q9rlmWzl3YW9BOHFVTgRyG1dLKq 5tUw== X-Gm-Message-State: AOAM533HZuYDodgtcbHK9Zx4e++5LKtFwPey5h5ZG+XrW6M6GAqbIwJG w+3tQGwRmNjPicm+a+Cp8mlv1A== X-Google-Smtp-Source: ABdhPJwW9dW090U2vHUzNPUpV1Mt8bRTkM26NfT0oEOck47f5YKRu8EkwGOvWNvxyd4IU6KLo0tJVw== X-Received: by 2002:a1c:6805:: with SMTP id d5mr9938456wmc.19.1595004990415; Fri, 17 Jul 2020 09:56:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:29 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Lorenzo Bianconi , Denis Ciocca Subject: [PATCH 29/30] iio: imu: st_lsm6dsx: st_lsm6dsx: Mark 'st_lsm6dsx_accel_ext_info' as __maybe_unused Date: Fri, 17 Jul 2020 17:55:37 +0100 Message-Id: <20200717165538.3275050-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org It doesn't make sense to move it into '*core*' as it's co-located with other, similar definitions which are used in multiple locations. Fixes the following W=1 kernel build warning(s): In file included from drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c:17: drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:497:44: warning: ‘st_lsm6dsx_accel_ext_info’ defined but not used [-Wunused-const-variable=] 497 | static const struct iio_chan_spec_ext_info st_lsm6dsx_accel_ext_info[] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c:17: drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:497:44: warning: ‘st_lsm6dsx_accel_ext_info’ defined but not used [-Wunused-const-variable=] 497 | static const struct iio_chan_spec_ext_info st_lsm6dsx_accel_ext_info[] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c:16: drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:497:44: warning: ‘st_lsm6dsx_accel_ext_info’ defined but not used [-Wunused-const-variable=] 497 | static const struct iio_chan_spec_ext_info st_lsm6dsx_accel_ext_info[] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Lorenzo Bianconi Cc: Denis Ciocca Signed-off-by: Lee Jones --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h index 3e47a9287938b..d82ec6398222f 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h @@ -494,7 +494,8 @@ st_lsm6dsx_get_mount_matrix(const struct iio_dev *iio_dev, return &hw->orientation; } -static const struct iio_chan_spec_ext_info st_lsm6dsx_accel_ext_info[] = { +static const +struct iio_chan_spec_ext_info __maybe_unused st_lsm6dsx_accel_ext_info[] = { IIO_MOUNT_MATRIX(IIO_SHARED_BY_ALL, st_lsm6dsx_get_mount_matrix), { } }; From patchwork Fri Jul 17 16:55:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670729 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 92A6613B6 for ; Fri, 17 Jul 2020 16:56:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79A0C2074B for ; Fri, 17 Jul 2020 16:56:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eK0lGRU9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728044AbgGQQ4t (ORCPT ); Fri, 17 Jul 2020 12:56:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728022AbgGQQ4d (ORCPT ); Fri, 17 Jul 2020 12:56:33 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 662C4C0619D3 for ; Fri, 17 Jul 2020 09:56:33 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id 17so18215409wmo.1 for ; Fri, 17 Jul 2020 09:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6yWYvMcU6Zb1q02j95UBx70RfKm9AF439nSQ0EKZmBU=; b=eK0lGRU9nKtV3NbUA7v6qAxbF/r+JqwBn5w+uhOSIKVyBDS6uUAhaItyocCUBuO3w9 K3dXkDZbzXDQWz9zAmZ9K5LS7Q+TnCVBhWCyuRiXuBWSF7KlWna2JZhd6dLdkXNx1v61 JUGTWEaw5BbJWcvbGO6CyTrSS1oYFEdCoc6fSXNBmzD7owmfFFC+aP9+srt0wApjxmpe YC0pxYT4HMA5Ic42xYDYIzx9s8UZjVxofxaiibycQHBJc9mzyIHLoekM1Pljpxjan48S aunPIDfnDB43VHl0azBwEscG1g2rrd0iftZ+Ux+p7zcdzzHnd/kxkFZ91JYJOI5WOxkK NLvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6yWYvMcU6Zb1q02j95UBx70RfKm9AF439nSQ0EKZmBU=; b=IjO6Yf+QEiVvLycK94Q2Xv/sYCxWQc28VhZ5jcrcfHDuFR9qwrOi8JibKi5XFvm7xr /FVo23VVxZR1DKGdhD3hQ84An2IZfOVlZcQeSTTLv5cMtxLG9t2OGcESDFD7IoGnHaEQ 3rKg0CCQXSlkns7aIlxq1KGCkigH1SYe/RNf2pJO3Pi7aUDUNE48KVDSiBulZ0prxIhO uptm/5hE1Uc9BpAueTUSNcLIXhGbvm7HwaVMahs3QYbnJvBVM5OZIq0z4K/nrJFsiN1M MwMv3Zj19Be39u1IG04+7I6miycHYPsEPG3/PtTcBImCT6V3gIQW8YEjSZUFx4S8IU5N NArA== X-Gm-Message-State: AOAM530sys6Zt6LfzwcwGX08uZAMwFm6W2dbNnMfM1ED3oq8MiaZyFf3 d6Drpi74KgMxlGJHtcNDJZuUyA== X-Google-Smtp-Source: ABdhPJzLb21jyV+I6Qu3YiGgdMcprDQRVbpNQ8nybgXlwGOQm+2UWGyQWhaS+LfhbyooqiIsfrvC2A== X-Received: by 2002:a1c:ab56:: with SMTP id u83mr9936549wme.94.1595004991500; Fri, 17 Jul 2020 09:56:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id k4sm14941516wrp.86.2020.07.17.09.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 09:56:31 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lee Jones , Heiko Stuebner , Philipp Zabel , linux-rockchip@lists.infradead.org Subject: [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote seemingly unintentional kerneldoc header Date: Fri, 17 Jul 2020 17:55:38 +0100 Message-Id: <20200717165538.3275050-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717165538.3275050-1-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This is the only use of kerneldoc in the source file and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller' Cc: Heiko Stuebner Cc: Philipp Zabel Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones Reviewed-by: Heiko Stuebner --- drivers/iio/adc/rockchip_saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c index 582ba047c4a67..cf4ec59c1dab0 100644 --- a/drivers/iio/adc/rockchip_saradc.c +++ b/drivers/iio/adc/rockchip_saradc.c @@ -183,7 +183,7 @@ static const struct of_device_id rockchip_saradc_match[] = { }; MODULE_DEVICE_TABLE(of, rockchip_saradc_match); -/** +/* * Reset SARADC Controller. */ static void rockchip_saradc_reset_controller(struct reset_control *reset)